| *** gahan has quit IRC | 00:04 | |
| *** yangyapeng has quit IRC | 00:07 | |
| *** ddieterly has joined #openstack-freezer | 00:17 | |
| *** ddieterly has quit IRC | 00:35 | |
| *** ddieterly has joined #openstack-freezer | 00:59 | |
| *** iceyao has joined #openstack-freezer | 01:07 | |
| *** yangyapeng has joined #openstack-freezer | 01:15 | |
| *** ddieterly has quit IRC | 01:15 | |
| yangyapeng | jonaspf: ping | 01:29 |
|---|---|---|
| yangyapeng | ping jonaspf | 01:29 |
| *** EinstCrazy has joined #openstack-freezer | 01:38 | |
| *** ddieterly has joined #openstack-freezer | 01:57 | |
| *** ddieterly is now known as ddieterly[away] | 01:57 | |
| *** ddieterly[away] is now known as ddieterly | 01:57 | |
| *** ddieterly has quit IRC | 02:12 | |
| *** ddieterly has joined #openstack-freezer | 02:20 | |
| *** EinstCrazy has quit IRC | 02:25 | |
| *** yangyape_ has joined #openstack-freezer | 02:28 | |
| *** yangyape_ has quit IRC | 02:28 | |
| *** EinstCrazy has joined #openstack-freezer | 02:28 | |
| *** EinstCrazy has quit IRC | 02:29 | |
| *** yangyapeng has quit IRC | 02:31 | |
| *** EinstCrazy has joined #openstack-freezer | 02:31 | |
| *** yangyapeng has joined #openstack-freezer | 02:32 | |
| *** EinstCrazy has quit IRC | 02:33 | |
| *** iceyao has quit IRC | 02:34 | |
| *** iceyao has joined #openstack-freezer | 02:35 | |
| *** ddieterly has quit IRC | 02:35 | |
| *** ddieterly has joined #openstack-freezer | 02:35 | |
| *** ddieterly has quit IRC | 02:35 | |
| *** EinstCra_ has joined #openstack-freezer | 02:36 | |
| *** yangyape_ has joined #openstack-freezer | 02:39 | |
| *** yangyapeng has quit IRC | 02:42 | |
| *** EinstCra_ has quit IRC | 02:42 | |
| *** EinstCrazy has joined #openstack-freezer | 02:43 | |
| *** iceyao has quit IRC | 03:10 | |
| *** iceyao has joined #openstack-freezer | 03:11 | |
| *** iceyao_ has joined #openstack-freezer | 03:12 | |
| *** iceyao has quit IRC | 03:16 | |
| *** EinstCrazy has quit IRC | 03:47 | |
| *** EinstCrazy has joined #openstack-freezer | 03:47 | |
| *** EinstCrazy has quit IRC | 03:55 | |
| *** iceyao_ has quit IRC | 03:56 | |
| *** iceyao has joined #openstack-freezer | 03:57 | |
| *** yangyape_ has quit IRC | 04:39 | |
| *** EinstCra_ has joined #openstack-freezer | 04:44 | |
| *** yangyapeng has joined #openstack-freezer | 04:45 | |
| *** lpetrut has joined #openstack-freezer | 04:59 | |
| *** EinstCra_ has quit IRC | 05:36 | |
| *** EinstCrazy has joined #openstack-freezer | 05:36 | |
| *** yangyapeng has quit IRC | 05:38 | |
| *** yangyape_ has joined #openstack-freezer | 05:38 | |
| *** EinstCrazy has quit IRC | 05:45 | |
| *** EinstCrazy has joined #openstack-freezer | 05:45 | |
| *** iceyao_ has joined #openstack-freezer | 05:48 | |
| *** iceyao has quit IRC | 05:50 | |
| *** openstackgerrit has quit IRC | 06:18 | |
| *** openstackgerrit has joined #openstack-freezer | 06:19 | |
| *** lpetrut has quit IRC | 06:29 | |
| *** lpetrut has joined #openstack-freezer | 06:42 | |
| *** EinstCrazy has quit IRC | 06:50 | |
| *** EinstCrazy has joined #openstack-freezer | 06:50 | |
| *** yuval has joined #openstack-freezer | 06:53 | |
| *** EinstCrazy has quit IRC | 06:55 | |
| *** EinstCrazy has joined #openstack-freezer | 06:58 | |
| openstackgerrit | yapeng Yang proposed openstack/freezer: Change cinder backup to define full backup or incremental backup https://review.openstack.org/329359 | 07:07 |
| *** lpetrut has quit IRC | 07:07 | |
| *** EinstCrazy has quit IRC | 07:10 | |
| *** yangyapeng has joined #openstack-freezer | 07:12 | |
| *** yangyape_ has quit IRC | 07:13 | |
| *** EinstCrazy has joined #openstack-freezer | 07:13 | |
| *** iceyao_ has quit IRC | 07:13 | |
| *** iceyao__ has joined #openstack-freezer | 07:13 | |
| *** EinstCrazy has quit IRC | 07:16 | |
| *** EinstCrazy has joined #openstack-freezer | 07:17 | |
| *** lpetrut has joined #openstack-freezer | 07:18 | |
| *** sxc731 has joined #openstack-freezer | 07:19 | |
| *** sxc731 has quit IRC | 07:19 | |
| *** lpetrut has quit IRC | 07:26 | |
| *** openstackgerrit has quit IRC | 07:33 | |
| *** openstackgerrit has joined #openstack-freezer | 07:34 | |
| *** EinstCrazy has quit IRC | 07:36 | |
| *** EinstCrazy has joined #openstack-freezer | 07:37 | |
| *** EinstCrazy has quit IRC | 07:52 | |
| *** EinstCrazy has joined #openstack-freezer | 07:52 | |
| *** EinstCrazy has quit IRC | 07:57 | |
| *** EinstCrazy has joined #openstack-freezer | 08:00 | |
| *** EinstCrazy has quit IRC | 08:47 | |
| *** EinstCrazy has joined #openstack-freezer | 08:48 | |
| *** EinstCrazy has quit IRC | 08:50 | |
| *** EinstCrazy has joined #openstack-freezer | 08:50 | |
| *** electrofelix has joined #openstack-freezer | 08:59 | |
| *** EinstCrazy has quit IRC | 09:23 | |
| *** EinstCrazy has joined #openstack-freezer | 09:24 | |
| *** EinstCrazy has quit IRC | 09:28 | |
| *** lpetrut has joined #openstack-freezer | 09:28 | |
| *** EinstCrazy has joined #openstack-freezer | 09:30 | |
| *** EinstCrazy has quit IRC | 09:38 | |
| *** EinstCrazy has joined #openstack-freezer | 09:39 | |
| *** EinstCrazy has quit IRC | 09:44 | |
| *** yangyapeng has quit IRC | 09:44 | |
| *** yangyapeng has joined #openstack-freezer | 09:44 | |
| *** EinstCrazy has joined #openstack-freezer | 09:57 | |
| *** EinstCrazy has quit IRC | 09:58 | |
| *** EinstCrazy has joined #openstack-freezer | 09:58 | |
| *** iceyao__ has quit IRC | 10:06 | |
| *** domhnallw has joined #openstack-freezer | 10:29 | |
| m3m0 | jmarianu: hey are you here? | 10:31 |
| *** EinstCrazy has quit IRC | 11:07 | |
| *** EinstCrazy has joined #openstack-freezer | 11:07 | |
| szaher | jmarianu: Hi. It seems like we are in different time zones | 11:22 |
| *** ddieterly has joined #openstack-freezer | 11:45 | |
| ddieterly | could we get these pushed thru? we almost had them merged yesterday. https://review.openstack.org/#/c/327241/ https://review.openstack.org/#/c/327914/ | 11:56 |
| m3m0 | ddieterly: done | 12:05 |
| ddieterly | m3m0 thanks | 12:06 |
| ddieterly | still need workflow approval for https://review.openstack.org/#/c/327914/11 | 12:08 |
| *** ddieterly is now known as ddieterly[away] | 12:08 | |
| *** lpetrut has quit IRC | 12:11 | |
| *** lpetrut has joined #openstack-freezer | 12:15 | |
| *** daemontool has joined #openstack-freezer | 12:16 | |
| openstackgerrit | Merged openstack/freezer: Improve Tempest tests https://review.openstack.org/327241 | 12:18 |
| *** ddieterly[away] is now known as ddieterly | 12:27 | |
| ddieterly | jonaspf slashme could either of you +A https://review.openstack.org/#/c/327914/11? | 12:29 |
| *** ddieterly has quit IRC | 12:35 | |
| *** Marcellin has joined #openstack-freezer | 12:56 | |
| *** sxc731 has joined #openstack-freezer | 13:09 | |
| *** sxc731 has left #openstack-freezer | 13:10 | |
| openstackgerrit | Memo Garcia proposed openstack/freezer-api: Added oslo.middleware in requirements.txt https://review.openstack.org/329917 | 13:12 |
| *** ddieterly has joined #openstack-freezer | 13:16 | |
| openstackgerrit | Merged openstack/freezer: Fix gnu tar error handling https://review.openstack.org/327914 | 13:18 |
| *** ddieterly is now known as ddieterly[away] | 13:39 | |
| *** iceyao has joined #openstack-freezer | 13:46 | |
| *** ddieterly[away] is now known as ddieterly | 13:46 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/freezer: Updated from global requirements https://review.openstack.org/315055 | 13:57 |
| *** ddieterly is now known as ddieterly[away] | 14:11 | |
| openstackgerrit | Jonas Pfannschmidt proposed openstack/freezer: First scenario test https://review.openstack.org/320591 | 14:16 |
| *** ddieterly[away] is now known as ddieterly | 14:19 | |
| openstackgerrit | Merged openstack/freezer: New Better & Well Formatted Docs with Sphinx https://review.openstack.org/296448 | 14:38 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/freezer: Updated from global requirements https://review.openstack.org/315055 | 14:44 |
| *** yuval has quit IRC | 14:45 | |
| timothyb89 | hi all, I'm working on https://launchpad.net/bugs/1592046 and I was wonder if anyone could confirm the intended behavior for the limit and offset parameters in freezer-api? | 14:59 |
| openstack | Launchpad bug 1592046 in Freezer "GET requests to the Freezer API with negative offset, limit values fail" [Undecided,In progress] - Assigned to Tim Buckley (timothy-jas-buckley) | 14:59 |
| timothyb89 | I have a preliminary patch up here: https://review.openstack.org/#/c/329671/ | 15:00 |
| timothyb89 | my assumption so far is that a limit or offset < 0 should raise an error, == 0 is ignored, and when > 0 is fine ... are these safe assumptions to make? | 15:01 |
| m3m0 | your assumption is correct, we should raise on invalid parameters | 15:03 |
| m3m0 | your patch looks ok to me :) | 15:04 |
| m3m0 | timothyb89 ^^ | 15:04 |
| timothyb89 | good to know, thanks! | 15:04 |
| m3m0 | your tempest patch looks good as well :) | 15:05 |
| m3m0 | I'm reviewing at the moment | 15:05 |
| timothyb89 | good to hear :) | 15:06 |
| *** yangyapeng has quit IRC | 15:19 | |
| *** EinstCrazy has quit IRC | 15:19 | |
| jonaspf | Could someone review https://review.openstack.org/#/c/320591/ ? | 15:26 |
| *** sxc731 has joined #openstack-freezer | 15:27 | |
| *** ddieterly is now known as ddieterly[away] | 15:39 | |
| m3m0 | 901017 | 15:40 |
| *** jmarianu has quit IRC | 15:41 | |
| *** jmarianu has joined #openstack-freezer | 15:44 | |
| domhnallw | timothyb89, I logged that bug - non-integer negative values are already rejected, and for some reason Elastic Search is okay with -1 (maybe it's a placeholder value for "all" or "none" or similar?) | 15:48 |
| domhnallw | (https://launchpad.net/bugs/1592046 that is) | 15:48 |
| openstack | Launchpad bug 1592046 in Freezer "GET requests to the Freezer API with negative offset, limit values fail" [Undecided,In progress] - Assigned to Tim Buckley (timothy-jas-buckley) | 15:48 |
| *** ddieterly[away] is now known as ddieterly | 15:49 | |
| domhnallw | It only seems to get upset when the values is a negative integer of -2 or less. | 15:49 |
| timothyb89 | domhnallw: I noticed that too, elasticsearch seems to have some odd behavior with both 0 and -1 | 15:49 |
| domhnallw | Well, offset=0 is fine, limit=0... well, who knows. | 15:49 |
| timothyb89 | domhnallw: size=0 (which a query param of limit=0 sets) seems to return all results, and I haven't got a clue with -1 does | 15:50 |
| domhnallw | I don't know either, but it doesn't fail :) | 15:50 |
| timothyb89 | right, so I guess that's my question... should we still consider that invalid on our end? | 15:50 |
| timothyb89 | (that's what I did in this patch) | 15:50 |
| domhnallw | I'd personally be of the opinion that if you don't want an offset or a limit, you don't specify them. | 15:51 |
| domhnallw | If you do, then they should be sensible. | 15:51 |
| domhnallw | So offset >= 0, limit >= 1? | 15:52 |
| domhnallw | m3m0, what do you think? | 15:52 |
| timothyb89 | that's my feeling as well, though I don't have it raising an error on limit=0 yet (but I agree that it probably should) | 15:52 |
| m3m0 | limit should be >=0 | 15:55 |
| domhnallw | If it returns an empty data set if nothing matches, then limit=0 should be illegal. If it returns a 404 instead, then it's fine (because then you could use the HTTP status code to determine the presence (or not) of data) | 15:55 |
| m3m0 | for limit, does 0 and -1 have different behaviours? | 15:56 |
| m3m0 | for offset, 0 is the one used | 15:56 |
| domhnallw | Okay then? | 15:57 |
| timothyb89 | limit=0 seems to return all results | 15:58 |
| timothyb89 | limit=-1 returns an empty set but no error? | 15:58 |
| domhnallw | So there you go. limit=-1 then you check the HTTP status code to see if there's data or not. limit=0 returns everything. Both have their uses. | 15:59 |
| domhnallw | What do you think? | 15:59 |
| timothyb89 | ah, so you're saying limit=-1 should conditionally throw an error if no data exists to be found but otherwise return an empty set? | 16:02 |
| *** lpetrut has quit IRC | 16:15 | |
| *** ddieterly is now known as ddieterly[away] | 16:16 | |
| *** yangyapeng has joined #openstack-freezer | 16:19 | |
| *** EinstCrazy has joined #openstack-freezer | 16:20 | |
| *** ddieterly[away] is now known as ddieterly | 16:21 | |
| *** EinstCrazy has quit IRC | 16:25 | |
| *** sxc731 has quit IRC | 16:27 | |
| *** ddieterly is now known as ddieterly[away] | 16:47 | |
| *** yangyapeng has quit IRC | 16:53 | |
| *** lpetrut has joined #openstack-freezer | 17:05 | |
| *** lpetrut has quit IRC | 17:05 | |
| *** lpetrut has joined #openstack-freezer | 17:06 | |
| *** ddieterly[away] is now known as ddieterly | 17:08 | |
| openstackgerrit | Tim Buckley proposed openstack/freezer: Add Tempest tests to validate checksum usage https://review.openstack.org/329113 | 17:15 |
| *** electrofelix has quit IRC | 17:34 | |
| *** iceyao has quit IRC | 17:34 | |
| *** ddieterly is now known as ddieterly[away] | 17:41 | |
| *** daemontool has quit IRC | 17:59 | |
| *** EinstCrazy has joined #openstack-freezer | 18:22 | |
| *** EinstCrazy has quit IRC | 18:27 | |
| *** ddieterly[away] has quit IRC | 18:43 | |
| *** ddieterly has joined #openstack-freezer | 18:44 | |
| *** yangyapeng has joined #openstack-freezer | 18:50 | |
| *** yangyapeng has quit IRC | 18:55 | |
| *** lpetrut has quit IRC | 19:02 | |
| *** lpetrut has joined #openstack-freezer | 19:30 | |
| *** ddieterly has quit IRC | 19:31 | |
| *** openstackgerrit has quit IRC | 19:33 | |
| *** openstackgerrit has joined #openstack-freezer | 19:34 | |
| *** EinstCrazy has joined #openstack-freezer | 19:57 | |
| *** jmarianu has quit IRC | 19:59 | |
| *** jmarianu has joined #openstack-freezer | 20:00 | |
| *** EinstCrazy has quit IRC | 20:02 | |
| *** lpetrut has quit IRC | 21:32 | |
| *** EinstCrazy has joined #openstack-freezer | 22:02 | |
| *** openstackgerrit has quit IRC | 22:02 | |
| *** openstackgerrit has joined #openstack-freezer | 22:06 | |
| *** EinstCrazy has quit IRC | 22:07 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!