*** yangyapeng has quit IRC | 00:11 | |
*** ddieterly has joined #openstack-freezer | 00:24 | |
*** ddieterly has quit IRC | 00:41 | |
*** iceyao has joined #openstack-freezer | 01:04 | |
*** zhurong has joined #openstack-freezer | 01:12 | |
*** yangyapeng has joined #openstack-freezer | 01:19 | |
*** EinstCrazy has joined #openstack-freezer | 01:22 | |
*** ddieterly has joined #openstack-freezer | 01:38 | |
*** zhurong has quit IRC | 01:40 | |
*** zhurong has joined #openstack-freezer | 01:41 | |
*** ddieterly has quit IRC | 01:43 | |
*** ddieterly has joined #openstack-freezer | 01:57 | |
*** EinstCra_ has joined #openstack-freezer | 02:02 | |
*** EinstCrazy has quit IRC | 02:05 | |
*** EinstCra_ has quit IRC | 02:23 | |
*** EinstCrazy has joined #openstack-freezer | 02:24 | |
*** ddieterly has quit IRC | 02:29 | |
*** M00nr41n has joined #openstack-freezer | 03:47 | |
*** M00nr41n has quit IRC | 03:51 | |
*** M00nr41n has joined #openstack-freezer | 03:53 | |
*** zhurong has quit IRC | 04:03 | |
*** M00nr41n has quit IRC | 04:04 | |
*** M00nr41n has joined #openstack-freezer | 04:06 | |
*** zhurong has joined #openstack-freezer | 04:13 | |
*** EinstCrazy has quit IRC | 04:50 | |
*** EinstCrazy has joined #openstack-freezer | 04:50 | |
*** zhurong has quit IRC | 04:58 | |
*** M00nr41n has quit IRC | 04:58 | |
*** zhurong has joined #openstack-freezer | 05:00 | |
openstackgerrit | yapeng Yang proposed openstack/freezer: Remove unnecessary executable permissions https://review.openstack.org/320250 | 05:17 |
---|---|---|
*** lpetrut has joined #openstack-freezer | 05:22 | |
*** EinstCra_ has joined #openstack-freezer | 05:32 | |
*** EinstCrazy has quit IRC | 05:35 | |
*** zhurong has quit IRC | 05:43 | |
*** zhurong has joined #openstack-freezer | 05:48 | |
*** M00nr41n has joined #openstack-freezer | 05:53 | |
*** fawadkhaliq has joined #openstack-freezer | 06:03 | |
*** fawadkhaliq has quit IRC | 06:09 | |
*** EinstCra_ has quit IRC | 06:10 | |
*** fawadkhaliq has joined #openstack-freezer | 06:10 | |
*** EinstCrazy has joined #openstack-freezer | 06:16 | |
*** zhangjn has quit IRC | 06:19 | |
*** zhangjn has joined #openstack-freezer | 06:24 | |
*** lpetrut has quit IRC | 06:24 | |
*** zhurong has quit IRC | 06:41 | |
*** zhurong has joined #openstack-freezer | 06:44 | |
*** sxc731 has joined #openstack-freezer | 07:01 | |
*** openstackgerrit has quit IRC | 07:33 | |
*** popawu has quit IRC | 07:33 | |
*** openstackgerrit has joined #openstack-freezer | 07:34 | |
*** fawadkhaliq has quit IRC | 07:44 | |
*** sxc731 has left #openstack-freezer | 07:57 | |
*** openstackgerrit has quit IRC | 08:18 | |
*** openstackgerrit has joined #openstack-freezer | 08:19 | |
*** electrofelix has joined #openstack-freezer | 09:00 | |
*** lpetrut has joined #openstack-freezer | 09:07 | |
*** EinstCra_ has joined #openstack-freezer | 09:09 | |
*** EinstCrazy has quit IRC | 09:13 | |
*** fawadkhaliq has joined #openstack-freezer | 09:30 | |
*** fawadkhaliq has quit IRC | 09:30 | |
*** EinstCra_ has quit IRC | 09:38 | |
*** EinstCrazy has joined #openstack-freezer | 09:38 | |
*** fawadkhaliq has joined #openstack-freezer | 09:46 | |
*** zengchen has quit IRC | 09:58 | |
*** EinstCrazy has quit IRC | 10:01 | |
*** yangyapeng has quit IRC | 10:01 | |
*** sxc731 has joined #openstack-freezer | 10:03 | |
*** sxc731 has left #openstack-freezer | 10:04 | |
*** zhurong has quit IRC | 10:17 | |
*** fawadkhaliq has quit IRC | 10:22 | |
*** fawadkhaliq has joined #openstack-freezer | 10:23 | |
*** yangyapeng has joined #openstack-freezer | 10:23 | |
openstackgerrit | Domhnall Walsh proposed openstack/freezer-api: Middleware loading now works for falcon >= 0.1.6 https://review.openstack.org/334920 | 10:24 |
openstackgerrit | Domhnall Walsh proposed openstack/freezer-api: Fix Middleware loading for falcon >= 0.1.6 https://review.openstack.org/334920 | 10:27 |
*** lpetrut has quit IRC | 10:27 | |
*** yangyapeng has quit IRC | 10:27 | |
jokke_ | domhnallw: around? | 10:28 |
*** fawadkhaliq has quit IRC | 10:28 | |
*** iceyao_ has joined #openstack-freezer | 10:28 | |
*** iceyao_ has quit IRC | 10:29 | |
*** fawadkhaliq has joined #openstack-freezer | 10:29 | |
*** iceyao has quit IRC | 10:32 | |
*** fawadkhaliq has quit IRC | 10:35 | |
*** fawadkhaliq has joined #openstack-freezer | 10:37 | |
*** fawadkhaliq has quit IRC | 10:40 | |
domhnallw | Hey, yep. | 10:40 |
domhnallw | Hi jokke_ | 10:40 |
*** fawadkhaliq has joined #openstack-freezer | 10:40 | |
*** fawadk has joined #openstack-freezer | 10:46 | |
*** fawadkhaliq has quit IRC | 10:47 | |
*** fawadk has quit IRC | 10:47 | |
*** fawadkhaliq has joined #openstack-freezer | 10:47 | |
*** fawadk has joined #openstack-freezer | 10:52 | |
*** fawadkhaliq has quit IRC | 10:52 | |
*** fawadkhaliq has joined #openstack-freezer | 10:58 | |
jokke_ | hey | 10:59 |
jokke_ | was looking the falcon change | 10:59 |
*** fawadk has quit IRC | 10:59 | |
jokke_ | is there change in behavior on the req.get_header between versions? | 11:00 |
jokke_ | domhnallw: ^^ | 11:00 |
jokke_ | iiuc the who try: except: block is built in to the default behavior of the get_header if not specifically defined required | 11:01 |
*** fawadkhaliq has quit IRC | 11:05 | |
*** fawadkhaliq has joined #openstack-freezer | 11:05 | |
*** fawadk has joined #openstack-freezer | 11:07 | |
*** fawadkhaliq has quit IRC | 11:08 | |
domhnallw | Hey. | 11:09 |
domhnallw | Basically, get_header returns (None,) if the header isn't set, otherwise you can ask it to throw an exception. | 11:09 |
domhnallw | get_header() appears to be consistent across all versions. | 11:10 |
*** fawadkhaliq has joined #openstack-freezer | 11:11 | |
domhnallw | http://falcon.readthedocs.io/en/stable/api/request_and_response.html#falcon.Request.get_header | 11:11 |
*** fawadk has quit IRC | 11:12 | |
*** fawadkhaliq has quit IRC | 11:12 | |
domhnallw | The docs say it returns None if the header isn't set but in practice it's returning a tuple containing None. | 11:12 |
domhnallw | That appears to be consistent across all versions. | 11:12 |
*** fawadkhaliq has joined #openstack-freezer | 11:12 | |
domhnallw | I agree that the approach I've taken looks odd. | 11:13 |
domhnallw | If it returned None instead of (None,) it'd be fine. | 11:14 |
jokke_ | yeah | 11:14 |
*** fawadkhaliq has quit IRC | 11:14 | |
*** fawadkhaliq has joined #openstack-freezer | 11:15 | |
domhnallw | If you think that testing to see if it looks *like* None is better, I can do that? | 11:16 |
*** electrofelix has quit IRC | 11:17 | |
*** fawadkhaliq has quit IRC | 11:18 | |
*** fawadkhaliq has joined #openstack-freezer | 11:18 | |
*** electrofelix has joined #openstack-freezer | 11:22 | |
*** fawadk has joined #openstack-freezer | 11:23 | |
*** fawadkhaliq has quit IRC | 11:23 | |
domhnallw | FYI am double-checking to absolutely confirm how I arrived at the conclusion it was misbehaving. | 11:24 |
domhnallw | (i.e. returning (None,) | 11:24 |
*** fawadk has quit IRC | 11:26 | |
*** fawadkhaliq has joined #openstack-freezer | 11:26 | |
domhnallw | Weird, I can't seem to replicate it. It's passed for 0.1.6, 0.2.0 and 1.0.0 and is in the process of passing for 0.3.0. | 11:30 |
*** fawadkhaliq has quit IRC | 11:31 | |
*** fawadkhaliq has joined #openstack-freezer | 11:31 | |
domhnallw | Okay, I'm ripping that try catch block out. | 11:31 |
domhnallw | Any other stuff that looks odd/weird/wrong? | 11:31 |
openstackgerrit | Domhnall Walsh proposed openstack/freezer-api: Fix Middleware loading for falcon >= 0.1.6 https://review.openstack.org/334920 | 11:32 |
domhnallw | Have to run to lunch before the queue gets insane. Back in a bit :) | 11:33 |
jokke_ | the rest there looks good ... that was just weird ;) | 11:36 |
*** fawadkhaliq has quit IRC | 11:37 | |
*** fawadkhaliq has joined #openstack-freezer | 11:37 | |
*** fawadkhaliq has quit IRC | 11:39 | |
*** fawadkhaliq has joined #openstack-freezer | 11:39 | |
*** fawadkhaliq has quit IRC | 11:42 | |
*** fawadkhaliq has joined #openstack-freezer | 11:42 | |
*** fawadk has joined #openstack-freezer | 11:46 | |
*** fawadkhaliq has quit IRC | 11:46 | |
*** fawadk has quit IRC | 11:48 | |
*** fawadkhaliq has joined #openstack-freezer | 11:48 | |
*** ddieterly has joined #openstack-freezer | 11:48 | |
*** fawadkhaliq has quit IRC | 11:50 | |
*** fawadkhaliq has joined #openstack-freezer | 11:50 | |
*** fawadkhaliq has quit IRC | 11:58 | |
*** fawadk has joined #openstack-freezer | 11:58 | |
*** fawadkhaliq has joined #openstack-freezer | 12:03 | |
*** fawadk has quit IRC | 12:04 | |
*** ddieterly has quit IRC | 12:07 | |
*** fawadkhaliq has quit IRC | 12:07 | |
*** fawadkhaliq has joined #openstack-freezer | 12:08 | |
openstackgerrit | Domhnall Walsh proposed openstack/freezer-api: Fix Middleware loading for falcon >= 0.1.6 https://review.openstack.org/334920 | 12:11 |
domhnallw | ^^^ removes an unneeded import I just spotted, otherwise the same. | 12:11 |
*** fawadk has joined #openstack-freezer | 12:13 | |
*** fawadkhaliq has quit IRC | 12:14 | |
*** fawadkhaliq has joined #openstack-freezer | 12:18 | |
*** fawadkhaliq has quit IRC | 12:18 | |
*** fawadk has quit IRC | 12:20 | |
*** lpetrut has joined #openstack-freezer | 12:22 | |
*** ddieterly has joined #openstack-freezer | 12:24 | |
*** fawadkhaliq has joined #openstack-freezer | 12:25 | |
*** ddieterly has quit IRC | 12:29 | |
*** fawadkhaliq has quit IRC | 12:30 | |
*** ddieterly has joined #openstack-freezer | 12:46 | |
*** ddieterly has quit IRC | 12:56 | |
*** M00nr41n has quit IRC | 13:14 | |
*** ddieterly has joined #openstack-freezer | 13:30 | |
*** ddieterly is now known as ddieterly[away] | 13:30 | |
*** iceyao has joined #openstack-freezer | 13:38 | |
*** ddieterly[away] is now known as ddieterly | 13:39 | |
*** daemontool has joined #openstack-freezer | 13:43 | |
*** yangyapeng has joined #openstack-freezer | 13:54 | |
*** sxc731 has joined #openstack-freezer | 13:59 | |
*** sxc731 has left #openstack-freezer | 13:59 | |
*** EinstCrazy has joined #openstack-freezer | 14:01 | |
*** zhangjn has quit IRC | 14:02 | |
*** iceyao has quit IRC | 14:02 | |
*** zhangjn has joined #openstack-freezer | 14:04 | |
*** EinstCrazy has quit IRC | 14:04 | |
*** iceyao has joined #openstack-freezer | 14:07 | |
*** daemontool has quit IRC | 14:12 | |
*** EinstCrazy has joined #openstack-freezer | 14:14 | |
*** daemontool has joined #openstack-freezer | 14:14 | |
openstackgerrit | Domhnall Walsh proposed openstack/freezer-api: Fix Middleware loading for falcon >= 0.1.6 https://review.openstack.org/334920 | 14:15 |
*** M00nr41n has joined #openstack-freezer | 14:28 | |
*** zhurong has joined #openstack-freezer | 14:30 | |
*** EinstCrazy has quit IRC | 15:14 | |
*** sxc731 has joined #openstack-freezer | 15:16 | |
*** sxc731 has left #openstack-freezer | 15:17 | |
*** iceyao has quit IRC | 15:24 | |
*** iceyao has joined #openstack-freezer | 15:26 | |
*** daemontool has quit IRC | 15:28 | |
*** Marcellin has joined #openstack-freezer | 15:29 | |
*** M00nr41n has quit IRC | 15:32 | |
*** zhurong has quit IRC | 15:32 | |
*** iceyao has quit IRC | 16:02 | |
*** daemontool has joined #openstack-freezer | 16:31 | |
*** M00nr41n has joined #openstack-freezer | 16:47 | |
*** ddieterly is now known as ddieterly[away] | 16:52 | |
*** ddieterly[away] is now known as ddieterly | 16:58 | |
*** electrofelix has quit IRC | 17:12 | |
*** ddieterly is now known as ddieterly[away] | 17:19 | |
*** fawadkhaliq has joined #openstack-freezer | 17:35 | |
*** fawadkhaliq has quit IRC | 17:39 | |
*** daemontool has quit IRC | 18:00 | |
*** ddieterly[away] has quit IRC | 18:19 | |
*** lpetrut has quit IRC | 18:22 | |
*** ddieterly has joined #openstack-freezer | 19:09 | |
*** M00nr41n_ has joined #openstack-freezer | 19:42 | |
*** M00nr41n has quit IRC | 19:42 | |
*** lpetrut has joined #openstack-freezer | 19:51 | |
*** ddieterly is now known as ddieterly[away] | 20:03 | |
*** ddieterly[away] is now known as ddieterly | 20:26 | |
*** lpetrut has quit IRC | 21:36 | |
*** ddieterly is now known as ddieterly[away] | 21:49 | |
openstackgerrit | Domhnall Walsh proposed openstack/freezer-api: Fix Middleware loading for falcon >= 0.1.6 https://review.openstack.org/334920 | 21:53 |
*** ddieterly[away] is now known as ddieterly | 22:12 | |
*** ddieterly is now known as ddieterly[away] | 22:55 | |
*** ddieterly[away] has quit IRC | 22:55 | |
openstackgerrit | Domhnall Walsh proposed openstack/freezer-api: Fix Middleware loading for falcon >= 0.1.6 https://review.openstack.org/334920 | 23:11 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!