| *** zhurong has quit IRC | 00:01 | |
| *** yangyapeng has quit IRC | 00:11 | |
| *** zhusz has joined #openstack-freezer | 00:22 | |
| *** StraubTW has quit IRC | 00:27 | |
| *** ddieterly has joined #openstack-freezer | 00:57 | |
| *** ddieterly has quit IRC | 01:06 | |
| *** zhurong has joined #openstack-freezer | 01:11 | |
| *** yangyapeng has joined #openstack-freezer | 01:22 | |
| *** iceyao has joined #openstack-freezer | 01:37 | |
| *** yangyape_ has joined #openstack-freezer | 02:01 | |
| *** yangyapeng has quit IRC | 02:03 | |
| *** c00281451 has joined #openstack-freezer | 02:22 | |
| *** EinstCra_ has joined #openstack-freezer | 02:25 | |
| *** yangyapeng has joined #openstack-freezer | 02:27 | |
| *** yangyape_ has quit IRC | 02:27 | |
| *** EinstCrazy has quit IRC | 02:29 | |
| *** zhusz has quit IRC | 02:42 | |
| *** iceyao_ has joined #openstack-freezer | 02:44 | |
| *** iceyao has quit IRC | 02:46 | |
| *** yangyape_ has joined #openstack-freezer | 02:58 | |
| *** yangyapeng has quit IRC | 02:58 | |
| *** iceyao has joined #openstack-freezer | 03:15 | |
| *** StraubTW has joined #openstack-freezer | 03:17 | |
| *** EinstCra_ has quit IRC | 03:18 | |
| *** iceyao_ has quit IRC | 03:19 | |
| *** StraubTW has quit IRC | 03:21 | |
| *** EinstCrazy has joined #openstack-freezer | 03:24 | |
| *** clenimar has quit IRC | 03:28 | |
| *** clenimar has joined #openstack-freezer | 03:32 | |
| *** yangyape_ has quit IRC | 03:41 | |
| *** yangyapeng has joined #openstack-freezer | 03:42 | |
| *** clenimar has quit IRC | 04:04 | |
| *** clenimar has joined #openstack-freezer | 04:10 | |
| *** StraubTW has joined #openstack-freezer | 04:17 | |
| *** StraubTW has quit IRC | 04:23 | |
| *** michauds has joined #openstack-freezer | 05:05 | |
| *** lpetrut has joined #openstack-freezer | 05:06 | |
| *** michauds has quit IRC | 05:10 | |
| *** iceyao has quit IRC | 05:28 | |
| *** iceyao has joined #openstack-freezer | 05:32 | |
| *** iceyao has quit IRC | 05:34 | |
| *** EinstCrazy has quit IRC | 05:43 | |
| *** yangyapeng has quit IRC | 05:54 | |
| *** yangyapeng has joined #openstack-freezer | 05:56 | |
| *** lpetrut has quit IRC | 06:16 | |
| athinkingmeat | hi | 06:20 |
|---|---|---|
| *** lpetrut has joined #openstack-freezer | 06:25 | |
| *** lpetrut has quit IRC | 06:45 | |
| yangyapeng | hi athinkingmeat | 07:09 |
| athinkingmeat | any suggestions on how to fix Freezer client error: Critical Error: 'FreezerConfig' object has no attribute 'client_manager' ? :) this started to happen after i've applied refs/changes/91/344691/1 to fix nova import problem | 07:12 |
| yangyapeng | if you install swift? stable/mitaka? | 07:13 |
| yangyapeng | athinkingmeat: | 07:14 |
| athinkingmeat | stable/mitaka . swift is there, but i have set to use local path for backups :D should i work with swift? | 07:15 |
| yangyapeng | https://review.openstack.org/#/c/303701/ athinkingmeat I fix it in master | 07:19 |
| yangyapeng | backup fs to local ? | 07:19 |
| athinkingmeat | yangyapeng: i was trying to do nova to local. | 07:20 |
| yangyapeng | i know. I have a path to fix it backup nova to local | 07:20 |
| yangyapeng | https://review.openstack.org/#/c/315547/ and https://review.openstack.org/#/c/315085/ | 07:21 |
| yangyapeng | this patch fix it to backup nova and cinder to local | 07:22 |
| yangyapeng | it is unavaiable in master, but it need to have a try in stable/mitaka. | 07:22 |
| yangyapeng | athinkingmeat: | 07:22 |
| yangyapeng | athinkingmeat: can you have a try ? | 07:23 |
| athinkingmeat | yangyapeng: i can try, but you will have to help me to fetch refs from git :) | 07:23 |
| yangyapeng | step1 : git fetch https://git.openstack.org/openstack/freezer refs/changes/85/315085/7 && git checkout FETCH_HEAD | 07:24 |
| yangyapeng | step1 pacth to fix backup cinder to local. | 07:25 |
| yangyapeng | step2: git fetch https://git.openstack.org/openstack/freezer refs/changes/47/315547/1 && git checkout FETCH_HEAD | 07:25 |
| yangyapeng | step 2: fix backup nova to local. | 07:25 |
| yangyapeng | freezer-agent --nova-inst-id 1983bb28-b962-4597-ab83-c7529594c1c5 | 07:26 |
| yangyapeng | --restore-from-date 2016-04-28T09:55:50 --storage local | 07:26 |
| yangyapeng | --container /home/nfs | 07:26 |
| yangyapeng | usage: | 07:26 |
| athinkingmeat | ok, thank you | 07:27 |
| athinkingmeat | ssl certificate is self signed, probably it is the reason why i get this error https://www.irccloud.com/pastebin/kBXy70fJ/ | 07:32 |
| yangyapeng | it looks like ssl certificate | 07:36 |
| yangyapeng | athinkingmeat: Can you get the token ? the command openstack token issue | 07:36 |
| athinkingmeat | i can get token with insecure flag https://www.irccloud.com/pastebin/Tqzi9qIy/ | 07:37 |
| yangyapeng | It looks like a openssl problem | 07:43 |
| athinkingmeat | ok, will try to replace cert with valid one | 07:44 |
| *** saggi has joined #openstack-freezer | 07:50 | |
| *** zhusz has joined #openstack-freezer | 07:50 | |
| *** StraubTW has joined #openstack-freezer | 07:54 | |
| *** StraubTW has quit IRC | 07:59 | |
| *** zhanghao has joined #openstack-freezer | 07:59 | |
| *** szaher_ has joined #openstack-freezer | 08:33 | |
| *** lpetrut has joined #openstack-freezer | 08:49 | |
| *** clsacramento has quit IRC | 09:05 | |
| *** electrofelix has joined #openstack-freezer | 09:15 | |
| *** daemontool has joined #openstack-freezer | 09:39 | |
| *** daemontool_ has joined #openstack-freezer | 09:44 | |
| athinkingmeat | yangyapeng: it worked with valid ssl certificate :) | 09:46 |
| yangyapeng | athinkingmeat: :) | 09:46 |
| *** daemontool has quit IRC | 09:47 | |
| openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/freezer: Remove discover from test-requirements https://review.openstack.org/345297 | 10:00 |
| daemontool_ | yangyapeng, who are the engineers from Cloud99 with more contributions in Freezer? Including the pending reviews? | 10:01 |
| *** zhurong has quit IRC | 10:02 | |
| yangyapeng | iceyao Einst Crazy zhangjnan :) | 10:05 |
| openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/freezer-api: Remove discover from test-requirements https://review.openstack.org/345301 | 10:06 |
| daemontool_ | yangyapeng, in that order from more to less contribs? | 10:07 |
| openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/freezer-web-ui: Remove discover from test-requirements https://review.openstack.org/345304 | 10:07 |
| yangyapeng | daemontool_: yeah, | 10:09 |
| yangyapeng | daemontool_: include contribution the lenth of time later | 10:10 |
| daemontool_ | yangyapeng, are you the first? | 10:11 |
| daemontool_ | ok | 10:11 |
| daemontool_ | ty | 10:11 |
| yangyapeng | daemontool_: ：） | 10:11 |
| *** yangyapeng has quit IRC | 10:18 | |
| *** yangyapeng has joined #openstack-freezer | 10:21 | |
| *** yangyapeng has quit IRC | 10:24 | |
| *** zhusz has quit IRC | 11:32 | |
| *** daemontool_ has quit IRC | 11:35 | |
| *** zhurong has joined #openstack-freezer | 11:37 | |
| *** daemontool_ has joined #openstack-freezer | 11:38 | |
| *** zhurong has quit IRC | 11:42 | |
| *** zhurong has joined #openstack-freezer | 11:43 | |
| daemontool_ | someone from ericsson should join the chan shortly to ask for some support on troubleshooting | 11:52 |
| *** yangyapeng has joined #openstack-freezer | 11:53 | |
| *** yangyapeng has quit IRC | 11:53 | |
| *** yangyapeng has joined #openstack-freezer | 11:54 | |
| *** zhusz has joined #openstack-freezer | 11:58 | |
| *** zhusz_ has joined #openstack-freezer | 11:59 | |
| *** zhusz has left #openstack-freezer | 11:59 | |
| *** qwebirc30062 has joined #openstack-freezer | 12:01 | |
| *** daemontool__ has joined #openstack-freezer | 12:06 | |
| *** daemontool_ has quit IRC | 12:09 | |
| *** iceyao has joined #openstack-freezer | 12:28 | |
| athinkingmeat | restoring nova backup: [*] Critical Error: Multiple possible networks found, use a Network ID to be more specific. (HTTP 409) (Request-ID: req-51dfed45-6134-48a0-9b80-ffab180da85f) | 13:27 |
| yangyapeng | hi athinkingmeat | 13:27 |
| yangyapeng | the patch fix it , but need you apply it . https://review.openstack.org/#/c/312430/ | 13:27 |
| yangyapeng | athinkingmeat: | 13:27 |
| athinkingmeat | yangyapeng: teach me how to find out refs please :) | 13:30 |
| yangyapeng | athinkingmeat: git fetch https://git.openstack.org/openstack/freezer refs/changes/30/312430/12 && git checkout FETCH_HEAD | 13:31 |
| yangyapeng | athinkingmeat: but, have you apply my two patch backup nova or cinder to local? | 13:32 |
| yangyapeng | athinkingmeat: so,May can't apply this directly path to fix mutiple network. | 13:33 |
| athinkingmeat | status after patching https://www.irccloud.com/pastebin/rdjgYB2R/ | 13:35 |
| yangyapeng | yeah it is ok . | 13:38 |
| yangyapeng | athinkingmeat: if you restore nova, increase the param --nova-restore-network NETWORK_ID | 13:39 |
| yangyapeng | athinkingmeat: prefix the network_id | 13:39 |
| athinkingmeat | https://www.irccloud.com/pastebin/x9EHzStG/ | 13:47 |
| *** StraubTW has joined #openstack-freezer | 13:48 | |
| athinkingmeat | probably this is because i have set internalURL for the endpoint type | 13:48 |
| athinkingmeat | i get this error now: https://www.irccloud.com/pastebin/YjnXyC19/ | 13:56 |
| *** EinstCrazy has joined #openstack-freezer | 13:58 | |
| yangyapeng | athinkingmeat: f240f5de-466e-4bf1-bcff-1a8280960a0e the network is invalid | 13:59 |
| m3m0 | hello everyone, we have a meeting at #openstack-meeting-alt | 14:00 |
| yangyapeng | athinkingmeat: the network_id is correct？ | 14:00 |
| athinkingmeat | yangyapeng: yeah, i can see it in openstack network list | 14:01 |
| *** zhusz_ has quit IRC | 14:02 | |
| *** ddieterly has joined #openstack-freezer | 14:03 | |
| athinkingmeat | yangyapeng: thank you for your time, i am going out now. will continue tomorrow :) | 14:04 |
| yangyapeng | athinkingmeat: ok see you | 14:04 |
| *** zhurong has quit IRC | 14:04 | |
| daemontool__ | shouldn't the freezer tab in horizon be under Projects like other services? | 14:07 |
| *** ddieterly has quit IRC | 14:13 | |
| *** yangyape_ has joined #openstack-freezer | 14:16 | |
| *** daemontool__ is now known as daemontool | 14:16 | |
| *** ddieterly has joined #openstack-freezer | 14:19 | |
| *** yangyapeng has quit IRC | 14:19 | |
| *** EinstCrazy has quit IRC | 14:31 | |
| *** EinstCrazy has joined #openstack-freezer | 14:32 | |
| *** michauds has joined #openstack-freezer | 14:44 | |
| daemontool | m3m0, when you get the chance can you try | 14:56 |
| daemontool | on deploying devstack master | 14:56 |
| daemontool | with freezer and try to create a new job from horizon? | 14:56 |
| daemontool | doens't work here | 14:56 |
| *** michauds has quit IRC | 14:57 | |
| m3m0 | any specific error you get? | 15:00 |
| m3m0 | daemontool: ^^ | 15:00 |
| domhnallw | daemontool, I've been seeing some weird stuff here too. | 15:00 |
| zhangjn | Kolla first | 15:00 |
| *** yangyapeng has joined #openstack-freezer | 15:01 | |
| iceyao | ：） | 15:01 |
| m3m0 | domhnallw: which ones? | 15:01 |
| m3m0 | zhangjn: +2 :) | 15:02 |
| *** yangyape_ has quit IRC | 15:02 | |
| *** Marcellin_ has joined #openstack-freezer | 15:02 | |
| zhangjn | iceyao: you can to do this BP. | 15:03 |
| iceyao | yeah, I can do that | 15:03 |
| zhangjn | :) | 15:03 |
| domhnallw | m3m0, It's a bit hazy in my head as it was a few days ago, but IIRC from a fresh devstack install I'm seeing what look like some layout issues, and as well as that when I've tried to request lists of certain items, it was redirecting me to /identity. | 15:03 |
| domhnallw | I know I was thinking about raising a bug but I wanted to rule out that it was something not-so-clever in my setup :) | 15:04 |
| m3m0 | if you can raise the bug we can work on it, let me ask the management if we can work on horizon or move the bug to the horizon team | 15:05 |
| domhnallw | Sure. | 15:06 |
| domhnallw | I'll get to that maybe tomorrow. | 15:06 |
| openstackgerrit | yapeng Yang proposed openstack/freezer: Increase the judgment of the state of the cinder volume https://review.openstack.org/318551 | 15:06 |
| daemontool | domhnallw, ok thanks | 15:07 |
| daemontool | m3m0, when the create job button is clicked | 15:07 |
| daemontool | nothing happen | 15:07 |
| domhnallw | daemontool, I think that might be related to what I was seeing. | 15:07 |
| *** saggi has quit IRC | 15:07 | |
| domhnallw | The network activity logs in the browsers I tried were... odd. | 15:07 |
| m3m0 | do you have any example of those logs? | 15:08 |
| daemontool | yes but there-s nothing | 15:08 |
| daemontool | ok | 15:09 |
| m3m0 | and for the network logs? | 15:09 |
| daemontool | have to check | 15:09 |
| daemontool | freezer client-list retrurn None | 15:10 |
| domhnallw | One sec. | 15:10 |
| yangyapeng | should have a auto regist client to freezer-api | 15:11 |
| daemontool | quite cool the freezer cli | 15:11 |
| daemontool | :) | 15:11 |
| daemontool | btw did you try the remote console from horizon for a VM? impressive :) | 15:12 |
| slashme | daemontool: ?? | 15:13 |
| slashme | Daemontool: the NoVNC console ? | 15:13 |
| daemontool | yes, if you start a vm, click on the vm details, console | 15:14 |
| domhnallw | m3m0, I'm having difficulty replicating it right now because I have jobs and actions to browse, but beforehand requests to (for example) http://my_devstack_host/dashboard/disaster_recovery/jobs would return a 302 Found and redirect me to /dashboard/identity instead. Now that I have jobs, it doesn't do that. | 15:14 |
| daemontool | you have a remote qemu console | 15:14 |
| slashme | Hmm, something new in the console ? It's been present since forever. | 15:15 |
| daemontool | never saw it | 15:16 |
| slashme | It's especialy usefull with windows VM ;) | 15:17 |
| *** szaher_ has quit IRC | 15:18 | |
| yangyapeng | domhnallw: my question is different from you, I create action , but when I create a job, that con not join in the job action | 15:18 |
| yangyapeng | error getting action list | 15:18 |
| domhnallw | yangyapeng, yes, I'm getting that too when there are no actions assigned to the user I've logged in as. | 15:19 |
| domhnallw | If there are actions logged, then it seems to want to work, at least here. | 15:20 |
| *** EinstCrazy has quit IRC | 15:20 | |
| domhnallw | The layout on the pages is strange looking in some cases; for example, when you look at the jobs page and haven't clicked on a job to show its actions, then the little TWBS toolbar at the top of the actions list is being hidden and the action list gets pulled upward by the height of the toolbar pulling it out of line with the jobs list. | 15:22 |
| domhnallw | That thing of hiding the button toolbar on the right-hand pane is happening in a couple of places and throwing off the alignment of the left and right panes (for example, on the jobs page, left pane = jobs list, right pane = actions list) | 15:23 |
| yangyapeng | yeah | 15:25 |
| *** StraubTW_ has joined #openstack-freezer | 15:28 | |
| domhnallw | Specifically, it's the <caption> tag for the relevant table, e.g. the actions_in_job table on the job list page. | 15:28 |
| domhnallw | yangyapeng, just in case, you know that the UI will only show jobs, actions etc. that are issued through the API? | 15:30 |
| domhnallw | The command-line tools won't necessary touch the API so they won't appear in the Horizon plugin either. | 15:30 |
| *** szaher_ has joined #openstack-freezer | 15:30 | |
| *** StraubTW has quit IRC | 15:30 | |
| domhnallw | This behaviour is intentional. | 15:30 |
| *** StraubTW_ has quit IRC | 15:31 | |
| yangyapeng | but , I use the curl command create job , it is ok, and it is through the api. | 15:32 |
| domhnallw | Yep, that *should* be fine. | 15:32 |
| domhnallw | It was in case you were using the agent, for example. | 15:33 |
| yangyapeng | curl -s -H "X-Auth-Token: gAAAAABXgFgCniNhNu5wbJOIXGiuDXeBrYXaVxiY_P2c186xXHxKdi_CDtn0JJa5ZeKmH5karIDfZAJdVCzAE-YxcRlPa3_TgWmJP6rI3ixY4Smc3NuD-3DPyWj4X7uIs7jssktRBXd5WmjdTM-JQ1uAhVbnlBRslseLCndEMXiEc72tvcWK_C4" -X POST -H "Content-type: application/json" -d '{"client_id": "e1b7f9b499224fccbd5e9755b36cb186_freezer", "description": "freezer backup nova-81", "job_actions": [{"fullbackup_dayofweek”: "1", "mandatory": true, "m | 15:33 |
| yangyapeng | ax_retries": 5, "max_retries_interval": 60, "freezer_action": {"action": "backup", "cindernative_vol_id": "cf19a93f-b272-44fa-89db-18664658a00e", "backup_level": "incremental"}}], "job_schedule": {"schedule_interval": "1 days”, "schedule_start_date": "2016-07-03T10:38:00"}}' http://172.16.40.240:9090/v1/jobs | 15:34 |
| yangyapeng | It is ok .it shoud be fine | 15:34 |
| yangyapeng | In horizon, the same as use command curl maybe | 15:35 |
| domhnallw | Okay, I just mentioned it in case it was the cause. It seems it's not. | 15:35 |
| *** michauds has joined #openstack-freezer | 15:35 | |
| szaher_ | guys, do you think we might need this ( http://docs.openstack.org/developer/oslo.config/mutable.html ) for anything in freezer ? | 15:35 |
| domhnallw | What would be the use case, I guess? | 15:36 |
| *** StraubTW has joined #openstack-freezer | 15:36 | |
| domhnallw | Would either the agent or the scheduler benefit from on-the-fly reconfiguration? | 15:38 |
| *** michauds has quit IRC | 15:40 | |
| szaher_ | Scheduler and freezer-api might use it, not sure about that | 15:40 |
| szaher_ | the agent I don't think so | 15:41 |
| yangyapeng | hmm agent don't need | 15:41 |
| szaher_ | Yes | 15:42 |
| StraubTW | Hi! I was trying to run the Freezer code without the trickle executable but with a configuration file. It wouldn’t run. So, I took a look and it appears that if you do not have a trickle executable but you do have a config file that it will add a tmp_file key to the backup_args dictionary. However, if you don’t have a trickle executable, it will try to pop out tmp_file which doesn’t exist and thus an exception is thr | 15:53 |
| StraubTW | own and the program exits. Would it be possible to have someone move the if backup_args.config: \ backup_args.__dict__[‘tmp_file’] = conf_file.name above and on the same indent as the if trickle_executable and then move the part in the else statement if backup_args.config to the same indent level as well? That should prevent it from having a happy heart attack and exiting. | 15:53 |
| StraubTW | All in reference to a file called "config.py" under the common directory. | 15:56 |
| szaher_ | StraubTW | 15:56 |
| szaher_ | StraubTW | 15:56 |
| szaher_ | Hi StraubTW | 15:56 |
| StraubTW | Hi! | 15:56 |
| szaher_ | which version of freezer are you using ? | 15:57 |
| szaher_ | could you paste your error message, config file and logs here http://paste.openstack.org/ | 15:57 |
| StraubTW | "Mitaka" | 15:57 |
| StraubTW | Sure. Gimmie a sec. | 15:58 |
| szaher_ | tyt | 15:58 |
| StraubTW | Ok. | 16:01 |
| szaher_ | urls plz | 16:04 |
| StraubTW | http://paste.openstack.org/show/539076/ | 16:05 |
| StraubTW | Sorry. Wasn't sure how all of this worked. | 16:05 |
| *** iceyao has quit IRC | 16:08 | |
| szaher_ | StraubTW I am not sure what are you trying to do here ? | 16:09 |
| szaher_ | where is the path that you're trying to back it up ? | 16:10 |
| szaher_ | why are you adding all this arguments to your config file ? | 16:10 |
| szaher_ | adding upload_limit or download_limit will make freezer look for trickle executable | 16:10 |
| StraubTW | It was the example config file. path_to_backup = /Users/AStraub/Documents is the test dir I was trying to back up. | 16:10 |
| szaher_ | what is the command that you used to run this job ? | 16:11 |
| szaher_ | why did you add the option param config to the job file ? | 16:11 |
| StraubTW | Because it was in the example file? | 16:11 |
| StraubTW | freezerc --config ./freezer/job-backup.conf | 16:11 |
| StraubTW | Sorry... freezerc --config .freezer/job-backup.conf | 16:12 |
| szaher_ | freezerc is deprecated and to be removed I think in newton | 16:13 |
| szaher_ | where is the example file ? | 16:13 |
| szaher_ | can you provide a link for that file ? | 16:13 |
| szaher_ | http://paste.openstack.org/show/539078/ | 16:15 |
| szaher_ | try to run this job file to test freezer | 16:15 |
| szaher_ | and use the command # freezer-agent --config .../path/to/job/file | 16:16 |
| szaher_ | http://paste.openstack.org/show/539080/ here is a modified one | 16:17 |
| szaher_ | you have to source OS credentials that will be used to upload the backup to swift | 16:18 |
| domhnallw | StraubTW, is that a Windows box you're running that on? | 16:18 |
| StraubTW | Mac | 16:18 |
| domhnallw | Oh. | 16:18 |
| domhnallw | Was wondering about /Users. | 16:18 |
| StraubTW | The example file is in github under /specs/ and is called job-backup.conf.example | 16:19 |
| szaher_ | I think this needs to be change and it's outdated | 16:20 |
| szaher_ | slashme any idea about this https://github.com/openstack/freezer/blob/stable/mitaka/specs/job-backup.conf.example ? | 16:21 |
| StraubTW | The file in question is in the master branch at: https://github.com/openstack/freezer/blob/master/freezer/common/config.py | 16:22 |
| domhnallw | It's identical to the one on the mitaka brance bar a single typo in a comment. I suspect it's a bit outdated. | 16:23 |
| domhnallw | branch* | 16:23 |
| szaher_ | StraubTW, which question | 16:24 |
| szaher_ | ? | 16:24 |
| domhnallw | szaher_, "in question" === "that we're talking about" | 16:24 |
| slashme | szaher it is super outdated ... | 16:25 |
| domhnallw | :p | 16:25 |
| *** ddieterly is now known as ddieterly[away] | 16:25 | |
| StraubTW | Outside of the example, if you run without the trickle executable, on line 565 it will skip to the else clause and then attempt to remove the tmp_file item. | 16:26 |
| StraubTW | However, the tmp_file item is only added if you are in the if clause above the else. | 16:26 |
| szaher_ | Please, check from line 530 | 16:27 |
| szaher_ | if you passed upload_limit or download_limit and you are using config file this is going to create a tmp file and dump the parameters that you passed in your config file in it | 16:28 |
| szaher_ | if backup_args.config: | 16:28 |
| szaher_ | conf_file = NamedTemporaryFile(prefix='freezer_job_', delete=False) | 16:28 |
| StraubTW | Yes.... | 16:29 |
| szaher_ | so, removing the tmp file is Ok and won't cause anyproblems | 16:29 |
| StraubTW | But trying to remove 'tmp_file' from the dictionary when it is not there causes an exception. | 16:29 |
| szaher_ | if you didn't pass upload or download limits so no tmp files will be created and we won't call the remove statement | 16:29 |
| StraubTW | line 588 | 16:29 |
| StraubTW | backup_args.__dict__.pop('tmp_file') | 16:29 |
| szaher_ | Do you have a code editor offline ? | 16:30 |
| StraubTW | I have a copy of the file and a copy of vi. | 16:30 |
| StraubTW | I'm looking at : https://github.com/openstack/freezer/blob/master/freezer/common/config.py | 16:31 |
| szaher_ | me too | 16:32 |
| szaher_ | you need to have something where you can fold and unfold the code just to see | 16:32 |
| StraubTW | Ok. In the if statement at line 573 the 'tmp_file' item is added to the dictionary. | 16:32 |
| StraubTW | in the else statement associated with the if it is removed from the dictionary. | 16:32 |
| StraubTW | Thus, if the if statement is false it will go to the else statement and attempt to remove the item which is not in the dictionary. | 16:33 |
| szaher_ | Man the tmp file and tmp_file index are created before the if statement | 16:34 |
| szaher_ | check line 501 | 16:34 |
| StraubTW | 502 says that you add an item to the dictionary called 'storages' | 16:34 |
| StraubTW | However, the code is popping an item called 'tmp_file' which was never added. | 16:35 |
| szaher_ | Ok, You are right | 16:36 |
| szaher_ | going to file a bug about this and do it tomorrow | 16:36 |
| StraubTW | Thank you very much. I hope I was helpful. | 16:36 |
| szaher_ | Thanks man :) | 16:36 |
| *** szaher_ has quit IRC | 16:37 | |
| slashme | szaher: the bug is already created | 16:38 |
| *** ddieterly[away] is now known as ddieterly | 17:01 | |
| *** ddieterly is now known as ddieterly[away] | 17:22 | |
| *** electrofelix has quit IRC | 17:35 | |
| *** clenimar has quit IRC | 17:45 | |
| *** lpetrut has quit IRC | 17:57 | |
| *** daemontool has quit IRC | 18:01 | |
| *** clenimar has joined #openstack-freezer | 18:12 | |
| *** lpetrut has joined #openstack-freezer | 18:18 | |
| *** ddieterly[away] has quit IRC | 18:22 | |
| *** lpetrut has quit IRC | 18:27 | |
| *** ddieterly has joined #openstack-freezer | 18:32 | |
| *** ddieterly is now known as ddieterly[away] | 18:42 | |
| *** lpetrut has joined #openstack-freezer | 18:46 | |
| *** michauds has joined #openstack-freezer | 18:51 | |
| *** ddieterly[away] is now known as ddieterly | 18:55 | |
| *** ddieterly is now known as ddieterly[away] | 19:21 | |
| *** ddieterly[away] is now known as ddieterly | 19:23 | |
| *** ddieterly is now known as ddieterly[away] | 19:27 | |
| *** ddieterly[away] is now known as ddieterly | 19:50 | |
| *** ddieterly is now known as ddieterly[away] | 20:25 | |
| *** ddieterly[away] is now known as ddieterly | 20:57 | |
| *** ddieterly has quit IRC | 21:10 | |
| *** clenimar has quit IRC | 21:47 | |
| *** Marcellin_ has quit IRC | 21:57 | |
| *** clenimar has joined #openstack-freezer | 22:02 | |
| *** StraubTW has quit IRC | 22:12 | |
| *** lpetrut has quit IRC | 22:33 | |
| *** ddieterly has joined #openstack-freezer | 22:43 | |
| *** ddieterly has quit IRC | 23:20 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!