| opendevreview | Markus Hentsch proposed openstack/freezer master: Remove inconsistent no_incremental option https://review.opendev.org/c/openstack/freezer/+/973219 | 09:58 |
|---|---|---|
| mhen | noonedeadpunk: release note added and also caught some remainig occurences of the old flag in the docs which I fixed | 09:58 |
| noonedeadpunk | yep, was just looking at `--noincremental` part... | 10:06 |
| noonedeadpunk | which got confused be because of https://docs.python.org/3/library/argparse.html#argparse.BooleanOptionalAction | 10:07 |
| mhen | oslo's behavior is different from argparse: https://docs.openstack.org/oslo.config/latest/reference/api/oslo_config.html#oslo_config.cfg.BoolOpt | 10:10 |
| mhen | it generates `--no<myoptionname>` instead of `--no-<myoptionname>` (not the hyphen) | 10:10 |
| noonedeadpunk | I was jsut tryihng to find that, yes :D | 10:11 |
| noonedeadpunk | I just close to never used it this way | 10:12 |
| noonedeadpunk | I have comments on the release note though, sorry | 10:21 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Remove inconsistent no_incremental option https://review.opendev.org/c/openstack/freezer/+/973219 | 10:43 |
| opendevreview | Josephine Seifert proposed openstack/freezer master: Default to identity version 3 https://review.opendev.org/c/openstack/freezer/+/973615 | 13:25 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix issues in Python code https://review.opendev.org/c/openstack/freezer/+/973620 | 13:44 |
| opendevreview | Josephine Seifert proposed openstack/freezer-api master: Fix devstack installation of elasticsearch https://review.opendev.org/c/openstack/freezer-api/+/973462 | 13:48 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Glance integration https://review.opendev.org/c/openstack/freezer/+/973623 | 14:01 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Glance integration https://review.opendev.org/c/openstack/freezer/+/973623 | 14:08 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Glance integration https://review.opendev.org/c/openstack/freezer/+/973623 | 14:10 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Nova integration https://review.opendev.org/c/openstack/freezer/+/973625 | 14:13 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Cinder integration and osbrick engine https://review.opendev.org/c/openstack/freezer/+/973627 | 14:18 |
| mhen | noonedeadpunk: I have abondoned the mixed patchset and split it up: https://review.opendev.org/q/topic:%22fix/nova-cinder-glance-integration%22 | 14:21 |
| mhen | Python fixes @ https://review.opendev.org/c/openstack/freezer/+/973620 are the base, then Glance @ https://review.opendev.org/c/openstack/freezer/+/973623 and Nova and Cinder base on the Glance changes | 14:22 |
| mhen | hopefully this can make reviews quick | 14:23 |
| noonedeadpunk | 973620 fails on unit tests from what I can tell | 14:34 |
| mhen | yeah, the split did some damage | 14:39 |
| mhen | I'm looking into it | 14:39 |
| noonedeadpunk | btw also instead of setting "depends-on" you can have patches rebased on each other. Or, just push them all together, if they're developed together | 14:40 |
| mhen | wdym "push them all together"? | 14:41 |
| noonedeadpunk | so if you have like 2-3 commits on a local branch (or master), doing `git review` will send them together and make them "rebased" and tested together as well | 14:42 |
| mhen | wait what? | 14:42 |
| mhen | how cool is that | 14:42 |
| noonedeadpunk | so you will see a relation chain like here https://review.opendev.org/c/openstack/project-config/+/973387 | 14:43 |
| mhen | and here I am fighting with multiple git worktrees ... | 14:43 |
| noonedeadpunk | and, you can rebase pataches on each other in gerrit as well | 14:43 |
| noonedeadpunk | yeah, right, that's why I decided to mention that, as the way you did pushed seemed you got some hard time... | 14:44 |
| noonedeadpunk | and that's smth quite unique to gerrrit, which doesn't really exist in gitlab/github | 14:44 |
| mhen | guess I can't migrate my current 4 patchsets to chained commits and need to abandon them first? | 14:46 |
| noonedeadpunk | you can, why not | 14:48 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix issues in Python code https://review.opendev.org/c/openstack/freezer/+/973620 | 14:48 |
| noonedeadpunk | ie like that ^ :D | 14:49 |
| noonedeadpunk | damn | 14:49 |
| noonedeadpunk | I did it in reverse | 14:49 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix issues in Python code https://review.opendev.org/c/openstack/freezer/+/973620 | 14:49 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Glance integration https://review.opendev.org/c/openstack/freezer/+/973623 | 14:49 |
| mhen | how are you doing this? | 14:50 |
| noonedeadpunk | rebase button in gerrt | 14:51 |
| noonedeadpunk | but also you can jsut do `git rebase; git review` | 14:51 |
| mhen | ok, question before I unleash chaos: if I do the rebases in gerrit, chain all of them together and then locally do "git review -d" on the last in the chain, can I edit all 4 patchsets in parallel by amending the last 4 commits on my local branch working copy? | 14:54 |
| noonedeadpunk | so you'd need to do git review -d of the patch you want to edit | 14:55 |
| noonedeadpunk | but yes, all of them will appear locally for you | 14:55 |
| mhen | I'm referring to your "so if you have like 2-3 commits on a local branch (or master), doing `git review` will send them together and make them "rebased" and tested together as well" | 14:55 |
| noonedeadpunk | probably you can amend all of them by checkouting to head, but I try to avoid that | 14:55 |
| noonedeadpunk | "git review -d" -> this downloads remote commit to your machine, isn't it? | 14:56 |
| mhen | this is how I "edit an existing patchset" so to speak | 14:56 |
| noonedeadpunk | I mean. You can play with it :) THere's nothing which can't be undone, unless some commit will have multiple `Change-Id:` in footer :D | 14:57 |
| noonedeadpunk | then it will be a mess | 14:57 |
| noonedeadpunk | but yes, if you have like 2-3 commits and you do `git review` - all 3 will be sent as different patches, chained together | 14:58 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Cinder integration and osbrick engine https://review.opendev.org/c/openstack/freezer/+/973627 | 14:59 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Nova integration https://review.opendev.org/c/openstack/freezer/+/973625 | 14:59 |
| noonedeadpunk | and you also don't need depends-on in this case | 15:00 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix issues in Python code https://review.opendev.org/c/openstack/freezer/+/973620 | 15:01 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Glance integration https://review.opendev.org/c/openstack/freezer/+/973623 | 15:01 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Cinder integration and osbrick engine https://review.opendev.org/c/openstack/freezer/+/973627 | 15:01 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Nova integration https://review.opendev.org/c/openstack/freezer/+/973625 | 15:01 |
| mhen | woah that is so cool | 15:01 |
| noonedeadpunk | gerrit is really nice :) | 15:01 |
| mhen | til | 15:01 |
| mhen | noonedeadpunk: thank you so much for your guidance this is immensely helpful | 15:02 |
| noonedeadpunk | I really have quite some level of anxiety when I have to deal with Github these days | 15:02 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix issues in Python code https://review.opendev.org/c/openstack/freezer/+/973620 | 16:24 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Glance integration https://review.opendev.org/c/openstack/freezer/+/973623 | 16:25 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Cinder integration and osbrick engine https://review.opendev.org/c/openstack/freezer/+/973627 | 16:33 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Nova integration https://review.opendev.org/c/openstack/freezer/+/973625 | 16:34 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Replace cinderclient with SDK and fix osbrick https://review.opendev.org/c/openstack/freezer/+/973627 | 16:37 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Nova integration and change clients to SDK https://review.opendev.org/c/openstack/freezer/+/973625 | 16:39 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Replace cinderclient with SDK and fix osbrick https://review.opendev.org/c/openstack/freezer/+/973627 | 17:08 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix issues in Python code https://review.opendev.org/c/openstack/freezer/+/973620 | 17:13 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Glance integration https://review.opendev.org/c/openstack/freezer/+/973623 | 17:13 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Replace cinderclient with SDK and fix osbrick https://review.opendev.org/c/openstack/freezer/+/973627 | 17:13 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Replace cinderclient with SDK and fix osbrick https://review.opendev.org/c/openstack/freezer/+/973627 | 17:16 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Nova integration and change clients to SDK https://review.opendev.org/c/openstack/freezer/+/973625 | 17:16 |
| opendevreview | Markus Hentsch proposed openstack/freezer master: Fix Nova integration and change clients to SDK https://review.opendev.org/c/openstack/freezer/+/973625 | 17:22 |
| mhen | so, unit tests succeed for each of the individual patchset in the chain locally for me now, let's see what Zuul says | 17:25 |
| -opendevstatus- NOTICE: Gerrit on review.opendev.org will be offline briefly in order to restart on a newer JVM and to clear out caches | 18:33 | |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!