| *** mhen_ is now known as mhen | 02:32 | |
| mhen | noonedeadpunk: while I reviewed your fix for restore-from-date I noticed that when specifying a timestamp before the oldest backup, freezer-agent returns the error "Critical Error: max() arg is an empty sequence" | 10:38 |
|---|---|---|
| mhen | this is because there is no matching backup (empty list) for that restore-from-date filter | 10:38 |
| mhen | I didn't mention it in the review because it is not strictly caused by your changes but rather the code part [1] missing any kind of handling for an empty list to begin with | 10:40 |
| mhen | [1] https://github.com/openstack/freezer/blob/a3210ca85aa698e0af957dd85b41609c6522261e/freezer/openstack/restore.py#L257 | 10:40 |
| noonedeadpunk | mhen: ah, right, I will patch this out right away | 10:40 |
| noonedeadpunk | goiod catrch | 10:40 |
| opendevreview | Merged openstack/freezer-web-ui master: Move freezer panel under Projects dashboard https://review.opendev.org/c/openstack/freezer-web-ui/+/973949 | 18:19 |
| opendevreview | Merged openstack/freezer-web-ui master: Register a panel for API url https://review.opendev.org/c/openstack/freezer-web-ui/+/973972 | 18:19 |
| opendevreview | Merged openstack/freezer-web-ui master: Do not raise KeyError when sessions/jobs do not exist https://review.opendev.org/c/openstack/freezer-web-ui/+/975427 | 18:19 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!