| *** diogogmt has quit IRC | 00:08 | |
| *** SumitNaiksatam has quit IRC | 00:15 | |
| *** davidlenwell has quit IRC | 00:53 | |
| *** davidlenwell has joined #openstack-fwaas | 01:05 | |
| *** diogogmt has joined #openstack-fwaas | 01:05 | |
| *** vishwanathj has quit IRC | 01:10 | |
| *** chandanc_ has joined #openstack-fwaas | 01:30 | |
| *** vishwanathj has joined #openstack-fwaas | 01:32 | |
| *** chandanc_ has quit IRC | 01:38 | |
| *** chandanc_ has joined #openstack-fwaas | 02:38 | |
| *** SridarK has quit IRC | 02:50 | |
| *** diogogmt has quit IRC | 03:05 | |
| *** yamamoto has joined #openstack-fwaas | 03:17 | |
| *** mickeys has joined #openstack-fwaas | 03:23 | |
| *** mickeys has quit IRC | 03:27 | |
| *** vishwanathj has quit IRC | 04:06 | |
| *** yamamoto_ has joined #openstack-fwaas | 04:18 | |
| *** yamamoto_ has quit IRC | 04:18 | |
| *** yamamoto has quit IRC | 04:18 | |
| *** yamamoto has joined #openstack-fwaas | 04:19 | |
| *** yamamoto has quit IRC | 04:23 | |
| *** vishwanathj has joined #openstack-fwaas | 04:26 | |
| *** vishwanathj has quit IRC | 04:26 | |
| *** yamamoto has joined #openstack-fwaas | 05:04 | |
| *** vishwanathj has joined #openstack-fwaas | 05:29 | |
| *** vishwanathj has quit IRC | 05:29 | |
| *** SridarK has joined #openstack-fwaas | 05:59 | |
| SridarK | chandanc_: hi | 05:59 |
|---|---|---|
| chandanc_ | Hello SridarK | 06:05 |
| chandanc_ | sorry was busy with other stuff | 06:05 |
| SridarK | chandanc_: oh no worries | 06:05 |
| SridarK | chandanc_: saw ur email - nice that u got the basic calls going | 06:05 |
| chandanc_ | ya, but there are small small stuff to be fixed | 06:05 |
| SridarK | chandanc_: is there something else u would need from me - so u have a productive day | 06:06 |
| SridarK | chandanc_: yes noted, going thru that | 06:06 |
| chandanc_ | For my testing, not yet | 06:06 |
| chandanc_ | i thing i have to get on with the POST call | 06:06 |
| chandanc_ | I havent got enough time to look at the conntrack patch | 06:07 |
| chandanc_ | will get back | 06:07 |
| chandanc_ | just wanted to know, what is the timelike you are looking at for the patches | 06:07 |
| chandanc_ | *timeline | 06:07 |
| SridarK | chandanc_: no worries on the conntrack pls take a look when u can | 06:10 |
| SridarK | chandanc_: for the patches - i was hoping we can merge or be very close to merging b4 we start the next week | 06:10 |
| SridarK | i was hoping for tomorrow, but that looks unlikely, i have been adding to the db patch as that has to go in right after the ext | 06:11 |
| chandanc_ | hmm, monday is holiday here. But i am hoping to get some testing done during the weekend | 06:11 |
| SridarK | chandanc_: yes i also realized that | 06:11 |
| SridarK | chandanc_: ok great, i will also be avail all weekend - to get things ready | 06:12 |
| chandanc_ | sure will mail/irc | 06:14 |
| chandanc_ | thanks a lot for the help | 06:14 |
| chandanc_ | looks like we have a problem with tenant_id and project_id, the REST API is expecting to receive project_id, while neutron is only passing on tenant_id. Also the plugin code is using tenant_id while DB is mostly using project_id | 07:00 |
| chandanc_ | I dont have a complete view of the tenant_id/project_id change, can someone provide some background/context | 07:01 |
| SridarK | chandanc_: yes this was a problem for me too, i think just now things have moved to project_id | 07:07 |
| chandanc_ | any tricks ? | 07:07 |
| SridarK | this also has some keystone implications, so what i did for my testing was just to replace project_id with tenant_id | 07:07 |
| SridarK | which is why the curl cmds are also with tenant_id | 07:08 |
| chandanc_ | oh, will try that | 07:08 |
| SridarK | i think that will be easiest | 07:08 |
| chandanc_ | sure | 07:08 |
| SridarK | chandanc_: in the db, look at _make_firewall_group_dict_with_rules() - this will create the dict that will get sent across to the agent | 07:15 |
| SridarK | i have not tested that yet - so u may run in to some integration issues | 07:15 |
| SridarK | other parts of the create firewall_group should be ok | 07:16 |
| SridarK | in the plugin, the key point for u would be: self.agent_rpc.update_firewall_group(context, fw_with_rules) in the create_firewall_group method | 07:17 |
| SridarK | my suggestion is to craft a dict that u can pass in here so that u can test the workflow thru the agent and driver | 07:17 |
| SridarK | i am quite exhausted, so i will call it a night, but will check in with u early am (my time) | 07:18 |
| *** mickeys has joined #openstack-fwaas | 08:27 | |
| *** carl_baldwin_ has joined #openstack-fwaas | 08:31 | |
| *** mickeys has quit IRC | 08:31 | |
| *** mickeys has joined #openstack-fwaas | 08:32 | |
| *** carl_baldwin has quit IRC | 08:35 | |
| *** carl_baldwin_ is now known as carl_baldwin | 08:35 | |
| *** mickeys has quit IRC | 08:36 | |
| *** yamamoto has quit IRC | 09:17 | |
| *** malos_ is now known as malos | 09:19 | |
| *** chandanc_ has quit IRC | 11:01 | |
| *** yamamoto has joined #openstack-fwaas | 13:28 | |
| *** njohnston_ is now known as njohnston | 13:34 | |
| *** yamamoto has quit IRC | 13:43 | |
| *** vishwanathj has joined #openstack-fwaas | 13:56 | |
| *** diogogmt has joined #openstack-fwaas | 13:59 | |
| njohnston | Good morning SridarK | 14:05 |
| SridarK | njohnston: Good Morning | 14:05 |
| njohnston | You were up late last night! | 14:06 |
| SridarK | njohnston: yes - trying to put the wrap on the few minor things, i was able to test out the policy update | 14:06 |
| njohnston | excellent | 14:06 |
| SridarK | and push the PS | 14:06 |
| njohnston | Would you like me to push a new PS for 311159 that addresses the comments from Yushiro and Chandan? | 14:07 |
| SridarK | on the db patch - few more nits - mostly minor and UT - we can go after these | 14:07 |
| SridarK | njohnston: if u are busy on the UT, u can continue with that | 14:08 |
| SridarK | and pick this up whenever the next PS is ready | 14:08 |
| SridarK | i was chatting with chandanc and he was working around it anyway | 14:09 |
| njohnston | I worked some on the UT last night, and I am completely stuck. I was not able to move past the 404 error. | 14:09 |
| njohnston | I am thinking we might want to leave a TODO instead and separate UT implementation into another patch, as we discussed yesterday, so we can get some things merged. | 14:09 |
| SridarK | njohnston: ok - i will also look today, u think we can try to get together with mfranc213 and try to get thispushed | 14:09 |
| njohnston | mfranc213 is on PTO today | 14:10 |
| SridarK | njohnston: is there good precedence for that | 14:10 |
| njohnston | :-( | 14:10 |
| SridarK | oh ok | 14:10 |
| SridarK | i have pinged shwetaap to also address the comments on the ext patch | 14:11 |
| SridarK | so that can be ready | 14:11 |
| njohnston | Excellent, since that is the first one that needs to go through - we are all waiting on that | 14:11 |
| SridarK | yes | 14:11 |
| SridarK | and let me give the ut debugging a shot as well | 14:12 |
| SridarK | i have some mtgs in the am - but once my bit is done - i should be able to multitask | 14:12 |
| njohnston | Since I am stuck on the UT, I will focus on reviews | 14:13 |
| SridarK | could u maybe look at some of the get_ methods in the db patch | 14:13 |
| njohnston | unless you can think of a better place for me to be looking | 14:13 |
| SridarK | there are a few that need to be fixed up | 14:13 |
| SridarK | and i can look at the UT while u do that | 14:14 |
| njohnston | OK. So just to be clear, do you have anything pending you want to commit to 311159 before I start making changes? | 14:15 |
| SridarK | get_firewall_rules, get_firewall_groups | 14:15 |
| SridarK | no i was going to take these on first thing | 14:16 |
| njohnston | OK, I will work on get_methods, and I'll check back in with you when I have something to push up. | 14:16 |
| SridarK | i will also wait to see what chandan has found | 14:17 |
| SridarK | i would be nice to start next week with atleast 2 or 3 of the patches in | 14:17 |
| SridarK | ok great - we can get to work then | 14:18 |
| xgerman | ping me if you need me for anything… | 14:23 |
| SridarK | xgerman: thx | 14:25 |
| *** yamamoto has joined #openstack-fwaas | 14:30 | |
| *** chandanc_ has joined #openstack-fwaas | 14:34 | |
| SridarK | njohnston: when u get a chance - can u pls email me the error logs for ur test run | 14:42 |
| njohnston | will do | 14:45 |
| SridarK | njohnston: thx | 15:00 |
| njohnston | SridarK: Posted my fix for the get_ methods for 311159 | 15:17 |
| SridarK | njohnston: great thx | 15:18 |
| SridarK | njohnston: would it make sense to keep adding more of the UTs | 15:18 |
| SridarK | i think if we get the first one to work | 15:19 |
| SridarK | the others will fall in place | 15:19 |
| njohnston | If we can get one to work, then I think the rest will fall in line, yes... | 15:20 |
| njohnston | BTW, the UTs now have a problem: TypeError: Can't instantiate abstract class Firewall_db_mixin_v2 with abstract methods create_address_group, delete_address_group, get_address_group, update_address_group | 15:20 |
| SridarK | i clearly had an issue with the env | 15:20 |
| SridarK | i did not pick up the ext patch dependency | 15:20 |
| SridarK | yes i saw that on Jenkins | 15:21 |
| njohnston | ok, updated 311159 to include those address group methods | 15:26 |
| njohnston | plus a syntax fix | 15:26 |
| *** yamamoto has quit IRC | 15:26 | |
| *** mickeys has joined #openstack-fwaas | 15:27 | |
| *** yamamoto has joined #openstack-fwaas | 15:28 | |
| njohnston | SridarK: Sent you the output of my tox run for 311159 | 15:29 |
| SridarK | njohnston: thx | 15:35 |
| SridarK | njohnston: do u think it would make sense to continue to churn out some basic CRUD type tests for the main 3 resources | 15:36 |
| SridarK | they will all fail, but if we figure out this issue | 15:37 |
| SridarK | then we will have all of them in place | 15:37 |
| SridarK | if we have to go to Plan B - we can just pull them out of the PS and submit as another one | 15:37 |
| SridarK | i have env and started debugging - but soon i will be sitting in traffic heading to work - so it will take some time for me to get back | 15:39 |
| njohnston | Sure, I can start writing more CRUD type unit tests. I'll start by fleshing out the rest of the ones for Policy. The fwaas v2 version of this file has 71 UTs, so there is a lot to pick from... but I'll leave the negative testing and other permutations for later. | 15:42 |
| SridarK | njohnston: yes completely agree - just the basic ones will be good for now | 15:45 |
| SridarK | on the address_group - stuff - they need to come out of the ext patch - once that gets out there - we can remove it | 15:46 |
| njohnston | lunch, afk | 15:58 |
| chandanc_ | Hello All, I could list and create rules, policies and firewall_groups on my devstack. I have posted the comments on the DB, REST and Plugin patches. | 16:17 |
| SridarK | chandanc_: great thx for the validation | 16:19 |
| SridarK | chandanc_: are u able to test the agent + driver pieces | 16:20 |
| chandanc_ | i just got in shape for the driver tests, will update you as i proceed | 16:20 |
| chandanc_ | i have to go away for dinner, but will keep you posted | 16:22 |
| SridarK | chandanc_: cool - i will be driving to work too | 16:25 |
| njohnston | back | 16:42 |
| njohnston | reissuing 311159 to include public column in firewall_rules_v2 table | 16:51 |
| *** SridarK has quit IRC | 16:54 | |
| *** yamamoto has quit IRC | 16:57 | |
| *** chandanc_ has quit IRC | 17:16 | |
| *** SridarK has joined #openstack-fwaas | 17:33 | |
| *** yamamoto has joined #openstack-fwaas | 18:02 | |
| *** yamamoto has quit IRC | 18:07 | |
| njohnston | reissuing 311159 to remove firewall_policy_id foreign key | 18:29 |
| njohnston | SridarK: Any news from Shweta on https://review.openstack.org/#/c/264489/ | 18:30 |
| njohnston | SridarK: Let me know if you have had any success with the UT problem... I have ported over the rest of the UTs, so I can either join them to 311159 or spin a new patch depending on if you figured out a way around the problem. | 18:49 |
| SridarK | njohnston: i have pinged Shweta - and she said she will be getting the comments addressed soon and get a patch out | 18:51 |
| njohnston | Excellent! | 18:51 |
| SridarK | i think we have most pieces in and with the tests the chandanc has been doing too - i think we are in good shape on that | 18:51 |
| SridarK | njohnston: on the UT - one thing it seems is that we may need to fake the plugin | 18:52 |
| SridarK | njohnston: i am looking at that - got swamped with mtgs - so trying to figure this out over the rest of the day | 18:53 |
| SridarK | njohnston: i would vote for adding them to the db patch | 18:53 |
| SridarK | {"message": "The resource could not be found.<br /><br />\n\n\n", "code": "404 Not Found", "title": "Not Found"} | 18:54 |
| SridarK | i am trying to see if somehow the ext did not quite get setup - although u do have the ext mgr | 18:55 |
| SridarK | so i will continue the debugging of that, once we get that piece nailed - i think the other tests will fall in to place. | 18:56 |
| njohnston | updated 311159 with the other tests | 18:57 |
| SridarK | ok cool thx | 19:12 |
| *** SridarK has quit IRC | 19:53 | |
| -openstackstatus- NOTICE: The Gerrit service on review.openstack.org is restarting for a scheduled upgrade, but should return to service momentarily: http://lists.openstack.org/pipermail/openstack-dev/2016-August/101394.html | 20:49 | |
| -openstackstatus- NOTICE: The Mediawiki service at wiki.openstack.org will be offline from 21:00 UTC until approximately 23:00 UTC for a planned upgrade http://lists.openstack.org/pipermail/openstack-dev/2016-August/101395.html | 20:57 | |
| *** ChanServ changes topic to "The Mediawiki service at wiki.openstack.org will be offline from 21:00 UTC until approximately 23:00 UTC for a planned upgrade http://lists.openstack.org/pipermail/openstack-dev/2016-August/101395.html" | 20:57 | |
| *** SridarK has joined #openstack-fwaas | 21:33 | |
| -openstackstatus- NOTICE: ok https://wiki.openstack.org/ is now running Mediawiki 1.27.0; please let us know in #openstack-infra if anything seems wrong | 22:59 | |
| *** ChanServ changes topic to "ok https://wiki.openstack.org/ is now running Mediawiki 1.27.0; please let us know in #openstack-infra if anything seems wrong" | 22:59 | |
| *** vishwanathj has quit IRC | 23:02 | |
| *** ChanServ changes topic to "#openstack-fwaas" | 23:05 | |
| -openstackstatus- NOTICE: https://wiki.openstack.org/ is now running Mediawiki 1.27.0; please let us know in #openstack-infra if anything seems wrong | 23:05 | |
| *** mickeys has quit IRC | 23:40 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!