*** cuongnv has joined #openstack-fwaas | 01:29 | |
*** Tim_Eberhard has quit IRC | 01:52 | |
*** yushiro has joined #openstack-fwaas | 01:52 | |
yushiro | a | 02:06 |
---|---|---|
yushiro | ^^^ typo | 02:06 |
*** reedip_out_of_ar has joined #openstack-fwaas | 02:07 | |
*** lnicolas has joined #openstack-fwaas | 02:16 | |
yushiro | reedip, | 02:21 |
yushiro | Can I migrate https://review.openstack.org/#/c/478363/ to neutron-lib one? Is there some reason to keep exceptions in neutron-fwaas ? | 02:22 |
*** reedip_out_of_ar has quit IRC | 02:27 | |
xgerman_ | yushiro there is no reason. they should be in Neutron Lin | 02:30 |
xgerman_ | Lib | 02:30 |
yushiro | xgerman_, My patches are also effected his patch. So, I can help it to migrate neutron-lib. | 02:31 |
yushiro | I'll make a patch now. | 02:31 |
xgerman_ | Thx | 02:31 |
*** trungnv has quit IRC | 02:35 | |
*** Tim_Eberhard has joined #openstack-fwaas | 03:38 | |
*** yamamoto has joined #openstack-fwaas | 03:50 | |
*** amotoki_away is now known as amotoki | 03:58 | |
reedip | yushiro : If you have not created a patch, then I will migrate the same in neutron-lib. It is just a file copy | 04:09 |
yushiro | reedip, done right now :) | 04:10 |
reedip | Oh :P | 04:10 |
yushiro | I added your name as co-authored-by and added reno. http//review.openstack.org/478719 | 04:11 |
yushiro | aha, I commented in gerrit but it was broken URL ;-( | 04:11 |
reedip | Yeah, I saw it. Thanks. I will modify https://review.openstack.org/#/c/478363/1 to pick the data from neutron-lib/exceptions | 04:11 |
yushiro | Yes, please do it :) | 04:11 |
yushiro | it'll be helpful. | 04:12 |
yushiro | Anyway, my patch is needed https://review.openstack.org/#/c/478363 | 04:13 |
reedip | yushiro : Also, I think fwaas can be changed to firewall. yamamoto thanks, your comment was useful. It makes sense to move the Exceptions to neutron-lib | 04:13 |
reedip | yushiro : but renaming is optional | 04:14 |
yushiro | reedip, what is 'renaming'? | 04:17 |
reedip | neutron_lib/exceptions/fwaas.py to neutron_lib/exceptions/firewall.py | 04:18 |
*** Tim_Eberhard has quit IRC | 04:18 | |
reedip | yushiro : https://review.openstack.org/478363 | 04:25 |
yushiro | ah, sorry. I didn't realize it. | 04:28 |
yushiro | thanks. | 04:28 |
*** trungnv has joined #openstack-fwaas | 04:28 | |
yushiro | reedip, thanks for your comment. done. | 04:43 |
yushiro | reedip, I'll leave office with some accident(I lost my iphone) See you today's meeting. | 04:57 |
*** yushiro has quit IRC | 04:58 | |
reedip | ohh .... take care | 05:36 |
*** openstackgerrit has joined #openstack-fwaas | 08:49 | |
openstackgerrit | Van Hung Pham proposed openstack/neutron-fwaas master: Switch from oslosphinx to openstackdocstheme https://review.openstack.org/478750 | 08:49 |
openstackgerrit | Siyi Luo proposed openstack/neutron-fwaas master: Enable some off-by-default checks https://review.openstack.org/478819 | 09:28 |
*** yamamoto has quit IRC | 09:41 | |
*** yamamoto has joined #openstack-fwaas | 09:43 | |
*** yamamoto has quit IRC | 09:43 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-fwaas-dashboard master: Imported Translations from Zanata https://review.openstack.org/478832 | 09:45 |
*** yamamoto has joined #openstack-fwaas | 10:06 | |
openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 11:31 |
reedip | amotoki : nice ... the bot works :) | 11:31 |
reedip | xgerman_ https://review.openstack.org/#/c/478883/ | 11:32 |
openstackgerrit | Merged openstack/neutron-fwaas-dashboard master: Imported Translations from Zanata https://review.openstack.org/478832 | 11:39 |
*** yamamoto has quit IRC | 11:43 | |
*** yamamoto has joined #openstack-fwaas | 11:55 | |
*** yamamoto has quit IRC | 12:00 | |
*** yamamoto has joined #openstack-fwaas | 12:12 | |
*** cuongnv has quit IRC | 12:41 | |
*** Tim_Eberhard has joined #openstack-fwaas | 13:49 | |
*** yushiro has joined #openstack-fwaas | 14:00 | |
yushiro | reedip, hi. today's meeting? | 14:07 |
*** SridarK has joined #openstack-fwaas | 14:07 | |
SridarK | reedip: hi | 14:08 |
SridarK | sorry got late | 14:08 |
*** vks1 has joined #openstack-fwaas | 14:13 | |
SridarK | yushiro: xgerman_: perhaps reedip stepped away - were we going to talk some today on neutron-lib issues ? | 14:14 |
yushiro | SridarK, xgerman_ sounds good. OK. | 14:14 |
SridarK | yushiro: ok i think we were talk now correct ? Unless i messed up on the time | 14:15 |
yushiro | ah, so.. in this time, let me sync current status. | 14:16 |
yushiro | now, I put https://review.openstack.org/#/c/478719/ to migrate all of fwaas exceptions into neutron-lib. | 14:17 |
yushiro | boden reviewed it and looks good for him.(I just updated this patch) | 14:17 |
*** vks1 has quit IRC | 14:17 | |
yushiro | regarding exception, https://review.openstack.org/#/c/478719/ and https://review.openstack.org/#/c/478363/ | 14:18 |
*** vks1 has joined #openstack-fwaas | 14:19 | |
SridarK | ah ok 478363 will be dependent on 478719 | 14:19 |
SridarK | ok perfect | 14:19 |
yushiro | regarding networking-midonet, reedip also puts a patch https://review.openstack.org/#/c/472057/ . It also depends 478719 | 14:19 |
SridarK | yushiro: ok | 14:20 |
yushiro | So, I'll ping boden now and accerelate to be merged 478719. If it is finished, please review 478363 ASAP :) | 14:21 |
SridarK | 478719 looks good - awating Jenkins | 14:21 |
SridarK | yushiro: yes will do | 14:21 |
yushiro | SridarK, yes. After that, I'll rebase following patches(default fwg, l2-agent, defaulg-fwg configurable) | 14:21 |
SridarK | yushiro: ok and then we can do some integration test | 14:22 |
yushiro | SridarK, correct. | 14:22 |
SridarK | we may need some tweaks on the plugin - i can look into that | 14:22 |
yushiro | SridarK, xgerman_ yes, I couldn't reach out to Chandan about race condition for calling fwaas driver | 14:23 |
xgerman_ | sounds good | 14:23 |
yushiro | If you try to integrate and operates 'openstack server create', it still fails for ovs driver. | 14:24 |
SridarK | yushiro: ok | 14:24 |
yushiro | ah, please do not forget [agent] extensions = fwaas_v2 into /etc/neutron/plugins/ml2/ml2_conf.ini | 14:24 |
yushiro | and please restart q-agt, after that, l2-agent can work correctly. | 14:25 |
SridarK | yushiro: chandanc is still out this week - i asked him to ping me when he has some time - will keep u posted | 14:25 |
SridarK | yushiro: ok - did u also put this in a etherpad ? | 14:25 |
yushiro | Yes, just a moment. | 14:25 |
yushiro | SridarK, please refer https://etherpad.openstack.org/p/fwaas-v2-l2-agent and 'How to integrate xx' section. | 14:27 |
yushiro | Unfortunately, there is merge confliction because of reverting neutron-lib patch. | 14:28 |
xgerman_ | :-( | 14:28 |
SridarK | sigh yes | 14:28 |
SridarK | i am hoping over next week we can undo the revert | 14:29 |
SridarK | yushiro: thx for the etherpad link | 14:29 |
yushiro | SridarK, NP and I hope so. | 14:30 |
yushiro | SridarK, xgerman_ By the way, are you going to join in denver PTG? I may can join :) | 14:31 |
SridarK | yushiro: ah ok good - i will talk to my Manager too abt going to Denver | 14:32 |
xgerman_ | not sure — haven’t asked for dunfing | 14:34 |
xgerman_ | funding | 14:34 |
yushiro | OK. hopefully we can meet again. | 14:34 |
xgerman_ | that would be great — I also have silm hopes for Sydney (would take that over Denver) | 14:35 |
yushiro | xgerman_, yeah. and now CFP is opening. | 14:35 |
yushiro | can we talk about CFP idea here or in mail? | 14:39 |
xgerman_ | we can talk here… | 14:40 |
yushiro | OK :) | 14:40 |
yushiro | Can we talk about 'update fwaas_v2 status and some feedback from denver PTG' ? | 14:43 |
xgerman_ | aboslutely — people like demos and roadmaps | 14:44 |
SridarK | yes possibly | 14:44 |
yushiro | xgerman_, yes, demo and roadmaps are very important | 14:44 |
*** reedip_out_of_ar has joined #openstack-fwaas | 14:44 | |
SridarK | it will be good if we have L2 in place and then there is something to share | 14:44 |
SridarK | else it will be very repetitive from Boston | 14:45 |
yushiro | SridarK, yes. In fact, I'm not sure it takes 40 minutes because not so big difference from Boston. | 14:46 |
yushiro | So, I'd like to add several usecase to use fwg. | 14:47 |
xgerman_ | labs are also always popular — so we could have people follow along with the new v2 commands | 14:50 |
SridarK | xgerman_: the lab proposal is a good option | 14:52 |
reedip_out_of_ar | Hi | 14:52 |
SridarK | will involve more work but lets think on this | 14:52 |
reedip_out_of_ar | am I late ? | 14:52 |
SridarK | reedip_out_of_ar: hi | 14:52 |
xgerman_ | hi | 14:52 |
reedip_out_of_ar | wait. lemme change my nick | 14:52 |
*** reedip_out_of_ar is now known as reedip_ | 14:52 | |
yushiro | yeah, good. | 14:53 |
yushiro | oh, welcome home, reedip_ :) | 14:53 |
SridarK | reedip_: no worries | 14:53 |
reedip_ | yushiro : did you find the ifone ? | 14:53 |
SridarK | reedip_: we wanted to discuss the neutron-lib issues | 14:54 |
SridarK | but i will need to log off soon to head to work | 14:54 |
yushiro | reedip_, no I couldn't.. I just update all of account password :8 | 14:54 |
reedip_ | SridarK : I just published a new patch | 14:55 |
reedip_ | wait lemme search | 14:55 |
reedip_ | Ok, this is WIP: https://review.openstack.org/#/c/478883/ | 14:55 |
SridarK | reedip_: ok thx - let me go thru - did u find a specific issue that caused midonet to fail | 14:56 |
reedip_ | SridarK : no, but this time , I changed a lot of stuff which should ideally NOT impact any other module | 14:56 |
SridarK | reedip_: ok - let me also go thru the patch | 14:57 |
reedip_ | you can check the patch, I tried to keep the files before and after migration similar, only changing the references from neutron_fwaas.extension to neutron_lib.api.definitions | 14:57 |
yushiro | reedip_, Ok, thanks. | 14:58 |
*** Tim_Eberhard has quit IRC | 14:59 | |
reedip_ | ok | 15:00 |
SridarK | reedip_: and at some point if we can check midonet before merge - that will be good | 15:01 |
SridarK | hopefully over next week we can get things back into neutron-lib | 15:01 |
reedip_ | SridarK : Yes, I updated https://review.openstack.org/443416 | 15:03 |
SridarK | ok will step away to head to work, yushiro will keep an eye on ur PS for exceptions | 15:04 |
yushiro | SridarK, reedip_ Yes. | 15:04 |
reedip_ | yushiro : do watch it all night long :D | 15:05 |
reedip_ | just kidding | 15:05 |
SridarK | :-) | 15:05 |
yushiro | reedip_, hahaha :) Today, I have many 'KI' | 15:05 |
reedip_ | yushiro : everything is connected ( copying Marvel Cinematic Universe ) | 15:05 |
yushiro | memo! | 15:07 |
reedip_ | yushiro : your neutron-lib patch for execption needs a +1 from jenkins, it will propagate to https://review.openstack.org/#/c/478363/2 -> https://review.openstack.org/#/c/478883/ -> https://review.openstack.org/#/c/443416/ | 15:07 |
yushiro | reedip_, yes, exactly. I talked boden in a few minutes ago, he can review after jenkins got +1. | 15:08 |
reedip_ | yes, I saw the neutron IRC room | 15:08 |
yushiro | wow, everything is connected ! | 15:09 |
reedip_ | good, lets wait.once it gets a +1 , we can just recheck all the patches to see how the progress goes | 15:09 |
yushiro | :) | 15:09 |
reedip_ | SridarK , dont worry, the patches are in good (yushiro 's ) hands :P | 15:09 |
yushiro | Yes, after that, I'll rebase l2 patch | 15:09 |
reedip_ | and I can rebase my 4 pending patches :( | 15:10 |
yushiro | SridarK, xgerman_ reedip_ In last several week, I had to work my vendor's plugin(networking-fujitsu) from my manager. But it totally finished and I can focus on fwaas/neutron side. | 15:11 |
reedip_ | great ... :) | 15:11 |
xgerman_ | +1 | 15:12 |
reedip_ | SridarK, xgerman_ , yushiro : I wanted to discuss a patch | 15:13 |
xgerman_ | sure | 15:13 |
reedip_ | https://review.openstack.org/370731 | 15:13 |
yushiro | OK | 15:13 |
reedip_ | ading firewall_policy to fwaas_v2 | 15:13 |
reedip_ | yushiro logged the bug but we never concluded if it is required | 15:13 |
xgerman_ | mmh, rules can be shared among multiple policies | 15:16 |
reedip_ | xgerman_ yes, but right now we do not show the policy in the rules | 15:16 |
reedip_ | as per the bug | 15:16 |
xgerman_ | policies | 15:16 |
xgerman_ | your patch does seem to make it one pokicy - many rukes; but I think it should be many-many | 15:17 |
yushiro | reedip_, yes, I realized fwaas_v2 can use FirewallPolicyRuleAssociation. Hence, If we add firewall_rule_dict, 'firewall_policies' should be added but it is many : many relation. | 15:17 |
yushiro | xgerman_, said what I'd like to say :) | 15:18 |
yushiro | fwaas v1, firewall_policy : firewall_rule = 1:n and firewall_rule can refer 1 firewall_policy. | 15:19 |
reedip_ | as of now I was trying to link multiple firewall policies to one firewall rule | 15:20 |
reedip_ | if the firewall policy is a list, then the information can be appended, right? | 15:20 |
xgerman_ | there is an association table you need to map | 15:21 |
reedip_ | which yushiro is mentioning | 15:22 |
reedip_ | FirewallPolicyRuleAssociation | 15:22 |
reedip_ | https://github.com/openstack/neutron-fwaas/blob/034c18cd5f7543c54aa9e37599971460ac0b522f/neutron_fwaas/db/firewall/v2/firewall_db_v2.py#L90 | 15:23 |
xgerman_ | yeah, I agree we should show it on the rule (which policies use it) but I work so rarely on the DB level that i would need to look up an example mapping | 15:27 |
yushiro | http://paste.openstack.org/show/614085/ | 15:31 |
yushiro | As reedip_ said, we cannot refer firewall_policies from firewall_rule body. | 15:31 |
yushiro | ^^^^ is a result 2 policies can associate with 1 rule. | 15:32 |
reedip_ | wait , looking | 15:32 |
reedip_ | yeah , that needs to be changed | 15:32 |
reedip_ | ok, I will try to fix this :) | 15:32 |
yushiro | so, as xgerman_ said, we should add 'firewall_policies'. | 15:33 |
reedip_ | yep | 15:34 |
yushiro | into firwall_rule | 15:34 |
yushiro | SridarK, Do you have some comments about that? | 15:34 |
yushiro | reedip_, anything else to discuss ? | 15:35 |
reedip_ | nope , not from my side as of now | 15:37 |
yushiro | reedip_, OK, cool. | 15:39 |
reedip_ | ok, going for dinner now ... | 15:39 |
xgerman_ | I am in like three meetings at the same time :-( | 15:40 |
*** yamamoto has quit IRC | 15:41 | |
yushiro | xgerman_, wow, you look so hard :p I'll go to bed now.. Good night :) | 15:42 |
reedip_ | yushiro : good night | 15:42 |
yushiro | reedip_, night :) | 15:42 |
reedip_ | xgerman_ ; you need to rest a bit :) | 15:42 |
*** yushiro has quit IRC | 15:42 | |
xgerman_ | good night ;-) | 15:42 |
*** Tim_Eberhard has joined #openstack-fwaas | 16:06 | |
*** reedip_ has quit IRC | 16:11 | |
*** reedip_ has joined #openstack-fwaas | 16:18 | |
*** yamamoto has joined #openstack-fwaas | 16:41 | |
*** yamamoto has quit IRC | 16:53 | |
*** SridarK has quit IRC | 16:55 | |
*** reedip_ has quit IRC | 16:56 | |
*** vks1 has quit IRC | 17:16 | |
*** SumitNaiksatam has joined #openstack-fwaas | 17:51 | |
*** SumitNaiksatam has quit IRC | 18:56 | |
*** SumitNaiksatam has joined #openstack-fwaas | 18:58 | |
*** SumitNaiksatam has quit IRC | 19:15 | |
*** SumitNaiksatam has joined #openstack-fwaas | 19:19 | |
*** SumitNaiksatam has quit IRC | 20:27 | |
*** Tim_Eberhard has quit IRC | 23:23 | |
*** yushiro has joined #openstack-fwaas | 23:36 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!