openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: FWaaS v2 extension for L2 agent https://review.openstack.org/323971 | 00:15 |
---|---|---|
*** vishwana_ has joined #openstack-fwaas | 00:57 | |
*** vishwanathj has quit IRC | 01:01 | |
*** trungnv has quit IRC | 01:10 | |
*** yamamoto has quit IRC | 01:19 | |
*** yamamoto has joined #openstack-fwaas | 01:26 | |
*** trungnv has joined #openstack-fwaas | 01:53 | |
*** trungnv has quit IRC | 02:15 | |
*** trungnv has joined #openstack-fwaas | 02:18 | |
*** trungnv has quit IRC | 02:21 | |
reedip | I think it is Artificial Intelligence in FWaaS :D | 02:49 |
*** yushiro has joined #openstack-fwaas | 03:56 | |
openstackgerrit | Reedip proposed openstack/neutron-fwaas master: DNR WIP :RBAC DB setup and migration for FWP https://review.openstack.org/491704 | 04:46 |
openstackgerrit | Reedip proposed openstack/neutron-fwaas master: DNR WIP :RBAC DB setup and migration for FWP https://review.openstack.org/491704 | 04:50 |
openstackgerrit | Sarath Chandra Mekala proposed openstack/neutron-fwaas-dashboard master: FWaaS V2 Horizon Dashboard https://review.openstack.org/475840 | 05:06 |
*** SarathMekala has joined #openstack-fwaas | 05:08 | |
SarathMekala | hi amotoki | 05:08 |
SarathMekala | I have pushed in a patch with your devstack changes | 05:08 |
amotoki | SarathMekala: thanks. did you check it works? | 05:09 |
SarathMekala | yes | 05:09 |
amotoki | thanks | 05:09 |
SarathMekala | I check my code after the merge | 05:09 |
SarathMekala | will check the devstack by doing in a fresh install today | 05:10 |
SarathMekala | will inform you once i am done | 05:10 |
amotoki | my main env is for fwaas v1 now, so I will just review your code as static review (no running the code) | 05:10 |
SarathMekala | sure.. np | 05:10 |
amotoki | so all real work check is up to you and fwaas team | 05:10 |
SarathMekala | yeah.. will send across a doc to the team today so that they too can test out the UI | 05:11 |
amotoki | SarathMekala: btw, your patch set 10 seems to break all including fwaas v1 tests | 05:12 |
amotoki | http://logs.openstack.org/40/475840/10/check/gate-neutron-fwaas-dashboard-python27-ubuntu-xenial/87c3ac4/ut_openstack_dashboard_nose_results.html | 05:12 |
amotoki | I will review the code after some basic tests are passed to avoid unnecessary comments. | 05:13 |
SarathMekala | sure.. I will check the logs | 05:13 |
amotoki | could you at least address pep8 errors before pushing a patch set? | 05:15 |
SarathMekala | sure will take care of them | 05:16 |
*** yamamoto has quit IRC | 05:19 | |
*** yamamoto has joined #openstack-fwaas | 05:31 | |
*** yamamoto_ has joined #openstack-fwaas | 06:05 | |
*** yamamoto has quit IRC | 06:09 | |
openstackgerrit | Sarath Chandra Mekala proposed openstack/neutron-fwaas-dashboard master: FWaaS V2 Horizon Dashboard https://review.openstack.org/475840 | 06:31 |
*** vks1 has joined #openstack-fwaas | 07:07 | |
*** vks1 has quit IRC | 07:12 | |
*** vks1 has joined #openstack-fwaas | 07:39 | |
amotoki | SarathMekala: are you editing something on fwaas v2 dashboard patch? | 07:52 |
amotoki | SarathMekala: if you haven't implemented UTs, it is better to skip v2 UT using unittest.skip | 07:53 |
amotoki | SarathMekala: and passing py27 test allows you to check your code is importable. the latest version is completely broken | 07:53 |
amotoki | SarathMekala: we cannot test v2 dashboard even with devstack :( | 07:53 |
*** SarathMekala has quit IRC | 08:03 | |
*** vishwana_ has quit IRC | 08:47 | |
*** doude has quit IRC | 08:47 | |
*** vks1 has quit IRC | 08:47 | |
*** yamamoto_ has quit IRC | 08:47 | |
*** zigo has quit IRC | 08:47 | |
*** yushiro has quit IRC | 08:47 | |
*** hoangcx has quit IRC | 08:47 | |
*** reedip has quit IRC | 08:47 | |
*** Trident has quit IRC | 08:47 | |
*** bradjones has quit IRC | 08:47 | |
*** afranc has quit IRC | 08:47 | |
*** mestery has quit IRC | 08:47 | |
*** obre has quit IRC | 08:47 | |
*** bbzhao has quit IRC | 08:47 | |
*** carl_baldwin has quit IRC | 08:47 | |
*** xgerman_ has quit IRC | 08:47 | |
*** fyxim has quit IRC | 08:47 | |
*** jhesketh has quit IRC | 08:47 | |
*** mfranc213 has quit IRC | 08:47 | |
*** openstackgerrit has quit IRC | 08:47 | |
*** njohnston has quit IRC | 08:47 | |
*** ChanServ has quit IRC | 08:47 | |
*** amotoki has quit IRC | 08:47 | |
*** openstack has joined #openstack-fwaas | 13:53 | |
*** vks1 has quit IRC | 14:02 | |
xgerman_ | o/ | 14:14 |
*** vks1 has joined #openstack-fwaas | 14:15 | |
*** SridarK has joined #openstack-fwaas | 15:12 | |
*** reedip_ has joined #openstack-fwaas | 15:37 | |
*** yamamoto has quit IRC | 15:43 | |
*** yamamoto has joined #openstack-fwaas | 15:45 | |
*** yamamoto has quit IRC | 15:45 | |
*** yamamoto has joined #openstack-fwaas | 15:46 | |
*** SarathMekala has joined #openstack-fwaas | 15:48 | |
*** yamamoto has quit IRC | 15:51 | |
*** yamamoto has joined #openstack-fwaas | 15:57 | |
*** yamamoto has quit IRC | 16:01 | |
openstackgerrit | Sarath Chandra Mekala proposed openstack/neutron-fwaas-dashboard master: FWaaS V2 Horizon Dashboard https://review.openstack.org/475840 | 16:03 |
*** SarathMekala has quit IRC | 16:10 | |
xgerman_ | I am in some interrupt driven mode so feel free to ping me if you need reviews/advice/help | 16:10 |
openstackgerrit | Sarath Chandra Mekala proposed openstack/neutron-fwaas-dashboard master: FWaaS V2 Horizon Dashboard https://review.openstack.org/475840 | 16:26 |
*** SarathMekala has joined #openstack-fwaas | 16:28 | |
SarathMekala | hi amotoki.. I have fixed the pep8 and import issues | 16:42 |
SarathMekala | you can check the build results and do the review if things go green | 16:42 |
*** yamamoto has joined #openstack-fwaas | 16:58 | |
*** yamamoto has quit IRC | 17:03 | |
*** SridarK has quit IRC | 17:04 | |
*** SarathMekala has quit IRC | 17:16 | |
*** reedip_ has quit IRC | 17:23 | |
*** vks1 has quit IRC | 17:35 | |
openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: FWaaS v2 extension for L2 agent https://review.openstack.org/323971 | 17:39 |
yushiro_dinner | hi SridarK, xgerman_ I added UTs for l2-agent and fixed some bugs. | 17:40 |
*** yushiro_dinner is now known as yushiro | 17:40 | |
yushiro | also updated how to building devstack https://etherpad.openstack.org/p/fwaas-v2-l2-agent | 17:41 |
*** yushiro is now known as yushiro_afk | 17:52 | |
*** yamamoto has joined #openstack-fwaas | 17:59 | |
*** yamamoto has quit IRC | 18:04 | |
*** yamamoto has joined #openstack-fwaas | 19:00 | |
*** yamamoto has quit IRC | 19:05 | |
*** yamamoto has joined #openstack-fwaas | 20:02 | |
*** yamamoto has quit IRC | 20:06 | |
*** yamamoto_ has joined #openstack-fwaas | 21:03 | |
*** yamamoto_ has quit IRC | 21:08 | |
*** yamamoto_ has joined #openstack-fwaas | 21:16 | |
*** yamamoto_ has quit IRC | 21:21 | |
*** yamamoto_ has joined #openstack-fwaas | 21:57 | |
yushiro_afk | gate issue .... | 23:56 |
*** yushiro_afk is now known as yushiro | 23:56 | |
*** yushiro has quit IRC | 23:56 | |
*** yushiro has joined #openstack-fwaas | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!