| *** yamamoto_ has joined #openstack-fwaas | 00:15 | |
| *** yamamoto_ has quit IRC | 00:20 | |
| *** yamamoto_ has joined #openstack-fwaas | 01:16 | |
| *** yamamoto_ has quit IRC | 01:23 | |
| *** TuanVu has joined #openstack-fwaas | 01:32 | |
| *** TuanVu has quit IRC | 02:15 | |
| *** yamamoto has joined #openstack-fwaas | 02:19 | |
| *** yamamoto has quit IRC | 02:25 | |
| *** hoangcx has quit IRC | 03:09 | |
| openstackgerrit | Merged openstack/neutron-fwaas master: FW rule applied incorrectly if port specified is a range https://review.openstack.org/443385 | 03:16 |
|---|---|---|
| *** hoangcx has joined #openstack-fwaas | 03:21 | |
| *** yamamoto has joined #openstack-fwaas | 03:21 | |
| *** yamamoto has quit IRC | 03:27 | |
| *** SarathMekala has joined #openstack-fwaas | 03:48 | |
| reedip | o/ | 03:58 |
| *** yamamoto has joined #openstack-fwaas | 03:59 | |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas-dashboard master: FWaaS V2 Horizon Dashboard https://review.openstack.org/475840 | 04:01 |
| SarathMekala | thanks yushiro | 04:25 |
| yushiro | SarathMekala, NP. but error with pep8 ;( sorry this is my mistake. | 04:26 |
| yushiro | SarathMekala, As I sent e-mail for you, I still cannot open 'create firewall group' and 'add policy' window. | 04:28 |
| yushiro | SarathMekala, How about you? | 04:28 |
| *** yamamoto has quit IRC | 04:34 | |
| *** yamamoto has joined #openstack-fwaas | 04:35 | |
| *** yamamoto has quit IRC | 04:38 | |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas-dashboard master: FWaaS V2 Horizon Dashboard https://review.openstack.org/475840 | 04:44 |
| *** SridarK has joined #openstack-fwaas | 04:51 | |
| SridarK | yushiro: hi | 04:51 |
| yushiro | SridarK, hi | 04:51 |
| SridarK | thx for the revised PS | 04:52 |
| SridarK | i just tried it quickly | 04:52 |
| yushiro | SridarK, NP :) | 04:52 |
| SridarK | same issue with create FWG | 04:52 |
| SarathMekala | yushiro, I have a cust demo from 10:30 to 11:30. I will sync up with you after that | 04:52 |
| SridarK | may be i made some mistake | 04:52 |
| SridarK | SarathMekala: no worries | 04:52 |
| SridarK | SarathMekala: thx for the diff | 04:52 |
| yushiro | SarathMekala, OK, I see. thank you. | 04:52 |
| SarathMekala | np SridarK | 04:52 |
| SridarK | SarathMekala: pls focus on ur Customer demo - ignore us for a while - then if u can work thru with yushiro - i will check again in my morn | 04:53 |
| SridarK | i will sync with yushiro now | 04:53 |
| SarathMekala | sure SridarK | 04:54 |
| SarathMekala | thanks yushiro for pitchin in | 04:54 |
| yushiro | SarathMekala, OK. :) | 04:55 |
| yushiro | SridarK, now, I found 1 issue regarding create/update firewall rule. It sends all of attributes even if we don't change from initial value. | 04:55 |
| yushiro | It has already been fixed in case of firewall group and firewall policy. | 04:56 |
| *** sarathmekala_ has joined #openstack-fwaas | 05:00 | |
| SridarK | yushiro: i tested Rule insert and delete on Policy | 05:00 |
| SridarK | that looks good | 05:00 |
| SridarK | yushiro: But Create FWG does not work for me | 05:00 |
| SridarK | Previously insert Rule on Policy had the issue with duplicates | 05:01 |
| SridarK | so that is definitely fixed | 05:01 |
| *** sarathmekala__ has joined #openstack-fwaas | 05:01 | |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas-dashboard master: FWaaS V2 Horizon Dashboard https://review.openstack.org/475840 | 05:01 |
| yushiro | SridarK, oops yes, you're right. firewall group is only success when 'UPDATE'. | 05:01 |
| *** njohnston has quit IRC | 05:02 | |
| *** afranc has quit IRC | 05:02 | |
| reedip | Modified the devstack RST a bit | 05:02 |
| reedip | and uploaded my initial comments | 05:02 |
| *** SarathMekala has quit IRC | 05:02 | |
| yushiro | thanks | 05:03 |
| *** sarathmekala_ has quit IRC | 05:04 | |
| SridarK | reedip: ok i am not pulling that now since it is RST only | 05:04 |
| yushiro | SridarK, Could you tell me what is 'duplicate' ? Insert rule list? | 05:04 |
| *** afranc has joined #openstack-fwaas | 05:04 | |
| *** njohnston has joined #openstack-fwaas | 05:04 | |
| reedip | NP :) | 05:05 |
| SridarK | yushiro: when i tried to do an insert Rule in Policy tab - i would get the drop box displaying Rule1Rule1 instead of Rule1 | 05:05 |
| SridarK | that is fixed | 05:05 |
| yushiro | SridarK, Oh, OK. | 05:05 |
| SridarK | yushiro: on update FWG | 05:06 |
| SridarK | on the Edit Dropdown i only see option for Ports | 05:07 |
| *** yushiro has quit IRC | 05:12 | |
| *** yushiro has joined #openstack-fwaas | 05:18 | |
| yushiro | SridarK, sorry I was suddenly logged out from IRC. | 05:19 |
| reedip | <SridarK> yushiro: on update FWG | 05:25 |
| reedip | on the Edit Dropdown i only see option for Ports | 05:25 |
| reedip | ^^ that was the log | 05:25 |
| yushiro | reedip, thanks | 05:25 |
| yushiro | SridarK, OK, so 'Edit Firewall Group' button. | 05:26 |
| yushiro | SridarK, I can see 'name', 'description', 'ingress polich', 'egress policy', 'enableAdmin State' and 'shared' | 05:29 |
| SridarK | yushiro: hmm | 05:29 |
| yushiro | If I click 'Add port' button, I can see only 'Ports'. | 05:30 |
| SridarK | yushiro: yes thx | 05:30 |
| SridarK | that works | 05:30 |
| SridarK | my bad | 05:30 |
| yushiro | NP | 05:30 |
| SridarK | I rarely use dashboard :-) | 05:31 |
| *** amotoki has joined #openstack-fwaas | 05:34 | |
| *** yamamoto has joined #openstack-fwaas | 05:38 | |
| SridarK | yushiro: some minor issues with FWG policy update (removing has an issue) | 05:41 |
| yushiro | SridarK, sure. | 05:43 |
| yushiro | I and amotoki commented https://review.openstack.org/#/c/475840/17/neutron_fwaas_dashboard/dashboards/project/firewalls_v2/forms.py@181 | 05:44 |
| yushiro | this includes a bug. | 05:44 |
| *** yamamoto has quit IRC | 05:44 | |
| amotoki | yushiro: SridarK: who is now taking care of it? | 05:46 |
| yushiro | I'm fixing !! | 05:46 |
| amotoki | fwaas dahboard patch set 20 from reedip looks noisy... it is completely unrelated.. | 05:46 |
| reedip | ?? | 05:46 |
| amotoki | reedip: you changed devstack/README.rst | 05:47 |
| yushiro | reedip, I think we should update only critical bug fix in this term. | 05:47 |
| reedip | yushiro , amotoki : Okay , sorry | 05:47 |
| amotoki | reedip: in addition, your change is completely unnecessary from POV of documentation too. | 05:48 |
| amotoki | reedip: no need to change from neutron to Neutron (the docs team guidelines suggests 'neutron') | 05:48 |
| reedip | amotoki : ok, didnt know that | 05:48 |
| SridarK | amotoki: also sarathmekala__ should be back online after his presentation in a bit | 05:48 |
| amotoki | reedip: in addition the line length becomes too long. it should be <80chars | 05:48 |
| reedip | ok | 05:49 |
| amotoki | so i said the change is noisy from these three reasons | 05:49 |
| amotoki | at now, yushiro is the owner of improving it | 05:49 |
| SridarK | amotoki: yes, i think with yushiro's fix for Create - the Patch is in decent shape - there could still be issues with more testing but basic workflows shd be ok | 05:50 |
| amotoki | yushiro: do you have any topic I can help? | 05:51 |
| SridarK | we can evaluate more for a decision | 05:51 |
| reedip | amotoki : thanks, and sorry for the change | 05:51 |
| *** sarathmekala__ has quit IRC | 05:57 | |
| *** sarathmekala__ has joined #openstack-fwaas | 05:57 | |
| sarathmekala__ | hi team | 06:01 |
| sarathmekala__ | I am back from my meeting.. went through the discussion | 06:02 |
| yushiro | amotoki, I need your help why we clicked 'Create firewall group' or 'Add policy' and not displayed... | 06:02 |
| sarathmekala__ | yushiro, are you getting an error when you click on create firewall group? | 06:03 |
| sarathmekala__ | and create policy? | 06:04 |
| yushiro | sarathmekala__, No error at any log ( apache, q-xxx ) | 06:04 |
| yushiro | sarathmekala__, keep on looping "Loading...." | 06:04 |
| sarathmekala__ | the UI should pop up an error message | 06:04 |
| sarathmekala__ | ok.. then its stuck some where.. I will take a look | 06:05 |
| SridarK | sarathmekala__: yes same thing as yushiro mentions observed by me | 06:07 |
| amotoki | yushiro: ack. I am trying to run fwaas-v2 in my devstack. This need to take some time to switch from fwaas v1. | 06:07 |
| yushiro | amotoki, thank you so much. | 06:07 |
| SridarK | sarathmekala__: quick summary: other things looking much better than PS17 | 06:08 |
| sarathmekala__ | cool :) | 06:08 |
| amotoki | yushiro: re "Create firewall group" , I see two "addfirewallgroup" entries in urls.py. | 06:12 |
| amotoki | https://review.openstack.org/#/c/475840/20/neutron_fwaas_dashboard/dashboards/project/firewalls_v2/urls.py | 06:12 |
| amotoki | L.30 and L.32 | 06:12 |
| amotoki | I think create firewall group does not require a policy ID as a parameter, so L.32 looks what we need. | 06:12 |
| amotoki | yushiro: thought? | 06:13 |
| yushiro | amotoki, yes. | 06:13 |
| yushiro | ah ,sorry I leave my desk now. will turn back. | 06:13 |
| amotoki | could you test after removing L.30-31 ? | 06:13 |
| *** yushiro is now known as yushiro_afk | 06:13 | |
| yushiro_afk | not tested! | 06:13 |
| *** vishwana_ has joined #openstack-fwaas | 06:15 | |
| *** vishwanathj has quit IRC | 06:18 | |
| reedip | how do we deploy the Fwaas Dashboard | 06:19 |
| reedip | I checked yushiro_afk | 06:20 |
| reedip | his email , but I couldnt get it to work | 06:21 |
| sarathmekala__ | follow the steps in yushiros email/etherpad | 06:22 |
| reedip | Checking | 06:22 |
| sarathmekala__ | ok.. am looking as well | 06:23 |
| reedip | Steps arent there | 06:23 |
| yushiro_afk | hmm, amotoki , not changed even if I deleted L30-31 | 06:25 |
| sarathmekala__ | steps: | 06:26 |
| sarathmekala__ | $ git clone https://github.com/openstack/neutron-fwaas-dashboard | 06:26 |
| amotoki | so there still seems another cause | 06:26 |
| sarathmekala__ | $ cd neutron-fwaas-dashboard | 06:26 |
| sarathmekala__ | "git review -d 475840" | 06:26 |
| sarathmekala__ | sudo pip install . | 06:26 |
| reedip | got it :) | 06:26 |
| reedip | Putting the same on the etherpad | 06:27 |
| sarathmekala__ | cp neutron_fwaas_dashboard/enabled/_1461_project_firewalls_v2_panel.py /opt/stack/horizon/openstack_dashboard/local/enabled/ | 06:27 |
| sarathmekala__ | sudo service apache2 restart | 06:27 |
| reedip | sarathmekala__ : Ok, the FirewallGroup does the LOADING bit with chrome. Thats expected, right? | 06:29 |
| sarathmekala__ | is it showing you the FWG creation form? | 06:29 |
| sarathmekala__ | its a workflow.. it has two steps | 06:29 |
| *** eezhova has joined #openstack-fwaas | 06:30 | |
| sarathmekala__ | Step1 : create FWG + add ingress/egress policy | 06:30 |
| sarathmekala__ | Step2: add the ports | 06:30 |
| sarathmekala__ | then submit | 06:30 |
| sarathmekala__ | are you able to test till here | 06:30 |
| reedip | This is what I am getting | 06:31 |
| sarathmekala__ | oops.. can you send the screenshot again | 06:31 |
| reedip | That is from Chrome | 06:31 |
| SridarK | reedip: create fwg has an issue | 06:31 |
| reedip | SridarK : The Loading is stuck, right? | 06:32 |
| yushiro_afk | 'Create firewall group' button jumps http://localhost:20080/dashboard/project/firewalls_v2/addfirewallgroup | 06:32 |
| SridarK | reedip: yes | 06:32 |
| SridarK | create a fwg from osc | 06:32 |
| SridarK | then u can test the update operation | 06:32 |
| SridarK | that is what i did | 06:32 |
| reedip | SridarK : ok, updating fwg-6 then | 06:32 |
| reedip | with this information | 06:32 |
| sarathmekala__ | SridarK, are you able to see the workflow forms | 06:33 |
| sarathmekala__ | or nothing happens when you click 'Create FWG' | 06:34 |
| reedip | sarathmekala__ : nothing happens | 06:34 |
| SridarK | sarathmekala__: yes nothing happens | 06:34 |
| sarathmekala__ | ok | 06:35 |
| SridarK | just spinning and stuck as yushiro_afk also mentioned | 06:35 |
| reedip | One more thing ( minor ) sarathmekala__ , SridarK : There is no HELP message in Create FirewallRules Form, but there are help strings in Update Firewall Rules. | 06:35 |
| reedip | SridarK : I am facing the same issue of FWG in FWP. Are you also facing that issue? | 06:40 |
| *** yamamoto has joined #openstack-fwaas | 06:40 | |
| *** yamamoto has quit IRC | 06:46 | |
| SridarK | reedip: yes and this is what folks are debugging | 06:46 |
| amotoki | hmm.... in my test env, "Create FWG" and "Add Policy" are displayed expectedly | 06:47 |
| reedip | SridarK : Ok, thanks | 06:48 |
| amotoki | Rule and Port selection form looks weird though... | 06:49 |
| reedip | SridarK : the html redirection isnt working there :( But If you add the complete link, you can view the page | 06:49 |
| reedip | for example : http://IP-ADDR/dashboard/project/firewalls_v2/addpolicy | 06:49 |
| amotoki | my env is a bit different as I am running django debug server (runserver) | 06:51 |
| SridarK | reedip: yes indeed | 06:51 |
| amotoki | i will try with apache2 httpd | 06:51 |
| SridarK | reedip: i am able to add a policy | 06:52 |
| reedip | :) | 06:52 |
| SridarK | amotoki: possibly | 06:52 |
| amotoki | from my experience so far, no difference happens by using runserver or apache2 httpd. tricky | 06:53 |
| SridarK | with addfirewallgroup - unable to create a fwg with None for either ingress or egress | 06:55 |
| *** yamamoto has joined #openstack-fwaas | 06:55 | |
| reedip | SridarK : Yes, I just checked it now .... UUID is invalid | 06:56 |
| SridarK | but other wise looks good (with complete link) | 06:56 |
| reedip | SridarK : we are sending "" as Ingress/Egress is nothing is specified. We need to send None | 06:56 |
| reedip | https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/firewall_v2.py#L142 | 06:57 |
| amotoki | in my env, it works well with apache2 httpd. when I clicked "Create Firewall Group" the form appeared expectedly | 06:57 |
| amotoki | did you all run the final two steps in here? https://docs.openstack.org/neutron-fwaas-dashboard/latest/install/index.html | 06:57 |
| amotoki | collectstatic and compress | 06:57 |
| amotoki | when I shared the steps with yushiro, the steps were included | 06:58 |
| amotoki | SridarK: I confirmed your point (None for ingress/egress for FWG) | 06:59 |
| SridarK | amotoki: ah yes - i did not - i just followed the email - i think i missed these | 06:59 |
| amotoki | SridarK: could you try them and then restart apache2? | 07:00 |
| amotoki | I am not sure it affects but it might be related. | 07:00 |
| yushiro_afk | amotoki, SridarK If we specify 'ingress_firewall_policy_id' None, context is as follows: | 07:02 |
| yushiro_afk | {'ingress_firewall_policy_id': u | 07:02 |
| yushiro_afk | ''} | 07:02 |
| reedip | SridarK : We also cannot modify the ports on which FWG has been created once ( mentioned in the etherpad ) | 07:03 |
| SridarK | amotoki: just tried - but i still have an issue with Create | 07:04 |
| SridarK | yushiro_afk: ok | 07:06 |
| yushiro_afk | So, I think it's better to replace https://review.openstack.org/#/c/475840/20/neutron_fwaas_dashboard/dashboards/project/firewalls_v2/forms.py@166 and 167 | 07:11 |
| yushiro_afk | egress_policy_id_choices.append((None, _('None'))) | 07:12 |
| yushiro_afk | ah, sorry. This fix it not good. | 07:12 |
| yushiro_afk | ah, it's OK | 07:13 |
| yushiro_afk | just fixed. | 07:13 |
| SridarK | yushiro_afk: yes i think that should do it | 07:13 |
| *** sarathmekala__ has quit IRC | 07:18 | |
| SridarK | yushiro_afk: i will step away now and check back in the morn, i think if sarathmekala_ fixes any pending UT issues - we have a chance to make it | 07:19 |
| yushiro_afk | I'll update once with some critical issues. | 07:19 |
| yushiro_afk | SridarK, OK, I see. | 07:19 |
| *** sarathmekala__ has joined #openstack-fwaas | 07:20 | |
| *** eezhova has quit IRC | 07:21 | |
| SridarK | yushiro_afk: thx | 07:21 |
| amotoki | I might find a problem of the cause of Create Firewall Group loading forever | 07:25 |
| amotoki | coudl you add the following to /opt/stack/horizon/openstack_dashboard/local/enabled/_1461_project_firewalls_v2_panel.py ? | 07:26 |
| -amotoki- ADD_INSTALLED_APPS = ['neutron_fwaas_dashboard'] | 07:26 | |
| -amotoki- AUTO_DISCOVER_STATIC_FILES = True | 07:26 | |
| amotoki | then run collectstatic, compress and restart apache2 | 07:26 |
| amotoki | this is what we have for fwaas v1 stuff and they are required for horizon plugins. when I tested last, I also had 'enabled' file for fwaas v1 dashboard. | 07:27 |
| amotoki | yushiro_afk and others: ^^ might help you | 07:29 |
| yushiro_afk | thanks ! I'll try it | 07:31 |
| yushiro_afk | amotoki, yes, I copied /opt/stack/horizon/openstack_dashboard/local/enabled/_1461_project_firewalls_v2_panel.py | 07:33 |
| amotoki | yushiro_afk: also http://paste.openstack.org/show/619131/ pehaps will fix an issue when creating a firewall group without ingress/egress_firwall_policy_id | 07:33 |
| amotoki | will be afk around up to 30mins | 07:35 |
| reedip | amotoki ; | 07:40 |
| reedip | amotoki ; where would the clean be called from? ? Just curious | 07:41 |
| amotoki | reedip: you can read the django form document :) workflows.Step inherits django.forms.Form | 07:47 |
| amotoki | reedip: the document is https://docs.djangoproject.com/en/1.11/ref/forms/validation/ | 07:47 |
| reedip | Thanks amotoki , will do :) | 07:47 |
| yushiro_afk | I can see create firewall group and 'add policy' view after executed amotoki 's procedure :) | 07:48 |
| *** eezhova has joined #openstack-fwaas | 07:49 | |
| amotoki | yushiro_afk: could you upload a new version after updating 'enabled' file and clean() one? | 07:51 |
| amotoki | yushiro_afk: I think it is good time to sync the code base | 07:51 |
| yushiro_afk | OK. but clean() doen's work correctly... | 07:51 |
| amotoki | mmm | 07:52 |
| *** yushiro_afk is now known as yushiro | 07:55 | |
| *** openstackgerrit has quit IRC | 08:03 | |
| amotoki | yushiro: how did not clean() work correctly? | 08:15 |
| yushiro | if ingress_policy None, then error occurred. '' is not valid UUID. | 08:20 |
| sarathmekala__ | yushiro, on the plugin side do you accept None for egress_policy_id/ingress_policy_id? | 08:20 |
| yushiro | sarathmekala__, yes. Problem is request body generated as follows: {'ingress_firewall_policy_id': ''} | 08:21 |
| sarathmekala__ | amotoki, clean logic should set it to None right? | 08:22 |
| amotoki | sarathmekala__: I believe so | 08:22 |
| amotoki | yushiro: could you add some debug log to neutron_fwaas_dashboard/dashboards/project/firewalls_v2/workflows.py AddFirewallGroup:handle() | 08:23 |
| yushiro | Yeees, just a moment | 08:23 |
| amotoki | something like LOG.info('#### context = %s', context) before calling firewall_group_create | 08:23 |
| sarathmekala__ | yushiro, you can try pdb as well.. it works with tox | 08:23 |
| amotoki | perhaps in your default settings, LOG.debug will be ignored. | 08:23 |
| amotoki | sarathmekala__: we are debugging in the real env under apache2 | 08:24 |
| sarathmekala__ | ok | 08:24 |
| amotoki | I am not sure we can attach the apache2 horizon code from pdb | 08:24 |
| amotoki | honestly I've never used pdb :) | 08:24 |
| yushiro | wow ! | 08:25 |
| sarathmekala__ | :) .. we can give it a shot and see | 08:25 |
| yushiro | amotoki, sarathmekala__ FPFP: context = {'name': u'admin', 'admin_state_up': True, 'ingress_firewall_policy_id': u'None', 'shared': False, 'egress_firewall_policy_id': u'None', 'description': u''} | 08:28 |
| yushiro | I changed 'ingress_firewall_policy_id' None | 08:28 |
| amotoki | yushiro: ah, got it. my clean() assume 'ingress_firewall_policy_id' = ''. | 08:29 |
| amotoki | I think that's the reason http://paste.openstack.org/show/619131/ | 08:30 |
| *** openstackgerrit has joined #openstack-fwaas | 08:30 | |
| openstackgerrit | Elena Ezhova proposed openstack/neutron-fwaas master: Fix router update on L3 agent restart https://review.openstack.org/495657 | 08:30 |
| amotoki | see L.347 of the paste | 08:30 |
| sarathmekala__ | ^^ one more thing 'None' is a string... should it not be NOne | 08:30 |
| amotoki | If you want to use 'None', replace "if not cleaned_data[field]" to "if cleaned_data[field] == 'None'" | 08:31 |
| amotoki | anyway a string 'None' cannot be passed to the neutron server. | 08:31 |
| yushiro | amotoki, aaa!! sorry. I changed default value '' to 'None' in my local. | 08:32 |
| yushiro | However, self.initial stores as follows: FPFP: self.initial = {u'status': u'INACTIVE', 'ingress_policy': None, 'firewallgroup_id': u'b169d282-9b14-4b6 | 08:33 |
| yushiro | 3-93b4-fcbd450105dc', u'description': u'', u'admin_state_up': True, u'tenant_id': u'30c26e78d3b3495da18f36cbc0c897fe', u'ingress_firewall_policy_id': None, u'ports': [], 'egress_policy': <Policy: {u'desc | 08:33 |
| yushiro | ription': u'', u'firewall_rules': [u'0871f043-e569-4316-81c3-a520dc3658d0'], u'tenant_id': u'b85e682ce25e4b079c01da1da9970c6e', u'audited': False, u'shared': True, u'project_id': u'b85e682ce25e4b079c01da | 08:33 |
| yushiro | 1da9970c6e', u'id': u'497281dd-0adb-4792-bcfd-041fef0d1144', u'name': u'policy'}>, 'admin_state': 'UP', u'shared': False, u'project_id': u'30c26e78d3b3495da18f36cbc0c897fe', u'id': u'b169d282-9b14-4b63-9 | 08:33 |
| yushiro | 3b4-fcbd450105dc', u'egress_firewall_policy_id': u'497281dd-0adb-4792-bcfd-041fef0d1144', u'name': u'fwgaaaaaaaaaaaaaaa'} | 08:33 |
| *** SridarK has quit IRC | 08:34 | |
| yushiro | So, initial value: None, chose value 'None': '', expected to convert: None | 08:34 |
| amotoki | yushiro: self.initial has pure python representation so you see None as a primitive | 08:34 |
| amotoki | yushiro: on the other hand, if field values are post from the form, they are all strings | 08:35 |
| *** yamamoto has quit IRC | 08:35 | |
| amotoki | Python None will be converted into a string "None" | 08:35 |
| yushiro | amotoki, Indeed. | 08:35 |
| sarathmekala__ | amotoki, right | 08:35 |
| amotoki | so clean() or clean_<field>() needs to take care of them | 08:35 |
| yushiro | amotoki, quick question. __init__ handles ingress_policy_id_choices.append(('', _('None'))) | 08:36 |
| yushiro | if clean() is called after __init__, should we convert ingress_policy_id_choices.append((None, _('None'))) ? | 08:36 |
| amotoki | yushiro: no, the code in __init__() populates the drop-down menu. | 08:37 |
| amotoki | yushiro: it is called both when GET and POST are called | 08:37 |
| amotoki | yushiro: on the other hand, clean() is called only when POST is called. | 08:38 |
| amotoki | ingress_policy_id_choices.append(('', _('None'))) means that '' is sent back to the web server if _("None") is selected | 08:38 |
| yushiro | amotoki, I see. | 08:38 |
| yushiro | So, I'd like to judge initial value(None) and selected 'None' ('') | 08:39 |
| yushiro | If initial value is None and selected value is 'None', I think there is 'NO CHN | 08:40 |
| yushiro | NO CHANGE | 08:40 |
| sarathmekala__ | yes | 08:44 |
| *** njohnston has quit IRC | 08:47 | |
| reedip | * too much info * | 08:47 |
| *** njohnston has joined #openstack-fwaas | 08:47 | |
| yushiro | If clean() works correctly, no need to conver in handle(), right? | 08:53 |
| sarathmekala__ | i think clean() is called before handle(), amotoki can confirm | 08:56 |
| amotoki | clean() is called before handle() is called. | 08:57 |
| yushiro | amotoki, call() is not called... Maybe I'm wrong with nest. | 08:59 |
| amotoki | call? | 08:59 |
| yushiro | aaa | 08:59 |
| yushiro | clean( | 08:59 |
| *** yamamoto has joined #openstack-fwaas | 08:59 | |
| amotoki | even when POST? | 09:00 |
| yushiro | just a moment | 09:02 |
| amotoki | do we need some kind of video conf like appear.io to share a screen? | 09:02 |
| yushiro | amotoki, OK!!, it called and work successfully | 09:03 |
| amotoki | nice! | 09:03 |
| yushiro | sorry I tried PUT not POST ... | 09:03 |
| yushiro | OK, I'll update current version. | 09:03 |
| amotoki | yushiro: do you send http request manually?? | 09:04 |
| yushiro | no, I tried using 'update firewall group' button | 09:04 |
| amotoki | i see | 09:07 |
| sarathmekala__ | super | 09:08 |
| amotoki | i think we need similar fix in other places like update firewall group too | 09:08 |
| amotoki | but it looks better to sync our code once | 09:09 |
| amotoki | it is important to use a single code base | 09:09 |
| yushiro | yes, | 09:09 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas-dashboard master: FWaaS V2 Horizon Dashboard https://review.openstack.org/475840 | 09:15 |
| yushiro | Sorry for late!!!! | 09:15 |
| yushiro | Sorry, I have to go out my office some task.... will turn back at night ;( | 09:16 |
| sarathmekala__ | yushiro, np.. I will jump in once I reach back home | 09:18 |
| amotoki | yushiro: what is the current status of the above? | 09:19 |
| amotoki | I will update the patch based on patch set 21. | 09:22 |
| amotoki | at least 'enabled' file needs to be updated. | 09:22 |
| amotoki | mmm.... devstack/plugins.sh disappears.... | 09:23 |
| amotoki | what happened? | 09:23 |
| yushiro | amotoki, ohhhhhh, am I missing something. | 09:24 |
| amotoki | yushiro: no. it seems to happen in some older patch set | 09:25 |
| yushiro | so sorry, it seems to be reverted enabled file. _7010_project_firewalls_panel.py is the latest | 09:26 |
| amotoki | np. will cover it | 09:26 |
| yushiro | _7010 includes ADD_INSTALLED_APPS = ['neutron_fwaas_dashboard'] | 09:26 |
| yushiro | and AUTO_DISCOVER_STATIC_FILES = True So, no need to add new file I think. | 09:26 |
| amotoki | actually v1 and v2 panels check neutron extension availability, so we can enable both :) | 09:27 |
| amotoki | it is okay to copy all enabled files | 09:27 |
| yushiro | aha :) OK. | 09:29 |
| yushiro | OK, see you guys!! I'll be back!!! | 09:29 |
| openstackgerrit | Akihiro Motoki proposed openstack/neutron-fwaas-dashboard master: FWaaS V2 Horizon Dashboard https://review.openstack.org/475840 | 09:52 |
| amotoki | ANNOUNCE on neutron-fwaas-dashboard: I updated 'enabled' file. from now on, copy all _70* enabled files under neutron_fwaas_dashboard/enabled to /opt/stack/horizon/openstack_dashboard/local/enabled | 09:53 |
| amotoki | _1461_project_firewalls_v2_panel.py is also need to be removed. | 09:53 |
| amotoki | i have no plan to touch the dashboard code in next couple of hours. feel free to try/fix/improve it, folks! | 09:56 |
| reedip | Guys, do update the etherpad as well, thanks :) | 09:59 |
| amotoki | reedip: about which points? | 10:00 |
| reedip | amotoki like fwg#6 and #7 ? | 10:01 |
| amotoki | reedip: i see | 10:01 |
| reedip | amotoki : I commented on some of the issues where I can see that the stuff is working now. But I am not removing it , so that the points can be cross-verified before removing them | 10:02 |
| reedip | There were certain minor issue(s) like fwr#6 and fwr#7 , but maybe they can be checked later | 10:02 |
| amotoki | reedip: some information on which patch set you used would be helpful | 10:03 |
| reedip | Patch set #21. | 10:04 |
| reedip | I also have snapshots | 10:04 |
| amotoki | like L.110 as well. is it from you? | 10:04 |
| amotoki | IMHO still in question for a release... | 10:05 |
| amotoki | is anyone wokring on UT fix? | 10:06 |
| reedip | amotoki : added the PS for L:#110 and L#104 in the etherpad | 10:07 |
| amotoki | as long as UT fails, we cannot merge it :) | 10:27 |
| *** hoangcx has quit IRC | 10:29 | |
| amotoki | sarathmekala__: do you have time to fix UT failures? | 10:31 |
| amotoki | In JP side, normal office hours were over and we don't think we have enough to work on it. | 10:31 |
| *** sarathmekala__ has quit IRC | 10:35 | |
| *** sarathmekala__ has joined #openstack-fwaas | 10:35 | |
| *** hoangcx has joined #openstack-fwaas | 10:35 | |
| *** hoangcx has quit IRC | 10:39 | |
| reedip | amotoki: is the release cut tomorrow morning JP side? | 10:42 |
| amotoki | reedip: it is not decided exactly, but the release timing affects several folks out side of fwaas team | 10:43 |
| amotoki | so it should be done with enough time margin | 10:43 |
| amotoki | (including members of the release team, neutron-release team) | 10:44 |
| reedip | amotoki : I am not proficient in Horizon , so I will check the UT failures as much as I can , but I do hope other members come up soon :) | 10:44 |
| amotoki | I have no plan to coordinate the exact timing. if the deadline is gone, that's all. | 10:44 |
| reedip | amotoki : ok, thanks ... | 10:45 |
| amotoki | test_data for FWaaS v2 looks like contain unrelated feilds..... | 10:45 |
| amotoki | some v1 specific attribute..... | 10:45 |
| amotoki | I tend to give up checking such details. | 10:46 |
| amotoki | reedip: hopefully you can check API data here is correct first https://review.openstack.org/#/c/475840/22/neutron_fwaas_dashboard/test/test_data/fwaas_data_v2.py | 10:46 |
| amotoki | reedip: i am checking but i need to go soon | 10:47 |
| amotoki | also I noticed ingress/egress_firewall_policy_id is missing in firewall group data | 10:48 |
| amotoki | some cross check and comments on gerrit would be helpful | 10:48 |
| amotoki | if you want to dump API responses, oscurl is useful. | 10:53 |
| amotoki | oscurl -f json -s network -p /v2.0/fwaas/firewall_rules/660f0134-b4b0-4c3d-b6d3-b7ce4e1358c0 | 10:53 |
| *** sarathmekala__ has quit IRC | 11:05 | |
| *** yamamoto has quit IRC | 11:11 | |
| *** yamamoto has joined #openstack-fwaas | 11:18 | |
| *** yamamoto has quit IRC | 11:36 | |
| *** yamamoto has joined #openstack-fwaas | 11:40 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-fwaas master: Updated from global requirements https://review.openstack.org/496051 | 12:14 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-fwaas-dashboard master: Updated from global requirements https://review.openstack.org/494855 | 12:14 |
| amotoki | UpdateFirewallGroup failure is caused by _get_request_body() introduced in PS21 | 12:19 |
| amotoki | _get_request_body() normalizes an empty string to None, but it applies to string fields like name or description. | 12:20 |
| amotoki | It tries to send None (JSON null) as name/description and neutron server returns an exception. | 12:20 |
| amotoki | that's all from me. | 12:23 |
| amotoki | my current vote is to defer the v2 dashboard to Queens | 12:24 |
| amotoki | if this is proposed to horizon, considering the current maturity of the code, FFE would be rejected with 100%. | 12:32 |
| openstackgerrit | Akihiro Motoki proposed openstack/neutron-fwaas-dashboard master: FWaaS V2 Horizon Dashboard https://review.openstack.org/475840 | 12:56 |
| openstackgerrit | Akihiro Motoki proposed openstack/neutron-fwaas-dashboard master: FWaaS V2 Horizon Dashboard https://review.openstack.org/475840 | 12:58 |
| openstackgerrit | Akihiro Motoki proposed openstack/neutron-fwaas-dashboard master: FWaaS V2 Horizon Dashboard https://review.openstack.org/475840 | 13:01 |
| amotoki | I posted all I have now. good luck | 13:03 |
| *** reedip_ has joined #openstack-fwaas | 13:45 | |
| *** sarathmekala__ has joined #openstack-fwaas | 13:56 | |
| reedip_ | o/ | 13:58 |
| xgerman_ | o/ | 14:03 |
| sarathmekala__ | o/ | 14:04 |
| *** yushiro2 has joined #openstack-fwaas | 14:10 | |
| yushiro2 | I'm home. | 14:11 |
| yushiro2 | sarathmekala__, ping :) | 14:11 |
| *** reedip_ has quit IRC | 14:11 | |
| sarathmekala__ | hi yushiro2 | 14:11 |
| yushiro2 | sarathmekala__, Hi. sorry for late. | 14:11 |
| sarathmekala__ | np.. I too just reached home | 14:12 |
| yushiro2 | sarathmekala__, wow, I saw the patch set 25 :) | 14:12 |
| yushiro2 | I just applied PS25 in my local env now. | 14:12 |
| yushiro2 | will test more. | 14:12 |
| *** eezhova has quit IRC | 14:12 | |
| sarathmekala__ | sure.. I too will mark the issue i am working on in the etherpad | 14:13 |
| sarathmekala__ | yushiro2, when you pull in a new patch, does pip install update the old files? | 14:15 |
| yushiro2 | sarathmekala__, ah yes. I always do as following steps: | 14:16 |
| yushiro2 | 1. git checkout master | 14:16 |
| yushiro2 | 2. git review -d <your_owesome_patch> | 14:16 |
| amotoki | yushiro2: master of what? | 14:16 |
| yushiro2 | amotoki, neutron-fwaas-dashboard repos | 14:16 |
| sarathmekala__ | ok.. do you repeat the same in the next rounds as well | 14:17 |
| amotoki | yushiro2: okay. actually git checkout master is optional | 14:17 |
| yushiro2 | sarathmekala__, yes. | 14:18 |
| sarathmekala__ | hmm.. how are you patching your horizon then? | 14:18 |
| sarathmekala__ | pip install? | 14:18 |
| amotoki | the etherpad instruction says "pip install .", so you need to install fwaas dashboard again | 14:19 |
| amotoki | if you use pip install -e . you don't need to install fwaas-dashboard again. | 14:19 |
| yushiro2 | sarathmekala__, I'm executing 'git review -d <change-id>' and 'sudo pip install .' in neutron-fwaas-dashboard | 14:19 |
| amotoki | git review -d <xxx> | 14:19 |
| amotoki | is enough if so. | 14:20 |
| yushiro2 | sarathmekala__, I think amotoki is always true :) | 14:20 |
| sarathmekala__ | yushiro2, got it | 14:20 |
| sarathmekala__ | amotoki, knows tricks of the trade ;) | 14:20 |
| amotoki | it is not a tricky. it is a well-known behavior of pip install. | 14:21 |
| sarathmekala__ | ok... lets take a quick consensus.. on the testing so far | 14:22 |
| sarathmekala__ | 1. Rules have been tested fully | 14:22 |
| sarathmekala__ | 2. Policy CRUD is tested as well | 14:22 |
| sarathmekala__ | is the issue related to policy creation solved? | 14:23 |
| sarathmekala__ | or it is the same as FWG (showing a spinner and waiting infinitely) | 14:23 |
| amotoki | if we specify rules when creating a policy, the rule specified are ignored completely. I see this problem | 14:24 |
| amotoki | so Policy create has some problem I think | 14:24 |
| yushiro2 | amotoki, sarathmekala__ what is problem while creating policy? | 14:25 |
| amotoki | I would suggest you all check the etherpad page from top to bottom to check what have been addressed and what not. | 14:25 |
| amotoki | I don't think it is a good idea to create another list like above | 14:25 |
| sarathmekala__ | amotoki, sure.. but we need to have a clear checklist at the top | 14:26 |
| sarathmekala__ | will add it to the etherpad to tick off things | 14:26 |
| yushiro2 | amotoki, yes, I would have I made test cases for each resources.... | 14:26 |
| amotoki | how to summarize the situations are all up to you | 14:27 |
| yushiro2 | amotoki, sarathmekala__ well, now I attached PS25, I'm verifying all of etherpad cases now. | 14:27 |
| sarathmekala__ | ok.. thanks yushiro2 | 14:28 |
| amotoki | yushiro2: sarathmekala__: a problem while creating a policy I mean: we see 'Rules' tab in the creating policy form. I can select some rule(s), but I see no rules are associated with the created policy.... | 14:28 |
| sarathmekala__ | amotoki, ok.. I will check this functionality | 14:29 |
| yushiro2 | amotoki, OK, that seems generated request body is wrong.. | 14:29 |
| amotoki | perhaps so. I've investigated nothing on it. | 14:29 |
| sarathmekala__ | ok | 14:30 |
| *** SridarK has joined #openstack-fwaas | 14:30 | |
| SridarK | yushiro: sarathmekala__ how are things ? | 14:31 |
| amotoki | it is good to check the current work items, but we need to remember what the criteria are for the release. is it clear? | 14:31 |
| SridarK | I have some mtgs early but then i can pick up the latest patch | 14:31 |
| yushiro2 | SridarK, Now are PS25. It has still some issues. Now I'm checking each cases on etherpad. | 14:32 |
| SridarK | amotoki: thx i see u have multiple updates too | 14:32 |
| amotoki | The release is not for developers. It is for end-users (which is the targets) | 14:32 |
| *** eezhova has joined #openstack-fwaas | 14:32 | |
| sarathmekala__ | SridarK, I have created a checklist in the etherpad.. if yushiro/amotoki/redeep/you can mark the areas you verified we will have a consice overview | 14:32 |
| SridarK | yushiro2: ok | 14:32 |
| SridarK | sarathmekala__: ok | 14:32 |
| amotoki | so if we deliver a release, it needs to be a quality where end-users can use it | 14:33 |
| amotoki | I cannot work on the dashboard more until Friday afternoon. | 14:33 |
| amotoki | I would like to delegate the final decision and the responsibility of taking care of the release patch https://review.openstack.org/#/c/496307/ to yushiro2/SridarK/xgerman_ | 14:34 |
| SridarK | amotoki: +1 | 14:35 |
| SridarK | amotoki: thx for all the help | 14:35 |
| sarathmekala__ | +1 | 14:35 |
| xgerman_ | +1 | 14:35 |
| SridarK | sarathmekala__: i think the checklist is good first pass on basic workflow - i think i have gone thru these with PS 19 | 14:36 |
| yushiro2 | amotoki, Thank you so much for your help. | 14:36 |
| amotoki | thanks. I have various schedules tomorrow | 14:36 |
| amotoki | I am here so feel free to ask me if there are questions | 14:36 |
| SridarK | The Create on FWG and policy were the issues i ran into | 14:37 |
| SridarK | I will repeat with PS25 | 14:37 |
| sarathmekala__ | SridarK, ok | 14:37 |
| amotoki | Some ANNOUNCEMETN again: you need to update 'enabled' files for horizon plugin. see L.189-190 of the etherpad for more detail when you try PS23 or later (including PS25) | 14:38 |
| amotoki | It will address an issue on clicking Create FWG and policy button | 14:39 |
| amotoki | at least it worked for me and yushiro | 14:39 |
| SridarK | amotoki: thx - i will try that in a bit as well | 14:45 |
| *** SarathMekala has joined #openstack-fwaas | 14:54 | |
| *** sarathmekala__ has quit IRC | 14:54 | |
| amotoki | xgerman, SridarK, yushiro: can some of you put -W on https://review.openstack.org/#/c/496307/ ? | 14:59 |
| amotoki | I can remove my -W and you can make decision anytime you want without clearing my -W. | 15:00 |
| *** yamamoto has quit IRC | 15:09 | |
| xgerman_ | hu, only have +/-1 powers | 15:11 |
| xgerman_ | probably not part of OpenStacj releases | 15:12 |
| amotoki | xgerman_: ah, i see. totally forgot it | 15:18 |
| amotoki | I will be in the channel tomorrow too, so I can clear -W | 15:19 |
| xgerman_ | ok | 15:21 |
| xgerman_ | thanks | 15:21 |
| *** yamamoto has joined #openstack-fwaas | 15:21 | |
| SarathMekala | after applying amotoki suggestion I am able to see the create FWG and create policy popup windows.. hope its working for all | 15:25 |
| *** yamamoto has quit IRC | 15:32 | |
| *** yamamoto has joined #openstack-fwaas | 15:33 | |
| *** yushiro2 has quit IRC | 15:41 | |
| *** sarathmekala_ has joined #openstack-fwaas | 15:47 | |
| *** SarathMekala has quit IRC | 15:48 | |
| *** reedip has quit IRC | 15:50 | |
| *** yamamoto has quit IRC | 15:57 | |
| *** SarathMekala has joined #openstack-fwaas | 16:00 | |
| *** sarathmekala_ has quit IRC | 16:02 | |
| *** reedip has joined #openstack-fwaas | 16:02 | |
| *** sarathmekala_ has joined #openstack-fwaas | 16:04 | |
| *** SarathMekala has quit IRC | 16:06 | |
| *** eezhova has quit IRC | 16:24 | |
| openstackgerrit | Merged openstack/neutron-fwaas master: Don't return 404 when deleting a non-existant FWG https://review.openstack.org/494034 | 17:28 |
| sarathmekala_ | yushiro, u around? | 17:33 |
| *** sarathmekala_ has quit IRC | 17:39 | |
| *** sarathmekala_ has joined #openstack-fwaas | 17:40 | |
| sarathmekala_ | guys... I see one issue | 17:40 |
| sarathmekala_ | the class FirewallRuleV2 in the plugin db does not have the 'description' field | 17:40 |
| sarathmekala_ | so when we send {"description":None} from the UI, the backend is rejecting it as not valid | 17:41 |
| amotoki | sarathmekala_: it is actually not correct. as you see, you can set description when creating a resource and see the value in the detail page | 17:44 |
| amotoki | sarathmekala_: did you check my comment on the gerrit review? https://review.openstack.org/#/c/475840/22/neutron_fwaas_dashboard/dashboards/project/firewalls_v2/forms.py@395 | 17:45 |
| amotoki | sarathmekala_: this describes why | 17:45 |
| sarathmekala_ | exactly.. | 17:47 |
| sarathmekala_ | for name and description should an empty value be '' | 17:47 |
| amotoki | sarathmekala_: i think yushiro introduced it to handle all fields in the same way but it does a bit too much. | 17:48 |
| amotoki | sarathmekala_: yeah, exactly | 17:48 |
| sarathmekala_ | ok... rule update is also failing because of it | 17:48 |
| sarathmekala_ | when i have description blank or clear out the description | 17:48 |
| amotoki | sarathmekala_: perhaps I think it is better to add an argument to _get_request_body which specifies which fields should be treated specially (i.e., an empty value should be converted into None) | 17:49 |
| sarathmekala_ | or the other way.. | 17:51 |
| sarathmekala_ | i think we will have a smaller set | 17:51 |
| amotoki | yeah, any way works | 17:51 |
| sarathmekala_ | for ex: name, description | 17:52 |
| amotoki | Look at https://developer.openstack.org/api-ref/networking/v2/index.html?expanded=id284-detail#id284 | 17:53 |
| amotoki | you can see several updatable fields, but fields which accepts None is not so many | 17:53 |
| amotoki | I see only four such fields: destination_ip_address, destination_port, source_ip_address, source_port | 17:54 |
| amotoki | another way is to normalize them in clean() method in the form. this is more beautiful and straight-forward to me, but it needs some django knowledge from its doc | 17:55 |
| sarathmekala_ | actually the logic in the handle method takes care of these 4 | 17:56 |
| sarathmekala_ | and sets them to None if not specified | 17:56 |
| sarathmekala_ | for ex: look at forms.py UpdateRules handle method | 17:57 |
| amotoki | yeah, it works. | 17:58 |
| amotoki | IMHO basically handle() should focus on the logic and clean() / clean_<field>() is responsible for data format/type, but you can do all in handle(). | 17:59 |
| sarathmekala_ | ok.. we can clean this up going forward in the next cycle :) | 17:59 |
| amotoki | however, it is the implementation approach discussion and at now what we need is the working code | 17:59 |
| amotoki | so I am okay with either | 18:00 |
| sarathmekala_ | right | 18:00 |
| sarathmekala_ | i think the purpose of _get_request_body shoudl be to reduce the payload by removing unmodified attributes | 18:00 |
| amotoki | exactly | 18:01 |
| amotoki | converting '' to None is not the main purpose | 18:01 |
| sarathmekala_ | after doing this change: | 18:06 |
| sarathmekala_ | def _get_request_body(context, initial_values): | 18:06 |
| sarathmekala_ | body = {} | 18:06 |
| sarathmekala_ | for key, value in context.items(): | 18:06 |
| sarathmekala_ | if value != initial_values[key]: | 18:06 |
| sarathmekala_ | body[key] = value | 18:06 |
| sarathmekala_ | return body | 18:06 |
| sarathmekala_ | rule updation is working | 18:07 |
| sarathmekala_ | i will check the other flows | 18:07 |
| sarathmekala_ | ^^ this modification is in forms.py | 18:07 |
| sarathmekala_ | existing method updated | 18:07 |
| *** eezhova has joined #openstack-fwaas | 18:42 | |
| *** eezhova has quit IRC | 18:45 | |
| *** sarathmekala_ has quit IRC | 19:05 | |
| *** SridarK has quit IRC | 19:07 | |
| *** eezhova has joined #openstack-fwaas | 19:56 | |
| *** eezhova has quit IRC | 20:33 | |
| *** sarathmekala_ has joined #openstack-fwaas | 22:01 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-fwaas master: Updated from global requirements https://review.openstack.org/496051 | 23:29 |
| *** yushiro2 has joined #openstack-fwaas | 23:47 | |
| yushiro2 | morning. sarathmekala_ Sorry for yesterday. I took care of my wife and fall asleep last night. | 23:48 |
| yushiro2 | team, today I leave my office and am in another office. If you ask me something, please reach out me in IRC or e-mail(y.furukawa8@gmail.com) | 23:49 |
| yushiro2 | I cannot see company e-mail.. | 23:50 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!