| *** yamamoto_ has joined #openstack-fwaas | 00:13 | |
| *** yamamoto_ has quit IRC | 00:13 | |
| *** yushiro has joined #openstack-fwaas | 00:34 | |
| *** yamamoto_ has joined #openstack-fwaas | 01:14 | |
| *** yamamoto_ has quit IRC | 01:20 | |
| openstackgerrit | Hunt Xu proposed openstack/neutron-fwaas master: Use configurable conntrack driver in fwaas_v2 https://review.openstack.org/489980 | 01:30 |
|---|---|---|
| *** yamamoto_ has joined #openstack-fwaas | 02:16 | |
| *** yamamoto_ has quit IRC | 02:22 | |
| *** bzhao has joined #openstack-fwaas | 02:43 | |
| *** yamamoto has joined #openstack-fwaas | 02:49 | |
| *** bbzhao has joined #openstack-fwaas | 02:53 | |
| *** bzhao has quit IRC | 02:53 | |
| *** reedip_ has quit IRC | 03:01 | |
| *** yamamoto has quit IRC | 03:12 | |
| *** yamamoto has joined #openstack-fwaas | 04:13 | |
| *** yamamoto has quit IRC | 04:19 | |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Fix validation with 'protocol' for firewall_rule https://review.openstack.org/423229 | 04:29 |
| reedip | yushiro : ping | 04:46 |
| yushiro | reedip, pong | 04:46 |
| openstackgerrit | Adit Sarfaty proposed openstack/neutron-fwaas master: Use neutron-lib FirewallInternalDriverError https://review.openstack.org/498256 | 05:06 |
| *** yamamoto has joined #openstack-fwaas | 05:15 | |
| *** yamamoto has quit IRC | 05:21 | |
| *** hoangcx has quit IRC | 05:41 | |
| *** hoangcx has joined #openstack-fwaas | 05:42 | |
| *** yamamoto has joined #openstack-fwaas | 06:13 | |
| *** yamamoto has quit IRC | 06:38 | |
| *** yamamoto has joined #openstack-fwaas | 06:39 | |
| *** yamamoto has quit IRC | 06:39 | |
| *** eezhova has joined #openstack-fwaas | 06:44 | |
| openstackgerrit | Merged openstack/neutron-fwaas-dashboard master: Imported Translations from Zanata https://review.openstack.org/497803 | 06:48 |
| reedip | yushiro : hi, have you ever created a network with MTU > actual physical network MTU ? | 07:38 |
| *** yamamoto has joined #openstack-fwaas | 07:40 | |
| *** eezhova has quit IRC | 07:41 | |
| *** yamamoto has quit IRC | 07:45 | |
| yushiro | reedip, hmm no. | 07:52 |
| yushiro | reedip, I think it is validated in ml2 plugin layer. | 07:53 |
| yushiro | it depends type_driver. If you set 'local', it depends on 'global_physnet_mtu' in /etc/neutron/neutron.conf | 07:54 |
| yushiro | reedip, otherwise, it depends on physical environment which you specified as 'physical_network'. | 07:55 |
| yushiro | reedip, You can refer neutron/neutron/plugins/ml2/plugin.py +761 ~ 768 | 07:56 |
| *** eezhova has joined #openstack-fwaas | 08:05 | |
| reedip | thanks yushiro | 08:09 |
| yushiro | eezhova, ping | 08:40 |
| eezhova | yushiro, hi | 08:41 |
| yushiro | eezhova, Thanks for your reply | 08:41 |
| *** yamamoto has joined #openstack-fwaas | 08:42 | |
| yushiro | eezhova, Let me explain a reason why I said to specify 'set' as a type in docstring. | 08:42 |
| yushiro | eezhova, I thought it is more easy to understand in case of writing test codes. I think it's better to align with a type of arguments for testing. | 08:43 |
| yushiro | eezhova, Could you tell me your opinion? | 08:44 |
| eezhova | yushiro, Hmm, yes, I agree about the tests. It is possible to write a test that would work for all iterable types but it would look more complex | 08:46 |
| eezhova | yushiro, it's not worth it, I guess.. | 08:46 |
| *** yamamoto has quit IRC | 08:47 | |
| eezhova | yushiro, I'll update the patch per your comments then | 08:47 |
| yushiro | eezhova, oh, just a moment, please. | 08:47 |
| yushiro | eezhova, what is 'more complex' ? You mean it's enough to specify 'iterable' ? | 08:50 |
| eezhova | yushiro, I mean that it would be needed to change the test to validate call args separately (smth like I was trying to do in PS3) and additionally iterate over port_ids elements to check that they are the same as expected ones. | 08:55 |
| eezhova | that's because we can't just make assertEqual for two iterables | 08:57 |
| yushiro | eezhova, Ah, yes. In PS3 you wrote self._invoke_driver_for_sync_from_plugin( | 09:02 |
| yushiro | ctx, list(ports_to_process), firewall_group). Hence, it seems complexity in test codes. | 09:02 |
| yushiro | eezhova, So no need to convert list() for the argument. | 09:03 |
| eezhova | yushiro, yep, set is unordered, hence the resulting list could also have different order from what was expected in a test | 09:03 |
| yushiro | eezhova, Yes. In detail, list stores() an order but set() doesn't store an order. Anyway, what I want to say is | 09:04 |
| eezhova | hm, in fact I checked - assertItemsEqual seems to work with different iterables | 09:07 |
| eezhova | https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertItemsEqual | 09:07 |
| yushiro | oh, OK. | 09:08 |
| yushiro | eezhova, 'iterable' includes wide meanings. E.g. if we specify dict() or ordereddict(), what's happen? It only evaluated 'key' and ignored 'value'... | 09:09 |
| yushiro | I think this method doesn't need to care about 'order', so it's OK to use assertCountEqual (assertItemsEqual) for testing. | 09:10 |
| *** reedip has quit IRC | 09:12 | |
| yushiro | eezhova, How about specifying 'ID of ports' (list or set) or something? | 09:12 |
| *** reedip has joined #openstack-fwaas | 09:12 | |
| eezhova | yushiro, For dictionary it should also work fine as it is iterable and by default we would iterate over its keys | 09:20 |
| yushiro | eezhova, Yes, but we cannot solve in a flash that only 'key' is evaluated after read current docstring. So, I think it's better to limit available argument type. | 09:24 |
| yushiro | In fact, dict() or ordereddict() is unexpected case for this method's argument. | 09:25 |
| eezhova | yushiro, yes, it is) okay, lets limit the argument variety | 09:27 |
| yushiro | eezhova, OK. I'll wait your next Patch sets ;) | 09:27 |
| yushiro | eezhova, Thanks for your discussion. Sorry for confusing my English ;( | 09:27 |
| eezhova | yushiro, No confusion at all, your English is really good :) | 09:28 |
| eezhova | I'm not a native speaker as well, btw | 09:28 |
| yushiro | eezhova, Wow, really?? OpenStack contributers except me are native for me ;) Haha~ | 09:29 |
| eezhova | yeah, there are not so many native speakers here as it may seem. the OpenStack community is rather diverse :) | 09:32 |
| yushiro | eezhova, +1 | 09:32 |
| openstackgerrit | Elena Ezhova proposed openstack/neutron-fwaas master: Fix router update on L3 agent restart https://review.openstack.org/495657 | 09:34 |
| *** yamamoto has joined #openstack-fwaas | 09:43 | |
| eezhova | yushiro, I got carried away about the test: there is no need to update it with assertItemsEqual and stuff because we don't validate the `_invoke_driver_for_sync_from_plugin` method, we just check that it is called with correct arguments (set in our case). Sorry for confusion | 09:45 |
| *** eezhova is now known as eezhova_afk | 09:45 | |
| *** yamamoto has quit IRC | 09:49 | |
| *** reedip has quit IRC | 09:52 | |
| *** reedip has joined #openstack-fwaas | 09:53 | |
| *** eezhova_afk is now known as eezhova | 10:21 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-fwaas-dashboard master: Imported Translations from Zanata https://review.openstack.org/498751 | 10:43 |
| *** yamamoto has joined #openstack-fwaas | 10:45 | |
| *** yamamoto has quit IRC | 10:51 | |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use neutron-lib FirewallInternalDriverError https://review.openstack.org/498256 | 10:52 |
| *** yushiro has quit IRC | 11:27 | |
| *** yamamoto has joined #openstack-fwaas | 11:47 | |
| *** yamamoto has quit IRC | 11:52 | |
| *** hoangcx_ has joined #openstack-fwaas | 12:17 | |
| *** obre has quit IRC | 12:39 | |
| *** obre has joined #openstack-fwaas | 12:40 | |
| *** obre has quit IRC | 12:42 | |
| *** obre has joined #openstack-fwaas | 12:42 | |
| *** obre has quit IRC | 12:45 | |
| *** obre has joined #openstack-fwaas | 12:46 | |
| *** yamamoto has joined #openstack-fwaas | 12:49 | |
| *** yamamoto has quit IRC | 12:54 | |
| *** SarathMekala has joined #openstack-fwaas | 13:39 | |
| *** yamamoto has joined #openstack-fwaas | 13:50 | |
| *** yamamoto has quit IRC | 13:56 | |
| openstackgerrit | Merged openstack/neutron-fwaas master: Drop MANIFEST.in - it's not needed by pbr https://review.openstack.org/479260 | 13:57 |
| *** yushiro has joined #openstack-fwaas | 13:59 | |
| *** chandanc has joined #openstack-fwaas | 13:59 | |
| *** doude has joined #openstack-fwaas | 14:19 | |
| *** hoangcx_ has quit IRC | 14:31 | |
| *** yamamoto has joined #openstack-fwaas | 14:52 | |
| *** yamamoto has quit IRC | 14:58 | |
| *** chandanc has quit IRC | 15:00 | |
| *** SarathMekala has quit IRC | 15:08 | |
| *** reedip_ has joined #openstack-fwaas | 15:08 | |
| *** yushiro has quit IRC | 15:09 | |
| reedip_ | sorry,my fone switched off | 15:09 |
| *** yushiro has joined #openstack-fwaas | 15:10 | |
| *** yushiro has quit IRC | 15:15 | |
| *** eezhova has quit IRC | 15:18 | |
| *** SarathMekala has joined #openstack-fwaas | 15:32 | |
| *** sarathmekala_ has joined #openstack-fwaas | 15:33 | |
| *** SarathMekala has quit IRC | 15:36 | |
| *** yamamoto has joined #openstack-fwaas | 15:54 | |
| *** eezhova has joined #openstack-fwaas | 15:57 | |
| *** eezhova has quit IRC | 15:57 | |
| *** yamamoto has quit IRC | 16:00 | |
| *** eezhova has joined #openstack-fwaas | 16:00 | |
| *** yamamoto has joined #openstack-fwaas | 16:56 | |
| *** sarathmekala_ has quit IRC | 17:00 | |
| *** yamamoto has quit IRC | 17:02 | |
| *** eezhova has quit IRC | 17:13 | |
| *** eezhova has joined #openstack-fwaas | 17:56 | |
| *** yamamoto has joined #openstack-fwaas | 17:58 | |
| *** eezhova has quit IRC | 17:58 | |
| *** yamamoto has quit IRC | 18:04 | |
| *** eezhova has joined #openstack-fwaas | 18:53 | |
| *** yamamoto has joined #openstack-fwaas | 18:59 | |
| *** yamamoto has quit IRC | 19:05 | |
| *** yamamoto has joined #openstack-fwaas | 19:27 | |
| openstackgerrit | Merged openstack/neutron-fwaas-dashboard master: Imported Translations from Zanata https://review.openstack.org/498751 | 19:42 |
| *** eezhova has quit IRC | 20:54 | |
| openstackgerrit | Merged openstack/neutron-fwaas master: Use neutron-lib FirewallInternalDriverError https://review.openstack.org/498256 | 20:58 |
| openstackgerrit | Merged openstack/neutron-fwaas master: FirewallGroupPortInvalidProject can be raised now https://review.openstack.org/494198 | 20:58 |
| *** yamamoto has quit IRC | 21:04 | |
| *** yamamoto has joined #openstack-fwaas | 21:08 | |
| *** yamamoto has quit IRC | 21:30 | |
| *** yamamoto has joined #openstack-fwaas | 21:32 | |
| *** yamamoto has quit IRC | 21:32 | |
| openstackgerrit | Akihiro Motoki proposed openstack/neutron-fwaas-dashboard master: FWaaS V2 Horizon Dashboard https://review.openstack.org/475840 | 21:39 |
| openstackgerrit | Akihiro Motoki proposed openstack/neutron-fwaas-dashboard master: Clean up unnecessary capitalizations https://review.openstack.org/498964 | 22:09 |
| *** yamamoto has joined #openstack-fwaas | 23:28 | |
| *** yamamoto has quit IRC | 23:46 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!