*** alanf-mc has quit IRC | 00:16 | |
*** alanf-mc has joined #openstack-glance | 00:18 | |
*** TravT has quit IRC | 00:28 | |
*** annegentle has joined #openstack-glance | 00:37 | |
*** annegentle has quit IRC | 00:43 | |
*** ericpeterson has joined #openstack-glance | 00:53 | |
*** annegentle has joined #openstack-glance | 00:54 | |
*** ericpeterson has quit IRC | 00:57 | |
*** ericpeterson has joined #openstack-glance | 00:57 | |
*** ericpeterson has quit IRC | 01:02 | |
*** ericpeterson has joined #openstack-glance | 01:19 | |
*** annegentle has quit IRC | 01:26 | |
*** alanf-mc has quit IRC | 01:46 | |
*** ericpeterson has quit IRC | 02:09 | |
*** annegentle has joined #openstack-glance | 02:13 | |
*** spzala has quit IRC | 02:18 | |
*** annegentle has quit IRC | 02:27 | |
*** annegentle has joined #openstack-glance | 02:35 | |
*** ericpeterson has joined #openstack-glance | 02:40 | |
*** ericpeterson has quit IRC | 03:05 | |
*** annegent_ has joined #openstack-glance | 03:17 | |
*** annegentle has quit IRC | 03:21 | |
*** fifieldt has joined #openstack-glance | 03:25 | |
*** dims has quit IRC | 03:38 | |
*** fifieldt has quit IRC | 03:59 | |
*** annegent_ has quit IRC | 04:18 | |
*** dims has joined #openstack-glance | 04:39 | |
*** dims has quit IRC | 04:45 | |
*** bkopilov has quit IRC | 05:08 | |
*** TravT has joined #openstack-glance | 05:12 | |
*** TravT has quit IRC | 05:17 | |
*** TravT has joined #openstack-glance | 05:32 | |
*** TravT has quit IRC | 05:33 | |
*** TravT_ has joined #openstack-glance | 05:33 | |
*** TravT_ has quit IRC | 05:34 | |
*** TravT has joined #openstack-glance | 05:34 | |
*** TravT has quit IRC | 05:35 | |
*** TravT_ has joined #openstack-glance | 05:35 | |
*** TravT_ has quit IRC | 05:36 | |
*** TravT has joined #openstack-glance | 05:36 | |
*** TravT has quit IRC | 05:37 | |
*** TravT_ has joined #openstack-glance | 05:37 | |
*** TravT_ has quit IRC | 05:44 | |
*** groen692 has joined #openstack-glance | 05:45 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance: Imported Translations from Transifex https://review.openstack.org/176633 | 06:02 |
---|---|---|
*** chlong has quit IRC | 06:21 | |
*** Longgeek_ has joined #openstack-glance | 06:24 | |
*** Longgeek has quit IRC | 06:27 | |
*** alanf-mc has joined #openstack-glance | 06:28 | |
*** chlong has joined #openstack-glance | 06:35 | |
*** TravT has joined #openstack-glance | 06:38 | |
*** TravT has quit IRC | 06:39 | |
*** zul has joined #openstack-glance | 06:44 | |
*** alanf-mc_ has joined #openstack-glance | 06:54 | |
*** alanf-mc has quit IRC | 06:58 | |
*** chlong has quit IRC | 07:02 | |
*** alanf-mc_ has quit IRC | 07:05 | |
*** alanf-mc has joined #openstack-glance | 07:06 | |
*** bkopilov has joined #openstack-glance | 07:18 | |
*** zul has quit IRC | 07:25 | |
*** zul has joined #openstack-glance | 07:25 | |
*** chlong has joined #openstack-glance | 07:26 | |
*** alanf-mc has quit IRC | 07:35 | |
*** chlong has quit IRC | 07:37 | |
*** chlong has joined #openstack-glance | 07:49 | |
*** Longgeek_ has quit IRC | 07:52 | |
*** chlong has quit IRC | 07:53 | |
*** chlong has joined #openstack-glance | 07:55 | |
*** Longgeek has joined #openstack-glance | 07:56 | |
*** arnaud____ has joined #openstack-glance | 07:56 | |
*** chlong has quit IRC | 08:01 | |
*** zul has quit IRC | 08:02 | |
*** zul has joined #openstack-glance | 08:09 | |
*** boris-42 has joined #openstack-glance | 08:13 | |
*** chlong has joined #openstack-glance | 08:19 | |
*** arnaud____ has quit IRC | 08:25 | |
*** zul has quit IRC | 08:31 | |
*** chlong has quit IRC | 08:40 | |
*** Longgeek has quit IRC | 08:46 | |
*** e0ne has joined #openstack-glance | 08:55 | |
*** e0ne has quit IRC | 08:58 | |
*** arnaud____ has joined #openstack-glance | 09:00 | |
*** arnaud____ has quit IRC | 09:05 | |
*** zul has joined #openstack-glance | 09:07 | |
*** sgotliv has joined #openstack-glance | 09:27 | |
*** MattMan has joined #openstack-glance | 09:37 | |
*** sgotliv has quit IRC | 10:02 | |
*** chlong has joined #openstack-glance | 10:14 | |
frickler | I noticed that this channel is not receiving status messages from openstackstatusbot, which I believe would be quite useful in addition to the messages from openstackgerrit | 10:21 |
frickler | please comment at https://review.openstack.org/178709 whether you agree or not | 10:22 |
*** number80 has quit IRC | 10:22 | |
kragniz | frickler: +1! | 10:23 |
kragniz | frickler: thanks for doing that | 10:23 |
*** ayoung has quit IRC | 10:25 | |
*** Miouge has joined #openstack-glance | 10:31 | |
*** ayoung has joined #openstack-glance | 10:37 | |
*** zul has quit IRC | 10:44 | |
*** arnaud____ has joined #openstack-glance | 10:50 | |
*** arnaud____ has quit IRC | 10:54 | |
*** chlong has quit IRC | 11:01 | |
*** chlong has joined #openstack-glance | 11:04 | |
*** chlong has quit IRC | 11:15 | |
*** Miouge has quit IRC | 11:46 | |
*** Miouge has joined #openstack-glance | 11:48 | |
*** delatte has joined #openstack-glance | 11:49 | |
*** ctina_ has joined #openstack-glance | 11:50 | |
*** arnaud____ has joined #openstack-glance | 11:51 | |
*** cdelatte has quit IRC | 11:52 | |
*** delattec has quit IRC | 11:52 | |
*** arnaud____ has quit IRC | 11:55 | |
*** Miouge has quit IRC | 11:55 | |
*** Miouge has joined #openstack-glance | 11:57 | |
*** Miouge has quit IRC | 12:05 | |
*** cdelatte has joined #openstack-glance | 12:06 | |
*** ericpeterson has joined #openstack-glance | 12:06 | |
*** delatte has quit IRC | 12:07 | |
*** jaypipes is now known as leakypipes | 12:21 | |
*** ericpeterson has quit IRC | 12:21 | |
*** zul has joined #openstack-glance | 12:30 | |
*** zul has quit IRC | 12:35 | |
*** annegentle has joined #openstack-glance | 12:54 | |
*** pdb_ has quit IRC | 13:00 | |
*** pdb_ has joined #openstack-glance | 13:01 | |
*** spzala has joined #openstack-glance | 13:03 | |
*** kapil___ has joined #openstack-glance | 13:08 | |
*** ericpeterson has joined #openstack-glance | 13:13 | |
*** stpierre has joined #openstack-glance | 13:16 | |
*** ericpeterson has quit IRC | 13:19 | |
*** peristeri has joined #openstack-glance | 13:19 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:28 | |
*** dims has joined #openstack-glance | 13:30 | |
openstackgerrit | Monty Taylor proposed openstack/glance: Remove unneeded setup hook from setup.cfg https://review.openstack.org/179381 | 13:37 |
*** vks has joined #openstack-glance | 13:38 | |
vks | Error in store configuration. Adding images to store is disabled | 13:38 |
vks | whats the config thing need to enable | 13:38 |
vks | ???? | 13:38 |
vks | any one | 13:38 |
*** arnaud____ has joined #openstack-glance | 13:40 | |
*** Miouge has joined #openstack-glance | 13:40 | |
*** Miouge has quit IRC | 13:40 | |
vks | Miouge, Error in store configuration. Adding images to store is disabled | 13:40 |
vks | have u seen this? | 13:40 |
vks | arnaud____, Error in store configuration. Adding images to store is disabled | 13:41 |
*** Miouge has joined #openstack-glance | 13:41 | |
*** arnaud____ has quit IRC | 13:45 | |
*** openstackgerrit has quit IRC | 13:51 | |
*** openstackgerrit has joined #openstack-glance | 13:51 | |
*** ericpeterson has joined #openstack-glance | 13:55 | |
*** ericpeterson has quit IRC | 13:56 | |
*** ericpeterson has joined #openstack-glance | 13:56 | |
*** mjturek1 has left #openstack-glance | 14:03 | |
*** ccrouch has quit IRC | 14:27 | |
*** pkoniszewski has joined #openstack-glance | 14:28 | |
vks | pkoniszewski, Hi I am getting this error while running , glance image-create Error in store configuration. Adding images to store is disabled | 14:30 |
vks | pkoniszewski, do u know this? | 14:30 |
vks | ericpeterson, Error in store configuration. Adding images to store is disabled | 14:31 |
*** zz_jgrimm is now known as jgrimm | 14:31 | |
ericpeterson | not sure | 14:31 |
vks | ericpeterson, any guess, like what is the flag in config file might be affecting ti | 14:32 |
ericpeterson | seems to me like your service / api config file is not setup correctly to store images. I'd think / hope you could find better insight wrt to glance than I can provide ;) | 14:35 |
*** ccrouch has joined #openstack-glance | 14:35 | |
sigmavirus24 | vks: any chance you can share (at least) the glance_store section of your glance-api.conf file? | 14:38 |
vks | sigmavirus24, yes sure | 14:39 |
sigmavirus24 | vks: also version information about glance_store and glance | 14:39 |
*** vijendar has joined #openstack-glance | 14:43 | |
*** TravT has joined #openstack-glance | 14:53 | |
*** dims is now known as dimsum__ | 14:58 | |
vks | sigmavirus24, hi http://pastebin.com/ysJS6stS | 15:12 |
vks | sigmavirus24, can u check once??? | 15:13 |
vks | sigmavirus24, are u there?? | 15:19 |
openstackgerrit | Merged openstack/glance: Drop use of 'oslo' namespace package https://review.openstack.org/178333 | 15:24 |
*** pkoniszewski has quit IRC | 15:27 | |
*** arnaud____ has joined #openstack-glance | 15:28 | |
*** dimsum__ has quit IRC | 15:31 | |
*** dimsum__ has joined #openstack-glance | 15:31 | |
*** arnaud____ has quit IRC | 15:33 | |
sigmavirus24 | vks: I'm 90% certain you absolutely need to uncomment #filesystem_store_datadirs=/var/lib/glance/images/:1 | 15:34 |
sigmavirus24 | You need to define filesystem_store_datadir or filesystem_store_datadirs | 15:34 |
sigmavirus24 | if you're not, there's no defined place to store images and the store is misconfigured | 15:34 |
vks | sigmavirus24, let me just enable that | 15:34 |
vks | sigmavirus24, enabling that doesn't helped | 15:38 |
vks | sigmavirus24, this is the whole config file http://pastebin.com/EbvquCEP | 15:44 |
sigmavirus24 | vks: stupid question: You did restart your glance processes after changing glance-api.conf, right? | 15:52 |
vks | sigmavirus24, yeah | 15:58 |
*** ericpete_ has joined #openstack-glance | 16:01 | |
*** ericpeterson has quit IRC | 16:04 | |
*** annegentle has quit IRC | 16:04 | |
*** groen692 has quit IRC | 16:06 | |
vks | getting same error, Error in store configuration. Adding images to store is disabled | 16:07 |
vks | sigmavirus24, ? | 16:07 |
*** arnaud____ has joined #openstack-glance | 16:09 | |
*** MattMan has left #openstack-glance | 16:09 | |
*** peristeri has quit IRC | 16:23 | |
*** gokrokve has joined #openstack-glance | 16:25 | |
*** arnaud____ has quit IRC | 16:26 | |
*** gokrokve has quit IRC | 16:26 | |
*** gokrokve has joined #openstack-glance | 16:27 | |
*** alanf-mc has joined #openstack-glance | 16:48 | |
*** gokrokve has quit IRC | 16:51 | |
*** HenryG is now known as floccinaucinihil | 16:54 | |
*** floccinaucinihil is now known as HenryThe8th | 16:55 | |
openstackgerrit | Merged openstack/glance: Merge tag '2015.1.0' https://review.openstack.org/179285 | 17:02 |
openstackgerrit | Louis Taylor proposed openstack/python-glanceclient: Add some basic CLI functional tests https://review.openstack.org/179424 | 17:03 |
*** annegentle has joined #openstack-glance | 17:04 | |
openstackgerrit | Merged openstack/glance: Remove unneeded setup hook from setup.cfg https://review.openstack.org/179381 | 17:06 |
*** gokrokve has joined #openstack-glance | 17:18 | |
*** gokrokve_ has joined #openstack-glance | 17:20 | |
*** peristeri has joined #openstack-glance | 17:21 | |
*** gokrokve has quit IRC | 17:22 | |
*** gokrokv__ has joined #openstack-glance | 17:22 | |
*** gokrokve_ has quit IRC | 17:22 | |
nikhil_k_ | vks: I can try to help | 17:48 |
vks | nikhil_k_, yeah pls | 17:48 |
*** annegentle has quit IRC | 17:50 | |
nikhil_k_ | vks: what's the value set for store_capabilities_update_min_interval ? | 17:51 |
nikhil_k_ | in the config | 17:51 |
vks | nikhil_k_, http://pastebin.com/EbvquCEP | 17:53 |
*** annegentle has joined #openstack-glance | 18:07 | |
sigmavirus24 | nikhil_k_: I think vks is on Juno (which iirc doesn't have store capabilities) | 18:10 |
*** annegentle has quit IRC | 18:10 | |
*** jlk has left #openstack-glance | 18:10 | |
*** annegentle has joined #openstack-glance | 18:11 | |
nikhil_k_ | sigmavirus24: hmm | 18:11 |
nikhil_k_ | the exception seems to be related to that though or that the string was used for something else in juno | 18:12 |
nikhil_k_ | checking | 18:12 |
sigmavirus24 | nikhil_k_: at least the versions at the bottom of http://pastebin.com/ysJS6stS purport to be Juno | 18:13 |
nikhil_k_ | doesn't seem to exist at least in stable/juno!? | 18:13 |
sigmavirus24 | heh | 18:13 |
nikhil_k_ | ah | 18:13 |
sigmavirus24 | That would be a glance_store exception though that gets propogated upwards I think | 18:13 |
sigmavirus24 | "upwards" == through glance to the user | 18:14 |
sigmavirus24 | Which I think Gorka fixed | 18:14 |
nikhil_k_ | gotcha | 18:14 |
nikhil_k_ | sigmavirus24: you're right | 18:14 |
nikhil_k_ | here's what I shared with vks | 18:14 |
nikhil_k_ | so, it seems like there is some issue while checknig the store capability | 18:14 |
nikhil_k_ | https://github.com/openstack/glance_store/blob/master/glance_store/capabilities.py#L210 | 18:15 |
nikhil_k_ | https://github.com/openstack/glance/blob/master/glance/api/v1/upload_utils.py#L190 | 18:15 |
nikhil_k_ | so may be older version of store that isn't fixed | 18:15 |
sigmavirus24 | nikhil_k_: I don't think that capabilities existed in 0.1.0 | 18:15 |
sigmavirus24 | *0.1.10 | 18:15 |
nikhil_k_ | right, 0.1.11 I think for them | 18:16 |
sigmavirus24 | Oh I see what happens | 18:16 |
sigmavirus24 | so | 18:16 |
sigmavirus24 | When Store.configure() is called | 18:16 |
sigmavirus24 | if there's a BadStoreConfiguration exception then self.add = self.add_disabled | 18:17 |
sigmavirus24 | L68 | 18:17 |
sigmavirus24 | (glance_store/driver.py) | 18:17 |
sigmavirus24 | So, presumably the filesystem store is misconfigured vks | 18:17 |
sigmavirus24 | I just don't see how it's misconfigured is all | 18:18 |
nikhil_k_ | you're right! | 18:19 |
sigmavirus24 | Did we allow weighted filesystem directories in 0.1.10? | 18:19 |
sigmavirus24 | vks: what about instead of using filesystem_store_datadirs you do filesystem_store_datadir=/var/lib/glance/images | 18:20 |
stevelle | permissions? | 18:20 |
stevelle | other file system issue? | 18:20 |
sigmavirus24 | vks | 18:20 |
sigmavirus24 | vks: all of the information should be in your glance api logs | 18:20 |
sigmavirus24 | during configure_add for the filesystem, it logs every exception | 18:20 |
sigmavirus24 | stevelle: there are 3 error conditions | 18:21 |
sigmavirus24 | neither filesystem_store_datadir or filesystem_store_datadirs are specified, both are specified, or filesystem_store_file_perm is a bad setting | 18:22 |
vks | sigmavirus24, i resolved it by moving the default_store=file in DEFAULT sect | 18:22 |
sigmavirus24 | o_O | 18:22 |
sigmavirus24 | Weird that we were looking for it there when we had marked it as a deprecated location | 18:22 |
sigmavirus24 | stevelle: I lied | 18:23 |
vks | sigmavirus24, yeah thats true | 18:23 |
sigmavirus24 | Store._create_image_directories can raise a BadStoreConfiguration exception | 18:23 |
sigmavirus24 | Only if the directory doesn't exist at first and glance_store cannot create it | 18:23 |
sigmavirus24 | nikhil_k_: that's not something we'd fix, is it? (looking for default_store in the place we tell people we're going to look for it) | 18:24 |
sigmavirus24 | jokke_ if you're monitoring the logs, same question is posed to you | 18:24 |
*** e0ne has joined #openstack-glance | 18:27 | |
nikhil_k_ | sigmavirus24: heh, we need to fix that indeed! Though, this could be debatable i terms of whether it needs to be glance config or glance_store config section | 18:27 |
sigmavirus24 | Well there's no stable branch for glance_store on juno | 18:28 |
* nikhil_k_ read through the logs fast and hoped that's what was intended questions :-) | 18:28 | |
sigmavirus24 | nikhil_k_: I was wrong | 18:29 |
sigmavirus24 | https://github.com/openstack/glance/blob/stable/juno/etc/glance-api.conf#L8 | 18:29 |
sigmavirus24 | It's not documented as being deprecated for use in glance_store | 18:29 |
sigmavirus24 | That was in kilo | 18:30 |
sigmavirus24 | ignore me | 18:30 |
sigmavirus24 | :D | 18:30 |
nikhil_k_ | ok | 18:30 |
nikhil_k_ | hush | 18:30 |
* sigmavirus24 shuts up | 18:30 | |
nikhil_k_ | we prolly cannot have a stable/juno for store | 18:30 |
nikhil_k_ | :-) | 18:30 |
leakypipes | what is this gateway stuff in glance now? | 18:36 |
leakypipes | nikhil_k_: I used to be able to go to a file in Glance and see what the v2 image schema was... now I have zero clue how to find this information. anyone heard of a code comment or docstring in the gateway.py module? :( | 18:38 |
nikhil_k_ | leakypipes: Sorry to hear that you are finding the module not friendly enough. | 18:40 |
leakypipes | nikhil_k_: can you advise where I can see the schema for the v2 GET /images/{id} response? | 18:40 |
nikhil_k_ | leakypipes: It boils down to the domain layer refactoring to adopt onion architecture in Glance | 18:40 |
nikhil_k_ | sure | 18:40 |
leakypipes | nikhil_k_: "onion architecture"? :( | 18:41 |
nikhil_k_ | leakypipes: https://github.com/openstack/glance/blob/master/glance/api/v2/images.py#L916 | 18:42 |
nikhil_k_ | leakypipes: heh, yeah that one :P Though, it kinda helps with some stuff | 18:43 |
leakypipes | nikhil_k_: no, where is the schema for an image in the v2 API>? | 18:43 |
nikhil_k_ | ah | 18:43 |
leakypipes | nikhil_k_: oh, line 783, hidden away... | 18:43 |
leakypipes | nikhil_k_: why are v1 and v2 separate and conflicting API constructs like 'visibility' and 'is_public' jumbled into the same base properties? | 18:44 |
leakypipes | nikhil_k_: unfortunately, I need to hop off IRC in order to go in Windows so I can use webex... :( be back laters... sorry for all the questions. | 18:46 |
*** leakypipes has quit IRC | 18:46 | |
nikhil_k_ | will wait for you, Jay :-) (in case you are watching) | 18:51 |
nikhil_k_ | (sorry, I am getting pulled into a meeting where boss is asking for some critical fixes) | 18:52 |
nikhil_k_ | https://bugs.launchpad.net/glance/+bug/1420501 | 19:00 |
openstack | Launchpad bug 1420501 in Glance "is_public should not be a reserved attribute in v2" [Low,Fix released] - Assigned to Fei Long Wang (flwang) | 19:00 |
nikhil_k_ | leakypipes: images have some optional part related to custom properties that people specify in etc/schema-image.json | 19:00 |
nikhil_k_ | (will replay when online) | 19:01 |
*** e0ne has quit IRC | 19:02 | |
openstackgerrit | Merged openstack/glance: Add logging when policies forbid an action https://review.openstack.org/72800 | 19:07 |
openstackgerrit | Louis Taylor proposed openstack/glance: Remove string formatting from policy logging https://review.openstack.org/179461 | 19:09 |
kragniz | I didn't want to block that merged patch on ^ | 19:12 |
kragniz | (since it already took a year and three months to get it merged) | 19:13 |
sigmavirus24 | yeah we need to do that for all our logging | 19:13 |
kragniz | yeah | 19:13 |
kragniz | it's a pain to do unless it's merged quickly, though | 19:14 |
nikhil_k_ | kragniz: :-) Bring it up in a meeting | 19:15 |
kragniz | I think I did a few months ago | 19:15 |
kragniz | or maybe I planned to | 19:15 |
* kragniz forgets | 19:15 | |
*** bkopilov has quit IRC | 19:21 | |
*** arnaud____ has joined #openstack-glance | 19:27 | |
openstackgerrit | Ian Cordasco proposed openstack/glance-specs: Add HTTPS verification to glance-replicator https://review.openstack.org/149467 | 19:31 |
*** arnaud____ has quit IRC | 19:32 | |
*** bkopilov has joined #openstack-glance | 19:32 | |
*** bkopilov has quit IRC | 19:39 | |
*** annegentle has quit IRC | 19:43 | |
*** wayne_ has joined #openstack-glance | 19:43 | |
*** ctina_ has quit IRC | 19:43 | |
*** alanf-mc_ has joined #openstack-glance | 19:48 | |
*** HenryThe8th has quit IRC | 19:50 | |
*** bkopilov has joined #openstack-glance | 19:51 | |
*** alanf-mc has quit IRC | 19:51 | |
*** HenryG has joined #openstack-glance | 19:54 | |
*** HenryG has quit IRC | 19:55 | |
*** HenryG has joined #openstack-glance | 19:56 | |
*** bkopilov has quit IRC | 19:57 | |
openstackgerrit | Wayne Okuma proposed openstack/python-glanceclient: Support for Metadata Definition Catalog for Tags https://review.openstack.org/138612 | 20:06 |
*** julim has quit IRC | 20:09 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance: Updated from global requirements https://review.openstack.org/176827 | 20:09 |
*** annegentle has joined #openstack-glance | 20:10 | |
*** alanf-mc has joined #openstack-glance | 20:14 | |
*** HenryG has quit IRC | 20:16 | |
*** alanf-mc_ has quit IRC | 20:19 | |
*** HenryG has joined #openstack-glance | 20:21 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-glanceclient: Updated from global requirements https://review.openstack.org/155581 | 20:23 |
sigmavirus24 | nikhil_k_: General question about blueprints and such if you have a second | 20:25 |
nikhil_k_ | :-) | 20:25 |
nikhil_k_ | sure | 20:25 |
sigmavirus24 | wayne_: just resubmitted https://review.openstack.org/#/c/138612/19 which is attached to a blueprint that was accepted for kilo | 20:26 |
sigmavirus24 | the blueprint's already been targeted for L-1 though, is there anything that needs to be updated further about the bp? | 20:26 |
*** peristeri has quit IRC | 20:27 | |
sigmavirus24 | bp in question is https://blueprints.launchpad.net/glance/+spec/metadefs-tags | 20:27 |
nikhil_k_ | Thanks for bring it up, that's a good question | 20:27 |
* sigmavirus24 has no clue how any of this works =P | 20:28 | |
nikhil_k_ | I think we should encourage creating a dependent BP to metadefs-tags | 20:28 |
nikhil_k_ | and then ask wayne_ to link his spec to the new dependent one | 20:28 |
nikhil_k_ | and not the one that was accepted for kilo | 20:28 |
sigmavirus24 | That bp page is weird | 20:29 |
sigmavirus24 | It's "milestone target" is L-1 but it's marked as Implemented | 20:29 |
sigmavirus24 | So yeah, I agree with you about that | 20:29 |
sigmavirus24 | wayne_: ^^ | 20:29 |
nikhil_k_ | eh | 20:29 |
nikhil_k_ | we don't have logs on who set that | 20:30 |
sigmavirus24 | Yeah | 20:30 |
sigmavirus24 | I'm not overly concerned about it | 20:30 |
nikhil_k_ | may be we need to get ACLs on it too | 20:30 |
*** stpierre has quit IRC | 20:31 | |
sigmavirus24 | nikhil_k_: so I just noticed you registered https://blueprints.launchpad.net/glance/+spec/100-continue-in-response-headers | 20:31 |
nikhil_k_ | yeah, a while back | 20:31 |
nikhil_k_ | :) | 20:31 |
sigmavirus24 | Do you know how likely it is that wsgi supports that workflow? I know httplib makes it impossible for requests to support it | 20:31 |
nikhil_k_ | umm, it's been a while and I vagule remember the workflow. However, seemed like we needed to set a wsgi.enviro flag there | 20:32 |
nikhil_k_ | vaguely* | 20:32 |
nikhil_k_ | I do remember doing some research and possibly have notes. Will have to get back you on this :-) | 20:34 |
sigmavirus24 | That's something that, while we can't work with it in glanceclient right now, would be good to have for ... non-Python clients is all :D | 20:34 |
nikhil_k_ | you said non-Python clients :-) | 20:36 |
nikhil_k_ | I do agree, it would be a nice to have feature | 20:36 |
*** jgrimm is now known as zz_jgrimm | 20:37 | |
sigmavirus24 | I mea | 20:38 |
sigmavirus24 | *I mean | 20:38 |
sigmavirus24 | Unless someone is using plain sockets to talk to us in python | 20:38 |
sigmavirus24 | If they're using anything that bothers with urllib3, or requests then they can't use it... yet | 20:38 |
sigmavirus24 | We're working on rewriting our dependency on httplib but that is taking longer than most people think it would | 20:38 |
sigmavirus24 | https://www.python.org/dev/peps/pep-0333/#http-1-1-expect-continue | 20:40 |
nikhil_k_ | We == requests maintainers? | 20:40 |
sigmavirus24 | Yes | 20:40 |
sigmavirus24 | Sorry. So used to referring to the requests and urllib3 core teams as "We" | 20:41 |
sigmavirus24 | requests core developers: Kenneth, Cory, me. urllib3 core developers: Andrey, Cory, (sort of) me | 20:41 |
sigmavirus24 | so really the intersection is enough that we just call ourselves "we" | 20:41 |
nikhil_k_ | :-) | 20:42 |
sigmavirus24 | Also, technically, Andrey /could/ push code to requests but he's not really a core developer | 20:42 |
nikhil_k_ | Good to know | 20:42 |
nikhil_k_ | sigmavirus24: gotcha, so you think "wsgi.input stream" might interfere with requests/urllib3 ? | 20:43 |
nikhil_k_ | Anyways, we can research that later. | 20:44 |
sigmavirus24 | Sorry. I'm so used to this issue already that I never explain it well the first time. The short is: If requests sends the header Expect: 100-continue, it never can determine that the server sent a 100 Continue | 20:44 |
sigmavirus24 | So it just sends the data | 20:44 |
sigmavirus24 | It waits however long it takes the Python VM to execute OP codes between when we finish sending the headers and start sending the body | 20:45 |
nikhil_k_ | Gotcha, I just made a connection on your python client conn issue | 20:45 |
nikhil_k_ | So, requests is currently not optimizing on the return headers | 20:46 |
nikhil_k_ | And clients using requets would face this challenge | 20:46 |
nikhil_k_ | and I opened this without having that perspective | 20:46 |
sigmavirus24 | Well it's just more that we aren't kind to the server | 20:46 |
sigmavirus24 | So even if the server sends it, we never see that it was sent | 20:46 |
sigmavirus24 | But other clients /could/ wait for the 100 continue "response" before sending data | 20:47 |
sigmavirus24 | So implementing it is a good idea, but it has no benefit for python clients | 20:47 |
sigmavirus24 | (unless said python client is written entirely using sockets =P) | 20:47 |
nikhil_k_ | hmm, I thought httplib does handle that | 20:47 |
nikhil_k_ | at least, I kinda assumed that because swiftclient supports 100-continue | 20:48 |
nikhil_k_ | my proposal was based on that | 20:48 |
nikhil_k_ | more towards xen (dom0) glance plugin (alternative py-client) to make requests to glance | 20:48 |
nikhil_k_ | as it does not use py-client or requests | 20:49 |
nikhil_k_ | old py24/26 httplib module | 20:49 |
sigmavirus24 | if swiftclient is somehow checking/waiting for a 100-continue, I'd love to see how they do that | 20:50 |
sigmavirus24 | I may go hunting for that later | 20:50 |
nikhil_k_ | cool | 20:50 |
nikhil_k_ | sigmavirus24: hmm, I see these never merged. https://review.openstack.org/#/q/topic:bp/should-use-100-continue-header,n,z | 20:56 |
sigmavirus24 | yeah | 20:59 |
sigmavirus24 | It's nice to have | 20:59 |
sigmavirus24 | It's hard right now with httplib for us to obey it appropriately | 20:59 |
nikhil_k_ | yeah :/ | 20:59 |
*** ajayaa has joined #openstack-glance | 21:07 | |
*** boris-42 has quit IRC | 21:18 | |
openstackgerrit | Ian Cordasco proposed openstack/glance: Register oslo.log's config options in tests https://review.openstack.org/165812 | 21:29 |
sigmavirus24 | ajayaa: thanks for catching that | 21:31 |
*** dimsum__ has quit IRC | 21:56 | |
*** dimsum__ has joined #openstack-glance | 21:56 | |
*** vijendar has quit IRC | 22:03 | |
*** bkopilov has joined #openstack-glance | 22:08 | |
*** bkopilov has quit IRC | 22:13 | |
*** bkopilov has joined #openstack-glance | 22:14 | |
*** Miouge has quit IRC | 22:21 | |
*** bkopilov has quit IRC | 22:21 | |
*** bkopilov has joined #openstack-glance | 22:21 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:29 | |
*** ajayaa has quit IRC | 22:30 | |
*** bkopilov has quit IRC | 22:33 | |
*** annegentle has quit IRC | 22:36 | |
*** bkopilov has joined #openstack-glance | 22:40 | |
*** ericpete_ has quit IRC | 22:45 | |
*** bkopilov has quit IRC | 22:46 | |
*** bkopilov has joined #openstack-glance | 22:47 | |
*** gokrokv__ has quit IRC | 22:58 | |
*** angela-s2 has joined #openstack-glance | 23:03 | |
*** bkopilov has quit IRC | 23:04 | |
*** bkopilov has joined #openstack-glance | 23:11 | |
*** boris-42 has joined #openstack-glance | 23:18 | |
*** flwang has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!