*** BitSmith has quit IRC | 00:00 | |
*** ducttape_ has quit IRC | 00:04 | |
*** TravT_ has quit IRC | 00:08 | |
*** belmoreira has joined #openstack-glance | 00:11 | |
*** annashen has quit IRC | 00:16 | |
vilobhmm | nikhil_k : ^^ | 00:27 |
---|---|---|
*** tsekiyama has quit IRC | 00:36 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance: Updated from global requirements https://review.openstack.org/186114 | 00:41 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance_store: Updated from global requirements https://review.openstack.org/186941 | 00:41 |
*** mtanino has quit IRC | 00:44 | |
*** ducttape_ has joined #openstack-glance | 00:44 | |
*** ducttape_ has quit IRC | 00:44 | |
*** annashen has joined #openstack-glance | 00:47 | |
*** annashen has quit IRC | 00:54 | |
sabari | kragniz: db migrations tests are getting skipped in https://review.openstack.org/#/c/184373/. May be we want to hold that for now. | 00:57 |
sabari | ^ migrations tests for mysql | 00:57 |
*** chlong has quit IRC | 01:11 | |
*** BitSmith has joined #openstack-glance | 01:13 | |
*** BitSmith has quit IRC | 01:16 | |
*** dims_ has joined #openstack-glance | 01:18 | |
*** BitSmith has joined #openstack-glance | 01:19 | |
*** dims has quit IRC | 01:21 | |
*** tobe has joined #openstack-glance | 01:24 | |
*** arnaud____ has joined #openstack-glance | 01:27 | |
*** arnaud____ has quit IRC | 01:32 | |
*** BitSmith is now known as [BitSmith] | 01:34 | |
*** [BitSmith] is now known as BitSmith | 01:37 | |
*** BitSmith is now known as [BitSmith] | 01:38 | |
*** vilobhmm has quit IRC | 01:41 | |
*** [BitSmith] is now known as BitSmith | 01:43 | |
*** belmoreira has quit IRC | 01:50 | |
*** marcusvrn has joined #openstack-glance | 02:01 | |
*** BitSmith is now known as [BitSmith] | 02:07 | |
*** [BitSmith] is now known as BitSmith | 02:07 | |
*** dims_ has quit IRC | 02:33 | |
*** BitSmith has quit IRC | 02:34 | |
*** BitSmith has joined #openstack-glance | 02:40 | |
*** BitSmith has quit IRC | 02:44 | |
*** tobe has quit IRC | 02:46 | |
*** tobe has joined #openstack-glance | 02:47 | |
*** vilobhmm has joined #openstack-glance | 02:47 | |
*** BitSmith has joined #openstack-glance | 02:47 | |
*** tobe has quit IRC | 02:50 | |
*** ajayaa has joined #openstack-glance | 02:51 | |
*** tobe has joined #openstack-glance | 02:51 | |
*** BitSmith has quit IRC | 02:54 | |
*** vilobhmm has quit IRC | 02:59 | |
*** david-lyle has joined #openstack-glance | 03:04 | |
*** sgotliv_ has joined #openstack-glance | 03:05 | |
*** arnaud____ has joined #openstack-glance | 03:16 | |
*** arnaud____ has quit IRC | 03:21 | |
*** dims has joined #openstack-glance | 03:34 | |
*** kebray has joined #openstack-glance | 03:51 | |
*** fifieldt has joined #openstack-glance | 03:58 | |
*** ajayaa has quit IRC | 03:58 | |
*** tobe has quit IRC | 04:04 | |
*** TravT_ has joined #openstack-glance | 04:09 | |
*** ayoung has quit IRC | 04:09 | |
*** tobe has joined #openstack-glance | 04:13 | |
*** ajayaa has joined #openstack-glance | 04:15 | |
*** annashen has joined #openstack-glance | 04:22 | |
*** marcusvrn has quit IRC | 04:24 | |
*** annashen has quit IRC | 04:27 | |
*** kebray has quit IRC | 04:32 | |
*** changbl has joined #openstack-glance | 04:42 | |
*** ajayaa has quit IRC | 04:50 | |
*** haomaiw__ has joined #openstack-glance | 04:55 | |
*** haomaiwang has quit IRC | 04:56 | |
*** tobe has quit IRC | 04:56 | |
*** tobe has joined #openstack-glance | 05:01 | |
*** TravT_ has quit IRC | 05:18 | |
*** belmoreira has joined #openstack-glance | 05:22 | |
*** aswadr has joined #openstack-glance | 05:34 | |
*** belmoreira has quit IRC | 05:38 | |
*** ajayaa has joined #openstack-glance | 05:44 | |
*** nlevinki has joined #openstack-glance | 05:49 | |
*** haomaiw__ has quit IRC | 05:51 | |
*** vilobhmm has joined #openstack-glance | 05:57 | |
*** haomaiwang has joined #openstack-glance | 05:57 | |
*** Murali has joined #openstack-glance | 06:04 | |
*** haomaiwang has quit IRC | 06:18 | |
*** haomaiwa_ has joined #openstack-glance | 06:19 | |
*** annashen has joined #openstack-glance | 06:24 | |
*** annashen has quit IRC | 06:29 | |
*** aswadr has quit IRC | 06:35 | |
*** groen692 has joined #openstack-glance | 06:48 | |
*** abhishekk has joined #openstack-glance | 06:58 | |
*** arnaud____ has joined #openstack-glance | 07:08 | |
*** e0ne has joined #openstack-glance | 07:08 | |
*** markus_z has joined #openstack-glance | 07:12 | |
*** arnaud____ has quit IRC | 07:12 | |
*** e0ne has quit IRC | 07:12 | |
*** vilobhmm has quit IRC | 07:21 | |
*** vilobhmm has joined #openstack-glance | 07:23 | |
*** ajayaa has quit IRC | 07:27 | |
*** e0ne has joined #openstack-glance | 07:28 | |
*** e0ne has quit IRC | 07:29 | |
*** ajayaa has joined #openstack-glance | 07:30 | |
*** jistr has joined #openstack-glance | 07:33 | |
*** takedakn has joined #openstack-glance | 07:46 | |
*** vilobhmm has quit IRC | 07:46 | |
*** takedakn has quit IRC | 07:52 | |
*** ajayaa has quit IRC | 08:03 | |
*** krykowski has joined #openstack-glance | 08:04 | |
*** MattMan has quit IRC | 08:11 | |
*** TravT_ has joined #openstack-glance | 08:23 | |
*** annashen has joined #openstack-glance | 08:25 | |
*** jistr has quit IRC | 08:27 | |
*** annashen has quit IRC | 08:30 | |
*** MattMan has joined #openstack-glance | 08:41 | |
*** ajayaa has joined #openstack-glance | 08:42 | |
*** jistr has joined #openstack-glance | 08:43 | |
*** TravT_ has quit IRC | 08:55 | |
*** pdb has quit IRC | 09:40 | |
*** pdb has joined #openstack-glance | 09:40 | |
*** dims_ has joined #openstack-glance | 09:44 | |
kragniz | sabari: ah, the switch isn't as seamless as I thought | 09:46 |
*** dims has quit IRC | 09:47 | |
*** e0ne has joined #openstack-glance | 09:47 | |
*** e0ne is now known as e0ne_ | 09:54 | |
*** TravT_ has joined #openstack-glance | 09:55 | |
*** TravT_ has quit IRC | 10:00 | |
*** e0ne_ has quit IRC | 10:00 | |
*** e0ne has joined #openstack-glance | 10:01 | |
*** BitSmith has joined #openstack-glance | 10:02 | |
*** ajayaa has quit IRC | 10:12 | |
*** BitSmith has quit IRC | 10:13 | |
*** ajayaa has joined #openstack-glance | 10:16 | |
*** annashen has joined #openstack-glance | 10:28 | |
*** annashen has quit IRC | 10:32 | |
*** e0ne is now known as e0ne_ | 10:33 | |
*** e0ne_ is now known as e0ne | 10:34 | |
*** mfedosin has joined #openstack-glance | 10:39 | |
openstackgerrit | Gorka Eguileor proposed openstack/glance_store: Allow random read in RBD driver (get method) https://review.openstack.org/157325 | 10:43 |
*** aix has quit IRC | 11:07 | |
*** openstackgerrit has quit IRC | 11:13 | |
*** openstackgerrit has joined #openstack-glance | 11:14 | |
*** TravT_ has joined #openstack-glance | 11:16 | |
*** TravT_ has quit IRC | 11:21 | |
*** e0ne is now known as e0ne_ | 11:21 | |
*** ducttape_ has joined #openstack-glance | 11:27 | |
*** e0ne_ has quit IRC | 11:32 | |
*** e0ne has joined #openstack-glance | 11:36 | |
*** ducttape_ has quit IRC | 11:45 | |
*** julim has joined #openstack-glance | 11:45 | |
*** marcusvrn has joined #openstack-glance | 11:57 | |
*** Murali_ has joined #openstack-glance | 12:00 | |
*** Murali has quit IRC | 12:04 | |
*** Murali_ has quit IRC | 12:05 | |
*** Murali has joined #openstack-glance | 12:06 | |
*** aix has joined #openstack-glance | 12:09 | |
*** fifieldt has quit IRC | 12:53 | |
*** Murali has quit IRC | 12:55 | |
*** tobe has quit IRC | 12:55 | |
*** Murali has joined #openstack-glance | 12:56 | |
*** tobe has joined #openstack-glance | 12:57 | |
*** ajayaa has quit IRC | 12:58 | |
*** ajayaa has joined #openstack-glance | 12:59 | |
*** ajayaa has quit IRC | 13:01 | |
*** tobe has quit IRC | 13:02 | |
*** TravT_ has joined #openstack-glance | 13:04 | |
*** Longgeek_ has quit IRC | 13:06 | |
*** ducttape_ has joined #openstack-glance | 13:07 | |
*** ducttape_ has quit IRC | 13:08 | |
*** ducttape_ has joined #openstack-glance | 13:09 | |
*** TravT_ has quit IRC | 13:09 | |
*** ducttape_ has quit IRC | 13:09 | |
openstackgerrit | Flavio Percoco proposed openstack/python-glanceclient: Make glanceclient accept a session object https://review.openstack.org/141994 | 13:11 |
*** spzala has joined #openstack-glance | 13:13 | |
*** sgotliv__ has joined #openstack-glance | 13:18 | |
*** sgotliv_ has quit IRC | 13:20 | |
*** stpierre has joined #openstack-glance | 13:25 | |
*** annashen has joined #openstack-glance | 13:30 | |
*** krykowski has quit IRC | 13:31 | |
*** abhishekk has quit IRC | 13:32 | |
*** annashen has quit IRC | 13:35 | |
*** ccrouch has joined #openstack-glance | 13:42 | |
*** peristeri has joined #openstack-glance | 13:51 | |
*** ivasilevskaya has joined #openstack-glance | 13:55 | |
nikhil_k | Courtesy meeting reminder: ativelkov, cpallares, esheffield, flaper87, flwang1, hemanthm, ivasilevskaya, jokke_, kragniz, lakshmiS, mclaren, mfedosin, nikhil_k, Nikolay_St, Olena, pennerc, rosmaita, sigmavirus24, sabari, TravT, zhiyan, pkoniszewski, krykowski, ajayaa, GB21, bpoulos | 13:58 |
*** bpoulos has joined #openstack-glance | 13:58 | |
*** TravT_ has joined #openstack-glance | 14:05 | |
*** ducttape_ has joined #openstack-glance | 14:06 | |
*** TravT_ has quit IRC | 14:10 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 14:10 | |
*** takedakn has joined #openstack-glance | 14:19 | |
*** ericpeterson has joined #openstack-glance | 14:21 | |
*** sjmc7 has joined #openstack-glance | 14:22 | |
*** ducttape_ has quit IRC | 14:24 | |
*** jaypipes has quit IRC | 14:26 | |
*** zz_jgrimm is now known as jgrimm | 14:28 | |
*** Murali has quit IRC | 14:33 | |
*** e0ne is now known as e0ne_ | 14:34 | |
*** ayoung has joined #openstack-glance | 14:36 | |
*** takedakn has quit IRC | 14:41 | |
*** GB21 has joined #openstack-glance | 14:44 | |
*** tsekiyama has joined #openstack-glance | 14:45 | |
*** e0ne_ has quit IRC | 14:45 | |
*** TravT_ has joined #openstack-glance | 14:51 | |
*** mtanino has joined #openstack-glance | 14:52 | |
*** dims_ has quit IRC | 15:02 | |
*** dims has joined #openstack-glance | 15:02 | |
*** bpoulos has left #openstack-glance | 15:04 | |
*** nlevinki has quit IRC | 15:04 | |
*** cpallares1 has joined #openstack-glance | 15:05 | |
*** jistr is now known as jistr|mtg | 15:17 | |
*** markus_z has quit IRC | 15:21 | |
*** kebray has joined #openstack-glance | 15:23 | |
*** BitSmith has joined #openstack-glance | 15:24 | |
openstackgerrit | Merged openstack/python-glanceclient: Make glanceclient accept a session object https://review.openstack.org/141994 | 15:25 |
*** annashen has joined #openstack-glance | 15:32 | |
*** ducttape_ has joined #openstack-glance | 15:32 | |
*** groen692 has quit IRC | 15:32 | |
*** ericpeterson has quit IRC | 15:33 | |
*** jistr|mtg is now known as jistr | 15:35 | |
*** annashen has quit IRC | 15:36 | |
*** vilobhmm has joined #openstack-glance | 15:37 | |
*** vilobhmm1 has joined #openstack-glance | 15:41 | |
*** vilobhmm has quit IRC | 15:42 | |
*** ericpeterson has joined #openstack-glance | 15:42 | |
*** ducttape_ has quit IRC | 15:45 | |
*** peristeri_ has joined #openstack-glance | 15:55 | |
*** GB21 has quit IRC | 15:57 | |
*** peristeri has quit IRC | 15:58 | |
*** GB21 has joined #openstack-glance | 15:59 | |
*** arnaud____ has joined #openstack-glance | 16:00 | |
openstackgerrit | Stuart McLaren proposed openstack/python-glanceclient: Close iterables at the end of iteration https://review.openstack.org/190359 | 16:01 |
openstackgerrit | Flavio Percoco proposed openstack/glance: Make utf8 the default charset for mysql https://review.openstack.org/181347 | 16:09 |
*** BitSmith has quit IRC | 16:10 | |
*** vilobhmm1 has quit IRC | 16:15 | |
*** arnaud____ has quit IRC | 16:20 | |
*** e0ne has joined #openstack-glance | 16:27 | |
*** r-daneel has joined #openstack-glance | 16:27 | |
openstackgerrit | Inessa Vasilevskaya proposed openstack/glance: Fix DbError when image params are out of range https://review.openstack.org/182703 | 16:27 |
*** jaypipes has joined #openstack-glance | 16:35 | |
openstackgerrit | Inessa Vasilevskaya proposed openstack/glance: Artifacts custom logic support https://review.openstack.org/157099 | 16:36 |
openstackgerrit | Inessa Vasilevskaya proposed openstack/glance: Json schema generation for Artifact Type https://review.openstack.org/132253 | 16:37 |
openstackgerrit | Inessa Vasilevskaya proposed openstack/glance: Alternative versioning schemas POC https://review.openstack.org/186473 | 16:37 |
openstackgerrit | Inessa Vasilevskaya proposed openstack/glance: Proof of Concept of non-eventlet-based glance's service launch https://review.openstack.org/167673 | 16:38 |
*** vilobhmm has joined #openstack-glance | 16:40 | |
*** vilobhmm1 has joined #openstack-glance | 16:41 | |
ivasilevskaya | guys, could you please have a look at the following bugfixes: https://review.openstack.org/#/c/182703/ and https://review.openstack.org/#/c/178697/ ? | 16:43 |
ivasilevskaya | I'm taking a break with Glance contribution till the end of summer and I'd like to have no technicall debt left. They are small and not too boring to review :) | 16:43 |
*** vilobhmm has quit IRC | 16:44 | |
*** annashen has joined #openstack-glance | 16:45 | |
openstackgerrit | Inessa Vasilevskaya proposed openstack/glance: Fix HTTP 500 on NotAuthenticated in registry (v1) https://review.openstack.org/178697 | 16:53 |
*** ayoung has quit IRC | 16:54 | |
*** annegentle has joined #openstack-glance | 17:03 | |
*** e0ne has quit IRC | 17:09 | |
nikhil_k | flaper87: can you add your preference for jul28 on https://docs.google.com/spreadsheets/d/1w0eI6SPCA2IrOyHiEYC2uDO3fbYGzahZRUQSva0UD3Y/edit#gid=0 ? | 17:11 |
nikhil_k | that column is getting feedback | 17:11 |
nikhil_k | others too, sigmavirus24 kragniz jokke_ jcook rosmaita ativelkov mfedosin sabari ^ | 17:12 |
sabari | nikhil_k: thanks, almost forgot :) | 17:13 |
sigmavirus24 | nikhil_k: I'm just going to go ahead and predict I won't be able to make it | 17:13 |
sigmavirus24 | because sprint priorities or something | 17:13 |
nikhil_k | ivasilevskaya: sure :) seems like some conversation there. Who would be a POC/someone you okay rebasing, if we need more changes? | 17:14 |
jcook | nikhil_k: updated | 17:15 |
nikhil_k | sigmavirus24: gotcha. We will try to make Video work/engaging as best possible.. | 17:15 |
nikhil_k | thanks sabari jcook | 17:16 |
vilobhmm1 | nikhil_k : ping | 17:16 |
nikhil_k | david-lyle: TravT_: fyi ^ | 17:16 |
nikhil_k | vilobhmm1: hi | 17:16 |
vilobhmm1 | Does glance maintain instance snapshot quota ? | 17:16 |
vilobhmm1 | since glance does not have any cli to display the same | 17:16 |
vilobhmm1 | https://blueprints.launchpad.net/glance/+spec/glance-basic-quotas talk about it…but not sure if thats what its meant for ? | 17:16 |
vilobhmm1 | nikhil_k : ^^ | 17:16 |
nikhil_k | vilobhmm1: ah sorry, I missed your ping earlier.. | 17:16 |
vilobhmm1 | np | 17:17 |
nikhil_k | vilobhmm1: we have quota for image storage | 17:17 |
jcook | nikhil_k: np sir | 17:17 |
sigmavirus24 | nikhil_k: for me, it's more important to be able to hear people than see things | 17:17 |
sigmavirus24 | so if we can figure out a mumble set-up that'd be helpful | 17:17 |
* sigmavirus24 lunch | 17:17 | |
nikhil_k | ok, some technology that enables better hearing sigmavirus24 :-) (sure) | 17:18 |
vilobhmm1 | nikhil_k : not for instance snapshot ? | 17:19 |
nikhil_k | vilobhmm1: see thsi config, user_storage_quota = 0 | 17:19 |
nikhil_k | one sec | 17:19 |
vilobhmm1 | though https://review.openstack.org/#/c/37993/ | 17:19 |
*** ayoung has joined #openstack-glance | 17:19 | |
vilobhmm1 | sure | 17:19 |
nikhil_k | vilobhmm1: yep, did you see the reply to the ML on that convo | 17:20 |
nikhil_k | we may have to look for the subject but it was related to that spec you mentioned here | 17:20 |
vilobhmm1 | no i haven't seen such a ML conv | 17:20 |
nikhil_k | GB21: hi | 17:21 |
GB21 | hi nikhil_k | 17:21 |
nikhil_k | vilobhmm1: ok, let me find it | 17:21 |
nikhil_k | vilobhmm1: https://github.com/openstack/glance/blob/master/etc/glance-api.conf#L292 | 17:21 |
nikhil_k | looking for the ML convo | 17:21 |
vilobhmm1 | nikhil_k : thnx :) does that mean glance will maintain *instance snapshot* quota | 17:22 |
GB21 | nikhil_k, I have a question, the internal server error I ws getting, in the sabari's comments "If you | 17:22 |
GB21 | sync your code, you should no more be seeing 500 but a 201", does syncying means that I do ./unstack.sh and then again ./stack.sh | 17:22 |
nikhil_k | vilobhmm1: https://www.mail-archive.com/openstack-dev@lists.openstack.org/msg53246.html | 17:23 |
GB21 | Doing this again gave me an internal server error in the installation | 17:23 |
nikhil_k | vilobhmm1: there's not specific quota kept aside | 17:23 |
nikhil_k | vilobhmm1: though, I think the answer you are looking for and is, is yes | 17:23 |
nikhil_k | GB21: what do you mean by sycn your code? | 17:24 |
nikhil_k | internall server error in installation? | 17:24 |
nikhil_k | is github or any websites that devstack referes to down? Do check your logs for it | 17:25 |
GB21 | That is what I want to ask, what does it exactly means as when I googled it, I found that I should update devstack | 17:25 |
GB21 | for that I needed to unstack it and then again stack it | 17:25 |
GB21 | but when I stack it again, I get the same error i.e internal server error 500 | 17:26 |
GB21 | this is the same error I got while creating the tasks | 17:26 |
sabari | GB21: I meant a git pull. | 17:27 |
sabari | Sorry I need to run but will back shortly. | 17:27 |
GB21 | sabari, ohk | 17:28 |
GB21 | sabari, thanks | 17:28 |
nikhil_k | GB21: unstack/stack rejoin-stack won't do a git pull unless you have deleted the repo | 17:28 |
nikhil_k | GB21: so, here's my recommendation | 17:28 |
nikhil_k | 1. Don't do unstack/stack if you have stuff working under your devstack install | 17:29 |
vilobhmm1 | nikhil_k : ok…if the answer is yes…a follow up question is why don't we do a pre-check whether we have available space to create a snap before hand…..because none of that happen..till the image is actually created… | 17:29 |
vilobhmm1 | as what i saw in https://review.openstack.org/#/c/37993/ | 17:29 |
nikhil_k | 2. do, git fetch/git pull for your latest changes. | 17:29 |
vilobhmm1 | and if the instance snapshot is created by trigerring "nova image-create" | 17:29 |
nikhil_k | 3. restart glance-api and glance-reg (by hitting ctrl+c, up arrow and enter on the resp. screens) | 17:30 |
nikhil_k | 4. test and enjoy further work :P | 17:30 |
GB21 | nikhil_k, ohk, thanks :D | 17:30 |
vilobhmm1 | nikhil_k : even the check doesn't seem to be there as part of "glance image-create" or am i missing something obvious here ? | 17:31 |
nikhil_k | vilobhmm1: so the storage quota exists to ensure that we do not overfill the backend storage systems glance is using. Also, we have some way to restrict people from DOSing | 17:31 |
GB21 | nikhil_k, when we do stack.sh doesnt it updates itself everytime? | 17:32 |
nikhil_k | nova image-create essentially triggers what glance image-create is | 17:32 |
nikhil_k | GB21: not if the repo is pulled already | 17:32 |
GB21 | nikhil_k, ohk | 17:32 |
nikhil_k | vilobhmm1: There is where the openstack service boundaries make a little bit of different | 17:32 |
nikhil_k | difference* | 17:33 |
vilobhmm1 | nikhil_k : my point is there doesn't see a validation step ( which validates "am i runnning above quota") in the image-create | 17:33 |
vilobhmm1 | see = *seem to be* | 17:33 |
nikhil_k | vilobhmm1: Please correct me if I am wrong but not all virt drivers can deterministically calculate the image size before snapshot happens. snapshot happening can be multi-step process: | 17:34 |
nikhil_k | 1. HV does the magic to create snapshot | 17:34 |
*** TravT_ has quit IRC | 17:34 | |
nikhil_k | 2. snapshot is uploaded to glance | 17:34 |
nikhil_k | 3. snapshot size if checked | 17:35 |
*** jistr has quit IRC | 17:35 | |
nikhil_k | if nova/cinder/ironic stream snap data without being aware of the size | 17:35 |
vilobhmm1 | nikhil_k : should'nt the snapshot size check against quota happen before uploading snapshot to glance ? | 17:35 |
vilobhmm1 | nikhil_k : what do you think ? please correct if i am missing anything | 17:38 |
nikhil_k | vilobhmm1: we don't require users to specify size of the image during creation/upload so no. May be we can enforce it for v2 | 17:38 |
nikhil_k | v2 has a 2 step process and size is passed in during upload | 17:39 |
nikhil_k | although | 17:39 |
nikhil_k | umm, let me think a bit more | 17:40 |
nikhil_k | I think it may be tricky for some cases like import | 17:40 |
nikhil_k | may be not | 17:40 |
vilobhmm1 | but during *instance snap* creation looks like from what you said above image-size can;t be computed beforehand…specifying image size is not an option IMHO | 17:40 |
vilobhmm1 | nikhil_k: ^^ | 17:40 |
nikhil_k | if we have converted image during import process then not, otherwise yes | 17:40 |
nikhil_k | vilobhmm1: yep. nova isn't using v2 yet so when that happens we will know how many virt drivers are affected | 17:41 |
vilobhmm1 | is this documented somewhere ? is there a blueprint/spec/etherpad for it ? | 17:42 |
vilobhmm1 | nikhil_k : ^^ | 17:42 |
nikhil_k | vilobhmm1: for ? | 17:42 |
nikhil_k | nova using v2? | 17:42 |
vilobhmm1 | * v2 has a 2 step process and size is passed in during upload * and also checking for *instance snapshot* quota…esp for the quota thing if there is not i can go ahead and file a blueprint | 17:43 |
nikhil_k | vilobhmm1: http://developer.openstack.org/api-ref-image-v2.html | 17:44 |
vilobhmm1 | for the quota thing nikhil_k | 17:45 |
vilobhmm1 | thanks for the link | 17:45 |
nikhil_k | vilobhmm1: not yet | 17:46 |
vilobhmm1 | should i go ahead and file a blueprint | 17:46 |
vilobhmm1 | i think it should be a good start | 17:46 |
vilobhmm1 | what you think ? | 17:46 |
nikhil_k | vilobhmm1: you can, I did not get your pre-check query. If you see the api ref, we actually do the pre check for image v2 api | 17:47 |
nikhil_k | vilobhmm1: but like I also said | 17:48 |
nikhil_k | it may be dofficult for the nova virt drivers to enable that migration | 17:48 |
nikhil_k | so we will have to see how that goes | 17:48 |
nikhil_k | vilobhmm1: does that help much? | 17:49 |
vilobhmm1 | nikhil_k : what i meant by pre-check…is lets say *instance snap* quota is 50 GB (with 20GB free) and then when someone does a nova image-create/glance image-create of a 40GB instance….(snap size say 21GB) so before uploading the created snap which is 21 GB to glance…glance should do a pre-check "whether the created snap exceed my free available quota for instance snapshot (which is 20GB)" | 17:50 |
nikhil_k | I see how it's confusing here | 17:51 |
nikhil_k | vilobhmm1: https://review.openstack.org/#/c/37993/18/glance/api/v2/image_data.py | 17:51 |
vilobhmm1 | so if the pre-check fails …don;t upload the snap to glance…as anyhow after upload it will fail | 17:51 |
vilobhmm1 | as upload won't go through | 17:52 |
vilobhmm1 | does that make sense nikhil_k | 17:52 |
nikhil_k | vilobhmm1: ok, I think we may need to discuss a bit more on these lines: | 17:56 |
nikhil_k | 1. Do we need fine grained quotas? (user/tenant level)? | 17:57 |
nikhil_k | 2. Are quotas working for all backend storage systems? | 17:57 |
nikhil_k | 3. Does snapshot quota fall under the above category? | 17:57 |
nikhil_k | vilobhmm1: if you see https://review.openstack.org/#/c/37993/18/glance/api/v2/image_data.py lines 54, 86 | 17:58 |
nikhil_k | if the backend knows that for that size of the image, storage won't be able to handle the set_data call, we should see it raised before upload actually happens | 17:59 |
vilobhmm1 | yes | 18:02 |
nikhil_k | vilobhmm1: but for v1 (that is currently being used by Nova), see https://review.openstack.org/#/c/37993/18/glance/api/v1/upload_utils.py (check quota happens before but is lazy check) so you may see delay if size if not set | 18:03 |
vilobhmm1 | exception.StorageFull or exception.StorageQuotaFull should be raised if set_data exceeds the limit (which in fact is a logical calculation before doing actual save/write on the backend) | 18:04 |
nikhil_k | yeah | 18:04 |
nikhil_k | vilobhmm1: what storage are you using? | 18:05 |
vilobhmm1 | local file system..nothing fancy | 18:05 |
nikhil_k | hmm, may be we need to check the filesystem store dirver -- when does it raise this exception | 18:06 |
vilobhmm1 | ok | 18:06 |
vilobhmm1 | but doen't glance maintain something in glance db which will help to do the logical calculation as part of set_data ( this table is db should be in sync with what we have on the undelying backend i mean how much free space etc calc)… | 18:07 |
vilobhmm1 | that should help here IMHO | 18:07 |
vilobhmm1 | rather than waiting for the driver to raise the exception | 18:08 |
vilobhmm1 | nikhil_k : ^^ | 18:08 |
nikhil_k | vilobhmm1: glance cannot maintain that quota information. if you see on the BP, the feedback was already given that a new service in openstack that handles quota should do it | 18:08 |
nikhil_k | glance uses something called multiple locations | 18:09 |
nikhil_k | so, you may store data in more than one type of store | 18:09 |
vilobhmm1 | ok…but you said above glance maintains *instance snapshot* quota..I am confused now :( | 18:09 |
nikhil_k | glance maintains an overall quota | 18:09 |
vilobhmm1 | ok | 18:09 |
nikhil_k | more like a hard cap | 18:09 |
vilobhmm1 | ok | 18:10 |
nikhil_k | but that's also because glance itself can act as backend store | 18:10 |
nikhil_k | using filesystem | 18:10 |
nikhil_k | vilobhmm1: you can see here https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/filesystem.py (look for storagefull) | 18:11 |
vilobhmm1 | ok | 18:11 |
nikhil_k | may be we should remove it in glance | 18:12 |
openstackgerrit | Stuart McLaren proposed openstack/python-glanceclient: Close iterables at the end of iteration https://review.openstack.org/190359 | 18:12 |
nikhil_k | I see that implementation done to compromise a little bit on the responsiblity share | 18:13 |
nikhil_k | It really doesn't belong in Glance but exists so we will go with it. | 18:13 |
nikhil_k | For your case, if we fix the filesystem driver | 18:13 |
nikhil_k | (for v2 ie) it should help | 18:14 |
nikhil_k | and for v1 we will need to find whether nova is setting size or not before uploading for the driver you are using | 18:14 |
*** annegentle has quit IRC | 18:14 | |
*** jdurgin1 has joined #openstack-glance | 18:15 | |
*** kebray has quit IRC | 18:15 | |
nikhil_k | vilobhmm1: ok, I need to run. Giving you my email in a pm. feel free to reach out if stuck | 18:15 |
vilobhmm1 | nikhil_k thanks for your time | 18:17 |
*** jdurgin has quit IRC | 18:17 | |
*** annegentle has joined #openstack-glance | 18:17 | |
vilobhmm1 | although i think we are missing something | 18:18 |
vilobhmm1 | esp for v1 | 18:18 |
*** sigmavirus24 is now known as sigmavirus24_awa | 18:19 | |
*** sjmc7 has quit IRC | 18:21 | |
*** kebray has joined #openstack-glance | 18:42 | |
*** annegentle has quit IRC | 18:45 | |
*** jdurgin has joined #openstack-glance | 18:46 | |
*** jdurgin1 has quit IRC | 18:48 | |
*** ayoung has quit IRC | 18:49 | |
*** aix has quit IRC | 18:49 | |
*** TravT_ has joined #openstack-glance | 18:51 | |
*** e0ne has joined #openstack-glance | 18:51 | |
*** e0ne is now known as e0ne_ | 18:51 | |
*** jaypipes has quit IRC | 18:52 | |
*** e0ne_ is now known as e0ne | 18:53 | |
*** sjmc7 has joined #openstack-glance | 18:57 | |
*** e0ne is now known as e0ne_ | 19:00 | |
*** greghaynes has quit IRC | 19:05 | |
*** greghaynes has joined #openstack-glance | 19:05 | |
*** annashen has quit IRC | 19:08 | |
*** annashen has joined #openstack-glance | 19:14 | |
*** annegentle has joined #openstack-glance | 19:16 | |
*** TravT_ has quit IRC | 19:24 | |
*** marcusvrn has quit IRC | 19:24 | |
*** annashen has quit IRC | 19:31 | |
*** e0ne_ is now known as e0ne | 19:35 | |
*** ivasilevskaya has quit IRC | 19:39 | |
*** BitSmith has joined #openstack-glance | 19:40 | |
*** TravT_ has joined #openstack-glance | 19:51 | |
*** TravT_ has quit IRC | 20:04 | |
*** annashen has joined #openstack-glance | 20:21 | |
*** GB21 has quit IRC | 20:29 | |
*** TravT_ has joined #openstack-glance | 20:31 | |
*** annegentle has quit IRC | 20:45 | |
*** e0ne has quit IRC | 20:54 | |
openstackgerrit | Merged openstack/glance: REST API layer for Artifact Repository https://review.openstack.org/136629 | 20:54 |
TravT_ | ativelkov mfedosin Congratulations! ^ | 20:58 |
*** jdurgin1 has joined #openstack-glance | 20:59 | |
*** jdurgin has quit IRC | 21:00 | |
*** raildo has quit IRC | 21:04 | |
-openstackstatus- NOTICE: Gerrit has been restarted to terminate a persistent looping third-party CI bot | 21:06 | |
*** ayoung has joined #openstack-glance | 21:09 | |
*** TravT_ has quit IRC | 21:11 | |
nikhil_k | vilobhmm1: hi | 21:12 |
*** annegentle has joined #openstack-glance | 21:13 | |
*** peristeri_ has quit IRC | 21:20 | |
*** BitSmith has quit IRC | 21:23 | |
vilobhmm1 | nikhil_k : hello | 21:26 |
vilobhmm1 | sorry was out for lunch | 21:27 |
openstackgerrit | Matt Riedemann proposed openstack/glance: Cleanup TODO in glance/gateway.py for elasticsearch being unavailable https://review.openstack.org/190823 | 21:28 |
openstackgerrit | Matt Riedemann proposed openstack/glance: Cleanup TODO in glance/gateway.py for elasticsearch being unavailable https://review.openstack.org/190823 | 21:30 |
nikhil_k | vilobhmm1: np | 21:32 |
nikhil_k | vilobhmm1: just reaching out to see if your query was resolved | 21:32 |
*** ayoung has quit IRC | 21:33 | |
vilobhmm1 | i didn't got a chance to take a deep dive into https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/filesystem.py | 21:33 |
kragniz | nikhil_k: mriedem's patch ^ probably shouldn't be merged, since the search code should be removed soonish | 21:34 |
nikhil_k | kragniz: what does it break? | 21:36 |
nikhil_k | vilobhmm1: gotcha | 21:36 |
kragniz | nothing, it's just more code that will need to be removed | 21:37 |
*** TravT_ has joined #openstack-glance | 21:37 | |
nikhil_k | vilobhmm1: np, I would like to know how you are not seeing the quota enfored to understand the flow. The quota impl is not very clean across APIs but the developer who implemented is pretty smart guy. It's just the use case that did not seem to fit well against the project scope. | 21:38 |
*** annegentle has quit IRC | 21:38 | |
nikhil_k | kragniz: we need this resolved by L1 as it's already delayed. Also, it's a tiny change. | 21:40 |
nikhil_k | vilobhmm1: so, lemme know when you do get to that piece of code | 21:40 |
kragniz | nikhil_k: you persuaded me :) | 21:40 |
nikhil_k | kragniz: heh | 21:41 |
kragniz | on that note, when do we want to start removing search code? | 21:41 |
kragniz | (for some reason I has l1 in my head, which was why I didn;t want that change) | 21:41 |
kragniz | had | 21:41 |
*** dims_ has joined #openstack-glance | 21:44 | |
vilobhmm1 | but from what you say…for v1…if we exceed the *instance snapshot* quota or the *storage space* to store images this fs driver will throw an exception…but this driver should throw an exception if the image size is big enough not if it exceeds quota right ? The link that you mentioned is for v2 https://review.openstack.org/#/c/37993/18/glance/api/v2/image_data.py what should be done for v1 ? Secondly even for v2 as part of http | 21:45 |
vilobhmm1 | nikhil_k : ^^ | 21:45 |
*** dims has quit IRC | 21:46 | |
*** jdurgin1 has quit IRC | 21:47 | |
*** TravT_ has quit IRC | 21:48 | |
nikhil_k | kragniz: TravT_ wants to keep it in Glance until we've repo setup (or he was more like keep until project is approved, I think). So, I am okay with it..but we can/should wait | 21:48 |
kragniz | nikhil_k: yeah, it should totally wait until the code is happy in a new repo | 21:49 |
*** jdurgin has joined #openstack-glance | 21:49 | |
*** annashen has quit IRC | 21:53 | |
*** annegentle has joined #openstack-glance | 22:00 | |
flwang | nikhil_k: ping | 22:01 |
nikhil_k | flwang: hey! | 22:02 |
nikhil_k | finally we meet :D | 22:02 |
flwang | yep :) | 22:02 |
flwang | do you have a few miniutes? | 22:02 |
nikhil_k | sure | 22:02 |
flwang | i would like to discuss some work i may focus in L | 22:02 |
nikhil_k | sure thing | 22:02 |
flwang | and it would be nice to get some comments from you | 22:02 |
flwang | 1. the Glance v2 in Nova | 22:03 |
flwang | 2. Show deleted images | 22:03 |
flwang | 3. Nested quota for HMT | 22:03 |
flwang | as for v2 in nova, you know, it's a long work, and i would be shamed to say we haven't completed it | 22:04 |
nikhil_k | flwang: do you have a link? | 22:04 |
flwang | so I would like to may it happen in L to make Glance move | 22:04 |
flwang | https://review.openstack.org/144875 | 22:04 |
nikhil_k | actually it's #1 priority for us | 22:04 |
flwang | flaper87 was working on that | 22:04 |
nikhil_k | but I don;t have a link handy :P | 22:04 |
flwang | but seems it don't have much bandwidth in this release, so I will take it | 22:05 |
nikhil_k | ok | 22:05 |
nikhil_k | flwang: jokke_ was interested in it too | 22:05 |
nikhil_k | flwang: and do let me know if I can help there | 22:05 |
flwang | i don't think it need much change in Glance, but i just want to make you are aware of this, in case I need some support/change from glance side | 22:05 |
nikhil_k | I am trying to sort some things (imp bugs) but then will come back to this) | 22:06 |
nikhil_k | flwang: we need changes-since support for it | 22:06 |
flwang | yep, that's one thing i would like to mention | 22:06 |
nikhil_k | we discussed this in mid-cycle and stevelle is going to fix that parity for us | 22:06 |
flwang | in v1 we can use changes-since to show deleted images and at least we have the parameter, but in v2, we don't | 22:07 |
nikhil_k | yeah | 22:07 |
flwang | yep, i had a discussion with stevelle and i think we can address this by making some change in glance to support query that | 22:07 |
sabari | rosmaita: ping | 22:07 |
flwang | so it may need some bless from you guys for those specs | 22:08 |
stevelle | I had to put aside the work for a few weeks, flwang and nikhil_k but I do expect to work on it more by around July | 22:08 |
flwang | stevelle: oh ! | 22:08 |
flwang | did you submit your spec? | 22:08 |
stevelle | no, I did not finish the edits after talking with you, flwang | 22:08 |
flwang | can you submit it as a draft so that we can start review it? and even i can help maintain it | 22:09 |
stevelle | I should be able to get a draft in before the next Glance meeting. | 22:09 |
nikhil_k | guys, so let's do this as team and people can still own parts of the code | 22:09 |
nikhil_k | So, thanks stevelle | 22:10 |
flwang | stevelle: it would be cool | 22:10 |
flwang | nikhil_k: btw, i would like to know your opinion about showing deleted images | 22:11 |
flwang | in v1, we can show deleted images, and it has been exposed by Nova i think | 22:12 |
flwang | but in v2, we completely disabled it | 22:12 |
flwang | i have a patch to address it, but rosmaita believe it deserves a bp/spec | 22:13 |
flwang | nikhil_k: https://review.openstack.org/172784 | 22:13 |
nikhil_k | flwang: how do we show deleted in v1? | 22:14 |
flwang | with changes-since | 22:15 |
nikhil_k | ah, only that ok | 22:15 |
flwang | yep, we support it in v1 api, but for cli, we missed it, see https://review.openstack.org/#/c/173738/ | 22:15 |
nikhil_k | flwang: I think it makes sense to show deleted for v2 | 22:18 |
nikhil_k | though there can be some issues | 22:19 |
nikhil_k | spec would be nice | 22:19 |
flwang | yep, i will submit a spec for that soon | 22:19 |
flwang | btw, can you review this https://review.openstack.org/#/c/173738/? | 22:19 |
flwang | and the #3 is nested quota for HMT | 22:20 |
nikhil_k | surely | 22:20 |
flwang | nova and cinder are working on this https://review.openstack.org/#/c/129420/ | 22:21 |
flwang | so i think it would be nice if glance can support that as well | 22:22 |
*** ayoung has joined #openstack-glance | 22:22 | |
flwang | and i think we also need a basic refactor work for our quota code | 22:22 |
*** annegentle has quit IRC | 22:23 | |
nikhil_k | flwang: ah, I see this was something talked about during the summit too. We need it for Glance | 22:27 |
nikhil_k | flwang: about the delete image thing | 22:27 |
nikhil_k | flwang: we need changes-since | 22:27 |
nikhil_k | why do you think we need to support filtering based on statuses | 22:27 |
nikhil_k | people are talking about removing some status fields | 22:28 |
nikhil_k | HMT is interesting but quite complex | 22:29 |
flwang | yep, i can see your point. as for the delete image thing, the point is not related to if we should query/show it by 'status', it's about if we should allow user see it | 22:32 |
rosmaita | sabari: pong | 22:32 |
flwang | and re nested quota, yep, it's very complex, so it's on my todo list but lower priority :) | 22:32 |
vilobhmm1 | nikhil_k : those are the 2 queries (^^) that I have…may be once you are free we can chat | 22:32 |
flwang | rosmaita: would you mind joining to discuss the deleted image? | 22:33 |
rosmaita | flwang: sure | 22:33 |
nikhil_k | I agree we need to support changes-since | 22:34 |
flwang | yep, but should the new 'changes-since' include deleted images? | 22:35 |
flwang | to be consistent with v1 | 22:35 |
nikhil_k | yep | 22:35 |
nikhil_k | flwang: nova also uses force show deleted flag afaik | 22:36 |
*** ericpeterson has quit IRC | 22:36 | |
nikhil_k | but we don't support it | 22:36 |
nikhil_k | flwang: we agree that v1&v2 changes-since should be completely compatible | 22:37 |
nikhil_k | however, filtering on status can be expensive as image status is not idx | 22:37 |
flwang | nova cli support 'nova list --deleted' to show deleted VMs | 22:37 |
sabari | rosmaita: I ping'd re https://review.openstack.org/#/c/190394/1. We did introduce mandatory properties in task_input and I am only removing one of them which is not in use. | 22:37 |
nikhil_k | flwang: I see, delete VMs | 22:37 |
sabari | rosmaita: wasn't sure if I followed you well enough :). | 22:37 |
nikhil_k | I thought you meant deleted images | 22:37 |
nikhil_k | flwang: +1 on images cli supporting changes-since | 22:38 |
rosmaita | sabari: where were these introduced? | 22:38 |
nikhil_k | v1 and v2 | 22:38 |
sabari | rosmaita: https://github.com/openstack/glance/blob/master/glance/common/scripts/utils.py#L62 | 22:39 |
sabari | rosmaita: We throw InvalidInput if we don't find those keys when creating a task. | 22:39 |
rosmaita | sabari: but the definitive statement of what's mandatory is the task schema | 22:40 |
sabari | rosmaita: Agree, we should remove this check altogether IMO but it's there to support import tasks. | 22:41 |
sabari | what I am removing is something not used even by the import task. | 22:41 |
rosmaita | what is utils.py used for? | 22:42 |
sabari | rosmaita: we check this in https://github.com/openstack/glance/blob/74aeb021c44021722825d1f2476f4756aeff69ff/glance/async/taskflow_executor.py#L87 | 22:42 |
sabari | before we run the task. | 22:42 |
rosmaita | we don't use image_properties either, do we? | 22:45 |
sabari | rosmaita: we do, we use it when creating the image record. | 22:47 |
sabari | ^ https://github.com/openstack/glance/blob/74aeb021c44021722825d1f2476f4756aeff69ff/glance/async/flows/base_import.py#L64 | 22:47 |
rosmaita | so we have a dependency between this utility script and the example tasks | 22:48 |
*** kebray has quit IRC | 22:48 | |
rosmaita | sabari: i think the idea is that the utility should support all tasks for all providers; the example tasks that come with glance are just examples for, for example, devstack | 22:49 |
rosmaita | so it's probably not appropriate for the utility to do validation | 22:50 |
rosmaita | beyond maybe making sure the input element is non-empty | 22:50 |
rosmaita | sabari: does that make sense? | 22:51 |
*** jgrimm is now known as zz_jgrimm | 22:51 | |
sabari | rosmaita: yes, I agree to that. | 22:51 |
sabari | but I am not too sure about the main script, what purpose does it have ? | 22:51 |
sabari | do we run it standalone ? | 22:52 |
rosmaita | i am not sure | 22:52 |
rosmaita | i dont' know a lot about the implementation at this point | 22:52 |
sabari | rosmaita: ok np, I just noticed it looked like a standalone script | 22:53 |
sabari | anyway | 22:53 |
nikhil_k | we don't use import_from_format either | 22:53 |
sabari | we should remove the validations that are meant for import tasks from the utility script | 22:53 |
nikhil_k | wait what? | 22:53 |
*** annashen has joined #openstack-glance | 22:54 | |
nikhil_k | atm we have 2 implementation for import if no one noticed | 22:54 |
sabari | nikhil_k: I have only seen the one tied to the tasks api | 22:54 |
nikhil_k | I have been keeping mum about them with the hope that someone will and delete it soon | 22:54 |
sabari | what's the other ? | 22:54 |
sabari | :D | 22:54 |
nikhil_k | glance/common/scripts/image_import/main.py | 22:55 |
nikhil_k | I am trying to avoid stepping on toes but things are breaking!! | 22:55 |
sabari | ^ yeah, I just noticed when Brian mentioned, so what does that do ? | 22:55 |
*** annashen has quit IRC | 22:55 | |
nikhil_k | it does the original import | 22:55 |
sabari | so what purpose does it serve, am a bit confused seeing it :) | 22:57 |
nikhil_k | sabari: nvm, we can discuss that later | 22:57 |
sabari | nikhil_k: k np. | 22:59 |
nikhil_k | I hope my answer helped you and rosmaita | 23:00 |
sabari | nikhil_k: kinda, is it okay if I remove the validations for task input tied with the api or come up with some way to do just for import tasks ? | 23:02 |
sabari | ^both without affecting the script | 23:02 |
nikhil_k | ah | 23:03 |
nikhil_k | so the validations were bring done at the api level primarily becasue we did not have the script at that time and people were arguing a lot on where they would/if they would be done | 23:03 |
nikhil_k | I would vote for removing the validation at the api except that the body must contain input | 23:04 |
sabari | nikhil_k: yeah sounds good. | 23:04 |
sabari | but in any case I feel import_from_format is not needed ;). | 23:04 |
nikhil_k | the response must contain all the fields as per the schema | 23:04 |
sabari | if the input required for import doesn't exist the task would automatically fail. | 23:05 |
nikhil_k | sabari: yeah | 23:05 |
nikhil_k | sabari: failing after validation > auto fail. Best to give the user a helpful message | 23:05 |
sabari | nikhil_k: we may need some task type registration kinda mechanism in the future, so we know what is needed for the known tasks. | 23:06 |
nikhil_k | task.message is text and can result into weird errors so, you know having a validation method would really help | 23:06 |
sabari | but not today :) | 23:06 |
nikhil_k | sabari: yeah! | 23:06 |
nikhil_k | exactly :) | 23:06 |
*** ayoung has quit IRC | 23:07 | |
sabari | nikhil_k: https://review.openstack.org/#/c/188388/ makes the need for it stronger, if you take a look. | 23:07 |
*** annashen has joined #openstack-glance | 23:11 | |
nikhil_k | Glance -> Async-Glance | 23:12 |
nikhil_k | Let's see there's some discoverability issues in terms of operations | 23:13 |
*** kebray has joined #openstack-glance | 23:18 | |
*** annashen has quit IRC | 23:21 | |
*** ccrouch has quit IRC | 23:22 | |
*** annegentle has joined #openstack-glance | 23:24 | |
*** annegentle has quit IRC | 23:29 | |
*** chlong has joined #openstack-glance | 23:35 | |
*** annashen has joined #openstack-glance | 23:38 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 23:39 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!