Thursday, 2015-06-11

*** BitSmith has quit IRC00:00
*** ducttape_ has quit IRC00:04
*** TravT_ has quit IRC00:08
*** belmoreira has joined #openstack-glance00:11
*** annashen has quit IRC00:16
vilobhmmnikhil_k : ^^00:27
*** tsekiyama has quit IRC00:36
openstackgerritOpenStack Proposal Bot proposed openstack/glance: Updated from global requirements  https://review.openstack.org/18611400:41
openstackgerritOpenStack Proposal Bot proposed openstack/glance_store: Updated from global requirements  https://review.openstack.org/18694100:41
*** mtanino has quit IRC00:44
*** ducttape_ has joined #openstack-glance00:44
*** ducttape_ has quit IRC00:44
*** annashen has joined #openstack-glance00:47
*** annashen has quit IRC00:54
sabarikragniz: db migrations tests are getting skipped in https://review.openstack.org/#/c/184373/. May be we want to hold that for now.00:57
sabari^ migrations tests for mysql00:57
*** chlong has quit IRC01:11
*** BitSmith has joined #openstack-glance01:13
*** BitSmith has quit IRC01:16
*** dims_ has joined #openstack-glance01:18
*** BitSmith has joined #openstack-glance01:19
*** dims has quit IRC01:21
*** tobe has joined #openstack-glance01:24
*** arnaud____ has joined #openstack-glance01:27
*** arnaud____ has quit IRC01:32
*** BitSmith is now known as [BitSmith]01:34
*** [BitSmith] is now known as BitSmith01:37
*** BitSmith is now known as [BitSmith]01:38
*** vilobhmm has quit IRC01:41
*** [BitSmith] is now known as BitSmith01:43
*** belmoreira has quit IRC01:50
*** marcusvrn has joined #openstack-glance02:01
*** BitSmith is now known as [BitSmith]02:07
*** [BitSmith] is now known as BitSmith02:07
*** dims_ has quit IRC02:33
*** BitSmith has quit IRC02:34
*** BitSmith has joined #openstack-glance02:40
*** BitSmith has quit IRC02:44
*** tobe has quit IRC02:46
*** tobe has joined #openstack-glance02:47
*** vilobhmm has joined #openstack-glance02:47
*** BitSmith has joined #openstack-glance02:47
*** tobe has quit IRC02:50
*** ajayaa has joined #openstack-glance02:51
*** tobe has joined #openstack-glance02:51
*** BitSmith has quit IRC02:54
*** vilobhmm has quit IRC02:59
*** david-lyle has joined #openstack-glance03:04
*** sgotliv_ has joined #openstack-glance03:05
*** arnaud____ has joined #openstack-glance03:16
*** arnaud____ has quit IRC03:21
*** dims has joined #openstack-glance03:34
*** kebray has joined #openstack-glance03:51
*** fifieldt has joined #openstack-glance03:58
*** ajayaa has quit IRC03:58
*** tobe has quit IRC04:04
*** TravT_ has joined #openstack-glance04:09
*** ayoung has quit IRC04:09
*** tobe has joined #openstack-glance04:13
*** ajayaa has joined #openstack-glance04:15
*** annashen has joined #openstack-glance04:22
*** marcusvrn has quit IRC04:24
*** annashen has quit IRC04:27
*** kebray has quit IRC04:32
*** changbl has joined #openstack-glance04:42
*** ajayaa has quit IRC04:50
*** haomaiw__ has joined #openstack-glance04:55
*** haomaiwang has quit IRC04:56
*** tobe has quit IRC04:56
*** tobe has joined #openstack-glance05:01
*** TravT_ has quit IRC05:18
*** belmoreira has joined #openstack-glance05:22
*** aswadr has joined #openstack-glance05:34
*** belmoreira has quit IRC05:38
*** ajayaa has joined #openstack-glance05:44
*** nlevinki has joined #openstack-glance05:49
*** haomaiw__ has quit IRC05:51
*** vilobhmm has joined #openstack-glance05:57
*** haomaiwang has joined #openstack-glance05:57
*** Murali has joined #openstack-glance06:04
*** haomaiwang has quit IRC06:18
*** haomaiwa_ has joined #openstack-glance06:19
*** annashen has joined #openstack-glance06:24
*** annashen has quit IRC06:29
*** aswadr has quit IRC06:35
*** groen692 has joined #openstack-glance06:48
*** abhishekk has joined #openstack-glance06:58
*** arnaud____ has joined #openstack-glance07:08
*** e0ne has joined #openstack-glance07:08
*** markus_z has joined #openstack-glance07:12
*** arnaud____ has quit IRC07:12
*** e0ne has quit IRC07:12
*** vilobhmm has quit IRC07:21
*** vilobhmm has joined #openstack-glance07:23
*** ajayaa has quit IRC07:27
*** e0ne has joined #openstack-glance07:28
*** e0ne has quit IRC07:29
*** ajayaa has joined #openstack-glance07:30
*** jistr has joined #openstack-glance07:33
*** takedakn has joined #openstack-glance07:46
*** vilobhmm has quit IRC07:46
*** takedakn has quit IRC07:52
*** ajayaa has quit IRC08:03
*** krykowski has joined #openstack-glance08:04
*** MattMan has quit IRC08:11
*** TravT_ has joined #openstack-glance08:23
*** annashen has joined #openstack-glance08:25
*** jistr has quit IRC08:27
*** annashen has quit IRC08:30
*** MattMan has joined #openstack-glance08:41
*** ajayaa has joined #openstack-glance08:42
*** jistr has joined #openstack-glance08:43
*** TravT_ has quit IRC08:55
*** pdb has quit IRC09:40
*** pdb has joined #openstack-glance09:40
*** dims_ has joined #openstack-glance09:44
kragnizsabari: ah, the switch isn't as seamless as I thought09:46
*** dims has quit IRC09:47
*** e0ne has joined #openstack-glance09:47
*** e0ne is now known as e0ne_09:54
*** TravT_ has joined #openstack-glance09:55
*** TravT_ has quit IRC10:00
*** e0ne_ has quit IRC10:00
*** e0ne has joined #openstack-glance10:01
*** BitSmith has joined #openstack-glance10:02
*** ajayaa has quit IRC10:12
*** BitSmith has quit IRC10:13
*** ajayaa has joined #openstack-glance10:16
*** annashen has joined #openstack-glance10:28
*** annashen has quit IRC10:32
*** e0ne is now known as e0ne_10:33
*** e0ne_ is now known as e0ne10:34
*** mfedosin has joined #openstack-glance10:39
openstackgerritGorka Eguileor proposed openstack/glance_store: Allow random read in RBD driver (get method)  https://review.openstack.org/15732510:43
*** aix has quit IRC11:07
*** openstackgerrit has quit IRC11:13
*** openstackgerrit has joined #openstack-glance11:14
*** TravT_ has joined #openstack-glance11:16
*** TravT_ has quit IRC11:21
*** e0ne is now known as e0ne_11:21
*** ducttape_ has joined #openstack-glance11:27
*** e0ne_ has quit IRC11:32
*** e0ne has joined #openstack-glance11:36
*** ducttape_ has quit IRC11:45
*** julim has joined #openstack-glance11:45
*** marcusvrn has joined #openstack-glance11:57
*** Murali_ has joined #openstack-glance12:00
*** Murali has quit IRC12:04
*** Murali_ has quit IRC12:05
*** Murali has joined #openstack-glance12:06
*** aix has joined #openstack-glance12:09
*** fifieldt has quit IRC12:53
*** Murali has quit IRC12:55
*** tobe has quit IRC12:55
*** Murali has joined #openstack-glance12:56
*** tobe has joined #openstack-glance12:57
*** ajayaa has quit IRC12:58
*** ajayaa has joined #openstack-glance12:59
*** ajayaa has quit IRC13:01
*** tobe has quit IRC13:02
*** TravT_ has joined #openstack-glance13:04
*** Longgeek_ has quit IRC13:06
*** ducttape_ has joined #openstack-glance13:07
*** ducttape_ has quit IRC13:08
*** ducttape_ has joined #openstack-glance13:09
*** TravT_ has quit IRC13:09
*** ducttape_ has quit IRC13:09
openstackgerritFlavio Percoco proposed openstack/python-glanceclient: Make glanceclient accept a session object  https://review.openstack.org/14199413:11
*** spzala has joined #openstack-glance13:13
*** sgotliv__ has joined #openstack-glance13:18
*** sgotliv_ has quit IRC13:20
*** stpierre has joined #openstack-glance13:25
*** annashen has joined #openstack-glance13:30
*** krykowski has quit IRC13:31
*** abhishekk has quit IRC13:32
*** annashen has quit IRC13:35
*** ccrouch has joined #openstack-glance13:42
*** peristeri has joined #openstack-glance13:51
*** ivasilevskaya has joined #openstack-glance13:55
nikhil_kCourtesy meeting reminder: ativelkov, cpallares, esheffield, flaper87, flwang1, hemanthm, ivasilevskaya, jokke_, kragniz, lakshmiS, mclaren, mfedosin, nikhil_k, Nikolay_St, Olena, pennerc, rosmaita, sigmavirus24, sabari, TravT, zhiyan, pkoniszewski, krykowski, ajayaa, GB21, bpoulos13:58
*** bpoulos has joined #openstack-glance13:58
*** TravT_ has joined #openstack-glance14:05
*** ducttape_ has joined #openstack-glance14:06
*** TravT_ has quit IRC14:10
*** sigmavirus24_awa is now known as sigmavirus2414:10
*** takedakn has joined #openstack-glance14:19
*** ericpeterson has joined #openstack-glance14:21
*** sjmc7 has joined #openstack-glance14:22
*** ducttape_ has quit IRC14:24
*** jaypipes has quit IRC14:26
*** zz_jgrimm is now known as jgrimm14:28
*** Murali has quit IRC14:33
*** e0ne is now known as e0ne_14:34
*** ayoung has joined #openstack-glance14:36
*** takedakn has quit IRC14:41
*** GB21 has joined #openstack-glance14:44
*** tsekiyama has joined #openstack-glance14:45
*** e0ne_ has quit IRC14:45
*** TravT_ has joined #openstack-glance14:51
*** mtanino has joined #openstack-glance14:52
*** dims_ has quit IRC15:02
*** dims has joined #openstack-glance15:02
*** bpoulos has left #openstack-glance15:04
*** nlevinki has quit IRC15:04
*** cpallares1 has joined #openstack-glance15:05
*** jistr is now known as jistr|mtg15:17
*** markus_z has quit IRC15:21
*** kebray has joined #openstack-glance15:23
*** BitSmith has joined #openstack-glance15:24
openstackgerritMerged openstack/python-glanceclient: Make glanceclient accept a session object  https://review.openstack.org/14199415:25
*** annashen has joined #openstack-glance15:32
*** ducttape_ has joined #openstack-glance15:32
*** groen692 has quit IRC15:32
*** ericpeterson has quit IRC15:33
*** jistr|mtg is now known as jistr15:35
*** annashen has quit IRC15:36
*** vilobhmm has joined #openstack-glance15:37
*** vilobhmm1 has joined #openstack-glance15:41
*** vilobhmm has quit IRC15:42
*** ericpeterson has joined #openstack-glance15:42
*** ducttape_ has quit IRC15:45
*** peristeri_ has joined #openstack-glance15:55
*** GB21 has quit IRC15:57
*** peristeri has quit IRC15:58
*** GB21 has joined #openstack-glance15:59
*** arnaud____ has joined #openstack-glance16:00
openstackgerritStuart McLaren proposed openstack/python-glanceclient: Close iterables at the end of iteration  https://review.openstack.org/19035916:01
openstackgerritFlavio Percoco proposed openstack/glance: Make utf8 the default charset for mysql  https://review.openstack.org/18134716:09
*** BitSmith has quit IRC16:10
*** vilobhmm1 has quit IRC16:15
*** arnaud____ has quit IRC16:20
*** e0ne has joined #openstack-glance16:27
*** r-daneel has joined #openstack-glance16:27
openstackgerritInessa Vasilevskaya proposed openstack/glance: Fix DbError when image params are out of range  https://review.openstack.org/18270316:27
*** jaypipes has joined #openstack-glance16:35
openstackgerritInessa Vasilevskaya proposed openstack/glance: Artifacts custom logic support  https://review.openstack.org/15709916:36
openstackgerritInessa Vasilevskaya proposed openstack/glance: Json schema generation for Artifact Type  https://review.openstack.org/13225316:37
openstackgerritInessa Vasilevskaya proposed openstack/glance: Alternative versioning schemas POC  https://review.openstack.org/18647316:37
openstackgerritInessa Vasilevskaya proposed openstack/glance: Proof of Concept of non-eventlet-based glance's service launch  https://review.openstack.org/16767316:38
*** vilobhmm has joined #openstack-glance16:40
*** vilobhmm1 has joined #openstack-glance16:41
ivasilevskayaguys, could you please have a look at the following bugfixes: https://review.openstack.org/#/c/182703/ and https://review.openstack.org/#/c/178697/ ?16:43
ivasilevskayaI'm taking a break with Glance contribution till the end of summer and I'd like to have no technicall debt left. They are small and not too boring to review :)16:43
*** vilobhmm has quit IRC16:44
*** annashen has joined #openstack-glance16:45
openstackgerritInessa Vasilevskaya proposed openstack/glance: Fix HTTP 500 on NotAuthenticated in registry (v1)  https://review.openstack.org/17869716:53
*** ayoung has quit IRC16:54
*** annegentle has joined #openstack-glance17:03
*** e0ne has quit IRC17:09
nikhil_kflaper87: can you add your preference for jul28 on https://docs.google.com/spreadsheets/d/1w0eI6SPCA2IrOyHiEYC2uDO3fbYGzahZRUQSva0UD3Y/edit#gid=0 ?17:11
nikhil_kthat column is getting feedback17:11
nikhil_kothers too, sigmavirus24 kragniz jokke_ jcook rosmaita ativelkov mfedosin sabari ^17:12
sabarinikhil_k: thanks, almost forgot :)17:13
sigmavirus24nikhil_k: I'm just going to go ahead and predict I won't be able to make it17:13
sigmavirus24because sprint priorities or something17:13
nikhil_kivasilevskaya: sure :) seems like some conversation there. Who would be a POC/someone you okay rebasing, if we need more changes?17:14
jcooknikhil_k: updated17:15
nikhil_ksigmavirus24: gotcha. We will try to make Video work/engaging as best possible..17:15
nikhil_kthanks sabari jcook17:16
vilobhmm1nikhil_k : ping17:16
nikhil_kdavid-lyle: TravT_: fyi ^17:16
nikhil_kvilobhmm1: hi17:16
vilobhmm1Does glance maintain instance snapshot quota ?17:16
vilobhmm1since glance does not have any cli to display the same17:16
vilobhmm1https://blueprints.launchpad.net/glance/+spec/glance-basic-quotas talk about it…but not sure if thats what its meant for ?17:16
vilobhmm1nikhil_k : ^^17:16
nikhil_kvilobhmm1: ah sorry, I missed your ping earlier..17:16
vilobhmm1np17:17
nikhil_kvilobhmm1: we have quota for image storage17:17
jcooknikhil_k: np sir17:17
sigmavirus24nikhil_k: for me, it's more important to be able to hear people than see things17:17
sigmavirus24so if we can figure out a mumble set-up that'd be helpful17:17
* sigmavirus24 lunch17:17
nikhil_kok, some technology that enables better hearing sigmavirus24 :-) (sure)17:18
vilobhmm1nikhil_k : not for instance snapshot ?17:19
nikhil_kvilobhmm1: see thsi config, user_storage_quota = 017:19
nikhil_kone sec17:19
vilobhmm1though https://review.openstack.org/#/c/37993/17:19
*** ayoung has joined #openstack-glance17:19
vilobhmm1sure17:19
nikhil_kvilobhmm1: yep, did you see the reply to the ML on that convo17:20
nikhil_kwe may have to look for the subject but it was related to that spec you mentioned here17:20
vilobhmm1no i haven't seen such a ML conv17:20
nikhil_kGB21: hi17:21
GB21hi nikhil_k17:21
nikhil_kvilobhmm1: ok, let me find it17:21
nikhil_kvilobhmm1: https://github.com/openstack/glance/blob/master/etc/glance-api.conf#L29217:21
nikhil_klooking for the ML convo17:21
vilobhmm1nikhil_k : thnx :) does that mean glance will maintain *instance snapshot* quota17:22
GB21nikhil_k, I have a question, the internal server error I ws getting, in the sabari's comments  "If you17:22
GB21 sync your code, you should no more be seeing 500 but a 201", does syncying means that I do ./unstack.sh and then again ./stack.sh17:22
nikhil_kvilobhmm1: https://www.mail-archive.com/openstack-dev@lists.openstack.org/msg53246.html17:23
GB21Doing this again gave me an internal server error in the installation17:23
nikhil_kvilobhmm1: there's not specific quota kept aside17:23
nikhil_kvilobhmm1: though, I think the answer you are looking for and is, is yes17:23
nikhil_kGB21: what do you mean by sycn your code?17:24
nikhil_kinternall server error in installation?17:24
nikhil_kis github or any websites that devstack referes to down? Do check your logs for it17:25
GB21That is what I want to ask, what does it exactly means as when I googled it, I found that I should update devstack17:25
GB21for that I needed to unstack it and then again stack it17:25
GB21but when I stack it again, I get the same error i.e internal server error 50017:26
GB21this is the same error I got while creating the tasks17:26
sabariGB21: I meant a git pull.17:27
sabariSorry I need to run but will back shortly.17:27
GB21sabari, ohk17:28
GB21sabari, thanks17:28
nikhil_kGB21: unstack/stack rejoin-stack won't do a git pull unless you have deleted the repo17:28
nikhil_kGB21: so, here's my recommendation17:28
nikhil_k1. Don't do unstack/stack if you have stuff working under your devstack install17:29
vilobhmm1nikhil_k : ok…if the answer is yes…a follow up question is why don't we do a pre-check whether we have available space to create a snap before hand…..because none of that happen..till the image is actually created…17:29
vilobhmm1as what i saw in https://review.openstack.org/#/c/37993/17:29
nikhil_k2. do, git fetch/git pull for your latest changes.17:29
vilobhmm1and if the instance snapshot is created by trigerring "nova image-create"17:29
nikhil_k3. restart glance-api and glance-reg (by hitting ctrl+c, up arrow and enter on the resp. screens)17:30
nikhil_k4. test and enjoy further work :P17:30
GB21nikhil_k, ohk, thanks :D17:30
vilobhmm1nikhil_k : even the check doesn't seem to be there as part of "glance image-create" or am i missing something obvious here ?17:31
nikhil_kvilobhmm1: so the storage quota exists to ensure that we do not overfill the backend storage systems glance is using. Also, we have some way to restrict people from DOSing17:31
GB21 nikhil_k, when we do stack.sh doesnt it updates itself everytime?17:32
nikhil_knova image-create essentially triggers what glance image-create is17:32
nikhil_kGB21: not if the repo is pulled already17:32
GB21nikhil_k, ohk17:32
nikhil_kvilobhmm1: There is where the openstack service boundaries make a little bit of different17:32
nikhil_kdifference*17:33
vilobhmm1nikhil_k : my point is there doesn't see a validation step ( which validates "am i runnning above quota") in the image-create17:33
vilobhmm1see = *seem to be*17:33
nikhil_kvilobhmm1: Please correct me if I am wrong but not all virt drivers can deterministically calculate the image size before snapshot happens. snapshot happening can be multi-step process:17:34
nikhil_k1. HV does the magic to create snapshot17:34
*** TravT_ has quit IRC17:34
nikhil_k2. snapshot is uploaded to glance17:34
nikhil_k3. snapshot size if checked17:35
*** jistr has quit IRC17:35
nikhil_kif nova/cinder/ironic stream snap data without being aware of the size17:35
vilobhmm1nikhil_k : should'nt the snapshot size check against quota happen before uploading snapshot to glance ?17:35
vilobhmm1nikhil_k : what do you think ? please correct if i am missing anything17:38
nikhil_kvilobhmm1: we don't require users to specify size of the image during creation/upload so no. May be we can enforce it for v217:38
nikhil_kv2 has a 2 step process and size is passed in during upload17:39
nikhil_kalthough17:39
nikhil_kumm, let me think a bit more17:40
nikhil_kI think it may be tricky for some cases like import17:40
nikhil_kmay be not17:40
vilobhmm1but during *instance snap* creation looks like from what you said above image-size can;t be computed beforehand…specifying image size is not an option IMHO17:40
vilobhmm1nikhil_k: ^^17:40
nikhil_kif we have converted image during import process then not, otherwise yes17:40
nikhil_kvilobhmm1: yep. nova isn't using v2 yet so when that happens we will know how many virt drivers are affected17:41
vilobhmm1is this documented somewhere ? is there a blueprint/spec/etherpad for it ?17:42
vilobhmm1nikhil_k : ^^17:42
nikhil_kvilobhmm1: for ?17:42
nikhil_knova using v2?17:42
vilobhmm1* v2 has a 2 step process and size is passed in during upload * and also checking for *instance snapshot* quota…esp for the quota thing if there is not i can go ahead and file a blueprint17:43
nikhil_kvilobhmm1: http://developer.openstack.org/api-ref-image-v2.html17:44
vilobhmm1for the quota thing nikhil_k17:45
vilobhmm1thanks for the link17:45
nikhil_kvilobhmm1: not yet17:46
vilobhmm1should i go ahead and file a blueprint17:46
vilobhmm1i think it should be a good start17:46
vilobhmm1what you think ?17:46
nikhil_kvilobhmm1: you can, I did not get your pre-check query. If you see the api ref, we actually do the pre check for image v2 api17:47
nikhil_kvilobhmm1: but like I also said17:48
nikhil_kit may be dofficult for the nova virt drivers to enable that migration17:48
nikhil_kso we will have to see how that goes17:48
nikhil_kvilobhmm1: does that help much?17:49
vilobhmm1nikhil_k : what i meant by pre-check…is lets say *instance snap* quota is 50 GB (with 20GB free) and then when someone does a nova image-create/glance image-create of a 40GB instance….(snap size say 21GB) so before uploading the created snap which is 21 GB to glance…glance should do a pre-check "whether the created snap exceed my free available quota for instance snapshot (which is 20GB)"17:50
nikhil_kI see how it's confusing here17:51
nikhil_kvilobhmm1: https://review.openstack.org/#/c/37993/18/glance/api/v2/image_data.py17:51
vilobhmm1so if the pre-check fails …don;t upload the snap to glance…as anyhow after upload it will fail17:51
vilobhmm1as upload won't go through17:52
vilobhmm1does that make sense nikhil_k17:52
nikhil_kvilobhmm1: ok, I think we may need to discuss a bit more on these lines:17:56
nikhil_k1. Do we need fine grained quotas? (user/tenant level)?17:57
nikhil_k2. Are quotas working for all backend storage systems?17:57
nikhil_k3. Does snapshot quota fall under the above category?17:57
nikhil_kvilobhmm1: if you see https://review.openstack.org/#/c/37993/18/glance/api/v2/image_data.py lines 54, 8617:58
nikhil_kif the backend knows that for that size of the image, storage won't be able to handle the set_data call, we should see it raised before upload actually happens17:59
vilobhmm1yes18:02
nikhil_kvilobhmm1: but for v1 (that is currently being used by Nova), see https://review.openstack.org/#/c/37993/18/glance/api/v1/upload_utils.py (check quota happens before but is lazy check) so you may see delay if size if not set18:03
vilobhmm1exception.StorageFull or exception.StorageQuotaFull should be raised if set_data exceeds the limit (which in fact is a logical calculation before doing actual save/write on the backend)18:04
nikhil_kyeah18:04
nikhil_kvilobhmm1: what storage are you using?18:05
vilobhmm1local file system..nothing fancy18:05
nikhil_khmm, may be we need to check the filesystem store dirver -- when does it raise this exception18:06
vilobhmm1ok18:06
vilobhmm1but doen't glance maintain something in glance db which will help to do the logical calculation as part of set_data ( this table is db should be in sync with what we have on the undelying backend i mean how much free space etc calc)…18:07
vilobhmm1that should help here IMHO18:07
vilobhmm1rather than waiting for the driver to raise the exception18:08
vilobhmm1nikhil_k : ^^18:08
nikhil_kvilobhmm1: glance cannot maintain that quota information. if you see on the BP, the feedback was already given that a new service in openstack that handles quota should do it18:08
nikhil_kglance uses something called multiple locations18:09
nikhil_kso, you may store data in more than one type of store18:09
vilobhmm1ok…but you said above glance maintains *instance snapshot* quota..I am confused now :(18:09
nikhil_kglance maintains an overall quota18:09
vilobhmm1ok18:09
nikhil_kmore like a hard cap18:09
vilobhmm1ok18:10
nikhil_kbut that's also because glance itself can act as backend store18:10
nikhil_kusing filesystem18:10
nikhil_kvilobhmm1: you can see here https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/filesystem.py (look for storagefull)18:11
vilobhmm1ok18:11
nikhil_kmay be we should remove it in glance18:12
openstackgerritStuart McLaren proposed openstack/python-glanceclient: Close iterables at the end of iteration  https://review.openstack.org/19035918:12
nikhil_kI see that implementation done to compromise a little bit on the responsiblity share18:13
nikhil_kIt really doesn't belong in Glance but exists so we will go with it.18:13
nikhil_kFor your case, if we fix the filesystem driver18:13
nikhil_k(for v2 ie) it should help18:14
nikhil_kand for v1 we will need to find whether nova is setting size or not before uploading for the driver you are using18:14
*** annegentle has quit IRC18:14
*** jdurgin1 has joined #openstack-glance18:15
*** kebray has quit IRC18:15
nikhil_kvilobhmm1: ok, I need to run. Giving you my email in a pm. feel free to reach out if stuck18:15
vilobhmm1nikhil_k thanks for your time18:17
*** jdurgin has quit IRC18:17
*** annegentle has joined #openstack-glance18:17
vilobhmm1although i think we are missing something18:18
vilobhmm1esp for v118:18
*** sigmavirus24 is now known as sigmavirus24_awa18:19
*** sjmc7 has quit IRC18:21
*** kebray has joined #openstack-glance18:42
*** annegentle has quit IRC18:45
*** jdurgin has joined #openstack-glance18:46
*** jdurgin1 has quit IRC18:48
*** ayoung has quit IRC18:49
*** aix has quit IRC18:49
*** TravT_ has joined #openstack-glance18:51
*** e0ne has joined #openstack-glance18:51
*** e0ne is now known as e0ne_18:51
*** jaypipes has quit IRC18:52
*** e0ne_ is now known as e0ne18:53
*** sjmc7 has joined #openstack-glance18:57
*** e0ne is now known as e0ne_19:00
*** greghaynes has quit IRC19:05
*** greghaynes has joined #openstack-glance19:05
*** annashen has quit IRC19:08
*** annashen has joined #openstack-glance19:14
*** annegentle has joined #openstack-glance19:16
*** TravT_ has quit IRC19:24
*** marcusvrn has quit IRC19:24
*** annashen has quit IRC19:31
*** e0ne_ is now known as e0ne19:35
*** ivasilevskaya has quit IRC19:39
*** BitSmith has joined #openstack-glance19:40
*** TravT_ has joined #openstack-glance19:51
*** TravT_ has quit IRC20:04
*** annashen has joined #openstack-glance20:21
*** GB21 has quit IRC20:29
*** TravT_ has joined #openstack-glance20:31
*** annegentle has quit IRC20:45
*** e0ne has quit IRC20:54
openstackgerritMerged openstack/glance: REST API layer for Artifact Repository  https://review.openstack.org/13662920:54
TravT_ativelkov mfedosin Congratulations! ^20:58
*** jdurgin1 has joined #openstack-glance20:59
*** jdurgin has quit IRC21:00
*** raildo has quit IRC21:04
-openstackstatus- NOTICE: Gerrit has been restarted to terminate a persistent looping third-party CI bot21:06
*** ayoung has joined #openstack-glance21:09
*** TravT_ has quit IRC21:11
nikhil_kvilobhmm1: hi21:12
*** annegentle has joined #openstack-glance21:13
*** peristeri_ has quit IRC21:20
*** BitSmith has quit IRC21:23
vilobhmm1nikhil_k : hello21:26
vilobhmm1sorry was out for lunch21:27
openstackgerritMatt Riedemann proposed openstack/glance: Cleanup TODO in glance/gateway.py for elasticsearch being unavailable  https://review.openstack.org/19082321:28
openstackgerritMatt Riedemann proposed openstack/glance: Cleanup TODO in glance/gateway.py for elasticsearch being unavailable  https://review.openstack.org/19082321:30
nikhil_kvilobhmm1: np21:32
nikhil_kvilobhmm1: just reaching out to see if your query was resolved21:32
*** ayoung has quit IRC21:33
vilobhmm1i didn't got a chance to take a deep dive into https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/filesystem.py21:33
kragniznikhil_k: mriedem's patch ^ probably shouldn't be merged, since the search code should be removed soonish21:34
nikhil_kkragniz: what does it break?21:36
nikhil_kvilobhmm1: gotcha21:36
kragniznothing, it's just more code that will need to be removed21:37
*** TravT_ has joined #openstack-glance21:37
nikhil_kvilobhmm1: np, I would like to know how you are not seeing the quota enfored to understand the flow. The quota impl is not very clean across APIs but the developer who implemented is pretty smart guy. It's just the use case that did not seem to fit well against the project scope.21:38
*** annegentle has quit IRC21:38
nikhil_kkragniz: we need this resolved by L1 as it's already delayed. Also, it's a tiny change.21:40
nikhil_kvilobhmm1: so, lemme know when you do get to that piece of code21:40
kragniznikhil_k: you persuaded me :)21:40
nikhil_kkragniz: heh21:41
kragnizon that note, when do we want to start removing search code?21:41
kragniz(for some reason I has l1 in my head, which was why I didn;t want that change)21:41
kragnizhad21:41
*** dims_ has joined #openstack-glance21:44
vilobhmm1but from what you say…for v1…if we exceed the *instance snapshot* quota or the *storage space* to store images this fs driver will throw an exception…but this driver should throw an exception if the image size is big enough not if it exceeds quota right ? The link that you mentioned is for v2  https://review.openstack.org/#/c/37993/18/glance/api/v2/image_data.py what should be done for v1 ? Secondly even for v2 as part of http21:45
vilobhmm1nikhil_k : ^^21:45
*** dims has quit IRC21:46
*** jdurgin1 has quit IRC21:47
*** TravT_ has quit IRC21:48
nikhil_kkragniz: TravT_ wants to keep it in Glance until we've repo setup (or he was more like keep until project is approved, I think). So, I am okay with it..but we can/should wait21:48
kragniznikhil_k: yeah, it should totally wait until the code is happy in a new repo21:49
*** jdurgin has joined #openstack-glance21:49
*** annashen has quit IRC21:53
*** annegentle has joined #openstack-glance22:00
flwangnikhil_k: ping22:01
nikhil_kflwang: hey!22:02
nikhil_kfinally we meet :D22:02
flwangyep :)22:02
flwangdo you have a few miniutes?22:02
nikhil_ksure22:02
flwangi would like to discuss some work i may focus in L22:02
nikhil_ksure thing22:02
flwangand it would be nice to get some comments from you22:02
flwang1. the Glance v2 in Nova22:03
flwang2. Show deleted images22:03
flwang3. Nested quota for HMT22:03
flwangas for v2 in nova, you know, it's a long work, and i would be shamed to say we haven't completed it22:04
nikhil_kflwang: do you have a link?22:04
flwangso I would like to may it happen in L to make Glance move22:04
flwanghttps://review.openstack.org/14487522:04
nikhil_kactually it's #1 priority for us22:04
flwangflaper87 was working on that22:04
nikhil_kbut I don;t have a link handy :P22:04
flwangbut seems it don't have much bandwidth in this release, so I will take it22:05
nikhil_kok22:05
nikhil_kflwang: jokke_ was interested in it too22:05
nikhil_kflwang: and do let me know if I can help there22:05
flwangi don't think it need much change in Glance, but i just want to make you are aware of this, in case I need some support/change from glance side22:05
nikhil_kI am trying to sort some things (imp bugs) but then will come back to this)22:06
nikhil_kflwang: we need changes-since support for it22:06
flwangyep, that's one thing i would like to mention22:06
nikhil_kwe discussed this in mid-cycle and stevelle is going to fix that parity for us22:06
flwangin v1 we can use changes-since to show deleted images and at least we have the parameter, but in v2, we don't22:07
nikhil_kyeah22:07
flwangyep, i had a discussion with stevelle and i think we can address this by making some change in glance to support query that22:07
sabarirosmaita: ping22:07
flwangso it may need some bless from you guys for those specs22:08
stevelleI had to put aside the work for a few weeks, flwang and nikhil_k but I do expect to work on it more by around July22:08
flwangstevelle: oh !22:08
flwangdid you submit your spec?22:08
stevelleno, I did not finish the edits after talking with you, flwang22:08
flwangcan you submit it as a draft so that we can start review it? and even i can help maintain it22:09
stevelleI should be able to get a draft in before the next Glance meeting.22:09
nikhil_kguys, so let's do this as team and people can still own parts of the code22:09
nikhil_kSo, thanks stevelle22:10
flwangstevelle:  it would be cool22:10
flwangnikhil_k: btw, i would like to know your opinion about showing deleted images22:11
flwangin v1, we can show deleted images, and it has been exposed by Nova i think22:12
flwangbut in v2, we completely disabled it22:12
flwangi have a patch to address it, but rosmaita believe it deserves a bp/spec22:13
flwangnikhil_k: https://review.openstack.org/17278422:13
nikhil_kflwang: how do we show deleted in v1?22:14
flwangwith changes-since22:15
nikhil_kah, only that ok22:15
flwangyep, we support it in v1 api, but for cli, we missed it, see https://review.openstack.org/#/c/173738/22:15
nikhil_kflwang: I think it makes sense to show deleted for v222:18
nikhil_kthough there can be some issues22:19
nikhil_kspec would be nice22:19
flwangyep, i will submit a spec for that soon22:19
flwangbtw, can you review this https://review.openstack.org/#/c/173738/?22:19
flwangand the #3 is nested quota for HMT22:20
nikhil_ksurely22:20
flwangnova and cinder are working on this https://review.openstack.org/#/c/129420/22:21
flwangso i think it would be nice if glance can support that as well22:22
*** ayoung has joined #openstack-glance22:22
flwangand i think we also need a basic refactor work for our quota code22:22
*** annegentle has quit IRC22:23
nikhil_kflwang: ah, I see this was something talked about during the summit too. We need it for Glance22:27
nikhil_kflwang: about the delete image thing22:27
nikhil_kflwang: we need changes-since22:27
nikhil_kwhy do you think we need to support filtering based on statuses22:27
nikhil_kpeople are talking about removing some status fields22:28
nikhil_kHMT is interesting but quite complex22:29
flwangyep, i can see your point. as for the delete image thing, the point is not related to if we should query/show it by 'status', it's about if we should allow user see it22:32
rosmaitasabari: pong22:32
flwangand re nested quota, yep, it's very complex, so it's on my todo list but lower priority :)22:32
vilobhmm1nikhil_k : those are the 2 queries (^^) that I have…may be once you are free we can chat22:32
flwangrosmaita: would you mind joining to discuss the deleted image?22:33
rosmaitaflwang: sure22:33
nikhil_kI agree we need to support changes-since22:34
flwangyep, but should the new 'changes-since' include deleted images?22:35
flwangto be consistent with v122:35
nikhil_kyep22:35
nikhil_kflwang: nova also uses force show deleted flag afaik22:36
*** ericpeterson has quit IRC22:36
nikhil_kbut we don't support it22:36
nikhil_kflwang: we agree that v1&v2 changes-since should be completely compatible22:37
nikhil_khowever, filtering on status can be expensive as image status is not idx22:37
flwangnova cli support 'nova list --deleted' to show deleted VMs22:37
sabarirosmaita: I ping'd re https://review.openstack.org/#/c/190394/1. We did introduce mandatory properties in task_input and I am only removing one of them which is not in use.22:37
nikhil_kflwang: I see, delete VMs22:37
sabarirosmaita: wasn't sure if I followed you well enough :).22:37
nikhil_kI thought you meant deleted images22:37
nikhil_kflwang: +1 on images cli supporting changes-since22:38
rosmaitasabari: where were these introduced?22:38
nikhil_kv1 and v222:38
sabarirosmaita: https://github.com/openstack/glance/blob/master/glance/common/scripts/utils.py#L6222:39
sabarirosmaita: We throw InvalidInput if we don't find those keys when creating a task.22:39
rosmaitasabari: but the definitive statement of what's mandatory is the task schema22:40
sabarirosmaita: Agree, we should remove this check altogether IMO but it's there to support import tasks.22:41
sabariwhat I am removing is something not used even by the import task.22:41
rosmaitawhat is utils.py used for?22:42
sabarirosmaita: we check this in https://github.com/openstack/glance/blob/74aeb021c44021722825d1f2476f4756aeff69ff/glance/async/taskflow_executor.py#L8722:42
sabaribefore we run the task.22:42
rosmaitawe don't use image_properties either, do we?22:45
sabarirosmaita: we do, we use it when creating the image record.22:47
sabari^ https://github.com/openstack/glance/blob/74aeb021c44021722825d1f2476f4756aeff69ff/glance/async/flows/base_import.py#L6422:47
rosmaitaso we have a dependency between this utility script and the example tasks22:48
*** kebray has quit IRC22:48
rosmaitasabari: i think the idea is that the utility should support all tasks for all providers; the example tasks that come with glance are just examples for, for example, devstack22:49
rosmaitaso it's probably not appropriate for the utility to do validation22:50
rosmaitabeyond maybe making sure the input element is non-empty22:50
rosmaitasabari: does that make sense?22:51
*** jgrimm is now known as zz_jgrimm22:51
sabarirosmaita: yes, I agree to that.22:51
sabaribut I am not too sure about the main script, what purpose does it have ?22:51
sabarido we run it standalone ?22:52
rosmaitai am not sure22:52
rosmaitai dont' know a lot about the implementation at this point22:52
sabarirosmaita: ok np, I just noticed it looked like a standalone script22:53
sabarianyway22:53
nikhil_kwe don't use import_from_format either22:53
sabariwe should remove the validations that are meant for import tasks from the utility script22:53
nikhil_kwait what?22:53
*** annashen has joined #openstack-glance22:54
nikhil_katm we have 2 implementation for import if no one noticed22:54
sabarinikhil_k: I have only seen the one tied to the tasks api22:54
nikhil_kI have been keeping mum about them with the hope that someone will and delete it soon22:54
sabariwhat's the other ?22:54
sabari:D22:54
nikhil_kglance/common/scripts/image_import/main.py22:55
nikhil_kI am trying to avoid stepping on toes but things are breaking!!22:55
sabari^ yeah, I just noticed when Brian mentioned, so what does that do ?22:55
*** annashen has quit IRC22:55
nikhil_kit does the original import22:55
sabariso what purpose does it serve, am a bit confused seeing it :)22:57
nikhil_ksabari: nvm, we can discuss that later22:57
sabarinikhil_k: k np.22:59
nikhil_kI hope my answer helped you and rosmaita23:00
sabarinikhil_k: kinda, is it okay if I remove the validations for task input tied with the api or come up with some way to do just for import tasks ?23:02
sabari^both without affecting the script23:02
nikhil_kah23:03
nikhil_kso the validations were bring done at the api level primarily becasue we did not have the script at that time and people were arguing a lot on where they would/if they would be done23:03
nikhil_kI would vote for removing the validation at the api except that the body must contain input23:04
sabarinikhil_k: yeah sounds good.23:04
sabaribut in any case I feel import_from_format is not needed ;).23:04
nikhil_kthe response must contain all the fields as per the schema23:04
sabariif the input required for import doesn't exist the task would automatically fail.23:05
nikhil_ksabari: yeah23:05
nikhil_ksabari: failing after validation > auto fail. Best to give the user a helpful message23:05
sabarinikhil_k: we may need some task type registration kinda mechanism in the future, so we know what is needed for the known tasks.23:06
nikhil_ktask.message is text and can result into weird errors so, you know having a validation method would really help23:06
sabaribut not today :)23:06
nikhil_ksabari: yeah!23:06
nikhil_kexactly :)23:06
*** ayoung has quit IRC23:07
sabarinikhil_k: https://review.openstack.org/#/c/188388/ makes the need for it stronger, if you take a look.23:07
*** annashen has joined #openstack-glance23:11
nikhil_kGlance -> Async-Glance23:12
nikhil_kLet's see there's some discoverability issues in terms of operations23:13
*** kebray has joined #openstack-glance23:18
*** annashen has quit IRC23:21
*** ccrouch has quit IRC23:22
*** annegentle has joined #openstack-glance23:24
*** annegentle has quit IRC23:29
*** chlong has joined #openstack-glance23:35
*** annashen has joined #openstack-glance23:38
*** sigmavirus24_awa is now known as sigmavirus2423:39

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!