*** annashen has joined #openstack-glance | 00:24 | |
*** annashen_ has joined #openstack-glance | 00:35 | |
*** tsekiyam_ has joined #openstack-glance | 00:36 | |
*** jasondotstar has quit IRC | 00:38 | |
*** tsekiyama has quit IRC | 00:39 | |
*** dims has quit IRC | 00:40 | |
*** annashen_ has quit IRC | 00:40 | |
*** mtanino has quit IRC | 00:40 | |
*** tsekiyam_ has quit IRC | 00:41 | |
*** primechuck has joined #openstack-glance | 00:41 | |
*** primechuck has quit IRC | 00:42 | |
*** primechuck has joined #openstack-glance | 00:43 | |
*** primechu_ has joined #openstack-glance | 00:44 | |
*** primechuck has quit IRC | 00:44 | |
*** shosagoudar has joined #openstack-glance | 00:44 | |
*** annegentle has joined #openstack-glance | 00:44 | |
*** annashen has quit IRC | 00:45 | |
*** annashen has joined #openstack-glance | 00:46 | |
*** annashen has quit IRC | 00:46 | |
*** shosagoudar has quit IRC | 00:48 | |
*** annegentle has quit IRC | 00:49 | |
*** h00327910_ has joined #openstack-glance | 00:49 | |
*** primechu_ has quit IRC | 00:52 | |
*** lan__ has quit IRC | 00:54 | |
*** lan__ has joined #openstack-glance | 00:55 | |
*** shalq has quit IRC | 01:07 | |
*** Longgeek has joined #openstack-glance | 01:19 | |
*** MentalRay has joined #openstack-glance | 01:21 | |
*** chlong has joined #openstack-glance | 01:21 | |
*** dims has joined #openstack-glance | 01:24 | |
*** dims has quit IRC | 01:25 | |
*** harshs_ has quit IRC | 01:25 | |
*** dims has joined #openstack-glance | 01:26 | |
*** mingdang1 has joined #openstack-glance | 01:30 | |
*** jasondotstar has joined #openstack-glance | 01:32 | |
*** annashen has joined #openstack-glance | 01:36 | |
*** dims has quit IRC | 01:36 | |
*** dims has joined #openstack-glance | 01:37 | |
*** tobe has joined #openstack-glance | 01:39 | |
*** annashen has quit IRC | 01:41 | |
*** dims has quit IRC | 01:42 | |
*** Longgeek has quit IRC | 01:52 | |
*** haomaiwang has quit IRC | 01:56 | |
*** kebray has quit IRC | 01:58 | |
*** harshs has quit IRC | 02:13 | |
*** haomaiwa_ has joined #openstack-glance | 02:16 | |
*** shosagoudar has joined #openstack-glance | 02:30 | |
*** spzala has quit IRC | 02:32 | |
*** shosagoudar has quit IRC | 02:34 | |
*** nightanne has joined #openstack-glance | 02:34 | |
*** annashen has joined #openstack-glance | 02:37 | |
*** dims has joined #openstack-glance | 02:38 | |
*** tpeoples has quit IRC | 02:41 | |
*** annashen has quit IRC | 02:42 | |
*** dims has quit IRC | 02:43 | |
*** haomaiwa_ has quit IRC | 02:52 | |
*** haomaiwa_ has joined #openstack-glance | 02:52 | |
*** rwsu has quit IRC | 03:11 | |
*** shosagoudar has joined #openstack-glance | 03:31 | |
*** tpeoples has joined #openstack-glance | 03:32 | |
*** nightanne has quit IRC | 03:35 | |
*** nightanne has joined #openstack-glance | 03:36 | |
*** kebray has joined #openstack-glance | 03:36 | |
*** annashen has joined #openstack-glance | 03:38 | |
*** annashen has quit IRC | 03:43 | |
*** tpeoples has quit IRC | 03:43 | |
*** tpeoples has joined #openstack-glance | 03:43 | |
*** annashen has joined #openstack-glance | 03:48 | |
*** Longgeek has joined #openstack-glance | 03:49 | |
*** nightanne has quit IRC | 04:09 | |
*** Longgeek has quit IRC | 04:17 | |
*** haomaiwa_ has quit IRC | 04:20 | |
*** arnaud___ has joined #openstack-glance | 04:24 | |
*** MentalRay has quit IRC | 04:34 | |
*** annashen has quit IRC | 04:38 | |
*** haomaiwang has joined #openstack-glance | 04:39 | |
*** annashen has joined #openstack-glance | 04:39 | |
*** annashen has quit IRC | 04:43 | |
*** tobe has quit IRC | 04:44 | |
*** changbl has joined #openstack-glance | 04:45 | |
*** jasondotstar has quit IRC | 04:48 | |
*** arnaud___ has quit IRC | 04:50 | |
*** arnaud___ has joined #openstack-glance | 04:52 | |
*** sgotliv has joined #openstack-glance | 04:55 | |
*** ajayaa has joined #openstack-glance | 04:56 | |
*** dims has joined #openstack-glance | 05:03 | |
*** dims_ has joined #openstack-glance | 05:04 | |
*** haomaiwang has quit IRC | 05:04 | |
*** haomaiwang has joined #openstack-glance | 05:06 | |
*** dims has quit IRC | 05:08 | |
*** dims_ has quit IRC | 05:08 | |
*** annashen has joined #openstack-glance | 05:09 | |
*** ajayaa has quit IRC | 05:10 | |
*** tdp has joined #openstack-glance | 05:18 | |
*** tpeoples has quit IRC | 05:18 | |
*** kebray_ has joined #openstack-glance | 05:21 | |
*** kebray has quit IRC | 05:25 | |
*** ajayaa has joined #openstack-glance | 05:37 | |
*** david-ly_ has joined #openstack-glance | 05:37 | |
*** gberginc has joined #openstack-glance | 05:38 | |
*** annashen_ has joined #openstack-glance | 05:40 | |
*** david-lyle has quit IRC | 05:40 | |
*** annashen_ has quit IRC | 05:44 | |
*** ig0r__ has joined #openstack-glance | 05:52 | |
*** ig0r_ has quit IRC | 05:55 | |
*** Miouge has joined #openstack-glance | 05:59 | |
*** annashen has quit IRC | 06:00 | |
*** dims has joined #openstack-glance | 06:01 | |
*** haomaiwang has quit IRC | 06:04 | |
*** annashen has joined #openstack-glance | 06:07 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance: Imported Translations from Transifex https://review.openstack.org/197206 | 06:07 |
---|---|---|
*** haomaiwa_ has joined #openstack-glance | 06:08 | |
*** dims has quit IRC | 06:09 | |
*** bfic has joined #openstack-glance | 06:10 | |
*** dims has joined #openstack-glance | 06:13 | |
*** dims_ has joined #openstack-glance | 06:14 | |
*** Longgeek has joined #openstack-glance | 06:15 | |
*** dims has quit IRC | 06:17 | |
*** groen692 has joined #openstack-glance | 06:19 | |
*** dims_ has quit IRC | 06:21 | |
*** dims has joined #openstack-glance | 06:22 | |
*** Longgeek has quit IRC | 06:24 | |
*** dims has quit IRC | 06:27 | |
*** kebray_ has quit IRC | 06:40 | |
*** annashen_ has joined #openstack-glance | 06:40 | |
*** annashen has quit IRC | 06:42 | |
*** tobe has joined #openstack-glance | 06:45 | |
*** annashen_ has quit IRC | 06:46 | |
*** Longgeek has joined #openstack-glance | 06:48 | |
*** ajayaa has quit IRC | 06:58 | |
*** ajayaa has joined #openstack-glance | 06:59 | |
*** jistr has joined #openstack-glance | 07:16 | |
*** jamielennox is now known as jamielennox|away | 07:17 | |
*** markus_z has joined #openstack-glance | 07:19 | |
*** arnaud___ has quit IRC | 07:25 | |
*** cloudnull has quit IRC | 07:26 | |
*** sigmavirus24_awa has quit IRC | 07:27 | |
*** haomaiwa_ has quit IRC | 07:27 | |
*** haomaiwa_ has joined #openstack-glance | 07:28 | |
*** d34dh0r53 has quit IRC | 07:30 | |
*** eglute has quit IRC | 07:30 | |
*** shosagoudar has quit IRC | 07:31 | |
*** stevelle has quit IRC | 07:32 | |
*** shosagoudar has joined #openstack-glance | 07:32 | |
*** tdp has quit IRC | 07:35 | |
*** exploreshaifali has joined #openstack-glance | 07:41 | |
*** chlong has quit IRC | 08:10 | |
*** dims has joined #openstack-glance | 08:40 | |
*** annashen has joined #openstack-glance | 08:42 | |
*** dims has quit IRC | 08:45 | |
*** annashen has quit IRC | 08:47 | |
*** lan__ has quit IRC | 08:59 | |
*** lakshmiS has joined #openstack-glance | 08:59 | |
*** lan__ has joined #openstack-glance | 09:00 | |
*** jistr has quit IRC | 09:00 | |
*** jistr has joined #openstack-glance | 09:16 | |
openstackgerrit | Niall Bunting proposed openstack/glance: Catch update to a non-existent artifact property https://review.openstack.org/200057 | 09:27 |
*** bdossant has joined #openstack-glance | 09:35 | |
*** Miouge has quit IRC | 09:35 | |
*** annashen has joined #openstack-glance | 09:43 | |
*** exploreshaifali has quit IRC | 09:43 | |
*** annashen has quit IRC | 09:47 | |
*** e0ne has joined #openstack-glance | 09:51 | |
*** bfic has quit IRC | 09:57 | |
*** bfic has joined #openstack-glance | 09:59 | |
*** bfic has quit IRC | 10:02 | |
*** jasondotstar has joined #openstack-glance | 10:20 | |
*** dims has joined #openstack-glance | 10:28 | |
*** Miouge has joined #openstack-glance | 10:29 | |
*** dims_ has joined #openstack-glance | 10:29 | |
*** Miouge has quit IRC | 10:30 | |
*** Miouge has joined #openstack-glance | 10:32 | |
*** dims has quit IRC | 10:33 | |
openstackgerrit | James Page proposed openstack/python-glanceclient: Drop byte conversion for loading CA certificates https://review.openstack.org/200463 | 10:33 |
*** dims_ has quit IRC | 10:34 | |
*** haomaiwa_ has quit IRC | 10:40 | |
*** lakshmiS has quit IRC | 10:40 | |
*** vijendar has quit IRC | 10:43 | |
*** annashen has joined #openstack-glance | 10:44 | |
*** annashen has quit IRC | 10:48 | |
*** e0ne is now known as e0ne_ | 10:49 | |
openstackgerrit | James Page proposed openstack/python-glanceclient: Drop byte conversion for loading CA certificates https://review.openstack.org/200463 | 10:52 |
*** eglute has joined #openstack-glance | 10:53 | |
*** jamielennox|away is now known as jamielennox | 10:54 | |
*** d34dh0r53 has joined #openstack-glance | 10:54 | |
*** bfic has joined #openstack-glance | 10:55 | |
*** e0ne_ is now known as e0ne | 11:01 | |
*** vijendar has joined #openstack-glance | 11:05 | |
*** cdelatte has joined #openstack-glance | 11:07 | |
*** delattec has joined #openstack-glance | 11:07 | |
*** vijendar1 has joined #openstack-glance | 11:09 | |
*** vijendar has quit IRC | 11:11 | |
*** bfic has quit IRC | 11:12 | |
*** tobe has quit IRC | 11:15 | |
*** tobe has joined #openstack-glance | 11:16 | |
*** Miouge has quit IRC | 11:32 | |
*** e0ne is now known as e0ne_ | 11:35 | |
*** annashen has joined #openstack-glance | 11:45 | |
*** tobe has quit IRC | 11:45 | |
*** mingdang1 has quit IRC | 11:45 | |
*** vijendar1 has quit IRC | 11:46 | |
*** vijendar has joined #openstack-glance | 11:47 | |
*** vijendar has left #openstack-glance | 11:49 | |
*** annashen has quit IRC | 11:50 | |
*** bfic has joined #openstack-glance | 11:52 | |
*** Miouge has joined #openstack-glance | 11:57 | |
*** Miouge has quit IRC | 12:04 | |
*** Miouge has joined #openstack-glance | 12:05 | |
*** nightanne has joined #openstack-glance | 12:08 | |
*** nightanne is now known as morninganne | 12:11 | |
*** Miouge has quit IRC | 12:12 | |
*** Miouge has joined #openstack-glance | 12:13 | |
*** jasondotstar has quit IRC | 12:13 | |
*** lakshmiS has joined #openstack-glance | 12:14 | |
*** dims has joined #openstack-glance | 12:15 | |
*** ig0r__ has quit IRC | 12:17 | |
*** Miouge has quit IRC | 12:19 | |
*** dims has quit IRC | 12:20 | |
*** jaypipes has joined #openstack-glance | 12:20 | |
*** Miouge has joined #openstack-glance | 12:21 | |
*** e0ne_ is now known as e0ne | 12:21 | |
*** ig0r_ has joined #openstack-glance | 12:23 | |
*** david-lyle has joined #openstack-glance | 12:28 | |
*** chlong has joined #openstack-glance | 12:28 | |
*** julim has joined #openstack-glance | 12:29 | |
*** Miouge has quit IRC | 12:30 | |
*** david-ly_ has quit IRC | 12:30 | |
*** Miouge has joined #openstack-glance | 12:31 | |
*** edmondsw has joined #openstack-glance | 12:32 | |
*** ccrouch has joined #openstack-glance | 12:37 | |
*** dims has joined #openstack-glance | 12:41 | |
*** Miouge has quit IRC | 12:43 | |
*** vijendar1 has joined #openstack-glance | 12:43 | |
*** Miouge has joined #openstack-glance | 12:44 | |
*** Miouge has quit IRC | 12:44 | |
*** annashen has joined #openstack-glance | 12:45 | |
*** e0ne is now known as e0ne_ | 12:46 | |
*** Miouge has joined #openstack-glance | 12:46 | |
*** e0ne_ is now known as e0ne | 12:47 | |
*** leseb- has joined #openstack-glance | 12:49 | |
leseb- | hi all | 12:49 |
*** raildo_ has joined #openstack-glance | 12:50 | |
*** annashen has quit IRC | 12:50 | |
leseb- | any chance to get some attention on this spec? I believe we are ready to move forward: https://review.openstack.org/#/c/188388/ | 12:51 |
*** Miouge has quit IRC | 12:51 | |
*** raildo_ has quit IRC | 12:51 | |
*** zeddii has joined #openstack-glance | 12:51 | |
*** rosmaita has quit IRC | 12:54 | |
*** bfic has quit IRC | 12:55 | |
*** brianr has joined #openstack-glance | 13:01 | |
*** brianr is now known as rosmaita | 13:01 | |
*** bfic has joined #openstack-glance | 13:07 | |
*** cloudnull has joined #openstack-glance | 13:09 | |
*** jamielennox is now known as jamielennox|away | 13:09 | |
*** GeetikaBatra has joined #openstack-glance | 13:10 | |
*** jasondotstar has joined #openstack-glance | 13:10 | |
*** haomaiwa_ has joined #openstack-glance | 13:10 | |
*** haomaiwa_ has quit IRC | 13:11 | |
*** vijendar1 has quit IRC | 13:11 | |
*** haomaiwang has joined #openstack-glance | 13:11 | |
*** vijendar has joined #openstack-glance | 13:11 | |
*** GeetikaBatra is now known as GB21 | 13:13 | |
*** peristeri has joined #openstack-glance | 13:16 | |
openstackgerrit | Niall Bunting proposed openstack/glance: Catch update to a non-existent artifact property https://review.openstack.org/200057 | 13:22 |
*** primechuck has joined #openstack-glance | 13:24 | |
*** aix has quit IRC | 13:29 | |
*** bfic has quit IRC | 13:30 | |
*** morninganne has quit IRC | 13:31 | |
*** bfic has joined #openstack-glance | 13:34 | |
*** bfic has quit IRC | 13:34 | |
*** Miouge has joined #openstack-glance | 13:41 | |
*** morninganne has joined #openstack-glance | 13:42 | |
*** morninganne has quit IRC | 13:43 | |
*** exploreshaifali has joined #openstack-glance | 13:46 | |
*** annashen has joined #openstack-glance | 13:46 | |
*** annashen has quit IRC | 13:51 | |
*** mingdang_ has joined #openstack-glance | 13:57 | |
*** aix has joined #openstack-glance | 13:59 | |
*** morninganne has joined #openstack-glance | 14:01 | |
*** sigmavirus24_awa has joined #openstack-glance | 14:04 | |
*** tpeoples has joined #openstack-glance | 14:04 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 14:04 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 14:05 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 14:05 | |
*** Miouge has quit IRC | 14:06 | |
*** Miouge has joined #openstack-glance | 14:06 | |
openstackgerrit | Darja Shakhray proposed openstack/glance: Glance to handle exceptions from glance_store https://review.openstack.org/200000 | 14:07 |
openstackgerrit | Mike Fedosin proposed openstack/glance_store: Prevent glance-api hangups during connection to rbd https://review.openstack.org/200554 | 14:10 |
*** morninganne has quit IRC | 14:11 | |
*** Miouge has quit IRC | 14:11 | |
*** Miouge has joined #openstack-glance | 14:12 | |
*** Miouge has quit IRC | 14:12 | |
sigmavirus24 | kragniz: those test failures are lifeless's fault ;) | 14:15 |
kragniz | sigmavirus24: ikr | 14:15 |
sigmavirus24 | kragniz: no I'm serious. He's the mock maintainer now =P | 14:16 |
openstackgerrit | Louis Taylor proposed openstack/glance: Remove usage of assert_called_once in mocks https://review.openstack.org/200559 | 14:20 |
*** pbourke has quit IRC | 14:20 | |
* kragniz shakes his fist in the general direction of mock | 14:20 | |
*** pbourke has joined #openstack-glance | 14:21 | |
*** jistr is now known as jistr|mtg | 14:22 | |
*** mtanino has joined #openstack-glance | 14:23 | |
sigmavirus24 | wait what | 14:24 |
sigmavirus24 | that's the problem? | 14:24 |
sigmavirus24 | What happened to assert_called_once? | 14:24 |
sigmavirus24 | kragniz: ooo | 14:25 |
sigmavirus24 | I was thinking of assert_called_once_with(..) | 14:25 |
kragniz | sigmavirus24: it never existed | 14:26 |
sigmavirus24 | kragniz: yeah, I confused it | 14:26 |
sigmavirus24 | ENEEDMORECOFFEE | 14:26 |
kragniz | I think that's what happened to everyone! | 14:26 |
kragniz | and then the tests pass, so everyone thinks it's okay | 14:27 |
sigmavirus24 | yuuuup | 14:29 |
sigmavirus24 | Well I don't think that's the problem in flake8 | 14:29 |
sigmavirus24 | But I'll check | 14:29 |
kragniz | are flake8 tests failing too? | 14:29 |
sigmavirus24 | Nope that's not it | 14:30 |
sigmavirus24 | They were until I capped the mock version | 14:30 |
kragniz | there are other things it broke, but I think the assert_called_once thing is all that hit glance | 14:30 |
sigmavirus24 | See both http://ci.sigmavir.us/job/flake8/121/TOXENV=py27/console and our Travis job | 14:31 |
sigmavirus24 | So one thing is assert_called | 14:31 |
sigmavirus24 | Which I guess didn't ever exist either lol | 14:31 |
*** Miouge has joined #openstack-glance | 14:31 | |
kragniz | just don't trust assert_* at all ;) | 14:31 |
*** mingdang_ has quit IRC | 14:33 | |
sigmavirus24 | lol | 14:33 |
sigmavirus24 | assert_called_once_with works | 14:33 |
sigmavirus24 | apparently someone wrote tests with assert_called | 14:33 |
sigmavirus24 | Which I've never used anywhere else | 14:33 |
sigmavirus24 | I always assert that thing.called is True | 14:33 |
kragniz | just think how much extra test coverage this mock release is going to cause! | 14:35 |
leseb- | any chance to get some attention on this spec? I believe we are ready to move forward: https://review.openstack.org/#/c/188388/ | 14:36 |
*** exploreshaifali has quit IRC | 14:36 | |
*** morninganne has joined #openstack-glance | 14:39 | |
kragniz | leseb-: we're being very slow with spec approvals lately | 14:39 |
kragniz | it's likely more attention will be given to that and the other specs in the queue in the next few weeks | 14:40 |
leseb- | kragniz: yes I've noticed :), any reasons behind this? short on reviewers? | 14:40 |
leseb- | ok I see :) | 14:40 |
*** dims has quit IRC | 14:40 | |
leseb- | will wait until this happens then, thanks kragniz | 14:41 |
kragniz | leseb-: see http://lists.openstack.org/pipermail/openstack-dev/2015-July/068424.html | 14:42 |
leseb- | yes I read this, I might have missed the last updates though | 14:43 |
*** annashen has joined #openstack-glance | 14:47 | |
*** fifieldt has quit IRC | 14:49 | |
*** morninganne has quit IRC | 14:50 | |
*** morninganne has joined #openstack-glance | 14:51 | |
*** annashen has quit IRC | 14:52 | |
sigmavirus24 | leseb-: can you make the glance-drivers meeting? | 14:52 |
sigmavirus24 | or just the next glance meeting | 14:52 |
sigmavirus24 | either should work | 14:52 |
leseb- | sigmavirus24: when is it? | 14:52 |
sigmavirus24 | glance drivers are Tuesdays at 1400 UTC, glance meetings are Thursdays at 1400 UTC | 14:53 |
sigmavirus24 | So 50 minutes prior to now roughly on Tuesdays or Thursdays | 14:53 |
*** chlong is now known as chlong-weekend | 14:54 | |
leseb- | sigmavirus24: k I'll join Thursdays one (Tuesday is Bastille Day for me) | 14:54 |
kragniz | sigmavirus24: we have a slight problem, two of those asserts fail | 14:55 |
*** flwang has quit IRC | 14:58 | |
*** jaypipes has quit IRC | 14:59 | |
*** dims has joined #openstack-glance | 15:07 | |
sigmavirus24 | kragniz: that's joyful | 15:07 |
*** dims_ has joined #openstack-glance | 15:07 | |
sigmavirus24 | fixerated tests | 15:07 |
*** alex_xu has quit IRC | 15:08 | |
*** alex_xu has joined #openstack-glance | 15:10 | |
*** ducttape_ has joined #openstack-glance | 15:11 | |
*** dims has quit IRC | 15:11 | |
*** kebray has joined #openstack-glance | 15:13 | |
sigmavirus24 | kragniz: so https://gitlab.com/pycqa/flake8/issues/74 is a fun bug | 15:13 |
*** r-daneel has joined #openstack-glance | 15:16 | |
kragniz | sigmavirus24: that looks... interesting | 15:16 |
*** ig0r__ has joined #openstack-glance | 15:19 | |
*** tpeoples has quit IRC | 15:20 | |
sigmavirus24 | kragniz: that feature has been around for a while (multiprocessing) but I've never seen that before | 15:20 |
*** ig0r_ has quit IRC | 15:22 | |
kragniz | it's possible they have something weird with their env | 15:22 |
kragniz | sigmavirus24: so the failures are these two: https://github.com/openstack/glance/blob/master/glance/tests/unit/async/test_taskflow_executor.py#L79-80 | 15:23 |
kragniz | we could just disable them to get the gate up and running again | 15:24 |
*** tsekiyama has joined #openstack-glance | 15:26 | |
*** chlong-weekend has quit IRC | 15:26 | |
sigmavirus24 | kragniz: can you link me the failed test output? | 15:27 |
sigmavirus24 | Is it calling it more than once? | 15:27 |
sigmavirus24 | If so we can just assert that those mocks were called and ignore call count for now | 15:27 |
sigmavirus24 | That sill gives us an assertion but doesn't preserve the meaning of the original test | 15:27 |
sigmavirus24 | We can also add a TODO and a bug about it | 15:27 |
*** e0ne is now known as e0ne_ | 15:28 | |
kragniz | sigmavirus24: it's called 0 times | 15:28 |
sigmavirus24 | O_O | 15:28 |
sigmavirus24 | So that isn't patching things correctly then | 15:29 |
kragniz | sigmavirus24: https://jenkins05.openstack.org/job/gate-glance-python27/1366/console | 15:29 |
kragniz | at 2015-07-10 14:39:46.346 | 15:29 |
*** e0ne_ is now known as e0ne | 15:29 | |
*** jistr|mtg is now known as jistr | 15:30 | |
*** harshs has joined #openstack-glance | 15:30 | |
*** tpeoples has joined #openstack-glance | 15:31 | |
sigmavirus24 | kragniz: that should be engine.run.call_count | 15:35 |
sigmavirus24 | kragniz: that's from https://github.com/openstack/glance/blob/master/glance/async/taskflow_executor.py#L127 | 15:37 |
kragniz | sigmavirus24: cool! That fixed it | 15:37 |
sigmavirus24 | We only use engines.load in one place: https://github.com/openstack/glance/blob/master/glance/async/taskflow_executor.py#L124 | 15:38 |
*** ajayaa has quit IRC | 15:42 | |
*** lakshmiS has quit IRC | 15:45 | |
*** arnaud___ has joined #openstack-glance | 15:46 | |
*** Miouge has quit IRC | 15:46 | |
*** annashen has joined #openstack-glance | 15:48 | |
*** TravT has quit IRC | 15:48 | |
*** harshs has quit IRC | 15:49 | |
sigmavirus24 | kragniz: does that fix it for us? | 15:52 |
*** rwsu has joined #openstack-glance | 15:52 | |
sigmavirus24 | load_mock will be called once as we expect, and that other one should cover us appropriately | 15:53 |
*** annashen has quit IRC | 15:53 | |
*** TravT has joined #openstack-glance | 15:53 | |
kragniz | yes, it fixed that test | 15:54 |
*** groen692 has quit IRC | 15:54 | |
kragniz | these ones are also not being called: https://github.com/openstack/glance/blob/9d4225289b3486d64fd396a684cba14ef762e765/glance/tests/unit/v2/test_tasks_resource.py#L315-L318 | 15:54 |
sigmavirus24 | any others we're having issues with? | 15:54 |
kragniz | yup, I didn't spot those ones I just linked | 15:55 |
*** flwang has joined #openstack-glance | 15:55 | |
*** jistr has quit IRC | 15:55 | |
*** groen692 has joined #openstack-glance | 15:55 | |
sigmavirus24 | kragniz: so | 15:57 |
*** bdossant has quit IRC | 15:57 | |
sigmavirus24 | mock_get_task_factory should have a return_value set | 15:58 |
sigmavirus24 | whatever mock is used for that return_value is what needs new_task.return_value set | 15:58 |
sigmavirus24 | e.g. | 15:58 |
sigmavirus24 | mock_factory = mock.Mock() | 15:58 |
sigmavirus24 | mock_get_task_factory.return_value = mock_factory | 15:58 |
sigmavirus24 | mock_factory.new_task.return_value = ... | 15:59 |
sigmavirus24 | then mock_factory.new_task.call_count == 1 | 15:59 |
sigmavirus24 | etc. | 15:59 |
sigmavirus24 | make sense/ | 15:59 |
*** groen692 has quit IRC | 15:59 | |
kragniz | yup, makes sense! | 15:59 |
*** ducttape_ has quit IRC | 16:00 | |
openstackgerrit | Mike Fedosin proposed openstack/glance_store: Remove usage of assert_called_once in mocks https://review.openstack.org/200604 | 16:00 |
*** ducttape_ has joined #openstack-glance | 16:00 | |
*** Miouge has joined #openstack-glance | 16:00 | |
*** MentalRay has joined #openstack-glance | 16:03 | |
*** stevelle has joined #openstack-glance | 16:04 | |
sigmavirus24 | I think we all know who wrote all these tests with "assert_called_once" | 16:05 |
* sigmavirus24 gives flaper87 the stink eye | 16:05 | |
*** mgarza has joined #openstack-glance | 16:09 | |
*** e0ne has quit IRC | 16:11 | |
mfedosin | it's funny, but today I saw assert_called_twice | 16:12 |
kragniz | assert_called_three_times_with_some_sugar_on_top | 16:13 |
kragniz | it passes, so it much work! | 16:14 |
kragniz | must | 16:14 |
*** kebray has quit IRC | 16:32 | |
*** arnaud___ has quit IRC | 16:35 | |
*** harshs has joined #openstack-glance | 16:43 | |
*** dims_ has quit IRC | 16:46 | |
*** dims has joined #openstack-glance | 16:46 | |
*** dims has quit IRC | 16:47 | |
*** dims has joined #openstack-glance | 16:47 | |
*** annashen has joined #openstack-glance | 16:49 | |
*** annashen has quit IRC | 16:50 | |
*** annashen has joined #openstack-glance | 16:50 | |
*** Miouge has quit IRC | 16:52 | |
*** Miouge has joined #openstack-glance | 16:53 | |
mfedosin | flaper87, hi! I made a commit to glance_store with rados connection timeout. https://review.openstack.org/#/c/200554/ review it, please :) you promised =P | 16:57 |
*** Longgeek has quit IRC | 16:58 | |
openstackgerrit | Olena Logvinova proposed openstack/glance: Adds a rados_connect_timeout description https://review.openstack.org/200625 | 16:58 |
*** kebray has joined #openstack-glance | 16:59 | |
*** bitblt has joined #openstack-glance | 17:01 | |
*** MentalRay has quit IRC | 17:08 | |
*** cdelatte has quit IRC | 17:09 | |
*** delattec has quit IRC | 17:09 | |
*** TravT_ has joined #openstack-glance | 17:10 | |
*** TravT has quit IRC | 17:13 | |
*** TravT_ has quit IRC | 17:15 | |
*** TravT has joined #openstack-glance | 17:18 | |
*** e0ne has joined #openstack-glance | 17:28 | |
*** eandersson has quit IRC | 17:32 | |
*** cdelatte has joined #openstack-glance | 17:33 | |
*** delattec has joined #openstack-glance | 17:33 | |
*** TravT is now known as TravT_away | 17:45 | |
*** e0ne has quit IRC | 17:52 | |
*** e0ne has joined #openstack-glance | 17:54 | |
*** e0ne has quit IRC | 17:58 | |
*** Longgeek has joined #openstack-glance | 17:58 | |
*** sgotliv has quit IRC | 18:02 | |
*** Miouge has quit IRC | 18:04 | |
*** Longgeek has quit IRC | 18:07 | |
*** morninganne has quit IRC | 18:10 | |
*** reets has joined #openstack-glance | 18:11 | |
reets | Hello everyone cloned new copy of devstack today and having issue with g-api start | 18:12 |
*** Miouge has joined #openstack-glance | 18:12 | |
*** boris-42 has quit IRC | 18:12 | |
sigmavirus24 | I haven't sorry reets | 18:13 |
sigmavirus24 | kragniz: you still around? | 18:13 |
reets | i checked the logs it says could not bind to 0.0.0.0:9292 after waiting for 30 seconds | 18:21 |
*** aix has quit IRC | 18:21 | |
reets | any fix suggestion for this | 18:21 |
*** dims has quit IRC | 18:29 | |
sigmavirus24 | reets: that means the port was likely already in use | 18:29 |
sigmavirus24 | check to see if something's running using that, otherwise try to stack again | 18:29 |
*** exploreshaifali has joined #openstack-glance | 18:35 | |
reets | i checked what processes are using port 9292 | 18:37 |
reets | killed all and restarted again and had same issue | 18:37 |
*** wko has joined #openstack-glance | 18:42 | |
*** annashen has quit IRC | 18:45 | |
*** markus_z has quit IRC | 18:46 | |
*** harlowja_ has quit IRC | 18:46 | |
openstackgerrit | Ian Cordasco proposed openstack/glance: Remove usage of assert_called_once in mocks https://review.openstack.org/200559 | 18:49 |
*** harlowja has joined #openstack-glance | 18:50 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance: Updated from global requirements https://review.openstack.org/200666 | 18:57 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance_store: Updated from global requirements https://review.openstack.org/200667 | 18:57 |
*** morninganne has joined #openstack-glance | 19:03 | |
*** Longgeek has joined #openstack-glance | 19:05 | |
*** d34dh0r53 is now known as th31nt3rn | 19:05 | |
*** etoews has quit IRC | 19:07 | |
*** dims has joined #openstack-glance | 19:12 | |
*** morninganne is now known as annegentle | 19:12 | |
openstackgerrit | Rico Lin proposed openstack/python-glanceclient: New mock release(1.1.0) broke unit/function tests https://review.openstack.org/200685 | 19:15 |
*** dims has quit IRC | 19:17 | |
*** dims has joined #openstack-glance | 19:17 | |
*** exploreshaifali has quit IRC | 19:18 | |
*** ig0r__ has quit IRC | 19:19 | |
*** ig0r_ has joined #openstack-glance | 19:19 | |
*** ducttape_ has quit IRC | 19:21 | |
*** ducttape_ has joined #openstack-glance | 19:22 | |
*** annashen has joined #openstack-glance | 19:26 | |
*** ducttape_ has quit IRC | 19:26 | |
lifeless | sigmavirus24: yes, thats the bulk of the issues. A library that made virtual things exist let you call virtual methods that didn't exist. | 19:27 |
lifeless | sigmavirus24: its kindof classic ugly, having two interfaces on one object | 19:28 |
sigmavirus24 | yup | 19:28 |
openstackgerrit | Merged openstack/glance_store: Remove usage of assert_called_once in mocks https://review.openstack.org/200604 | 19:28 |
sigmavirus24 | lifeless: also, thanks for taking up maintenance of mock | 19:29 |
sigmavirus24 | even if you did cause lots of headaches today =P | 19:29 |
sigmavirus24 | jogo had added a couple assert_called_once()'s to flake8's tests at some point | 19:29 |
*** kebray has quit IRC | 19:36 | |
lifeless | sigmavirus24: to be clear, I'm backporting it to keep things more sane, not because I want people to use it :) | 19:37 |
sigmavirus24 | What's entertaining-ish to me is that I hadn't seen these issues using unittest.mock on 3.4 | 19:38 |
*** Longgeek has quit IRC | 19:38 | |
*** mtanino has quit IRC | 19:42 | |
lifeless | the unsafe thing is in 3.5 I think | 19:43 |
lifeless | this is one of the advantages of a systemic backport | 19:44 |
*** raildo_ has joined #openstack-glance | 19:44 | |
*** th31nt3rn is now known as d34dh0r53 | 19:45 | |
*** ducttape_ has joined #openstack-glance | 19:46 | |
*** reets has quit IRC | 19:47 | |
*** Miouge has quit IRC | 19:48 | |
*** rmcall has joined #openstack-glance | 19:51 | |
*** rmcall has quit IRC | 19:53 | |
openstackgerrit | Mike Fedosin proposed openstack/glance_store: Prevent glance-api hangups during connection to rbd https://review.openstack.org/200554 | 19:53 |
*** GB21 has quit IRC | 19:56 | |
*** rwsu has quit IRC | 19:58 | |
*** kebray has joined #openstack-glance | 20:05 | |
*** harlowja has quit IRC | 20:09 | |
*** harlowja has joined #openstack-glance | 20:09 | |
*** bitblt has quit IRC | 20:14 | |
*** shosagoudar has quit IRC | 20:16 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance: Updated from global requirements https://review.openstack.org/200666 | 20:17 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance_store: Updated from global requirements https://review.openstack.org/200667 | 20:17 |
openstackgerrit | Mike Fedosin proposed openstack/python-glanceclient: Glance v3 client basic methods https://review.openstack.org/192261 | 20:17 |
openstackgerrit | Mike Fedosin proposed openstack/python-glanceclient: Glance v3 client initial commit https://review.openstack.org/189860 | 20:17 |
openstackgerrit | Mike Fedosin proposed openstack/python-glanceclient: Glance v3 client listing support https://review.openstack.org/198450 | 20:17 |
openstackgerrit | Mike Fedosin proposed openstack/python-glanceclient: Glance v3 client methods for work with blobs https://review.openstack.org/197970 | 20:17 |
*** jaypipes has joined #openstack-glance | 20:22 | |
*** annashen has quit IRC | 20:26 | |
*** jasondotstar has quit IRC | 20:28 | |
*** peristeri has quit IRC | 20:29 | |
openstackgerrit | Ian Cordasco proposed openstack/glance: Remove usage of assert_called_once in mocks https://review.openstack.org/200559 | 20:29 |
sigmavirus24 | mfedosin: if you're still around ^ | 20:30 |
sigmavirus24 | sabari: ^ | 20:30 |
mfedosin | yes | 20:31 |
*** jaypipes is now known as leakypipes | 20:31 | |
mfedosin | cool | 20:32 |
sabari | sigmavirus24: cool | 20:34 |
sigmavirus24 | mfedosin: thanks for noticing that. I would have been angry that the tests still failed =P | 20:35 |
mfedosin | np :) but now we have to do something with the client | 20:36 |
*** annashen has joined #openstack-glance | 20:38 | |
*** annegentle has quit IRC | 20:39 | |
sabari | mfedosin: I saw a patch https://review.openstack.org/#/c/200685 | 20:39 |
sigmavirus24 | uh we need probably the update from g-r | 20:41 |
sigmavirus24 | mfedosin: can you approve https://review.openstack.org/#/c/200667/ ? | 20:43 |
sigmavirus24 | that'll help that review that sabari just linked | 20:44 |
sigmavirus24 | and I'll fix up that test that sabari noted | 20:44 |
*** mtanino has joined #openstack-glance | 20:44 | |
*** vijendar1 has joined #openstack-glance | 20:45 | |
sabari | sigmavirus24: Great, also should we rebase the mock fix on top of g-r update ? | 20:45 |
sigmavirus24 | already going to sabari =P | 20:45 |
sabari | sigmavirus24 :D | 20:46 |
sigmavirus24 | review.o.o is slow today | 20:46 |
sigmavirus24 | so pulling down changes has been annoying slow | 20:46 |
sabari | ^ yeah | 20:46 |
sigmavirus24 | oh wait | 20:47 |
sigmavirus24 | that's the glance store fix | 20:47 |
sigmavirus24 | d'oh | 20:47 |
sigmavirus24 | I guess glanceclient wasn't updated? | 20:47 |
*** vijendar has quit IRC | 20:48 | |
sabari | uh oh, yeah. Let me look for it too | 20:48 |
sabari | hmm there's no update | 20:48 |
sigmavirus24 | sabari: I don't see any in a while | 20:49 |
sigmavirus24 | I suspect something's broken | 20:49 |
sabari | sigmavirus24: this merged yest https://review.openstack.org/#/c/197274/ | 20:50 |
sabari | but I am not sure about the proposal bot and it's frequency | 20:50 |
openstackgerrit | Ian Cordasco proposed openstack/python-glanceclient: Remove usage of assert_called_once on Mock objects https://review.openstack.org/200685 | 20:52 |
sigmavirus24 | sabari: it should have sent us a review today though | 20:53 |
*** TravT_away is now known as TravT | 20:56 | |
sabari | sigmavirus24: Just one comment https://review.openstack.org/#/c/200685/2/test-requirements.txt | 20:56 |
sabari | I wasn't too sure. | 20:56 |
sigmavirus24 | sabari: I copied it from glance_store openstack proposal bot change | 20:57 |
sigmavirus24 | d'oh | 20:57 |
sigmavirus24 | it really shouldnt' matter functionally | 20:57 |
sigmavirus24 | sabari: fixed anyway | 20:57 |
sigmavirus24 | good catch | 20:57 |
openstackgerrit | Ian Cordasco proposed openstack/python-glanceclient: Remove usage of assert_called_once on Mock objects https://review.openstack.org/200685 | 20:58 |
sabari | yeah, I thought so too. The parsing should take care of it. | 20:58 |
sabari | Thanks anyway :) | 20:58 |
*** ducttape_ has quit IRC | 20:59 | |
-openstackstatus- NOTICE: Gerrit will be unavailable from 22:00 to 22:30 UTC for project renames | 21:02 | |
*** ig0r_ has quit IRC | 21:10 | |
*** raildo_ has quit IRC | 21:13 | |
*** jasondotstar has joined #openstack-glance | 21:18 | |
*** annegentle has joined #openstack-glance | 21:18 | |
*** annegentle has quit IRC | 21:19 | |
*** annegentle has joined #openstack-glance | 21:20 | |
*** jasondotstar has quit IRC | 21:22 | |
*** jasondotstar has joined #openstack-glance | 21:31 | |
*** shosagoudar has joined #openstack-glance | 21:33 | |
*** Longgeek has joined #openstack-glance | 21:35 | |
*** shosagoudar has quit IRC | 21:37 | |
*** annashen has quit IRC | 21:41 | |
*** annashen has joined #openstack-glance | 21:42 | |
*** rwsu has joined #openstack-glance | 21:43 | |
*** annashen has quit IRC | 21:46 | |
*** jasondot_ has joined #openstack-glance | 21:50 | |
*** jasondotstar has quit IRC | 21:53 | |
*** edmondsw has quit IRC | 21:53 | |
*** raildo has joined #openstack-glance | 21:55 | |
*** sgotliv has joined #openstack-glance | 21:56 | |
*** Longgeek has quit IRC | 21:58 | |
-openstackstatus- NOTICE: Gerrit is unavailable from approximately 22:00 to 22:30 UTC for project renames | 21:58 | |
*** ChanServ changes topic to "Gerrit is unavailable from approximately 22:00 to 22:30 UTC for project renames" | 21:58 | |
*** annashen has joined #openstack-glance | 22:00 | |
*** kebray has quit IRC | 22:04 | |
*** harlowja_ has joined #openstack-glance | 22:09 | |
*** annegentle has quit IRC | 22:09 | |
*** harlowja has quit IRC | 22:10 | |
*** sgotliv has quit IRC | 22:11 | |
*** primechuck has quit IRC | 22:11 | |
*** MentalRay has joined #openstack-glance | 22:11 | |
*** tpeoples has quit IRC | 22:12 | |
*** primechuck has joined #openstack-glance | 22:13 | |
*** boris-42 has joined #openstack-glance | 22:15 | |
*** annashen has quit IRC | 22:15 | |
*** annashen has joined #openstack-glance | 22:22 | |
*** mgarza has quit IRC | 22:23 | |
*** annashen has quit IRC | 22:27 | |
*** ChanServ changes topic to "Discussion of OpenStack Glance | logs at http://eavesdrop.openstack.org/irclogs/%23openstack-glance/" | 22:30 | |
*** alex_xu has quit IRC | 22:43 | |
*** alex_xu has joined #openstack-glance | 22:43 | |
*** primechuck has quit IRC | 22:44 | |
*** krykowski has quit IRC | 22:52 | |
*** krykowski has joined #openstack-glance | 22:53 | |
*** dhellmann has quit IRC | 22:54 | |
*** dhellmann has joined #openstack-glance | 22:56 | |
*** dims has quit IRC | 23:13 | |
*** dims has joined #openstack-glance | 23:17 | |
*** mingdang1 has joined #openstack-glance | 23:21 | |
*** mingdang_ has joined #openstack-glance | 23:31 | |
*** shosagoudar has joined #openstack-glance | 23:34 | |
*** mingdang1 has quit IRC | 23:35 | |
*** shosagoudar has quit IRC | 23:39 | |
*** openstackgerrit has quit IRC | 23:39 | |
*** openstackgerrit has joined #openstack-glance | 23:39 | |
*** Longgeek has joined #openstack-glance | 23:40 | |
*** mingdang_ has quit IRC | 23:47 | |
*** rwsu has quit IRC | 23:54 | |
*** r-daneel has quit IRC | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!