| *** kent_w has quit IRC | 00:01 | |
| *** kent_w has joined #openstack-glance | 00:02 | |
| *** ayoung has joined #openstack-glance | 00:07 | |
| *** tsekiyam_ has joined #openstack-glance | 00:07 | |
| *** mtanino has quit IRC | 00:10 | |
| *** tsekiyama has quit IRC | 00:10 | |
| *** tsekiyam_ has quit IRC | 00:11 | |
| sigmavirus24 | mriedem: I'll be around a bit long | 00:16 |
|---|---|---|
| sigmavirus24 | When you have a unittest up, I'll +2 | 00:16 |
| mriedem | sigmavirus24: unit test is kind of not working since the rbd module isn't there in tox | 00:17 |
| mriedem | trying to see if i can mock that all out somehow | 00:17 |
| sigmavirus24 | in test-requirements.txt you mean? | 00:17 |
| mriedem | well, pypi | 00:17 |
| sigmavirus24 | oh | 00:17 |
| mriedem | it comes from the distro | 00:17 |
| sigmavirus24 | well | 00:17 |
| mriedem | librbd | 00:17 |
| *** kent_w has quit IRC | 00:17 | |
| sigmavirus24 | that's probably why we haven't really tested any of this | 00:17 |
| sigmavirus24 | lifeless: can you mock out an import entirely? | 00:17 |
| *** kent_w has joined #openstack-glance | 00:18 | |
| lifeless | sigmavirus24: variously, sure | 00:18 |
| sigmavirus24 | I know you can mock things on a module, I mean can you use mock to inject a faux rbd module when testing so we dont' have a dependency on librbd | 00:19 |
| lifeless | sure | 00:19 |
| lifeless | in various ways | 00:19 |
| lifeless | sys.modules['rbd'] = Mock() | 00:19 |
| lifeless | sys.modules['rbd.sub'] = sys.modules['rbd'].sub | 00:20 |
| lifeless | etc | 00:20 |
| lifeless | or whatever you need | 00:20 |
| sigmavirus24 | Ah true | 00:20 |
| * sigmavirus24 never thought about how you might do that and is a bit... tired | 00:20 | |
| lifeless | if it might already be imported | 00:20 |
| lifeless | then you need mock.patch [or any other monkey patch tooling you wish to use] | 00:20 |
| sigmavirus24 | mhm | 00:20 |
| lifeless | (in concert with an explicit new thing rather than autospec (because it might not be there) | 00:21 |
| sigmavirus24 | mhm | 00:21 |
| lifeless | neverthelessitsalldoable | 00:21 |
| lifeless | perhaps you should try sleep ? :) | 00:22 |
| mriedem | it's not imported in the unit tests b/c there isn't a pip | 00:22 |
| mriedem | so i'll try sys.modules['rbd'] = Mock() | 00:22 |
| sigmavirus24 | too early too sleep | 00:22 |
| *** mingdang1 has joined #openstack-glance | 00:27 | |
| *** tpeoples has quit IRC | 00:28 | |
| *** primechuck has joined #openstack-glance | 00:29 | |
| mriedem | got it | 00:32 |
| mriedem | was making it harder than it needed to be | 00:32 |
| *** kent_w has quit IRC | 00:33 | |
| *** kent_w has joined #openstack-glance | 00:34 | |
| *** harshs has quit IRC | 00:40 | |
| mriedem | running pep8 and then it's up | 00:42 |
| openstackgerrit | Matt Riedemann proposed openstack/glance_store: rbd: make sure features is an int when passed to librbd.create https://review.openstack.org/203294 | 00:44 |
| mriedem | sigmavirus24: there you go ^ | 00:44 |
| *** kent_w has quit IRC | 00:49 | |
| *** kent_w has joined #openstack-glance | 00:50 | |
| sigmavirus24 | mriedem: I'm probably the only US core that's still around | 00:54 |
| sigmavirus24 | unless nikhil_k is around | 00:54 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 00:58 | |
| mriedem | sigmavirus24_awa: well, it still requires a 0.7.1 release so probably doesn't matter | 00:58 |
| mriedem | ooo looks like lifeless or dims_ or dhellmann could release it https://review.openstack.org/#/admin/groups/967,members | 00:59 |
| *** kent_w has quit IRC | 01:05 | |
| *** kent_w has joined #openstack-glance | 01:05 | |
| *** mriedem1 has joined #openstack-glance | 01:17 | |
| *** mriedem has quit IRC | 01:19 | |
| *** kent_w has quit IRC | 01:20 | |
| *** kent_w has joined #openstack-glance | 01:22 | |
| *** primechuck has quit IRC | 01:30 | |
| *** kent_w has quit IRC | 01:36 | |
| *** kent_w has joined #openstack-glance | 01:37 | |
| *** jasondotstar has joined #openstack-glance | 01:38 | |
| *** jasondotstar has quit IRC | 01:38 | |
| *** jasondotstar has joined #openstack-glance | 01:38 | |
| *** jasondotstar has quit IRC | 01:40 | |
| *** ducttape_ has joined #openstack-glance | 01:49 | |
| *** kent_w has quit IRC | 01:52 | |
| *** kent_w has joined #openstack-glance | 01:53 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-glanceclient: Updated from global requirements https://review.openstack.org/200900 | 01:56 |
| *** kent_w has quit IRC | 02:08 | |
| *** kent_w has joined #openstack-glance | 02:09 | |
| *** ducttape_ has quit IRC | 02:11 | |
| *** primechuck has joined #openstack-glance | 02:21 | |
| *** mriedem1 has quit IRC | 02:24 | |
| *** kent_w has quit IRC | 02:24 | |
| *** kent_w has joined #openstack-glance | 02:25 | |
| *** mingdang1 has quit IRC | 02:26 | |
| *** annashen has quit IRC | 02:31 | |
| *** kent_w has quit IRC | 02:39 | |
| *** kent_w has joined #openstack-glance | 02:40 | |
| *** dims_ has quit IRC | 02:41 | |
| *** dims_ has joined #openstack-glance | 02:44 | |
| *** dims_ has quit IRC | 02:54 | |
| *** annashen has joined #openstack-glance | 02:58 | |
| *** boris-42 has quit IRC | 03:02 | |
| *** annashen has quit IRC | 03:06 | |
| *** kent_w has quit IRC | 03:22 | |
| *** mingdang1 has joined #openstack-glance | 03:26 | |
| *** mingdang1 has quit IRC | 03:31 | |
| *** annashen has joined #openstack-glance | 03:48 | |
| *** tpeoples has joined #openstack-glance | 03:50 | |
| *** annashen has quit IRC | 04:16 | |
| *** kent_w has joined #openstack-glance | 04:23 | |
| *** changbl has quit IRC | 04:44 | |
| *** harshs has joined #openstack-glance | 05:08 | |
| *** harshs has quit IRC | 05:21 | |
| *** kent_w has quit IRC | 05:22 | |
| *** kent_w has joined #openstack-glance | 05:23 | |
| *** kent_w has quit IRC | 05:38 | |
| *** tpeoples has quit IRC | 05:43 | |
| *** annashen has joined #openstack-glance | 05:49 | |
| *** primechuck has quit IRC | 06:04 | |
| *** harshs has joined #openstack-glance | 06:06 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/glance: Imported Translations from Transifex https://review.openstack.org/197206 | 06:06 |
| *** vilobhmm has joined #openstack-glance | 06:07 | |
| *** harshs has quit IRC | 06:10 | |
| *** groen692 has joined #openstack-glance | 06:16 | |
| *** kent_w has joined #openstack-glance | 06:23 | |
| *** annashen has quit IRC | 06:29 | |
| *** annashen has joined #openstack-glance | 06:31 | |
| *** annashen has quit IRC | 06:35 | |
| *** mingdang1 has joined #openstack-glance | 06:44 | |
| *** groen692 has quit IRC | 06:51 | |
| *** pcaruana has joined #openstack-glance | 06:52 | |
| *** mingdang1 has quit IRC | 07:07 | |
| *** annashen has joined #openstack-glance | 07:31 | |
| *** annashen has quit IRC | 07:36 | |
| *** vilobhmm has quit IRC | 07:50 | |
| *** pbourke has quit IRC | 08:27 | |
| *** pbourke has joined #openstack-glance | 08:27 | |
| *** annashen has joined #openstack-glance | 08:32 | |
| *** e0ne has joined #openstack-glance | 08:36 | |
| *** annashen has quit IRC | 08:37 | |
| *** e0ne has quit IRC | 08:39 | |
| *** annashen has joined #openstack-glance | 09:33 | |
| *** annashen has quit IRC | 09:38 | |
| *** mingdang1 has joined #openstack-glance | 10:20 | |
| *** ducttape_ has joined #openstack-glance | 10:39 | |
| *** ducttape_ has quit IRC | 10:48 | |
| *** primechuck has joined #openstack-glance | 11:46 | |
| *** primechuck has quit IRC | 12:10 | |
| *** primechuck has joined #openstack-glance | 12:17 | |
| *** dims_ has joined #openstack-glance | 12:20 | |
| *** primechuck has quit IRC | 12:20 | |
| *** primechuck has joined #openstack-glance | 12:25 | |
| *** kent_w has quit IRC | 12:25 | |
| *** mriedem has joined #openstack-glance | 12:40 | |
| *** primechuck has quit IRC | 12:44 | |
| *** pbourke has quit IRC | 13:01 | |
| *** mriedem has left #openstack-glance | 13:02 | |
| *** miand has joined #openstack-glance | 13:07 | |
| *** harshs has joined #openstack-glance | 13:08 | |
| *** chlong has joined #openstack-glance | 13:09 | |
| *** kent_w has joined #openstack-glance | 13:26 | |
| *** GB21 has joined #openstack-glance | 13:32 | |
| *** pbourke has joined #openstack-glance | 13:37 | |
| *** e0ne has joined #openstack-glance | 13:40 | |
| *** e0ne has quit IRC | 13:45 | |
| *** mingdang1 has quit IRC | 13:45 | |
| *** mingdang1 has joined #openstack-glance | 13:50 | |
| *** mingdang1 has quit IRC | 13:55 | |
| *** harshs has quit IRC | 13:57 | |
| *** kent_w has quit IRC | 14:00 | |
| *** harshs has joined #openstack-glance | 14:03 | |
| *** e0ne has joined #openstack-glance | 14:04 | |
| *** e0ne has quit IRC | 14:07 | |
| *** belmoreira has joined #openstack-glance | 14:07 | |
| *** e0ne has joined #openstack-glance | 14:10 | |
| *** e0ne has quit IRC | 14:12 | |
| *** e0ne has joined #openstack-glance | 14:17 | |
| *** harshs has quit IRC | 14:22 | |
| *** harshs has joined #openstack-glance | 14:24 | |
| *** GB21_ has joined #openstack-glance | 14:37 | |
| *** annashen has joined #openstack-glance | 14:38 | |
| *** GB21 has quit IRC | 14:38 | |
| *** annashen has quit IRC | 14:38 | |
| *** GB21_ is now known as GB21 | 14:39 | |
| *** e0ne has quit IRC | 14:39 | |
| *** e0ne has joined #openstack-glance | 14:44 | |
| *** e0ne has quit IRC | 14:53 | |
| *** harshs has quit IRC | 14:53 | |
| *** kent_w has joined #openstack-glance | 14:56 | |
| *** e0ne has joined #openstack-glance | 14:57 | |
| *** e0ne has quit IRC | 15:11 | |
| *** harshs has joined #openstack-glance | 15:13 | |
| *** changbl has joined #openstack-glance | 15:14 | |
| *** e0ne has joined #openstack-glance | 15:15 | |
| *** e0ne has quit IRC | 15:17 | |
| *** e0ne has joined #openstack-glance | 15:20 | |
| *** e0ne has quit IRC | 15:23 | |
| *** e0ne has joined #openstack-glance | 15:26 | |
| *** e0ne has quit IRC | 15:29 | |
| *** kent_w has quit IRC | 15:29 | |
| *** sgotliv has joined #openstack-glance | 15:31 | |
| *** harshs has quit IRC | 15:32 | |
| *** e0ne has joined #openstack-glance | 15:32 | |
| *** e0ne has quit IRC | 15:35 | |
| *** annashen has joined #openstack-glance | 15:39 | |
| *** e0ne has joined #openstack-glance | 15:40 | |
| *** e0ne has quit IRC | 15:42 | |
| *** annashen has quit IRC | 15:44 | |
| *** _stowa has quit IRC | 15:45 | |
| *** e0ne has joined #openstack-glance | 15:46 | |
| *** e0ne has quit IRC | 15:50 | |
| jokke_ | dhellmann: looks like your test script did not work as this https://review.openstack.org/#/c/203362/ got +1 from Jenkins while cd04b9217f4581f9d1d6840bc6c3c4c916b330e8 was not merged yet | 15:51 |
| *** e0ne has joined #openstack-glance | 15:54 | |
| *** _stowa has joined #openstack-glance | 15:54 | |
| jokke_ | kragniz: comments of https://review.openstack.org/#/c/202564/ explains my -1 | 15:55 |
| kragniz | jokke_: yeah, I saw that | 15:56 |
| kragniz | jokke_: I'm not using a Depends-On, though | 15:56 |
| kragniz | I forgot to mark as wip | 15:57 |
| jokke_ | cool ... I did not think that possibility either. In case of merge that doesn't really matter the SHA would still change | 15:57 |
| jokke_ | shouldn't be issue here 'though as we do not have anything else in pipeline. Just flagged for Doug as he wrote check for that yesterday | 15:58 |
| *** e0ne has quit IRC | 15:58 | |
| kragniz | yeah, it'll be fine as long as we don't try to merge something in the meantime | 15:59 |
| jokke_ | ;) | 16:00 |
| *** ig0r_ has joined #openstack-glance | 16:01 | |
| *** e0ne has joined #openstack-glance | 16:02 | |
| *** ig0r_ has quit IRC | 16:05 | |
| *** miand has quit IRC | 16:07 | |
| openstackgerrit | Merged openstack/glance_store: rbd: make sure features is an int when passed to librbd.create https://review.openstack.org/203294 | 16:09 |
| kragniz | jokke_: ^ | 16:10 |
| *** e0ne has quit IRC | 16:12 | |
| *** e0ne has joined #openstack-glance | 16:16 | |
| *** e0ne has quit IRC | 16:19 | |
| *** e0ne has joined #openstack-glance | 16:23 | |
| *** kent_w has joined #openstack-glance | 16:26 | |
| *** e0ne has quit IRC | 16:31 | |
| *** e0ne has joined #openstack-glance | 16:35 | |
| *** e0ne has quit IRC | 16:37 | |
| *** e0ne has joined #openstack-glance | 16:41 | |
| *** e0ne has quit IRC | 16:46 | |
| *** dims_ has quit IRC | 16:49 | |
| *** e0ne has joined #openstack-glance | 16:50 | |
| *** e0ne has quit IRC | 16:53 | |
| *** e0ne has joined #openstack-glance | 16:57 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/glance_store: Updated from global requirements https://review.openstack.org/200667 | 16:58 |
| *** kent_w has quit IRC | 16:59 | |
| *** e0ne has quit IRC | 17:05 | |
| *** marekd has joined #openstack-glance | 17:08 | |
| *** e0ne has joined #openstack-glance | 17:10 | |
| *** e0ne has quit IRC | 17:11 | |
| *** annashen has joined #openstack-glance | 17:15 | |
| *** e0ne has joined #openstack-glance | 17:16 | |
| *** e0ne has quit IRC | 17:18 | |
| *** e0ne has joined #openstack-glance | 17:22 | |
| *** annashen has quit IRC | 17:26 | |
| *** e0ne has quit IRC | 17:26 | |
| *** e0ne has joined #openstack-glance | 17:30 | |
| *** e0ne has quit IRC | 17:38 | |
| *** dims_ has joined #openstack-glance | 17:41 | |
| *** e0ne has joined #openstack-glance | 17:41 | |
| *** marekd has quit IRC | 17:42 | |
| *** marekd has joined #openstack-glance | 17:42 | |
| *** e0ne has quit IRC | 17:55 | |
| *** kent_w has joined #openstack-glance | 17:56 | |
| *** e0ne has joined #openstack-glance | 17:59 | |
| *** e0ne has quit IRC | 18:02 | |
| *** e0ne has joined #openstack-glance | 18:06 | |
| *** e0ne has quit IRC | 18:08 | |
| *** e0ne has joined #openstack-glance | 18:11 | |
| *** e0ne has quit IRC | 18:17 | |
| *** kent_w has quit IRC | 18:18 | |
| *** e0ne has joined #openstack-glance | 18:20 | |
| *** e0ne has quit IRC | 18:23 | |
| *** annashen has joined #openstack-glance | 18:26 | |
| *** e0ne has joined #openstack-glance | 18:27 | |
| *** e0ne has quit IRC | 18:28 | |
| *** annashen has quit IRC | 18:31 | |
| *** vilobhmm has joined #openstack-glance | 18:40 | |
| *** vilobhmm1 has joined #openstack-glance | 18:45 | |
| *** vilobhmm has quit IRC | 18:47 | |
| *** changbl has quit IRC | 18:48 | |
| *** vilobhmm1 has quit IRC | 18:57 | |
| *** annashen has joined #openstack-glance | 18:59 | |
| *** marekd has quit IRC | 19:12 | |
| *** kent_w has joined #openstack-glance | 19:19 | |
| openstackgerrit | Merged openstack/glance-specs: CLI Support For Tag Metadata Definitions https://review.openstack.org/179674 | 19:20 |
| *** marekd has joined #openstack-glance | 19:27 | |
| *** belmoreira has quit IRC | 19:36 | |
| *** marekd has quit IRC | 19:40 | |
| *** ig0r_ has joined #openstack-glance | 19:45 | |
| *** ig0r_ has quit IRC | 19:47 | |
| *** GB21 has quit IRC | 19:52 | |
| *** GB21 has joined #openstack-glance | 19:53 | |
| *** marekd has joined #openstack-glance | 19:55 | |
| *** primechuck has joined #openstack-glance | 19:57 | |
| *** primechu_ has joined #openstack-glance | 20:00 | |
| *** dims_ has quit IRC | 20:00 | |
| *** primechuck has quit IRC | 20:00 | |
| *** belmoreira has joined #openstack-glance | 20:03 | |
| *** dims_ has joined #openstack-glance | 20:04 | |
| *** edmondsw has joined #openstack-glance | 20:05 | |
| *** edmondsw has quit IRC | 20:05 | |
| *** dims_ has quit IRC | 20:09 | |
| *** GB21 has quit IRC | 20:40 | |
| *** ducttape_ has joined #openstack-glance | 20:43 | |
| *** annashen has quit IRC | 20:49 | |
| *** kent_w has quit IRC | 21:03 | |
| *** kent_w has joined #openstack-glance | 21:04 | |
| openstackgerrit | Merged openstack/glance: Updated from global requirements https://review.openstack.org/200666 | 21:06 |
| *** ducttape_ has quit IRC | 21:14 | |
| *** dims_ has joined #openstack-glance | 21:15 | |
| *** belmoreira has quit IRC | 21:19 | |
| *** dims_ has quit IRC | 21:26 | |
| *** primechu_ has quit IRC | 21:36 | |
| *** dims_ has joined #openstack-glance | 22:29 | |
| *** dims_ has quit IRC | 22:35 | |
| *** mingdang1 has joined #openstack-glance | 23:49 | |
| *** mingdang1 has quit IRC | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!