*** r-daneel has quit IRC | 00:16 | |
*** annegentle has quit IRC | 00:18 | |
*** boris-42 has quit IRC | 00:20 | |
*** bapalm has joined #openstack-glance | 00:37 | |
*** bapalm has quit IRC | 00:39 | |
*** tsekiyam_ has joined #openstack-glance | 00:45 | |
*** mtanino has quit IRC | 00:46 | |
*** tsekiyama has quit IRC | 00:48 | |
*** tsekiyam_ has quit IRC | 00:50 | |
*** annegentle has joined #openstack-glance | 01:14 | |
*** dims_ has joined #openstack-glance | 01:21 | |
*** dims has quit IRC | 01:22 | |
*** sdake has joined #openstack-glance | 01:27 | |
*** sdake_ has joined #openstack-glance | 01:30 | |
*** sdake has quit IRC | 01:34 | |
*** harshs has joined #openstack-glance | 01:40 | |
*** mingdang1 has joined #openstack-glance | 01:54 | |
*** harshs has quit IRC | 01:56 | |
*** spzala has quit IRC | 01:57 | |
*** dims has joined #openstack-glance | 02:03 | |
*** dims_ has quit IRC | 02:05 | |
*** dims_ has joined #openstack-glance | 02:06 | |
*** dims has quit IRC | 02:09 | |
*** sdake_ has quit IRC | 02:09 | |
*** dims_ has quit IRC | 02:22 | |
*** annashen has joined #openstack-glance | 02:28 | |
*** harshs has joined #openstack-glance | 02:43 | |
openstackgerrit | Sabari proposed openstack/glance_store: Handle swift store's optional dependecy https://review.openstack.org/209744 | 03:12 |
---|---|---|
openstackgerrit | Sabari proposed openstack/glance_store: Conditionally import dependencies of swift store https://review.openstack.org/209744 | 03:13 |
*** boris-42 has joined #openstack-glance | 03:27 | |
*** junhongl has joined #openstack-glance | 03:54 | |
flaper87 | sabari: thanks for the reviews | 03:55 |
flaper87 | sabari: Did you read my last comment on the spec? | 03:55 |
*** ayoung has quit IRC | 03:56 | |
*** annashen has quit IRC | 04:17 | |
*** annegentle has quit IRC | 04:41 | |
openstackgerrit | Merged openstack/glance_store: Imported Translations from Transifex https://review.openstack.org/204920 | 05:01 |
*** junhongl has quit IRC | 05:15 | |
*** junhongl has joined #openstack-glance | 05:15 | |
*** harshs has quit IRC | 05:22 | |
*** takedakn has joined #openstack-glance | 05:24 | |
*** takedakn has quit IRC | 05:28 | |
*** junhongl has quit IRC | 05:30 | |
openstackgerrit | Merged openstack/glance: Make utf8 the default charset for mysql https://review.openstack.org/181347 | 05:30 |
*** tpeoples has quit IRC | 05:46 | |
*** tpeoples has joined #openstack-glance | 05:51 | |
*** groen692 has joined #openstack-glance | 06:03 | |
*** dims has joined #openstack-glance | 06:03 | |
openstackgerrit | Edgar Magana proposed openstack/glance: Fix few typos in glance https://review.openstack.org/209117 | 06:07 |
openstackgerrit | Edgar Magana proposed openstack/glance: Fix few typos in glance https://review.openstack.org/209117 | 06:08 |
*** dims has quit IRC | 06:09 | |
openstackgerrit | Abhijeet Malawade proposed openstack/glance: Fix Request ID has a double 'req-' at the start https://review.openstack.org/206521 | 06:18 |
*** boris-42 has quit IRC | 06:20 | |
*** e0ne has joined #openstack-glance | 06:21 | |
openstackgerrit | Merged openstack/glance_store: Add explicit dependencies for store dependencies https://review.openstack.org/207116 | 06:22 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance: Imported Translations from Transifex https://review.openstack.org/208186 | 06:25 |
openstackgerrit | Jamie Lennox proposed openstack/glance: Turn on debug logging for ValueError https://review.openstack.org/209774 | 06:26 |
*** belmoreira has joined #openstack-glance | 06:51 | |
*** junhongl has joined #openstack-glance | 06:52 | |
*** e0ne has quit IRC | 07:00 | |
*** takedakn has joined #openstack-glance | 07:01 | |
*** ishant has joined #openstack-glance | 07:01 | |
*** e0ne has joined #openstack-glance | 07:11 | |
*** tpeoples has quit IRC | 07:14 | |
*** markus_z has joined #openstack-glance | 07:24 | |
*** e0ne has quit IRC | 07:26 | |
*** takedakn has quit IRC | 07:28 | |
*** pbourke has quit IRC | 07:33 | |
*** pbourke has joined #openstack-glance | 07:33 | |
*** sayali has joined #openstack-glance | 07:50 | |
*** sdake has joined #openstack-glance | 07:54 | |
*** ishant_ has joined #openstack-glance | 07:55 | |
*** ishant has quit IRC | 07:59 | |
*** GB21 has joined #openstack-glance | 08:02 | |
*** jistr has joined #openstack-glance | 08:14 | |
*** e0ne has joined #openstack-glance | 08:22 | |
*** e0ne has quit IRC | 08:41 | |
*** e0ne has joined #openstack-glance | 08:58 | |
jokke_ | Morning | 09:00 |
*** haomaiwang has quit IRC | 09:21 | |
*** haomaiwang has joined #openstack-glance | 09:21 | |
*** bdossant has joined #openstack-glance | 09:25 | |
*** MattMan has quit IRC | 09:42 | |
*** e0ne has quit IRC | 09:43 | |
*** MattMan has joined #openstack-glance | 09:44 | |
openstackgerrit | Kentaro Takeda proposed openstack/glance: Incorrect variable name is declared in test_validate_key_cert_key_cant_read() method. https://review.openstack.org/209846 | 09:46 |
openstackgerrit | Kentaro Takeda proposed openstack/glance: Incorrect variable name is declared in test_validate_key_cert_key_cant_read() method. https://review.openstack.org/209846 | 09:47 |
openstackgerrit | Kentaro Takeda proposed openstack/glance: Incorrect variable name is declared https://review.openstack.org/209846 | 09:47 |
openstackgerrit | Kentaro Takeda proposed openstack/glance: Incorrect variable name is declared https://review.openstack.org/209846 | 09:48 |
*** dims has joined #openstack-glance | 09:49 | |
openstackgerrit | Kentaro Takeda proposed openstack/glance: Incorrect variable name is declared https://review.openstack.org/209846 | 09:52 |
*** GB21 has quit IRC | 09:56 | |
*** GB21 has joined #openstack-glance | 09:58 | |
*** e0ne has joined #openstack-glance | 09:59 | |
*** eandersson has joined #openstack-glance | 10:26 | |
openstackgerrit | Niall Bunting proposed openstack/glance: Removes *.sql files from git ignore https://review.openstack.org/209866 | 10:50 |
*** dims_ has joined #openstack-glance | 10:51 | |
*** e0ne has quit IRC | 10:52 | |
*** dims has quit IRC | 10:53 | |
*** e0ne has joined #openstack-glance | 10:54 | |
openstackgerrit | Merged openstack/glance: Include metadefs files in all packages https://review.openstack.org/206790 | 10:57 |
*** smatzek has joined #openstack-glance | 11:00 | |
*** sdake has quit IRC | 11:07 | |
jamielennox | is there a restriction placed on the glance API used in the gate? | 11:21 |
jamielennox | like an explicit use v | 11:21 |
jamielennox | 1 | 11:21 |
*** mingdang1 has quit IRC | 11:23 | |
*** spzala has joined #openstack-glance | 11:24 | |
*** shalq has joined #openstack-glance | 11:24 | |
jokke_ | jamielennox: not that I know ... we do test v2 api in the gate | 11:27 |
jamielennox | jokke_: hmm, i can't replicate an issue i have in gate locally | 11:28 |
jamielennox | thought it might have been a different API as i'm getting different log messages | 11:28 |
jokke_ | jamielennox: interesting, what are you seeing? | 11:28 |
jamielennox | jokke_: so i'm trying to fix devstack to use glance -> swift v3 auth api | 11:28 |
jamielennox | with a few addiitonal debug patches i'm seeing http://logs.openstack.org/51/209351/3/check/gate-tempest-dsvm-full/7c182e9/logs/screen-g-api.txt.gz#_2015-08-06_10_27_19_758 | 11:29 |
jamielennox | which is really annoying because it means it gets caught by ValueError at https://github.com/openstack/glance/blob/master/glance/api/v1/upload_utils.py#L272 | 11:30 |
jamielennox | when i do this locally i don't see the debug messages i'm seeing in gate, so i thought maybe locally i was uploading images to glance with v2, but v1 was being used in the gate | 11:30 |
jamielennox | i *think* it means that i've got invalid credentials but i can't get a useful message | 11:31 |
jokke_ | jamielennox: ah, one of those things we mask the exception actually raised to us | 11:31 |
jamielennox | jokke_: right - catching ValueError so broadly is a bit... dumb | 11:32 |
jamielennox | but then swiftclient not being able to serialize exceptions is also wrong | 11:32 |
jokke_ | so by the gate issue, it looks like swiftclient is trying to do something nasty when it's authentication fails | 11:33 |
jokke_ | yeah | 11:33 |
jamielennox | yep - this also passes on my local machine | 11:33 |
jokke_ | jamielennox: on devstack? | 11:33 |
jamielennox | jokke_: i had Depends-On: https://review.openstack.org/#/c/209800/ | 11:34 |
jamielennox | jokke_: which i hoped would at least show the issue but it didn't show up | 11:34 |
* jokke_ is just thinking could this be one of those things that issue has been fixed, but not released so devstack looks all good as it pulls the gits but gate does not as it pulls the packages from pypi | 11:35 | |
*** eandersson has quit IRC | 11:35 | |
jamielennox | right, as that review is actually failing so it could never have worked | 11:36 |
*** eandersson has joined #openstack-glance | 11:36 | |
jamielennox | jokke_: so i feel the real error is http://logs.openstack.org/51/209351/3/check/gate-tempest-dsvm-full/7c182e9/logs/screen-g-api.txt.gz#_2015-08-06_10_27_17_893 | 11:37 |
jokke_ | my thought exactly | 11:37 |
jamielennox | i've very explicity said to use v3 auth and yet that's sourcing keystoneclient.auth.identity.v2 | 11:37 |
jamielennox | but i can't replicate it locally and i've got no idea how to debug what happened | 11:37 |
*** e0ne has quit IRC | 11:41 | |
*** e0ne has joined #openstack-glance | 11:44 | |
jokke_ | jamielennox: by quick grep the auth_version gets never set anywhere to 3 for swiftclient | 11:46 |
jamielennox | jokke_: http://logs.openstack.org/51/209351/3/check/gate-tempest-dsvm-full/7c182e9/logs/etc/glance/glance-swift-store.conf.txt.gz | 11:47 |
jamielennox | the version is still being set to 2 in the main conf file but that glance-swift file should override that | 11:48 |
jokke_ | jamielennox: sorry, this might be really far off, but try swift_store_auth_version = 3 there instead | 11:50 |
jokke_ | jamielennox: oh sorry, never mind ... was looking wrong function | 11:52 |
*** ishant_ has quit IRC | 11:53 | |
jokke_ | jamielennox: I think I found it! | 11:59 |
jamielennox | jokke_: awesome, i was thinking of calling it a night otherwise | 12:00 |
jokke_ | jamielennox: https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/swift/store.py#L940 | 12:00 |
jamielennox | jokke_: :O, wtf is that | 12:01 |
jokke_ | that's very much hardcoded auth_version value on get_connection :P | 12:02 |
jamielennox | jokke_: so how is it that locally that's not being triggered? | 12:03 |
*** mingdang1 has joined #openstack-glance | 12:03 | |
jamielennox | jokke_: that's the multi-tenant store | 12:03 |
jokke_ | gate uses multitenant store vs you use locally single tenant | 12:03 |
jamielennox | which isn't good, but shouldn't matter here | 12:03 |
jamielennox | jokke_: ... | 12:03 |
jamielennox | when did that change | 12:03 |
jokke_ | I don't see any other place where that would be overriden | 12:04 |
jamielennox | multi-tenant store should use the user token | 12:04 |
jokke_ | that's purely sophisticated quess from me | 12:04 |
jokke_ | I just can't find any other reference that would not be overriden bu the swift store conf auth_version | 12:05 |
jamielennox | #swift_store_multi_tenant = False in http://logs.openstack.org/51/209351/3/check/gate-tempest-dsvm-full/7c182e9/logs/etc/glance/glance-api.conf.txt.gz | 12:05 |
jamielennox | unless the default in glance_store has changed recently | 12:05 |
jamielennox | because i had a review that i abandoned to switch devstack to multi-tenant mode to work around this issue | 12:06 |
jokke_ | glance_store/_drivers/swift/store.py: cfg.BoolOpt('swift_store_multi_tenant', default=False, | 12:07 |
jamielennox | none of the swift_store_* options are shown in the options debug list | 12:07 |
jamielennox | which i think means they aren't referenced in the glance oslo.config options list | 12:08 |
jokke_ | jamielennox: we load SingleTenantStore http://logs.openstack.org/51/209351/3/check/gate-tempest-dsvm-full/7c182e9/logs/screen-g-api.txt.gz#_2015-08-06_10_27_14_506 | 12:12 |
openstackgerrit | Niall Bunting proposed openstack/glance: Removes *.sql files from git ignore https://review.openstack.org/209866 | 12:12 |
jamielennox | jokke_: ok, so that's not it | 12:12 |
jokke_ | sorry for false alarm | 12:13 |
jamielennox | jokke_: so what happens if i upload images to :9292/images without a version number | 12:14 |
jamielennox | http://logs.openstack.org/51/209351/3/check/gate-tempest-dsvm-full/7c182e9/logs/devstacklog.txt.gz#_2015-08-06_10_27_15_526 | 12:14 |
jamielennox | i mean i didn't change that so i don't know why it would cause an issue now | 12:15 |
jokke_ | jamielennox: as I expected | 12:16 |
jokke_ | glance store does not have that on last release | 12:16 |
jamielennox | jokke_: no, but Depends-On: should take care of that | 12:16 |
jamielennox | jokke_: oh - but it doesn't | 12:17 |
jamielennox | wtf | 12:17 |
jokke_ | depends on just prevents merge before the depending changes has merged, it does not patch the component changed on those | 12:18 |
jokke_ | the tests are still ran against the packages pulled from pip | 12:19 |
jamielennox | jokke_: it should do more than that, and we can see that https://review.openstack.org/#/c/209774/ is used | 12:20 |
jamielennox | jokke_: because without that i didn't see an error at all | 12:20 |
jamielennox | jokke_: however it appears that it doesn't work for libraries | 12:20 |
jamielennox | jokke_: which would explain why my swfitclient fix wasn't showing up, even when i changed the ordering | 12:21 |
jokke_ | http://logs.openstack.org/51/209351/3/check/gate-tempest-dsvm-full/7c182e9/logs/pip-freeze.txt.gz glance-store==0.7.1 | 12:23 |
jokke_ | yes, projects comes in from git so the can be cherry picked in ... libs does not | 12:24 |
jamielennox | jokke_: excellent, so once again people writing clients get ignored - wtf is the point of that | 12:24 |
*** dims has joined #openstack-glance | 12:24 | |
jokke_ | jamielennox: tell me about it ... but the crying is insane when the lib release breaks the gate as those changes were never tested against everything else before | 12:25 |
jamielennox | jokke_: that would seem to be the point of testing against recent client | 12:25 |
*** vijendar has joined #openstack-glance | 12:26 | |
*** vijendar has quit IRC | 12:26 | |
*** vijendar has joined #openstack-glance | 12:26 | |
*** dims_ has quit IRC | 12:27 | |
jokke_ | jamielennox: IIUC that is to avoid the situation where deployer tries to install from master and the lib does not have the dependencies released | 12:27 |
jamielennox | jokke_: i don't think that applies in Depends-On in gate | 12:28 |
jokke_ | well the depends on just ensures that the change gets merged, not that it gets released | 12:28 |
*** mingdang_ has joined #openstack-glance | 12:29 | |
jokke_ | what I would suggest 'though is that we would add 1 test run done against master ... so you could see that "Yes, my change fails gating because client x and z has not released their related changes, but them included this works" | 12:30 |
*** mingdang1 has quit IRC | 12:30 | |
jokke_ | anyways ... call it night, we know why it fails and you will need to wait the release, before that change will merge. Based on the local testing it works anyways ;) | 12:31 |
jokke_ | will *not* merge | 12:32 |
jamielennox | jokke_: yea, checked in -infra as well | 12:33 |
jokke_ | OR if you change that swift_auth_version to 3 in gapi.conf it should pass also | 12:33 |
jamielennox | nothing we can do until we get a library release | 12:33 |
jamielennox | jokke_: no, because it's still not supported until the master branch of glance_store | 12:33 |
jokke_ | as that's what it's utilizing with the current code | 12:34 |
jokke_ | ah | 12:34 |
jamielennox | flaper87: ok - really wanting a glance_store release when you can | 12:34 |
jokke_ | nikhil_k: ^^ | 12:34 |
flaper87 | jamielennox: ok, roger that | 12:34 |
flaper87 | sigmavirus24_awa: nikhil_k ^ Lets sync and schedule one! | 12:35 |
jokke_ | flaper87: yeah would make sense ... 0.8.0 ;) | 12:35 |
jokke_ | previous was already 3 weeks ago so :P | 12:35 |
*** edmondsw has joined #openstack-glance | 12:36 | |
jamielennox | jokke_: thanks for your help, i'm done for the night | 12:37 |
nikhil_k | flaper87: jokke_ : jamielennox : please sync with dhellmann or ttx as well for that. I am cool with whenever | 12:38 |
flaper87 | nikhil_k: ah jeez, you're right! | 12:39 |
flaper87 | nikhil_k: great point | 12:39 |
flaper87 | ETOOMANYTEAMS | 12:39 |
flaper87 | requesting a release out of https://github.com/openstack/glance_store/commit/29a84f7ced03ece1eb5b2128593dc84f8f95bec1 | 12:41 |
*** bapalm has joined #openstack-glance | 12:44 | |
flaper87 | jokke_: https://review.openstack.org/#/c/209536/ | 12:44 |
jamielennox | flaper87: how do we sync that with dhellmann? do you have to email or put in a review somewhere? | 12:45 |
flaper87 | jokke_: a) it'll take time and many other changes b) shipping the json file is more complicated than haivng it in a python module because then ou gotta figure out where the heck that file should be stored c) sure | 12:45 |
jamielennox | send an email... | 12:45 |
flaper87 | jamielennox: I just pingged him on IRC, I'll let you know | 12:45 |
jamielennox | flaper87: cheerys | 12:46 |
jamielennox | cheers | 12:46 |
jamielennox | alright - night all | 12:46 |
flaper87 | jamielennox: night | 12:46 |
flaper87 | jokke_: actually, I'll put that in the review | 12:46 |
*** zul has joined #openstack-glance | 12:46 | |
flaper87 | jokke_: replied on the review. I'd love to get some feedback when you can | 12:51 |
flaper87 | really want to fix his issue asap, it's really unfortunate and awful | 12:52 |
jokke_ | flaper87: just got back from bit of fresh air and fetching coffee | 13:02 |
jokke_ | flaper87: it was preference order, not reality check ;) | 13:02 |
jokke_ | flaper87: I'd be happy with image_schema module just to keep it bit tidier | 13:05 |
*** junhongl has left #openstack-glance | 13:08 | |
*** abhishekk has joined #openstack-glance | 13:09 | |
jokke_ | sigmavirus24_awa: wanna join to the fight _again_ http://logs.openstack.org/01/178201/2/check/gate-glance_store-python27/a52f322/console.html#_2015-08-06_12_02_34_943 | 13:10 |
*** vijendar has quit IRC | 13:25 | |
openstackgerrit | Marek Denis proposed openstack/glance-specs: Federated model for cloning glance objects https://review.openstack.org/191897 | 13:30 |
*** marcusvrn has joined #openstack-glance | 13:30 | |
*** vokhrimenko has quit IRC | 13:35 | |
marekd | flaper87: rosmaita ^^ | 13:35 |
*** ayoung has joined #openstack-glance | 13:39 | |
bunting | jokke_: https://review.openstack.org/#/c/207150/ here is my current patch for the problem if it helps | 13:44 |
*** edmondsw has quit IRC | 13:46 | |
*** harshs has joined #openstack-glance | 13:49 | |
openstackgerrit | Niall Bunting proposed openstack/glance: Bodies that are not dicts or lists return 400 https://review.openstack.org/204138 | 13:50 |
*** jaypipes has quit IRC | 13:53 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:55 | |
*** sdake has joined #openstack-glance | 13:55 | |
sigmavirus24 | jokke_: why are you concerned about that? It means the Python that's installed at the gate is super old | 14:00 |
*** r-daneel has joined #openstack-glance | 14:01 | |
*** bpoulos has joined #openstack-glance | 14:02 | |
jokke_ | sigmavirus24: well I'm worried about that because our stable/kilo gate is bonkers | 14:02 |
sigmavirus24 | jokke_: it's merely a warning | 14:02 |
sigmavirus24 | It's informational of sorts but also a "Hey we can't really give you the best security because this python is old and the ssl module is absolutely awful" | 14:02 |
jokke_ | sigmavirus24: sorry my bad | 14:03 |
sigmavirus24 | jokke_: No worries | 14:04 |
sigmavirus24 | I know it's a red-herring | 14:04 |
sigmavirus24 | Courtesy meeting reminder: ativelkov, cpallares, esheffield, flaper87, flwang1, hemanthm, ivasilevskaya, jokke_, kragniz, lakshmiS, mclaren, mfedosin, nikhil_k, Nikolay_St, Olena, pennerc, rosmaita, sigmavirus24, sabari, TravT, zhiyan, pkoniszewski, krykowski, ajayaa, GB21, bpoulos, harshs, abhishekk, bunting | 14:04 |
*** vijendar has joined #openstack-glance | 14:04 | |
GB21 | sigmavirus24, thanks for the reminder :D | 14:04 |
sigmavirus24 | You're welcome GB21 | 14:05 |
*** GB21 has quit IRC | 14:10 | |
*** tpeoples has joined #openstack-glance | 14:13 | |
*** sdake has quit IRC | 14:14 | |
*** bpoulos has quit IRC | 14:16 | |
*** dims has quit IRC | 14:25 | |
*** dims has joined #openstack-glance | 14:26 | |
*** edmondsw has joined #openstack-glance | 14:28 | |
*** mingdang_ has quit IRC | 14:34 | |
*** jasondot_ is now known as jasondotstar | 14:38 | |
*** tsekiyama has joined #openstack-glance | 14:44 | |
*** annegentle has joined #openstack-glance | 14:45 | |
*** MVenesio has joined #openstack-glance | 14:45 | |
*** delattec has joined #openstack-glance | 14:48 | |
*** lakshmiS has joined #openstack-glance | 14:49 | |
*** e0ne has quit IRC | 14:52 | |
*** e0ne has joined #openstack-glance | 14:57 | |
*** Fin1te has joined #openstack-glance | 14:58 | |
*** r-daneel has quit IRC | 14:58 | |
*** bapalm_ has joined #openstack-glance | 15:00 | |
*** r-daneel has joined #openstack-glance | 15:01 | |
*** bapalm has quit IRC | 15:01 | |
flaper87 | nikhil_k: https://review.openstack.org/#/c/197899/ :D :P ;) PLEASE! (the spec the spec the spec) https://review.openstack.org/#/c/188388/ | 15:02 |
flaper87 | rosmaita: ^ | 15:02 |
* flaper87 waves | 15:02 | |
jokke_ | gr8 so we have 2 security bugs discussed openly on today's meeting :| | 15:02 |
flaper87 | it's 1am here and I have a plane to catch tomorrow morning | 15:02 |
flaper87 | jokke_: sometimes happens, it's not always obvious how you can exploit a bug | 15:02 |
abhishekk | jokke_, sigmavirus24, nikhil_k, sabari: please have a look at patch https://review.openstack.org/#/c/207847/ once you get time | 15:02 |
jokke_ | flaper87: so you'll be here with us whole evening ;) | 15:02 |
flaper87 | jokke_: if you're buying drinks, I'll stay | 15:03 |
flaper87 | :P | 15:03 |
* flaper87 is doing research on headphones because he lost his | 15:04 | |
*** ishant has joined #openstack-glance | 15:04 | |
*** abhishekk has quit IRC | 15:04 | |
rosmaita | flaper87: will put some comments on triggerd task spec ... soon | 15:05 |
rosmaita | sorry i didn't get to it last night | 15:05 |
*** jaypipes has joined #openstack-glance | 15:05 | |
rosmaita | will do it today new york time | 15:05 |
jokke_ | flaper87: sure deal! I go and buy drinks in local and you continue working. | 15:05 |
flaper87 | rosmaita: sounds perfect, thanks! | 15:07 |
flaper87 | jokke_: hey hey, don't try to fool me. You send me money over through paypal (you pay the fee) and I'll buy the drinks | 15:07 |
flaper87 | ok, I'm out! take care all | 15:08 |
marekd | flaper87: nikhil_k rosmaita : Hi, please take a look when you have a free minute : https://review.openstack.org/#/c/191897/ | 15:08 |
*** mtanino has joined #openstack-glance | 15:09 | |
*** zul has quit IRC | 15:10 | |
openstackgerrit | Matthew Edmonds proposed openstack/glance: clean up requirements https://review.openstack.org/203242 | 15:11 |
*** harshs has quit IRC | 15:21 | |
openstackgerrit | Kentaro Takeda proposed openstack/glance: Fix variable name in the second 'with' statement https://review.openstack.org/209990 | 15:25 |
*** sdake has joined #openstack-glance | 15:31 | |
*** spzala has quit IRC | 15:38 | |
*** jaypipes has quit IRC | 15:43 | |
*** jaypipes has joined #openstack-glance | 15:56 | |
nikhil_k | flaper87: marekd : sure thing! | 15:56 |
*** GB21 has joined #openstack-glance | 16:00 | |
*** ishant has quit IRC | 16:01 | |
*** belmoreira has quit IRC | 16:03 | |
*** GB21_ has joined #openstack-glance | 16:05 | |
*** GB21 has quit IRC | 16:06 | |
*** hogepodge has quit IRC | 16:06 | |
*** hogepodge has joined #openstack-glance | 16:07 | |
openstackgerrit | Merged openstack/python-glanceclient: Support for Metadata Definition Catalog for Tags https://review.openstack.org/138612 | 16:08 |
*** jistr has quit IRC | 16:12 | |
*** sdake has quit IRC | 16:14 | |
*** GB21_ is now known as GB21 | 16:17 | |
*** groen692 has quit IRC | 16:18 | |
*** exploreshaifali has joined #openstack-glance | 16:24 | |
*** annegentle has quit IRC | 16:38 | |
*** smatzek has quit IRC | 16:41 | |
*** bdossant has quit IRC | 16:41 | |
*** takedakn has joined #openstack-glance | 16:42 | |
*** Fin1te has quit IRC | 16:42 | |
*** takedakn has quit IRC | 16:42 | |
openstackgerrit | Tomoki Sekiyama proposed openstack/glance_store: Implement get, add and delete for cinder store https://review.openstack.org/166414 | 16:51 |
openstackgerrit | Erno Kuvaja proposed openstack/glance: Add mechanism to limit Request ID size https://review.openstack.org/210025 | 16:56 |
openstackgerrit | Erno Kuvaja proposed openstack/glance: Setting default max_request_id_length to 64 https://review.openstack.org/210026 | 16:56 |
*** lakshmiS has quit IRC | 16:57 | |
*** bapalm_ has quit IRC | 17:01 | |
openstackgerrit | GB21 proposed openstack/glance: Add a task_scrub function https://review.openstack.org/209255 | 17:03 |
*** harshs has joined #openstack-glance | 17:11 | |
*** spzala has joined #openstack-glance | 17:12 | |
*** chlong has quit IRC | 17:14 | |
jokke_ | nikhil_k, sigmavirus24: https://bugs.launchpad.net/glance/+bug/1482301 fix proposed to all branches | 17:19 |
openstack | Launchpad bug 1482301 in Glance "'X-Openstack-Request-ID' leght limited only by header size" [Critical,In progress] - Assigned to Erno Kuvaja (jokke) | 17:19 |
jokke_ | hemanthm: ^^ you as well if still around | 17:23 |
nikhil_k | jokke_: done | 17:23 |
nikhil_k | at least the bug part | 17:24 |
jokke_ | nikhil_k: ;) | 17:24 |
jokke_ | nikhil_k: we gotta wait for the checks, but would be nice if you would look through the fix if and flag anything you think needs to change so I can do them asap | 17:25 |
nikhil_k | jokke_: added a comment on master | 17:26 |
hemanthm | jokke_: hey | 17:26 |
nikhil_k | hemanthm: ^ | 17:26 |
jokke_ | nikhil_k: | 17:27 |
jokke_ | sorry | 17:27 |
hemanthm | looking | 17:27 |
jokke_ | is there standard size? | 17:27 |
nikhil_k | is abhishek around? | 17:27 |
nikhil_k | I thought it was uuid? | 17:28 |
nikhil_k | not sure what's the latest on the consensus around the prefixing it with other things | 17:28 |
jokke_ | nikhil_k: yeah, and it's actually irrelevant on that first change as it's intentionally just bringing the mechanism without limit so it was easily backportable | 17:30 |
jokke_ | backwards compatible and all | 17:30 |
nikhil_k | I see | 17:30 |
nikhil_k | that's great point | 17:30 |
nikhil_k | ok, +2 coming your way then | 17:30 |
nikhil_k | but good to get a +1 from abhishek first | 17:30 |
nikhil_k | ot tpatil | 17:30 |
nikhil_k | or* | 17:30 |
nikhil_k | first == before merge | 17:31 |
*** sdake has joined #openstack-glance | 17:33 | |
jokke_ | I'm well willing to debate on the one that actually sets any limit, I just want to have that limiting mechanism in there so we can provide admins tools to plug that security hole ... the initial 0 does not limit | 17:41 |
*** marcusvrn has quit IRC | 17:43 | |
*** eandersson has quit IRC | 17:47 | |
*** exploreshaifali has quit IRC | 17:47 | |
*** exploreshaifali has joined #openstack-glance | 17:52 | |
*** markus_z has quit IRC | 17:53 | |
*** exploreshaifali has quit IRC | 17:54 | |
*** zul has joined #openstack-glance | 17:56 | |
*** abhishekk has joined #openstack-glance | 18:01 | |
abhishekk | jokke_: hi you around? | 18:01 |
abhishekk | nikhil_k: hi | 18:02 |
nikhil_k | abhishekk: o/ | 18:02 |
nikhil_k | I am around just for a bit, sorry got a plenty to handle today :// | 18:03 |
abhishekk | nikhil_k: sure no proble | 18:03 |
nikhil_k | abhishekk: is this the req-id limit thin? | 18:03 |
abhishekk | just want to say https://bugs.launchpad.net/glance/+bug/1482301 is not there in juno and kilo | 18:03 |
openstack | Launchpad bug 1482301 in Glance "'X-Openstack-Request-ID' lenght limited only by header size" [Critical,In progress] - Assigned to Erno Kuvaja (jokke) | 18:03 |
abhishekk | then how it is just by design in liberty? | 18:04 |
*** bapalm has joined #openstack-glance | 18:04 | |
abhishekk | sorry, https://bugs.launchpad.net/glance/+bug/1480191 | 18:04 |
openstack | Launchpad bug 1480191 in Glance "User can send 'request-id' from headers to glance api" [Undecided,Opinion] - Assigned to Abhijeet Malawade (abhijeet-malawade) | 18:04 |
nikhil_k | eh, that's my gtd got in the way | 18:04 |
nikhil_k | ah | 18:04 |
abhishekk | I am not sure how x-openstack-request-id header passed by user is not accepted in juno and kilo and in current master it is accepting | 18:06 |
nikhil_k | abhishekk: can you please elaborate more on this? | 18:08 |
abhishekk | nikhil_k: even if user pass 'x-openstack-request-id' from header, it is not accepted in glance | 18:09 |
abhishekk | nikhil_k: i ran this curl command on stable/juno curl -g -i -X GET -H 'Accept-Encoding: gzip, deflate' -H 'Accept: */*' -H 'Connection: keep-alive' -H 'X-Auth-Token: ff173629aa104fa9bdb7266347d05128' -H 'X-Openstack-Request-Id: testing--aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa123456' http://10.69.4.174:9292/v2/images?limit=1 | 18:09 |
abhishekk | and got this response, HTTP/1.1 200 OK Content-Length: 737 Content-Type: application/json; charset=UTF-8 X-Openstack-Request-Id: req-6db4f65a-0440-4a49-9919-521b472506a2 Date: Thu, 06 Aug 2015 17:56:54 GMT Connection: keep-alive | 18:10 |
nikhil_k | hmm, is that oslo.middleware update that caused this? | 18:10 |
abhishekk | the 'X-Openstack-Request-Id' is generated by glance IMO | 18:11 |
nikhil_k | but teh middleware handles/can handle headers | 18:11 |
nikhil_k | I don;t think we enabled anything in glance that would loosen header restrictions | 18:12 |
nikhil_k | abhishekk: is your issue about letting people pass that header? | 18:13 |
abhishekk | nikhil_k: yes | 18:13 |
nikhil_k | abhishekk: I think fixing that case makes sense | 18:13 |
nikhil_k | we are allowed to make api changes until liberty freeze | 18:14 |
abhishekk | nikhil_k: ok | 18:14 |
nikhil_k | let's hear from jokke on that bug why he things e need to let pass that header | 18:14 |
nikhil_k | abhishekk: thanks, catchya later | 18:14 |
abhishekk | nikhil_k: thank you | 18:15 |
*** abhishekk has quit IRC | 18:15 | |
*** spzala has quit IRC | 18:17 | |
jokke_ | I'm here | 18:17 |
*** pal has joined #openstack-glance | 18:20 | |
*** Fin1te has joined #openstack-glance | 18:21 | |
*** ayoung has quit IRC | 18:34 | |
*** e0ne has quit IRC | 18:37 | |
*** mtreinish has quit IRC | 18:37 | |
*** mtreinish has joined #openstack-glance | 18:39 | |
*** spzala has joined #openstack-glance | 18:40 | |
*** lakshmiS has joined #openstack-glance | 18:45 | |
*** harlowja has quit IRC | 18:56 | |
*** lakshmiS has quit IRC | 18:58 | |
*** GB21_ has joined #openstack-glance | 19:04 | |
*** harshs has quit IRC | 19:05 | |
*** GB21 has quit IRC | 19:07 | |
*** annegentle has joined #openstack-glance | 19:09 | |
*** wokuma has joined #openstack-glance | 19:13 | |
*** harshs has joined #openstack-glance | 19:24 | |
*** e0ne has joined #openstack-glance | 19:24 | |
*** harshs has quit IRC | 19:25 | |
*** boris-42 has joined #openstack-glance | 19:39 | |
*** fifieldt_ has joined #openstack-glance | 19:39 | |
*** fifieldt has quit IRC | 19:42 | |
*** ayoung has joined #openstack-glance | 19:49 | |
*** fnordahl has quit IRC | 20:10 | |
*** daemontool_ has joined #openstack-glance | 20:10 | |
*** Fin1te has quit IRC | 20:12 | |
*** marzif has quit IRC | 20:12 | |
*** tpeoples has quit IRC | 20:16 | |
*** fnordahl has joined #openstack-glance | 20:17 | |
*** DCWilliams_VA has joined #openstack-glance | 20:21 | |
hemanthm | jokke_, flaper87: created the v1 status bug we talked about earlier in the morning. | 20:23 |
*** dims_ has joined #openstack-glance | 20:23 | |
hemanthm | it's private for now, but I subscribed you both to it | 20:23 |
*** dims_ has quit IRC | 20:24 | |
*** e0ne has quit IRC | 20:24 | |
sigmavirus24 | hemanthm: if it was spoken about in the meeting and you're continuing to speak about it in public IRC channels there's no point keeping it private security | 20:25 |
*** dims_ has joined #openstack-glance | 20:25 | |
*** dims has quit IRC | 20:26 | |
*** DCWilliams_VA has quit IRC | 20:26 | |
hemanthm | sigmavirus24: well I realized certain things only after I tested it in devstack. It can't be worse to let the security team look at it first | 20:27 |
hemanthm | anyway, +1 you have a point :) | 20:28 |
sigmavirus24 | hemanthm: yeah just stop using public logged channels to discuss it | 20:28 |
hemanthm | aye | 20:30 |
*** pal has quit IRC | 20:37 | |
*** sgotliv_ has quit IRC | 20:44 | |
*** bapalm has quit IRC | 20:50 | |
*** GB21_ has quit IRC | 20:59 | |
jokke_ | thanks hemanthm | 21:02 |
jokke_ | I'll include that to my comments in it | 21:03 |
jokke_ | hemanthm: if you have the environment still available, mind to check how image-upload behaves | 21:06 |
*** e0ne has joined #openstack-glance | 21:09 | |
*** ayoung has quit IRC | 21:11 | |
*** e0ne has quit IRC | 21:16 | |
*** bpoulos has joined #openstack-glance | 21:17 | |
*** annegentle has quit IRC | 21:18 | |
*** harshs has joined #openstack-glance | 21:24 | |
*** MVenesio has quit IRC | 21:24 | |
*** flwang1 has joined #openstack-glance | 21:29 | |
flwang1 | nikhil_k: ping | 21:29 |
*** harlowja has joined #openstack-glance | 21:34 | |
*** belmoreira has joined #openstack-glance | 21:35 | |
*** harlowja has quit IRC | 21:39 | |
*** harlowja has joined #openstack-glance | 21:39 | |
openstackgerrit | Erno Kuvaja proposed openstack/glance: Setting default max_request_id_length to 64 https://review.openstack.org/210026 | 21:40 |
openstackgerrit | Erno Kuvaja proposed openstack/glance: Add mechanism to limit Request ID size https://review.openstack.org/210025 | 21:40 |
*** alanf has joined #openstack-glance | 21:43 | |
alanf | anyone know if glance in fact support image creation from tar.gz file? | 21:44 |
*** zul has quit IRC | 21:45 | |
*** vijendar has quit IRC | 21:47 | |
*** zul has joined #openstack-glance | 21:55 | |
*** delattec has quit IRC | 21:58 | |
openstackgerrit | Brianna Poulos proposed openstack/glance-specs: Image Signing and Verification Support https://review.openstack.org/177948 | 22:03 |
jokke_ | alanf: how do you mean? | 22:12 |
jokke_ | alanf: iirc some compresser archives were supported on Images API v1 copy-from functionality, but we do not support that currently in v2 nor we do support it if user just uploads it (I'm not sure 'though if it works) | 22:13 |
jokke_ | compressed even | 22:14 |
alanf | jokke_ i am trying to determine if glance can properly download and handle a remote image source that is compressed | 22:14 |
alanf | i see | 22:14 |
openstackgerrit | Fei Long Wang proposed openstack/python-glanceclient: Use API v2 as default https://review.openstack.org/193931 | 22:15 |
alanf | current in horizon there is help text: | 22:15 |
alanf | Currently only images available via an HTTP URL are supported. The image location must be accessible to the Image Service. Compressed image binaries are supported (.zip and .tar.gz.) | 22:15 |
alanf | it has been around since 2012 i think, but recently a user reported the feature broken | 22:16 |
alanf | i am trying to determine is this is a defect in horizon and/or glance, or this is deprecated and this helper text needs to be updated | 22:16 |
openstackgerrit | Fei Long Wang proposed openstack/python-glanceclient: Use API v2 as default https://review.openstack.org/193931 | 22:18 |
jokke_ | alanf: it's supposed to work still with Images Api v1 | 22:18 |
jokke_ | Not sure if Horizon even uses that anymore and wouldn't be surprised if it had broken at some point and no-one just noticed it | 22:19 |
jokke_ | so feel free to file a bug if your investigations comes to the conclusion that the issue is indeed in glance | 22:19 |
alanf | ok thanks! | 22:19 |
*** edmondsw has quit IRC | 22:20 | |
*** zul has quit IRC | 22:35 | |
jamielennox | flaper87, nikhil_k, sigmavirus24: so in addition to glance_store we need a glanceclient release as well please | 22:42 |
*** dims_ has quit IRC | 22:50 | |
*** dims_ has joined #openstack-glance | 23:10 | |
*** shalq has quit IRC | 23:16 | |
*** shalq has joined #openstack-glance | 23:16 | |
*** r-daneel has quit IRC | 23:17 | |
*** sdake has quit IRC | 23:38 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!