| *** haomaiwa_ has quit IRC | 00:01 | |
| *** haomaiwang has joined #openstack-glance | 00:01 | |
| *** ducttape_ has joined #openstack-glance | 00:09 | |
| *** harshs has joined #openstack-glance | 00:11 | |
| *** sb- is now known as sb | 00:17 | |
| *** mfedosin has quit IRC | 00:23 | |
| *** kebray has joined #openstack-glance | 00:33 | |
| *** sgotliv has quit IRC | 00:37 | |
| *** kebray has quit IRC | 00:40 | |
| *** ducttape_ has quit IRC | 00:55 | |
| *** haomaiwang has quit IRC | 01:01 | |
| *** haomaiwa_ has joined #openstack-glance | 01:02 | |
| *** vilobhmm11 has quit IRC | 01:17 | |
| *** harlowja has quit IRC | 01:18 | |
| *** chlong has joined #openstack-glance | 01:18 | |
| *** harshs has quit IRC | 01:19 | |
| *** achanda has quit IRC | 01:21 | |
| *** achanda has joined #openstack-glance | 01:33 | |
| *** jasondotstar has quit IRC | 01:35 | |
| *** raginbajin has quit IRC | 01:35 | |
| *** dims_ has joined #openstack-glance | 01:37 | |
| *** jasondotstar has joined #openstack-glance | 01:37 | |
| *** raginbajin has joined #openstack-glance | 01:37 | |
| *** dims has quit IRC | 01:38 | |
| *** azbiswas has quit IRC | 01:39 | |
| *** azbiswas has joined #openstack-glance | 01:39 | |
| *** dims_ has quit IRC | 01:41 | |
| *** azbiswas has quit IRC | 01:43 | |
| *** dims has joined #openstack-glance | 01:49 | |
| *** azbiswas has joined #openstack-glance | 01:57 | |
| *** ducttape_ has joined #openstack-glance | 01:59 | |
| *** haomaiwa_ has quit IRC | 02:01 | |
| *** haomaiwang has joined #openstack-glance | 02:03 | |
| *** edmondsw has quit IRC | 02:03 | |
| *** mtanino has quit IRC | 02:04 | |
| *** mragupat has joined #openstack-glance | 02:08 | |
| *** mragupat has quit IRC | 02:08 | |
| *** azbiswas_ has joined #openstack-glance | 02:08 | |
| *** mragupat has joined #openstack-glance | 02:08 | |
| *** ByPasS_ has joined #openstack-glance | 02:14 | |
| *** azbiswas has quit IRC | 02:15 | |
| *** openstackgerrit has quit IRC | 02:15 | |
| *** ByPasS has quit IRC | 02:15 | |
| *** ByPasS_ is now known as ByPasS | 02:15 | |
| *** chlong has quit IRC | 02:15 | |
| *** harshs has joined #openstack-glance | 02:18 | |
| *** openstackgerrit has joined #openstack-glance | 02:23 | |
| *** mragupat has quit IRC | 02:24 | |
| *** ducttape_ has quit IRC | 02:26 | |
| *** ducttape_ has joined #openstack-glance | 02:27 | |
| *** chlong has joined #openstack-glance | 02:29 | |
| *** vilobhmm11 has joined #openstack-glance | 02:34 | |
| *** ducttape_ has quit IRC | 02:35 | |
| *** haomaiwang has quit IRC | 03:01 | |
| *** harshs has quit IRC | 03:01 | |
| *** haomaiwang has joined #openstack-glance | 03:01 | |
| *** vilobhmm11 has quit IRC | 03:04 | |
| *** links has joined #openstack-glance | 03:10 | |
| *** vilobhmm11 has joined #openstack-glance | 03:12 | |
| *** vilobhmm11 has quit IRC | 03:27 | |
| *** vilobhmm11 has joined #openstack-glance | 03:31 | |
| openstackgerrit | Merged openstack/glance_store: Use url_for from keystoneclient in swift store https://review.openstack.org/272990 | 03:44 |
|---|---|---|
| *** azbiswas_ has quit IRC | 03:52 | |
| *** azbiswas has joined #openstack-glance | 03:53 | |
| *** flwang1 has quit IRC | 03:53 | |
| *** azbiswas has quit IRC | 03:57 | |
| *** harshs has joined #openstack-glance | 03:58 | |
| *** ducttape_ has joined #openstack-glance | 03:58 | |
| *** harshs has quit IRC | 03:59 | |
| *** haomaiwang has quit IRC | 04:01 | |
| *** haomaiwang has joined #openstack-glance | 04:01 | |
| *** gjayavelu has joined #openstack-glance | 04:01 | |
| *** azbiswas has joined #openstack-glance | 04:04 | |
| openstackgerrit | Merged openstack/glance_store: Updated from global requirements https://review.openstack.org/278669 | 04:11 |
| *** boris-42 has quit IRC | 04:14 | |
| *** pt_15 has quit IRC | 04:15 | |
| *** itisha has quit IRC | 04:16 | |
| *** mragupat has joined #openstack-glance | 04:21 | |
| *** vilobhmm11 has quit IRC | 04:22 | |
| *** vilobhmm11 has joined #openstack-glance | 04:23 | |
| *** vilobhmm11 has quit IRC | 04:24 | |
| *** harshs has joined #openstack-glance | 04:28 | |
| *** ducttape_ has quit IRC | 04:29 | |
| openstackgerrit | javeme proposed openstack/glance: Drop python 2.6 support https://review.openstack.org/278859 | 04:35 |
| *** harshs has quit IRC | 04:43 | |
| *** dims has quit IRC | 04:43 | |
| *** mfedosin has joined #openstack-glance | 04:47 | |
| *** julim has joined #openstack-glance | 05:00 | |
| *** haomaiwang has quit IRC | 05:01 | |
| *** haomaiwa_ has joined #openstack-glance | 05:01 | |
| *** jamielennox is now known as jamielennox|away | 05:06 | |
| *** jamielennox|away is now known as jamielennox | 05:31 | |
| *** vilobhmm11 has joined #openstack-glance | 05:48 | |
| *** haomaiwa_ has quit IRC | 06:01 | |
| *** 18VAACNL5 has joined #openstack-glance | 06:01 | |
| *** abhishekk has joined #openstack-glance | 06:18 | |
| openstackgerrit | Abhishek Kekane proposed openstack/glance: glance-manage db purge failure for limit https://review.openstack.org/278870 | 06:19 |
| abhishekk | mclaren: hi could you please review this patch https://review.openstack.org/261288 | 06:33 |
| abhishekk | , when you get time. We have implemented request-id hooks solution as per your suggestion | 06:33 |
| openstackgerrit | Merged openstack/glance: Imported Translations from Zanata https://review.openstack.org/277698 | 06:37 |
| *** groen692 has joined #openstack-glance | 06:41 | |
| openstackgerrit | Abhishek Kekane proposed openstack/glance: glance-manage db purge failure for limit https://review.openstack.org/278870 | 06:44 |
| openstackgerrit | Abhishek Kekane proposed openstack/glance: glance-manage db purge failure for limit https://review.openstack.org/278870 | 06:45 |
| *** 18VAACNL5 has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-glance | 07:01 | |
| *** baojg has joined #openstack-glance | 07:13 | |
| *** vilobhmm111 has joined #openstack-glance | 07:31 | |
| *** vilobhmm11 has quit IRC | 07:33 | |
| *** baojg has quit IRC | 07:35 | |
| *** baojg has joined #openstack-glance | 07:35 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/glance: Updated from global requirements https://review.openstack.org/277126 | 07:39 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/glance_store: Updated from global requirements https://review.openstack.org/278898 | 07:39 |
| *** baojg has quit IRC | 07:42 | |
| *** sgotliv has joined #openstack-glance | 07:49 | |
| *** baojg has joined #openstack-glance | 07:55 | |
| *** vilobhmm11 has joined #openstack-glance | 07:57 | |
| *** vilobhmm111 has quit IRC | 07:57 | |
| openstackgerrit | Abhishek Kekane proposed openstack/glance: glance-manage db purge failure for limit https://review.openstack.org/278870 | 07:58 |
| *** haomaiwang has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-glance | 08:01 | |
| *** sinese_ has joined #openstack-glance | 08:10 | |
| *** achanda has quit IRC | 08:11 | |
| *** achanda has joined #openstack-glance | 08:14 | |
| openstackgerrit | Kairat Kushaev proposed openstack/python-glanceclient: Add reno to glanceclient https://review.openstack.org/278920 | 08:19 |
| kairat_ | Glance folks, could you please merge that ^, looks like we need to start adding notes for glanceclient | 08:26 |
| *** vilobhmm11 has quit IRC | 08:26 | |
| *** sinese_ has quit IRC | 08:34 | |
| abhishekk | kairat_: ++, its require | 08:35 |
| *** rcernin has joined #openstack-glance | 08:35 | |
| kairat_ | abhishekk, I guess it needs for request_ids change | 08:36 |
| abhishekk | kairat_: yes, once your patch will merge, I will add release notes patch | 08:36 |
| abhishekk | kairat_: thanks for taking this ahead | 08:38 |
| kairat_ | abhishekk, BTW, request patch seems good | 08:38 |
| kairat_ | I just would like all doc strings to be updated =) | 08:38 |
| abhishekk | kairat_: tahnk you, I am adding docstring as per you suggestion | 08:38 |
| abhishekk | kairat_: tahnk you for review | 08:39 |
| *** mragupat has quit IRC | 08:40 | |
| *** e0ne has joined #openstack-glance | 08:42 | |
| *** achanda has quit IRC | 08:44 | |
| *** azbiswas has quit IRC | 08:44 | |
| *** openstackgerrit has quit IRC | 08:47 | |
| *** openstackgerrit_ has joined #openstack-glance | 08:47 | |
| *** openstackgerrit_ is now known as openstackgerrit | 08:48 | |
| *** gjayavelu has quit IRC | 08:49 | |
| *** sgotliv has quit IRC | 08:52 | |
| *** slunkad has quit IRC | 08:56 | |
| *** rsjethani has joined #openstack-glance | 08:59 | |
| rsjethani | kairat u here? | 08:59 |
| rsjethani | kairat_ u here? | 09:00 |
| *** haomaiwang has quit IRC | 09:01 | |
| kairat_ | rsjethani, yep | 09:01 |
| *** haomaiwa_ has joined #openstack-glance | 09:01 | |
| rsjethani | regarding your comment : https://review.openstack.org/#/c/261288/4/glanceclient/v2/images.py@218 | 09:02 |
| rsjethani | There are methods which do not have docstring at all | 09:03 |
| rsjethani | for example https://review.openstack.org/#/c/261288/4/glanceclient/v2/image_members.py@35 | 09:04 |
| kairat_ | Soo, what's the question=)? | 09:05 |
| rsjethani | so should I modify only existing docstrings? | 09:05 |
| rsjethani | or add docstrings for methods where there is no docstring? | 09:05 |
| kairat_ | If you have time to update it I would love it=) | 09:07 |
| kairat_ | But it is not required to be honest) | 09:07 |
| kairat_ | At least for me | 09:07 |
| *** slunkad has joined #openstack-glance | 09:08 | |
| rsjethani | ok so for now I will modify exisitng doctrings and later will submit a separate patch to add new docstrings | 09:09 |
| *** mvk has joined #openstack-glance | 09:27 | |
| openstackgerrit | Darja Shakhray proposed openstack/glance: Added support new v2 API image filters https://review.openstack.org/248359 | 09:40 |
| openstackgerrit | Kairat Kushaev proposed openstack/glance: Use keystoneclient functions to receive endpoint https://review.openstack.org/274131 | 09:43 |
| *** baojg_ has joined #openstack-glance | 09:58 | |
| *** baojg has quit IRC | 09:58 | |
| *** haomaiwa_ has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-glance | 10:01 | |
| *** dshakhray has joined #openstack-glance | 10:02 | |
| openstackgerrit | Darja Shakhray proposed openstack/glance: Unallowed request PATCH when work with blob https://review.openstack.org/229312 | 10:27 |
| *** gberginc has joined #openstack-glance | 10:33 | |
| openstackgerrit | Darja Shakhray proposed openstack/glance: Fix 500 status code when we add in "depend_on" yourself https://review.openstack.org/220587 | 10:35 |
| *** achanda has joined #openstack-glance | 10:44 | |
| *** azbiswas has joined #openstack-glance | 10:44 | |
| *** dims has joined #openstack-glance | 10:48 | |
| *** azbiswas has quit IRC | 10:50 | |
| *** achanda has quit IRC | 10:51 | |
| *** mvk has quit IRC | 10:54 | |
| *** haomaiwang has quit IRC | 11:01 | |
| *** haomaiwa_ has joined #openstack-glance | 11:01 | |
| *** baojg_ has quit IRC | 11:12 | |
| *** baojg has joined #openstack-glance | 11:16 | |
| *** mvk has joined #openstack-glance | 11:26 | |
| *** achanda has joined #openstack-glance | 11:48 | |
| *** achanda has quit IRC | 11:52 | |
| openstackgerrit | Flavio Percoco proposed openstack/python-glanceclient: Add reno to glanceclient https://review.openstack.org/278920 | 11:58 |
| openstackgerrit | Ravi Shekhar Jethani proposed openstack/python-glanceclient: Provide a list of request ids to the caller https://review.openstack.org/261288 | 12:00 |
| *** haomaiwa_ has quit IRC | 12:01 | |
| *** haomaiwang has joined #openstack-glance | 12:01 | |
| *** ig0r_ has joined #openstack-glance | 12:12 | |
| *** smatzek has joined #openstack-glance | 12:20 | |
| flaper87 | rosmaita: hey there! Sorry for not having gotten back on the `tar` thread. I will | 12:24 |
| *** dims has quit IRC | 12:40 | |
| *** mclaren has quit IRC | 12:45 | |
| *** azbiswas has joined #openstack-glance | 12:47 | |
| *** azbiswas has quit IRC | 12:51 | |
| *** jaypipes has joined #openstack-glance | 12:56 | |
| *** sgotliv has joined #openstack-glance | 12:56 | |
| *** mfedosin has quit IRC | 13:00 | |
| *** haomaiwang has quit IRC | 13:01 | |
| *** haomaiwang has joined #openstack-glance | 13:01 | |
| *** delattec has joined #openstack-glance | 13:10 | |
| *** ducttape_ has joined #openstack-glance | 13:11 | |
| *** delatte has quit IRC | 13:13 | |
| *** dims has joined #openstack-glance | 13:20 | |
| *** smatzek has quit IRC | 13:23 | |
| *** rsjethani has quit IRC | 13:23 | |
| *** ducttape_ has quit IRC | 13:27 | |
| *** delatte has joined #openstack-glance | 13:32 | |
| rosmaita | flaper87: np, i forgot all about that, guess there's no interest ATM | 13:34 |
| *** delattec has quit IRC | 13:35 | |
| *** burgerk has joined #openstack-glance | 13:37 | |
| *** edmondsw has joined #openstack-glance | 13:38 | |
| *** abhishekk has quit IRC | 13:40 | |
| *** smatzek has joined #openstack-glance | 13:47 | |
| *** links has quit IRC | 13:48 | |
| *** achanda has joined #openstack-glance | 13:50 | |
| *** mfedosin has joined #openstack-glance | 13:51 | |
| *** ninag has joined #openstack-glance | 13:55 | |
| *** achanda has quit IRC | 13:55 | |
| *** edmondsw has quit IRC | 13:59 | |
| *** haomaiwang has quit IRC | 14:01 | |
| *** haomaiwang has joined #openstack-glance | 14:01 | |
| *** julim has quit IRC | 14:05 | |
| *** krotscheck_dcm is now known as krotscheck | 14:15 | |
| *** gberginc has quit IRC | 14:22 | |
| *** links has joined #openstack-glance | 14:28 | |
| *** baojg has quit IRC | 14:37 | |
| *** julim has joined #openstack-glance | 14:52 | |
| *** ducttape_ has joined #openstack-glance | 14:59 | |
| *** haomaiwang has quit IRC | 15:01 | |
| *** haomaiwang has joined #openstack-glance | 15:01 | |
| *** burgerk has quit IRC | 15:01 | |
| dshakhray | I have one question) 'king kong' is one or two values in filter 'in:123,"king""kong",456' | 15:06 |
| *** jwang_ has joined #openstack-glance | 15:08 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/glance: Updated from global requirements https://review.openstack.org/277126 | 15:09 |
| *** gjayavelu has joined #openstack-glance | 15:09 | |
| dshakhray | mfedosin, flaper87 | 15:11 |
| *** jwang has quit IRC | 15:12 | |
| mfedosin | dshakhray: I suppose one | 15:13 |
| mfedosin | but the quotes have to be escaped | 15:14 |
| *** harshs has joined #openstack-glance | 15:16 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:17 | |
| dshakhray | but what to do in this case? split or merge? | 15:17 |
| *** mragupat has joined #openstack-glance | 15:18 | |
| *** ig0r_ has quit IRC | 15:21 | |
| *** pushkaru has joined #openstack-glance | 15:21 | |
| *** mfedosin has quit IRC | 15:24 | |
| openstackgerrit | Merged openstack/python-glanceclient: Add reno to glanceclient https://review.openstack.org/278920 | 15:24 |
| *** burgerk has joined #openstack-glance | 15:26 | |
| *** vijendar has joined #openstack-glance | 15:30 | |
| *** azbiswas has joined #openstack-glance | 15:33 | |
| kairat_ | i've asked about that in openstack-sdks without no answer | 15:33 |
| kairat_ | Looks like that are on meeting | 15:33 |
| *** achanda has joined #openstack-glance | 15:34 | |
| openstackgerrit | Kairat Kushaev proposed openstack/glance: [WIP] Refactoring - provide single place to initialize policy https://review.openstack.org/279144 | 15:35 |
| *** zul_ has joined #openstack-glance | 15:36 | |
| *** zul has quit IRC | 15:36 | |
| *** mtanino has joined #openstack-glance | 15:40 | |
| openstackgerrit | Darja Shakhray proposed openstack/glance: Added support new v2 API image filters https://review.openstack.org/248359 | 15:41 |
| *** achanda has quit IRC | 15:42 | |
| *** edmondsw has joined #openstack-glance | 15:43 | |
| *** sgotliv has quit IRC | 15:51 | |
| *** gjayavelu has quit IRC | 15:52 | |
| *** EmilienM has quit IRC | 15:53 | |
| *** HenryG has quit IRC | 15:55 | |
| *** vijendar1 has joined #openstack-glance | 15:58 | |
| *** achanda has joined #openstack-glance | 15:59 | |
| *** haomaiwang has quit IRC | 16:01 | |
| *** haomaiwa_ has joined #openstack-glance | 16:01 | |
| *** HenryG has joined #openstack-glance | 16:02 | |
| *** achanda has quit IRC | 16:02 | |
| *** vijendar has quit IRC | 16:02 | |
| *** links has quit IRC | 16:04 | |
| *** EmilienM has joined #openstack-glance | 16:06 | |
| *** vijendar has joined #openstack-glance | 16:10 | |
| *** vijendar1 has quit IRC | 16:11 | |
| *** harshs has quit IRC | 16:19 | |
| *** mvk has quit IRC | 16:24 | |
| *** flwang1 has joined #openstack-glance | 16:30 | |
| *** nikhil_k has joined #openstack-glance | 16:38 | |
| *** tpeoples has quit IRC | 16:38 | |
| *** comstud has quit IRC | 16:38 | |
| *** toan has quit IRC | 16:39 | |
| *** ayoung has quit IRC | 16:39 | |
| *** nikhil has quit IRC | 16:39 | |
| *** toan has joined #openstack-glance | 16:40 | |
| *** tpeoples has joined #openstack-glance | 16:43 | |
| *** comstud has joined #openstack-glance | 16:44 | |
| *** dshakhray has quit IRC | 16:44 | |
| *** nikhil_k is now known as nikhil | 16:50 | |
| *** r-daneel has joined #openstack-glance | 16:52 | |
| *** ayoung has joined #openstack-glance | 16:52 | |
| *** lakshmiS has joined #openstack-glance | 16:53 | |
| *** rcernin has quit IRC | 16:56 | |
| *** sgotliv has joined #openstack-glance | 16:58 | |
| *** haomaiwa_ has quit IRC | 17:01 | |
| *** haomaiwang has joined #openstack-glance | 17:01 | |
| openstackgerrit | Flavio Percoco proposed openstack/python-glanceclient: Auto-generated squash commit https://review.openstack.org/279190 | 17:04 |
| flaper87 | sigmavirus24: jokke_ rosmaita nikhil kairat_ et all: I did this: https://review.openstack.org/279190 | 17:05 |
| flaper87 | That is a group of commits squashed together that are not worth running separate CI jobs for | 17:05 |
| flaper87 | I wanted to get your thoughts before going ahead and abandoning the original patches | 17:06 |
| *** pushkaru has quit IRC | 17:06 | |
| *** vijendar has quit IRC | 17:06 | |
| flaper87 | As far as ATC status goes, ppl will get their status and access to summit because `Co-Authored-by` is parsed | 17:06 |
| *** sgotliv has quit IRC | 17:06 | |
| kragniz | flaper87: interesting idea | 17:07 |
| flaper87 | This will help with reducing the jobs in the gate and it should also reduce the review queue | 17:07 |
| flaper87 | I've a script to do that now that I'll publish if you think this makes sense | 17:07 |
| flaper87 | kragniz: yeah, it kinda works as a PR on GH and running 1 job per PR | 17:08 |
| flaper87 | It really bothers me to have CI jobs running separately for a commit that just changes 1 letter in a docstring | 17:08 |
| flaper87 | and now that HP cloud is gone and we have even fewer resources, I think it makes more sense | 17:08 |
| flaper87 | I'll drop a comment on the review | 17:09 |
| jokke_ | flaper87: +++ | 17:11 |
| flaper87 | I just realized I can put the name of a group in the "Add reviewers" field | 17:12 |
| flaper87 | this... is... cool and dangerous | 17:12 |
| flaper87 | Why don't I ever read tooltip fields or help text in input fields ? | 17:12 |
| nikhil | flaper87: +2ed | 17:13 |
| jokke_ | flaper87: _store and stable releases early next week? | 17:13 |
| kragniz | flaper87: ssh, don't tell people about that | 17:13 |
| *** vijendar has joined #openstack-glance | 17:13 | |
| *** e0ne has quit IRC | 17:14 | |
| flaper87 | jokke_: yes, I was planning to do the store one this week but I found a couple of other reviews that would be better to have | 17:15 |
| flaper87 | jokke_: so, I'll ping you on monday | 17:15 |
| flaper87 | nikhil: awesome | 17:15 |
| jokke_ | flaper87: ++ | 17:16 |
| *** groen692 has quit IRC | 17:16 | |
| *** pushkaru has joined #openstack-glance | 17:24 | |
| *** vijendar1 has joined #openstack-glance | 17:42 | |
| *** vijendar has quit IRC | 17:46 | |
| *** flwang1 has quit IRC | 17:49 | |
| *** dshakhray has joined #openstack-glance | 17:54 | |
| *** harshs has joined #openstack-glance | 17:57 | |
| *** haomaiwang has quit IRC | 18:01 | |
| *** haomaiwang has joined #openstack-glance | 18:01 | |
| *** azbiswas has quit IRC | 18:06 | |
| *** e0ne has joined #openstack-glance | 18:15 | |
| *** rcernin has joined #openstack-glance | 18:17 | |
| *** gjayavelu has joined #openstack-glance | 18:50 | |
| *** vijendar1 has quit IRC | 18:51 | |
| *** vijendar has joined #openstack-glance | 18:54 | |
| *** gjayavelu has quit IRC | 18:54 | |
| *** vijendar1 has joined #openstack-glance | 18:55 | |
| *** vilobhmm11 has joined #openstack-glance | 18:55 | |
| *** vijendar has quit IRC | 18:58 | |
| openstackgerrit | YAMADA Hideki proposed openstack/glance_store: Sheepdog: fix image-download failure https://review.openstack.org/272448 | 18:58 |
| *** haomaiwang has quit IRC | 19:01 | |
| *** haomaiwang has joined #openstack-glance | 19:01 | |
| openstackgerrit | YAMADA Hideki proposed openstack/glance_store: Sheepdog: fix image-download failure https://review.openstack.org/272448 | 19:03 |
| *** harlowja has joined #openstack-glance | 19:04 | |
| *** dnovosel_ is now known as dnovosel | 19:06 | |
| *** avarner_ has quit IRC | 19:17 | |
| *** avarner_ has joined #openstack-glance | 19:22 | |
| openstackgerrit | Dina Belova proposed openstack/glance: Use OSprofiler options consolidated in lib itself https://review.openstack.org/278157 | 19:25 |
| *** boris-42 has joined #openstack-glance | 19:26 | |
| *** vijendar1 has quit IRC | 19:31 | |
| *** gberginc has joined #openstack-glance | 19:45 | |
| *** azbiswas has joined #openstack-glance | 19:50 | |
| *** gjayavelu has joined #openstack-glance | 19:51 | |
| *** haomaiwang has quit IRC | 20:01 | |
| *** haomaiwa_ has joined #openstack-glance | 20:01 | |
| *** vijendar has joined #openstack-glance | 20:02 | |
| *** ayoung has quit IRC | 20:06 | |
| *** vijendar has quit IRC | 20:14 | |
| *** gjayavelu has quit IRC | 20:21 | |
| *** ayoung has joined #openstack-glance | 20:22 | |
| *** rcernin has quit IRC | 20:24 | |
| *** flwang1 has joined #openstack-glance | 20:32 | |
| *** julim has quit IRC | 20:40 | |
| *** mriedem has joined #openstack-glance | 20:51 | |
| mriedem | is there such a concept as page_size in the glance api? | 20:52 |
| mriedem | the only thing i see in the code is some ImagePager test code | 20:52 |
| mriedem | but that all looks unused elsewhere, like in the actual api | 20:52 |
| *** e0ne has quit IRC | 20:53 | |
| *** smatzek has quit IRC | 20:54 | |
| flwang1 | mriedem: seems on, see https://github.com/openstack/glance/blob/master/glance/api/v2/images.py#L88 | 20:56 |
| flwang1 | mriedem: why ask? what's the background? | 20:56 |
| mriedem | s/on/no/ | 20:56 |
| mriedem | i think it's an s3 carry over | 20:56 |
| mriedem | i was looking at this nova code https://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L208-L209 | 20:57 |
| mriedem | and the only other place page_size is referenced in nova is when calling the glance API: https://github.com/openstack/nova/blob/master/nova/image/glance.py#L500 | 20:57 |
| mriedem | but glance doesn't actually have page_size in it's API | 20:57 |
| mriedem | so i think it comes from s3, which is the other image backend in nova i guess http://docs.aws.amazon.com/aws-sdk-php/v2/guide/feature-iterators.html | 20:58 |
| *** avarner_ has quit IRC | 20:58 | |
| *** haomaiwa_ has quit IRC | 21:01 | |
| flwang1 | mriedem: i think your analysis is correct, how about remove the page_size param for now? | 21:01 |
| flwang1 | given we never use it | 21:01 |
| *** vijendar has joined #openstack-glance | 21:01 | |
| mriedem | it's passed through to s3 | 21:01 |
| *** haomaiwang has joined #openstack-glance | 21:01 | |
| flwang1 | hmm... i see. so we still need it to keep the compatible with s3 but glance is just skipping it | 21:02 |
| flwang1 | mriedem: are you looking for implementing it in glance? | 21:02 |
| mriedem | i think anyway | 21:02 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/image/s3.py#L168 | 21:02 |
| mriedem | flwang1: no, i wanted to remove it from nova if it were unused | 21:02 |
| flwang1 | mriedem: remove sounds good for me | 21:03 |
| mriedem | i tend to not want to remove things i don't understand where they might be used, or why they aren't being used now | 21:10 |
| mriedem | usually leads to bugs | 21:10 |
| flwang1 | mriedem: yep, i agree | 21:12 |
| mriedem | hmm, might be in glanceclient https://github.com/openstack/nova/commit/d3aa5c59e0e2ed289d91d11b0fa3d15996aeac43 | 21:12 |
| mriedem | checking | 21:12 |
| flwang1 | based on glance code, glance doesn't support it | 21:12 |
| flwang1 | mriedem: https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v2/images.py#L96 | 21:13 |
| flwang1 | interesting... | 21:13 |
| flwang1 | ah i see | 21:14 |
| flwang1 | mriedem: we did the paging on client side | 21:14 |
| mriedem | yup | 21:14 |
| mriedem | i see that now | 21:14 |
| mriedem | ok, well, mystery solved | 21:14 |
| flwang1 | mriedem: it's a little bit weird | 21:14 |
| flaper87 | paging in the client is new and just for v2, AFAIR | 21:14 |
| flaper87 | or was it the marker thing? | 21:14 |
| flaper87 | :D | 21:14 |
| mriedem | well, this page_size thing was added to nova a looong time ago https://github.com/openstack/nova/commit/d3aa5c59e0e2ed289d91d11b0fa3d15996aeac43 | 21:15 |
| flaper87 | I know for sure it's v2 | 21:15 |
| flaper87 | likely from S3 as you mentioned | 21:15 |
| flaper87 | oh look, the comment on glanceclient is mine | 21:15 |
| flwang1 | flaper87: but generally, we shouldn't add logic on client side, right? | 21:15 |
| flaper87 | :D | 21:15 |
| flaper87 | we don't, normally... now? | 21:15 |
| flwang1 | flaper87: you always trick me with different standards :) | 21:16 |
| mriedem | yeah because anyone not using glanceclient doesn't get that support | 21:16 |
| flwang1 | flaper87: what's the problem/concern why we don't do the paging on server side? | 21:17 |
| flaper87 | flwang1: I think it's just that no one had implemented. But there's a patch to align v2 with some standards from the API WG | 21:18 |
| flaper87 | I believe marker/page are in. I don't recall exactly, TBH | 21:18 |
| mriedem | neutronclient also uses page_size it looks like | 21:18 |
| flwang1 | mriedem: on client side? | 21:18 |
| mriedem | yeah | 21:18 |
| flwang1 | mriedem: wow | 21:19 |
| mriedem | http://git.openstack.org/cgit/openstack/python-neutronclient/tree/neutronclient/neutron/v2_0/__init__.py#n162 | 21:19 |
| mriedem | this is the API WG patch btw https://review.openstack.org/#/c/190743/ | 21:20 |
| flwang1 | mriedem: obviously, the guideline is targeting the server side | 21:24 |
| *** pushkaru has quit IRC | 21:27 | |
| *** pushkaru has joined #openstack-glance | 21:28 | |
| flwang1 | flaper87: may i get your opinion on this one https://bugs.launchpad.net/python-glanceclient/+bug/1537626 ? | 21:36 |
| openstack | Launchpad bug 1537626 in python-glanceclient "`glance location-update` deletes locations and backend images" [Undecided,Confirmed] - Assigned to Fei Long Wang (flwang) | 21:36 |
| flwang1 | flaper87: btw did you get a chance to review the location rank spec-lite? | 21:37 |
| *** vijendar has quit IRC | 21:38 | |
| *** mriedem has left #openstack-glance | 21:39 | |
| *** MattMan_ has quit IRC | 21:42 | |
| *** MattMan has joined #openstack-glance | 21:42 | |
| *** ninag has quit IRC | 21:51 | |
| *** dshakhray has quit IRC | 21:52 | |
| *** ayoung has quit IRC | 21:52 | |
| *** avarner_ has joined #openstack-glance | 21:53 | |
| *** smatzek has joined #openstack-glance | 21:57 | |
| *** lakshmiS has quit IRC | 21:57 | |
| *** delatte has quit IRC | 22:00 | |
| *** _ducttape_ has joined #openstack-glance | 22:00 | |
| openstackgerrit | Kairat Kushaev proposed openstack/glance_store: LOG.warn is deprecated in python3 https://review.openstack.org/274801 | 22:00 |
| *** ayoung has joined #openstack-glance | 22:00 | |
| *** haomaiwang has quit IRC | 22:01 | |
| *** haomaiwang has joined #openstack-glance | 22:01 | |
| *** chlong has quit IRC | 22:03 | |
| *** burgerk has quit IRC | 22:03 | |
| *** ducttape_ has quit IRC | 22:03 | |
| *** bwallis has joined #openstack-glance | 22:06 | |
| *** mragupat has quit IRC | 22:23 | |
| *** dims has quit IRC | 22:23 | |
| openstackgerrit | Kairat Kushaev proposed openstack/glance_store: Sheepdog: fix image-download failure https://review.openstack.org/272448 | 22:25 |
| *** dims has joined #openstack-glance | 22:26 | |
| *** sgotliv has joined #openstack-glance | 22:28 | |
| *** bwallis has quit IRC | 22:28 | |
| *** mragupat has joined #openstack-glance | 22:29 | |
| *** smatzek has quit IRC | 22:29 | |
| *** _ducttape_ has quit IRC | 22:37 | |
| *** ayoung has quit IRC | 22:37 | |
| *** ducttape_ has joined #openstack-glance | 22:38 | |
| *** vijendar has joined #openstack-glance | 22:38 | |
| *** cdelatte has joined #openstack-glance | 22:42 | |
| *** ninag has joined #openstack-glance | 22:51 | |
| *** ninag has quit IRC | 22:56 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:58 | |
| *** haomaiwang has quit IRC | 23:01 | |
| *** haomaiwang has joined #openstack-glance | 23:01 | |
| flwang1 | jokke_: ping | 23:10 |
| flwang1 | jokke_: re the spec-lite process | 23:11 |
| *** mragupat has quit IRC | 23:11 | |
| flwang1 | jokke_: flaper87 mentioned you're working on the process of spec-lite, any porgress? | 23:11 |
| openstackgerrit | Merged openstack/glance_store: Updated from global requirements https://review.openstack.org/278898 | 23:11 |
| *** ninag has joined #openstack-glance | 23:16 | |
| *** ninag has quit IRC | 23:16 | |
| *** ayoung has joined #openstack-glance | 23:25 | |
| *** pushkaru has quit IRC | 23:27 | |
| *** chlong has joined #openstack-glance | 23:30 | |
| *** marcusvrn_ has quit IRC | 23:47 | |
| *** ayoung has quit IRC | 23:50 | |
| *** ducttape_ has quit IRC | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!