Friday, 2016-02-26

*** haomaiwa_ has joined #openstack-glance00:01
*** chlong_ has quit IRC00:03
*** ayoung has quit IRC00:04
*** haomaiwa_ has quit IRC00:09
*** dramakri has quit IRC00:22
*** kzaitsev_mb has quit IRC00:29
*** daemontool has quit IRC00:47
*** ayoung has joined #openstack-glance00:52
*** RichardRaseley has quit IRC00:57
*** vilobhmm11 has quit IRC00:59
*** haomaiwa_ has joined #openstack-glance01:06
*** ducttape_ has joined #openstack-glance01:08
*** ninag has quit IRC01:09
*** vilobhmm11 has joined #openstack-glance01:10
flwangflaper87: pls help review the location update patch https://review.openstack.org/28078601:10
flwangit's breaking the function, we need to get it in M01:10
openstackgerritMerged openstack/glance: remove redundant "#!/usr/bin/env python" header  https://review.openstack.org/28361001:12
openstackgerritFei Long Wang proposed openstack/glance: Fix location update  https://review.openstack.org/28078601:12
*** haomaiwa_ has quit IRC01:13
*** ducttape_ has quit IRC01:15
*** mtanino has quit IRC01:21
*** haomaiwang has joined #openstack-glance01:25
*** haomaiwang has quit IRC01:33
*** dims has quit IRC01:49
*** chlong_ has joined #openstack-glance01:49
*** annasort has joined #openstack-glance01:55
*** lakshmiS has quit IRC02:08
*** mingdang1 has joined #openstack-glance02:16
*** haomaiwang has joined #openstack-glance02:21
*** ducttape_ has joined #openstack-glance02:37
*** ducttape_ has quit IRC02:40
*** vilobhmm11 has quit IRC02:40
*** vilobhmm11 has joined #openstack-glance02:42
*** ducttape_ has joined #openstack-glance02:44
*** ducttape_ has quit IRC02:46
*** ducttape_ has joined #openstack-glance02:53
*** delatte has quit IRC02:56
*** vilobhmm11 has quit IRC02:56
*** haomaiwang has quit IRC03:01
*** haomaiwang has joined #openstack-glance03:01
*** harshs has quit IRC03:02
*** pushkaru has quit IRC03:05
*** dims has joined #openstack-glance03:10
openstackgerritTomoki Sekiyama proposed openstack/glance_store: Implement get, add and delete for cinder store  https://review.openstack.org/16641403:23
*** boris-42 has quit IRC03:24
*** links has joined #openstack-glance03:26
*** ducttape_ has quit IRC03:46
*** mingdang1 has quit IRC03:50
*** flwang1 has quit IRC03:54
*** azbiswas has joined #openstack-glance03:55
*** haomaiwang has quit IRC04:01
*** haomaiwang has joined #openstack-glance04:01
*** azbiswas has quit IRC04:12
*** vilobhmm11 has joined #openstack-glance04:25
*** vilobhmm11 has quit IRC04:39
*** vilobhmm11 has joined #openstack-glance04:39
openstackgerritErno Kuvaja proposed openstack/glance-specs: Initial lite-specs.rst and per deliverable folders  https://review.openstack.org/28251604:52
*** haomaiwang has quit IRC05:01
*** haomaiwang has joined #openstack-glance05:01
*** dshakhray has quit IRC05:04
*** ducttape_ has joined #openstack-glance05:05
*** rsjethani has joined #openstack-glance05:09
*** rsjethani has quit IRC05:16
*** ducttape_ has quit IRC05:37
*** mingdang1 has joined #openstack-glance05:38
*** vilobhmm11 has quit IRC05:39
*** mingdang1 has quit IRC05:46
*** haomaiwang has quit IRC06:01
*** haomaiwang has joined #openstack-glance06:01
*** mingdang1 has joined #openstack-glance06:01
openstackgerritMerged openstack/glance: Support importing OVA/OVF package to Glance  https://review.openstack.org/21481006:07
*** vilobhmm11 has joined #openstack-glance06:09
openstackgerritMerged openstack/glance_store: Updated from global requirements  https://review.openstack.org/28442906:09
*** sgotliv has joined #openstack-glance06:14
*** abhishekk_ has joined #openstack-glance06:23
*** links has quit IRC06:26
*** sgotliv has quit IRC06:33
*** sgotliv has joined #openstack-glance06:33
*** dims has quit IRC06:37
*** groen692 has joined #openstack-glance06:39
*** groen692 has quit IRC06:43
*** groen692 has joined #openstack-glance06:46
*** haomaiwang has quit IRC06:52
*** haomaiwang has joined #openstack-glance06:53
*** haomaiwang has quit IRC07:01
*** haomaiwang has joined #openstack-glance07:01
*** rcernin has joined #openstack-glance07:05
openstackgerritAndreas Jaeger proposed openstack/glance: Move bandit into pep8  https://review.openstack.org/28288507:07
*** sgotliv has quit IRC07:10
openstackgerritAndreas Jaeger proposed openstack/glance: Move bandit into pep8  https://review.openstack.org/28288507:11
openstackgerritAndreas Jaeger proposed openstack/glance: Move bandit into pep8  https://review.openstack.org/28288507:13
openstackgerritKairat Kushaev proposed openstack/glance_store: Implement re-authentication for swift driver  https://review.openstack.org/25185107:19
openstackgerritKairat Kushaev proposed openstack/glance_store: Implement swift store connection manager  https://review.openstack.org/25185007:19
*** chlong_ has quit IRC07:26
*** daemontool has joined #openstack-glance07:31
*** ihrachys has joined #openstack-glance07:39
openstackgerritMerged openstack/glance: Updated from global requirements  https://review.openstack.org/28502107:41
*** haomaiwang has quit IRC08:01
*** haomaiwang has joined #openstack-glance08:01
*** belmoreira has joined #openstack-glance08:08
*** achanda has quit IRC08:29
*** achanda has joined #openstack-glance08:33
*** daemontool has quit IRC08:35
*** daemontool has joined #openstack-glance08:36
openstackgerritTomoki Sekiyama proposed openstack/glance_store: Implement get, add and delete for cinder store  https://review.openstack.org/16641408:43
*** TravT has joined #openstack-glance08:49
*** vilobhmm11 has quit IRC08:54
*** haomaiwang has quit IRC09:01
*** haomaiwa_ has joined #openstack-glance09:01
*** achanda has quit IRC09:03
*** nikhil has quit IRC09:04
*** TravT has quit IRC09:05
kairatsigmavirus24_awa, could you please look at that: https://review.openstack.org/#/c/275120/? There is a question raised some time ago, so it would be good to clarify it.09:07
*** TravT has joined #openstack-glance09:07
*** TravT has quit IRC09:10
*** rcernin has quit IRC09:14
*** jistr has joined #openstack-glance09:27
*** rcernin has joined #openstack-glance09:28
*** ihrachys_ has joined #openstack-glance09:32
*** dshakhray has joined #openstack-glance09:33
*** ishant has joined #openstack-glance09:35
*** ihrachys has quit IRC09:35
*** rsjethani has joined #openstack-glance09:42
rsjethaniHi Kairat09:42
rsjethaniI have merged rele notes patch in to request id patch: https://review.openstack.org/#/c/261288/09:44
*** kzaitsev_mb has joined #openstack-glance09:49
*** haomaiwa_ has quit IRC10:01
*** haomaiwang has joined #openstack-glance10:01
*** TravT has joined #openstack-glance10:11
*** kzaitsev_mb has quit IRC10:15
*** TravT has quit IRC10:16
*** daemontool has quit IRC10:16
*** haomaiwang has quit IRC10:23
*** ishant has quit IRC10:27
*** haomaiwang has joined #openstack-glance10:29
*** achanda has joined #openstack-glance10:33
*** ducttape_ has joined #openstack-glance10:34
*** flwang1 has joined #openstack-glance10:36
*** achanda has quit IRC10:38
openstackgerritBéla Vancsics proposed openstack/glance: Use assertGreater/Less/Equal instead of assertTrue(A * B)  https://review.openstack.org/28473910:44
*** sgotliv has joined #openstack-glance10:49
*** ducttape_ has quit IRC10:57
*** haomaiwang has quit IRC11:01
*** haomaiwang has joined #openstack-glance11:01
*** mingdang1 has quit IRC11:03
*** sgotliv has quit IRC11:08
openstackgerritDarja Shakhray proposed openstack/glance: Adding method "__setitem__"  for class "ImageTarget"  https://review.openstack.org/26689111:13
*** haomaiwang has quit IRC11:14
flaper87flwang: I haven't forgotten. I'm getting more folks to review it oo11:23
flaper87too*11:23
flaper87flwang: especially jokke_ since he wrote the original patch11:24
openstackgerritNiall Bunting proposed openstack/glance: Test tag against schema to check length  https://review.openstack.org/21675211:27
*** kzaitsev_mb has joined #openstack-glance11:32
*** achanda has joined #openstack-glance11:35
*** achanda has quit IRC11:39
*** kzaitsev_mb has quit IRC11:44
*** kzaitsev_mb has joined #openstack-glance11:56
openstackgerritDarja Shakhray proposed openstack/glance: Add transaction layer  https://review.openstack.org/27211811:57
*** smatzek has joined #openstack-glance12:00
*** ihrachys_ is now known as ihrachys12:03
openstackgerritFlavio Percoco proposed openstack/glance_store: Add new config options for HTTPS store  https://review.openstack.org/27005912:04
flaper87kairat: https://review.openstack.org/#/c/270059/12:05
*** krotscheck_dcm is now known as krotscheck12:13
*** TravT has joined #openstack-glance12:13
*** haomaiwang has joined #openstack-glance12:14
*** daemontool has joined #openstack-glance12:14
*** cdelatte has joined #openstack-glance12:18
*** haomaiwang has quit IRC12:19
*** TravT has quit IRC12:19
*** mingdang1 has joined #openstack-glance12:19
*** mfedosin has joined #openstack-glance12:23
openstackgerritMerged openstack/glance_store: Implement get, add and delete for cinder store  https://review.openstack.org/16641412:26
*** proxima has joined #openstack-glance12:29
openstackgerritFei Long Wang proposed openstack/glance: Fix location update  https://review.openstack.org/28078612:41
*** takedakn has joined #openstack-glance12:43
flaper87wow, the cinder driver merged! Cool12:44
kairatwe need to refine it later12:44
kairatto support multi-backend and keystone v312:45
kairatbut this is finally, merged, cool=)12:45
kairat*impove it later12:45
*** julim has joined #openstack-glance12:45
flaper87yup, it's far from perfect12:49
flaper87but we'll hopefully get there12:50
* flaper87 hands a half-full glass of water to kairat :P12:50
*** takedakn has quit IRC12:50
kairatheh12:50
*** abhishekk_ has quit IRC12:52
*** flwang1 has quit IRC12:54
bretonkeystone v3 is not yet supported?13:02
flaper87breton: I believe it is or at least I'm sure some parts of the code do13:08
kairatI know that tempest tests are passed with v313:09
kairatfor glance13:09
kairatBut I certainly see some areas (like project domains) that needs to be considered in glance13:10
*** TravT has joined #openstack-glance13:10
*** ducttape_ has joined #openstack-glance13:13
*** itisha has joined #openstack-glance13:15
*** TravT has quit IRC13:15
*** daemontool has quit IRC13:15
*** daemontool has joined #openstack-glance13:16
*** daemontool has quit IRC13:17
*** daemontool has joined #openstack-glance13:18
*** flaviosr has joined #openstack-glance13:18
*** daemontool has quit IRC13:24
*** rsjethani has quit IRC13:33
*** ducttape_ has quit IRC13:35
openstackgerritMerged openstack/glance_store: test_http_get_redirect is not testing redirects correctly  https://review.openstack.org/28458513:37
openstackgerritMerged openstack/glance_store: Switch VMWare Datastore to use Requests  https://review.openstack.org/16854013:37
*** achanda has joined #openstack-glance13:37
*** haomaiwang has joined #openstack-glance13:38
*** achanda has quit IRC13:42
*** ninag has joined #openstack-glance13:44
kairatflaper87, Would it be possible to review that: https://review.openstack.org/#/c/251851/?13:47
*** edmondsw has joined #openstack-glance13:50
*** dims has joined #openstack-glance13:54
*** daemontool has joined #openstack-glance13:54
*** haomaiwang has quit IRC14:01
*** haomaiwang has joined #openstack-glance14:01
*** TravT has joined #openstack-glance14:12
*** takedakn has joined #openstack-glance14:13
*** takedakn has quit IRC14:14
*** Zaina has left #openstack-glance14:15
*** daemontool has quit IRC14:16
*** daemontool has joined #openstack-glance14:16
*** TravT has quit IRC14:16
*** daemontool_ has joined #openstack-glance14:18
*** jaypipes is now known as sicklypipes14:22
*** daemontool has quit IRC14:22
flaviosrhi all, anyone know if its ok for glance to use that much of memory http://paste.openstack.org/show/488378/ ?14:44
kairatflaviosr, is it liberty?14:47
kairator kilo or master?14:47
*** TravT has joined #openstack-glance14:47
kairatLooks like issue in glance14:48
*** flaviosr_ has joined #openstack-glance14:48
flaviosr_sorry for that14:49
kairatfor what? :)14:49
flaviosr_got disconnected14:50
flaviosr_so, as I was saying14:50
kairatis it liberty?14:50
openstackgerritStuart McLaren proposed openstack/glance: Return 204 rather than 403 when no image data  https://review.openstack.org/25433414:50
flaviosr_it is not from master, its from ubuntu packages14:50
*** mingdang1 has quit IRC14:50
flaviosr_kilo14:50
*** flaviosr has quit IRC14:51
flaviosr_2015.1.214:51
*** ducttape_ has joined #openstack-glance14:56
kairatOh, I was not working on glance in kilo.14:56
kairatDid you execute some specific operations in cloud?14:56
kairatOr glance just "eats" memory14:57
flaviosr_no, it keeps getting that way after some days14:58
flaviosr_like, if i restart glance-api today it is fine, but after about 5 days it get on this situation15:00
flaviosr_consuming about 25% of total memory15:00
*** haomaiwang has quit IRC15:01
*** daemontool_ has quit IRC15:01
*** haomaiwang has joined #openstack-glance15:01
flaviosr_I was thinking about some cache for images, but im not sure15:01
*** vijendar has joined #openstack-glance15:02
flaviosr_I am using rbd as glance backend15:03
kairatI tried to find something similar in our bugs but haven't succeed15:04
*** delattec has joined #openstack-glance15:04
*** daemontool has joined #openstack-glance15:05
kairatPerhaps, you need to create a bug about that15:05
flaviosr_Ok kairat, I will investigate more about that15:06
flaviosr_thanks :)15:06
*** cdelatte has quit IRC15:06
*** sigmavirus24_awa is now known as sigmavirus2415:07
*** burgerk has joined #openstack-glance15:08
openstackgerritFlavio Percoco proposed openstack/glance_store: Add new config options for HTTPS store  https://review.openstack.org/27005915:13
flaper87kairat: ^15:13
kairatyep, waiting for Jenkins15:14
*** kzaitsev_mb has quit IRC15:15
kairatflaper87, what if I got zero review for my patch today15:15
*** achanda has joined #openstack-glance15:24
*** nikhil has joined #openstack-glance15:25
flaper87kairat: you can approve it anyway. The check pipeline will run and the the verification one15:26
flaper87kairat: the latter won't be run if the former fails15:26
*** kzaitsev_mb has joined #openstack-glance15:27
flaper87kairat: kairat if you don't have other reviews, then reviewing blueprints and glance patches would be super cool15:27
*** delatte has joined #openstack-glance15:28
*** delattec has quit IRC15:30
flaper87bunting: hey15:32
flaper87bunting: is Stuart somewhere near you?15:32
buntingyup15:32
flaper87bunting: https://review.openstack.org/#/c/251851/ <- need him to review this15:32
flaper87could you ping him :D15:32
flaper87for me15:32
flaper87pretty please15:32
buntingsure15:32
openstackgerritDarja Shakhray proposed openstack/glance: Add transaction layer  https://review.openstack.org/27211815:33
buntingflaper87: He said he would15:33
kragnizthe stuart-poking responsibilities are handed down the generations15:34
flaper87bunting: AWESOME!15:34
flaper87kragniz: hahahaha, it used to be YOU!15:34
flaper87:D15:34
buntingOur one true job15:35
flaper87bunting: tell him I <3 him and that kairat will get beers for him and that this is TOTALLY not a bribe15:35
flaper87bunting: oh and that he's probably the one that knows that driver better right now. He's kinda screwed15:35
flaper87:P15:35
kairatBeer is not so good in Russia15:36
kairatbut I definitely can promise a bottle of vodka15:37
flaper87kairat: well, I was thinking about Austin15:37
flaper87kairat: Or vodka15:37
flaper87that works15:37
flaper87Since you're at it, bring one for me15:37
flaper87hahahaha15:37
kairatAh, I am not sure that I will be here15:37
flaper87(obviously a joke)15:37
flaper87kairat: wutttttttttt???15:37
flaper87mfedosin: ^ fix that15:37
flaper87now15:37
flaper87>.>15:37
flaper87who wants kairat to attend?15:38
flaper87O/15:38
flaper87o_______________/15:38
mfedosinflaper87: I'm trying :)15:38
kairatHeh, will see =)15:38
*** belmoreira has quit IRC15:43
mfedosinflaper87: we need your help here https://review.openstack.org/#/c/254334/315:45
flaper87mfedosin: will review15:46
flaper87mfedosin: I asked jokke_ to weight in as well15:46
kairatsigmavirus24, so you would recommend to stay it as it is here https://review.openstack.org/#/c/275120/?15:46
mfedosinon short: in Liberty when user wanted to download 'killed' image Glance returned 204, in Mitaka we changed it to 40315:46
kairatone sorting direction for list and another for any requests with filters15:47
mfedosinit's cli only thing15:47
kairatit was rejected by community15:48
mfedosinwhat community?15:48
kairatso I am wondering if we should re-apply the patch15:48
kairatby glance15:48
kairatIf you are talking about that: https://review.openstack.org/#/c/275120/?15:48
kairat=)15:48
mfedosinah, I thought you'd talked about rejecting desc sorting order15:50
kairatAFAIR, bunting proposed a patch to client where we changed default sort dir on client side15:50
*** achanda has quit IRC15:51
sigmavirus24kairat: yes15:51
sigmavirus24kairat: I think the right place to fix this is the client15:52
sigmavirus24other clients probably behave differently too15:52
sigmavirus24by changing the API we're changing those clients implicitly15:52
sigmavirus24unless they're specifying their own sort order15:52
mfedosinwe can say, that default sort dir for client is asc, and always add it in requests15:53
*** mtanino has joined #openstack-glance15:54
mfedosinit's like we did with purge_props in v115:54
kairatok, thanks for consultation15:54
mfedosinin glance the default value it true, but client uses false15:54
*** harshs has joined #openstack-glance15:54
mfedosinsigmavirus24: while you're here...15:54
mfedosinhi, btw!15:54
* sigmavirus24 runs15:54
sigmavirus24hi mfedosin ;)15:55
mfedosinI'm faster ;)15:55
* mfedosin kids15:55
mfedosinhttps://review.openstack.org/#/c/254334/315:55
mfedosinStuart want to revert a patch that forbids download deactivated images for users15:55
mfedosinand his opinion is we should return 204 when user wants to download killed image15:56
mfedosinI think that current status 403 is correct15:56
mfedosinsigmavirus24: what do you think?15:57
sigmavirus24I saw this15:58
sigmavirus24I still have to decide on this15:58
sigmavirus24I mean it's kind of tricky right16:00
sigmavirus24The user can see the image has been deactivated16:00
*** haomaiwang has quit IRC16:01
*** haomaiwang has joined #openstack-glance16:01
flaper87nikhil: ey16:02
flaper87hey, even16:02
flaper87nikhil: could you take a look at this patch? https://review.openstack.org/#/c/248359/16:03
flaper87like the db side of it16:03
*** TravT has quit IRC16:03
mfedosinsigmavirus24: yes, but I don't see any problem with that16:04
mfedosinreturn 403 if it's impossible to download image seems correct to me16:04
sigmavirus24mfedosin: except an image without any uploaded data wouldn't be a 403, right?16:05
flaper87brb16:05
mfedosinsigmavirus24: why not? I don't mind if we return 403 in that case16:06
mfedosinI understand if we have to keep compatibility and follow official document16:07
mfedosinhttp://developer.openstack.org/api-ref-image-v2.html16:07
mfedosinso, I proposed a patch that returns this behavior16:07
*** daemontool has quit IRC16:07
mfedosinhttps://review.openstack.org/#/c/284780/16:08
nikhilflaper87: ack16:10
sigmavirus24mfedosin: if there's no data to return that would semantically be a 20416:12
sigmavirus24That said, I feel like if an administrator has disabled some resource it could either be a 404 or a 40316:13
mfedosinfor me when image is 'queued' glance should return error code, because it's clear that it's impossible to download this image...16:15
mfedosin204 is correct when we created image without data with v116:16
mfedosinsigmavirus24: do you know about this trick?16:16
*** sgotliv has joined #openstack-glance16:17
sigmavirus24mfedosin: So I don't agree. If the image is queued, then there's no image data to return.16:18
sigmavirus24Nothing to return -> 20416:19
mfedosinv1 return 40416:19
sigmavirus24I don't see having nothing to return from a queued image as an error16:19
mfedosinreturns16:19
sigmavirus24mfedosin: v2 was introduced to break the bad decisions of v116:19
sigmavirus24I don't think the behaviour of v1 is a justification for doing something wrong i v216:19
mfedosinsigmavirus24: and add other :D16:19
sigmavirus24*in16:19
mfedosinno-no, it's just fyi16:19
mfedosinso yeah, queued -> 20416:20
mfedosinsaving?16:20
*** dims has quit IRC16:22
sigmavirus24202 I think16:25
sigmavirus24or maybe 10216:26
sigmavirus24I'm not certain to be honest16:26
sigmavirus24102 are informational not really meant to be actual statuses16:27
sigmavirus24202 is typically used during server creation too iirc16:27
sigmavirus24As in "the operation is in progress" accepted16:27
sigmavirus24That's what the poll operation tells you/does16:27
mfedosinsigmavirus24: agree16:29
*** vijendar has quit IRC16:29
mfedosinand when image was deleted/killed -> 410 Gone16:29
mfedosinhttp://tools.ietf.org/html/rfc7231.html#section-6.5.916:30
nikhilflaper87: can you set some fields on https://blueprints.launchpad.net/glance/+spec/in-filtering-operator ? I want to be aware how strict the review needs to be..16:30
sigmavirus24mfedosin: that could arguably be a 404 too16:30
*** rcernin has quit IRC16:31
mfedosinare we able to revert killed images?16:31
sigmavirus24I don't think so, so you're right it should be a 41016:32
sigmavirus24We do keep the image record16:32
sigmavirus24Some sites use a 404 because they lose the record and can't be entirely certain if it ever existed16:32
sigmavirus24I think I disagree with mclaren though16:32
sigmavirus24I think a 403 is better16:32
mfedosinfor killed?16:33
mfedosinsigmavirus24: I just need it too, because I'm working on Glare v1 API...16:34
sigmavirus24no16:34
sigmavirus24for deactivated16:34
sigmavirus24sorry16:34
mfedosinhttps://review.openstack.org/#/c/283136/16:34
mfedosinokay, thank you man :)16:36
mfedosinsorry, have to go home...16:36
mfedosinI'll update my patch later to saving -> 20216:36
*** ihrachys has quit IRC16:39
*** daemontool has joined #openstack-glance16:40
*** mfedosin has quit IRC16:41
*** harshs has quit IRC16:43
*** vijendar has joined #openstack-glance16:44
*** SamYaple has joined #openstack-glance16:47
nikhilflaper87: reviewed https://review.openstack.org/#/c/248359/16:48
SamYapleHello. I am trying to track down the security impact of running show_image_direct_url=True16:48
nikhilI haven't +W it16:49
SamYapleI know there was a vulnerability on it a while back, but is this still an insecure option?16:49
SamYapleive heard conflicting opinions16:49
nikhilSamYaple: then you should have this conversation in private with the Openstack VMT and(or) glance-core-sec team.16:49
sigmavirus24nikhil: SamYaple doesn't have a vulnerability to report16:49
sigmavirus24He's asking about the security implications of setting that16:49
SamYaplecorrect16:50
SamYapleAFAIK any vulnerability is out in the wild and/or fixed already16:50
nikhilhmm16:50
nikhillemme check16:50
*** vijendar1 has joined #openstack-glance16:53
*** vijendar has quit IRC16:54
*** vijendar has joined #openstack-glance16:54
nikhilsigmavirus24: which feature did the status codes conversation you guys were having a few mins back, relate to ?16:54
*** vijendar1 has quit IRC16:58
*** haomaiwang has quit IRC17:01
*** haomaiwang has joined #openstack-glance17:01
*** lakshmiS has joined #openstack-glance17:01
flaper87nikhil: thanks for your review17:02
nikhilyou're welcome17:04
flaper87Hey folks, just wanted to say thanks for all those amazing reviews. It's been awesome to see the effort that have been done in the last couple of days.17:05
flaper87nikhil: kairat mfedosin jokke_ mclaren bunting rosmaita ^17:05
flaper87sigmavirus24:17:05
flaper87^17:05
nikhilsigmavirus24: nvm, I was able to dig into the initial part of the conversations.. a bit of search given we'd a number of them quite recently :)17:06
nikhilflaper87: ++ happy to help. we're all up for awesome release!17:06
*** vilobhmm11 has joined #openstack-glance17:07
*** groen692 has quit IRC17:07
*** dims has joined #openstack-glance17:09
*** achanda has joined #openstack-glance17:10
*** dims has quit IRC17:10
*** vijendar1 has joined #openstack-glance17:11
*** melwitt_ has joined #openstack-glance17:12
*** MattMan_ has joined #openstack-glance17:14
*** diegows_ has joined #openstack-glance17:16
*** hemanthm_ has joined #openstack-glance17:16
*** tonyb_ has joined #openstack-glance17:16
*** kfox1111_ has joined #openstack-glance17:16
sigmavirus24sorry nikhil was afk17:16
nikhilsigmavirus24: np17:17
*** vijendar has quit IRC17:20
*** edmondsw has quit IRC17:20
*** MattMan has quit IRC17:20
*** zul has quit IRC17:20
*** ekarlso- has quit IRC17:20
*** krotscheck has quit IRC17:20
*** tonyb has quit IRC17:20
*** strictlyb has quit IRC17:20
*** timburke has quit IRC17:20
*** bapalm has quit IRC17:20
*** diegows has quit IRC17:20
*** melwitt has quit IRC17:20
*** _stowa has quit IRC17:20
*** hemanthm has quit IRC17:20
*** kfox1111 has quit IRC17:20
*** krotscheck has joined #openstack-glance17:20
*** bapalm has joined #openstack-glance17:21
*** strictlyb has joined #openstack-glance17:21
flaper87sigmavirus24: you'll never be forgiven17:21
flaper87sigmavirus24: NEVER!17:21
sigmavirus24flaper87: typical17:21
sigmavirus24I work on requests and everyone blames me for the .json -> .json() switch in 1.x17:21
*** dims has joined #openstack-glance17:22
sigmavirus24I didn't even do it17:22
sigmavirus24But as soon as I say I work on requests that's the immediate response "WHY DID YOU DO THAT?!"17:22
sigmavirus24I'm used to being hated on ;)17:22
*** timburke has joined #openstack-glance17:23
*** ekarlso- has joined #openstack-glance17:27
*** edmondsw has joined #openstack-glance17:27
*** zul has joined #openstack-glance17:27
*** _stowa_ has joined #openstack-glance17:28
*** _stowa_ is now known as _stowa17:35
*** vilobhmm11 has quit IRC17:38
flaper87So, folks! We'll release glance_store on monday17:42
flaper87I realize weekend is right there but, this is the last chance to get features in for glance_store17:43
*** jistr has quit IRC17:49
*** vijendar1 has quit IRC17:51
*** vilobhmm11 has joined #openstack-glance17:59
*** haomaiwang has quit IRC18:01
*** haomaiwang has joined #openstack-glance18:01
*** AJaeger has joined #openstack-glance18:02
*** vilobhmm11 has quit IRC18:02
*** sgotliv has quit IRC18:02
AJaegerflaper87: I had to rebase and update the bandit to pep8 merge. could you put it again on your review queue, please? https://review.openstack.org/#/c/282885/18:02
sigmavirus24features? Why features when we can fix bugs?18:02
*** vijendar has joined #openstack-glance18:03
AJaegerflaper87: your review queue is short ;) Thanks to you and Ian (sorry, don't know your nick)18:04
sigmavirus24AJaeger: I'm Ian ;)18:07
* sigmavirus24 is also a bandit core18:07
*** pt_15 has joined #openstack-glance18:08
AJaegersigmavirus24: We talked several times but forgot the real name ;/ Sorry18:08
sigmavirus24AJaeger: not a problem :)18:08
sigmavirus24Most people don't actually know my real name18:08
AJaegersigmavirus24: hope as bandit core you're happy with how I did it - and look at my bug report ;)18:08
sigmavirus24my brain has already context-switched off of this18:09
* sigmavirus24 double chekcs18:09
*** dims is now known as dimsum__18:09
*** kzaitsev_mb has quit IRC18:09
flaper87AJaeger: lol, just read IRC18:10
flaper87:D18:10
*** RichardRaseley has joined #openstack-glance18:11
AJaegersigmavirus24: https://bugs.launchpad.net/bandit/+bug/155016118:11
openstackLaunchpad bug 1550161 in Bandit "advice on defusedxml but that is not in global-requiriments" [Undecided,New]18:11
*** harshs has joined #openstack-glance18:11
*** dshakhray has quit IRC18:11
AJaegerflaper87: perfect timing?18:11
sigmavirus24AJaeger: commented18:12
AJaegersigmavirus24: thanks, let's continue there.18:14
openstackgerritMerged openstack/glance: Added support new v2 API image filters  https://review.openstack.org/24835918:20
*** vilobhmm11 has joined #openstack-glance18:23
*** vilobhmm11 has quit IRC18:23
*** vilobhmm11 has joined #openstack-glance18:23
*** bjornar__ has joined #openstack-glance18:30
*** ducttape_ has quit IRC18:34
*** pushkaru has joined #openstack-glance18:34
openstackgerritMerged openstack/glance_store: Add new config options for HTTPS store  https://review.openstack.org/27005918:34
*** kairat_ has joined #openstack-glance18:36
*** vilobhmm11 has quit IRC18:37
kairat_flaper87, nikhil could you please take a look on this too: https://review.openstack.org/#/c/251851/18:40
*** vilobhmm11 has joined #openstack-glance18:41
flaper87kairat_: I'm half-way through18:44
flaper87halfway*18:44
flaper87I honestly don't think I know that driver well enough18:45
kairat_ah, ok18:45
flaper87but I'll do my best18:45
*** haomaiwang has quit IRC18:46
*** haomaiwang has joined #openstack-glance18:48
*** achanda has quit IRC18:51
kairat_bunting, I know mclaren is busy so I hope he will be able to spent some time on my patches18:54
*** AJaeger has left #openstack-glance18:55
*** achanda has joined #openstack-glance18:55
*** agireud has quit IRC18:55
*** agireud has joined #openstack-glance18:57
nikhilkairat_: ack, in about 20 mins. that's on my queue already :)18:58
kairat_nikhil, thanks!18:58
*** vilobhmm11 has quit IRC19:00
*** haomaiwang has quit IRC19:01
*** 92AAAEL3R has joined #openstack-glance19:01
buntingkairat_: probably have to be monday now unfortuantly19:01
*** vilobhmm11 has joined #openstack-glance19:01
kairat_bunting, Oh, ok19:02
bunting7 here in Ireland19:02
buntingkairat_: at least you get to keep your beer ;)19:03
*** RichardRaseley has quit IRC19:05
*** delattec has joined #openstack-glance19:06
*** delatte has quit IRC19:08
*** delatte has joined #openstack-glance19:09
*** delattec has quit IRC19:11
*** melwitt_ is now known as melwitt19:14
sabariflaper87: thanks for updating the http config patch :)19:15
*** dimsum__ has quit IRC19:16
*** vijendar has quit IRC19:19
*** ducttape_ has joined #openstack-glance19:23
*** vijendar has joined #openstack-glance19:24
*** porunov has joined #openstack-glance19:38
*** vilobhmm11 has quit IRC19:47
*** vilobhmm111 has joined #openstack-glance19:48
*** erhudy has joined #openstack-glance19:48
*** sgotliv has joined #openstack-glance19:59
*** 92AAAEL3R has quit IRC20:01
*** haomaiwang has joined #openstack-glance20:01
*** itisha has quit IRC20:09
openstackgerritMerged openstack/glance: Move bandit into pep8  https://review.openstack.org/28288520:09
*** alejandrito has joined #openstack-glance20:20
*** vijendar has quit IRC20:29
*** dane-fichter has joined #openstack-glance20:30
dane-fichterhemanthm_: I see you're having some more issues with the verifier20:30
dane-fichterhemanthm_ : any questions I can help with20:31
*** pushkaru has quit IRC20:33
*** sgotliv has quit IRC20:37
*** achanda has quit IRC20:45
hemanthm_dane-fichter: Hey. Like we discussed yday, I pushed up another patchset that keeps a copy of the verifier, in case if the bufferedreader needs to reset the contents20:46
*** hemanthm_ is now known as hemanthm20:46
dane-fichterhemanthm: hmm perhaps I don't fully understand this comment from tim burke then20:46
dane-fichterwhat's the issue there?20:47
hemanthmdane-fichter: if we do end up resetting, we'd have created a new verifier object and the caller (glance) wouldn't necessarily know that the object has changed20:47
dane-fichterooh yeah that'd be bad20:47
hemanthmit would still be pointing to the earlier verifier object that it initially passed20:47
hemanthmyeah20:47
*** dims has joined #openstack-glance20:48
hemanthmtoo bad there's no reset operation on the verifier :)20:48
dane-fichterha! if you wanna hack that on, go right ahead20:49
dane-fichterthe joy of open source20:49
dane-fichter(It wouldn't be that bad, you'd just have to refresh that hash context)20:50
*** vijendar has joined #openstack-glance20:50
hemanthmdane-fichter: I see. I'll try looking into that. Do you see any other solution for the short-term?20:51
* hemanthm looks for magical ways of resetting references 20:52
dane-fichterhemanthm: that way lies madness my friend20:53
hemanthmyou bet!20:54
dane-fichterI think a "nice" way of doing it would be to add a method to signature_utils that can "refresh" a verifier20:54
*** annasort has quit IRC20:54
dane-fichterThe nicest way to do it would be to hack on pyca/cryptography directly and get them to do a release20:54
dane-fichterbut it's understandable if you don't have time for that20:55
dane-fichterI will say that they are very responsive and accomodating though20:55
*** fesp has joined #openstack-glance20:58
*** vijendar has quit IRC20:59
*** haomaiwang has quit IRC21:01
hemanthmdane-fichter: ok, let me look into those options21:01
hemanthmthanks for the help! :)21:01
*** haomaiwang has joined #openstack-glance21:01
dane-fichterno problemo. they have an IRC channel as well and are very responsive on it21:01
hemanthm#cryptography-dev ?21:01
dane-fichteryes21:02
hemanthmok, I shall get in touch with them.21:02
dane-fichterhaving a reset() or refresh() method for that AsymmetricVerificationContext object would be the cleanest solution imo21:03
dane-fichteranyhow, good luck :) let me know if you have any further questions21:04
*** smatzek has quit IRC21:06
hemanthmdane-fichter: +121:07
*** vijendar has joined #openstack-glance21:11
*** kairat_ has quit IRC21:11
*** dane-fichter has quit IRC21:12
*** dshakhray has joined #openstack-glance21:15
*** pt_15 has quit IRC21:15
*** delattec has joined #openstack-glance21:15
*** alejandrito has quit IRC21:16
*** delatte has quit IRC21:17
*** delattec has quit IRC21:20
*** delattec has joined #openstack-glance21:22
openstackgerritKenneth Burger proposed openstack/glance: remove castellan from glance requirements  https://review.openstack.org/28494121:29
openstackgerritKenneth Burger proposed openstack/glance: remove castellan from glance requirements  https://review.openstack.org/28494121:32
*** ninag has quit IRC21:36
*** fesp has quit IRC21:37
*** fesp has joined #openstack-glance21:39
*** nikhil has quit IRC21:39
openstackgerritOpenStack Proposal Bot proposed openstack/glance: Updated from global requirements  https://review.openstack.org/28555221:41
*** agireud has quit IRC21:41
*** jamielennox is now known as jamielennox|away21:43
*** agireud has joined #openstack-glance21:43
*** vijendar has quit IRC21:43
*** porunov has quit IRC21:45
*** pushkaru has joined #openstack-glance21:48
*** dshakhray has quit IRC21:51
*** nikhil has joined #openstack-glance21:57
*** haomaiwang has quit IRC22:01
*** haomaiwang has joined #openstack-glance22:01
hemanthm21:57:58 < reaperhulk> hemanthm: for now the answer is "no reset" but similar functionality will likely appear with the alternate signing methods we're considering22:04
hemanthm21:58:07 < reaperhulk> that will probably take the form of "you can replace the hash context"22:04
hemanthmah, dane left22:04
hemanthmnevermind22:04
*** boden has joined #openstack-glance22:05
nikhilflaper87: when you get a chance, can you add priority reviews / dashboard link to the agenda under spotlight links https://etherpad.openstack.org/p/glance-team-meeting-agenda ?  I noticed that glance doesn't have it while some other prjs do.22:20
*** smatzek has joined #openstack-glance22:20
*** smatzek has quit IRC22:21
*** proxima has quit IRC22:39
*** burgerk has quit IRC22:41
*** marcusvrn_ has quit IRC22:47
*** boden has quit IRC22:53
fespnikhil: sure, I hadn't done that as I was hoping we would do that using the dashboard. I guess an etherpad would be good too... I'll do that soon22:59
fespDefinitely before monday22:59
*** fesp has quit IRC22:59
*** haomaiwang has quit IRC23:01
openstackgerritSrinivas Sakhamuri proposed openstack/glance_store: Make the image uploads atomic  https://review.openstack.org/24208423:01
*** haomaiwa_ has joined #openstack-glance23:01
nikhilflaper87: sounds good. I was thinking of any related review links to the agenda etherpad under spotlight.23:02
openstackgerritSrinivas Sakhamuri proposed openstack/glance_store: Make the image uploads atomic  https://review.openstack.org/24208423:07
*** dims has quit IRC23:07
openstackgerritMatthew Edmonds proposed openstack/glance: make old signature dependencies optional  https://review.openstack.org/28494123:07
*** sigmavirus24 is now known as sigmavirus24_awa23:08
*** ducttape_ has quit IRC23:10
*** daemontool_ has joined #openstack-glance23:10
*** daemontool has quit IRC23:13
openstackgerritMatthew Edmonds proposed openstack/glance: make signature dependencies optional  https://review.openstack.org/28494123:21
*** pushkaru has quit IRC23:21
*** dims has joined #openstack-glance23:34
*** edmondsw has quit IRC23:39
*** erhudy has quit IRC23:40

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!