*** haomaiwa_ has joined #openstack-glance | 00:01 | |
*** chlong_ has quit IRC | 00:03 | |
*** ayoung has quit IRC | 00:04 | |
*** haomaiwa_ has quit IRC | 00:09 | |
*** dramakri has quit IRC | 00:22 | |
*** kzaitsev_mb has quit IRC | 00:29 | |
*** daemontool has quit IRC | 00:47 | |
*** ayoung has joined #openstack-glance | 00:52 | |
*** RichardRaseley has quit IRC | 00:57 | |
*** vilobhmm11 has quit IRC | 00:59 | |
*** haomaiwa_ has joined #openstack-glance | 01:06 | |
*** ducttape_ has joined #openstack-glance | 01:08 | |
*** ninag has quit IRC | 01:09 | |
*** vilobhmm11 has joined #openstack-glance | 01:10 | |
flwang | flaper87: pls help review the location update patch https://review.openstack.org/280786 | 01:10 |
---|---|---|
flwang | it's breaking the function, we need to get it in M | 01:10 |
openstackgerrit | Merged openstack/glance: remove redundant "#!/usr/bin/env python" header https://review.openstack.org/283610 | 01:12 |
openstackgerrit | Fei Long Wang proposed openstack/glance: Fix location update https://review.openstack.org/280786 | 01:12 |
*** haomaiwa_ has quit IRC | 01:13 | |
*** ducttape_ has quit IRC | 01:15 | |
*** mtanino has quit IRC | 01:21 | |
*** haomaiwang has joined #openstack-glance | 01:25 | |
*** haomaiwang has quit IRC | 01:33 | |
*** dims has quit IRC | 01:49 | |
*** chlong_ has joined #openstack-glance | 01:49 | |
*** annasort has joined #openstack-glance | 01:55 | |
*** lakshmiS has quit IRC | 02:08 | |
*** mingdang1 has joined #openstack-glance | 02:16 | |
*** haomaiwang has joined #openstack-glance | 02:21 | |
*** ducttape_ has joined #openstack-glance | 02:37 | |
*** ducttape_ has quit IRC | 02:40 | |
*** vilobhmm11 has quit IRC | 02:40 | |
*** vilobhmm11 has joined #openstack-glance | 02:42 | |
*** ducttape_ has joined #openstack-glance | 02:44 | |
*** ducttape_ has quit IRC | 02:46 | |
*** ducttape_ has joined #openstack-glance | 02:53 | |
*** delatte has quit IRC | 02:56 | |
*** vilobhmm11 has quit IRC | 02:56 | |
*** haomaiwang has quit IRC | 03:01 | |
*** haomaiwang has joined #openstack-glance | 03:01 | |
*** harshs has quit IRC | 03:02 | |
*** pushkaru has quit IRC | 03:05 | |
*** dims has joined #openstack-glance | 03:10 | |
openstackgerrit | Tomoki Sekiyama proposed openstack/glance_store: Implement get, add and delete for cinder store https://review.openstack.org/166414 | 03:23 |
*** boris-42 has quit IRC | 03:24 | |
*** links has joined #openstack-glance | 03:26 | |
*** ducttape_ has quit IRC | 03:46 | |
*** mingdang1 has quit IRC | 03:50 | |
*** flwang1 has quit IRC | 03:54 | |
*** azbiswas has joined #openstack-glance | 03:55 | |
*** haomaiwang has quit IRC | 04:01 | |
*** haomaiwang has joined #openstack-glance | 04:01 | |
*** azbiswas has quit IRC | 04:12 | |
*** vilobhmm11 has joined #openstack-glance | 04:25 | |
*** vilobhmm11 has quit IRC | 04:39 | |
*** vilobhmm11 has joined #openstack-glance | 04:39 | |
openstackgerrit | Erno Kuvaja proposed openstack/glance-specs: Initial lite-specs.rst and per deliverable folders https://review.openstack.org/282516 | 04:52 |
*** haomaiwang has quit IRC | 05:01 | |
*** haomaiwang has joined #openstack-glance | 05:01 | |
*** dshakhray has quit IRC | 05:04 | |
*** ducttape_ has joined #openstack-glance | 05:05 | |
*** rsjethani has joined #openstack-glance | 05:09 | |
*** rsjethani has quit IRC | 05:16 | |
*** ducttape_ has quit IRC | 05:37 | |
*** mingdang1 has joined #openstack-glance | 05:38 | |
*** vilobhmm11 has quit IRC | 05:39 | |
*** mingdang1 has quit IRC | 05:46 | |
*** haomaiwang has quit IRC | 06:01 | |
*** haomaiwang has joined #openstack-glance | 06:01 | |
*** mingdang1 has joined #openstack-glance | 06:01 | |
openstackgerrit | Merged openstack/glance: Support importing OVA/OVF package to Glance https://review.openstack.org/214810 | 06:07 |
*** vilobhmm11 has joined #openstack-glance | 06:09 | |
openstackgerrit | Merged openstack/glance_store: Updated from global requirements https://review.openstack.org/284429 | 06:09 |
*** sgotliv has joined #openstack-glance | 06:14 | |
*** abhishekk_ has joined #openstack-glance | 06:23 | |
*** links has quit IRC | 06:26 | |
*** sgotliv has quit IRC | 06:33 | |
*** sgotliv has joined #openstack-glance | 06:33 | |
*** dims has quit IRC | 06:37 | |
*** groen692 has joined #openstack-glance | 06:39 | |
*** groen692 has quit IRC | 06:43 | |
*** groen692 has joined #openstack-glance | 06:46 | |
*** haomaiwang has quit IRC | 06:52 | |
*** haomaiwang has joined #openstack-glance | 06:53 | |
*** haomaiwang has quit IRC | 07:01 | |
*** haomaiwang has joined #openstack-glance | 07:01 | |
*** rcernin has joined #openstack-glance | 07:05 | |
openstackgerrit | Andreas Jaeger proposed openstack/glance: Move bandit into pep8 https://review.openstack.org/282885 | 07:07 |
*** sgotliv has quit IRC | 07:10 | |
openstackgerrit | Andreas Jaeger proposed openstack/glance: Move bandit into pep8 https://review.openstack.org/282885 | 07:11 |
openstackgerrit | Andreas Jaeger proposed openstack/glance: Move bandit into pep8 https://review.openstack.org/282885 | 07:13 |
openstackgerrit | Kairat Kushaev proposed openstack/glance_store: Implement re-authentication for swift driver https://review.openstack.org/251851 | 07:19 |
openstackgerrit | Kairat Kushaev proposed openstack/glance_store: Implement swift store connection manager https://review.openstack.org/251850 | 07:19 |
*** chlong_ has quit IRC | 07:26 | |
*** daemontool has joined #openstack-glance | 07:31 | |
*** ihrachys has joined #openstack-glance | 07:39 | |
openstackgerrit | Merged openstack/glance: Updated from global requirements https://review.openstack.org/285021 | 07:41 |
*** haomaiwang has quit IRC | 08:01 | |
*** haomaiwang has joined #openstack-glance | 08:01 | |
*** belmoreira has joined #openstack-glance | 08:08 | |
*** achanda has quit IRC | 08:29 | |
*** achanda has joined #openstack-glance | 08:33 | |
*** daemontool has quit IRC | 08:35 | |
*** daemontool has joined #openstack-glance | 08:36 | |
openstackgerrit | Tomoki Sekiyama proposed openstack/glance_store: Implement get, add and delete for cinder store https://review.openstack.org/166414 | 08:43 |
*** TravT has joined #openstack-glance | 08:49 | |
*** vilobhmm11 has quit IRC | 08:54 | |
*** haomaiwang has quit IRC | 09:01 | |
*** haomaiwa_ has joined #openstack-glance | 09:01 | |
*** achanda has quit IRC | 09:03 | |
*** nikhil has quit IRC | 09:04 | |
*** TravT has quit IRC | 09:05 | |
kairat | sigmavirus24_awa, could you please look at that: https://review.openstack.org/#/c/275120/? There is a question raised some time ago, so it would be good to clarify it. | 09:07 |
*** TravT has joined #openstack-glance | 09:07 | |
*** TravT has quit IRC | 09:10 | |
*** rcernin has quit IRC | 09:14 | |
*** jistr has joined #openstack-glance | 09:27 | |
*** rcernin has joined #openstack-glance | 09:28 | |
*** ihrachys_ has joined #openstack-glance | 09:32 | |
*** dshakhray has joined #openstack-glance | 09:33 | |
*** ishant has joined #openstack-glance | 09:35 | |
*** ihrachys has quit IRC | 09:35 | |
*** rsjethani has joined #openstack-glance | 09:42 | |
rsjethani | Hi Kairat | 09:42 |
rsjethani | I have merged rele notes patch in to request id patch: https://review.openstack.org/#/c/261288/ | 09:44 |
*** kzaitsev_mb has joined #openstack-glance | 09:49 | |
*** haomaiwa_ has quit IRC | 10:01 | |
*** haomaiwang has joined #openstack-glance | 10:01 | |
*** TravT has joined #openstack-glance | 10:11 | |
*** kzaitsev_mb has quit IRC | 10:15 | |
*** TravT has quit IRC | 10:16 | |
*** daemontool has quit IRC | 10:16 | |
*** haomaiwang has quit IRC | 10:23 | |
*** ishant has quit IRC | 10:27 | |
*** haomaiwang has joined #openstack-glance | 10:29 | |
*** achanda has joined #openstack-glance | 10:33 | |
*** ducttape_ has joined #openstack-glance | 10:34 | |
*** flwang1 has joined #openstack-glance | 10:36 | |
*** achanda has quit IRC | 10:38 | |
openstackgerrit | Béla Vancsics proposed openstack/glance: Use assertGreater/Less/Equal instead of assertTrue(A * B) https://review.openstack.org/284739 | 10:44 |
*** sgotliv has joined #openstack-glance | 10:49 | |
*** ducttape_ has quit IRC | 10:57 | |
*** haomaiwang has quit IRC | 11:01 | |
*** haomaiwang has joined #openstack-glance | 11:01 | |
*** mingdang1 has quit IRC | 11:03 | |
*** sgotliv has quit IRC | 11:08 | |
openstackgerrit | Darja Shakhray proposed openstack/glance: Adding method "__setitem__" for class "ImageTarget" https://review.openstack.org/266891 | 11:13 |
*** haomaiwang has quit IRC | 11:14 | |
flaper87 | flwang: I haven't forgotten. I'm getting more folks to review it oo | 11:23 |
flaper87 | too* | 11:23 |
flaper87 | flwang: especially jokke_ since he wrote the original patch | 11:24 |
openstackgerrit | Niall Bunting proposed openstack/glance: Test tag against schema to check length https://review.openstack.org/216752 | 11:27 |
*** kzaitsev_mb has joined #openstack-glance | 11:32 | |
*** achanda has joined #openstack-glance | 11:35 | |
*** achanda has quit IRC | 11:39 | |
*** kzaitsev_mb has quit IRC | 11:44 | |
*** kzaitsev_mb has joined #openstack-glance | 11:56 | |
openstackgerrit | Darja Shakhray proposed openstack/glance: Add transaction layer https://review.openstack.org/272118 | 11:57 |
*** smatzek has joined #openstack-glance | 12:00 | |
*** ihrachys_ is now known as ihrachys | 12:03 | |
openstackgerrit | Flavio Percoco proposed openstack/glance_store: Add new config options for HTTPS store https://review.openstack.org/270059 | 12:04 |
flaper87 | kairat: https://review.openstack.org/#/c/270059/ | 12:05 |
*** krotscheck_dcm is now known as krotscheck | 12:13 | |
*** TravT has joined #openstack-glance | 12:13 | |
*** haomaiwang has joined #openstack-glance | 12:14 | |
*** daemontool has joined #openstack-glance | 12:14 | |
*** cdelatte has joined #openstack-glance | 12:18 | |
*** haomaiwang has quit IRC | 12:19 | |
*** TravT has quit IRC | 12:19 | |
*** mingdang1 has joined #openstack-glance | 12:19 | |
*** mfedosin has joined #openstack-glance | 12:23 | |
openstackgerrit | Merged openstack/glance_store: Implement get, add and delete for cinder store https://review.openstack.org/166414 | 12:26 |
*** proxima has joined #openstack-glance | 12:29 | |
openstackgerrit | Fei Long Wang proposed openstack/glance: Fix location update https://review.openstack.org/280786 | 12:41 |
*** takedakn has joined #openstack-glance | 12:43 | |
flaper87 | wow, the cinder driver merged! Cool | 12:44 |
kairat | we need to refine it later | 12:44 |
kairat | to support multi-backend and keystone v3 | 12:45 |
kairat | but this is finally, merged, cool=) | 12:45 |
kairat | *impove it later | 12:45 |
*** julim has joined #openstack-glance | 12:45 | |
flaper87 | yup, it's far from perfect | 12:49 |
flaper87 | but we'll hopefully get there | 12:50 |
* flaper87 hands a half-full glass of water to kairat :P | 12:50 | |
*** takedakn has quit IRC | 12:50 | |
kairat | heh | 12:50 |
*** abhishekk_ has quit IRC | 12:52 | |
*** flwang1 has quit IRC | 12:54 | |
breton | keystone v3 is not yet supported? | 13:02 |
flaper87 | breton: I believe it is or at least I'm sure some parts of the code do | 13:08 |
kairat | I know that tempest tests are passed with v3 | 13:09 |
kairat | for glance | 13:09 |
kairat | But I certainly see some areas (like project domains) that needs to be considered in glance | 13:10 |
*** TravT has joined #openstack-glance | 13:10 | |
*** ducttape_ has joined #openstack-glance | 13:13 | |
*** itisha has joined #openstack-glance | 13:15 | |
*** TravT has quit IRC | 13:15 | |
*** daemontool has quit IRC | 13:15 | |
*** daemontool has joined #openstack-glance | 13:16 | |
*** daemontool has quit IRC | 13:17 | |
*** daemontool has joined #openstack-glance | 13:18 | |
*** flaviosr has joined #openstack-glance | 13:18 | |
*** daemontool has quit IRC | 13:24 | |
*** rsjethani has quit IRC | 13:33 | |
*** ducttape_ has quit IRC | 13:35 | |
openstackgerrit | Merged openstack/glance_store: test_http_get_redirect is not testing redirects correctly https://review.openstack.org/284585 | 13:37 |
openstackgerrit | Merged openstack/glance_store: Switch VMWare Datastore to use Requests https://review.openstack.org/168540 | 13:37 |
*** achanda has joined #openstack-glance | 13:37 | |
*** haomaiwang has joined #openstack-glance | 13:38 | |
*** achanda has quit IRC | 13:42 | |
*** ninag has joined #openstack-glance | 13:44 | |
kairat | flaper87, Would it be possible to review that: https://review.openstack.org/#/c/251851/? | 13:47 |
*** edmondsw has joined #openstack-glance | 13:50 | |
*** dims has joined #openstack-glance | 13:54 | |
*** daemontool has joined #openstack-glance | 13:54 | |
*** haomaiwang has quit IRC | 14:01 | |
*** haomaiwang has joined #openstack-glance | 14:01 | |
*** TravT has joined #openstack-glance | 14:12 | |
*** takedakn has joined #openstack-glance | 14:13 | |
*** takedakn has quit IRC | 14:14 | |
*** Zaina has left #openstack-glance | 14:15 | |
*** daemontool has quit IRC | 14:16 | |
*** daemontool has joined #openstack-glance | 14:16 | |
*** TravT has quit IRC | 14:16 | |
*** daemontool_ has joined #openstack-glance | 14:18 | |
*** jaypipes is now known as sicklypipes | 14:22 | |
*** daemontool has quit IRC | 14:22 | |
flaviosr | hi all, anyone know if its ok for glance to use that much of memory http://paste.openstack.org/show/488378/ ? | 14:44 |
kairat | flaviosr, is it liberty? | 14:47 |
kairat | or kilo or master? | 14:47 |
*** TravT has joined #openstack-glance | 14:47 | |
kairat | Looks like issue in glance | 14:48 |
*** flaviosr_ has joined #openstack-glance | 14:48 | |
flaviosr_ | sorry for that | 14:49 |
kairat | for what? :) | 14:49 |
flaviosr_ | got disconnected | 14:50 |
flaviosr_ | so, as I was saying | 14:50 |
kairat | is it liberty? | 14:50 |
openstackgerrit | Stuart McLaren proposed openstack/glance: Return 204 rather than 403 when no image data https://review.openstack.org/254334 | 14:50 |
flaviosr_ | it is not from master, its from ubuntu packages | 14:50 |
*** mingdang1 has quit IRC | 14:50 | |
flaviosr_ | kilo | 14:50 |
*** flaviosr has quit IRC | 14:51 | |
flaviosr_ | 2015.1.2 | 14:51 |
*** ducttape_ has joined #openstack-glance | 14:56 | |
kairat | Oh, I was not working on glance in kilo. | 14:56 |
kairat | Did you execute some specific operations in cloud? | 14:56 |
kairat | Or glance just "eats" memory | 14:57 |
flaviosr_ | no, it keeps getting that way after some days | 14:58 |
flaviosr_ | like, if i restart glance-api today it is fine, but after about 5 days it get on this situation | 15:00 |
flaviosr_ | consuming about 25% of total memory | 15:00 |
*** haomaiwang has quit IRC | 15:01 | |
*** daemontool_ has quit IRC | 15:01 | |
*** haomaiwang has joined #openstack-glance | 15:01 | |
flaviosr_ | I was thinking about some cache for images, but im not sure | 15:01 |
*** vijendar has joined #openstack-glance | 15:02 | |
flaviosr_ | I am using rbd as glance backend | 15:03 |
kairat | I tried to find something similar in our bugs but haven't succeed | 15:04 |
*** delattec has joined #openstack-glance | 15:04 | |
*** daemontool has joined #openstack-glance | 15:05 | |
kairat | Perhaps, you need to create a bug about that | 15:05 |
flaviosr_ | Ok kairat, I will investigate more about that | 15:06 |
flaviosr_ | thanks :) | 15:06 |
*** cdelatte has quit IRC | 15:06 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 15:07 | |
*** burgerk has joined #openstack-glance | 15:08 | |
openstackgerrit | Flavio Percoco proposed openstack/glance_store: Add new config options for HTTPS store https://review.openstack.org/270059 | 15:13 |
flaper87 | kairat: ^ | 15:13 |
kairat | yep, waiting for Jenkins | 15:14 |
*** kzaitsev_mb has quit IRC | 15:15 | |
kairat | flaper87, what if I got zero review for my patch today | 15:15 |
*** achanda has joined #openstack-glance | 15:24 | |
*** nikhil has joined #openstack-glance | 15:25 | |
flaper87 | kairat: you can approve it anyway. The check pipeline will run and the the verification one | 15:26 |
flaper87 | kairat: the latter won't be run if the former fails | 15:26 |
*** kzaitsev_mb has joined #openstack-glance | 15:27 | |
flaper87 | kairat: kairat if you don't have other reviews, then reviewing blueprints and glance patches would be super cool | 15:27 |
*** delatte has joined #openstack-glance | 15:28 | |
*** delattec has quit IRC | 15:30 | |
flaper87 | bunting: hey | 15:32 |
flaper87 | bunting: is Stuart somewhere near you? | 15:32 |
bunting | yup | 15:32 |
flaper87 | bunting: https://review.openstack.org/#/c/251851/ <- need him to review this | 15:32 |
flaper87 | could you ping him :D | 15:32 |
flaper87 | for me | 15:32 |
flaper87 | pretty please | 15:32 |
bunting | sure | 15:32 |
openstackgerrit | Darja Shakhray proposed openstack/glance: Add transaction layer https://review.openstack.org/272118 | 15:33 |
bunting | flaper87: He said he would | 15:33 |
kragniz | the stuart-poking responsibilities are handed down the generations | 15:34 |
flaper87 | bunting: AWESOME! | 15:34 |
flaper87 | kragniz: hahahaha, it used to be YOU! | 15:34 |
flaper87 | :D | 15:34 |
bunting | Our one true job | 15:35 |
flaper87 | bunting: tell him I <3 him and that kairat will get beers for him and that this is TOTALLY not a bribe | 15:35 |
flaper87 | bunting: oh and that he's probably the one that knows that driver better right now. He's kinda screwed | 15:35 |
flaper87 | :P | 15:35 |
kairat | Beer is not so good in Russia | 15:36 |
kairat | but I definitely can promise a bottle of vodka | 15:37 |
flaper87 | kairat: well, I was thinking about Austin | 15:37 |
flaper87 | kairat: Or vodka | 15:37 |
flaper87 | that works | 15:37 |
flaper87 | Since you're at it, bring one for me | 15:37 |
flaper87 | hahahaha | 15:37 |
kairat | Ah, I am not sure that I will be here | 15:37 |
flaper87 | (obviously a joke) | 15:37 |
flaper87 | kairat: wutttttttttt??? | 15:37 |
flaper87 | mfedosin: ^ fix that | 15:37 |
flaper87 | now | 15:37 |
flaper87 | >.> | 15:37 |
flaper87 | who wants kairat to attend? | 15:38 |
flaper87 | O/ | 15:38 |
flaper87 | o_______________/ | 15:38 |
mfedosin | flaper87: I'm trying :) | 15:38 |
kairat | Heh, will see =) | 15:38 |
*** belmoreira has quit IRC | 15:43 | |
mfedosin | flaper87: we need your help here https://review.openstack.org/#/c/254334/3 | 15:45 |
flaper87 | mfedosin: will review | 15:46 |
flaper87 | mfedosin: I asked jokke_ to weight in as well | 15:46 |
kairat | sigmavirus24, so you would recommend to stay it as it is here https://review.openstack.org/#/c/275120/? | 15:46 |
mfedosin | on short: in Liberty when user wanted to download 'killed' image Glance returned 204, in Mitaka we changed it to 403 | 15:46 |
kairat | one sorting direction for list and another for any requests with filters | 15:47 |
mfedosin | it's cli only thing | 15:47 |
kairat | it was rejected by community | 15:48 |
mfedosin | what community? | 15:48 |
kairat | so I am wondering if we should re-apply the patch | 15:48 |
kairat | by glance | 15:48 |
kairat | If you are talking about that: https://review.openstack.org/#/c/275120/? | 15:48 |
kairat | =) | 15:48 |
mfedosin | ah, I thought you'd talked about rejecting desc sorting order | 15:50 |
kairat | AFAIR, bunting proposed a patch to client where we changed default sort dir on client side | 15:50 |
*** achanda has quit IRC | 15:51 | |
sigmavirus24 | kairat: yes | 15:51 |
sigmavirus24 | kairat: I think the right place to fix this is the client | 15:52 |
sigmavirus24 | other clients probably behave differently too | 15:52 |
sigmavirus24 | by changing the API we're changing those clients implicitly | 15:52 |
sigmavirus24 | unless they're specifying their own sort order | 15:52 |
mfedosin | we can say, that default sort dir for client is asc, and always add it in requests | 15:53 |
*** mtanino has joined #openstack-glance | 15:54 | |
mfedosin | it's like we did with purge_props in v1 | 15:54 |
kairat | ok, thanks for consultation | 15:54 |
mfedosin | in glance the default value it true, but client uses false | 15:54 |
*** harshs has joined #openstack-glance | 15:54 | |
mfedosin | sigmavirus24: while you're here... | 15:54 |
mfedosin | hi, btw! | 15:54 |
* sigmavirus24 runs | 15:54 | |
sigmavirus24 | hi mfedosin ;) | 15:55 |
mfedosin | I'm faster ;) | 15:55 |
* mfedosin kids | 15:55 | |
mfedosin | https://review.openstack.org/#/c/254334/3 | 15:55 |
mfedosin | Stuart want to revert a patch that forbids download deactivated images for users | 15:55 |
mfedosin | and his opinion is we should return 204 when user wants to download killed image | 15:56 |
mfedosin | I think that current status 403 is correct | 15:56 |
mfedosin | sigmavirus24: what do you think? | 15:57 |
sigmavirus24 | I saw this | 15:58 |
sigmavirus24 | I still have to decide on this | 15:58 |
sigmavirus24 | I mean it's kind of tricky right | 16:00 |
sigmavirus24 | The user can see the image has been deactivated | 16:00 |
*** haomaiwang has quit IRC | 16:01 | |
*** haomaiwang has joined #openstack-glance | 16:01 | |
flaper87 | nikhil: ey | 16:02 |
flaper87 | hey, even | 16:02 |
flaper87 | nikhil: could you take a look at this patch? https://review.openstack.org/#/c/248359/ | 16:03 |
flaper87 | like the db side of it | 16:03 |
*** TravT has quit IRC | 16:03 | |
mfedosin | sigmavirus24: yes, but I don't see any problem with that | 16:04 |
mfedosin | return 403 if it's impossible to download image seems correct to me | 16:04 |
sigmavirus24 | mfedosin: except an image without any uploaded data wouldn't be a 403, right? | 16:05 |
flaper87 | brb | 16:05 |
mfedosin | sigmavirus24: why not? I don't mind if we return 403 in that case | 16:06 |
mfedosin | I understand if we have to keep compatibility and follow official document | 16:07 |
mfedosin | http://developer.openstack.org/api-ref-image-v2.html | 16:07 |
mfedosin | so, I proposed a patch that returns this behavior | 16:07 |
*** daemontool has quit IRC | 16:07 | |
mfedosin | https://review.openstack.org/#/c/284780/ | 16:08 |
nikhil | flaper87: ack | 16:10 |
sigmavirus24 | mfedosin: if there's no data to return that would semantically be a 204 | 16:12 |
sigmavirus24 | That said, I feel like if an administrator has disabled some resource it could either be a 404 or a 403 | 16:13 |
mfedosin | for me when image is 'queued' glance should return error code, because it's clear that it's impossible to download this image... | 16:15 |
mfedosin | 204 is correct when we created image without data with v1 | 16:16 |
mfedosin | sigmavirus24: do you know about this trick? | 16:16 |
*** sgotliv has joined #openstack-glance | 16:17 | |
sigmavirus24 | mfedosin: So I don't agree. If the image is queued, then there's no image data to return. | 16:18 |
sigmavirus24 | Nothing to return -> 204 | 16:19 |
mfedosin | v1 return 404 | 16:19 |
sigmavirus24 | I don't see having nothing to return from a queued image as an error | 16:19 |
mfedosin | returns | 16:19 |
sigmavirus24 | mfedosin: v2 was introduced to break the bad decisions of v1 | 16:19 |
sigmavirus24 | I don't think the behaviour of v1 is a justification for doing something wrong i v2 | 16:19 |
mfedosin | sigmavirus24: and add other :D | 16:19 |
sigmavirus24 | *in | 16:19 |
mfedosin | no-no, it's just fyi | 16:19 |
mfedosin | so yeah, queued -> 204 | 16:20 |
mfedosin | saving? | 16:20 |
*** dims has quit IRC | 16:22 | |
sigmavirus24 | 202 I think | 16:25 |
sigmavirus24 | or maybe 102 | 16:26 |
sigmavirus24 | I'm not certain to be honest | 16:26 |
sigmavirus24 | 102 are informational not really meant to be actual statuses | 16:27 |
sigmavirus24 | 202 is typically used during server creation too iirc | 16:27 |
sigmavirus24 | As in "the operation is in progress" accepted | 16:27 |
sigmavirus24 | That's what the poll operation tells you/does | 16:27 |
mfedosin | sigmavirus24: agree | 16:29 |
*** vijendar has quit IRC | 16:29 | |
mfedosin | and when image was deleted/killed -> 410 Gone | 16:29 |
mfedosin | http://tools.ietf.org/html/rfc7231.html#section-6.5.9 | 16:30 |
nikhil | flaper87: can you set some fields on https://blueprints.launchpad.net/glance/+spec/in-filtering-operator ? I want to be aware how strict the review needs to be.. | 16:30 |
sigmavirus24 | mfedosin: that could arguably be a 404 too | 16:30 |
*** rcernin has quit IRC | 16:31 | |
mfedosin | are we able to revert killed images? | 16:31 |
sigmavirus24 | I don't think so, so you're right it should be a 410 | 16:32 |
sigmavirus24 | We do keep the image record | 16:32 |
sigmavirus24 | Some sites use a 404 because they lose the record and can't be entirely certain if it ever existed | 16:32 |
sigmavirus24 | I think I disagree with mclaren though | 16:32 |
sigmavirus24 | I think a 403 is better | 16:32 |
mfedosin | for killed? | 16:33 |
mfedosin | sigmavirus24: I just need it too, because I'm working on Glare v1 API... | 16:34 |
sigmavirus24 | no | 16:34 |
sigmavirus24 | for deactivated | 16:34 |
sigmavirus24 | sorry | 16:34 |
mfedosin | https://review.openstack.org/#/c/283136/ | 16:34 |
mfedosin | okay, thank you man :) | 16:36 |
mfedosin | sorry, have to go home... | 16:36 |
mfedosin | I'll update my patch later to saving -> 202 | 16:36 |
*** ihrachys has quit IRC | 16:39 | |
*** daemontool has joined #openstack-glance | 16:40 | |
*** mfedosin has quit IRC | 16:41 | |
*** harshs has quit IRC | 16:43 | |
*** vijendar has joined #openstack-glance | 16:44 | |
*** SamYaple has joined #openstack-glance | 16:47 | |
nikhil | flaper87: reviewed https://review.openstack.org/#/c/248359/ | 16:48 |
SamYaple | Hello. I am trying to track down the security impact of running show_image_direct_url=True | 16:48 |
nikhil | I haven't +W it | 16:49 |
SamYaple | I know there was a vulnerability on it a while back, but is this still an insecure option? | 16:49 |
SamYaple | ive heard conflicting opinions | 16:49 |
nikhil | SamYaple: then you should have this conversation in private with the Openstack VMT and(or) glance-core-sec team. | 16:49 |
sigmavirus24 | nikhil: SamYaple doesn't have a vulnerability to report | 16:49 |
sigmavirus24 | He's asking about the security implications of setting that | 16:49 |
SamYaple | correct | 16:50 |
SamYaple | AFAIK any vulnerability is out in the wild and/or fixed already | 16:50 |
nikhil | hmm | 16:50 |
nikhil | lemme check | 16:50 |
*** vijendar1 has joined #openstack-glance | 16:53 | |
*** vijendar has quit IRC | 16:54 | |
*** vijendar has joined #openstack-glance | 16:54 | |
nikhil | sigmavirus24: which feature did the status codes conversation you guys were having a few mins back, relate to ? | 16:54 |
*** vijendar1 has quit IRC | 16:58 | |
*** haomaiwang has quit IRC | 17:01 | |
*** haomaiwang has joined #openstack-glance | 17:01 | |
*** lakshmiS has joined #openstack-glance | 17:01 | |
flaper87 | nikhil: thanks for your review | 17:02 |
nikhil | you're welcome | 17:04 |
flaper87 | Hey folks, just wanted to say thanks for all those amazing reviews. It's been awesome to see the effort that have been done in the last couple of days. | 17:05 |
flaper87 | nikhil: kairat mfedosin jokke_ mclaren bunting rosmaita ^ | 17:05 |
flaper87 | sigmavirus24: | 17:05 |
flaper87 | ^ | 17:05 |
nikhil | sigmavirus24: nvm, I was able to dig into the initial part of the conversations.. a bit of search given we'd a number of them quite recently :) | 17:06 |
nikhil | flaper87: ++ happy to help. we're all up for awesome release! | 17:06 |
*** vilobhmm11 has joined #openstack-glance | 17:07 | |
*** groen692 has quit IRC | 17:07 | |
*** dims has joined #openstack-glance | 17:09 | |
*** achanda has joined #openstack-glance | 17:10 | |
*** dims has quit IRC | 17:10 | |
*** vijendar1 has joined #openstack-glance | 17:11 | |
*** melwitt_ has joined #openstack-glance | 17:12 | |
*** MattMan_ has joined #openstack-glance | 17:14 | |
*** diegows_ has joined #openstack-glance | 17:16 | |
*** hemanthm_ has joined #openstack-glance | 17:16 | |
*** tonyb_ has joined #openstack-glance | 17:16 | |
*** kfox1111_ has joined #openstack-glance | 17:16 | |
sigmavirus24 | sorry nikhil was afk | 17:16 |
nikhil | sigmavirus24: np | 17:17 |
*** vijendar has quit IRC | 17:20 | |
*** edmondsw has quit IRC | 17:20 | |
*** MattMan has quit IRC | 17:20 | |
*** zul has quit IRC | 17:20 | |
*** ekarlso- has quit IRC | 17:20 | |
*** krotscheck has quit IRC | 17:20 | |
*** tonyb has quit IRC | 17:20 | |
*** strictlyb has quit IRC | 17:20 | |
*** timburke has quit IRC | 17:20 | |
*** bapalm has quit IRC | 17:20 | |
*** diegows has quit IRC | 17:20 | |
*** melwitt has quit IRC | 17:20 | |
*** _stowa has quit IRC | 17:20 | |
*** hemanthm has quit IRC | 17:20 | |
*** kfox1111 has quit IRC | 17:20 | |
*** krotscheck has joined #openstack-glance | 17:20 | |
*** bapalm has joined #openstack-glance | 17:21 | |
*** strictlyb has joined #openstack-glance | 17:21 | |
flaper87 | sigmavirus24: you'll never be forgiven | 17:21 |
flaper87 | sigmavirus24: NEVER! | 17:21 |
sigmavirus24 | flaper87: typical | 17:21 |
sigmavirus24 | I work on requests and everyone blames me for the .json -> .json() switch in 1.x | 17:21 |
*** dims has joined #openstack-glance | 17:22 | |
sigmavirus24 | I didn't even do it | 17:22 |
sigmavirus24 | But as soon as I say I work on requests that's the immediate response "WHY DID YOU DO THAT?!" | 17:22 |
sigmavirus24 | I'm used to being hated on ;) | 17:22 |
*** timburke has joined #openstack-glance | 17:23 | |
*** ekarlso- has joined #openstack-glance | 17:27 | |
*** edmondsw has joined #openstack-glance | 17:27 | |
*** zul has joined #openstack-glance | 17:27 | |
*** _stowa_ has joined #openstack-glance | 17:28 | |
*** _stowa_ is now known as _stowa | 17:35 | |
*** vilobhmm11 has quit IRC | 17:38 | |
flaper87 | So, folks! We'll release glance_store on monday | 17:42 |
flaper87 | I realize weekend is right there but, this is the last chance to get features in for glance_store | 17:43 |
*** jistr has quit IRC | 17:49 | |
*** vijendar1 has quit IRC | 17:51 | |
*** vilobhmm11 has joined #openstack-glance | 17:59 | |
*** haomaiwang has quit IRC | 18:01 | |
*** haomaiwang has joined #openstack-glance | 18:01 | |
*** AJaeger has joined #openstack-glance | 18:02 | |
*** vilobhmm11 has quit IRC | 18:02 | |
*** sgotliv has quit IRC | 18:02 | |
AJaeger | flaper87: I had to rebase and update the bandit to pep8 merge. could you put it again on your review queue, please? https://review.openstack.org/#/c/282885/ | 18:02 |
sigmavirus24 | features? Why features when we can fix bugs? | 18:02 |
*** vijendar has joined #openstack-glance | 18:03 | |
AJaeger | flaper87: your review queue is short ;) Thanks to you and Ian (sorry, don't know your nick) | 18:04 |
sigmavirus24 | AJaeger: I'm Ian ;) | 18:07 |
* sigmavirus24 is also a bandit core | 18:07 | |
*** pt_15 has joined #openstack-glance | 18:08 | |
AJaeger | sigmavirus24: We talked several times but forgot the real name ;/ Sorry | 18:08 |
sigmavirus24 | AJaeger: not a problem :) | 18:08 |
sigmavirus24 | Most people don't actually know my real name | 18:08 |
AJaeger | sigmavirus24: hope as bandit core you're happy with how I did it - and look at my bug report ;) | 18:08 |
sigmavirus24 | my brain has already context-switched off of this | 18:09 |
* sigmavirus24 double chekcs | 18:09 | |
*** dims is now known as dimsum__ | 18:09 | |
*** kzaitsev_mb has quit IRC | 18:09 | |
flaper87 | AJaeger: lol, just read IRC | 18:10 |
flaper87 | :D | 18:10 |
*** RichardRaseley has joined #openstack-glance | 18:11 | |
AJaeger | sigmavirus24: https://bugs.launchpad.net/bandit/+bug/1550161 | 18:11 |
openstack | Launchpad bug 1550161 in Bandit "advice on defusedxml but that is not in global-requiriments" [Undecided,New] | 18:11 |
*** harshs has joined #openstack-glance | 18:11 | |
*** dshakhray has quit IRC | 18:11 | |
AJaeger | flaper87: perfect timing? | 18:11 |
sigmavirus24 | AJaeger: commented | 18:12 |
AJaeger | sigmavirus24: thanks, let's continue there. | 18:14 |
openstackgerrit | Merged openstack/glance: Added support new v2 API image filters https://review.openstack.org/248359 | 18:20 |
*** vilobhmm11 has joined #openstack-glance | 18:23 | |
*** vilobhmm11 has quit IRC | 18:23 | |
*** vilobhmm11 has joined #openstack-glance | 18:23 | |
*** bjornar__ has joined #openstack-glance | 18:30 | |
*** ducttape_ has quit IRC | 18:34 | |
*** pushkaru has joined #openstack-glance | 18:34 | |
openstackgerrit | Merged openstack/glance_store: Add new config options for HTTPS store https://review.openstack.org/270059 | 18:34 |
*** kairat_ has joined #openstack-glance | 18:36 | |
*** vilobhmm11 has quit IRC | 18:37 | |
kairat_ | flaper87, nikhil could you please take a look on this too: https://review.openstack.org/#/c/251851/ | 18:40 |
*** vilobhmm11 has joined #openstack-glance | 18:41 | |
flaper87 | kairat_: I'm half-way through | 18:44 |
flaper87 | halfway* | 18:44 |
flaper87 | I honestly don't think I know that driver well enough | 18:45 |
kairat_ | ah, ok | 18:45 |
flaper87 | but I'll do my best | 18:45 |
*** haomaiwang has quit IRC | 18:46 | |
*** haomaiwang has joined #openstack-glance | 18:48 | |
*** achanda has quit IRC | 18:51 | |
kairat_ | bunting, I know mclaren is busy so I hope he will be able to spent some time on my patches | 18:54 |
*** AJaeger has left #openstack-glance | 18:55 | |
*** achanda has joined #openstack-glance | 18:55 | |
*** agireud has quit IRC | 18:55 | |
*** agireud has joined #openstack-glance | 18:57 | |
nikhil | kairat_: ack, in about 20 mins. that's on my queue already :) | 18:58 |
kairat_ | nikhil, thanks! | 18:58 |
*** vilobhmm11 has quit IRC | 19:00 | |
*** haomaiwang has quit IRC | 19:01 | |
*** 92AAAEL3R has joined #openstack-glance | 19:01 | |
bunting | kairat_: probably have to be monday now unfortuantly | 19:01 |
*** vilobhmm11 has joined #openstack-glance | 19:01 | |
kairat_ | bunting, Oh, ok | 19:02 |
bunting | 7 here in Ireland | 19:02 |
bunting | kairat_: at least you get to keep your beer ;) | 19:03 |
*** RichardRaseley has quit IRC | 19:05 | |
*** delattec has joined #openstack-glance | 19:06 | |
*** delatte has quit IRC | 19:08 | |
*** delatte has joined #openstack-glance | 19:09 | |
*** delattec has quit IRC | 19:11 | |
*** melwitt_ is now known as melwitt | 19:14 | |
sabari | flaper87: thanks for updating the http config patch :) | 19:15 |
*** dimsum__ has quit IRC | 19:16 | |
*** vijendar has quit IRC | 19:19 | |
*** ducttape_ has joined #openstack-glance | 19:23 | |
*** vijendar has joined #openstack-glance | 19:24 | |
*** porunov has joined #openstack-glance | 19:38 | |
*** vilobhmm11 has quit IRC | 19:47 | |
*** vilobhmm111 has joined #openstack-glance | 19:48 | |
*** erhudy has joined #openstack-glance | 19:48 | |
*** sgotliv has joined #openstack-glance | 19:59 | |
*** 92AAAEL3R has quit IRC | 20:01 | |
*** haomaiwang has joined #openstack-glance | 20:01 | |
*** itisha has quit IRC | 20:09 | |
openstackgerrit | Merged openstack/glance: Move bandit into pep8 https://review.openstack.org/282885 | 20:09 |
*** alejandrito has joined #openstack-glance | 20:20 | |
*** vijendar has quit IRC | 20:29 | |
*** dane-fichter has joined #openstack-glance | 20:30 | |
dane-fichter | hemanthm_: I see you're having some more issues with the verifier | 20:30 |
dane-fichter | hemanthm_ : any questions I can help with | 20:31 |
*** pushkaru has quit IRC | 20:33 | |
*** sgotliv has quit IRC | 20:37 | |
*** achanda has quit IRC | 20:45 | |
hemanthm_ | dane-fichter: Hey. Like we discussed yday, I pushed up another patchset that keeps a copy of the verifier, in case if the bufferedreader needs to reset the contents | 20:46 |
*** hemanthm_ is now known as hemanthm | 20:46 | |
dane-fichter | hemanthm: hmm perhaps I don't fully understand this comment from tim burke then | 20:46 |
dane-fichter | what's the issue there? | 20:47 |
hemanthm | dane-fichter: if we do end up resetting, we'd have created a new verifier object and the caller (glance) wouldn't necessarily know that the object has changed | 20:47 |
dane-fichter | ooh yeah that'd be bad | 20:47 |
hemanthm | it would still be pointing to the earlier verifier object that it initially passed | 20:47 |
hemanthm | yeah | 20:47 |
*** dims has joined #openstack-glance | 20:48 | |
hemanthm | too bad there's no reset operation on the verifier :) | 20:48 |
dane-fichter | ha! if you wanna hack that on, go right ahead | 20:49 |
dane-fichter | the joy of open source | 20:49 |
dane-fichter | (It wouldn't be that bad, you'd just have to refresh that hash context) | 20:50 |
*** vijendar has joined #openstack-glance | 20:50 | |
hemanthm | dane-fichter: I see. I'll try looking into that. Do you see any other solution for the short-term? | 20:51 |
* hemanthm looks for magical ways of resetting references | 20:52 | |
dane-fichter | hemanthm: that way lies madness my friend | 20:53 |
hemanthm | you bet! | 20:54 |
dane-fichter | I think a "nice" way of doing it would be to add a method to signature_utils that can "refresh" a verifier | 20:54 |
*** annasort has quit IRC | 20:54 | |
dane-fichter | The nicest way to do it would be to hack on pyca/cryptography directly and get them to do a release | 20:54 |
dane-fichter | but it's understandable if you don't have time for that | 20:55 |
dane-fichter | I will say that they are very responsive and accomodating though | 20:55 |
*** fesp has joined #openstack-glance | 20:58 | |
*** vijendar has quit IRC | 20:59 | |
*** haomaiwang has quit IRC | 21:01 | |
hemanthm | dane-fichter: ok, let me look into those options | 21:01 |
hemanthm | thanks for the help! :) | 21:01 |
*** haomaiwang has joined #openstack-glance | 21:01 | |
dane-fichter | no problemo. they have an IRC channel as well and are very responsive on it | 21:01 |
hemanthm | #cryptography-dev ? | 21:01 |
dane-fichter | yes | 21:02 |
hemanthm | ok, I shall get in touch with them. | 21:02 |
dane-fichter | having a reset() or refresh() method for that AsymmetricVerificationContext object would be the cleanest solution imo | 21:03 |
dane-fichter | anyhow, good luck :) let me know if you have any further questions | 21:04 |
*** smatzek has quit IRC | 21:06 | |
hemanthm | dane-fichter: +1 | 21:07 |
*** vijendar has joined #openstack-glance | 21:11 | |
*** kairat_ has quit IRC | 21:11 | |
*** dane-fichter has quit IRC | 21:12 | |
*** dshakhray has joined #openstack-glance | 21:15 | |
*** pt_15 has quit IRC | 21:15 | |
*** delattec has joined #openstack-glance | 21:15 | |
*** alejandrito has quit IRC | 21:16 | |
*** delatte has quit IRC | 21:17 | |
*** delattec has quit IRC | 21:20 | |
*** delattec has joined #openstack-glance | 21:22 | |
openstackgerrit | Kenneth Burger proposed openstack/glance: remove castellan from glance requirements https://review.openstack.org/284941 | 21:29 |
openstackgerrit | Kenneth Burger proposed openstack/glance: remove castellan from glance requirements https://review.openstack.org/284941 | 21:32 |
*** ninag has quit IRC | 21:36 | |
*** fesp has quit IRC | 21:37 | |
*** fesp has joined #openstack-glance | 21:39 | |
*** nikhil has quit IRC | 21:39 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance: Updated from global requirements https://review.openstack.org/285552 | 21:41 |
*** agireud has quit IRC | 21:41 | |
*** jamielennox is now known as jamielennox|away | 21:43 | |
*** agireud has joined #openstack-glance | 21:43 | |
*** vijendar has quit IRC | 21:43 | |
*** porunov has quit IRC | 21:45 | |
*** pushkaru has joined #openstack-glance | 21:48 | |
*** dshakhray has quit IRC | 21:51 | |
*** nikhil has joined #openstack-glance | 21:57 | |
*** haomaiwang has quit IRC | 22:01 | |
*** haomaiwang has joined #openstack-glance | 22:01 | |
hemanthm | 21:57:58 < reaperhulk> hemanthm: for now the answer is "no reset" but similar functionality will likely appear with the alternate signing methods we're considering | 22:04 |
hemanthm | 21:58:07 < reaperhulk> that will probably take the form of "you can replace the hash context" | 22:04 |
hemanthm | ah, dane left | 22:04 |
hemanthm | nevermind | 22:04 |
*** boden has joined #openstack-glance | 22:05 | |
nikhil | flaper87: when you get a chance, can you add priority reviews / dashboard link to the agenda under spotlight links https://etherpad.openstack.org/p/glance-team-meeting-agenda ? I noticed that glance doesn't have it while some other prjs do. | 22:20 |
*** smatzek has joined #openstack-glance | 22:20 | |
*** smatzek has quit IRC | 22:21 | |
*** proxima has quit IRC | 22:39 | |
*** burgerk has quit IRC | 22:41 | |
*** marcusvrn_ has quit IRC | 22:47 | |
*** boden has quit IRC | 22:53 | |
fesp | nikhil: sure, I hadn't done that as I was hoping we would do that using the dashboard. I guess an etherpad would be good too... I'll do that soon | 22:59 |
fesp | Definitely before monday | 22:59 |
*** fesp has quit IRC | 22:59 | |
*** haomaiwang has quit IRC | 23:01 | |
openstackgerrit | Srinivas Sakhamuri proposed openstack/glance_store: Make the image uploads atomic https://review.openstack.org/242084 | 23:01 |
*** haomaiwa_ has joined #openstack-glance | 23:01 | |
nikhil | flaper87: sounds good. I was thinking of any related review links to the agenda etherpad under spotlight. | 23:02 |
openstackgerrit | Srinivas Sakhamuri proposed openstack/glance_store: Make the image uploads atomic https://review.openstack.org/242084 | 23:07 |
*** dims has quit IRC | 23:07 | |
openstackgerrit | Matthew Edmonds proposed openstack/glance: make old signature dependencies optional https://review.openstack.org/284941 | 23:07 |
*** sigmavirus24 is now known as sigmavirus24_awa | 23:08 | |
*** ducttape_ has quit IRC | 23:10 | |
*** daemontool_ has joined #openstack-glance | 23:10 | |
*** daemontool has quit IRC | 23:13 | |
openstackgerrit | Matthew Edmonds proposed openstack/glance: make signature dependencies optional https://review.openstack.org/284941 | 23:21 |
*** pushkaru has quit IRC | 23:21 | |
*** dims has joined #openstack-glance | 23:34 | |
*** edmondsw has quit IRC | 23:39 | |
*** erhudy has quit IRC | 23:40 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!