Monday, 2016-12-19

« Sunday, 2016-12-18 Index Tuesday, 2016-12-20 »
*** ducttape_ has joined #openstack-glance00:08
*** croelandt has quit IRC00:23
*** ducttape_ has quit IRC00:52
*** ducttape_ has joined #openstack-glance01:04
*** ducttape_ has quit IRC01:15
*** ducttape_ has joined #openstack-glance01:29
*** trananhkma has joined #openstack-glance01:46
*** ducttape_ has quit IRC01:50
*** ducttape_ has joined #openstack-glance02:12
*** catintheroof has quit IRC02:28
*** catintheroof has joined #openstack-glance02:30
*** catintheroof has quit IRC02:34
*** ducttape_ has quit IRC02:37
*** ducttape_ has joined #openstack-glance02:37
*** ducttape_ has quit IRC02:52
openstackgerritCao Xuan Hoang proposed openstack/glance: Removes unnecessary utf-8 encoding  https://review.openstack.org/41010603:05
*** ediardo has quit IRC03:09
*** ediardo has joined #openstack-glance03:11
*** ducttape_ has joined #openstack-glance03:15
*** udesale has joined #openstack-glance03:22
*** ducttape_ has quit IRC03:26
*** nicolasbock has joined #openstack-glance03:53
*** ducttape_ has joined #openstack-glance04:26
*** ducttape_ has quit IRC04:31
*** nicolasbock has quit IRC04:43
*** prateek has joined #openstack-glance04:49
*** ducttape_ has joined #openstack-glance05:00
*** pdeore has joined #openstack-glance05:06
*** tshefi has joined #openstack-glance05:11
*** ratailor has joined #openstack-glance05:20
*** ducttape_ has quit IRC05:39
*** bkopilov has joined #openstack-glance06:04
*** bkopilov has quit IRC06:17
*** e0ne has joined #openstack-glance06:31
*** enginy has joined #openstack-glance06:31
*** e0ne has quit IRC06:33
*** ezoszed has joined #openstack-glance06:34
*** enginy has quit IRC06:34
*** enginy has joined #openstack-glance06:35
*** enginy has quit IRC06:36
*** qwertyco has joined #openstack-glance06:36
*** e0ne has joined #openstack-glance06:36
*** e0ne has quit IRC06:38
*** groen692 has joined #openstack-glance06:53
*** ducttape_ has joined #openstack-glance06:57
*** ducttape_ has quit IRC07:02
*** tesseract has joined #openstack-glance07:04
*** tesseract is now known as Guest3325407:05
*** pcaruana has joined #openstack-glance07:33
openstackgerritTuan Luong-Anh proposed openstack/python-glanceclient: Replace dict.iteritems() with dict.items()  https://review.openstack.org/36336707:54
*** mosulica has joined #openstack-glance08:11
*** qwertyco has quit IRC08:24
*** ducttape_ has joined #openstack-glance08:28
*** e0ne has joined #openstack-glance08:30
*** ducttape_ has quit IRC08:33
*** qwertyco has joined #openstack-glance08:36
*** zzzeek has quit IRC09:00
*** zzzeek has joined #openstack-glance09:01
*** qwertyco has quit IRC09:06
*** hieulq has joined #openstack-glance09:29
*** bkopilov has joined #openstack-glance09:52
*** Dinesh_Bhor has joined #openstack-glance09:54
*** ducttape_ has joined #openstack-glance09:58
*** ducttape_ has quit IRC10:03
*** bkopilov_ has joined #openstack-glance10:08
*** trananhkma has quit IRC10:20
*** mosulica has quit IRC10:39
*** udesale has quit IRC10:58
*** ducttape_ has joined #openstack-glance11:03
*** ducttape_ has quit IRC11:21
*** esmiurium has joined #openstack-glance11:30
*** ducttape_ has joined #openstack-glance11:33
*** nicolasbock has joined #openstack-glance11:38
*** smatzek has joined #openstack-glance11:43
*** pdeore has quit IRC11:47
*** ducttape_ has quit IRC11:49
*** ratailor has quit IRC11:49
*** e0ne has quit IRC11:50
*** catintheroof has joined #openstack-glance12:18
*** prateek has quit IRC12:24
*** ezoszed has quit IRC12:25
*** ezoszed has joined #openstack-glance12:26
*** bkopilov has quit IRC12:42
*** bkopilov_ has quit IRC12:42
*** flaper87 has joined #openstack-glance12:45
*** ducttape_ has joined #openstack-glance12:49
*** ducttape_ has quit IRC12:54
*** groen692 has quit IRC13:24
*** groen692 has joined #openstack-glance13:31
*** prateek has joined #openstack-glance13:31
*** erhudy has joined #openstack-glance13:45
*** ducttape_ has joined #openstack-glance13:50
*** ducttape_ has quit IRC13:55
*** tshefi has quit IRC13:57
*** pdeore has joined #openstack-glance14:02
*** e0ne has joined #openstack-glance14:02
*** pdeore__ has joined #openstack-glance14:04
*** pdeore__ has quit IRC14:06
*** pdeore has quit IRC14:07
*** ezoszed has quit IRC14:10
*** ezoszed has joined #openstack-glance14:11
*** chlong has joined #openstack-glance14:14
*** bkopilov has joined #openstack-glance14:15
*** bkopilov_ has joined #openstack-glance14:16
*** pdeore__ has joined #openstack-glance14:17
*** pdeore__ has quit IRC14:22
*** pdeore__ has joined #openstack-glance14:23
*** ducttape_ has joined #openstack-glance14:32
*** pdeore__ has quit IRC14:38
*** smatzek has quit IRC14:39
*** ducttape_ has quit IRC14:42
*** prateek has quit IRC14:46
*** prateek has joined #openstack-glance14:52
*** jamielennox is now known as jamielennox|away14:56
*** smatzek has joined #openstack-glance15:02
alex_bashGlancers: in order to facilicate the move to running Python3.5 jobs (http://lists.openstack.org/pipermail/openstack-dev/2016-December/109170.html) please review this patch asap: https://review.openstack.org/#/c/410428/15:14
*** ducttape_ has joined #openstack-glance15:17
*** ezoszed has quit IRC15:18
sigmavirusalex_bash: I really don't think this takes any priority over the items discussed and decided at the meeting15:26
sigmavirusAlso, we probably need to explore a better way of writing our tox.ini file15:27
alex_bashwas hoping for comments and suggestions to that effect on the review15:28
alex_bashas far as priority, we'll have a consistently failing gate job as soon as it's made voting, so I think it should be addressed as soon as possible15:29
*** aarefiev is now known as aarefiev_afk15:41
*** prateek has quit IRC15:44
*** tshefi has joined #openstack-glance15:49
*** mtanino has joined #openstack-glance15:50
sigmavirusalex_bash: so all those patches in that ml thread have merged15:56
sigmavirusand glance's gate is fine15:56
sigmavirusthat's because Andreas saw that our python3.5 tests were not passing and didn't break our gate15:56
sigmavirusso no, I don't think that patch is a priority15:56
sigmavirusnor do I think it will become one before Thursday15:56
*** mvk has quit IRC16:00
*** _ducttape_ has joined #openstack-glance16:00
*** Guest33254 has quit IRC16:02
*** hugokuo has quit IRC16:03
*** ratailor has joined #openstack-glance16:03
*** ducttape_ has quit IRC16:04
*** hugokuo has joined #openstack-glance16:09
*** keekz has quit IRC16:09
*** keekz has joined #openstack-glance16:11
*** pcaruana has quit IRC16:15
*** TravT has joined #openstack-glance16:26
*** _ducttape_ has quit IRC16:27
*** ducttape_ has joined #openstack-glance16:28
*** TravT has quit IRC16:33
*** smatzek has quit IRC16:34
*** smatzek has joined #openstack-glance16:38
*** e0ne has quit IRC16:59
*** ratailor has quit IRC17:01
*** _ducttape_ has joined #openstack-glance17:08
*** tshefi has quit IRC17:08
*** ducttape_ has quit IRC17:11
*** Zer0Byte__ has joined #openstack-glance17:17
*** groen692 has quit IRC17:17
*** _ducttape_ has quit IRC17:40
*** ducttape_ has joined #openstack-glance17:41
*** nicolasbock has quit IRC17:43
*** nicolasbock has joined #openstack-glance17:48
openstackgerritElod Illes proposed openstack/glance: Add Devstack plugin  https://review.openstack.org/40439117:56
openstackgerritDharini Chandrasekar proposed openstack/glance: Implement and Enable Community Images  https://review.openstack.org/36911018:01
openstackgerritMaxim Nestratov proposed openstack/glance: expand hypervisor_type meta data with Virtuozzo hypervisor  https://review.openstack.org/34162318:07
*** mfedosin_ has joined #openstack-glance18:07
openstackgerritIan Cordasco proposed openstack/glance: Update sample config files for Ocata-3  https://review.openstack.org/41256418:18
sigmavirusalex_bash: on the other hand, if you help the people who are around this week power through the priorities for this week prior to Thursday, we'll have no priorities and we can tackle the Python 3.5 work you've done18:36
sigmavirusalex_bash: the review priorities are not just for cores18:36
*** david-lyle_ has joined #openstack-glance19:13
*** dct360 has joined #openstack-glance19:13
*** openstackstatus has quit IRC19:13
*** david-lyle has quit IRC19:13
*** openstack has joined #openstack-glance19:13
*** e0ne has joined #openstack-glance19:23
*** e0ne has quit IRC19:27
*** e0ne has joined #openstack-glance19:31
*** chlong has quit IRC19:34
*** chlong has joined #openstack-glance19:36
*** ducttape_ has quit IRC19:37
openstackgerritDharini Chandrasekar proposed openstack/glance: Implement and Enable Community Images  https://review.openstack.org/36911019:39
openstackgerritCarlos Konstanski proposed openstack/python-glanceclient: v2: Content-Type: application/octet-stream header always added  https://review.openstack.org/39681619:53
*** rcernin has joined #openstack-glance19:56
*** e0ne has quit IRC19:56
openstackgerritMerged openstack/glance_store: Raise exc when using multi-tenant and swift+config  https://review.openstack.org/38894419:58
*** mfedosin_ has quit IRC19:58
*** e0ne has joined #openstack-glance20:00
*** ducttape_ has joined #openstack-glance20:05
*** e0ne has quit IRC20:30
*** e0ne has joined #openstack-glance20:34
*** e0ne has quit IRC20:38
*** jamielennox|away is now known as jamielennox21:04
*** e0ne has joined #openstack-glance21:07
*** e0ne has quit IRC21:10
*** e0ne has joined #openstack-glance21:14
*** e0ne has quit IRC21:18
openstackgerritIan Cordasco proposed openstack/glance: Update tox configuration file to reduce duplication  https://review.openstack.org/41261721:20
sigmavirusalex_bash: if we review ^ then your py35 change becomes a little simpler21:20
*** smatzek has quit IRC21:29
*** _ducttape_ has joined #openstack-glance21:29
alex_bashsigmavirus: looking21:32
*** ducttape_ has quit IRC21:33
*** _ducttape_ has quit IRC21:34
*** smatzek has joined #openstack-glance22:05
openstackgerritMerged openstack/glance: Python3: fix test_client_redirects.py  https://review.openstack.org/39288922:19
stevellerosmaita and others, please note Community Images is blocked by Tempest. We cannot implement CI (https://review.openstack.org/#/c/369110) due to recently-introduced Tempest tests (https://review.openstack.org/#/c/317088/)22:31
dharinicsigmavirus, Can you please have a look at stevelle's comment on CI? https://review.openstack.org/#/c/369110/22:36
stevellewe could use more opinions on how to update the tempest tests22:37
*** smatzek has quit IRC22:37
dharinicI was stuck trying to figure out why the tempest tests were failing. stevelle helped me understand what exactly was going on. So we are basically blocked due to the change Ia1369fa73f56ec290e868d3f2f2873785a70951d going in right after Timothy's PS 5322:38
stevelleMy suggestion was going to be to remove the explicit setting of private visibility in the shared _create_standard_image method and then add explicit updates to set private visibility on any existing tempest test which depends on private visibility behavior22:38
dharinicalex_bash^22:38
alex_bashI see only one alternative22:39
dharinicOr as stevelle mentioned in the comment, we can skip that one test22:40
alex_bashUpdate the tempest tests to not explicitly specify private visibility22:40
stevelleWe should also explicitly set private visibility for some existing tests, however22:41
stevelleas the change to default visibility from private to shared will otherwise break them22:41
stevellethat means skipping more tests possibly22:42
alex_bashactually, another alternative is to disable the tests until CI merges22:42
stevellethat's decidedly suboptimal, and either way requires we get a change merged in Tempest22:42
alex_bashThen change the failing tests to set the visibility to shared before doing member operations22:42
alex_bashI think it'll have to be done regardless22:43
stevellelook through the links above22:43
dharinicI know the person who authored the change. Maybe I email him with all of Glance folks cc'd? If that helps move quicker22:43
alex_bashI have looked at the test, it's not compatible with CI, because we've changed the API22:44
stevellewe don't have to disable the tests22:45
dharinicI think fixing the tempest tests is the right way to go. But, that might block CI for a fairly long time22:47
stevelleWe might have to disable one test, but others should likely be updated slightly22:47
stevelleI'm not sure what sort of social policies exist for tempest tests.22:50
stevelleand modifying them, that is something we likely need to get feedback on quickly22:50
*** mvk has joined #openstack-glance22:51
dharinicI agree.22:51
*** castulo has joined #openstack-glance22:58
dharinicHi castulo22:58
castulohey dharinic, what's up?22:58
dharinicstevelle^22:58
dharinicSo regarding this change that went into tempests: https://review.openstack.org/#/c/317088/22:59
dharinicThe images are created with private visibility22:59
dhariniccastulo: This is bp we are implementing in glance https://review.openstack.org/#/c/369110/23:00
dharinicwe require that images be created for tempest tests with the default visibility of "shared"23:00
castulolet me see23:00
dharinicand, possibly edit the tests that require visibility as private, by explicitly doing that23:01
dharinicSure. You can have a look at stevelle's comment on the latest PS23:01
castuloI'm not sure I get what you mean dhaniric, that patch I uploaded was to increase the coverage of the tests tempest had for listing images using all the parameters it supports (or supported, I wrote that patch many months ago). So as part of those tests there was one test that was sharing an image with another user, just so I could list the imgaes filtering by those who had the visbility = shared23:05
dharinicyes castulo. Thats right.23:06
dharinicwhen tempest tests run for glance, and create images: ListImagesTest._create_standard_image23:07
dharinicthey do so with private visibility23:08
stevellecastulo: and the new feature specifically introduces two new visibility states: [community, shared]23:09
dharinicWhich is fine. But, we are trying to implement a bp https://review.openstack.org/#/c/396919/23:09
stevellecastulo: after new feature, attempts to add member on a private image are forbidden. The current test expects add member to be accepted.23:10
stevellecastulo: I believe the ask is for assistance in revising the tests so we can get the feature in23:13
castuloI see, so based on new functionality the test_list_images_param_member_status test should not be using a private image for sharing it....23:14
castuloso what initial visibility should an image have so it can have a member created (shared)?23:16
dharinicyeah23:16
stevellecastulo: default image visibility is changed from 'private' to 'shared' with the new feature.23:17
stevellecastulo: default visibility would work, but some existing tempest tests already depend on _create_standard_image setting private visibility23:18
castuloso if the new default visibility of an image is shared, what happens to the visibility of an image after creating an image member?23:19
stevellecastulo: visibility remains shared23:20
stevellevisibility is a setting, not a reflection of state23:20
stevelleand not a calculated value23:20
castulomember_status remains unchanged, right?23:21
castuloso just to see if I get this right... so the test needs to be changed so it uses a shared image instead of a private one since sharing a private one is not allowed any more, correct?23:23
dharinicYeah, i believe thats the way to do it. stevelle can you confirm?23:25
alex_bashcastulo: that would be correct after Community Images merges, but now it would fail because there is no 'shared' visibility23:25
stevelleconfirming both the above23:26
alex_bashI think the way forward is to temporarily disable either the member test or the tests that check 'private' visibility23:27
stevellea 'default' visibility however would work now, and after the feature merges23:27
stevellebut default visibility would break test_list_images_param_visibility23:27
stevellethat test could be updated to use an image client to set visibility = 'private' before the test assertion23:28
stevellethat would also pass now, and after the feature merges23:28
alex_bashstevelle: that would work, but it changes the nature of the test a bit23:30
stevelleagreed, this is where we want castulo to consult :)23:30
alex_bashcurrently it tests for 'private' visibility after image creation, the new way would test that explicitly setting to 'private' works23:30
castuloso instead of using "private" for creating all the test images, using "default", and then just modifying test_list_images_param_visibility to use default as visibility as well23:31
*** ducttape_ has joined #openstack-glance23:31
stevellecastulo: I believe that should work, but I haven't tried it with a local tempest run, there may be other issues I missed23:31
castulohmm, well, the test is only testing the list of images can be filtered based on the parameters23:32
alex_bashto clarify not "default" but rather not specify visibility at all and let the API choose the default internally23:32
castuloso changing visibility from private to shared should not affect the purpose of the test I think23:32
openstackgerritMerged openstack/glance: Python 3: fix glance.tests.functional.db.test_sqlalchemy  https://review.openstack.org/40362023:32
*** ducttape_ has quit IRC23:34
*** ducttape_ has joined #openstack-glance23:35
stevelleI feel like the tempest patch set should take a few minutes to cook up and test, the hard part is making sure the change is not undermining anything23:36
stevelleand then merging23:36
castuloI need to leave soon, I can work on that patch first thing tomorrow morning if that is ok with you guys23:37
stevelleour priority comes from the fact that this feature is blocking other changes for Ocata as well23:37
stevelleI could cook up a patch set tonight that we can throw at the gate as well if there are no red flags castulo23:38
stevelleI'd be happy to let you take it over in the morning23:38
castuloas you prefer stevelle, just let me know how to proceed :)23:39
*** ducttape_ has quit IRC23:39
stevellecastulo: If I get around to it, I will add you as a reviewer right away, thanks23:40
stevelleI need to go shopping but will be back23:40
castulocool23:41
castulogood luck shopping23:41
*** nicolasbock has quit IRC23:54
*** ducttape_ has joined #openstack-glance23:55
*** ducttape_ has quit IRC23:59
« Sunday, 2016-12-18 Index Tuesday, 2016-12-20 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!