| rosmaita | hemanthm: about that change you made to eliminate the constants ... i can't find get_alembic_branch_head in glance.db.sqlalchemy | 00:04 |
|---|---|---|
| hemanthm | rosmaita: it's here https://review.openstack.org/#/c/392993/32/glance/db/sqlalchemy/alembic_migrations/__init__.py | 00:05 |
| rosmaita | ty, i was looking at an old version | 00:05 |
| hemanthm | I just realized that the number of rows we return after data migration could actually be greater than the number of rows in the table | 00:08 |
| hemanthm | it may confuse operators is all | 00:08 |
| hemanthm | like how can you migrate 1000 rows when there are only 900 rows in the images table | 00:09 |
| rosmaita | yes, that will provoke some questions | 00:09 |
| hemanthm | we just double count some rows because of the way we set all non-public images to private first | 00:09 |
| hemanthm | and then set shared | 00:10 |
| rosmaita | yeah, we'll have to think of a nice way to explain that | 00:11 |
| rosmaita | going to grab some dinner ... bbiab | 00:11 |
| hemanthm | ack, enjoy your dinner | 00:11 |
| openstackgerrit | Hemanth Makkapati proposed openstack/glance: Add expand/migrate/contract migrations for CI https://review.openstack.org/424774 | 00:15 |
| openstackgerrit | Hemanth Makkapati proposed openstack/glance: Add expand/migrate/contract migrations for CI https://review.openstack.org/424774 | 00:16 |
| dharinic | hemanthm: I think we should prevent that overlap | 00:23 |
| dharinic | the count returned for shared must be reassigned as private_count - shared_count | 00:28 |
| dharinic | and then return migrated rowcount | 00:28 |
| stevelle | hemanthm: I got nothing but nits here | 00:29 |
| dharinic | or just count only twice. cos the third one is a subset of the second | 00:34 |
| stevelle | I don't think doing calculations makes it any more helpful. the sum is the "number of changes performed" instead of "rows updated" and then it becomes clearer | 00:35 |
| dharinic | Hmmm, but as an operator I would expect a result for "number of rows updated". | 00:36 |
| hemanthm | agree with stevelle | 00:36 |
| hemanthm | it depends on how we interpret what's returned from data migrations | 00:36 |
| dharinic | Dont see why an operator would care about "number of changes" made | 00:36 |
| dharinic | Hmmm | 00:36 |
| hemanthm | dharinic: getting into those calculations is probably okay for this migrations | 00:37 |
| stevelle | It is unclear to me how number of "rows" is meaningful. | 00:37 |
| hemanthm | but we don't know if that'd be possible for all migrations | 00:37 |
| dharinic | yep, i realize that. | 00:38 |
| hemanthm | stevelle: feel free to post those nits, I'm waiting on pushing a new PS anyway | 00:38 |
| stevelle | if rows is meaningful, we just do a count(*) and return that number. | 00:38 |
| stevelle | working on them | 00:38 |
| hemanthm | oh well, I did push a new PS, but I can do another one too | 00:38 |
| hemanthm | ack | 00:38 |
| *** ducttape_ has quit IRC | 00:39 | |
| dharinic | cool. | 00:39 |
| *** ducttape_ has joined #openstack-glance | 00:39 | |
| hemanthm | hmmm strange .. I saw gate running on the 2nd patch. Now it says queued again | 00:40 |
| *** ducttape_ has quit IRC | 00:41 | |
| *** _ducttape_ has joined #openstack-glance | 00:41 | |
| *** _ducttape_ has quit IRC | 00:42 | |
| *** ducttape_ has joined #openstack-glance | 00:42 | |
| stevelle | I see is running | 00:50 |
| stevelle | 3 checks left to go | 00:50 |
| dharinic | jenkins passes on patch 3 | 00:52 |
| hemanthm | It started again after being queued | 00:53 |
| hemanthm | well, unless I'm hallucinating | 00:53 |
| *** openstackgerrit has quit IRC | 01:02 | |
| stevelle | hemanthm: no objections over patch 4, if you're going to do another go for it. | 01:26 |
| hemanthm | stevelle: nothing pending, I didn't realize I already pushed a new PS | 01:27 |
| stevelle | hemanthm: wasn't sure if you were going to for https://review.openstack.org/#/c/424774/13/glance/tests/functional/db/migrations/test_ocata_contract01.py@56 | 01:28 |
| hemanthm | stevelle: I did push a new PS for that | 01:28 |
| hemanthm | it is PS #15 | 01:29 |
| stevelle | not sure why I'm not seeing it | 01:29 |
| stevelle | force-reloads | 01:29 |
| stevelle | bombs away. | 01:31 |
| hemanthm | \o/ | 01:32 |
| dharinic | :D | 01:32 |
| hemanthm | dharinic: are these your first set of +2s? | 01:32 |
| rosmaita | thanks, folks ... lot of work by hemanthm stevelle dharinic and alex_bash | 01:33 |
| dharinic | hemanthm: First major +2s | 01:33 |
| hemanthm | ah, ok | 01:34 |
| dharinic | I had +2'd 2 small changes earlier | 01:34 |
| dharinic | thanks rosmaita :) | 01:34 |
| dharinic | lot of great work by hemanthm :) | 01:34 |
| rosmaita | while we're watching the gate, everyone take a look at the release notes: https://review.openstack.org/#/c/427971/ | 01:34 |
| hemanthm | It was a lot of work for sure but it is a lot more work to review. Thanks a ton to stevelle, dharinic, rosmaita, nikhil and sigmavirus! | 01:35 |
| stevelle | I'm just glad we ended up having as many eyes on it as we did | 01:38 |
| hemanthm | rosmaita: that's two out of three priorities delivered? | 01:40 |
| hemanthm | or say 1.5 because we didn't finish rolling upgrades | 01:40 |
| rosmaita | well, 2.5 out of 4 | 01:40 |
| rosmaita | (community goal, too) | 01:40 |
| hemanthm | ah, right | 01:40 |
| rosmaita | i'd even go so far as 2.75 out of 4 | 01:41 |
| dharinic | rosmaita: the database section you have referenced in the release notes.. would we updating that as well? | 01:41 |
| rosmaita | dharinic: yes, we will have to | 01:41 |
| rosmaita | if we add a rolling upgrad page, we'll put a link to it on the db page | 01:42 |
| hemanthm | yeah, I will update the dev docs | 01:42 |
| rosmaita | the advantage of working from the developer docs is that the link in the release notes will be to master | 01:42 |
| dharinic | Hmmm. The release note points to something that is currently not updated. Is that fine? | 01:42 |
| rosmaita | it will be updated when the changes merge | 01:42 |
| dharinic | oh cool | 01:42 |
| dharinic | awesome | 01:42 |
| rosmaita | that's the db.rst file that was in patch 3 i think | 01:43 |
| hemanthm | yeah | 01:43 |
| rosmaita | but it will need some more work | 01:43 |
| rosmaita | but the key thing is, we can merge that whenever we feel like it | 01:43 |
| *** jose-phillips has quit IRC | 01:44 | |
| *** mtanino has quit IRC | 01:53 | |
| *** openstackgerrit has joined #openstack-glance | 01:54 | |
| openstackgerrit | Fei Long Wang proposed openstack/glance_store master: Replace image.stat() with image.size() call https://review.openstack.org/378460 | 01:54 |
| *** jdillaman has quit IRC | 02:04 | |
| openstackgerrit | Brian Rosmaita proposed openstack/glance master: Alembic migrations/rolling upgrades release note https://review.openstack.org/427971 | 02:05 |
| *** zhurong has joined #openstack-glance | 02:08 | |
| rosmaita | dharinic: sorry, i missed your comments while i was updating that patch | 02:17 |
| *** jdillaman has joined #openstack-glance | 02:17 | |
| dharinic | No problem rosmaita. They were just some minor suggestions. Anyway we point to the doc | 02:18 |
| rosmaita | did you mean highlight in italics, or bold? | 02:18 |
| hemanthm | I'm seeing the same thing again ... gate is running twice | 02:18 |
| *** cdelatte has quit IRC | 02:19 | |
| dharinic | back ticks | 02:19 |
| rosmaita | those are usually reserved for identifiers, though | 02:19 |
| dharinic | Actually, any highlight works. | 02:19 |
| rosmaita | http://docs-draft.openstack.org/71/427971/2/check/gate-glance-releasenotes/ea58584//releasenotes/build/html/unreleased.html | 02:20 |
| * dharinic needs to learn more about documenting | 02:20 | |
| rosmaita | the two items in the prelude have italics in them, i could see doing that | 02:20 |
| *** zhurong has quit IRC | 02:20 | |
| dharinic | yeah. any form of differentiating them from the other text.. i guess | 02:21 |
| dharinic | hemanthm: I think it is running now | 02:22 |
| rosmaita | i'll do that, we can see how it looks ... the manage commands, though, i think shoudl be in the docs, not here | 02:22 |
| dharinic | yep. Sure. | 02:22 |
| hemanthm | dharinic: yeah, but I definitely saw the neutorn jobs almost finish on the 2nd patch | 02:23 |
| hemanthm | they have started again it looks like | 02:23 |
| rosmaita | i was kind of surprised how fast the first patch merged | 02:24 |
| openstackgerrit | Brian Rosmaita proposed openstack/glance master: Alembic migrations/rolling upgrades release note https://review.openstack.org/427971 | 02:24 |
| rosmaita | stevelle: flwang followed your hacking suggestion for https://review.openstack.org/#/c/378460/3 | 02:34 |
| flwang | rosmaita: thanks for highlight this | 02:42 |
| flwang | anybody know how to check why a test is skipped when using tox? thanks | 02:43 |
| hemanthm | Stepping away to get dinner, be back in an hour | 02:44 |
| *** hemanthm is now known as hemanthm|afk | 02:44 | |
| dharinic | flwang: Not sure. But sometimes due to lack of env support in your machine/vm, few tests get skipped. | 02:51 |
| dharinic | by tox | 02:51 |
| flwang | dharinic: yep, that's one of the reasons, but the weird thing is nosetests works fine | 02:52 |
| dharinic | oh. weird. Any specific test thats getting skipped? | 02:57 |
| *** bkopilov has quit IRC | 03:02 | |
| flwang | hah, it's a zaqar test, not glance | 03:04 |
| flwang | so i'm just trying to figure out how to debug it | 03:04 |
| dharinic | Aha, okay. | 03:07 |
| flwang | dharinic: but thanks a lot | 03:07 |
| dharinic | flwang: No problem :) | 03:09 |
| *** mtanino has joined #openstack-glance | 03:20 | |
| *** mtanino has quit IRC | 03:24 | |
| stevelle | looks like the gate wedged on post-processing a sporadic ceph failure in 397409, but recheck is running | 03:34 |
| *** hemanthm|afk is now known as hemanthm | 03:40 | |
| hemanthm | oh well | 03:40 |
| hemanthm | does the gate have to run again on #3 and #4? | 03:41 |
| openstackgerrit | Fei Long Wang proposed openstack/glance_store master: Replace image.stat() with image.size() call https://review.openstack.org/378460 | 03:45 |
| *** nicolasbock has quit IRC | 04:01 | |
| *** bkopilov has joined #openstack-glance | 04:19 | |
| stevelle | it was cancelled for them, but yes after 2 merges | 04:24 |
| hemanthm | hmmm | 04:28 |
| stevelle | just restarted the +1 verify check on 3 and 4 | 04:28 |
| hemanthm | stevelle: why not reverify? | 04:30 |
| stevelle | they are synonyms. | 04:30 |
| hemanthm | I thought recheck won't merge but reverify does | 04:30 |
| hemanthm | not sure | 04:31 |
| stevelle | afaik they actually behave the same | 04:31 |
| hemanthm | ok | 04:31 |
| *** abhishek_k has joined #openstack-glance | 04:35 | |
| *** abhishekk has quit IRC | 04:35 | |
| *** ducttape_ has quit IRC | 04:36 | |
| *** udesale has joined #openstack-glance | 04:36 | |
| *** pdeore has joined #openstack-glance | 04:47 | |
| *** adisky_ has joined #openstack-glance | 04:50 | |
| hemanthm | stevelle: just noticed that you removed +W from #3 and #4. Is that by accident? | 05:06 |
| stevelle | nope, will reapply to ensure the gate attempts merge | 05:07 |
| stevelle | #2 just finished the last check for +1, should get the logs up soon and start it's +2 | 05:08 |
| *** ratailor has joined #openstack-glance | 05:08 | |
| hemanthm | ok, thanks | 05:09 |
| *** bkopilov_ has joined #openstack-glance | 05:25 | |
| *** groen692 has joined #openstack-glance | 05:35 | |
| *** ducttape_ has joined #openstack-glance | 05:37 | |
| *** groen692 has quit IRC | 05:42 | |
| *** groen692 has joined #openstack-glance | 05:42 | |
| *** ducttape_ has quit IRC | 05:42 | |
| *** markvoelker has joined #openstack-glance | 06:10 | |
| *** markvoelker_ has quit IRC | 06:12 | |
| *** mnaser has quit IRC | 06:12 | |
| *** abhishek_k has quit IRC | 06:13 | |
| *** abhishek_k has joined #openstack-glance | 06:13 | |
| *** groen692 has quit IRC | 06:27 | |
| *** groen692 has joined #openstack-glance | 06:29 | |
| *** mnaser has joined #openstack-glance | 06:35 | |
| *** groen692 has quit IRC | 06:42 | |
| *** groen692 has joined #openstack-glance | 06:44 | |
| *** clayton has quit IRC | 06:46 | |
| *** groen692 has quit IRC | 06:50 | |
| *** groen692 has joined #openstack-glance | 06:50 | |
| *** pdeore has quit IRC | 06:57 | |
| *** groen692 has quit IRC | 07:00 | |
| *** pdeore has joined #openstack-glance | 07:04 | |
| *** rcernin has joined #openstack-glance | 07:06 | |
| *** tshefi has joined #openstack-glance | 07:07 | |
| *** ducttape_ has joined #openstack-glance | 07:08 | |
| *** ducttape_ has quit IRC | 07:13 | |
| *** zhurong has joined #openstack-glance | 07:13 | |
| *** tesseract has joined #openstack-glance | 07:16 | |
| *** groen692 has joined #openstack-glance | 07:21 | |
| *** e0ne has joined #openstack-glance | 07:28 | |
| *** groen692 has quit IRC | 07:33 | |
| *** e0ne has quit IRC | 07:33 | |
| *** mfedosin has joined #openstack-glance | 07:34 | |
| *** e0ne has joined #openstack-glance | 07:38 | |
| *** pcaruana has joined #openstack-glance | 07:39 | |
| *** e0ne has quit IRC | 07:42 | |
| *** pcaruana has quit IRC | 07:42 | |
| *** pcaruana has joined #openstack-glance | 07:43 | |
| *** e0ne has joined #openstack-glance | 07:46 | |
| *** groen692 has joined #openstack-glance | 07:50 | |
| *** e0ne has quit IRC | 07:53 | |
| *** e0ne has joined #openstack-glance | 07:57 | |
| *** e0ne has quit IRC | 08:01 | |
| *** e0ne has joined #openstack-glance | 08:06 | |
| *** e0ne has quit IRC | 08:11 | |
| *** e0ne has joined #openstack-glance | 08:16 | |
| *** e0ne has quit IRC | 08:21 | |
| *** e0ne has joined #openstack-glance | 08:26 | |
| *** zhurong has quit IRC | 08:28 | |
| *** rcernin has quit IRC | 08:28 | |
| *** ezoszed has joined #openstack-glance | 08:29 | |
| *** ezoszed has quit IRC | 08:29 | |
| *** ezoszed has joined #openstack-glance | 08:31 | |
| *** e0ne has quit IRC | 08:34 | |
| *** ducttape_ has joined #openstack-glance | 08:38 | |
| *** e0ne has joined #openstack-glance | 08:38 | |
| *** ducttape_ has quit IRC | 08:43 | |
| *** e0ne has quit IRC | 08:50 | |
| *** rcernin has joined #openstack-glance | 08:52 | |
| *** e0ne has joined #openstack-glance | 08:54 | |
| *** zzzeek has quit IRC | 09:00 | |
| *** zzzeek has joined #openstack-glance | 09:01 | |
| BobBall | rosmaita: No worries - thanks. | 09:02 |
| BobBall | rosmaita: Looks like the failure might have been Cinder breaking support for Ubuntu 14.04 | 09:02 |
| *** e0ne has quit IRC | 09:02 | |
| *** ezoszed has quit IRC | 09:09 | |
| *** ezoszed has joined #openstack-glance | 09:17 | |
| openstackgerrit | Danny Al-Gaaf proposed openstack/glance master: Adds purge command to glancemanage man page https://review.openstack.org/427634 | 09:24 |
| stevelle | http://status.openstack.org/openstack-health/#/job/gate-tempest-dsvm-neutron-full-ubuntu-xenial?duration=P7D :( | 10:09 |
| *** ducttape_ has joined #openstack-glance | 10:09 | |
| *** ducttape_ has quit IRC | 10:14 | |
| stevelle | https://review.openstack.org/#/c/427782/ may resolve that, will have to see | 10:19 |
| *** udesale has quit IRC | 10:24 | |
| *** dalgaaf has quit IRC | 10:43 | |
| *** dalgaaf has joined #openstack-glance | 10:49 | |
| *** aarefiev_afk is now known as aarefiev | 11:08 | |
| *** ducttape_ has joined #openstack-glance | 11:10 | |
| *** ducttape_ has quit IRC | 11:14 | |
| *** nicolasbock has joined #openstack-glance | 11:18 | |
| *** ducttape_ has joined #openstack-glance | 11:30 | |
| *** groen692 has quit IRC | 11:35 | |
| *** groen692 has joined #openstack-glance | 11:47 | |
| *** catintheroof has joined #openstack-glance | 11:47 | |
| *** groen692 has quit IRC | 11:52 | |
| *** ducttape_ has quit IRC | 11:57 | |
| *** bkopilov_ has quit IRC | 11:57 | |
| *** bkopilov has quit IRC | 11:58 | |
| *** ducttape_ has joined #openstack-glance | 12:00 | |
| *** e0ne has joined #openstack-glance | 12:00 | |
| *** ratailor has quit IRC | 12:02 | |
| *** openstackgerrit has quit IRC | 12:03 | |
| *** clayton has joined #openstack-glance | 12:13 | |
| *** ducttape_ has quit IRC | 12:22 | |
| *** ducttape_ has joined #openstack-glance | 12:42 | |
| *** ducttape_ has quit IRC | 12:53 | |
| *** mvk has quit IRC | 12:55 | |
| *** gcb has joined #openstack-glance | 13:00 | |
| *** ducttape_ has joined #openstack-glance | 13:02 | |
| *** openstackgerrit has joined #openstack-glance | 13:09 | |
| openstackgerrit | Merged openstack/glance master: Refactor tests to use Alembic to run migrations https://review.openstack.org/397409 | 13:09 |
| *** dalgaaf has quit IRC | 13:20 | |
| *** dalgaaf has joined #openstack-glance | 13:27 | |
| *** mvk has joined #openstack-glance | 13:29 | |
| *** abashmak_ is now known as alex_bash | 13:47 | |
| *** zhurong has joined #openstack-glance | 13:48 | |
| *** ducttape_ has quit IRC | 13:57 | |
| rosmaita | Courtesy meeting reminder on #openstack-meeting-4: ativelkov, cpallares, flaper87, flwang1, hemanthm, jokke_, kragniz, lakshmiS, mclaren, mfedosin, nikhil_k, Nikolay_St, Olena, pennerc, rosmaita, sigmavirus24, sabari, TravT, ajayaa, GB21, bpoulos, harshs, abhishek, bunting, dshakhray, wxy, dhellmann, kairat, aavraham, alex_bash | 13:59 |
| *** gcb has quit IRC | 14:05 | |
| *** zhurong has quit IRC | 14:06 | |
| *** ducttape_ has joined #openstack-glance | 14:16 | |
| *** zhurong has joined #openstack-glance | 14:17 | |
| *** bkopilov_ has joined #openstack-glance | 14:19 | |
| *** bkopilov has joined #openstack-glance | 14:19 | |
| *** ducttape_ has quit IRC | 14:27 | |
| *** udesale has joined #openstack-glance | 14:29 | |
| sigmavirus | hemanthm: SSH timeout should be safe to recheck: http://logs.openstack.org/93/392993/32/gate/gate-tempest-dsvm-neutron-full-ubuntu-xenial/f5393de/console.html#_2017-02-02_14_32_21_048097 | 14:36 |
| sigmavirus | hemanthm: also, us old fogies should unlearn "reverify" since everything responds to "recheck" and "reverify" never stopped the patch from going back through the check queue to the gate queue | 14:37 |
| hemanthm | sigmavirus: yeah, it's the same failure that keeps showing up | 14:37 |
| hemanthm | sigmavirus: ack | 14:37 |
| *** zzzeek has quit IRC | 14:40 | |
| *** zzzeek has joined #openstack-glance | 14:40 | |
| *** pdeore has quit IRC | 14:49 | |
| *** TravT has joined #openstack-glance | 14:59 | |
| dharinic | https://review.openstack.org/#/c/417197/ | 15:00 |
| dharinic | http://logs.openstack.org/97/417197/3/check/gate-glance_store-releasenotes/762764f/console.html#_2017-01-31_17_26_32_410254 | 15:00 |
| *** udesale has quit IRC | 15:00 | |
| dharinic | rosmaita: Could use some advise on the translation issue. Since this is cherry picked, i do not get why it would fail on a releasenote. | 15:01 |
| rosmaita | dharinic: looking in stable/newton, it looks like translations were imported fairly recently | 15:02 |
| rosmaita | but the conf.py was not changed | 15:02 |
| dharinic | My first recheck for this issue was on Jan 5 rosmaita | 15:02 |
| rosmaita | "recent" == 7 months ago | 15:02 |
| dharinic | Haha. okay | 15:03 |
| rosmaita | conf.py dates back to a year ago | 15:03 |
| dharinic | cool, so this calls for a change to conf.py? | 15:03 |
| rosmaita | i think so ... maybe the thing to do is see if dhellmann is in #openstack-infra and see if there's something about reno and translations | 15:04 |
| dharinic | okay. Will check. Thanks rosmaita | 15:04 |
| rosmaita | but the short answer is, i think you're going to have to modify conf.py | 15:06 |
| rosmaita | but i don't really understand why ... it would be great if you could find out | 15:06 |
| *** zhurong has quit IRC | 15:09 | |
| *** mtanino has joined #openstack-glance | 15:13 | |
| dharinic | will look rosmaita | 15:13 |
| *** ducttape_ has joined #openstack-glance | 15:14 | |
| openstackgerrit | Brian Rosmaita proposed openstack/glance master: Alembic migrations/rolling upgrades release note https://review.openstack.org/427971 | 15:14 |
| rosmaita | dharinic: hemanthm: stevelle: could use a sanity check on ^^ | 15:15 |
| hemanthm | looking | 15:16 |
| rosmaita | all i can say is, we have some seriously long release notes! | 15:16 |
| *** johndperkins has quit IRC | 15:17 | |
| hemanthm | better long than short I guess | 15:18 |
| *** TravT has quit IRC | 15:19 | |
| *** TravT has joined #openstack-glance | 15:19 | |
| *** gabor_antal_ has joined #openstack-glance | 15:32 | |
| *** gabor_antal has quit IRC | 15:32 | |
| *** konan_abhi has joined #openstack-glance | 15:34 | |
| *** abhishek_k has quit IRC | 15:35 | |
| openstackgerrit | Brian Rosmaita proposed openstack/glance master: Alembic migrations/rolling upgrades release note https://review.openstack.org/427971 | 15:35 |
| *** thiagolib has quit IRC | 15:38 | |
| *** ezoszed has quit IRC | 15:44 | |
| openstackgerrit | Brian Rosmaita proposed openstack/glance master: Alembic migrations/rolling upgrades release note https://review.openstack.org/427971 | 15:48 |
| alex_bash | dharinic: congrats on making core!!! | 15:50 |
| *** e0ne has quit IRC | 15:53 | |
| rosmaita | sigmavirus: sigmaroosavirus it is! | 15:54 |
| sigmavirus | rosmaita: glad you liked that =P | 15:55 |
| rosmaita | i may have to refer to you as "teddy" occasionally, though | 15:56 |
| *** burgerk has joined #openstack-glance | 15:59 | |
| *** _ducttape_ has joined #openstack-glance | 16:00 | |
| *** _ducttape_ has quit IRC | 16:01 | |
| *** ducttape_ has quit IRC | 16:03 | |
| *** ducttape_ has joined #openstack-glance | 16:06 | |
| stevelle | point of interest: https://review.openstack.org/#/c/427775/ should clean up some of the gate failures we're being hit by so things can merge faster | 16:06 |
| hemanthm | that one is just ahead of us in the gate | 16:08 |
| dharinic | Thank you alex_bash :) | 16:08 |
| stevelle | maybe don't workflow or recheck until it merges, hemanthm | 16:09 |
| hemanthm | stevelle: +1 | 16:10 |
| *** mfedosin has quit IRC | 16:14 | |
| *** kberger has joined #openstack-glance | 16:25 | |
| *** rcernin has quit IRC | 16:29 | |
| *** ducttape_ has quit IRC | 16:38 | |
| *** ducttape_ has joined #openstack-glance | 16:39 | |
| *** tesseract has quit IRC | 16:41 | |
| openstackgerrit | Merged openstack/glance master: Add expand/migrate/contract commands to glance-manage CLI https://review.openstack.org/392993 | 16:45 |
| rosmaita | yay!!! | 16:52 |
| hemanthm | this is ready for +W | 16:52 |
| hemanthm | https://review.openstack.org/#/c/424774/ | 16:52 |
| rosmaita | i'll do it | 16:53 |
| rosmaita | done | 16:55 |
| hemanthm | cool | 16:56 |
| rosmaita | i was going to add, "and may God have mercy on our souls" to my +A comment, but thought that would be overdoing it | 16:57 |
| hemanthm | haha | 16:57 |
| hemanthm | rosmaita: it's your fault now if rolling upgrades break, you didn't ask for mercy | 16:58 |
| rosmaita | i just got back from the api-wg meeting ... really don't want to argue theology now! | 16:58 |
| hemanthm | :) | 16:59 |
| rosmaita | true story though ... at a previous job where i was tech lead on a project, i used to go donate blood the day before a release, because i felt that the software required a blood sacrifice | 17:00 |
| hemanthm | LOL | 17:00 |
| hemanthm | If that was true, I don't know what sacrifice OpenStack would need | 17:01 |
| alex_bash | liver and at least one of the kidneys | 17:01 |
| rosmaita | alex_bash: problem is, eventually you run out of those! | 17:02 |
| alex_bash | that's why we need fresh contributors all the time | 17:03 |
| *** hoonetorg has quit IRC | 17:03 | |
| alex_bash | shhh, don't tell the newbies their true purpose | 17:03 |
| rosmaita | really fresh! | 17:03 |
| stevelle | seems legit | 17:03 |
| dharinic | Lol | 17:03 |
| stevelle | so, lets wrap up the work on https://review.openstack.org/#/c/427971/ and get it into the gate | 17:04 |
| *** hoonetorg has joined #openstack-glance | 17:04 | |
| stevelle | with the nova fix in we should be pretty safe, not needing to do 1 at a time | 17:04 |
| dharinic | I had a question on the releasenote rosmaita | 17:05 |
| rosmaita | cool ... thanks for watching all this stevelle | 17:05 |
| rosmaita | your eyes must be glazed over | 17:05 |
| rosmaita | you've been at it for like 48 hours | 17:05 |
| rosmaita | dharinic: sure | 17:05 |
| rosmaita | yes, that is a good question | 17:05 |
| dharinic | I think stevelle mentioned it yesterday too. We need not really be talking about scripts to operators.. | 17:06 |
| rosmaita | well, i wonder whether operators modify scripts | 17:06 |
| rosmaita | like add extra indexes and stuff | 17:06 |
| dharinic | Less likely, but possible | 17:06 |
| rosmaita | also, probably before doing an upgrade, you want to see what you're getting into | 17:07 |
| dharinic | If everybody thinks, it is okay to have all that information in there, I am cool. | 17:07 |
| stevelle | I don't feel strongly, just wanted to get the thinking out loud on the point | 17:07 |
| dharinic | Just felt that it was too in-detail | 17:07 |
| rosmaita | i was wondering about that (the too much detail, i mean) | 17:07 |
| stevelle | and the audience includes packagers and operators | 17:07 |
| rosmaita | yeah, my reason for putting it in was that i figure packagers are going to include both | 17:08 |
| rosmaita | since we didnt' remove the "old" one | 17:08 |
| dharinic | okayy. | 17:08 |
| rosmaita | dharinic: but i'm still not convinced it's the right move | 17:08 |
| rosmaita | bummer that nikhil isn't here, he has spent a lot of time talking to operators | 17:09 |
| nikhil | I'm partially present | 17:09 |
| nikhil | :) | 17:09 |
| * nikhil has no context yet | 17:10 | |
| rosmaita | https://review.openstack.org/#/c/427971/6/releasenotes/notes/alembic-migrations-902b31edae7a5d7d.yaml | 17:10 |
| rosmaita | nikhil: ^^ will give you some context | 17:10 |
| hemanthm | Isn't too much detail better than missing detail? | 17:10 |
| hemanthm | If we are not sure I mean | 17:10 |
| rosmaita | i'm not sure ... we dont' want to encourage people to mess around | 17:11 |
| rosmaita | but we dont' want to hide anything, either | 17:11 |
| rosmaita | (and we can't actually hide anything, anyway) | 17:11 |
| hemanthm | Well, all the information is going to be in the dev docs any way | 17:12 |
| hemanthm | and there is a link to dev docs in the release notes | 17:12 |
| hemanthm | we can't stop people from messing around | 17:12 |
| hemanthm | My only worry is repetition | 17:13 |
| rosmaita | right ... i am going to put up a dev docs patch later today | 17:13 |
| rosmaita | so i could pull that stuff out of hte relnotes and use it in the devdocs | 17:13 |
| rosmaita | i guess the advantage of the detail is that it shows that we mean business | 17:14 |
| rosmaita | i.e., this is a change that needs to be paid attention to | 17:14 |
| rosmaita | because the commands for the manage cli take different values for the versions | 17:15 |
| hemanthm | I don't have a strong opinion, I'm good with what it is now | 17:17 |
| hemanthm | I don't think the extra detail hurts | 17:17 |
| *** mtanino_ has joined #openstack-glance | 17:18 | |
| dharinic | yeah, as long as it is not too much of repeating information, it is okay i guess | 17:19 |
| rosmaita | thanks for flagging this, dharinic , because it's a big pain to backfix a relnote, so it would be good to be convinced this is what we want before we merge it | 17:19 |
| *** mtanino__ has joined #openstack-glance | 17:19 | |
| *** mtanino has quit IRC | 17:19 | |
| dharinic | sure rosmaita. We can merge it when we are sure we dont have information repeating in both the rel note and the doc | 17:20 |
| rosmaita | well, there will definitely be some repeating info | 17:20 |
| rosmaita | the locations and stuff for sure | 17:20 |
| rosmaita | those have to be in teh dev docs | 17:20 |
| dharinic | Yep. | 17:20 |
| rosmaita | pretty much the entire thing, actually, just with more detail | 17:20 |
| rosmaita | i thought it was key to mention that there are 2 script directories now, but only one of them is actionable | 17:21 |
| rosmaita | so then needed to say which is the "real" one, and what the point of having the other one around is | 17:22 |
| *** mtanino_ has quit IRC | 17:22 | |
| rosmaita | i'll be curious what nikhil says when he's had a chance to look it over | 17:22 |
| nikhil | rosmaita: looking now | 17:29 |
| rosmaita | ty | 17:29 |
| *** hoonetorg has quit IRC | 17:38 | |
| *** chlong has joined #openstack-glance | 17:39 | |
| *** ducttape_ has quit IRC | 17:39 | |
| *** hoonetorg has joined #openstack-glance | 17:41 | |
| *** aarefiev is now known as aarefiev_afk | 17:44 | |
| *** hoonetorg has quit IRC | 17:47 | |
| nikhil | rosmaita: commented | 17:48 |
| rosmaita | ty | 17:49 |
| rosmaita | nikhil: what do you think about removing the "old" migration scripts before RC-1 ? | 17:54 |
| nikhil | rosmaita: you mean the code? | 17:55 |
| nikhil | or reference in the docs? | 17:55 |
| rosmaita | out of the code tree | 17:55 |
| *** jose-phillips has joined #openstack-glance | 17:56 | |
| sigmavirus | rosmaita: ping me when the last two rolling upgrade patches merge? | 17:56 |
| hemanthm | sigmavirus: 3rd one merged | 17:56 |
| * sigmavirus thought 3/5 were merged over an hour ago | 17:56 | |
| hemanthm | 4th is in the gate and almost done | 17:57 |
| rosmaita | 5th is being revised, but it's docs only, should go pretty fast | 17:57 |
| nikhil | rosmaita: hmm, I thought this feature is experimental? | 17:57 |
| rosmaita | only the rolling upgrade part | 17:58 |
| rosmaita | the E-M-C migration | 17:58 |
| rosmaita | otherwise, you can just do a regular upgrade | 17:58 |
| rosmaita | but the regualr one uses alembic | 17:58 |
| sigmavirus | rosmaita: good use of hyphens to avoid copyright issues | 17:58 |
| rosmaita | sigmavirus: :) | 17:58 |
| sigmavirus | regular == cold, yes? | 17:58 |
| rosmaita | yes | 17:58 |
| nikhil | rosmaita: noted | 17:58 |
| *** hoonetorg has joined #openstack-glance | 17:59 | |
| nikhil | rosmaita: please don't get me wrong and I don't believe we've reason to doubt: but if a few come back shouting I think we can have a backup plan | 17:59 |
| rosmaita | so you are saying keep the old scripts in? | 17:59 |
| sigmavirus | nikhil: how do you mean? | 17:59 |
| nikhil | rosmaita: we can mark them deprecated (I think) | 17:59 |
| hemanthm | I think we should keep old ones around for a bit | 18:00 |
| rosmaita | well, they won't run with glance-manage anymore | 18:00 |
| hemanthm | Maybe remove them in Pike | 18:00 |
| nikhil | though that won't have any technical significance | 18:00 |
| hemanthm | How do we mark migrations deprecated? | 18:00 |
| nikhil | yeah, we can't show them in the output | 18:01 |
| nikhil | so the deprecation has less meaning | 18:01 |
| hemanthm | There is no execution path for them | 18:01 |
| rosmaita | well, its worse than that ... the same commands now assume alembic scripts | 18:01 |
| rosmaita | what hemanthm said | 18:01 |
| hemanthm | Unless someone explicitly installs and invokes sqla-migrate | 18:01 |
| nikhil | but the feeling a devops person gets when he/she wakes up a fine morning to see them deleted | 18:02 |
| rosmaita | sure, but they are replaced with brand-spanking-new ones! | 18:02 |
| rosmaita | so ... that's why i went into all that detail in the release note | 18:02 |
| nikhil | it's a bad situation to make downstream folks with custom patches really really annoyed | 18:03 |
| rosmaita | so if someone looks, they won't be surprised/confused | 18:03 |
| nikhil | it's a hit and miss | 18:03 |
| hemanthm | They would be annoyed anyway | 18:03 |
| hemanthm | If they had their custom migrations, they'd have to switch to alembic too | 18:03 |
| nikhil | or revert alembic commits | 18:04 |
| rosmaita | that's the advantage of both versions, i guess, they can see how they will have to change their patches | 18:04 |
| nikhil | in the later case it's a easier devops experience | 18:04 |
| hemanthm | I want to keep them around for the reason rosmaita said above | 18:05 |
| nikhil | I don't believe all the problems are independent | 18:05 |
| rosmaita | well, for the convenience of operators, it just so happens that hte alembic commits are all stacked up right at the top! | 18:05 |
| nikhil | or any arguments for that matter | 18:05 |
| nikhil | things are interconnected | 18:05 |
| rosmaita | ok, so the consensus is: (a) leave the old scripts in | 18:06 |
| nikhil | rosmaita: yep, if people are annoyed it will be a hard sell | 18:06 |
| rosmaita | how about (b) remove the locations from the release note <-- i dont like this so much | 18:06 |
| nikhil | (a) is for developers/devops | 18:07 |
| nikhil | (b) is for operators to not get scared | 18:07 |
| hemanthm | (b) is just about how to present it | 18:08 |
| hemanthm | It'll be there in the link anyway | 18:08 |
| hemanthm | link to dev docs | 18:08 |
| nikhil | +1 on how to present it | 18:09 |
| rosmaita | ok, i'll do a quick revision and we can see how it looks | 18:09 |
| *** e0ne has joined #openstack-glance | 18:19 | |
| openstackgerrit | Brian Rosmaita proposed openstack/glance master: Alembic migrations/rolling upgrades release note https://review.openstack.org/427971 | 18:23 |
| rosmaita | nikhil: hemanthm: stevelle: dharinic: sigmavirus: ^^ | 18:23 |
| openstackgerrit | Merged openstack/glance master: Add expand/migrate/contract migrations for CI https://review.openstack.org/424774 | 18:27 |
| rosmaita | sigmavirus: ^^ that was #4, now just the release notes | 18:29 |
| sigmavirus | WOOT! | 18:29 |
| dharinic | :) | 18:29 |
| sigmavirus | rosmaita: so | 18:29 |
| sigmavirus | if you rebase your releasenotes patch on top of current master and there are no objects, I can submit your SHA sicne it'll merge without a emrge commit | 18:30 |
| sigmavirus | if you don't want to do that, then we can just wait for yours to merge to submit the release request | 18:30 |
| rosmaita | ok ... need comments on this version first | 18:32 |
| *** dharinic is now known as dharinic|lunch | 18:34 | |
| sigmavirus | geeze rosmaita you're so needy ;P | 18:35 |
| *** mvk has quit IRC | 18:35 | |
| rosmaita | what i need is some lunch ... but will get this done first | 18:37 |
| hemanthm | rosmaita: go ahead, I can push up a patch if further changes are needed | 18:38 |
| * sigmavirus aims to make review of this patch as humorous as possible | 18:39 | |
| rosmaita | i'll make sigmavirus 's changes and then go | 18:39 |
| sigmavirus | I'm good after those changes are made | 18:39 |
| rosmaita | i'm glad someone appreciates my experimental prose | 18:39 |
| sigmavirus | You'll have my Roose+2 | 18:39 |
| *** ducttape_ has joined #openstack-glance | 18:40 | |
| sigmavirus | also never forget that wen I started calling kragniz "kraggy" he started calling me "siggy" | 18:40 |
| sigmavirus | Long live Kraggy | 18:40 |
| nikhil | rosmaita: you've my comments too | 18:42 |
| *** ducttape_ has quit IRC | 18:44 | |
| rosmaita | nikhil: ty | 18:46 |
| openstackgerrit | Brian Rosmaita proposed openstack/glance master: Alembic migrations/rolling upgrades release note https://review.openstack.org/427971 | 18:49 |
| openstackgerrit | Brian Rosmaita proposed openstack/glance master: Alembic migrations/rolling upgrades release note https://review.openstack.org/427971 | 18:53 |
| hemanthm | rosmaita: "for" is repeated on L34 | 18:57 |
| * nikhil bbiab | 19:00 | |
| openstackgerrit | Brian Rosmaita proposed openstack/glance master: Alembic migrations/rolling upgrades release note https://review.openstack.org/427971 | 19:02 |
| rosmaita | i hope that's the last one ^^ | 19:03 |
| * rosmaita bbiab | 19:08 | |
| *** dharinic|lunch is now known as dharinic | 19:08 | |
| stevelle | somewhat surprised nobody followed nikhil's statement with "and my axe!" | 19:09 |
| hemanthm | :) | 19:15 |
| hemanthm | I get this reference at least | 19:16 |
| nikhil | stevelle: I dont | 19:26 |
| stevelle | fair enough. just a lord of the rings thing. | 19:27 |
| *** ducttape_ has joined #openstack-glance | 19:32 | |
| rosmaita | sigmavirus: your move ... want a new ps? | 19:32 |
| rosmaita | who'd have thought we'd be talking about the present perfect simple tense on a review? gotta love working on glance! | 19:35 |
| *** TravT has quit IRC | 19:37 | |
| sigmavirus | rosmaita: nah, I'm fine | 19:37 |
| sigmavirus | +2 | 19:37 |
| *** mtanino__ has quit IRC | 19:39 | |
| hemanthm | any final reservations anyone? If not, will +W | 19:39 |
| rosmaita | sigroosavirus beat you to it | 19:40 |
| hemanthm | oh, nevermind .. Roosevirus to the rescue | 19:40 |
| dharinic | rooseyvirus* | 19:41 |
| sigmavirus | rosmaita: https://review.openstack.org/428399 | 20:03 |
| sigmavirus | et. all ^ | 20:03 |
| sigmavirus | rosmaita: just fwiw, a docs person agrees with me on your release notes change =P | 20:03 |
| sigmavirus | said docs person will remain unnamed | 20:03 |
| rosmaita | i can live with that | 20:17 |
| rosmaita | you probably noticed that my sentences aren't the shortest, either | 20:18 |
| nikhil | rosmaita: congrats on getting this out | 20:19 |
| rosmaita | but since we use python, i've been able to remove the semicolon key from my keyboard | 20:19 |
| rosmaita | nikhil: thanks for your help, some very timely reviews | 20:19 |
| nikhil | rosmaita: ;) | 20:20 |
| nikhil | rosmaita: well, python does have semicolon | 20:20 |
| nikhil | rosmaita: but it also has zen of python | 20:20 |
| rosmaita | i thought we had a hacking rule against that :) | 20:21 |
| * nikhil checks | 20:21 | |
| sigmavirus | rosmaita: we do | 20:21 |
| sigmavirus | it's not actually hacking specific | 20:21 |
| sigmavirus | it's pep8 specific | 20:21 |
| sigmavirus | Glance RC-1 has been approved! | 20:22 |
| rosmaita | man, i was just looking over the hash | 20:22 |
| sigmavirus | #success Glance merged Experimental Rolling Upgrades for RC-1 | 20:23 |
| openstackstatus | sigmavirus: Added success to Success page | 20:23 |
| sigmavirus | (we should use that more often) | 20:23 |
| nikhil | rosmaita: sigmavirus : congrats on getting RC1 out | 20:24 |
| rosmaita | https://wiki.openstack.org/wiki/Successes | 20:24 |
| rosmaita | i had no idea | 20:24 |
| nikhil | sigmavirus: couldn't find the rule yet | 20:24 |
| sigmavirus | rosmaita: it's nice | 20:24 |
| sigmavirus | nikhil: it's a rule about multiple statements on one line | 20:24 |
| nikhil | rather pep8 has another pet peeve https://www.python.org/dev/peps/pep-0008/#whitespace-in-expressions-and-statements | 20:24 |
| sigmavirus | I don't think it specifically checks for `;` only | 20:24 |
| nikhil | sigmavirus: aha | 20:24 |
| nikhil | it's weird | 20:25 |
| sigmavirus | people tend to only use ;s in python to have more than one statement on a line | 20:25 |
| sigmavirus | what do you mean? | 20:25 |
| sigmavirus | Oh yeah | 20:25 |
| nikhil | how that's a inconsistent cyclic dep | 20:25 |
| sigmavirus | Some people love the whitespace inside parens | 20:25 |
| sigmavirus | I never understood that | 20:25 |
| sigmavirus | I've never seen that in the wild in any language either | 20:25 |
| nikhil | in that rule they mention semicolon | 20:25 |
| sigmavirus | yeah | 20:26 |
| nikhil | ha | 20:26 |
| sigmavirus | multiple expressions on a single line are *okay* | 20:26 |
| sigmavirus | But they prefer you don't | 20:26 |
| sigmavirus | But ifyou have to | 20:26 |
| sigmavirus | Don't do it that way | 20:26 |
| sigmavirus | =P | 20:26 |
| nikhil | LOL | 20:26 |
| nikhil | do it only if you don't :P :P | 20:26 |
| nikhil | (don't have to) | 20:27 |
| sigmavirus | yeah | 20:27 |
| sigmavirus | so | 20:27 |
| sigmavirus | Guido, et. all, have been nagged to clarify some things over the years in that doc | 20:27 |
| *** mfedosin has joined #openstack-glance | 20:27 | |
| sigmavirus | because some people use it as a book that one can never violate and bash each other's heads in with it | 20:28 |
| sigmavirus | so some silly clarifications have landed | 20:28 |
| nikhil | (don't doubt it) | 20:29 |
| *** mvk has joined #openstack-glance | 20:38 | |
| *** TravT has joined #openstack-glance | 20:38 | |
| *** TravT has quit IRC | 20:39 | |
| rosmaita | sigmavirus: i forgot to regenerate the config files | 20:40 |
| *** harlowja has quit IRC | 21:00 | |
| *** _ducttape_ has joined #openstack-glance | 21:06 | |
| *** ducttape_ has quit IRC | 21:10 | |
| *** mfedosin has quit IRC | 21:14 | |
| *** catintheroof has quit IRC | 21:14 | |
| *** catintheroof has joined #openstack-glance | 21:15 | |
| sigmavirus | rosmaita: poop | 21:19 |
| *** catintheroof has quit IRC | 21:19 | |
| *** _ducttape_ has quit IRC | 21:23 | |
| *** ducttape_ has joined #openstack-glance | 21:24 | |
| rosmaita | sigmavirus: ploop | 21:43 |
| rosmaita | release notes still haven't merged | 21:43 |
| stevelle | good call on the use of success tracker sigmavirus | 21:56 |
| stevelle | I forget abt it | 21:56 |
| *** flwang has left #openstack-glance | 22:03 | |
| dhellmann | sigmavirus, rosmaita : do you have any release blockers in progress that should hold up the glance rc1 tag? | 22:03 |
| dhellmann | it would be better to wait than to rush rc1 and have an rc2 follow on quickly after | 22:04 |
| dhellmann | that tends to train users to ignore release candidates | 22:04 |
| rosmaita | dhellmann: yes, i think i need to merge a config file update | 22:04 |
| dhellmann | rosmaita : ok, maybe mark https://review.openstack.org/#/c/428399/ WIP until you're ready? | 22:04 |
| dhellmann | oh, I see your -1 now | 22:04 |
| dhellmann | my dashboard hides the -1 when there is a +2 :-/ | 22:05 |
| rosmaita | yeah, i don't have workflow powers | 22:05 |
| dhellmann | np, I'll remove my +2 for now | 22:05 |
| rosmaita | that change you're waiting on still hasn't merged, not sure what's up wtih that | 22:05 |
| rosmaita | dhellmann: thanks | 22:05 |
| rosmaita | i will update that patch soon as i have a new hash | 22:06 |
| *** harlowja has joined #openstack-glance | 22:25 | |
| *** ducttape_ has quit IRC | 22:26 | |
| *** ducttape_ has joined #openstack-glance | 22:31 | |
| *** harlowja has quit IRC | 22:32 | |
| *** harlowja has joined #openstack-glance | 22:33 | |
| *** ducttape_ has quit IRC | 22:43 | |
| *** mtanino has joined #openstack-glance | 22:51 | |
| -openstackstatus- NOTICE: Restarting gerrit due to performance problems | 22:51 | |
| * stevelle is glad glance is out of the gate right now | 22:51 | |
| rosmaita | actually, release notes are still in there | 22:51 |
| stevelle | ah, thought we had that through | 22:52 |
| rosmaita | no, and it looks like that thing hemanthm noticed yesterday when things are going through twice | 22:53 |
| *** burgerk_ has joined #openstack-glance | 23:00 | |
| stevelle | hmm, well it looks like the job is done, acting like the logstack queue having trouble or something | 23:01 |
| *** burgerk has quit IRC | 23:03 | |
| *** burgerk_ has quit IRC | 23:04 | |
| *** tshefi has quit IRC | 23:05 | |
| openstackgerrit | Merged openstack/glance master: Alembic migrations/rolling upgrades release note https://review.openstack.org/427971 | 23:32 |
| openstackgerrit | Brian Rosmaita proposed openstack/glance master: Refresh config files for Ocata RC-1 https://review.openstack.org/428485 | 23:35 |
| openstackgerrit | Brian Rosmaita proposed openstack/glance master: Refresh config files for Ocata RC-1 https://review.openstack.org/428485 | 23:40 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!