*** mtanino has quit IRC | 00:07 | |
*** Sukhdev has quit IRC | 01:06 | |
*** jamielennox has quit IRC | 01:08 | |
*** jamielennox has joined #openstack-glance | 01:15 | |
*** harlowja has quit IRC | 01:19 | |
*** cdelatte has quit IRC | 01:27 | |
*** zhurong has joined #openstack-glance | 01:38 | |
*** markvoelker has quit IRC | 02:03 | |
*** markvoelker has joined #openstack-glance | 02:06 | |
*** mtanino_ has joined #openstack-glance | 02:09 | |
*** jamielennox has quit IRC | 02:17 | |
*** jamielennox has joined #openstack-glance | 02:24 | |
*** dillaman has joined #openstack-glance | 02:29 | |
*** zhurong has quit IRC | 03:13 | |
*** harlowja has joined #openstack-glance | 03:31 | |
*** udesale has joined #openstack-glance | 03:36 | |
*** mtanino_ has quit IRC | 03:53 | |
*** nicolasbock has joined #openstack-glance | 04:07 | |
*** hoonetorg has joined #openstack-glance | 04:26 | |
*** links has joined #openstack-glance | 04:33 | |
*** zhurong has joined #openstack-glance | 04:39 | |
*** harlowja has quit IRC | 04:52 | |
*** c06 has joined #openstack-glance | 04:59 | |
c06 | hi all | 04:59 |
---|---|---|
c06 | need suggestions on this one -> https://bugs.launchpad.net/glance/+bug/1706068 | 04:59 |
openstack | Launchpad bug 1706068 in Glance "(docker) uploaded and downloaded image having different image name" [Undecided,New] | 04:59 |
c06 | give some suggestions so that i can work on this one.. | 05:08 |
*** abhishekk has joined #openstack-glance | 05:11 | |
*** groen692 has joined #openstack-glance | 05:14 | |
*** pdeore has joined #openstack-glance | 05:23 | |
*** jdwidari has joined #openstack-glance | 05:36 | |
*** jdwidari has quit IRC | 05:36 | |
*** udesale__ has joined #openstack-glance | 05:47 | |
*** udesale has quit IRC | 05:50 | |
*** ratailor has joined #openstack-glance | 05:58 | |
*** udesale has joined #openstack-glance | 06:12 | |
*** udesale__ has quit IRC | 06:14 | |
*** aavraham has joined #openstack-glance | 06:27 | |
*** zhurong has quit IRC | 06:33 | |
*** tshefi has joined #openstack-glance | 07:09 | |
*** rcernin has joined #openstack-glance | 07:13 | |
*** namnh has joined #openstack-glance | 07:27 | |
*** obre has quit IRC | 07:36 | |
*** obre has joined #openstack-glance | 07:36 | |
*** abhishekk is now known as abhishekk|away | 07:48 | |
*** jaosorior has joined #openstack-glance | 07:52 | |
*** testuro has joined #openstack-glance | 08:07 | |
*** e0ne has joined #openstack-glance | 08:11 | |
*** dpawlik has quit IRC | 08:32 | |
*** danpawlik has joined #openstack-glance | 08:34 | |
*** e0ne has quit IRC | 08:40 | |
*** e0ne has joined #openstack-glance | 08:42 | |
*** abhishekk|away is now known as abhishekk | 08:43 | |
*** e0ne has quit IRC | 08:54 | |
*** e0ne has joined #openstack-glance | 08:54 | |
*** c06 has left #openstack-glance | 08:54 | |
*** mvk has quit IRC | 09:04 | |
openstackgerrit | Artem Tiumentcev proposed openstack/glance-specs master: [SPEC] Add basic quotas https://review.openstack.org/487777 | 09:09 |
*** udesale has quit IRC | 09:14 | |
openstackgerrit | Artem Tiumentcev proposed openstack/glance master: Add image quotas https://review.openstack.org/484361 | 09:17 |
openstackgerrit | Artem Tiumentcev proposed openstack/python-glanceclient master: Add client commands for quotas https://review.openstack.org/484362 | 09:24 |
*** c06 has joined #openstack-glance | 09:25 | |
c06 | anyone on.?? | 09:26 |
*** bhagyashris has quit IRC | 09:29 | |
kairat | c06, i fell your bug may be closed as invalid | 09:29 |
kairat | glance do not update image containment | 09:30 |
c06 | y any reason | 09:30 |
kairat | image it is name in glance | 09:30 |
kairat | and not related to some files in tar | 09:30 |
kairat | IIUC you want some files inside tar to be updated | 09:31 |
kairat | c06, do i unserstand correctly& | 09:31 |
c06 | kairat: yes but small change | 09:31 |
kairat | i think it wouldn't be small | 09:32 |
c06 | i didnt want the file to be updated. i am uploading one docker cirros image as updated-cirros to glance | 09:32 |
*** e0ne has quit IRC | 09:32 | |
kairat | so | 09:33 |
kairat | what do you want then? | 09:33 |
c06 | after downloading and importing to docker, still docker is showing the image name as cirros | 09:33 |
c06 | not as updated-cirros(glance_image_name) | 09:33 |
kairat | it requires update of tar. file, does it? | 09:34 |
kairat | at the current moment name of glance image and docker image are not related, iirc, sorry | 09:35 |
c06 | yes that one i downloaded from glance | 09:35 |
kairat | glance just stores bytes under some name | 09:35 |
kairat | and return bytes under some name | 09:36 |
c06 | oops | 09:36 |
c06 | if you want i can make some steps to elaborate the issue | 09:36 |
c06 | just it will take 5 mins | 09:37 |
*** e0ne has joined #openstack-glance | 09:37 | |
*** mvk has joined #openstack-glance | 09:44 | |
c06 | kairat: http://paste.openstack.org/show/616681/ | 09:45 |
c06 | hope it will give some idea regarding the issue | 09:50 |
*** masber has quit IRC | 09:55 | |
c06 | kairat: does it valid or not.? | 10:08 |
kairat | so imagine you uploaded file to google disk | 10:09 |
kairat | and changed name in google disk | 10:09 |
kairat | do you expect some file content to be changed? | 10:09 |
kairat | i understand what you want and there were some features that potentially can support your cases | 10:10 |
kairat | nut none of them are stable iiuc | 10:10 |
c06 | kairat: reasonable example | 10:11 |
c06 | no issue i will simply try | 10:11 |
kairat | you can try to look into image import refactoring | 10:12 |
kairat | or tasks(which are deprecated and may be deleted soon) | 10:12 |
kairat | hth | 10:12 |
c06 | refactoring also they will depercate.? or only tasks | 10:13 |
*** udesale has joined #openstack-glance | 10:17 | |
openstackgerrit | Merged openstack/glance master: Updated from global requirements https://review.openstack.org/487462 | 10:19 |
*** abhishekk has quit IRC | 10:36 | |
*** abhishekk has joined #openstack-glance | 10:47 | |
*** smatzek has joined #openstack-glance | 10:57 | |
*** testuro has quit IRC | 11:14 | |
*** rosmaita has joined #openstack-glance | 11:16 | |
*** namnh has quit IRC | 11:20 | |
kairat | c06, no | 11:30 |
kairat | refactoring won't | 11:30 |
kairat | but i am not an expert in this feature | 11:30 |
kairat | tbh | 11:30 |
c06 | ok ty kairat .. :) i will check that one.. | 11:31 |
kairat | you re welcome | 11:31 |
c06 | atleast you responded ty dude.. :) | 11:31 |
c06 | gave some idea and i am cleared ty .:) | 11:31 |
*** pdeore_ has joined #openstack-glance | 11:54 | |
*** pdeore has quit IRC | 11:56 | |
*** jokke_ has joined #openstack-glance | 11:58 | |
*** catintheroof has joined #openstack-glance | 12:11 | |
*** abhishekk has quit IRC | 12:20 | |
*** bhagyashris has joined #openstack-glance | 12:22 | |
jokke_ | mfedosin, flaper87, rosmaita: if you have any cycles we have 3 patches still pending before requesting the client release. Listed in the meeting agenda | 12:27 |
jokke_ | Also anything we _must_ get in before requesting P-3 for glance? | 12:27 |
rosmaita | i don't think so ... your /info router change was merged yesterday, i think? | 12:29 |
jokke_ | yes | 12:29 |
rosmaita | oh, there was the wsgi release note | 12:30 |
rosmaita | https://review.openstack.org/#/c/485913/ | 12:30 |
jokke_ | that, yes lets deal with that | 12:31 |
*** c06 has left #openstack-glance | 12:47 | |
*** pdeore__ has joined #openstack-glance | 12:49 | |
*** pdeore_ has quit IRC | 12:51 | |
*** links has quit IRC | 12:52 | |
openstackgerrit | Erno Kuvaja proposed openstack/python-glanceclient master: Add image import features to client https://review.openstack.org/486630 | 12:54 |
*** ratailor has quit IRC | 12:56 | |
*** ratailor has joined #openstack-glance | 12:56 | |
*** ratailor has quit IRC | 12:57 | |
*** gcb has quit IRC | 13:02 | |
*** leni1 has joined #openstack-glance | 13:02 | |
*** lucasxu has joined #openstack-glance | 13:03 | |
*** gcb has joined #openstack-glance | 13:04 | |
openstackgerrit | Erno Kuvaja proposed openstack/python-glanceclient master: Add image import features to client https://review.openstack.org/486630 | 13:10 |
*** abhishekk has joined #openstack-glance | 13:37 | |
*** jdillaman has quit IRC | 13:38 | |
*** efried_zzz is now known as efried | 13:40 | |
openstackgerrit | Brian Rosmaita proposed openstack/python-glanceclient master: Add release note for Pike https://review.openstack.org/487269 | 13:44 |
*** pdeore__ has quit IRC | 13:49 | |
*** mtanino_ has joined #openstack-glance | 13:49 | |
*** leni1 has left #openstack-glance | 13:49 | |
*** udesale has quit IRC | 13:55 | |
rosmaita | Courtesy meeting reminder on #openstack-meeting-4: ativelkov, cpallares, flaper87, flwang1, hemanthm, jokke_, kragniz, lakshmiS, mclaren, mfedosin, nikhil_k, Nikolay_St, Olena, pennerc, rosmaita, sigmavirus24, sabari, TravT, ajayaa, GB21, bpoulos, harshs, abhishekk, bunting, dshakhray, wxy, dhellmann, kairat, aavraham, alex_bash, smcginnis | 13:59 |
*** mvk has quit IRC | 14:06 | |
*** aavraham has quit IRC | 14:17 | |
*** aavraham has joined #openstack-glance | 14:18 | |
*** lucasxu has quit IRC | 14:30 | |
*** lucasxu has joined #openstack-glance | 14:32 | |
*** tshefi has quit IRC | 14:55 | |
*** abhishekk has quit IRC | 14:56 | |
*** lucasxu has quit IRC | 14:59 | |
*** lucasxu has joined #openstack-glance | 15:02 | |
*** rcernin has quit IRC | 15:03 | |
*** links has joined #openstack-glance | 15:04 | |
*** links has quit IRC | 15:07 | |
openstackgerrit | Merged openstack/glance master: Add release note for wsgi containerization https://review.openstack.org/485913 | 15:08 |
*** gyee has joined #openstack-glance | 15:35 | |
*** aavraham has left #openstack-glance | 15:41 | |
openstackgerrit | Erno Kuvaja proposed openstack/python-glanceclient master: Add missing docstring https://review.openstack.org/487911 | 15:45 |
*** e0ne has quit IRC | 15:47 | |
openstackgerrit | Brian Rosmaita proposed openstack/python-glanceclient master: Add documentation for image import commands https://review.openstack.org/487913 | 15:50 |
openstackgerrit | Brian Rosmaita proposed openstack/python-glanceclient master: Add documentation for image import commands https://review.openstack.org/487913 | 15:52 |
openstackgerrit | Brian Rosmaita proposed openstack/python-glanceclient master: Add release note for Pike https://review.openstack.org/487269 | 16:03 |
*** lucasxu has quit IRC | 16:06 | |
openstackgerrit | Brian Rosmaita proposed openstack/python-glanceclient master: Add documentation for image import commands https://review.openstack.org/487913 | 16:08 |
openstackgerrit | Merged openstack/python-glanceclient master: Update glanceclient version ref https://review.openstack.org/486824 | 16:08 |
*** abhishekk has joined #openstack-glance | 16:14 | |
openstackgerrit | Cyril Roelandt proposed openstack/glance master: Add a default rootwrap.conf file. https://review.openstack.org/485244 | 16:54 |
*** hyakuhei has quit IRC | 17:02 | |
*** hyakuhei has joined #openstack-glance | 17:02 | |
*** hyakuhei has quit IRC | 17:02 | |
*** hyakuhei has joined #openstack-glance | 17:02 | |
openstackgerrit | Erno Kuvaja proposed openstack/python-glanceclient master: Add image import features to client https://review.openstack.org/486630 | 17:06 |
*** harlowja has joined #openstack-glance | 17:09 | |
*** mvk has joined #openstack-glance | 17:13 | |
*** rcernin has joined #openstack-glance | 17:16 | |
*** groen692 has quit IRC | 17:23 | |
jokke_ | abhishekk, rosmaita: ok lets continue here | 17:31 |
abhishekk | hi | 17:31 |
rosmaita | hello | 17:32 |
rosmaita | looks like abhishekk found a problem in the client import stuff | 17:33 |
abhishekk | yes | 17:33 |
abhishekk | IMO these changes required, http://paste.openstack.org/show/616758/ | 17:34 |
abhishekk | for example right now, https://review.openstack.org/#/c/486630/9/glanceclient/v2/images.py@239 returns resp, body but https://github.com/openstack/python-glanceclient/blob/master/glanceclient/common/utils.py#L482 requires body, resp | 17:35 |
rosmaita | i'm kind of crippled atm by lack of test environment | 17:36 |
rosmaita | which is not a very helpful comment | 17:36 |
rosmaita | if it's not too big a change, let's do it | 17:37 |
rosmaita | i think it's getting pretty late where abhishekk is | 17:38 |
abhishekk | not a issue, I will be still around | 17:38 |
abhishekk | :) | 17:38 |
jokke_ | I have the change ready | 17:41 |
jokke_ | what a C*nty way of doing that wrapper | 17:41 |
rosmaita | well, i must admit, in glance everything is wrapped into something, and some wrappings make more sense than otehrs | 17:42 |
openstackgerrit | Erno Kuvaja proposed openstack/python-glanceclient master: Add image import features to client https://review.openstack.org/486630 | 17:43 |
openstackgerrit | Erno Kuvaja proposed openstack/python-glanceclient master: Add missing docstring https://review.openstack.org/487911 | 17:43 |
abhishekk | unfortunately that wrapper was added by me after discussion with crossproject team :( | 17:43 |
abhishekk | sorry for that | 17:44 |
rosmaita | :) | 17:44 |
rosmaita | you were definitely the right person to be reviewing this code, then! | 17:45 |
jokke_ | there is nothing wrong with wrappers, but expecting the returns in wrong order and just swapping them around everywhere instead of dealing with it inside the wrapper is bit of @~£$%&^*$^$ | 17:45 |
jokke_ | ;) | 17:45 |
jokke_ | abhishekk: _and_ the blame is not on you, it's on Ravi :P | 17:46 |
abhishekk | jokke_: :D | 17:46 |
jokke_ | git blame at least | 17:46 |
abhishekk | jokke_: should I publish the edit on the patch? | 17:46 |
jokke_ | abhishekk: which one? | 17:47 |
jokke_ | did i mess up something else there? | 17:48 |
abhishekk | https://review.openstack.org/486630 | 17:48 |
abhishekk | on this one | 17:48 |
abhishekk | yes | 17:48 |
jokke_ | abhishekk: ahh | 17:48 |
abhishekk | instead of return (resp,body), resp just return body, resp for import-info and image-import | 17:49 |
abhishekk | in stage method you are calling upload so just return self.uplpad will be fine as upload is already returning (resp,body), resp | 17:50 |
jokke_ | ohh | 17:50 |
jokke_ | actually don't let me do the change so you can approve it :P | 17:51 |
abhishekk | and in shell.py https://review.openstack.org/#/c/486630/9..10/glanceclient/v2/shell.py@322 requires do_import_info(gc, args) | 17:51 |
abhishekk | https://review.openstack.org/#/c/486630/10/glanceclient/v2/shell.py@834 in _get_import_info, just add return gc.images.get_import_info() | 17:52 |
jokke_ | why? | 17:53 |
jokke_ | is there any reason why we want that response up to the do_* ? | 17:54 |
abhishekk | no | 17:55 |
abhishekk | but now we are just returning RequestIdProxy object and not a tuple | 17:56 |
openstackgerrit | Erno Kuvaja proposed openstack/python-glanceclient master: Add image import features to client https://review.openstack.org/486630 | 17:56 |
openstackgerrit | Erno Kuvaja proposed openstack/python-glanceclient master: Add missing docstring https://review.openstack.org/487911 | 17:56 |
abhishekk | if you do body, resp = gc.images.get_import_info() it will say need one or more values to unpack | 17:57 |
abhishekk | https://github.com/openstack/python-glanceclient/blob/master/glanceclient/common/utils.py#L545, it just returning single value and not tuple | 17:58 |
abhishekk | sorry for the trouble | 17:59 |
jokke_ | so the images.get_import_info should have returned (body, resp), resp | 18:00 |
abhishekk | even that should have worked but that is not as per design | 18:00 |
abhishekk | if we are expecting a return then that should be wrapped with response in a wrapper | 18:01 |
jokke_ | hmm-m so the print_dict won't work because te return is wrapper object not a dict | 18:01 |
abhishekk | and if nothing was returned for example in case of delete earlier nothing was returned so it is decided to return tuple with response | 18:02 |
abhishekk | no if you do the change what i suggested now then print_dict will work | 18:03 |
jokke_ | so need to usewill it work if I throw that whole _get_import_info out? | 18:04 |
jokke_ | will it work if I throw that whole _get_import_info out? | 18:04 |
abhishekk | http://wrapt.readthedocs.io/en/latest/wrappers.html#object-proxy | 18:04 |
jokke_ | yes, it should ... so lets forget tht whole function then as it just became useless | 18:05 |
abhishekk | yes then you should call gc.images.get_import_info() whereever required | 18:06 |
openstackgerrit | Erno Kuvaja proposed openstack/python-glanceclient master: Add image import features to client https://review.openstack.org/486630 | 18:07 |
smcginnis | What's the reason for changing images.py to add temporary variables? | 18:09 |
smcginnis | Oh, nevermind. I see now. | 18:09 |
abhishekk | sounds good now | 18:10 |
jokke_ | smcginnis: took me about an hour to understand ;) | 18:11 |
jokke_ | and 15 revs | 18:11 |
smcginnis | jokke_: Hah! :) | 18:11 |
abhishekk | thank you for bearing with me | 18:12 |
jokke_ | abhishekk: nonono, thank you | 18:12 |
abhishekk | how much time is left for release? | 18:12 |
rosmaita | that's some good reviewing, abhishekk | 18:12 |
abhishekk | thank you | 18:13 |
jokke_ | abhishekk: quess who will be my trusted client reviewer from now on ... and all the bugs assignee ;) | 18:13 |
abhishekk | :D | 18:14 |
smcginnis | Gate queue looks like it's taking a little over 2 hours right now. So better not wait too much longer. | 18:18 |
jokke_ | abhishekk: you still around? | 18:32 |
abhishekk | yes | 18:32 |
jokke_ | left you the honours for +A the relnotes and documentations | 18:33 |
rosmaita | those are the only two patches outstanding | 18:33 |
rosmaita | we're closing in on a release! | 18:34 |
abhishekk | ok | 18:34 |
rosmaita | jokke_: will you have time to put the release patch together, or do you want me to do it? | 18:34 |
jokke_ | I'll do it once those has merged | 18:35 |
jokke_ | it's not like I have life anyways :P | 18:36 |
abhishekk | my connection is breaking in between its taking lots of time to load the patch | 18:37 |
jokke_ | I can ninja them if it's easier for you | 18:38 |
abhishekk | jokke_: please do the needful | 18:39 |
jokke_ | ok, then we just wait the gate to finish and request tag :D | 18:40 |
jokke_ | Thanks guys! | 18:40 |
rosmaita | thanks everyone! | 18:40 |
jokke_ | I feel almost like ready to start my holidays | 18:41 |
*** rosmaita has quit IRC | 18:42 | |
*** abhishekk is now known as abhishekk|away | 19:00 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance_store master: Updated from global requirements https://review.openstack.org/487996 | 19:09 |
*** abhishekk|away has quit IRC | 19:27 | |
*** nicolasbock has quit IRC | 19:48 | |
*** e0ne has joined #openstack-glance | 19:51 | |
openstackgerrit | Merged openstack/python-glanceclient master: Add release note for Pike https://review.openstack.org/487269 | 20:12 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-glanceclient master: Updated from global requirements https://review.openstack.org/488114 | 20:14 |
*** smatzek has quit IRC | 20:15 | |
*** e0ne has quit IRC | 20:17 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance master: Updated from global requirements https://review.openstack.org/487995 | 20:21 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance_store master: Updated from global requirements https://review.openstack.org/487996 | 20:21 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-glanceclient master: Updated from global requirements https://review.openstack.org/488114 | 20:32 |
*** rajathagasthya has joined #openstack-glance | 21:02 | |
openstackgerrit | Merged openstack/python-glanceclient master: Add image import features to client https://review.openstack.org/486630 | 21:04 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-glanceclient master: Updated from global requirements https://review.openstack.org/488114 | 21:07 |
openstackgerrit | Brian Rosmaita proposed openstack/python-glanceclient master: Add missing docstring https://review.openstack.org/487911 | 21:09 |
*** rosmaita has joined #openstack-glance | 21:10 | |
*** e0ne has joined #openstack-glance | 21:37 | |
*** mtanino_ has quit IRC | 22:06 | |
*** e0ne has quit IRC | 22:09 | |
*** rcernin has quit IRC | 22:26 | |
*** catintheroof has quit IRC | 22:27 | |
*** dalgaaf has quit IRC | 22:30 | |
*** dalgaaf has joined #openstack-glance | 22:30 | |
*** openstack has joined #openstack-glance | 22:42 | |
*** fnordahl has quit IRC | 22:42 | |
*** fnordahl_ has joined #openstack-glance | 22:42 | |
*** hemanthm has joined #openstack-glance | 22:42 | |
*** Daviey_ has quit IRC | 22:42 | |
*** jmccrory has quit IRC | 22:42 | |
*** hemanthm_ has quit IRC | 22:42 | |
*** jmccrory has joined #openstack-glance | 22:43 | |
*** oomichi has quit IRC | 22:45 | |
*** oomichi has joined #openstack-glance | 22:47 | |
*** aavraham has joined #openstack-glance | 22:53 | |
*** rosmaita has left #openstack-glance | 22:58 | |
*** aavraham has quit IRC | 23:34 | |
openstackgerrit | Merged openstack/python-glanceclient master: Add missing docstring https://review.openstack.org/487911 | 23:38 |
*** catintheroof has joined #openstack-glance | 23:52 | |
*** rajathagasthya has quit IRC | 23:57 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-glanceclient master: Updated from global requirements https://review.openstack.org/488114 | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!