| *** chlong has joined #openstack-glance | 00:20 | |
| *** gcb has joined #openstack-glance | 00:30 | |
| *** Sukhdev has quit IRC | 01:12 | |
| *** e0ne has joined #openstack-glance | 01:58 | |
| *** e0ne has quit IRC | 02:02 | |
| *** chlong has quit IRC | 02:03 | |
| -openstackstatus- NOTICE: Gerrit is being restarted to feed its insatiable memory appetite | 02:40 | |
| *** gcb has quit IRC | 03:53 | |
| *** e0ne has joined #openstack-glance | 04:00 | |
| *** e0ne has quit IRC | 04:04 | |
| *** abhishekk has joined #openstack-glance | 04:13 | |
| *** udesale has joined #openstack-glance | 04:16 | |
| *** pdeore has joined #openstack-glance | 04:27 | |
| *** gyee has quit IRC | 04:58 | |
| *** groen692 has joined #openstack-glance | 05:23 | |
| *** zhurong has joined #openstack-glance | 05:24 | |
| *** lbragstad has quit IRC | 05:44 | |
| *** ratailor has joined #openstack-glance | 05:47 | |
| *** aavraham has joined #openstack-glance | 05:57 | |
| *** udesale has quit IRC | 05:59 | |
| *** udesale has joined #openstack-glance | 06:00 | |
| *** dalgaaf has quit IRC | 06:05 | |
| *** dhellmann has quit IRC | 06:05 | |
| *** mancdaz has quit IRC | 06:05 | |
| *** harlowja has quit IRC | 06:05 | |
| *** _d34dh0r53_ has quit IRC | 06:05 | |
| *** jmccrory has quit IRC | 06:05 | |
| *** fnordahl has quit IRC | 06:05 | |
| *** amito-infinidat has quit IRC | 06:05 | |
| *** melwitt has quit IRC | 06:05 | |
| *** melwitt has joined #openstack-glance | 06:05 | |
| *** d34dh0r53 has joined #openstack-glance | 06:05 | |
| *** dhellmann has joined #openstack-glance | 06:05 | |
| *** fnordahl has joined #openstack-glance | 06:05 | |
| *** melwitt is now known as Guest36641 | 06:06 | |
| *** amito-infinidat has joined #openstack-glance | 06:07 | |
| *** dalgaaf has joined #openstack-glance | 06:10 | |
| *** mancdaz has joined #openstack-glance | 06:10 | |
| *** jmccrory has joined #openstack-glance | 06:10 | |
| *** tshefi has quit IRC | 06:34 | |
| *** mosulica has joined #openstack-glance | 06:45 | |
| *** mosulica has quit IRC | 06:53 | |
| *** zhurong has quit IRC | 06:54 | |
| *** mosulica has joined #openstack-glance | 06:54 | |
| openstackgerrit | junbo.li proposed openstack/glance master: Switch base to Pike in link address https://review.openstack.org/505070 | 06:56 |
|---|---|---|
| *** rcernin has joined #openstack-glance | 07:18 | |
| *** zhurong has joined #openstack-glance | 07:20 | |
| -openstackstatus- NOTICE: Post jobs are not executed currently, do not tag any releases | 07:21 | |
| *** ChanServ changes topic to "Post jobs are not executed currently, do not tag any releases" | 07:21 | |
| *** pcaruana has joined #openstack-glance | 07:22 | |
| *** tesseract has joined #openstack-glance | 07:24 | |
| openstackgerrit | junbo.li proposed openstack/glance master: [Doc] fix output license info in configure doc https://review.openstack.org/505087 | 07:29 |
| *** tshefi has joined #openstack-glance | 07:29 | |
| openstackgerrit | junbo.li proposed openstack/glance master: [Doc] fix output license info in configure doc https://review.openstack.org/505087 | 07:31 |
| *** mingyu has joined #openstack-glance | 07:42 | |
| *** aarefiev_ptg is now known as aarefiev | 07:47 | |
| *** d0ugal has quit IRC | 08:01 | |
| *** d0ugal has joined #openstack-glance | 08:08 | |
| *** mvk has quit IRC | 08:21 | |
| *** zhurong has quit IRC | 08:24 | |
| *** mvk has joined #openstack-glance | 08:50 | |
| *** udesale has quit IRC | 08:50 | |
| *** udesale has joined #openstack-glance | 09:03 | |
| openstackgerrit | Eric Xie proposed openstack/glance master: Fix missing some content of glance database creation. https://review.openstack.org/505123 | 09:03 |
| *** udesale has quit IRC | 09:05 | |
| *** udesale has joined #openstack-glance | 09:05 | |
| *** zhurong has joined #openstack-glance | 09:05 | |
| *** arc0 has joined #openstack-glance | 09:06 | |
| *** udesale__ has joined #openstack-glance | 09:10 | |
| *** udesale has quit IRC | 09:12 | |
| *** e0ne has joined #openstack-glance | 09:24 | |
| *** mvk has quit IRC | 09:32 | |
| *** szahers has joined #openstack-glance | 09:44 | |
| *** dalgaaf has quit IRC | 09:44 | |
| *** mvk has joined #openstack-glance | 09:45 | |
| *** dalgaaf has joined #openstack-glance | 09:46 | |
| jokke_ | abhishekk: you got home alive? | 09:57 |
| abhishekk | jokke_: yes :D | 09:57 |
| jokke_ | \\o \o/ o// o/7 | 09:57 |
| abhishekk | just caught with fever | 09:57 |
| jokke_ | oh you too | 09:57 |
| abhishekk | you as well ? | 09:57 |
| jokke_ | my throat is like sandpaper and I've been caughing like crazy last two days | 09:57 |
| abhishekk | ohh take care | 09:58 |
| jokke_ | so today working on power of Paracetamol and Guaifesin infused into a hot drink | 09:58 |
| jokke_ | but I was looking the spec you wrote last week | 09:59 |
| abhishekk | jokke_: I guess you have lot to say on it | 10:00 |
| jokke_ | not that much | 10:00 |
| jokke_ | couple of notes | 10:00 |
| abhishekk | shoot, I will modify it | 10:01 |
| jokke_ | and actually more of a question what do you think about the config approach | 10:01 |
| abhishekk | config option is added just incase in some deployments operator doesn't want to inject those properties to the image | 10:01 |
| jokke_ | so I'm not sure we want to implement the feature twice. I think we should just stick with the interoperable image import and not add these optional features to the old workflow | 10:01 |
| jokke_ | so that we can just utilize the taskflow to get these things done | 10:02 |
| abhishekk | ok | 10:02 |
| jokke_ | that said, what do you think of having separate config for those instead of adding all that stuff into the -api.conf? | 10:02 |
| jokke_ | so if we implement the metadata injection, possibly the image conversion + what ever comes in the future, we would have own config for all the stuff thta optionally happens during the import taskflow? | 10:03 |
| jokke_ | and the -api.conf would have just option to specify which tasks are included and the config needs for those tasks would be found in the new config file | 10:04 |
| jokke_ | just an idea that came to my mind when looking the spec | 10:05 |
| jokke_ | what do you think? | 10:05 |
| abhishekk | ok, sounds good, but whats benefit over new file? we can have new section as well right? | 10:06 |
| jokke_ | well glance-api-conf is currently >4500 lines | 10:07 |
| abhishekk | only benfit I can see here is we can separate out the interoperable config options and if someone doesn't want to use it then they will not provide it | 10:07 |
| abhishekk | in that case yes | 10:07 |
| jokke_ | I can see all these optional tasks coming over time having lots of things to configure and I think the -api.conf is already crazy mess as it is | 10:07 |
| jokke_ | and that what you just said | 10:08 |
| abhishekk | sounds good, please add your suggestion on the specs, I will modify it accordingly | 10:08 |
| *** nicolasbock has joined #openstack-glance | 10:09 | |
| abhishekk | so in glance-api.conf we need one config option say task_config_path/task_config_file_name right? | 10:09 |
| jokke_ | So I think that's one thing we need to decide. I don't think the hooks were defined how we include those optional tasks (their existence should be in the original spec, but not detailed implementation) | 10:12 |
| jokke_ | So we need to figure out how we do that smart | 10:12 |
| jokke_ | I don't want it to be too liberal nor too messy | 10:13 |
| abhishekk | ok | 10:13 |
| jokke_ | so I think we need to figure out the config format and the mechanism how the additional tasks are introduced | 10:13 |
| abhishekk | yes | 10:13 |
| abhishekk | jokke_: do you have something in mind? | 10:14 |
| abhishekk | i guess you want something similarto mistral workflow? | 10:15 |
| jokke_ | no | 10:15 |
| jokke_ | I was actually looking mistral as a option to replace taskflow for us, but it does not make any sense for us | 10:16 |
| jokke_ | like the taskflow use case is pretty much exactly what we need | 10:16 |
| jokke_ | just need to figure out how we do that deployment specific extendability to it | 10:16 |
| abhishekk | jokke_: right, so dynamicaly build the flow based on inputs? | 10:17 |
| jokke_ | well that's kind of what we don't want to do. So we don't want to have different workflows available based on the end user call, we do want it to be as transparent to the end user as possible giving the operator possibility to specify what the deployed node does when it gets the call | 10:19 |
| jokke_ | hopefully that makes sense | 10:19 |
| abhishekk | yes, let me think how we can achieve the same | 10:20 |
| jokke_ | so we do not want to let user x to specify what tasks are ran when they call import | 10:20 |
| abhishekk | ok | 10:21 |
| jokke_ | Feel free to ask me to clarify any points if they don't make sense | 10:28 |
| jokke_ | I posted my comments into the review | 10:29 |
| *** udesale__ has quit IRC | 10:32 | |
| *** udesale has joined #openstack-glance | 10:32 | |
| abhishekk | jokke_ yes, I will go through it | 10:33 |
| *** mingyu has quit IRC | 10:50 | |
| *** udesale has quit IRC | 10:54 | |
| *** udesale has joined #openstack-glance | 10:55 | |
| openstackgerrit | Erno Kuvaja proposed openstack/glance master: Align default policy in code with the one in conf https://review.openstack.org/503803 | 10:57 |
| abhishekk | jokke_: you need to make change here as well https://review.openstack.org/#/c/503803/2/glance/tests/unit/test_policy.py@191 | 11:04 |
| jokke_ | oh crap, thanks ... wanted to see it as my test env is somehow bonkers again (just can't run the tests locally atm) | 11:05 |
| abhishekk | and wait, | 11:05 |
| abhishekk | if you pass role admin, it will not raise forbidden right? | 11:06 |
| abhishekk | so better remove those 3 lines | 11:06 |
| abhishekk | 209 to 212 and 191 to 194 | 11:07 |
| jokke_ | so on line 209 not admin but on line 191 admin | 11:08 |
| jokke_ | actually those tests should have resulted exactly right ... they should have raised forbidden when the policy is admin | 11:09 |
| abhishekk | jokke_: so actual forbidden is raised at line 210 while enforcing get_image | 11:12 |
| abhishekk | enforcer.enforce(context, 'get_image', {}) it will return Forbidden now | 11:12 |
| jokke_ | as it should and that's what we're asserting on the following line | 11:15 |
| jokke_ | oh crap | 11:16 |
| jokke_ | sorry my bad | 11:16 |
| jokke_ | yes ... need to clean out those | 11:16 |
| openstackgerrit | Erno Kuvaja proposed openstack/glance master: Align default policy in code with the one in conf https://review.openstack.org/503803 | 11:19 |
| jokke_ | now it should be right | 11:19 |
| abhishekk | jokke_: https://etherpad.openstack.org/p/glance-image-import-tests | 11:19 |
| abhishekk | basic tests for coverage, I will add more as and when found | 11:20 |
| jokke_ | abhishekk: man you're a rock star! | 11:21 |
| abhishekk | jokke_: :D | 11:23 |
| *** pdeore has quit IRC | 11:27 | |
| *** aavraham has quit IRC | 11:29 | |
| *** mingyu has joined #openstack-glance | 11:34 | |
| *** zhurong has quit IRC | 11:49 | |
| openstackgerrit | Merged openstack/glance_store master: Updated from global requirements https://review.openstack.org/504637 | 12:07 |
| *** lucasxu has joined #openstack-glance | 12:15 | |
| openstackgerrit | Merged openstack/glance master: Updated from global requirements https://review.openstack.org/504636 | 12:16 |
| *** MVenesio has joined #openstack-glance | 12:19 | |
| *** abhishekk has quit IRC | 12:33 | |
| *** catintheroof has joined #openstack-glance | 12:49 | |
| *** szahers has quit IRC | 12:54 | |
| *** ratailor has quit IRC | 12:58 | |
| *** mosulica has quit IRC | 12:59 | |
| *** udesale has quit IRC | 13:17 | |
| *** chlong has joined #openstack-glance | 13:20 | |
| *** markvoelker has joined #openstack-glance | 13:30 | |
| *** arc0 has quit IRC | 13:54 | |
| *** Guest36641 is now known as melwitt | 14:03 | |
| *** ratailor has joined #openstack-glance | 14:14 | |
| *** rosmaita has joined #openstack-glance | 14:20 | |
| *** szahers has joined #openstack-glance | 14:49 | |
| *** lbragstad has joined #openstack-glance | 14:59 | |
| *** szahers has quit IRC | 15:00 | |
| *** gyee has joined #openstack-glance | 15:05 | |
| *** lbragstad has quit IRC | 15:11 | |
| *** MVenesio has quit IRC | 15:30 | |
| *** e0ne has quit IRC | 15:37 | |
| *** tshefi has quit IRC | 15:46 | |
| *** ratailor has quit IRC | 16:09 | |
| *** hamzy has quit IRC | 16:11 | |
| *** groen692 has quit IRC | 16:19 | |
| *** pcaruana has quit IRC | 16:38 | |
| *** rcernin has quit IRC | 16:52 | |
| *** tesseract has quit IRC | 16:52 | |
| *** mvk has quit IRC | 17:01 | |
| *** szahers has joined #openstack-glance | 17:08 | |
| *** szahers has quit IRC | 17:10 | |
| *** udesale has joined #openstack-glance | 17:27 | |
| *** udesale has quit IRC | 17:31 | |
| *** harlowja has joined #openstack-glance | 17:49 | |
| *** MVenesio has joined #openstack-glance | 17:49 | |
| *** mvk has joined #openstack-glance | 17:53 | |
| *** mingyu has quit IRC | 18:45 | |
| *** mingyu has joined #openstack-glance | 18:46 | |
| *** mingyu has quit IRC | 18:47 | |
| *** mingyu has joined #openstack-glance | 18:48 | |
| *** Sukhdev has joined #openstack-glance | 19:18 | |
| *** lucasxu has quit IRC | 19:26 | |
| *** NostawRm has quit IRC | 19:33 | |
| *** rcernin has joined #openstack-glance | 20:14 | |
| *** e0ne has joined #openstack-glance | 20:22 | |
| -openstackstatus- NOTICE: Zuul and Gerrit are being restarted to address issues discovered with the Gerrit 2.13 upgrade. review.openstack.org will be inaccessible for a few minutes while we make these changes. Currently running jobs will be restarted for you once Zuul and Gerrit are running again. | 20:26 | |
| *** e0ne has quit IRC | 20:28 | |
| *** Sukhdev has quit IRC | 20:41 | |
| *** catintheroof has quit IRC | 20:50 | |
| *** catintheroof has joined #openstack-glance | 20:50 | |
| *** catintheroof has quit IRC | 20:51 | |
| *** e0ne has joined #openstack-glance | 21:08 | |
| *** jose-phillips has joined #openstack-glance | 21:11 | |
| openstackgerrit | Tim Burke proposed openstack/glance_store master: Expand sz to size https://review.openstack.org/505408 | 21:21 |
| *** e0ne has quit IRC | 21:37 | |
| *** e0ne has joined #openstack-glance | 21:38 | |
| *** e0ne has quit IRC | 21:38 | |
| *** jistr has quit IRC | 21:41 | |
| *** Sukhdev has joined #openstack-glance | 21:49 | |
| *** rosmaita has quit IRC | 21:57 | |
| *** jistr has joined #openstack-glance | 22:01 | |
| *** Sukhdev has quit IRC | 22:12 | |
| *** MVenesio has quit IRC | 22:12 | |
| *** chlong has quit IRC | 22:21 | |
| -openstackstatus- NOTICE: Gerrit is being restarted to address some final issues, review.openstack.org will be inaccessible for a few minutes while we restart | 22:32 | |
| openstackgerrit | Merged openstack/glance_store master: Buffered reader: Upload recovery for swift store https://review.openstack.org/120866 | 22:34 |
| *** catintheroof has joined #openstack-glance | 22:45 | |
| *** openstackgerrit has quit IRC | 22:47 | |
| *** rcernin has quit IRC | 23:11 | |
| *** hoonetorg has quit IRC | 23:23 | |
| *** hoonetorg has joined #openstack-glance | 23:36 | |
| *** ChanServ changes topic to "OpenStack Glance | priorities: http://lists.openstack.org/pipermail/openstack-dev/2017-September/121975.html | logs at http://eavesdrop.openstack.org/irclogs/%23openstack-glance/" | 23:38 | |
| -openstackstatus- NOTICE: Gerrit is once again part of normal puppet config management. Problems with Gerrit gitweb links and Zuul post jobs have been addressed. We currently cannot create new gerrit projects (fixes in progress) and email sending is slow (being debugged). | 23:38 | |
| *** Sukhdev has joined #openstack-glance | 23:46 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!