openstackgerrit | Sean McGinnis proposed openstack/glance master: Fix SQLAlchemy reference link https://review.openstack.org/518459 | 00:09 |
---|---|---|
*** gyee_ has quit IRC | 00:13 | |
*** markvoelker has quit IRC | 00:31 | |
*** zhurong has joined #openstack-glance | 00:34 | |
*** Sukhdev has joined #openstack-glance | 00:43 | |
*** markvoelker has joined #openstack-glance | 00:43 | |
*** zhurong has quit IRC | 01:34 | |
*** Sukhdev has quit IRC | 01:38 | |
*** trungnv has quit IRC | 02:11 | |
*** dalgaaf has quit IRC | 02:39 | |
*** dalgaaf has joined #openstack-glance | 02:39 | |
*** namnh has joined #openstack-glance | 02:45 | |
*** links has joined #openstack-glance | 03:03 | |
*** akekane has joined #openstack-glance | 03:13 | |
*** akekane is now known as abhishekk | 03:14 | |
*** _ix has joined #openstack-glance | 03:27 | |
*** Sukhdev has joined #openstack-glance | 03:36 | |
openstackgerrit | Merged openstack/glance master: Fix SQLAlchemy reference link https://review.openstack.org/518459 | 03:44 |
*** rosmaita has quit IRC | 03:56 | |
*** flwang1 has quit IRC | 04:05 | |
abhishekk | jokke_: still around? | 04:23 |
*** nikhil has quit IRC | 04:25 | |
*** udesale has joined #openstack-glance | 04:50 | |
*** Sukhdev has quit IRC | 05:26 | |
openstackgerrit | Nguyen Van Trung proposed openstack/glance master: Add validation to improve pep8 check for glance project https://review.openstack.org/520337 | 05:34 |
*** trungnv has joined #openstack-glance | 05:34 | |
*** ratailor has joined #openstack-glance | 05:36 | |
*** ratailor has quit IRC | 05:36 | |
*** ratailor has joined #openstack-glance | 05:36 | |
*** Sukhdev has joined #openstack-glance | 05:41 | |
*** Sukhdev has quit IRC | 05:42 | |
*** _ix has quit IRC | 05:48 | |
*** zhurong has joined #openstack-glance | 06:41 | |
*** belmoreira has joined #openstack-glance | 06:42 | |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Stage call fails with TypeError https://review.openstack.org/520945 | 06:57 |
*** markvoelker has quit IRC | 06:59 | |
*** pcaruana has joined #openstack-glance | 07:04 | |
*** flwang1 has joined #openstack-glance | 07:17 | |
*** rcernin has quit IRC | 07:18 | |
*** namnh has quit IRC | 07:27 | |
*** trungnv has quit IRC | 07:42 | |
*** zhurong has quit IRC | 07:43 | |
*** markvoelker has joined #openstack-glance | 08:00 | |
*** AlexeyAbashkin has joined #openstack-glance | 08:01 | |
*** alexchadin has joined #openstack-glance | 08:24 | |
*** belmoreira has quit IRC | 08:47 | |
*** sdatko has joined #openstack-glance | 08:51 | |
*** alexchadin has quit IRC | 09:05 | |
*** alexchadin has joined #openstack-glance | 09:05 | |
*** arcolife has joined #openstack-glance | 09:07 | |
*** e0ne has joined #openstack-glance | 09:29 | |
*** alexchadin has quit IRC | 09:46 | |
*** alexchadin has joined #openstack-glance | 09:47 | |
*** alexchadin has quit IRC | 09:57 | |
*** alexchadin has joined #openstack-glance | 09:58 | |
*** sapd__ has quit IRC | 10:09 | |
*** sapd__ has joined #openstack-glance | 10:14 | |
*** arcolife has quit IRC | 10:22 | |
*** arcolife has joined #openstack-glance | 10:36 | |
*** udesale has quit IRC | 10:56 | |
*** abhishekk has quit IRC | 11:00 | |
*** alexchadin has quit IRC | 11:04 | |
*** alexchadin has joined #openstack-glance | 11:05 | |
*** alexchadin has quit IRC | 11:17 | |
*** e0ne has quit IRC | 11:26 | |
*** e0ne has joined #openstack-glance | 11:26 | |
*** e0ne has quit IRC | 11:41 | |
*** e0ne has joined #openstack-glance | 11:44 | |
*** ratailor has quit IRC | 11:54 | |
*** pbourke has quit IRC | 12:10 | |
*** pbourke has joined #openstack-glance | 12:12 | |
*** udesale has joined #openstack-glance | 12:13 | |
*** clayton has quit IRC | 12:44 | |
*** arcolife has quit IRC | 12:47 | |
*** gcb has quit IRC | 12:47 | |
*** MattMan has quit IRC | 12:54 | |
*** MattMan has joined #openstack-glance | 12:54 | |
*** mosulica has joined #openstack-glance | 13:05 | |
*** links has quit IRC | 13:19 | |
*** clayton has joined #openstack-glance | 13:29 | |
*** markvoelker has quit IRC | 13:34 | |
*** markvoelker has joined #openstack-glance | 13:34 | |
*** clayton has quit IRC | 13:38 | |
*** clayton has joined #openstack-glance | 13:39 | |
*** gabor_antal_ has quit IRC | 14:04 | |
*** udesale has quit IRC | 14:31 | |
*** ratailor has joined #openstack-glance | 14:58 | |
*** udesale has joined #openstack-glance | 15:11 | |
*** udesale has quit IRC | 15:12 | |
*** e0ne_ has joined #openstack-glance | 15:14 | |
*** e0ne has quit IRC | 15:17 | |
*** odyssey4me has joined #openstack-glance | 15:22 | |
odyssey4me | hi everyone - is there anything in particular holding back a final core vote for https://review.openstack.org/#/c/506145/ ? | 15:23 |
*** rosmaita has joined #openstack-glance | 15:23 | |
*** ratailor has quit IRC | 15:31 | |
odyssey4me | rosmaita ^ | 15:35 |
odyssey4me | sorry, I see you just joined, so I'll repeat the message :) | 15:35 |
odyssey4me | hi everyone - is there anything in particular holding back a final core vote for https://review.openstack.org/#/c/506145/ ? | 15:35 |
* rosmaita looking | 15:46 | |
odyssey4me | thanks rosmaita | 15:47 |
rosmaita | odyssey4me: LGTM | 15:49 |
rosmaita | odyssey4me: at the PTG you mentioned perhaps having time to help set up upgrade testing for glance ... how's your time looking? | 15:50 |
odyssey4me | rosmaita terrible, that said I think I can put some time into making that happen | 15:51 |
odyssey4me | I can push up a patch to add the job as a non-voting job now, then we can improve the job to a point of it doing all the right things. Happy with that? | 15:51 |
rosmaita | totally understand | 15:51 |
rosmaita | yes, that would be a good start and very helpful | 15:52 |
odyssey4me | let me do that now, then we can liaise in the hope that we do all the right things by M3 (hopefully) | 15:53 |
rosmaita | works for me! | 15:53 |
*** mosulica has quit IRC | 16:00 | |
*** AlexeyAbashkin has quit IRC | 16:05 | |
*** gyee_ has joined #openstack-glance | 16:09 | |
openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/glance master: Add non-voting rolling upgrade test https://review.openstack.org/521123 | 16:11 |
rosmaita | that was quick! | 16:11 |
odyssey4me | yeah, it's pretty straightforward to define the job, as we have the framework there already | 16:12 |
rosmaita | thanks for the detailed commit message | 16:12 |
odyssey4me | but our glance role needs to actually do rolling upgrades (currently it does the old style of deploying glance-registry and glance-api, so it can't do rolling upgrades), but I'll patch that in asap and add a depends-on to this once that's going so that they're tested together | 16:13 |
rosmaita | odyssey4me : on line 31 in .zuul.yaml, should s/keystone/glance/ ? | 16:14 |
odyssey4me | yes, lemme fix | 16:14 |
rosmaita | np | 16:14 |
odyssey4me | if there're any other excludes or notes you'd like added then please comment in review :) | 16:16 |
openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/glance master: Add non-voting rolling upgrade test https://review.openstack.org/521123 | 16:18 |
*** _ix has joined #openstack-glance | 16:34 | |
*** jistr has quit IRC | 16:39 | |
*** jistr has joined #openstack-glance | 16:43 | |
openstackgerrit | Merged openstack/glance master: Add default configuration files to data_files https://review.openstack.org/506145 | 16:59 |
odyssey4me | rosmaita it appears that the glance docs stop somewhere after ocata - I guess they need updating? | 16:59 |
odyssey4me | the install docs still describe the setup for glance with both registry and api | 17:00 |
odyssey4me | I take it that the consolidation required for rolling upgrades is that registry is no longer running, and therefore only the api is running? | 17:00 |
rosmaita | yes, so a v2-only installation | 17:15 |
rosmaita | with no registry | 17:15 |
*** _ix has quit IRC | 17:21 | |
odyssey4me | hmm, ok - are there any plans to go beyond deprecating v1 (ie removing it entirely?) | 17:23 |
odyssey4me | looks like I'll have to implement some changes to allow deployers to enable/disable these things first, and to be able to do online/offline upgrades based on whatever's enabled/disabled... so this is going to get a little complex, but it'll be worth it I think :) | 17:24 |
odyssey4me | it's especially important to do it this way because of that nasty THIS IS EXPERIMENTAL warning in the rolling upgrade docs :) | 17:25 |
rosmaita | odyssey4me: so v1 is scheduled to be removed in Queens | 17:25 |
odyssey4me | oh really? hmm - that makes it easier to force the hand | 17:25 |
odyssey4me | is there a patch up for that already? if not, what's holding it back? | 17:26 |
rosmaita | well, image import has to be feature-complete | 17:26 |
rosmaita | which we are working on ... | 17:26 |
rosmaita | but there may not be a v1 removal patch until Q-3 | 17:27 |
rosmaita | also, registry is deprecated in Q and will be removed in S | 17:27 |
odyssey4me | ok, I think I'll need to still implement it the way I'm thinking | 17:28 |
odyssey4me | it'll hopefully give us something to test and validate that rolling upgrades are safe so that that big warning can be removed for Queens, or perhaps in R | 17:28 |
rosmaita | yes, that would be great | 17:29 |
odyssey4me | everything we implement goes into production environments, so the conservative approach is better for the defaults we apply | 17:29 |
odyssey4me | but there's nothing that says we can't enable someone to opt-in to new features, giving people the option to try it out and give feedback | 17:30 |
rosmaita | i agree | 17:30 |
odyssey4me | I'm building a test environment now and will put together a series of patches in the next week or two to get everything in place. I may ping questions to the channel as I go. | 17:31 |
odyssey4me | rosmaita does glance have any tests which exercise different stores (eg rbd, swift, etc)? would that be something of interest to have? | 17:36 |
odyssey4me | I'm speaking of functional tests here, of course. | 17:37 |
rosmaita | i think we're pretty light on those, both in glance and glance_store | 17:40 |
rosmaita | http://git.openstack.org/cgit/openstack/glance_store/tree/glance_store/tests/functional | 17:40 |
rosmaita | http://git.openstack.org/cgit/openstack/glance/tree/glance/tests/functional | 17:41 |
odyssey4me | ok, we can extend to implementing more of those too later | 17:41 |
*** akekane has joined #openstack-glance | 17:41 | |
rosmaita | ok, cool | 17:42 |
*** akekane is now known as abhishekk | 17:42 | |
abhishekk | rosmaita: hi, when you get some free time, please let me know your opinion about this bug, https://bugs.launchpad.net/glance/+bug/1732830 | 17:47 |
openstack | Launchpad bug 1732830 in Glance "Unreachable 'ImageSizeLimitExceeded' exception block in stage call" [Undecided,New] - Assigned to Abhishek Kekane (abhishek-kekane) | 17:47 |
rosmaita | abhishekk: ok | 17:47 |
abhishekk | rosmaita: thank you | 17:47 |
*** e0ne_ has quit IRC | 17:49 | |
odyssey4me | if I'm currently running the v1 api and the registry service, is there anything special that needs to be done to disable the registry service? | 17:52 |
odyssey4me | do I have to first remove the v1 api before I can disable the registry service? | 17:53 |
rosmaita | odyssey4me: no, there are settings in the glance-api.conf file for whether v2 uses the registry or not | 17:54 |
odyssey4me | ok, but if v1 is running the registry has to be used, right? | 17:55 |
rosmaita | yes | 17:55 |
rosmaita | by v1 | 17:56 |
odyssey4me | and the v2 options for glance-api to use registry are noted here: https://docs.openstack.org/glance/latest/configuration/glance_api.html#DEFAULT.data_api | 17:58 |
odyssey4me | along with the enable_v2_* options | 17:59 |
rosmaita | yes | 18:06 |
*** abhishekk has quit IRC | 18:07 | |
openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/glance master: Correct spelling error for config section DEFAULT https://review.openstack.org/521151 | 18:15 |
odyssey4me | rosmaita ^ just a little thing I found along the way that needed fixing | 18:15 |
rosmaita | i thought we fixed that, but guess not | 18:17 |
rosmaita | odyssey4me : did you regenerate the config files, or fix them by hand? | 18:18 |
odyssey4me | rosmaita I just did a sed, but it's clearly the confi.py entry that was the cause of the docs issue | 18:25 |
rosmaita | odyssey4me : ok, just commit the config.py if you don't mind | 18:26 |
rosmaita | or you could regenerate the config files and include them in the commit | 18:26 |
rosmaita | up to you | 18:26 |
rosmaita | i think some more stuff will be brought in on regeneration | 18:26 |
odyssey4me | rosmaita the change for that is in the same review | 18:27 |
odyssey4me | I didn't think it appropriate to bring in unrelated changes, but I can regen the file if you like. | 18:27 |
rosmaita | well, the only reason to commit new sample .conf files is if they've been regenerated | 18:28 |
rosmaita | we have a policy about that, but i can't remember what it is | 18:29 |
*** _ix has joined #openstack-glance | 18:29 | |
odyssey4me | ok, will regen and submit with the code patch | 18:29 |
odyssey4me | thanks for having a tox env for that, otherwise it'd be a thing to figure out :) | 18:30 |
rosmaita | thanks, just mention in the commit message that your patch includes a sample conf file refresh | 18:30 |
odyssey4me | yup, will do | 18:30 |
rosmaita | thanks! | 18:30 |
openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/glance master: Correct related section for enable_image_import https://review.openstack.org/521151 | 18:35 |
odyssey4me | there we go | 18:35 |
odyssey4me | quite a bit of new content | 18:36 |
rosmaita | yes, i forgot to regenerate in master when i regenerated for the pike release | 18:36 |
rosmaita | thanks for taking the time to correct that help text | 18:37 |
odyssey4me | apparently it's not desirable to keep these sample conf files in the git tree - downstream consumers are supposed to learn to generate them rather than rely on a sample which may not be current | 18:38 |
odyssey4me | glance appears to be one of the few projects still doing it | 18:38 |
rosmaita | that's good to know | 18:38 |
rosmaita | because it is an enormous pain in the butt | 18:39 |
odyssey4me | this is what nova does instead: https://github.com/openstack/nova/blob/master/etc/nova/README-nova.conf.txt | 18:39 |
odyssey4me | I'm guessing that they have something for docs which generates the same in docs whenever the docs are published | 18:40 |
rosmaita | i was hoping we could take advantage of zuul3 to set up a job to do the refresh | 18:40 |
rosmaita | yeah, thanks for the link, i will have to look into that | 18:40 |
odyssey4me | well, you kinda can do it with the proposal bot - probably | 18:40 |
odyssey4me | but a better option would probably be to have it publish with docs as nova's doing | 18:41 |
rosmaita | yeah, we were thinking generate, compare to current, if any diff, put up a patch | 18:41 |
rosmaita | but i agree, better to do it like nova | 18:41 |
odyssey4me | aha: https://github.com/openstack/nova/commit/83a9c2ac334712b27704a814552628cf0e536a85 | 18:42 |
rosmaita | means we will have to fix all those docstrings, you probably noticed that the generated html looks pretty bad in ours | 18:42 |
odyssey4me | yeah, I wondered if that was a known bug | 18:43 |
odyssey4me | I can push up a patch to switch to doing this if you like? | 18:43 |
rosmaita | i have no objection! | 18:43 |
odyssey4me | ok, I've got to run now but I'll pick that up tomorrow I think... it doesn't look too complicated and would save you some time | 18:44 |
rosmaita | if you have time, that would be great | 18:45 |
odyssey4me | make the tools work for you :) | 18:45 |
rosmaita | exactly! | 18:45 |
*** e0ne has joined #openstack-glance | 19:03 | |
*** _ix has quit IRC | 19:12 | |
*** ChanServ changes topic to "OpenStack Glance" | 19:12 | |
*** ChanServ changes topic to "OpenStack Glance | priorities: http://lists.openstack.org/pipermail/openstack-dev/2017-November/124678.html" | 19:12 | |
*** ChanServ changes topic to "OpenStack Glance | priorities: http://lists.openstack.org/pipermail/openstack-dev/2017-November/124678.html | logs at http://eavesdrop.openstack.org/irclogs/%23openstack-glance/" | 19:12 | |
*** e0ne has quit IRC | 19:15 | |
*** Sukhdev has joined #openstack-glance | 19:38 | |
openstackgerrit | Merged openstack/glance master: Remove setting of version/release from releasenotes https://review.openstack.org/520644 | 19:40 |
*** rosmaita has quit IRC | 19:52 | |
*** _ix has joined #openstack-glance | 20:09 | |
*** Sukhdev has quit IRC | 20:51 | |
*** AlexeyAbashkin has joined #openstack-glance | 21:19 | |
*** AlexeyAbashkin has quit IRC | 21:24 | |
*** Sukhdev has joined #openstack-glance | 21:53 | |
openstackgerrit | Merged openstack/glance master: Correct related section for enable_image_import https://review.openstack.org/521151 | 22:08 |
*** hoonetorg has quit IRC | 22:28 | |
*** _ix has quit IRC | 22:36 | |
*** _ix has joined #openstack-glance | 22:50 | |
*** pcaruana has quit IRC | 23:54 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!