*** rmcall has joined #openstack-glance | 00:20 | |
*** rmcall has quit IRC | 00:20 | |
*** jdurgin has joined #openstack-glance | 00:23 | |
*** r-daneel has quit IRC | 00:56 | |
*** jdurgin has quit IRC | 01:30 | |
*** itlinux has joined #openstack-glance | 01:47 | |
*** jdurgin has joined #openstack-glance | 01:53 | |
openstackgerrit | Brian Rosmaita proposed openstack/glance master: URI filtering for web-download https://review.openstack.org/542956 | 01:57 |
---|---|---|
*** jdurgin has quit IRC | 01:57 | |
*** harlowja has quit IRC | 03:08 | |
*** dalgaaf has quit IRC | 03:27 | |
*** dalgaaf has joined #openstack-glance | 03:32 | |
*** ykarel|away has joined #openstack-glance | 03:34 | |
*** itlinux has quit IRC | 03:37 | |
*** konan has joined #openstack-glance | 03:50 | |
*** bkopilov has quit IRC | 04:00 | |
*** rosmaita has quit IRC | 04:00 | |
*** itlinux has joined #openstack-glance | 04:00 | |
*** bkopilov has joined #openstack-glance | 04:03 | |
*** udesale has joined #openstack-glance | 04:13 | |
*** gyee has quit IRC | 04:14 | |
*** itlinux has quit IRC | 04:17 | |
*** masber has joined #openstack-glance | 04:33 | |
*** links has joined #openstack-glance | 04:34 | |
*** abhishekk has joined #openstack-glance | 04:41 | |
*** links has quit IRC | 04:42 | |
*** links has joined #openstack-glance | 04:45 | |
*** pdeore has joined #openstack-glance | 04:46 | |
*** dalgaaf has quit IRC | 04:56 | |
*** r-daneel has joined #openstack-glance | 04:57 | |
*** dalgaaf has joined #openstack-glance | 04:58 | |
*** threestrands_ has joined #openstack-glance | 05:09 | |
*** threestrands_ has quit IRC | 05:09 | |
*** threestrands_ has joined #openstack-glance | 05:09 | |
*** threestrands has quit IRC | 05:09 | |
*** threestrands_ has quit IRC | 05:10 | |
*** threestrands_ has joined #openstack-glance | 05:11 | |
*** harlowja has joined #openstack-glance | 05:15 | |
*** threestrands has joined #openstack-glance | 05:15 | |
*** threestrands has quit IRC | 05:15 | |
*** threestrands has joined #openstack-glance | 05:15 | |
*** threestrands_ has quit IRC | 05:18 | |
*** Abhi_ has joined #openstack-glance | 05:27 | |
*** Abhi_ has quit IRC | 05:28 | |
*** threestrands has quit IRC | 05:28 | |
*** pdeore_ has joined #openstack-glance | 05:45 | |
*** pdeore has quit IRC | 05:48 | |
*** udesale has quit IRC | 05:48 | |
*** udesale has joined #openstack-glance | 05:48 | |
*** harlowja has quit IRC | 06:14 | |
*** btully has joined #openstack-glance | 06:16 | |
*** e0ne has joined #openstack-glance | 06:20 | |
*** btully has quit IRC | 06:21 | |
*** konan has quit IRC | 06:22 | |
*** e0ne has quit IRC | 06:30 | |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: db sync fails for mysql while adding triggers https://review.openstack.org/544792 | 06:34 |
*** rcernin has quit IRC | 06:44 | |
*** e0ne has joined #openstack-glance | 06:44 | |
*** e0ne_ has joined #openstack-glance | 06:51 | |
*** pdeore__ has joined #openstack-glance | 06:53 | |
*** e0ne_ has quit IRC | 06:55 | |
*** e0ne has quit IRC | 06:55 | |
*** pdeore__ is now known as pdeore | 06:55 | |
*** hoonetorg has quit IRC | 06:56 | |
*** e0ne has joined #openstack-glance | 06:56 | |
*** pdeore_ has quit IRC | 06:56 | |
*** hoonetorg has joined #openstack-glance | 06:57 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance master: Imported Translations from Zanata https://review.openstack.org/544171 | 07:03 |
*** udesale_ has joined #openstack-glance | 07:07 | |
*** udesale has quit IRC | 07:09 | |
*** threestrands has joined #openstack-glance | 07:09 | |
*** threestrands has quit IRC | 07:09 | |
*** threestrands has joined #openstack-glance | 07:09 | |
openstackgerrit | Merged openstack/glance master: Make the Image status transition early https://review.openstack.org/544511 | 07:22 |
*** udesale__ has joined #openstack-glance | 07:23 | |
*** mbindlish has joined #openstack-glance | 07:25 | |
*** udesale_ has quit IRC | 07:26 | |
*** rcernin has joined #openstack-glance | 07:28 | |
*** pcaruana has joined #openstack-glance | 07:40 | |
*** edmondsw has joined #openstack-glance | 07:41 | |
*** e0ne has quit IRC | 07:43 | |
*** e0ne has joined #openstack-glance | 07:43 | |
*** edmondsw has quit IRC | 07:45 | |
*** e0ne has quit IRC | 07:49 | |
*** belmoreira has joined #openstack-glance | 07:55 | |
*** MattMan has quit IRC | 08:02 | |
*** MattMan has joined #openstack-glance | 08:02 | |
*** ykarel|away is now known as ykarel|lunch | 08:04 | |
*** btully has joined #openstack-glance | 08:05 | |
*** AlexeyAbashkin has joined #openstack-glance | 08:08 | |
*** btully has quit IRC | 08:09 | |
*** tesseract has joined #openstack-glance | 08:17 | |
*** mdbooth has joined #openstack-glance | 08:22 | |
*** alexchadin has joined #openstack-glance | 08:22 | |
*** danpawlik has quit IRC | 08:24 | |
*** danpawlik has joined #openstack-glance | 08:25 | |
*** links has quit IRC | 08:35 | |
*** ykarel|lunch is now known as ykarel | 08:40 | |
*** links has joined #openstack-glance | 08:53 | |
*** alexchadin has quit IRC | 08:56 | |
*** alexchadin has joined #openstack-glance | 08:57 | |
*** ykarel_ has joined #openstack-glance | 09:06 | |
*** ykarel has quit IRC | 09:08 | |
*** ykarel_ has quit IRC | 09:15 | |
*** mbindlish has quit IRC | 09:18 | |
*** dtantsur|afk is now known as dtantsur | 09:21 | |
*** threestrands_ has joined #openstack-glance | 09:21 | |
*** threestrands has quit IRC | 09:21 | |
*** ykarel has joined #openstack-glance | 09:22 | |
*** edmondsw has joined #openstack-glance | 09:29 | |
*** edmondsw has quit IRC | 09:34 | |
*** alexchadin has quit IRC | 09:37 | |
*** e0ne has joined #openstack-glance | 09:37 | |
*** alexchadin has joined #openstack-glance | 09:38 | |
*** ykarel is now known as ykarel|away | 09:58 | |
*** ykarel|away has quit IRC | 10:08 | |
*** udesale_ has joined #openstack-glance | 10:30 | |
*** d0ugal has quit IRC | 10:30 | |
*** d0ugal has joined #openstack-glance | 10:33 | |
*** udesale__ has quit IRC | 10:33 | |
openstackgerrit | Prateek Goel proposed openstack/glance-specs master: New image status "deleting" https://review.openstack.org/544846 | 10:34 |
openstackgerrit | Prateek Goel proposed openstack/glance-specs master: New image status "deleting" https://review.openstack.org/544846 | 10:46 |
openstackgerrit | Erno Kuvaja proposed openstack/glance master: URI filtering for web-download https://review.openstack.org/542956 | 10:48 |
*** e0ne has quit IRC | 10:51 | |
*** e0ne has joined #openstack-glance | 10:59 | |
*** jistr is now known as jistr|mtg | 11:00 | |
*** ykarel has joined #openstack-glance | 11:04 | |
*** udesale__ has joined #openstack-glance | 11:14 | |
*** abhishekk has quit IRC | 11:15 | |
*** udesale_ has quit IRC | 11:16 | |
*** d0ugal has quit IRC | 11:20 | |
*** ykarel has quit IRC | 11:22 | |
*** e0ne has quit IRC | 11:24 | |
*** udesale__ has quit IRC | 11:30 | |
*** pbourke has quit IRC | 11:30 | |
*** e0ne has joined #openstack-glance | 11:31 | |
*** pbourke has joined #openstack-glance | 11:32 | |
*** d0ugal has joined #openstack-glance | 11:39 | |
*** btully has joined #openstack-glance | 11:43 | |
*** btully has quit IRC | 11:47 | |
*** pdeore has quit IRC | 11:52 | |
ShilpaD | jokke_: Hi, thank you for review 540736, I have replied to your questions here, kindly go through the same whenever you will get time. | 12:19 |
*** jistr|mtg is now known as jistr | 12:23 | |
*** e0ne has quit IRC | 12:29 | |
*** prateekgoel has joined #openstack-glance | 12:54 | |
*** prateekgoel has quit IRC | 12:58 | |
*** edmondsw has joined #openstack-glance | 13:06 | |
*** edmondsw has quit IRC | 13:10 | |
*** pooja-jadhav is now known as pooja_jadhav | 13:10 | |
*** mdnadeem has joined #openstack-glance | 13:18 | |
mdnadeem | openstack-glance hello team, is there any way to set default value for img_volume_type ? | 13:20 |
*** edmondsw has joined #openstack-glance | 13:24 | |
jokke_ | mdnadeem: I don't think so | 13:24 |
mdnadeem | jokke_, if we add default value there: https://github.com/openstack/glance/blob/master/etc/metadefs/storage-volume-type.json#L17 | 13:25 |
*** udesale has joined #openstack-glance | 13:25 | |
mdnadeem | jokke_, then re-run the glance-manage db_load_metadefs | 13:25 |
mdnadeem | jokke_, is that make any sense ? | 13:25 |
jokke_ | mdnadeem: if you look the description, there is mention of default_volume_type ... does that not work for you? | 13:28 |
jokke_ | mdnadeem: I'm not sure how adding default there and syncing would behave. You'd need to roll out test environment and give it a try | 13:30 |
mdnadeem | jokke_, default_volume_type is of cinder.conf , so my use case there is a volume type already set for it whenever user create a volume directly, however i need to set it at glance side while creating a volume from image it will take a different volume type other than default one which is set in cinder.conf | 13:31 |
mdnadeem | jokke_, i have seen there is an option in glance.conf to full fill my use case cinder_volume_type , however i feel this is only work when i have set cinder as glance backened , which is not the case in my env | 13:33 |
jokke_ | mdnadeem: yes, that would be the cinder driver option, not what you are looking for | 13:34 |
jokke_ | like said, I do not know how adding the default to the metadef json file and syncing would affect existing records, you would need to try that if it solves your problem | 13:35 |
mdnadeem | jokke_, yes, i am trying it | 13:35 |
ShilpaD | jokke: Hi, agrreeing your point, will revert to original message "Database is up to date. No migrations needed." and upload patch. | 13:40 |
*** abhishekk has joined #openstack-glance | 13:42 | |
jokke_ | ShilpaD: thanks ... what I understand other than that it does look pretty good | 13:44 |
jokke_ | ShilpaD: thanks for your efforts | 13:45 |
ShilpaD | jokke_: thank you | 13:45 |
*** rosmaita has joined #openstack-glance | 13:47 | |
*** mbindlish_ has joined #openstack-glance | 13:53 | |
*** e0ne has joined #openstack-glance | 13:54 | |
*** McClymontS has joined #openstack-glance | 13:56 | |
rosmaita | Courtesy meeting reminder on #openstack-meeting-4: ativelkov, cpallares, flaper87, flwang1, hemanthm, jokke_, kragniz, lakshmiS, mclaren, mfedosin, nikhil_k, Nikolay_St, Olena, pennerc, rosmaita, sigmavirus24, sabari, TravT, ajayaa, GB21, bpoulos, harshs, abhishekk, bunting, dshakhray, wxy, dhellmann, kairat, alex_bash, smcginnis, arcolife,Brin | 13:59 |
*** esberglu has joined #openstack-glance | 13:59 | |
openstackgerrit | Merged openstack/glance master: Imported Translations from Zanata https://review.openstack.org/544171 | 14:00 |
openstackgerrit | Shilpa Devharakar proposed openstack/glance master: Add validation to check if E-M-C is already in sync https://review.openstack.org/540736 | 14:02 |
*** dtantsur is now known as dtantsur|brb | 14:02 | |
*** rmcall has joined #openstack-glance | 14:21 | |
*** pdeore has joined #openstack-glance | 14:23 | |
*** alexchadin has quit IRC | 14:29 | |
*** esberglu has quit IRC | 14:34 | |
openstackgerrit | Paul Bourke (pbourke) proposed openstack/glance master: Fix some api tests when behind http proxy https://review.openstack.org/541390 | 14:38 |
*** threestrands_ has quit IRC | 14:39 | |
*** pdeore has quit IRC | 14:43 | |
*** dtantsur|brb is now known as dtantsur | 14:49 | |
*** ykarel has joined #openstack-glance | 14:50 | |
rosmaita | hello everyone | 14:53 |
*** McClymontS has quit IRC | 14:53 | |
abhishekk | o/ | 14:53 |
rosmaita | let's take a look at https://etherpad.openstack.org/p/glance-queens-rc1-patches | 14:53 |
rosmaita | and asses the current situation | 14:53 |
jokke_ | I did update it during the meeting | 14:54 |
rosmaita | cool | 14:54 |
jokke_ | so it should be about current | 14:54 |
rosmaita | ok, this prlimits under wsgi thing | 14:54 |
rosmaita | or uwsgi rather | 14:54 |
rosmaita | well, guess i better review it more carefully | 14:55 |
rosmaita | i don't think it has any effect on non-uwsgi glance | 14:55 |
jokke_ | it needs to have some mass testing | 14:55 |
rosmaita | the thing is, it's needed for tasks, and tasks do not run under uwsgi! | 14:55 |
rosmaita | so it's kind of a chicken-egg thing | 14:55 |
rosmaita | ok, i will put some comments on the patch | 14:56 |
rosmaita | so not a priority for RC-2 | 14:56 |
rosmaita | or 3 i guess | 14:56 |
*** mbindlish_ has quit IRC | 14:56 | |
jokke_ | so my concern with that is the same as what I said in the meeting ... fixing these things indicates that we as community are supporting of running Glance under uwsgi and at least I can't stand behind that statement | 14:56 |
rosmaita | agree entirely | 14:57 |
jokke_ | any new bug coming in, igf it's not reproducable with standalone glance, I care very little abot | 14:57 |
jokke_ | about | 14:57 |
abhishekk | yes | 14:57 |
rosmaita | and i apologize for letting this drag on, i should've stopped this earlier | 14:57 |
rosmaita | ok next open item is uri filtering | 14:58 |
jokke_ | that has been dragging for while as well ... hopefully all the issues have been addressed now | 14:58 |
jokke_ | as it will be half a day to gate the master and backport | 14:58 |
rosmaita | ok, question about the conf file (not the sample) | 14:59 |
rosmaita | i thought since it was optional, it doesn't get a .conf in etc | 14:59 |
jokke_ | well almost all our config files are optional | 14:59 |
jokke_ | and we don't carry the .sample files | 15:00 |
jokke_ | also the feature will be enabled by default and stay so from Rocky onwards | 15:00 |
rosmaita | well, we do carry the swift sample | 15:00 |
rosmaita | and the default setting is good without the file | 15:01 |
rosmaita | and there's taht other patch that removed glance-inporet-conf from setup.cfg | 15:01 |
rosmaita | so let's remove it for now, and you can add it once you are ptg :) | 15:01 |
*** rcernin has quit IRC | 15:01 | |
rosmaita | i mean ptl! | 15:01 |
jokke_ | -cache -manage and -scrubber all works perfectly fine as they default to api/registry confs | 15:01 |
abhishekk | So we have 2 patches which needs to be merged in master and stable/queens ASAP | 15:03 |
rosmaita | yeah, but let's stick with the plan, which is it's an optional file in queens | 15:03 |
rosmaita | so commit the updated .sample but not the .conf | 15:04 |
jokke_ | rosmaita: it's not any less optional and do we have that statement documented somewhere? | 15:04 |
abhishekk | one is uri filter and another is docs changes for the same | 15:04 |
rosmaita | pretty sure it was in the release notes and docs for bhagashri's patch | 15:04 |
abhishekk | jokke_, I guess it is their | 15:04 |
abhishekk | what rosmaita just said | 15:04 |
rosmaita | let's stick with my preference for rc-2 and we can discuss before monday | 15:05 |
rosmaita | and maybe you can talk me out of it ... let's move on so abhishek can go home | 15:05 |
rosmaita | :) | 15:05 |
rosmaita | so except for the conf file biz, i am fine with PS10 on the filtering patch | 15:07 |
rosmaita | https://review.openstack.org/#/c/542956/10 | 15:07 |
rosmaita | thanks for updating the etherpad jokke_ | 15:09 |
rosmaita | so abhishekk is correct just the uri filtering stuff outstanding | 15:09 |
*** r-daneel has quit IRC | 15:09 | |
abhishekk | rosmaita, I will be back online in couple of hours | 15:14 |
rosmaita | ok, cool ... thanks! | 15:14 |
rosmaita | we can discuss rc-3 expectations then | 15:14 |
*** abhishekk has quit IRC | 15:14 | |
ShilpaD | rosmaita: are we discussing postgracesql later? | 15:15 |
rosmaita | ShilpaD yes, although are you in india time zone? | 15:16 |
ShilpaD | yes | 15:16 |
rosmaita | ok, i have not looked at your latest patches | 15:17 |
*** mdnadeem has quit IRC | 15:17 | |
rosmaita | but it looks like migrations don't work with postgres because of the triggers? | 15:17 |
rosmaita | so would you say from your testing/research that this is the situation: | 15:18 |
rosmaita | actually, here is a question | 15:18 |
rosmaita | the expand scripts would add triggers, so they don't work with postgres either | 15:18 |
rosmaita | is that correct? (for ocata)? | 15:19 |
rosmaita | i am beginning to think that we need to revert the db-sync change and go back to the EMC plus monolithic scripts | 15:20 |
*** btully has joined #openstack-glance | 15:20 | |
ShilpaD | i have run and verified running ocata scripts on postgrace and they have run successfully, but give me 5 min, i will run upto only ocata expand and will againg confirm the same. | 15:20 |
rosmaita | and we can do the db-sync revision in rocky, but we need to make sure we have sufficient postgres test coverage | 15:21 |
rosmaita | ShilpaD ty, that would be great | 15:21 |
*** Nil_ has joined #openstack-glance | 15:22 | |
*** btully has quit IRC | 15:25 | |
*** konan has joined #openstack-glance | 15:26 | |
rosmaita | hello konan ShilpaD is running some tests on postgres expand | 15:32 |
openstackgerrit | Erno Kuvaja proposed openstack/glance master: URI filtering for web-download https://review.openstack.org/542956 | 15:36 |
jokke_ | rosmaita: ^^ and comment of the same added to your doc patch | 15:39 |
ShilpaD | rosmaita: hi | 15:40 |
ShilpaD | in ocata, for triggers, we have condition set, that it will work on MySQL only | 15:40 |
rosmaita | jokke_ ty | 15:40 |
rosmaita | ShilpaD very smart! | 15:41 |
rosmaita | ok, cool | 15:41 |
ShilpaD | if we ewmove that check, then we have DBError: (psycopg2.ProgrammingError) syntax error at or near "BEGIN" | 15:41 |
jokke_ | rosmaita: we also should change the "Technical information" section on that admin doc to reflect the same | 15:41 |
rosmaita | jokke_ ok, will look in a min | 15:42 |
rosmaita | ShilpaD so if we continue that practice, that is, no triggers added unless db is mysql, then the expand scripts should work with postgres | 15:42 |
rosmaita | and i guess the contract scripts have a similar check for mysql about trigger removal? | 15:43 |
rosmaita | so they should work with postgres, too? | 15:43 |
ShilpaD | yes for contract also there os check for MySql | 15:44 |
ShilpaD | for triggers | 15:44 |
rosmaita | great | 15:44 |
rosmaita | so the problem is the migrate part | 15:44 |
ShilpaD | so do we need to have triggers compatible with both MySql and PostgraSQL? | 15:44 |
rosmaita | ShilpaD no, the idea was that zero-downtime database upgrades would only be supported for mysql | 15:45 |
jokke_ | ShilpaD: that would be the decent case scenario ... optimal would be having them also DB2 and other perhaps deployed databases | 15:45 |
ShilpaD | rosmaita: ok, so no need of triggers for postgraceSQL | 15:47 |
rosmaita | not now | 15:47 |
rosmaita | we don't need to support zero-downtime upgrades for postgres | 15:48 |
rosmaita | we just want to not break people who are using it | 15:48 |
jokke_ | rosmaita: IIRC that was the statement that got sold to merge it at the time "We support only MySQL for now and fix the rest with later iterations" the spec does not mention anything it being exclusively for mysql ;) | 15:48 |
jokke_ | in general for this release what rosmaita just said would be way better situation than current | 15:49 |
rosmaita | true, but there's a move away from postgres support in openstack in general | 15:49 |
rosmaita | so we aren't going to support more than openstack claims too | 15:49 |
rosmaita | the idea was make it work for mysql and then see what to do next | 15:50 |
rosmaita | but yeah, the next PTL can decide to expand coverage ;) | 15:50 |
rosmaita | but what jokke_ said: we want it to be possible to upgrade your postgres database from pike -> queens | 15:51 |
rosmaita | but not zero-downtime | 15:51 |
rosmaita | just a regular db migration | 15:51 |
rosmaita | ShilpaD so what is breaking postgres regular db migrations ATM? | 15:52 |
ShilpaD | rosmaita: ATM according to me, migration scripts are not getting considered | 15:54 |
rosmaita | ok, do you have some notes on one of the bugs or on a patch or something? | 15:55 |
rosmaita | or, what should i look at before we talk again tomorrow? | 15:56 |
rosmaita | maybe that bug abhishek filed today? | 15:56 |
ShilpaD | no, but i am discussing with Abhishek on same | 15:56 |
rosmaita | ok, so we do have some progress, though. the current expand and contract scripts should work with both mysql and postgres | 15:57 |
ShilpaD | since he had workaround patch for same | 15:57 |
rosmaita | it's the migration that's the sticking point right now | 15:57 |
ShilpaD | ATM, yes | 15:57 |
rosmaita | ok, cool, thank you | 15:58 |
*** r-daneel has joined #openstack-glance | 15:58 | |
rosmaita | i will be working on getting rc-2 out today. our focus for rc-3 is fixing the database situation | 15:58 |
ShilpaD | rosmaita: ok, ty, will continue discussing same tomorrow. | 15:59 |
rosmaita | i will catch up with you and abhishek at the end of your day tomorrow | 15:59 |
rosmaita | ShilpaD sounds good, and thank you for working on this | 15:59 |
ShilpaD | rosmaita: thank you, leaving now, good day | 16:00 |
rosmaita | have a good evening! | 16:00 |
*** bhagyashris_ has joined #openstack-glance | 16:07 | |
*** pcaruana has quit IRC | 16:09 | |
openstackgerrit | Brian Rosmaita proposed openstack/glance master: Update admin docs for web-download import method https://review.openstack.org/544596 | 16:20 |
*** links has quit IRC | 16:22 | |
*** bhagyashris_ has quit IRC | 16:23 | |
*** rosmaita has quit IRC | 16:28 | |
*** e0ne has quit IRC | 16:37 | |
*** AlexeyAbashkin has quit IRC | 16:37 | |
konan | rosmaita, sorry was traveling back to home | 16:40 |
*** konan has quit IRC | 16:41 | |
*** konan has joined #openstack-glance | 16:42 | |
*** udesale has quit IRC | 16:44 | |
*** ykarel has quit IRC | 16:46 | |
*** abhishekk has joined #openstack-glance | 17:15 | |
*** harlowja has joined #openstack-glance | 17:19 | |
*** pcaruana has joined #openstack-glance | 17:20 | |
*** belmoreira has quit IRC | 17:27 | |
*** itlinux has joined #openstack-glance | 17:47 | |
*** tesseract has quit IRC | 17:52 | |
*** konan has quit IRC | 17:54 | |
*** rosmaita has joined #openstack-glance | 17:57 | |
rosmaita | jokke_ https://review.openstack.org/542956 is in the gate | 17:58 |
rosmaita | i want to do your comments on https://review.openstack.org/544596 in a follow up patch as part of https://bugs.launchpad.net/glance/+bug/1749762 | 17:59 |
openstack | Launchpad bug 1749762 in Glance "admin docs: interoperable image import revision" [High,Triaged] - Assigned to Brian Rosmaita (brian-rosmaita) | 17:59 |
*** AlexeyAbashkin has joined #openstack-glance | 18:01 | |
abhishekk | rosmaita, sorry I was travelling earlier when you were discussing about postgres | 18:02 |
*** dtantsur is now known as dtantsur|afk | 18:04 | |
abhishekk | gone through the discussion, so my point is expand and contract script will work with postgresql if we add that mysql check for triggers right? so can we remove _validate_engine check and the patch which I have added for postgresql support itself so that migration script will work with postgres? | 18:04 |
*** AlexeyAbashkin has quit IRC | 18:06 | |
*** kukacz has quit IRC | 18:15 | |
*** kukacz_ has joined #openstack-glance | 18:20 | |
rosmaita | abhishekk no worries | 18:36 |
rosmaita | yes, i believe that's correct | 18:36 |
rosmaita | will look more closely later today/early tomorrow | 18:36 |
abhishekk | that will be easy fix | 18:36 |
abhishekk | please let me know if you find any issue in this approach | 18:37 |
rosmaita | but i am more optimistic after my discussion with ShilpaD | 18:37 |
abhishekk | yes, me too | 18:37 |
rosmaita | great ... maybe we will actually get this fixed! | 18:38 |
abhishekk | yes | 18:38 |
rosmaita | thanks for your work on this, you have been really helpful | 18:39 |
abhishekk | not just mine, all of our efforts :D | 18:40 |
abhishekk | I guess for doc patch one +2 will be sufficient, so I will opt out now if nothing is urgent atm | 18:41 |
abhishekk | and if tomorrow we have this postgres fix working then we will be good to rollout rc3 on monday | 18:42 |
rosmaita | abhishekk ++ | 18:44 |
rosmaita | have a good evening, talk to you tomorrow | 18:44 |
abhishekk | ok then, drop me a mail if you find something urgent, have a good day ahead | 18:44 |
*** abhishekk has quit IRC | 18:44 | |
*** rmcall has quit IRC | 18:55 | |
*** btully has joined #openstack-glance | 18:58 | |
*** harlowja has quit IRC | 19:00 | |
*** btully has quit IRC | 19:02 | |
*** gyee has joined #openstack-glance | 19:03 | |
openstackgerrit | Merged openstack/glance master: URI filtering for web-download https://review.openstack.org/542956 | 19:09 |
*** r-daneel has quit IRC | 19:27 | |
*** harlowja has joined #openstack-glance | 19:35 | |
*** harlowja_ has joined #openstack-glance | 19:37 | |
*** harlowja has quit IRC | 19:39 | |
*** pcaruana has quit IRC | 20:03 | |
*** AlexeyAbashkin has joined #openstack-glance | 20:15 | |
*** kukacz_ has quit IRC | 20:17 | |
*** AlexeyAbashkin has quit IRC | 20:19 | |
*** e0ne has joined #openstack-glance | 20:22 | |
*** r-daneel has joined #openstack-glance | 20:31 | |
rosmaita | jokke_ yt? | 20:32 |
openstackgerrit | Brian Rosmaita proposed openstack/glance master: Update admin docs for web-download import method https://review.openstack.org/544596 | 20:34 |
*** e0ne has quit IRC | 20:38 | |
*** e0ne has joined #openstack-glance | 20:38 | |
*** e0ne has quit IRC | 21:31 | |
*** pcaruana has joined #openstack-glance | 21:31 | |
*** openstack has joined #openstack-glance | 21:43 | |
*** ChanServ sets mode: +o openstack | 21:43 | |
*** pcaruana has quit IRC | 21:48 | |
*** rcernin has joined #openstack-glance | 21:50 | |
*** belmoreira has joined #openstack-glance | 22:12 | |
jokke_ | rosmaita: now I am | 22:23 |
rosmaita | jokke_ cool | 22:28 |
rosmaita | sorry, i know it's late there | 22:28 |
rosmaita | can you take a look at https://review.openstack.org/544596 ? | 22:28 |
rosmaita | i want to hit the changes you suggest in the follow up patch | 22:28 |
jokke_ | well I changed the patch to align with the documentation and you insisted to go otherwise with it, so I assumed that you would at least align the docs then to how you wanted the implementation to be ;P | 22:31 |
rosmaita | yeah but as far as the documentation goes, it is aligned exactly with web-download | 22:33 |
rosmaita | i'm writing the other part now, if there's no rush to merge this, we can do it tomorrow | 22:34 |
rosmaita | should be done in half hour or so | 22:35 |
rosmaita | although i always underestimate writing time | 22:35 |
jokke_ | the pep is gating, docs job is queued | 22:35 |
rosmaita | :) | 22:35 |
jokke_ | there is only 10 jobs in the gate atm | 22:35 |
*** btully has joined #openstack-glance | 22:36 | |
* jokke_ knocking the wood, not gonna say and jinx it | 22:36 | |
rosmaita | :P | 22:37 |
jokke_ | you ninja backported the uri-filters? | 22:37 |
rosmaita | i think sean +2d | 22:37 |
rosmaita | scott proposed the cherry pick | 22:37 |
rosmaita | so my hands were clean, no need to ninja | 22:38 |
jokke_ | so we have Sean ninjaing stuff into glance stable now? :o | 22:38 |
jokke_ | ;) | 22:38 |
rosmaita | well, i only consider it a ninja if it's a single +2A | 22:38 |
rosmaita | he +2d., and then i +2A'd | 22:39 |
jokke_ | oh, you +2'd in between :P | 22:39 |
rosmaita | so it was pretty normal, all things considered | 22:39 |
rosmaita | or, as normal as it gets with glance | 22:39 |
jokke_ | lol yeah | 22:39 |
*** btully has quit IRC | 22:40 | |
jokke_ | no between us it goes by the process as long as we backport our own patches the other can just +2A as the process says that if other stable-core proposes backport one +2 is enough ;) | 22:40 |
jokke_ | that's why it became a problem when Abhishek backported my patch 'cause I could not +2 being my own patch and you +2A would be on paper ninjaing it in ;) | 22:41 |
rosmaita | yeah, that's why i grabbed scott to cherry-pick and didn't do it myself | 22:42 |
jokke_ | but fortunately flaper reacted quick on the ping | 22:42 |
rosmaita | yeah, i saw that | 22:42 |
jokke_ | but yeah ... we need more active core and more active stable core ... at least one on both groups would help a lot | 22:43 |
*** threestrands has joined #openstack-glance | 22:43 | |
*** threestrands has quit IRC | 22:43 | |
*** threestrands has joined #openstack-glance | 22:43 | |
rosmaita | i agree | 22:43 |
*** itlinux has quit IRC | 23:09 | |
*** belmoreira has quit IRC | 23:17 | |
*** r-daneel has quit IRC | 23:24 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!