*** dalgaaf has quit IRC | 00:05 | |
*** dalgaaf has joined #openstack-glance | 00:07 | |
*** btully has joined #openstack-glance | 00:10 | |
*** btully has quit IRC | 00:14 | |
*** threestrands has joined #openstack-glance | 00:40 | |
*** threestrands has quit IRC | 00:40 | |
*** threestrands has joined #openstack-glance | 00:40 | |
*** itlinux has quit IRC | 00:59 | |
*** harlowja has quit IRC | 01:13 | |
*** abhishekk|mbl has joined #openstack-glance | 01:26 | |
*** mfedosin has quit IRC | 02:03 | |
openstackgerrit | Brian Rosmaita proposed openstack/glance_store master: Multihash Implementation for Glance https://review.openstack.org/528790 | 02:11 |
---|---|---|
*** rosmaita has quit IRC | 02:19 | |
*** gcb has joined #openstack-glance | 02:22 | |
*** mfedosin has joined #openstack-glance | 02:27 | |
*** dpawlik has joined #openstack-glance | 02:41 | |
*** dpawlik has quit IRC | 02:45 | |
*** udesale has joined #openstack-glance | 03:24 | |
*** abhishekk|mbl has quit IRC | 03:35 | |
*** btully has joined #openstack-glance | 03:48 | |
*** btully has quit IRC | 03:52 | |
*** udesale has quit IRC | 04:55 | |
*** udesale has joined #openstack-glance | 04:55 | |
*** abhishekk has joined #openstack-glance | 04:59 | |
*** pdeore has joined #openstack-glance | 05:04 | |
*** MrWatson has joined #openstack-glance | 05:10 | |
*** openstackgerrit has quit IRC | 05:10 | |
*** links has joined #openstack-glance | 05:15 | |
*** jmlowe has quit IRC | 05:16 | |
*** wxy has quit IRC | 05:16 | |
*** NostawRm has quit IRC | 05:16 | |
*** serverascode has quit IRC | 05:16 | |
*** ameade has quit IRC | 05:16 | |
*** pas-ha has quit IRC | 05:16 | |
*** DuncanT has quit IRC | 05:16 | |
*** Roamer` has quit IRC | 05:16 | |
*** jmccrory has quit IRC | 05:16 | |
*** harlowja has joined #openstack-glance | 05:28 | |
*** harlowja has quit IRC | 05:32 | |
*** jmlowe has joined #openstack-glance | 05:35 | |
*** wxy has joined #openstack-glance | 05:35 | |
*** serverascode has joined #openstack-glance | 05:35 | |
*** ameade has joined #openstack-glance | 05:35 | |
*** pas-ha has joined #openstack-glance | 05:35 | |
*** DuncanT has joined #openstack-glance | 05:35 | |
*** Roamer` has joined #openstack-glance | 05:35 | |
*** jmccrory has joined #openstack-glance | 05:35 | |
*** ratailor has joined #openstack-glance | 05:35 | |
*** Luzi has joined #openstack-glance | 05:45 | |
*** bkopilov has joined #openstack-glance | 06:03 | |
*** tshefi has joined #openstack-glance | 06:03 | |
*** pcaruana has joined #openstack-glance | 06:35 | |
*** alexchadin has joined #openstack-glance | 06:36 | |
*** dpawlik has joined #openstack-glance | 06:49 | |
*** openstackgerrit has joined #openstack-glance | 06:52 | |
openstackgerrit | wangxiyuan proposed openstack/python-glanceclient master: Do not quote token https://review.openstack.org/583468 | 06:52 |
*** peereb has joined #openstack-glance | 07:09 | |
*** tesseract has joined #openstack-glance | 07:18 | |
*** btully has joined #openstack-glance | 07:25 | |
*** rcernin has quit IRC | 07:28 | |
*** btully has quit IRC | 07:30 | |
*** AlexeyAbashkin has joined #openstack-glance | 07:45 | |
openstackgerrit | wangxiyuan proposed openstack/python-glanceclient master: Do not quote token https://review.openstack.org/583468 | 08:01 |
*** markvoelker_ has quit IRC | 08:07 | |
jokke_ | need to run an errand ... back at the afternoon | 08:35 |
*** bkopilov has quit IRC | 08:44 | |
abhishekk | jokke_, ok | 08:49 |
*** threestrands has quit IRC | 08:51 | |
*** dtantsur|afk is now known as dtantsur | 09:20 | |
*** hoonetorg has quit IRC | 09:34 | |
*** hoonetorg has joined #openstack-glance | 09:48 | |
*** abhishekk has quit IRC | 10:03 | |
*** markvoelker has joined #openstack-glance | 10:08 | |
*** alexchadin has quit IRC | 10:08 | |
*** kukacz_ has quit IRC | 10:12 | |
*** kukacz_ has joined #openstack-glance | 10:13 | |
*** alexchadin has joined #openstack-glance | 10:22 | |
*** dpawlik has quit IRC | 10:39 | |
*** dpawlik has joined #openstack-glance | 10:41 | |
*** markvoelker has quit IRC | 10:42 | |
*** priteau has joined #openstack-glance | 10:42 | |
*** bkopilov has joined #openstack-glance | 10:54 | |
*** dpawlik has quit IRC | 10:55 | |
*** dpawlik has joined #openstack-glance | 10:56 | |
*** btully has joined #openstack-glance | 11:03 | |
*** btully has quit IRC | 11:07 | |
smcginnis | o/ | 11:23 |
*** pdeore has quit IRC | 11:25 | |
*** ratailor has quit IRC | 11:38 | |
*** markvoelker has joined #openstack-glance | 11:39 | |
*** abhishekk|mbl has joined #openstack-glance | 11:44 | |
*** markvoelker has quit IRC | 12:05 | |
*** markvoelker has joined #openstack-glance | 12:05 | |
*** MattMan has quit IRC | 12:06 | |
*** MattMan has joined #openstack-glance | 12:07 | |
*** edmondsw has joined #openstack-glance | 12:11 | |
*** dpawlik has quit IRC | 12:30 | |
*** rosmaita has joined #openstack-glance | 12:36 | |
rosmaita | abhishekk|mbl : thanks for your multihash review, and especially for the testing you've done | 12:46 |
rosmaita | good point about the docstrings, i'll fix that now | 12:46 |
*** dpawlik has joined #openstack-glance | 12:47 | |
*** btully has joined #openstack-glance | 12:51 | |
*** dpawlik has quit IRC | 12:52 | |
*** btully has quit IRC | 12:56 | |
openstackgerrit | Brian Rosmaita proposed openstack/glance_store master: Multihash Implementation for Glance https://review.openstack.org/528790 | 13:02 |
*** lbragstad has quit IRC | 13:19 | |
openstackgerrit | Brian Rosmaita proposed openstack/glance_store master: Multihash Implementation for Glance https://review.openstack.org/528790 | 13:28 |
rosmaita | smcginnis ^^ when you get a chance later, i added one more test (no code changes, though) | 13:29 |
*** gcb has quit IRC | 13:31 | |
smcginnis | rosmaita: Awesome, more tests are always a good thing. | 13:32 |
smcginnis | Well, almost always. ;) | 13:32 |
*** alexchadin has quit IRC | 13:34 | |
*** alexchadin has joined #openstack-glance | 13:34 | |
*** alexchadin has quit IRC | 13:35 | |
*** alexchadin has joined #openstack-glance | 13:35 | |
*** lbragstad has joined #openstack-glance | 13:46 | |
*** r-daneel has joined #openstack-glance | 13:48 | |
*** dpawlik has joined #openstack-glance | 13:51 | |
abhishekk|mbl | rosmaita: no issues | 14:09 |
rosmaita | abhishekk|mbl ty | 14:11 |
rosmaita | abhishekk|mbl : how did you like the rewritten back-compat wrapper? | 14:12 |
abhishekk|mbl | rosmaita: its less complex and mor flexoble | 14:14 |
rosmaita | i tried to use the inspect module like erno suggested, but the problem is the way the compatability check wrapper is tested -- it relies on the name of of the function returned to verify that each driver is wrapped, so i had to wrap the add() with capabilities_check first, then my wrapper | 14:14 |
rosmaita | i didn't want to get into trying to refactor that stuff | 14:15 |
abhishekk|mbl | Sorry, i didn't checked what erno has suggested but the wrapper wriiten was very easy than the previous one | 14:23 |
*** udesale_ has joined #openstack-glance | 14:26 | |
*** udesale has quit IRC | 14:27 | |
*** alexchadin has quit IRC | 14:35 | |
*** alexchadin has joined #openstack-glance | 14:41 | |
jokke_ | rosmaita: so did the capabilities check wrapper break the inspect? | 14:50 |
*** peereb has quit IRC | 14:51 | |
rosmaita | yeah, i didn't investigate further, was getting an error something like hashing_algo unknown argument | 14:53 |
rosmaita | when i did the inspect.getargspec | 14:53 |
rosmaita | there's probably a way to get around that but i didnt' want to get into it | 14:54 |
*** pcaruana has quit IRC | 14:56 | |
rosmaita | actually, it was when i tried to get the position of hashing_algo from the argspec | 14:57 |
*** jmlowe has quit IRC | 15:00 | |
jokke_ | I think literally only thing what was needed was that @wraps(...) wrapper for the inner function of that capabilities check | 15:00 |
jokke_ | or decorator I should say ... as decorating function without it basically hides the original function details otherwise ands the capabilities.check function (which is decorator) does not have it | 15:02 |
jokke_ | if this works as it is I'm fine with that for now ... i might play around with it some day if I get super bored | 15:04 |
jokke_ | but thanks, the back_compat_add looks already much cleaner and easier to follow | 15:05 |
rosmaita | yeah, i tried that, but there's a test for compatability check that relies on the name of the wrapped function being compat_check or something, so when i used @wraps on compat-check those tests all failed | 15:08 |
jokke_ | Oh FFS | 15:08 |
jokke_ | ;) | 15:08 |
rosmaita | that's why i had to use @wraps so that the name of the function you get back from my wrapper is actually named compatabilitiy_check | 15:08 |
rosmaita | yeah | 15:08 |
rosmaita | there's definitely a better way to do that stuff, but i figure that's a different patch | 15:09 |
jokke_ | ohh yeah | 15:09 |
*** tshefi has quit IRC | 15:09 | |
rosmaita | in any case, your suggestion was really good, simplified that crazy thing i wrote by a lot! | 15:09 |
* jokke_ makes a mental note of the next set of shitty tests to throw away | 15:09 | |
rosmaita | well, they're good tests in the sense that they make sure the capabilities wrapper is being used, it's just the way they do it that sucks | 15:10 |
*** alexchadin has quit IRC | 15:10 | |
rosmaita | ... and where i'm saying compatability_check above, i of course mean capabilities_check | 15:11 |
rosmaita | :) | 15:11 |
jokke_ | yeah | 15:11 |
rosmaita | i have backward compatability stuck in my head! | 15:11 |
jokke_ | ;) | 15:11 |
jokke_ | yeah you know the problem with python is that it's super relaxed how you can call the functions | 15:12 |
jokke_ | which means that any decorators like this gets easily super complex without either hardcoding stuff (like you had to do now, and possibly causing grey hair to someone in future) or the inspect | 15:13 |
rosmaita | yeah, the inspect module is cool | 15:13 |
jokke_ | I've really learned to love that feature when using decorators | 15:13 |
jokke_ | 'cause you can have pretty muc any combo of positional and kw args as long as you don't call with keyword anything that is at/before the positionals and it will be just fine function call | 15:15 |
jokke_ | also totally unrelated to your change, but I think we should throw that _check_metadata away from production code and move it to tests ;) | 15:18 |
jokke_ | not trusting our own driver code in production is extremely wasteful thing to do (bit like schema validating every field in the image-list call) ;) | 15:18 |
rosmaita | yeah, i was wondering about that, but figured it was not a related change | 15:22 |
rosmaita | yes, would be better in some kind of test | 15:22 |
*** jmlowe has joined #openstack-glance | 15:24 | |
jokke_ | so instead of extending the wrapping to store_add_to_backend you just plan to use the store_add_to_backend_with_multihash in glance internally to maintain the backwards compatibility on that layer of the glance_store? | 15:25 |
*** jose-phillips has quit IRC | 15:25 | |
rosmaita | yeah, i figured that the store_add_to_backend is supposed to be the entry point for consumers, so best to leave that one as is | 15:26 |
rosmaita | but i don't know, it's really just us and glare at this point | 15:27 |
jokke_ | I'm fine with that, could you please make a follow up patch to deprecate it so we can throw it away on the 1.0.0 release as well. We wanted to be backwards compatible with muti back-ends and the multihash as we don't have time to warn anyone we're changing things right now, but I'd like to get that cleaned out as well | 15:27 |
jokke_ | we Glare we know of | 15:27 |
jokke_ | then there is the possibility that X other things, perhaps outside of the OpenStack ecosystem is using it | 15:28 |
jokke_ | *well Glare | 15:28 |
rosmaita | right | 15:28 |
rosmaita | ok, i can put up a deprecation patch | 15:29 |
jokke_ | We've been asked to provide secure hashing for so long that I really don't want to maintain non-secure path any longer we absolutely have to | 15:29 |
rosmaita | i'll do it now, meeting i was supposed to have got cancelled | 15:29 |
jokke_ | coolcool | 15:30 |
*** links has quit IRC | 15:55 | |
*** pcaruana has joined #openstack-glance | 16:00 | |
*** lbragstad has quit IRC | 16:02 | |
abhishekk|mbl | I guess infra has some problem | 16:02 |
abhishekk|mbl | GlanceStore 0.25.0 is available on pypi but its not published on mirror used by infra | 16:03 |
abhishekk|mbl | They are out of space as of now | 16:03 |
rosmaita | bummer | 16:07 |
jokke_ | recheck the tips job | 16:08 |
jokke_ | that will pull the current state of the repo into the test run | 16:08 |
rosmaita | arrgh ... the multihash patch had passed everything but tempest, guess it will have to start over | 16:08 |
rosmaita | though maybe they are only restarting the zuul interface, not zuul itself | 16:09 |
openstackgerrit | Brian Rosmaita proposed openstack/glance_store master: Deprecate store_add_to_backend() https://review.openstack.org/583657 | 16:11 |
*** udesale_ has quit IRC | 16:13 | |
*** udesale has joined #openstack-glance | 16:13 | |
*** udesale has quit IRC | 16:18 | |
*** Luzi has quit IRC | 16:21 | |
*** btully has joined #openstack-glance | 16:29 | |
*** btully has quit IRC | 16:33 | |
*** AlexeyAbashkin has quit IRC | 16:36 | |
*** AlexeyAbashkin has joined #openstack-glance | 16:39 | |
*** AlexeyAbashkin has quit IRC | 16:43 | |
*** abhishekk has joined #openstack-glance | 16:49 | |
*** lbragstad has joined #openstack-glance | 16:50 | |
*** abhishekk|mbl has quit IRC | 16:55 | |
*** prometheanfire has left #openstack-glance | 16:57 | |
abhishekk | jokke_, rosmaita when are we targeting to release 0.26.0? | 17:03 |
rosmaita | abhishekk : tomorrow | 17:23 |
*** jose-phillips has joined #openstack-glance | 17:24 | |
*** dtantsur is now known as dtantsur|afk | 17:26 | |
rosmaita | abhishekk actually, today, but i think it is going to take all day to get multihash merged | 17:27 |
abhishekk | rosmaita, yes, gate is quiet slow | 17:33 |
*** tesseract has quit IRC | 17:35 | |
*** r-daneel has quit IRC | 17:45 | |
*** r-daneel has joined #openstack-glance | 17:47 | |
*** abhishekk has quit IRC | 17:51 | |
*** r-daneel_ has joined #openstack-glance | 17:53 | |
*** r-daneel has quit IRC | 17:53 | |
*** r-daneel_ is now known as r-daneel | 17:53 | |
*** abhishekk|mbl has joined #openstack-glance | 18:00 | |
*** pcaruana has quit IRC | 18:08 | |
rosmaita | jokke_ abhishekk|mbl smcginnis : https://review.openstack.org/#/c/528790/11 just got +1 from zuul if someone would like to do the honors | 18:09 |
rosmaita | also https://review.openstack.org/#/c/583657/ | 18:11 |
*** itlinux has joined #openstack-glance | 18:13 | |
*** btully has joined #openstack-glance | 18:18 | |
*** btully has quit IRC | 18:22 | |
abhishekk|mbl | rosmaita: i just have one question | 18:30 |
*** itlinux has quit IRC | 18:31 | |
rosmaita | abhishekk|mbl sure | 18:31 |
abhishekk|mbl | We will be deprecating capabilities related config parameter right? | 18:32 |
abhishekk|mbl | So later we also need to remove capabilities_check decorator? | 18:32 |
rosmaita | not exactly | 18:33 |
rosmaita | the deprecated config param has to do with dynamic capabiities updates | 18:33 |
rosmaita | although | 18:33 |
rosmaita | i get your point, why bother checking each time for static capabilities? | 18:33 |
rosmaita | i have not thought that far ahead, tbh | 18:34 |
abhishekk|mbl | Yes | 18:34 |
abhishekk|mbl | Ok | 18:34 |
*** itlinux has joined #openstack-glance | 18:34 | |
abhishekk|mbl | I guess I will +w to multihash patch now, just curious to hear from jokke_ | 18:35 |
abhishekk|mbl | If he has any questions, thought on this | 18:35 |
rosmaita | yeah, the capabilities stuff looks like it could be useful, but we really don't use it at all, i don't think | 18:35 |
smcginnis | rosmaita, abhishekk|mbl: I just approved. Should I hold that one? | 18:36 |
abhishekk|mbl | No, let it be | 18:36 |
abhishekk|mbl | smcginnis: have a look at release notes patch as well | 18:37 |
rosmaita | https://review.openstack.org/#/c/583657/ | 18:37 |
rosmaita | once those merge i will put up releases patch with a -W and we can make sure the glance_store-tips job passes before doing a release | 18:38 |
abhishekk|mbl | rosmaita, could you please have look at modified hidden images specs | 18:38 |
smcginnis | Done | 18:38 |
rosmaita | abhishekk|mbl will do | 18:38 |
abhishekk|mbl | smcginnis, jokke_ ^^ | 18:39 |
smcginnis | I was thinking it was a little too low level of detail for a release note, but since this is a lib that makes sense. | 18:39 |
abhishekk|mbl | Thank you | 18:39 |
rosmaita | smcginnis ty | 18:39 |
abhishekk|mbl | https://review.openstack.org/#/c/580568/ | 18:40 |
abhishekk|mbl | specs ^^ | 18:40 |
rosmaita | abhishekk|mbl ty | 18:41 |
rosmaita | abhishekk|mbl : can a user specify "hidden": true for image-create? | 18:44 |
abhishekk|mbl | rosmaita: need to check, will confirm tomorrow is that ok? | 18:45 |
rosmaita | oh yeah, no problem | 18:46 |
rosmaita | i forgot that it is late for you | 18:46 |
rosmaita | i will check myself if i have some time | 18:46 |
abhishekk|mbl | I think he can, so that need to restrict as well | 18:46 |
rosmaita | thanks for your reviews today, have a good evening | 18:46 |
abhishekk|mbl | If you able to verify, please comment on the specs | 18:46 |
abhishekk|mbl | Thank you, have a good day ahead | 18:47 |
*** harlowja has joined #openstack-glance | 18:54 | |
*** priteau has quit IRC | 18:58 | |
abhishekk|mbl | rosmaita: uese can specify -- hidden 'true' at the time of creation but glance does not consider it it sets hidden=False to newly created image as described in the specs | 19:04 |
abhishekk|mbl | s/uses/user | 19:04 |
rosmaita | ok, thanks | 19:04 |
rosmaita | i think the spec says false unless specified otherwise | 19:05 |
rosmaita | but we can change the spec | 19:05 |
rosmaita | (or you can, rather) | 19:05 |
rosmaita | for the use case we have, i don't think it matters if the image must be created with hidden==false | 19:05 |
rosmaita | also, if you have a minute, i'm wondering about the 409 for pre-rocky | 19:06 |
abhishekk|mbl | I guess we should not allow --hidden at the time of creation? | 19:06 |
rosmaita | won't pre-rocky glance treat 'hidden' as user custom metadata? | 19:06 |
rosmaita | abhishekk|mbl i think we could allow it ... maybe we should discuss at glance meeting tomorrow | 19:07 |
abhishekk|mbl | Means user should able to create hidden image? | 19:07 |
rosmaita | i don't know, it would be kind of dumb to create an image that disappears immediately | 19:08 |
rosmaita | i think not allowing at creation would be OK | 19:08 |
abhishekk|mbl | Yeah | 19:08 |
rosmaita | i think pre-rocky glance will be ok with a user creating | 19:09 |
rosmaita | i mean updating | 19:09 |
rosmaita | an image "hidden":" | 19:09 |
rosmaita | shoot, sorry, bad fingers today | 19:09 |
abhishekk|mbl | Anyway good thing to discuss in tomorrow's meeting ( please remind me :)) | 19:10 |
abhishekk|mbl | Yeah that will be ok to update | 19:10 |
rosmaita | i think it will allow "hidden": "true" in JSON (note that true is a string) | 19:10 |
rosmaita | i think it will not allow "hidden": true where true is a JSON boolean | 19:10 |
abhishekk|mbl | Yes | 19:10 |
rosmaita | ok | 19:11 |
rosmaita | i will put this on tomorrow's agenda, ttyl -- go get some sleep! | 19:11 |
abhishekk|mbl | Yeah, thank you | 19:13 |
*** abhishekk|mbl has quit IRC | 19:20 | |
*** dpawlik has quit IRC | 19:47 | |
*** arvindn05 has quit IRC | 19:48 | |
*** arvindn05 has joined #openstack-glance | 19:52 | |
*** itlinux has quit IRC | 20:09 | |
openstackgerrit | Merged openstack/glance_store master: Multihash Implementation for Glance https://review.openstack.org/528790 | 20:10 |
openstackgerrit | Merged openstack/glance_store master: Deprecate store_add_to_backend() https://review.openstack.org/583657 | 20:10 |
rosmaita | woot! | 20:10 |
*** r-daneel has quit IRC | 20:31 | |
*** jmlowe has quit IRC | 20:36 | |
*** itlinux has joined #openstack-glance | 20:37 | |
*** r-daneel has joined #openstack-glance | 20:40 | |
*** itlinux has quit IRC | 20:42 | |
*** dpawlik has joined #openstack-glance | 20:56 | |
*** dpawlik has quit IRC | 21:00 | |
*** edmondsw has quit IRC | 21:54 | |
*** btully has joined #openstack-glance | 21:56 | |
*** btully has quit IRC | 22:00 | |
*** linkmark has joined #openstack-glance | 22:03 | |
*** MrWatson has quit IRC | 22:12 | |
*** NostawRm has joined #openstack-glance | 22:12 | |
*** jmlowe has joined #openstack-glance | 22:24 | |
*** jmlowe has quit IRC | 22:25 | |
*** jmlowe has joined #openstack-glance | 22:25 | |
*** lbragstad has quit IRC | 22:29 | |
*** rcernin has joined #openstack-glance | 22:32 | |
*** imacdonn has quit IRC | 22:44 | |
*** imacdonn has joined #openstack-glance | 22:45 | |
*** dpawlik has joined #openstack-glance | 22:57 | |
*** jmlowe has quit IRC | 22:58 | |
*** jmlowe has joined #openstack-glance | 22:58 | |
*** dpawlik has quit IRC | 23:01 | |
*** itlinux has joined #openstack-glance | 23:04 | |
*** jmlowe has quit IRC | 23:05 | |
*** itlinux has quit IRC | 23:16 | |
*** itlinux has joined #openstack-glance | 23:28 | |
*** jmlowe has joined #openstack-glance | 23:37 | |
*** btully has joined #openstack-glance | 23:44 | |
*** btully has quit IRC | 23:48 | |
*** threestrands has joined #openstack-glance | 23:50 | |
*** threestrands has quit IRC | 23:50 | |
*** threestrands has joined #openstack-glance | 23:50 | |
*** rosmaita has quit IRC | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!