openstackgerrit | Merged openstack/python-glanceclient master: Add multi-store support https://review.openstack.org/575370 | 00:39 |
---|---|---|
openstackgerrit | Merged openstack/python-glanceclient master: Add release note for multi-store support https://review.openstack.org/585541 | 00:39 |
*** btully has joined #openstack-glance | 00:46 | |
*** btully has quit IRC | 00:50 | |
openstackgerrit | Merged openstack/python-glanceclient master: Unit tests for multi-store support https://review.openstack.org/577115 | 00:55 |
*** links has joined #openstack-glance | 01:30 | |
openstackgerrit | wangxiyuan proposed openstack/python-glanceclient master: Do not quote token https://review.openstack.org/583468 | 01:33 |
*** gyee has quit IRC | 01:55 | |
openstackgerrit | wangxiyuan proposed openstack/python-glanceclient master: Do not quote token https://review.openstack.org/583468 | 02:16 |
*** twouters has quit IRC | 02:33 | |
*** twouters has joined #openstack-glance | 02:33 | |
*** twouters has quit IRC | 02:33 | |
*** twouters has joined #openstack-glance | 02:33 | |
*** btully has joined #openstack-glance | 02:34 | |
*** btully has quit IRC | 02:39 | |
openstackgerrit | Brian Rosmaita proposed openstack/python-glanceclient master: Add release note for hidden images support https://review.openstack.org/585555 | 02:55 |
*** zhurong has joined #openstack-glance | 03:27 | |
*** pdeore has joined #openstack-glance | 03:35 | |
*** dalgaaf has quit IRC | 03:50 | |
*** dalgaaf has joined #openstack-glance | 03:52 | |
openstackgerrit | Brian Rosmaita proposed openstack/python-glanceclient master: Add support for hide old images https://review.openstack.org/579117 | 03:58 |
*** rosmaita has quit IRC | 03:59 | |
*** zhurong has quit IRC | 04:27 | |
*** r-daneel has joined #openstack-glance | 04:37 | |
*** udesale has joined #openstack-glance | 04:39 | |
*** udesale has quit IRC | 04:42 | |
*** udesale has joined #openstack-glance | 04:43 | |
*** udesale_ has joined #openstack-glance | 05:13 | |
*** udesale has quit IRC | 05:15 | |
*** udesale_ has quit IRC | 05:19 | |
*** udesale has joined #openstack-glance | 05:20 | |
*** ratailor has joined #openstack-glance | 05:22 | |
*** hoonetorg has quit IRC | 06:01 | |
*** btully has joined #openstack-glance | 06:12 | |
*** Luzi has joined #openstack-glance | 06:15 | |
*** btully has quit IRC | 06:17 | |
*** hoonetorg has joined #openstack-glance | 06:17 | |
*** abhishekk has joined #openstack-glance | 06:20 | |
*** pcaruana has joined #openstack-glance | 06:33 | |
*** pdeore_ has joined #openstack-glance | 06:44 | |
*** pdeore has quit IRC | 06:46 | |
*** pdeore_ has quit IRC | 06:52 | |
*** pdeore has joined #openstack-glance | 06:53 | |
*** rcernin has quit IRC | 06:59 | |
*** tesseract has joined #openstack-glance | 07:16 | |
*** dtantsur|afk is now known as dtantsur | 07:28 | |
*** AlexeyAbashkin has joined #openstack-glance | 07:42 | |
*** btully has joined #openstack-glance | 08:01 | |
*** alexchadin has joined #openstack-glance | 08:04 | |
*** btully has quit IRC | 08:05 | |
openstackgerrit | Abhishek Kekane proposed openstack/python-glanceclient master: Add support for hide old images https://review.openstack.org/579117 | 08:15 |
abhishekk | jokke_, hi, around? | 08:16 |
openstackgerrit | wangxiyuan proposed openstack/python-glanceclient master: Do not quote '+' for token header https://review.openstack.org/583468 | 08:24 |
*** btully has joined #openstack-glance | 08:29 | |
*** rcernin has joined #openstack-glance | 08:29 | |
*** openstackgerrit has quit IRC | 08:48 | |
*** btully has quit IRC | 09:00 | |
*** tshefi has joined #openstack-glance | 09:23 | |
*** d0ugal has joined #openstack-glance | 09:36 | |
*** d0ugal has quit IRC | 09:36 | |
*** d0ugal has joined #openstack-glance | 09:36 | |
*** lifeless has quit IRC | 09:37 | |
*** Tahvok has quit IRC | 09:50 | |
*** Tahvok has joined #openstack-glance | 09:51 | |
*** alexchadin has quit IRC | 09:59 | |
*** alexchadin has joined #openstack-glance | 10:08 | |
*** d0ugal has quit IRC | 10:21 | |
*** kukacz_ has quit IRC | 10:23 | |
*** kukacz_ has joined #openstack-glance | 10:23 | |
*** lifeless has joined #openstack-glance | 10:23 | |
*** alexchad_ has joined #openstack-glance | 10:35 | |
*** alexchad_ has quit IRC | 10:36 | |
*** alexchadin has quit IRC | 10:36 | |
*** btully has joined #openstack-glance | 10:46 | |
*** edmondsw has joined #openstack-glance | 10:49 | |
*** btully has quit IRC | 10:50 | |
*** pdeore has quit IRC | 11:02 | |
*** alexchadin has joined #openstack-glance | 11:09 | |
*** abhishekk has quit IRC | 11:12 | |
*** ratailor has quit IRC | 11:14 | |
*** alexchadin has quit IRC | 11:15 | |
*** rcernin has quit IRC | 11:21 | |
*** abhishekk-mbl has joined #openstack-glance | 11:22 | |
*** alexchadin has joined #openstack-glance | 11:37 | |
*** MattMan has quit IRC | 12:08 | |
*** MattMan has joined #openstack-glance | 12:08 | |
jokke_ | abhishekk-mbl: here now | 12:23 |
abhishekk-mbl | Pushed new patch for hidden images client support, added a comment on PS 9 please have a look | 12:24 |
jokke_ | k | 12:24 |
abhishekk-mbl | Thank you | 12:25 |
*** btully has joined #openstack-glance | 12:34 | |
*** btully has quit IRC | 12:39 | |
*** r-daneel has quit IRC | 12:57 | |
*** Tahvok has quit IRC | 13:08 | |
*** Tahvok has joined #openstack-glance | 13:11 | |
*** rosmaita has joined #openstack-glance | 13:12 | |
jokke_ | abhishekk-mbl: so ow do we do it on the other boolean values we take? I don't see any bool args in | 13:16 |
rosmaita | jokke_ maybe it's handled in the schema_args decorator, using the type from the schema? | 13:18 |
abhishekk-mbl | Yes it handled in schema_args | 13:20 |
abhishekk-mbl | If you pass yes, true 1 to --protected then it will be converted to True | 13:20 |
abhishekk-mbl | If you pass any other value say xyz then it is convert to false | 13:21 |
jokke_ | oh ok ... and which way schema args deals with it, does it allow all the different inputs (like True, true, 1, yes)? Just want us to be consistent with the inputs. | 13:21 |
abhishekk-mbl | Yes | 13:22 |
jokke_ | ok, so the schema args works same ways at that string_to_bool? | 13:22 |
abhishekk-mbl | No my string_to_bool will just accept true or false | 13:22 |
abhishekk-mbl | For any other values it will raise error | 13:23 |
rosmaita | i think there | 13:23 |
rosmaita | 's an oslo util that does the more general conversion | 13:23 |
rosmaita | if we want that | 13:23 |
abhishekk-mbl | If we want to be consistent then we need to change type to strutils.string_from_bool | 13:23 |
abhishekk-mbl | I have mentioned that in my comment | 13:24 |
jokke_ | yeah I think that would be the right thing to do | 13:24 |
rosmaita | agreed, if we're already using it for protected, should use it here too | 13:24 |
abhishekk-mbl | Can somebody put a patch with tht change? I am in gym now :D | 13:24 |
rosmaita | i can do that | 13:24 |
abhishekk-mbl | Thank you | 13:25 |
jokke_ | fair enough, thanks Brian | 13:25 |
rosmaita | np, have a good workout | 13:25 |
abhishekk-mbl | Yeah, no pain no gain :D | 13:25 |
jokke_ | rosmaita: and it's strutils.bool_from_string not string_from_bool I think | 13:25 |
jokke_ | abhishekk-mbl: absolutely right! | 13:25 |
jokke_ | and it gets (normally) head well out of work | 13:25 |
abhishekk-mbl | rosmaita: , i mentioned methid name in my comment, need to change it for create, create-via-import and update methods im shell.py | 13:26 |
abhishekk-mbl | jokke_: exactly | 13:26 |
*** d0ugal has joined #openstack-glance | 13:27 | |
rosmaita | abhishekk-mbl thanks for the pointers | 13:30 |
*** d0ugal has quit IRC | 13:45 | |
*** r-daneel has joined #openstack-glance | 13:55 | |
*** Luzi has quit IRC | 14:09 | |
*** btully has joined #openstack-glance | 14:23 | |
*** openstackgerrit has joined #openstack-glance | 14:27 | |
openstackgerrit | Brian Rosmaita proposed openstack/python-glanceclient master: Add support for hide old images https://review.openstack.org/579117 | 14:27 |
rosmaita | i tried to add some tests, but gave up | 14:27 |
*** btully has quit IRC | 14:28 | |
jokke_ | we can get back to those | 14:32 |
rosmaita | hopefully abhishek has a test env handy with his glance hidden images patch | 14:32 |
*** links has quit IRC | 14:33 | |
*** udesale has quit IRC | 14:48 | |
*** imacdonn has quit IRC | 14:51 | |
*** imacdonn has joined #openstack-glance | 14:51 | |
*** pcaruana has quit IRC | 14:52 | |
rosmaita | jokke_ : how are we looking for https://launchpad.net/python-glanceclient/+milestone/2.11.2 ? | 14:54 |
rosmaita | also, do we want to do 2.10.1 while we're at it from stable/queens ? | 14:57 |
rosmaita | https://launchpad.net/python-glanceclient/+milestone/2.10.1 | 14:57 |
jokke_ | rosmaita: I moved that final to 2.12.0 as we have new features included | 14:58 |
rosmaita | ok, makes sense | 14:58 |
jokke_ | but it's looking pretty much what we can do | 14:58 |
jokke_ | I'm way more worried Rocky-3 in glance than the gc | 14:59 |
rosmaita | are you going to do a prelude releasenote? and what about wxy's patch | 14:59 |
jokke_ | I'll have a look what we have merged ... reno only is super quick to gate | 15:01 |
jokke_ | I'll get something to eat now ... brb | 15:01 |
jokke_ | b | 15:06 |
*** r-daneel has quit IRC | 15:07 | |
*** r-daneel has joined #openstack-glance | 15:08 | |
*** r-daneel has quit IRC | 15:19 | |
abhishekk-mbl | rosmaita: i will test once back to home | 15:24 |
rosmaita | abhishekk-mbl ty | 15:24 |
*** r-daneel has joined #openstack-glance | 15:27 | |
*** gyee has joined #openstack-glance | 15:29 | |
*** alexchadin has quit IRC | 15:48 | |
*** itlinux has joined #openstack-glance | 15:49 | |
*** alexchadin has joined #openstack-glance | 15:50 | |
*** abhishekk has joined #openstack-glance | 16:05 | |
*** btully has joined #openstack-glance | 16:12 | |
*** tshefi has quit IRC | 16:14 | |
*** btully has quit IRC | 16:17 | |
*** rosmaita has quit IRC | 16:19 | |
*** rosmaita has joined #openstack-glance | 16:22 | |
*** alexchadin has quit IRC | 16:26 | |
*** alexchadin has joined #openstack-glance | 16:26 | |
*** alexchadin has quit IRC | 16:27 | |
*** alexchadin has joined #openstack-glance | 16:27 | |
*** alexchadin has quit IRC | 16:27 | |
abhishekk | rosmaita, around? | 16:28 |
*** alexchadin has joined #openstack-glance | 16:28 | |
rosmaita | abhishekk hello | 16:28 |
*** alexchadin has quit IRC | 16:28 | |
abhishekk | changes which you have made are working, I just needed to change in line of code in glance | 16:29 |
*** alexchadin has joined #openstack-glance | 16:29 | |
rosmaita | oh, cool | 16:29 |
*** alexchadin has quit IRC | 16:29 | |
rosmaita | i was wondering about making the image-list option a boolean, but it looked the way to do it | 16:29 |
abhishekk | rosmaita, yes its better to be identical for all calls | 16:31 |
abhishekk | for that only I needed to change one line in v2/images.py index method | 16:32 |
abhishekk | Do we need to mention it in release notes also? i.e. it will work for yes, y, true, True, 1 as well as no, n, false, False, 0 | 16:33 |
rosmaita | no, we can mention that in user docs if we want (or let it be a pleasant surprise for people) | 16:34 |
abhishekk | :D | 16:37 |
abhishekk | ok | 16:37 |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Hide old images https://review.openstack.org/578755 | 16:38 |
abhishekk | jokke_, smcginnis could you please have a look at specs, https://review.openstack.org/#/c/580568/ | 16:41 |
abhishekk | thank you | 16:41 |
smcginnis | Catching up on things this morning and hoping to devote some more time to reviews soon. | 16:41 |
abhishekk | smcginnis, ack | 16:43 |
*** abhishekk has quit IRC | 16:45 | |
*** tesseract has quit IRC | 16:53 | |
*** alexchadin has joined #openstack-glance | 17:00 | |
*** alexchadin has quit IRC | 17:06 | |
*** Nil_ has quit IRC | 17:06 | |
*** dtantsur is now known as dtantsur|afk | 17:13 | |
*** AlexeyAbashkin has quit IRC | 17:17 | |
*** alexchadin has joined #openstack-glance | 17:41 | |
*** alexchadin has quit IRC | 17:46 | |
*** itlinux has quit IRC | 17:47 | |
*** itlinux has joined #openstack-glance | 17:51 | |
*** btully has joined #openstack-glance | 18:01 | |
*** markvoelker_ has joined #openstack-glance | 18:05 | |
*** btully has quit IRC | 18:05 | |
*** markvoelker has quit IRC | 18:06 | |
*** rcernin has joined #openstack-glance | 18:09 | |
*** tshefi has joined #openstack-glance | 18:40 | |
abhishekk-mbl | jokke_: around? | 18:49 |
abhishekk-mbl | Client patch for hiding old images looks good to go now :D | 18:49 |
jokke_ | abhishekk-mbl: yeah, I'm here | 18:49 |
jokke_ | I'll merge the reno for it as well unless objections | 18:51 |
abhishekk-mbl | Can anyone modify the specs patch please, at my place we lost the electricity due to rain :( | 18:51 |
abhishekk-mbl | Yeah, reno looks good to me | 18:51 |
*** rcernin has quit IRC | 18:53 | |
itlinux | hello guys. I have an image that was in the backend of swift.. and now I move the backend to cinder.. what's the best way to remove the image.. since glance image-delete does not work.. I set the db status to deleted but I would like to remove it from the glance image-list | 18:56 |
jokke_ | abhishekk-mbl: I'll fix the formatting on the spec and merge it before I call it a night today | 18:57 |
abhishekk-mbl | I will try to edit it from mobile | 18:57 |
abhishekk-mbl | jokke_: thank you :D | 18:57 |
rosmaita | jokke_ with the hidden images and reno for them merged, is there anything else outstanding? | 19:00 |
jokke_ | rosmaita: for gc the wxy's bugfix and all the glance stuff | 19:00 |
abhishekk-mbl | I think wxy's approach is clear enough | 19:01 |
rosmaita | ok, i will +A wxy's bugfix and then i think that is all for glanceclient ... unless you want to add a "prelude" reno? | 19:02 |
abhishekk-mbl | Unless we need reno, i guess all done for glanceclient | 19:05 |
jokke_ | Apart from these we seem to have mostly testing and doc related changes since 2.11.1 | 19:06 |
abhishekk-mbl | Yeah | 19:07 |
*** rcernin has joined #openstack-glance | 19:09 | |
*** d0ugal has joined #openstack-glance | 19:11 | |
*** rcernin has quit IRC | 19:16 | |
*** alexchadin has joined #openstack-glance | 19:42 | |
*** d0ugal has quit IRC | 19:46 | |
*** alexchadin has quit IRC | 19:47 | |
*** btully has joined #openstack-glance | 19:50 | |
*** btully has quit IRC | 19:54 | |
*** tshefi has quit IRC | 19:58 | |
*** tshefi has joined #openstack-glance | 19:59 | |
jokke_ | I'll be afk about of an hour ... the hidden image client stuff should be merged by that | 20:09 |
*** rosmaita has quit IRC | 20:09 | |
*** rosmaita has joined #openstack-glance | 20:10 | |
itlinux | hi all, I have an image that I wanted to force delete what's the best way since I do not want it to show up.. | 20:14 |
itlinux | I cannot delete since I move backends.. | 20:14 |
*** alexchadin has joined #openstack-glance | 20:17 | |
*** alexchadin has quit IRC | 20:17 | |
*** edmondsw has quit IRC | 20:28 | |
*** edmondsw has joined #openstack-glance | 20:28 | |
*** edmondsw has quit IRC | 20:32 | |
rosmaita | itlinux i guess you are getting a failure when glance can't find the image data to delete? | 20:34 |
itlinux | yes.. | 20:34 |
rosmaita | do you have administrative privileges in glance? | 20:35 |
itlinux | and from the DB it says it's tight into some other parents.. | 20:35 |
itlinux | yes | 20:35 |
itlinux | I am the admin | 20:35 |
rosmaita | can you explain your comment "from the DB it says it's tight into some other parents" a bit more? | 20:37 |
abhishekk-mbl | I guess image has associated records in tags, members or properties table? | 20:38 |
itlinux | yea | 20:38 |
itlinux | it's calling some other propeties.. | 20:38 |
rosmaita | ah, so you did try to delete it by hand from the db? | 20:38 |
abhishekk-mbl | I guess yes | 20:39 |
rosmaita | got foreign key constraint violations | 20:39 |
itlinux | that's what I did try | 20:39 |
itlinux | unless there is a specific command .. | 20:39 |
rosmaita | well, you should be able to soft-delete all that stuff | 20:39 |
openstackgerrit | Merged openstack/python-glanceclient master: Add support for hide old images https://review.openstack.org/579117 | 20:39 |
openstackgerrit | Merged openstack/python-glanceclient master: Add release note for hidden images support https://review.openstack.org/585555 | 20:39 |
itlinux | let me try and see what it says.. | 20:39 |
openstackgerrit | Merged openstack/python-glanceclient master: Do not quote '+' for token header https://review.openstack.org/583468 | 20:39 |
itlinux | rosmaita what command will that be to soft-delete? | 20:40 |
rosmaita | you have to do it by hand | 20:40 |
itlinux | are steps anywhere? | 20:40 |
rosmaita | if you do a "describe images" to see the images table | 20:40 |
rosmaita | you will see a 'deleted' and 'deleted_at' column | 20:40 |
rosmaita | same thing on image_properties, image_locations, image_tags | 20:41 |
itlinux | yes | 20:41 |
rosmaita | i don't remember if it is a boolean or a tinyint | 20:41 |
itlinux | ERROR 1451 (23000): Cannot delete or update a parent row: a foreign key constraint fails (`glance`.`image_locations`, CONSTRAINT `image_locations_ibfk_1` FOREIGN KEY (`image_id`) REFERENCES `images` (`id`)) | 20:42 |
itlinux | delete from images where id = 'e5f3eaaa-ac4e-4696-9256-7bfd096ad5c4'; this is the command | 20:42 |
rosmaita | yes, you don't want to do that one | 20:43 |
abhishekk-mbl | \o/ glanceclient all in, I am going off the hook now | 20:43 |
rosmaita | abhishekk-mbl congratulations! i will put up release patch in a few min | 20:43 |
abhishekk-mbl | Have a nice day ahead rosmaita, jokke_, smcginnis | 20:43 |
smcginnis | abhishekk-mbl: Thanks, have a good night! | 20:44 |
rosmaita | itlinux look in the images table for a deleted image, something like 'select * from images where deleted = 1 limit 1; | 20:44 |
abhishekk-mbl | Great team work, good day | 20:44 |
*** abhishekk-mbl has quit IRC | 20:44 | |
rosmaita | abhishekk-mbl have a good evening, you put in a lot of work on glanceclient the past 2 weeks | 20:45 |
itlinux | Empty set (0.00 sec) | 20:45 |
rosmaita | itlinux give me a minute, i should have a glance db around somewhere | 20:46 |
itlinux | select * from images where status='deleted'; | 20:46 |
itlinux | this shows up | 20:46 |
itlinux | but deleted show 0 not 1 | 20:47 |
rosmaita | guess you don't have any deleted images in your db | 20:47 |
itlinux | http://paste.openstack.org/show/726651/ | 20:47 |
rosmaita | does that image show up when you list images with the API? | 20:50 |
itlinux | ok I did this | 20:50 |
itlinux | update images set deleted ='1' where id ='e5f3eaaa-ac4e-4696-9256-7bfd096ad5c4'; | 20:50 |
itlinux | let me see if that fixed | 20:50 |
itlinux | cool that worked.. | 20:51 |
itlinux | :) | 20:51 |
itlinux | rosmaita.. thank you! | 20:52 |
rosmaita | np, but before you go | 20:52 |
itlinux | I am here.. | 20:52 |
itlinux | all the time | 20:52 |
rosmaita | you should probably set a deleted_at time on that row | 20:52 |
itlinux | ahh ok.. what options should I put there.. | 20:52 |
rosmaita | it's a mysql datetime type, so i think you can update images set deleted_at = '2018-07-25 00:59:59' where id = 'e5f3eaaa-ac4e-4696-9256-7bfd096ad5c4'; | 20:53 |
itlinux | ok cool that worked.. | 20:54 |
rosmaita | ok, cool | 20:54 |
rosmaita | there is some more cleanup you should do | 20:55 |
itlinux | which is? | 20:55 |
rosmaita | you need to look in image_locations, image_members, image_properties, and image_tags for any row where image_id = 'e5f3eaaa-ac4e-4696-9256-7bfd096ad5c4' | 20:55 |
rosmaita | for any of those rows, you should set deleted=1 and deleted_at to the datetime you used for the image | 20:56 |
rosmaita | probably the only thing you'll have is a row in image_locations and maybe some rows in image_properties | 20:56 |
itlinux | ok let me check | 20:56 |
rosmaita | but that's all i can think of, you should be good to go | 20:57 |
itlinux | yes I see it on image_location.. | 20:57 |
itlinux | let me updat the delete_at and delete | 20:57 |
itlinux | all good thanks | 21:01 |
itlinux | http://paste.openstack.org/show/726652/ | 21:02 |
rosmaita | looks good! | 21:03 |
*** openstackgerrit has quit IRC | 21:04 | |
rosmaita | jokke_ : glanceclient release patch: https://review.openstack.org/585885 | 21:07 |
imacdonn | rosmaita: Hi. Need to check in on where we're at with https://review.openstack.org/#/c/554362/ | 21:20 |
*** itlinux has quit IRC | 21:31 | |
rosmaita | imacdonn looking | 21:34 |
*** itlinux has joined #openstack-glance | 21:36 | |
rosmaita | imacdonn it is definitely not going to happen in Rocky, we are well past feature freeze. if you want to pursue it for stein, you will need to lobby for it a bit, probably get it on the agenda for a glance meeting and possibly propose it as a topic at the PTG in Denver if you'll be there | 21:40 |
*** edmondsw has joined #openstack-glance | 21:40 | |
imacdonn | rosmaita: I assume the v1 API is gone in rocky, and so I'm essentially hosed now? :( | 21:40 |
rosmaita | ummm ... yes | 21:41 |
rosmaita | if you can't make a glance meeting, you could talk to jokke_ about it in this channel, he is in utc+1 time zone | 21:42 |
imacdonn | I did bring it up at a meeting months ago, but it was kindof squeezed in right at the end | 21:43 |
imacdonn | If no one else cares about this, I guess I have to rethink how we manage images | 21:43 |
*** edmondsw has quit IRC | 21:45 | |
rosmaita | imacdonn that's the other thing, maybe talk to some other operators and see if other people have that use case | 21:47 |
imacdonn | rosmaita: https://bugs.launchpad.net/glance/+bug/1750892 was supposed to be "plan B", but I guess it doesn't provide any way to add a checksum ... ? | 21:48 |
openstack | Launchpad bug 1750892 in Glance "Image remains in queued status after location set via PATCH" [Undecided,Triaged] | 21:48 |
rosmaita | looking | 21:48 |
rosmaita | i forgot about the image staying in queued status, that does seem to be a bug | 21:51 |
rosmaita | not being able to set the checksum seems to be the big problem, though | 21:52 |
imacdonn | yeah ... why couldn't that be PATCHed in too, though ? | 21:52 |
rosmaita | it would have to be policy-governed, and i think only be allowed to set an empty checksum, not update an existing value | 21:54 |
rosmaita | i think in v2 it's officially a read-only field | 21:54 |
imacdonn | how does it get populated then? Or is it computed from the image contents by glance ? | 21:55 |
rosmaita | yeah, this is from the image schema: | 21:56 |
rosmaita | "checksum": { | 21:56 |
rosmaita | "description": "md5 hash of image contents.", | 21:56 |
rosmaita | "maxLength": 32, | 21:56 |
rosmaita | "readOnly": true, | 21:56 |
rosmaita | "type": [ | 21:56 |
rosmaita | "null", | 21:56 |
rosmaita | "string" | 21:56 |
rosmaita | ] | 21:56 |
rosmaita | }, | 21:56 |
rosmaita | glance computes it during image upload | 21:56 |
imacdonn | that seems kinda weird to me ... if I have an image prepared, I may already have a checksum that I know is good .. what if there's some corruption in the transfer to glance? You'd end up with a bad image and a bad checksum and not catch it...... | 21:57 |
jokke_ | rosmaita: was that token bug in released version? | 21:59 |
jokke_ | or was that problem in master? | 21:59 |
rosmaita | jokke_ you mean wxy's bug? | 21:59 |
jokke_ | yeah | 21:59 |
rosmaita | it's in this version | 22:00 |
rosmaita | 2.12.0 | 22:00 |
jokke_ | the fix for it is in 2.12.0 but was the bug itself in 2.11 or was it caught while in master? | 22:00 |
rosmaita | i will have to check | 22:01 |
* jokke_ is just wondering if we need reno for that in 2.12 or not | 22:01 | |
jokke_ | before cutting the release | 22:01 |
jokke_ | cause that's literally only thing we do not have reno for apart from the testing and doc stuff that doesn't need one anyways | 22:02 |
rosmaita | the change that caused that was in 2.11.1, so master | 22:02 |
jokke_ | ok, so it was released | 22:02 |
rosmaita | yes | 22:02 |
jokke_ | ok let me throw together quick reno for that | 22:02 |
jokke_ | then we should be good to go | 22:02 |
rosmaita | this is the releasenote from the change that introduced that bug: http://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=c918dae2aab9c318fc00c1fdbb15e716a32cf507 | 22:03 |
jokke_ | cheers | 22:04 |
rosmaita | jokke_ ok, i just -W the release patch | 22:04 |
rosmaita | imacdonn yeah, that's a good point. | 22:05 |
*** openstackgerrit has joined #openstack-glance | 22:09 | |
openstackgerrit | Erno Kuvaja proposed openstack/python-glanceclient master: Releasenotes for bugfixes in 2.12.0 https://review.openstack.org/585895 | 22:09 |
jokke_ | rosmaita: ^^ in all it's simplicity ... as it's doc feel free to ninja it in unless you find something crappy there | 22:10 |
rosmaita | ok | 22:10 |
jokke_ | also it should not invoke merge patch so the hash should stick | 22:11 |
rosmaita | ok, cool | 22:11 |
jokke_ | then we just need to get the glance api patches landing for these | 22:11 |
rosmaita | :) | 22:11 |
jokke_ | by tomorrow ;) | 22:11 |
jokke_ | eob | 22:11 |
rosmaita | i forgot R-3 was tomorrow, thought it was next week | 22:13 |
jokke_ | R-3 and FF | 22:13 |
rosmaita | that snuck up fast | 22:13 |
jokke_ | That's why I was telling that we need your reviews since Monday ;) | 22:13 |
rosmaita | looking at your reno in html, i saw a typo in the multihash reno ... should i put up a patch to fix | 22:19 |
rosmaita | ? | 22:19 |
jokke_ | sure | 22:19 |
jokke_ | like said they gate really quick | 22:19 |
rosmaita | ok, one second | 22:20 |
jokke_ | like the one I sent up is done with check already | 22:22 |
openstackgerrit | Brian Rosmaita proposed openstack/python-glanceclient master: Correct typo in releasenote https://review.openstack.org/585901 | 22:24 |
rosmaita | jokke_ ^^ | 22:25 |
*** itlinux has quit IRC | 22:25 | |
rosmaita | i checked locally, it does fix the problem | 22:25 |
*** mtreinish has quit IRC | 22:33 | |
openstackgerrit | Merged openstack/python-glanceclient master: Releasenotes for bugfixes in 2.12.0 https://review.openstack.org/585895 | 22:36 |
*** mtreinish has joined #openstack-glance | 22:36 | |
jokke_ | rosmaita: gating | 22:39 |
rosmaita | ty | 22:41 |
openstackgerrit | Merged openstack/python-glanceclient master: Correct typo in releasenote https://review.openstack.org/585901 | 22:48 |
rosmaita | jokke_ : https://review.openstack.org/#/c/585885/2 | 22:51 |
jokke_ | looking good. thnx again Brian | 22:54 |
*** btully has joined #openstack-glance | 23:27 | |
*** r-daneel has quit IRC | 23:28 | |
*** edmondsw has joined #openstack-glance | 23:29 | |
openstackgerrit | Erno Kuvaja proposed openstack/glance-specs master: Modify operator image workflow specs https://review.openstack.org/580568 | 23:29 |
*** btully has quit IRC | 23:32 | |
*** edmondsw has quit IRC | 23:33 | |
jokke_ | rosmaita: I'm gonna hit the hay ... back in few hrs | 23:36 |
*** itlinux has joined #openstack-glance | 23:44 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!