*** imacdonn has quit IRC | 00:00 | |
*** imacdonn has joined #openstack-glance | 00:00 | |
*** Sravan has quit IRC | 00:33 | |
*** Sravan has joined #openstack-glance | 00:34 | |
*** Sravan has quit IRC | 00:41 | |
*** Sravan has joined #openstack-glance | 00:43 | |
*** Sravan has quit IRC | 00:51 | |
*** Sravan has joined #openstack-glance | 00:54 | |
*** Sravan has quit IRC | 01:00 | |
*** Sravan has joined #openstack-glance | 01:01 | |
*** Sravan has quit IRC | 01:08 | |
*** Sravan has joined #openstack-glance | 01:08 | |
*** Sravan has quit IRC | 01:21 | |
*** Sravan has joined #openstack-glance | 01:26 | |
*** Sravan has quit IRC | 01:39 | |
*** Sravan has joined #openstack-glance | 01:40 | |
*** tkajinam_ has joined #openstack-glance | 01:47 | |
*** tkajinam has quit IRC | 01:50 | |
*** _alastor_ has quit IRC | 01:52 | |
*** cfriesen has quit IRC | 01:59 | |
*** markvoelker has joined #openstack-glance | 02:37 | |
*** Sravan has quit IRC | 02:39 | |
*** markvoelker has quit IRC | 03:08 | |
*** cfriesen has joined #openstack-glance | 04:41 | |
*** Sravan has joined #openstack-glance | 04:42 | |
*** abhishekk has joined #openstack-glance | 04:47 | |
*** abhishekk has quit IRC | 05:13 | |
*** Sravan has quit IRC | 05:20 | |
*** Sravan has joined #openstack-glance | 05:24 | |
*** udesale has joined #openstack-glance | 05:34 | |
*** udesale has quit IRC | 05:46 | |
*** abhishekk has joined #openstack-glance | 05:48 | |
*** udesale has joined #openstack-glance | 05:48 | |
*** udesale has quit IRC | 05:53 | |
*** udesale has joined #openstack-glance | 05:54 | |
*** pdeore has joined #openstack-glance | 06:02 | |
*** pdeore has quit IRC | 06:44 | |
*** abhishekk has quit IRC | 06:55 | |
*** Luzi has joined #openstack-glance | 06:59 | |
*** Sravan has quit IRC | 07:01 | |
*** udesale has quit IRC | 07:02 | |
*** udesale has joined #openstack-glance | 07:05 | |
*** Sravan has joined #openstack-glance | 07:05 | |
*** udesale has quit IRC | 07:06 | |
*** udesale has joined #openstack-glance | 07:08 | |
*** udesale has quit IRC | 07:09 | |
*** udesale has joined #openstack-glance | 07:09 | |
*** abhishekk has joined #openstack-glance | 07:09 | |
*** Sravan has quit IRC | 07:09 | |
*** mosulica has joined #openstack-glance | 07:19 | |
*** mosulica has quit IRC | 07:25 | |
*** pcaruana has joined #openstack-glance | 08:10 | |
*** tkajinam_ has quit IRC | 08:15 | |
*** markvoelker has joined #openstack-glance | 08:16 | |
*** Sravan has joined #openstack-glance | 08:22 | |
*** awalende has joined #openstack-glance | 08:24 | |
*** Sravan has quit IRC | 08:27 | |
*** awalende has quit IRC | 08:35 | |
*** awalende has joined #openstack-glance | 08:35 | |
*** awalende has quit IRC | 08:39 | |
*** awalende has joined #openstack-glance | 08:40 | |
*** markvoelker has quit IRC | 08:49 | |
*** lpetrut has joined #openstack-glance | 09:17 | |
*** Sravan has joined #openstack-glance | 09:24 | |
*** Sravan has quit IRC | 09:29 | |
*** cfriesen has quit IRC | 09:37 | |
*** markvoelker has joined #openstack-glance | 09:47 | |
*** awalende has quit IRC | 09:48 | |
*** awalende has joined #openstack-glance | 09:55 | |
*** markvoelker has quit IRC | 10:19 | |
*** abhishekk has quit IRC | 10:25 | |
*** abhishekk has joined #openstack-glance | 10:31 | |
*** priteau has joined #openstack-glance | 10:46 | |
*** Sravan has joined #openstack-glance | 10:49 | |
*** Sravan has quit IRC | 10:54 | |
*** markvoelker has joined #openstack-glance | 11:16 | |
*** udesale has quit IRC | 11:26 | |
*** mvkr has joined #openstack-glance | 11:29 | |
*** markvoelker has quit IRC | 11:50 | |
*** abhishekk has quit IRC | 12:30 | |
*** markvoelker has joined #openstack-glance | 12:47 | |
*** markvoelker has quit IRC | 13:13 | |
*** abhishek has joined #openstack-glance | 13:40 | |
*** pcaruana has quit IRC | 13:50 | |
*** pcaruana has joined #openstack-glance | 13:57 | |
*** jdillaman has joined #openstack-glance | 14:16 | |
*** awalende has quit IRC | 14:39 | |
*** awalende has joined #openstack-glance | 14:40 | |
*** awalende has quit IRC | 14:44 | |
*** cfriesen has joined #openstack-glance | 14:55 | |
openstackgerrit | Merged openstack/glance master: Add test for data migration version https://review.openstack.org/632517 | 15:08 |
---|---|---|
*** udesale has joined #openstack-glance | 15:08 | |
*** Luzi has quit IRC | 15:18 | |
rosmaita | smcginnis: when you have a few minutes, can you take a look at Tony and J-P's questions on https://review.openstack.org/#/c/633011/ ? I'm not sure it matters whether 632517 (the CURRENT_VERSION test patch) is included in the tag or not--though i'm not sure i grasp all the implications | 15:21 |
rosmaita | jokke_: ^^ | 15:21 |
smcginnis | rosmaita: Sure, I'll take a look. | 15:37 |
rosmaita | thanks! | 15:37 |
*** pcaruana has quit IRC | 16:01 | |
*** udesale has quit IRC | 16:02 | |
*** _alastor_ has joined #openstack-glance | 16:03 | |
*** _alastor_ has quit IRC | 16:12 | |
openstackgerrit | Paul-Emile Element proposed openstack/glance master: Add flavor options to select emulated virtual tpm https://review.openstack.org/633256 | 16:14 |
*** pcaruana has joined #openstack-glance | 16:17 | |
jokke_ | looking now | 16:24 |
jokke_ | rosmaita: hmm-m just when replying to that review, realized a problem in that test | 16:33 |
rosmaita | oh no | 16:33 |
jokke_ | So when we tag the first release from series, checking out that tag and running tests from it will always fail | 16:34 |
jokke_ | so our first beta will always fail testing | 16:35 |
rosmaita | hmmm | 16:35 |
rosmaita | i guess we really need to do the api-break thing instead, then | 16:35 |
jokke_ | meaning I really don't want to have that test in the tag :P | 16:35 |
rosmaita | well, it's not in the tag this time | 16:36 |
rosmaita | but will be next time | 16:36 |
jokke_ | and when we release the first from series in future, we probably should merge skip and unskip that test patches and tag the skip commit :P | 16:36 |
jokke_ | but that is just process dance | 16:37 |
rosmaita | jeez ... this is getting pretty manual | 16:37 |
rosmaita | we should check with dhellmann, but maybe if we do the api-break in the same patch that changes the CURRENT_VERSION, that would be the way to go | 16:38 |
openstackgerrit | Lucian Petrut proposed openstack/glance master: WIP: glance Windows support https://review.openstack.org/630705 | 16:40 |
openstackgerrit | Lucian Petrut proposed openstack/glance master: WIP: Windows multiprocess wsgi https://review.openstack.org/630706 | 16:40 |
openstackgerrit | Lucian Petrut proposed openstack/glance master: WIP: Allow glance tests to run on Windows https://review.openstack.org/634007 | 16:40 |
*** gyee has joined #openstack-glance | 16:42 | |
*** abhishek has quit IRC | 16:42 | |
jokke_ | What we could do is to move that test into it's own job. That way it will flag the gate on both cases but it will not break just running the tests when you do it locally | 16:45 |
*** pcaruana has quit IRC | 16:45 | |
jokke_ | on both cases meaning trying to merge migration before version bump and not updating the migration after version bump | 16:46 |
rosmaita | that sounds like a good idea | 16:46 |
rosmaita | i'll put up a patch for that later today | 16:47 |
rosmaita | i guess we are ok for this beta release, since the change is not in the release? i mean, no reason to hold up the release patch? | 16:48 |
jokke_ | yep, like I said in my comment on the review, I prefer not having the test included to the release | 16:50 |
rosmaita | ok, cool, so this is mainly for the next time | 16:50 |
*** lpetrut has quit IRC | 16:57 | |
dhellmann | rosmaita : why are your database migrations tied to the software version? | 17:06 |
rosmaita | dhellmann: there is some bookkeeping that depends on a constant string that's the release name | 17:07 |
dhellmann | what sort of bookkeeping? | 17:07 |
rosmaita | i am not completely clear on that, tbh | 17:07 |
dhellmann | it feels odd to be embedding names like that in the database | 17:08 |
*** priteau has quit IRC | 17:08 | |
rosmaita | well, this doesn't wind up in the db, actually, but it has something to do with tracking migrations | 17:08 |
rosmaita | which are named with the release name prefix | 17:09 |
dhellmann | ok. I don't really understand, but it feels like you're having to go to some amount of trouble to deal with it and that just made me question the approach in general | 17:10 |
rosmaita | i agree, i need to take some time and look into why we did it this way ... it seemed to make sense at the time (ocata), and the people who worked on it left the project (osic) | 17:11 |
* dhellmann nods | 17:11 | |
rosmaita | you are right that there should be a better way! | 17:11 |
jokke_ | dhellmann: it's basically the alembic migrations to be applied in correct order. The original design was based on the release name and alphabetical ordering of them | 17:27 |
jokke_ | so we're kind of stuck with that | 17:28 |
dhellmann | jokke_ : alembic does all of that, though. why aren't you just telling it what order the scripts should be applied? | 17:28 |
dhellmann | I mean, that's what it's *for* | 17:28 |
jokke_ | tbh, I have no idea. Like said I know as much as our implementation is depending on the version name as baseline there. | 17:35 |
*** Sravan has joined #openstack-glance | 17:54 | |
*** Sravan has quit IRC | 17:55 | |
*** pcaruana has joined #openstack-glance | 18:17 | |
*** Sravan has joined #openstack-glance | 18:20 | |
*** Sravan has quit IRC | 18:32 | |
*** Sravan has joined #openstack-glance | 18:33 | |
*** awalende has joined #openstack-glance | 18:40 | |
*** awalende has quit IRC | 18:45 | |
*** priteau has joined #openstack-glance | 18:55 | |
*** Sravan has quit IRC | 18:56 | |
*** Sravan has joined #openstack-glance | 18:58 | |
*** Sravan has quit IRC | 19:03 | |
*** Sravan has joined #openstack-glance | 19:05 | |
*** Sravan has quit IRC | 19:09 | |
*** Sravan has joined #openstack-glance | 19:09 | |
*** rchurch has joined #openstack-glance | 19:22 | |
*** Sravan has quit IRC | 19:40 | |
*** Sravan has joined #openstack-glance | 19:42 | |
*** priteau has quit IRC | 20:01 | |
smcginnis | jokke_, rosmaita: Would now be a good time to do that beta release? | 20:12 |
smcginnis | I suppose I can always merge the follow on patch if necessary, but rather not give any surprises. | 20:12 |
*** Sravan has quit IRC | 20:16 | |
*** Sravan has joined #openstack-glance | 20:19 | |
*** Sravan has quit IRC | 20:26 | |
*** Sravan has joined #openstack-glance | 20:39 | |
*** _alastor_ has joined #openstack-glance | 20:44 | |
*** Sravan has quit IRC | 20:47 | |
*** Sravan has joined #openstack-glance | 20:47 | |
jokke_ | sure | 20:48 |
rosmaita | was afk ... now would be ok | 20:51 |
rosmaita | smcginnis: ^^ | 20:51 |
rosmaita | i'll be around for a while | 20:51 |
smcginnis | OK, I'll push the big red button. | 20:53 |
*** Sravan has quit IRC | 20:55 | |
rosmaita | :) | 20:59 |
*** Sravan has joined #openstack-glance | 21:01 | |
*** rosmaita has quit IRC | 21:04 | |
*** Sravan has quit IRC | 21:06 | |
*** rosmaita has joined #openstack-glance | 21:07 | |
smcginnis | Release is done. | 21:17 |
rosmaita | smcginnis: cool, i see the tag | 21:20 |
rosmaita | guess i could rebase something to see if it fails? | 21:20 |
openstackgerrit | Brian Rosmaita proposed openstack/glance master: DNM - test eventlet-0.22.1 https://review.openstack.org/571797 | 21:21 |
rosmaita | old patch, merge conflict | 21:23 |
rosmaita | did a recheck on https://review.openstack.org/#/c/624983/3 , let's see what happens | 21:24 |
jokke_ | be quick, I just hit +2A on the migration patch | 21:35 |
rosmaita | jokke_: good idea, the rebase i did should fail while the migration patch is going through the gate | 21:36 |
rosmaita | well, test_migration_version passes on the migration patch for py{27,35,36} | 21:50 |
*** openstackgerrit has quit IRC | 21:50 | |
*** Sravan has joined #openstack-glance | 22:00 | |
*** Sravan has quit IRC | 22:03 | |
*** Sravan has joined #openstack-glance | 22:03 | |
*** Sravan has quit IRC | 22:12 | |
*** Sravan has joined #openstack-glance | 22:14 | |
*** Sravan has quit IRC | 22:23 | |
*** Sravan has joined #openstack-glance | 22:30 | |
*** Sravan has quit IRC | 22:39 | |
*** Sravan has joined #openstack-glance | 22:42 | |
*** MattMan has quit IRC | 22:51 | |
*** MattMan has joined #openstack-glance | 22:51 | |
tonyb | So ... I have a situation where I add an image with openstack image create ... --id $static_uuid $name | 22:58 |
tonyb | then I delete it | 22:58 |
tonyb | when I try to re add it with the same command (including the same $static_uuid I get a conflict | 22:59 |
tonyb | I assume this means that the UUID is still in the database which kinda makes sense but is there a way (without manually editing the DB) to really purge deleted images? | 22:59 |
tonyb | For the sake of transparency I *can* drop the static_uuid so this is eally a for my education rather then impacting anything real | 23:00 |
* tonyb probably shoudl have lead with that ;D | 23:00 | |
*** tkajinam has joined #openstack-glance | 23:01 | |
rosmaita | tonyb: there is an ossn about that, gimme a sec to find it | 23:02 |
tonyb | rosmaita: Oh interesting | 23:02 |
rosmaita | tonyb: https://wiki.openstack.org/wiki/OSSN/OSSN-0075 | 23:03 |
rosmaita | i think we "fixed" this in rocky, gimme another sec | 23:03 |
tonyb | rosmaita: well I'm using rocky and seeing that behaviour | 23:03 |
rosmaita | well, that behavior is expected, that's why i said we "fixed" it | 23:04 |
tonyb | Oh I see | 23:04 |
rosmaita | https://docs.openstack.org/releasenotes/glance/rocky.html#security-issues | 23:04 |
tonyb | Yeah I see this is the fixed behaviour | 23:05 |
rosmaita | it will point you to this: https://docs.openstack.org/glance/latest/admin/db.html#purging-the-images-table | 23:05 |
rosmaita | in a nutshell, what you are seeing is expected behavior, and there's a reason why you can't reuse deleted image ids | 23:06 |
tonyb | rosmaita: Yup. Thanks. | 23:06 |
rosmaita | np, purge with care! | 23:06 |
* tonyb is now educated ;P #winning | 23:06 | |
tonyb | rosmaita: In my case it's a single user development cloud so pfft | 23:07 |
rosmaita | delete away! | 23:07 |
tonyb | we don't need no stinking securty ;P | 23:07 |
rosmaita | :) | 23:07 |
*** Sravan has quit IRC | 23:08 | |
*** Sravan has joined #openstack-glance | 23:12 | |
*** Sravan has quit IRC | 23:15 | |
*** Sravan has joined #openstack-glance | 23:39 | |
*** Sravan has quit IRC | 23:44 | |
*** Sravan has joined #openstack-glance | 23:50 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!