*** gyee has quit IRC | 00:23 | |
*** markvoelker has joined #openstack-glance | 00:29 | |
*** markvoelker has quit IRC | 01:02 | |
*** Sravan has joined #openstack-glance | 01:32 | |
*** Sravan has quit IRC | 01:37 | |
*** rosmaita has left #openstack-glance | 01:52 | |
*** markvoelker has joined #openstack-glance | 01:59 | |
*** markvoelker has quit IRC | 02:32 | |
*** threestrands has joined #openstack-glance | 02:54 | |
*** Sravan has joined #openstack-glance | 03:29 | |
*** Sravan has quit IRC | 03:37 | |
*** Sravan has joined #openstack-glance | 03:49 | |
*** Sravan has quit IRC | 03:50 | |
*** Sravan has joined #openstack-glance | 03:53 | |
*** ratailor has joined #openstack-glance | 03:54 | |
*** threestrands has quit IRC | 04:12 | |
*** Sravan_ has joined #openstack-glance | 04:15 | |
*** Sravan has quit IRC | 04:18 | |
*** markvoelker has joined #openstack-glance | 04:30 | |
*** Sravan has joined #openstack-glance | 04:30 | |
*** udesale has joined #openstack-glance | 04:31 | |
*** Sravan__ has joined #openstack-glance | 04:33 | |
*** Sravan_ has quit IRC | 04:34 | |
*** Sravan has quit IRC | 04:36 | |
*** Sravan__ has quit IRC | 04:43 | |
*** prometheanfire has joined #openstack-glance | 05:02 | |
prometheanfire | looks like new glance_store is breaking glance? | 05:02 |
---|---|---|
prometheanfire | https://review.opendev.org/663740 | 05:02 |
*** markvoelker has quit IRC | 05:03 | |
*** abhishekk has joined #openstack-glance | 05:16 | |
*** ratailor_ has joined #openstack-glance | 05:43 | |
*** ratailor has quit IRC | 05:43 | |
*** markvoelker has joined #openstack-glance | 06:00 | |
*** lpetrut has joined #openstack-glance | 06:19 | |
*** hoonetorg has quit IRC | 06:21 | |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Unit tests fails with new glance_store version 0.29.0 https://review.opendev.org/663840 | 06:25 |
prometheanfire | thanks | 06:30 |
*** markvoelker has quit IRC | 06:32 | |
*** itlinux_ has joined #openstack-glance | 06:34 | |
*** itlinux has quit IRC | 06:34 | |
*** pcaruana has joined #openstack-glance | 06:35 | |
*** hoonetorg has joined #openstack-glance | 06:38 | |
*** itlinux_ has quit IRC | 06:54 | |
*** itlinux has joined #openstack-glance | 06:59 | |
*** itlinux has quit IRC | 07:05 | |
*** mvkr has joined #openstack-glance | 07:09 | |
*** tesseract has joined #openstack-glance | 07:09 | |
*** itlinux has joined #openstack-glance | 07:12 | |
*** imacdonn has quit IRC | 07:16 | |
*** brinzhang has quit IRC | 07:26 | |
*** markvoelker has joined #openstack-glance | 07:30 | |
*** bhagyashris has joined #openstack-glance | 07:37 | |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: DNM: Fix subunit.parser error https://review.opendev.org/634628 | 07:39 |
*** rcernin has quit IRC | 07:55 | |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: DNM: Fix subunit.parser error https://review.opendev.org/634628 | 07:58 |
*** markvoelker has quit IRC | 08:03 | |
*** trident has quit IRC | 08:35 | |
*** trident has joined #openstack-glance | 08:37 | |
*** imacdonn has joined #openstack-glance | 08:37 | |
*** markvoelker has joined #openstack-glance | 09:00 | |
*** Sravan has joined #openstack-glance | 09:10 | |
*** Sravan has quit IRC | 09:15 | |
*** priteau has joined #openstack-glance | 09:25 | |
*** markvoelker has quit IRC | 09:32 | |
*** tkajinam has quit IRC | 09:37 | |
*** lpetrut has quit IRC | 09:38 | |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: PoC for 'barbican secret deletion' https://review.opendev.org/663878 | 09:55 |
*** bhagyashris has quit IRC | 09:55 | |
*** abhishekk has quit IRC | 09:55 | |
*** abhishekk has joined #openstack-glance | 09:56 | |
*** lpetrut has joined #openstack-glance | 10:04 | |
*** lpetrut has quit IRC | 10:04 | |
*** lpetrut has joined #openstack-glance | 10:05 | |
openstackgerrit | Erno Kuvaja proposed openstack/glance_store master: Revert "Change location metadata key 'backend' to 'store'" https://review.opendev.org/663889 | 10:42 |
abhishekk | jokke_, hi you around? | 10:45 |
*** udesale has quit IRC | 10:53 | |
*** udesale has joined #openstack-glance | 10:53 | |
openstackgerrit | Erno Kuvaja proposed openstack/glance_store master: Add 0.29.1 releasenotes https://review.opendev.org/663894 | 11:02 |
jokke_ | yes | 11:02 |
jokke_ | hello | 11:02 |
abhishekk | jokke_, hi | 11:05 |
abhishekk | any particular reason for reverting the "Change location metadata key 'backend' to 'store'" patch? | 11:06 |
jokke_ | yes, look the reno patch | 11:06 |
abhishekk | what backward compatible change you were talking, could you please explain, I might be overlooking something | 11:08 |
abhishekk | s/were/are | 11:09 |
jokke_ | that exact change | 11:12 |
jokke_ | it is backwards incompatible and breaks multi-store | 11:12 |
jokke_ | which is why it needs to be released as 1.0.0 | 11:13 |
jokke_ | you guys decided to rush it to be released as 0.29.0 which breaks semver and not include any mention about it in the release notes, now we need to fix that mess | 11:14 |
abhishekk | jokke_, sorry for that | 11:14 |
abhishekk | jokke_, also look out at this patch, https://review.opendev.org/663840 | 11:15 |
jokke_ | also looks like you did not release m-1 release from glance which actually did have deadline yesterday | 11:19 |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Rethinking filesystem access https://review.opendev.org/611253 | 11:19 |
abhishekk | jokke_, IMO we are not responsible to release m-1 for glance | 11:21 |
jokke_ | I'm pretty sure I have been reminding about that for past 3 weeks and Brian even added it to the release liaison tasks last cycle. We _need_ m-1 release out of glance to be able to do migrations due to how alembic works | 11:27 |
jokke_ | we learned that hard way last cycle when we did not do milestone releases | 11:28 |
jokke_ | ffs | 11:28 |
*** markvoelker has joined #openstack-glance | 11:30 | |
abhishekk | I remember now, sorry I missed that :( | 11:32 |
*** rosmaita has joined #openstack-glance | 11:35 | |
jokke_ | need coffee ... back in 10 or so | 11:44 |
*** ratailor_ has quit IRC | 12:01 | |
*** markvoelker has quit IRC | 12:03 | |
openstackgerrit | Brian Rosmaita proposed openstack/glance master: Add glance_store tips to experimental jobs https://review.opendev.org/663917 | 12:08 |
smcginnis | Regarding semver, with it still at a 0.x release, that is fine for this kind of change. | 12:09 |
*** udesale has quit IRC | 12:10 | |
smcginnis | Curious what the need for m-1 to be able to do migrations due to how alembic works. I know there are other projects using alembic that do not need to do milestone releases. | 12:11 |
*** udesale has joined #openstack-glance | 12:11 | |
rosmaita | smcginnis: it's an artificial need | 12:12 |
smcginnis | rosmaita: Is that something we should fix in Glance, or too late now? | 12:12 |
rosmaita | smcginnis: not sure, there's a glance config test i added that should break the world, although i don't remember the specific conditions under which that happens | 12:13 |
rosmaita | oh yeah, it's if we propose a milestone without making the config change | 12:13 |
smcginnis | Eeeh. | 12:13 |
rosmaita | so that's why we aren't getting nastygrams this morning | 12:13 |
rosmaita | smcginnis: take a look at the TODOs in tox.ini for glance | 12:14 |
rosmaita | smcginnis: what's the name of that success or thank you bot? looks like someone updated the docs CSS to get some groovy tables back, our docs landing page is looking nice again | 12:17 |
smcginnis | Yeah, glad to see that. | 12:18 |
jokke_ | rosmaita: bug 1831997 | 12:18 |
openstack | bug 1831997 in Glance "Unit tests relying on external dependencies" [Undecided,New] https://launchpad.net/bugs/1831997 | 12:18 |
rosmaita | jokke_: ty | 12:18 |
abhishekk | I am signing off as have to attend one family function, will be back online around 2000 UTC to check if anything is needed from my end | 12:20 |
rosmaita | jokke_: abhishekk: smcginnis: the migration constants update is listed here: https://docs.openstack.org/glance/latest/contributor/release-cpl.html#final-releases , which is probably why it got missed, since we decided to do it at M-1 instead | 12:20 |
jokke_ | smcginnis: so the glance_store release issue is twofold... it's backwards incompatible change that breaks multi-store and there is no reno montion ofr any of that | 12:20 |
rosmaita | abhishekk: have a good weekend, we should be good here | 12:20 |
jokke_ | abhishekk: have a good one! | 12:20 |
smcginnis | The release note part is an issue. But as far as semver goes since we haven't declared a 1.0 release yet, that part was fine. | 12:21 |
abhishekk | thank you | 12:21 |
rosmaita | jokke_: to smcginnis's credit, he did ask about release notes yesterday | 12:21 |
smcginnis | Have a good one abhishekk | 12:21 |
abhishekk | thank you | 12:21 |
abhishekk | please drop a mail in case anything urgent comes up, bye have a nice day ahead | 12:22 |
*** abhishekk has quit IRC | 12:23 | |
rosmaita | this has been sitting a long time: https://review.opendev.org/#/c/633140/ ... it's the update to the release CPL docs | 12:23 |
smcginnis | rosmaita: So that gate test... it looks like that constant needs to be updated *if* we do a milestone release, but if we don't we should be fine. So I'm maybe not clear yet on the need there. | 12:23 |
smcginnis | It's that we can't do any DB migrations until that is done? | 12:24 |
rosmaita | smcginnis: right, it's just that we don't want to be scrambling at RC-time ... and yes, no new migrations until that is updated | 12:24 |
smcginnis | OK, I think I understand a little better now. | 12:25 |
smcginnis | Thanks! | 12:25 |
rosmaita | there has to be a better way to do it, though | 12:25 |
rosmaita | but that was the best hemanth and alex could come up with at the time | 12:25 |
smcginnis | Yeah, like I mentioned, I'm not aware of any other alembic-using project having this issue. | 12:25 |
jokke_ | yes we need to do constant change and release milestone to be able to do the migrations due to how the alembic implementation we have is checking those and referring it to the version it gets from the service | 12:25 |
rosmaita | we were early adopters | 12:25 |
jokke_ | iit's lovely when it works as it allows us to not worry too much about the specific ordering of our migration scripts but it causes bit of work at the early stage of dev cycle | 12:26 |
*** udesale has quit IRC | 12:27 | |
*** udesale has joined #openstack-glance | 12:27 | |
*** lpetrut has quit IRC | 12:27 | |
jokke_ | basically by changing the constant and doing milestone release we do not need to maintain manual lists of migration order | 12:27 |
smcginnis | It may be easier to do this slightly differently. In the commit that bumps that constant, we can add a line to the commit message that containts "Sem-Ver: major". | 12:27 |
jokke_ | I think we did try that last cycle and it did not work | 12:28 |
smcginnis | Having that in the commit message will trigger PBR to report a higher major version number that will match the change in the patch. So there's no failure window. | 12:28 |
jokke_ | unless that's something that BPR introduced recently. | 12:29 |
jokke_ | as we definitely did try something like that | 12:29 |
smcginnis | No, it's been around for awhile now. I'd be curious to take a look at that last attempt to see why it wouldn't have worked. | 12:29 |
*** dansmith has quit IRC | 12:29 | |
rosmaita | jokke_: just noticed that your change to the py3-ssl tests never merged | 12:30 |
jokke_ | I think we used "feature" or something like that as keyword ... pretty sure it was not "major" | 12:30 |
jokke_ | rosmaita: thanks ... didn't realize even it was approved ... this week has been mess due to the bank holiday and yesterday's Red Hat Day Ireland | 12:32 |
smcginnis | That would have been it then. feature will just bump the Y version (X.Y.Z) but we would need the X version bumped with "major". | 12:32 |
*** dansmith has joined #openstack-glance | 12:32 | |
rosmaita | smcginnis: so could we do that semver thing in master as soon as the stable branch is cut? | 12:33 |
jokke_ | rosmaita: nope ... right after release would work 'though | 12:34 |
rosmaita | yeah, i think that's why we went with the milestone-1 idea | 12:34 |
jokke_ | as it's looking the last tag in the repo as baseline | 12:34 |
smcginnis | rosmaita: Yeah, we could. So as soon as master becomes N+1, we can bump the constant and have that in the commit so everything is in place and ready to go for the new release. | 12:35 |
smcginnis | Doesn't need to wait for the previous release. | 12:35 |
smcginnis | PBR will report the right version number depending on the branch you are on. | 12:35 |
rosmaita | i am noticing an increased number of +1s with no comments on reviews after i wrote my grumpy old man email ... i think people are trolling me | 12:36 |
jokke_ | good :D | 12:37 |
jokke_ | never not to troll if opportunity raises | 12:37 |
* jokke_ goes and drops some +1s into cinder reviews | 12:37 | |
rosmaita | GET OFF MY LAWN!!! | 12:37 |
smcginnis | :D | 12:37 |
jokke_ | smcginnis: is pbr really that smart that if we have last tag N, we cut stable from master it automatically treats that stable and master as N+1 and if we drop "semver: major" into master it treats the master as N+2? | 12:40 |
*** markvoelker has joined #openstack-glance | 12:49 | |
*** mvkr has quit IRC | 13:09 | |
*** priteau has quit IRC | 13:23 | |
smcginnis | jokke_: Sorry, had to step away for a bit. | 13:24 |
smcginnis | jokke_: Yeah, it looks through the current branch, so it would evaluate stable/x differently than master. | 13:25 |
smcginnis | As long as it's done *after* branching, should be fine. | 13:25 |
openstackgerrit | Merged openstack/glance master: Unit tests fails with new glance_store version 0.29.0 https://review.opendev.org/663840 | 13:36 |
*** priteau has joined #openstack-glance | 13:37 | |
*** baojg has joined #openstack-glance | 14:46 | |
*** itlinux has quit IRC | 14:46 | |
*** itlinux has joined #openstack-glance | 14:47 | |
*** itlinux has quit IRC | 14:52 | |
*** baojg has quit IRC | 14:56 | |
*** itlinux has joined #openstack-glance | 14:59 | |
*** Sravan has joined #openstack-glance | 15:15 | |
*** Sravan has quit IRC | 15:43 | |
*** Sravan has joined #openstack-glance | 15:44 | |
*** Sravan has quit IRC | 15:48 | |
*** markvoelker has quit IRC | 15:49 | |
*** gyee has joined #openstack-glance | 15:51 | |
*** priteau has quit IRC | 16:25 | |
*** tesseract has quit IRC | 16:40 | |
*** markvoelker has joined #openstack-glance | 16:50 | |
openstackgerrit | Merged openstack/glance master: Don't target broken ssl tests to specific py3.minor https://review.opendev.org/657966 | 17:24 |
*** markvoelker has quit IRC | 17:25 | |
*** markvoelker has joined #openstack-glance | 18:22 | |
*** gtema has joined #openstack-glance | 18:30 | |
gtema | hey guys. Can really the 'checksum' of the image be used to verify image uploading? We face in OpenStackSDK and Nodepool that the checksum reported after the image upload does not match the md5 checksum of the data we upload | 18:33 |
gtema | and since I know of the feature of image conversion and provider "backend plugins" I doubt we can really trust anything here | 18:36 |
*** Sravan has joined #openstack-glance | 18:54 | |
*** markvoelker has quit IRC | 18:55 | |
*** Sravan has quit IRC | 19:00 | |
*** Sravan has joined #openstack-glance | 19:04 | |
*** Sravan has quit IRC | 19:07 | |
*** gtema has quit IRC | 19:08 | |
*** Sravan has joined #openstack-glance | 19:09 | |
*** Sravan has quit IRC | 19:16 | |
*** Sravan has joined #openstack-glance | 19:19 | |
*** jdillaman has quit IRC | 19:30 | |
*** Sravan has quit IRC | 19:35 | |
*** udesale has quit IRC | 19:41 | |
*** markvoelker has joined #openstack-glance | 19:52 | |
*** markvoelker has quit IRC | 20:20 | |
*** redkrieg has joined #openstack-glance | 20:27 | |
*** Nick_A has joined #openstack-glance | 20:29 | |
*** prometheanfire has left #openstack-glance | 21:02 | |
*** Sravan has joined #openstack-glance | 21:13 | |
*** markvoelker has joined #openstack-glance | 21:16 | |
*** Sravan has quit IRC | 21:17 | |
*** Sravan has joined #openstack-glance | 21:19 | |
*** markvoelker has quit IRC | 21:21 | |
*** Sravan has quit IRC | 21:50 | |
*** pcaruana has quit IRC | 21:51 | |
*** Sravan has joined #openstack-glance | 22:07 | |
*** Sravan has quit IRC | 22:24 | |
*** Sravan has joined #openstack-glance | 22:29 | |
*** Sravan has quit IRC | 22:36 | |
*** Sravan has joined #openstack-glance | 22:56 | |
*** Sravan has quit IRC | 22:59 | |
*** Sravan has joined #openstack-glance | 23:12 | |
*** gyee has quit IRC | 23:12 | |
*** Sravan has quit IRC | 23:16 | |
*** markvoelker has joined #openstack-glance | 23:17 | |
*** Sravan has joined #openstack-glance | 23:25 | |
*** Sravan has quit IRC | 23:25 | |
*** Sravan has joined #openstack-glance | 23:31 | |
*** Sravan has quit IRC | 23:32 | |
*** hoonetorg has quit IRC | 23:35 | |
*** markvoelker has quit IRC | 23:38 | |
*** hoonetorg has joined #openstack-glance | 23:50 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!