*** gyee has quit IRC | 00:11 | |
*** Liang__ has joined #openstack-glance | 01:03 | |
*** evrardjp has quit IRC | 04:35 | |
*** evrardjp has joined #openstack-glance | 04:35 | |
*** ratailor has joined #openstack-glance | 04:50 | |
*** udesale has joined #openstack-glance | 05:10 | |
*** ratailor_ has joined #openstack-glance | 05:19 | |
*** ratailor has quit IRC | 05:21 | |
*** udesale_ has joined #openstack-glance | 05:21 | |
*** udesale has quit IRC | 05:24 | |
openstackgerrit | Merged openstack/glance master: Use unittest.mock instead of third party mock https://review.opendev.org/720914 | 05:31 |
---|---|---|
*** ratailor_ has quit IRC | 06:02 | |
*** ratailor has joined #openstack-glance | 06:02 | |
*** ratailor has quit IRC | 06:04 | |
*** ratailor has joined #openstack-glance | 06:05 | |
*** udesale_ has quit IRC | 06:14 | |
*** udesale has joined #openstack-glance | 06:37 | |
openstackgerrit | Merged openstack/python-glanceclient master: Use unittest.mock instead of third party mock https://review.opendev.org/720984 | 06:38 |
*** udesale has quit IRC | 06:43 | |
openstackgerrit | Merged openstack/glance master: Add missing Image property hw_vif_multiqueue_enabled to metadefs https://review.opendev.org/718307 | 06:53 |
openstackgerrit | Merged openstack/glance_store master: Use unittest.mock instead of third party mock https://review.opendev.org/720915 | 07:00 |
*** threestrands has quit IRC | 07:55 | |
*** udesale has joined #openstack-glance | 08:16 | |
*** udesale_ has joined #openstack-glance | 08:22 | |
*** udesale has quit IRC | 08:22 | |
*** udesale has joined #openstack-glance | 08:22 | |
openstackgerrit | Merged openstack/glance master: Update OS::Glance::CommonImageProperties in metadefs https://review.opendev.org/718292 | 08:39 |
openstackgerrit | Merged openstack/glance master: Imported Translations from Zanata https://review.opendev.org/719155 | 08:39 |
*** belmoreira has joined #openstack-glance | 08:41 | |
*** priteau has joined #openstack-glance | 08:48 | |
*** happyhemant has joined #openstack-glance | 09:17 | |
*** Liang__ has quit IRC | 10:03 | |
*** udesale has quit IRC | 11:09 | |
*** priteau has quit IRC | 11:44 | |
*** ratailor has quit IRC | 12:06 | |
*** brinzhang has quit IRC | 12:30 | |
*** rcernin has quit IRC | 13:14 | |
abhishekk | rosmaita, jokke_ around? | 14:19 |
rosmaita | abhishekk: in a meeting | 14:19 |
abhishekk | rosmaita, ack | 14:19 |
rosmaita | but i can talk if what you want to discuss isn't too complicated | 14:20 |
abhishekk | we have some doc changes and test related changes merged since M3 release | 14:21 |
abhishekk | If we decided to tag rc1 then do we need reno? | 14:21 |
rosmaita | not necessarily | 14:22 |
rosmaita | depends on if you like the current "prelude" | 14:22 |
abhishekk | yeah, I also thought so | 14:23 |
rosmaita | because if rc-1 winds up being the actual release, you'll want that in there | 14:23 |
abhishekk | no those are misc doc and some unit tests changes | 14:24 |
rosmaita | there are some instructions in the reno docs about how to generate what the combined release notes will look like | 14:25 |
rosmaita | not sure if they still work | 14:25 |
rosmaita | but you might want to do that to see what your ussuri release notes will look like | 14:26 |
abhishekk | ok | 14:26 |
abhishekk | let me see it | 14:26 |
rosmaita | abhishekk: https://docs.openstack.org/project-team-guide/release-management.html#how-to-preview-release-notes-at-rc-time | 14:28 |
abhishekk | rosmaita, thank you | 14:28 |
tkajinam | hi. is it correct that Glare project has already been retired and, is no more maintained ? https://opendev.org/x/glare | 14:59 |
tkajinam | I'm asking this because we still have puppet-glare in openstack namespace, and I'm wondering whether we can also retire it | 14:59 |
tkajinam | IIRC Glare was the project related to Glance, but please correct me if I should ask it in another place. | 15:00 |
abhishekk | tkajinam, glare was initially part of glance and later it was created as a separate project | 15:03 |
abhishekk | IMO at the moment it's not maintained, but you can reconfirm it at openstack-tc irc channel | 15:03 |
tkajinam | abhishekk, thanks. will check it with tc. Maybe I can ask it on ml as well when I propose retirement of puppet-glare | 15:05 |
abhishekk | tkajinam, that is good idea | 15:06 |
tkajinam | I just sent an e-mail on ml asking that topic. thanks again :-) | 15:18 |
abhishekk | tkajinam, no problem :D | 15:19 |
*** tkajinam has quit IRC | 15:40 | |
*** udesale_ has quit IRC | 15:41 | |
*** gyee has joined #openstack-glance | 15:52 | |
*** evrardjp has quit IRC | 16:35 | |
*** evrardjp has joined #openstack-glance | 16:35 | |
*** happyhemant has quit IRC | 16:38 | |
*** happyhemant has joined #openstack-glance | 16:40 | |
*** mnaser has quit IRC | 16:41 | |
*** TheJulia has quit IRC | 16:42 | |
*** TheJulia has joined #openstack-glance | 16:44 | |
*** mnaser has joined #openstack-glance | 16:44 | |
*** mnaser has quit IRC | 16:46 | |
*** mnaser has joined #openstack-glance | 16:47 | |
*** mnaser has quit IRC | 16:49 | |
*** mnaser has joined #openstack-glance | 16:50 | |
*** gmann is now known as gmann_lunch | 18:31 | |
*** gmann_lunch is now known as gmann | 18:51 | |
*** belmoreira has quit IRC | 18:53 | |
whoami-rajat | abhishekk, jokke_ i've answered few of your queries in the patch and will do rest of the necessary updates. Thanks. | 20:09 |
abhishekk | whoami-rajat, thanks, will have a look | 20:11 |
whoami-rajat | abhishekk, thanks! | 20:11 |
abhishekk | whoami-rajat, np! | 20:13 |
gmann | rosmaita: abhishekk you there to talk about policy testing failing on patrole | 20:24 |
rosmaita | gmann: i am kind of out of the loop, but can try | 20:25 |
abhishekk | gmann, wrapping up as its almost past midnight here | 20:25 |
gmann | abhishekk: ah sure. | 20:25 |
rosmaita | abhishekk: quick question for you to look at tomorrow -- can we get https://review.opendev.org/#/c/718147/ into RC-1 ? | 20:26 |
abhishekk | I will go through the discussion in the morning and will take away from there if required | 20:26 |
gmann | rosmaita: as i read the release notes the change in default value of 'admin_role' should not effect the testing tool tesrting policy in code https://review.opendev.org/#/c/719023/1 | 20:26 |
rosmaita | gmann: yes, that is the theory | 20:26 |
gmann | but patrole testing the policy in code with default values started failing - https://review.opendev.org/#/c/720601/ | 20:26 |
abhishekk | rosmaita, looking | 20:27 |
rosmaita | gmann: looking | 20:27 |
abhishekk | rosmaita, specs is not merged yet, seems like jokke_ still has some concerns over it | 20:28 |
rosmaita | abhishekk: ok, wish he'd leave a comment on the spec though | 20:29 |
abhishekk | Lets discuss this in weekly meeting and if required we can tag rc2 | 20:30 |
abhishekk | does this sounds ok? | 20:30 |
rosmaita | sounds good to me | 20:30 |
abhishekk | rosmaita, thank you | 20:30 |
gmann | rosmaita patrole job with 'admin', 'member' or 'reader' role (patrole run the tests with these roles) are complaining that rule default value which is failed when doing explicit policy checks with oslo.policy but it is passed for all three roles via API. so mismatch between both result and test fail | 20:30 |
abhishekk | rosmaita, signing out for the day | 20:30 |
rosmaita | good night! | 20:31 |
abhishekk | thanks, have a good day ahead | 20:31 |
rosmaita | gmann: you're looking at the "overpermission" problem? | 20:35 |
gmann | rosmaita: yeah | 20:35 |
rosmaita | that is really weird, because with the old value of admin_role, you should see the overpermission every time | 20:36 |
gmann | rosmaita: let me check the old result if those were denied always or allowed to access. | 20:38 |
rosmaita | ok, thanks | 20:38 |
gmann | rosmaita: seems like it started disallow from oslo policy direct check. this is pass cases where oslo said it is allowed for tested roles -https://zuul.opendev.org/t/openstack/build/68dd608de9c549cca0779419841ca1d1/log/controller/logs/tempest_log.txt#54558 | 20:47 |
gmann | this is failure log where olso failed to parse the rule- https://zuul.opendev.org/t/openstack/build/aa4a224cab324ceb8f09ad2f76a73149/log/controller/logs/tempest_log.txt#54132 | 20:49 |
rosmaita | (looking -- log display is really slow) | 20:50 |
rosmaita | gmann: i don't understand that message -- what is it trying to parse? | 20:51 |
rosmaita | is it expecting that glance is still using a policy file? | 20:51 |
gmann | i think its default value of 'default' rule (empty string) "" | 20:51 |
rosmaita | i thought we didn't bother to define a "default" since it's impossible with policies defined in code | 20:52 |
rosmaita | but i dont' remember all the details of zane's patch | 20:52 |
gmann | we are missing the oslo policy log actually which could have tell what exact rule failed to parse. its empty string or new default of admin_role config | 20:54 |
rosmaita | https://review.opendev.org/#/c/698793/6 | 20:54 |
rosmaita | looks like abhishek and zane worked on that | 20:55 |
gmann | but it started failing recently so i doubt on the deprecated rule addition changes | 20:57 |
gmann | it changing the 'admin_role' config option might have caused this ? | 20:57 |
gmann | rosmaita: let me debug it locally to get more logs. both oslo policy and patrole logs are confusing at this movement. | 21:00 |
rosmaita | i doubt it ... this is the only place admin_role occurs in the glance code: https://opendev.org/openstack/glance/src/branch/master/glance/api/middleware/context.py#L224 | 21:00 |
rosmaita | gmann: thanks, will be helpful if you get more info | 21:01 |
*** rcernin has joined #openstack-glance | 22:17 | |
*** tkajinam has joined #openstack-glance | 22:53 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!