Tuesday, 2020-07-07

*** Liang__ has joined #openstack-glance01:27
*** rcernin has quit IRC02:22
*** rcernin has joined #openstack-glance02:22
*** Liang__ has quit IRC03:28
*** Liang__ has joined #openstack-glance03:33
*** evrardjp has quit IRC04:33
*** evrardjp has joined #openstack-glance04:33
*** Liang__ has quit IRC04:36
*** Liang__ has joined #openstack-glance04:40
*** ratailor has joined #openstack-glance04:56
*** Liang__ has quit IRC05:00
openstackgerritAbhishek Kekane proposed openstack/glance-specs master: Make cinder driver compatible with multiple stores  https://review.opendev.org/69515205:11
*** udesale has joined #openstack-glance05:35
*** m75abrams has joined #openstack-glance05:38
*** bhagyashris is now known as bhagyashris|brb05:50
*** Luzi has joined #openstack-glance05:58
*** brtknr has quit IRC06:15
*** bhagyashris|brb is now known as bhagyashris06:16
*** brtknr has joined #openstack-glance06:24
*** amoralej|off is now known as amoralej07:04
*** Liang__ has joined #openstack-glance07:11
*** mvkr has joined #openstack-glance07:13
*** tosky has joined #openstack-glance07:36
*** m75abrams has quit IRC07:53
*** rcernin has quit IRC07:57
*** rcernin has joined #openstack-glance08:15
*** rcernin has quit IRC08:29
*** rcernin has joined #openstack-glance08:44
*** Liang__ has quit IRC08:44
*** rcernin has quit IRC08:45
*** Liang__ has joined #openstack-glance08:45
*** priteau has joined #openstack-glance08:49
*** k_mouza has joined #openstack-glance08:59
*** Liang__ has quit IRC09:33
*** Liang__ has joined #openstack-glance09:39
*** tosky has quit IRC10:00
*** tosky has joined #openstack-glance10:01
*** k_mouza has quit IRC10:02
*** k_mouza has joined #openstack-glance10:10
*** Liang__ has quit IRC10:13
*** Liang__ has joined #openstack-glance10:14
*** Liang__ has quit IRC10:37
*** bhagyashris is now known as bhagyashris|brb10:37
*** priteau has quit IRC11:00
*** tkajinam has quit IRC11:04
*** bhagyashris|brb is now known as bhagyashris11:12
*** jmlowe has joined #openstack-glance11:43
*** udesale_ has joined #openstack-glance11:49
*** udesale has quit IRC11:52
*** priteau has joined #openstack-glance11:55
*** amoralej is now known as amoralej|lunch12:00
*** priteau has quit IRC12:12
*** priteau has joined #openstack-glance12:20
*** ratailor has quit IRC12:56
*** amoralej|lunch is now known as amoralej13:08
*** jdillaman has joined #openstack-glance13:32
*** Luzi has quit IRC13:41
dansmithabhishekk: is this good to go or does it need more votes? https://review.opendev.org/#/c/739062/13:54
abhishekkdansmith, need rosmaita to have a look13:54
dansmithah okay, was wondering if it needed a specific person too13:55
rosmaitaack13:55
abhishekkglance has a policy that specs needs to be reviewed by all cores, which we are going to revisit in this meeting13:55
dansmithah okay I didn't realize that13:58
rosmaitadansmith: left a question & comment for you on the spec14:08
*** bhagyashris is now known as bhagyashris|dinn14:09
dansmithrosmaita: replied14:12
* dansmith notes how often irc becomes the async notification stream for gerrit comments14:13
rosmaitadansmith: replied14:24
dansmithrosmaita: replied14:26
rosmaitadansmith: replied14:27
dansmithhehe, I have no further replies to notify you of14:28
rosmaita\o/14:28
dansmithabhishekk: rosmaita: cinder can be a backend for glance, right? who owns the cinder resources?14:29
rosmaitadansmith: depends, either glance service user or individual tenant14:29
rosmaitadepends on config, i mean, operator chooses, not end user14:30
dansmithokay, so... if it's configured for "tenant" and I perform a copy-image on someone else's image, that might mean I own the new cinder copy?14:31
rosmaitano, it would be the tenant -- which would mean you personally get a "free" image that they are paying storage for14:33
dansmithwell, what I mean is.. right now if I copy-image on an image I own, it's clear that the cinder resource created is owned by me,14:34
dansmithbut if I am not the owner, but am allowed to do this, does glance use the user/tenant in my request to pass to cinder to create the new resources? or does it specifically look at the owner of the image and send that user/tenant to cinder?14:34
*** abhishekk is now known as abhishekk|away14:36
rosmaitadansmith: that is a good question14:38
openstackgerritDan Smith proposed openstack/glance-specs master: Add copy-unowned-image spec  https://review.opendev.org/73906214:38
rosmaitai think it may come from the request, because this situation has never happened before14:38
dansmithyeah, that's what I was worried about14:38
dansmithwhat happens if you try to delete an image and it can't delete one of the cinder resources? does it fail or just ignore and keep going?14:39
dansmithif the latter, then the owner of the cinder resource is really who gets charged for the storage of it, and they can delete it when they want to, without impacting the owner14:39
dansmithare there other glance backends that would have this problem of using the request's owner to create the resources in a copy?14:43
dansmithif it's only cinder, then it's probably enough to just document that *if* you're using the cinder backend and *if* configured to have the requester own the resources, you probably shouldn't delegate this to non-owners14:43
rosmaitadansmith: it's an option for the swift driver, too14:47
rosmaitapossibly S3?14:47
rosmaitayou have opened a can of worms :)14:48
dansmithwelp, even devstack and tempest can't easily use this feature without delegation of some kind, so...14:48
dansmithrosmaita: do swift and S3 have the same "owner or service user" options?14:49
dansmithI assume there's some way to map keystone tenants to s3 tenants in the s3 case?14:49
rosmaitaswift does explicitly, don't know about S314:49
rosmaitaS3 was only restored recently, i have no idea how it works14:50
dansmithwell, then for swift and cinder, I rest on my documentation point. If s3 doesn't have a mapping, I would tend to imagine it either (a) has other problems or (b) leaves everything owned by one user14:52
dansmithactually, for swift and cinder, I would think that glance would see a 404 if the original owner's token is used to try to delete the owned-by-a-delegate location, and should just assume it was deleted from underneath them, so that it doesn't really impact deleting the image itself14:54
dansmithif it didn't, then it would be stuck in the case where the user just deleted the cinder resource themselves before the image14:54
dansmithwho would be able to answer these questions? abhishekk|away ?14:54
rosmaitamaybe jokke14:56
dansmithack14:56
*** bhagyashris|dinn is now known as bhagyashris14:56
rosmaitabut there is a good chance that no one knows, really14:57
dansmithdoes glance have CI jobs for cinder and swift backing stores? That'd be a good way to poke at it14:58
dansmithI dunno what tempest-integrated-storage is, but otherwise I don't see a lot of real tempest/devstack jobs :/15:00
*** k_mouza_ has joined #openstack-glance15:11
*** k_mouza has quit IRC15:13
*** m75abrams has joined #openstack-glance15:17
*** m75abrams has quit IRC15:26
*** amoralej is now known as amoralej|off15:57
*** udesale_ has quit IRC16:29
jokkedansmith: rosmaita: abhishekk|away: If the delayed delete is used, the image gets "deleted" and the scrubber goes and deletes the data at some point, I'm not even sure how this works in the tenant owned images where the credentials are not obviously available. IIRC without delayed delete, the delete fails if all the locations can't be deleted.17:21
dansmithjokke: and in the non-delayed case, the delete happens with the tenant's token, not the service user?17:22
jokkedansmith: if the resource in the store is owned by the user tenant, correct17:23
dansmithif the resource is *configured* to be owned by the user tenant, I assume you mean?17:23
jokkeSo I'm thinking we probably should document this process as _not_ supported unless the stores are configured to use service credentials17:23
dansmithack17:24
dansmithjokke: do you know what happens if the tenant owns the resource, the tenant deletes it before it deletes the instance and glance sees the 404 from, say, cinder?17:24
dansmithbecause I think that resources you don't own but are directly referenced are generally 404'd, looking like the I-already-deleted-it case if they end up owned by a different person17:25
jokkeI think we get over that, but not 100% sure. And at least glance returns differently. We return forbidden if you don't own the image, but can see it and 404 only if you can't see the resource17:26
dansmithright, that's the same as other services I think17:27
dansmithif you try to even get /servers/instance-i-dont-own, you get a 404 not a 40117:27
dansmithanyway, nova will only use this for rbd, where the resources are all unowned anyway, so it shouldn't be a problem for this use-case, and I imagine the primary case for granting copy permissions on public images will be for this nova situation17:28
dansmithso documenting the caveats seems fine to me17:28
dansmithand if people start wanting to do this more powerfully, then the glance team can iterate from there17:29
jokkedansmith: that's what I'm thinking too17:30
jokkedansmith: I don't see a reson to try to solve any weird corner cases on a work you decided to take on that already blew on your face on it's complexity17:32
dansmithheh, thanks17:32
*** k_mouza_ has quit IRC17:49
*** priteau has quit IRC17:52
*** mvkr has quit IRC18:08
*** dosaboy has quit IRC21:17
*** mvkr has joined #openstack-glance21:20
*** dosaboy has joined #openstack-glance21:25
*** dosaboy has quit IRC21:40
*** dosaboy has joined #openstack-glance21:45
openstackgerritDan Smith proposed openstack/glance master: WIP Add a policy knob for allowing non-owned image copying  https://review.opendev.org/73870322:37
*** nicolasbock has quit IRC22:47
*** gmann has quit IRC22:47
*** vkmc has quit IRC22:47
*** coreycb has quit IRC22:47
*** mnaser has quit IRC22:50
*** TheJulia has quit IRC22:50
*** CeeMac has quit IRC22:51
*** NobodyCam has quit IRC22:52
*** rm_work has quit IRC22:52
*** rajinir_ has quit IRC22:52
*** lseki has quit IRC22:53
*** donnyd has quit IRC22:53
*** tkajinam has joined #openstack-glance22:54
*** tosky has quit IRC23:01
*** rcernin has joined #openstack-glance23:17

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!