Friday, 2020-07-24

« Thursday, 2020-07-23 Index Saturday, 2020-07-25 »
*** jmlowe has joined #openstack-glance00:01
brinzhang_dansmith: ack, I will try, thanks00:03
*** brinzhang0 has joined #openstack-glance00:06
*** brinzhang_ has quit IRC00:09
*** brinzhang has joined #openstack-glance00:17
*** brinzhang0 has quit IRC00:20
*** jmlowe has quit IRC00:58
*** jmlowe has joined #openstack-glance00:59
*** gyee has quit IRC02:33
*** gyee has joined #openstack-glance02:40
*** brinzhang_ has joined #openstack-glance03:33
*** brinzhang has quit IRC03:36
*** gyee has quit IRC04:14
*** udesale has joined #openstack-glance04:33
*** baojg has quit IRC04:40
*** baojg has joined #openstack-glance04:41
*** baojg has quit IRC05:12
*** ratailor has joined #openstack-glance05:14
*** ralonsoh has joined #openstack-glance07:28
*** amoralej|off is now known as amoralej07:31
*** baojg has joined #openstack-glance07:50
openstackgerritAbhishek Kekane proposed openstack/glance master: [Doc] Policy support to copy unowned images  https://review.opendev.org/74281007:52
abhishekkdansmith, ^^^07:52
*** baojg has quit IRC08:37
*** baojg has joined #openstack-glance08:39
*** ratailor_ has joined #openstack-glance09:06
*** ratailor has quit IRC09:08
openstackgerritAbhishek Kekane proposed openstack/glance master: Victoria milestone 2 release notes  https://review.opendev.org/74283509:26
openstackgerritAbhishek Kekane proposed openstack/glance master: Victoria milestone 2 release notes  https://review.opendev.org/74283509:45
*** k_mouza has joined #openstack-glance10:08
abhishekkdansmith, glance-cache-prefetcher needs to communicate to g-api as we have removed the registry dependency from glance10:14
*** k_mouza has quit IRC10:19
*** brinzhang_ has quit IRC10:20
*** k_mouza has joined #openstack-glance10:29
*** k_mouza has quit IRC10:45
*** baojg has quit IRC10:48
*** baojg has joined #openstack-glance10:50
*** baojg has quit IRC10:50
*** k_mouza has joined #openstack-glance10:51
*** baojg has joined #openstack-glance10:52
*** k_mouza has quit IRC10:53
*** k_mouza has joined #openstack-glance10:53
*** baojg has quit IRC10:55
*** baojg has joined #openstack-glance10:57
*** baojg has quit IRC11:01
*** k_mouza has quit IRC11:01
*** baojg has joined #openstack-glance11:02
*** baojg has quit IRC11:03
*** baojg has joined #openstack-glance11:04
*** baojg has quit IRC11:05
*** baojg has joined #openstack-glance11:08
*** udesale_ has joined #openstack-glance11:11
*** k_mouza has joined #openstack-glance11:12
*** udesale has quit IRC11:13
*** k_mouza has quit IRC11:17
*** baojg has quit IRC11:42
*** baojg has joined #openstack-glance11:44
*** baojg has quit IRC12:06
*** k_mouza has joined #openstack-glance12:07
*** baojg has joined #openstack-glance12:08
*** k_mouza has quit IRC12:12
*** k_mouza has joined #openstack-glance12:18
*** k_mouza has quit IRC12:23
*** k_mouza has joined #openstack-glance12:28
*** k_mouza has quit IRC12:31
*** k_mouza has joined #openstack-glance12:31
*** ratailor_ has quit IRC12:34
*** amoralej is now known as amoralej|lunch12:44
*** zigo has quit IRC13:19
*** baojg has quit IRC13:27
*** amoralej|lunch is now known as amoralej13:28
*** baojg has joined #openstack-glance13:29
*** zigo has joined #openstack-glance13:31
dansmithrosmaita: you said you wanted to see tempest tests on the wsgi stack,13:38
dansmithrosmaita: do you mean the regular set of tempest tests or the new unmerged ones for import?13:39
openstackgerritDan Smith proposed openstack/glance master: DNM: Run tempest tests on WSGI stack  https://review.opendev.org/74288313:39
dansmiththis ^ will get the latter13:39
*** baojg has quit IRC13:39
dansmiththe former is the tempest-integrated-storage-wsgi-import job13:40
*** baojg has joined #openstack-glance13:40
rosmaitadansmith: i mean the latter13:43
dansmithokay13:45
*** njohnston has joined #openstack-glance13:55
*** k_mouza has quit IRC14:00
openstackgerritMerged openstack/glance stable/ussuri: Fix broken glance-cache-manage utility  https://review.opendev.org/74274214:01
dansmithabhishekk: re: your poke earlier.. the prefetcher is the daemon thing right? why does it need to talk to the api?14:02
dansmithabhishekk: I got the impression that the api stored the image queue requests in a sqlite db that the prefetcher could read just like the unified api's periodic task could14:02
abhishekkdansmith, the earlier (when registry was available) the prefetcher daemon used to get the information related queued images from the sqllite db and then it was communicating with glance registry to pull those down in the cache14:06
abhishekksince we removed registry now there is no way to do so rather than communicating with the g-api14:06
dansmithokay I'm missing something14:07
abhishekkdansmith, if you go through prefetcher tool from pike you will understand the flow14:08
dansmithis there something that prevents that from working with the api running as wsgi?14:08
abhishekkat the moment it fails to establish the sql connection with glance db14:09
dansmithwhat does, the prefetcher daemon? and the main mysql db or the sqlite?14:09
openstackgerritAbhishek Kekane proposed openstack/glance stable/train: Fix broken glance-cache-manage utility  https://review.opendev.org/74288914:10
abhishekklet me tell you step by step14:11
*** k_mouza has joined #openstack-glance14:11
abhishekksqllite db is just used to store cache related information (like no of hits to cache, last hit time etc), it does not store image related info14:12
abhishekkprefetcher used to poke registry with image-id to get location of the image14:13
abhishekkusing that location url later prefetcher was communicating with glance_store to pull the image data and store it in cache14:13
abhishekkso second step where registry was used requires glance database to pull the actual image information14:14
dansmithokay, that's the main glance db yeah?14:14
dansmithand presumably the prefetcher, if it has a token, could look at the api to see the locations instead of the glance db, is that what you meant before?14:15
abhishekkby saying glance db I am actually referring the db which is used by API (or registry before removing)14:16
dansmithis that not the mysql db?14:17
dansmithi.e. where all the image info is stored14:17
abhishekkyes mysql db :)14:18
dansmithright, okay, so ... either the prefetcher needs to be able to talk to the database to get the location info,14:21
dansmithor to the API to get it right?14:21
abhishekkyes14:22
openstackgerritAbhishek Kekane proposed openstack/glance master: Victoria milestone 2 release notes  https://review.opendev.org/74283514:26
*** baojg has quit IRC14:33
openstackgerritSean McGinnis proposed openstack/glance master: Fix release note formatting  https://review.opendev.org/74289314:34
*** baojg has joined #openstack-glance14:34
dansmithabhishekk: sorry I got pulled into something else that I need to resolve14:39
abhishekkdansmith, no issues14:39
*** k_mouza has quit IRC14:43
*** k_mouza has joined #openstack-glance14:53
*** udesale_ has quit IRC14:55
openstackgerritDan Smith proposed openstack/glance master: DNM: Run tempest tests on WSGI stack  https://review.opendev.org/74288314:59
*** k_mouza has quit IRC15:03
openstackgerritAbhishek Kekane proposed openstack/glance master: Victoria milestone 2 release notes  https://review.opendev.org/74283515:18
*** k_mouza has joined #openstack-glance15:19
openstackgerritAbhishek Kekane proposed openstack/glance master: [Doc] Policy support to copy unowned images  https://review.opendev.org/74281015:21
-openstackstatus- NOTICE: We are renaming projects in Gerrit and review.opendev.org will experience a short outage. Thank you for your patience.15:22
*** k_mouza has quit IRC15:23
* abhishekk dinner break, back in 45 mins15:28
*** k_mouza has joined #openstack-glance15:32
*** k_mouza has quit IRC15:36
*** k_mouza has joined #openstack-glance15:37
*** gyee has joined #openstack-glance15:42
*** k_mouza has quit IRC15:42
*** k_mouza has joined #openstack-glance15:47
*** k_mouza has quit IRC15:51
*** k_mouza has joined #openstack-glance15:54
*** k_mouza has quit IRC15:59
*** k_mouza has joined #openstack-glance16:04
*** k_mouza has quit IRC16:08
*** amoralej is now known as amoralej|off16:08
*** k_mouza has joined #openstack-glance16:15
*** k_mouza has quit IRC16:17
*** k_mouza has joined #openstack-glance16:18
*** baojg has quit IRC16:26
*** baojg has joined #openstack-glance16:28
dansmithjokke: async notification that I answered your questioj16:45
dansmith*question16:45
dansmithabhishekk: which doc do we mention the new [wsgi] stuff in? the httpd doc? I figure we need to revert the changes to that before we go add this as the instructions have been replaced with "don't do this" IIRC16:46
abhishekkdansmith, let me check16:47
dansmithabhishekk: btw I've noticed this test fails randomly sometimes: https://afe51b0fdebfaf851085-afdd1b8d1365a659d6bca493609e84c0.ssl.cf1.rackcdn.com/742883/2/check/openstack-tox-lower-constraints/5a8ef4e/testr_results.html16:48
dansmithah maybe I should change that mock if something is getting lost there16:49
abhishekkI am seeing this failure first time16:49
dansmithI think it's that mock, I'll update it after jokke has a chance to find other stuff16:53
abhishekkdansmith, ack16:53
abhishekkalso I will revert my comment about doc change, but we need to address it once docs are reverted16:54
dansmithyep agreed16:56
*** k_mouza has quit IRC16:59
jokkedansmith: cheers17:14
*** k_mouza has joined #openstack-glance17:17
jokkedansmith: great ... I wasn't exactly sure how that affected so just caught my eye there. Cheers for the clarification17:17
dansmithI probably assumed it was too obvious that that should ever ever happen except if someone does something wrong but I'll update the docstring to indicate *why* that would happen17:18
dansmithsince I need to update that mock in test_images anyway17:18
jokkeIt kind of was, more of a thing that we really don't have history of using asserts like that so I wasn't exactly sure if that assert would have been treated some other way than regular exception but same time it looked like "this should never happen so why is it here and is there a problem if it's not" :P17:20
*** k_mouza has quit IRC17:21
*** k_mouza has joined #openstack-glance17:22
dansmithwell yes a failed assert just raises AssertionError, which could be caught from the caller if desired17:23
dansmithbut yeah, in this case it's never caught because it should never happen :)17:24
jokkemakes sense17:25
*** baojg has quit IRC17:26
dansmiththe benefit of using an assert is that, as you point out, they can be dropped like comments for runtime optimization17:26
*** k_mouza has quit IRC17:27
*** baojg has joined #openstack-glance17:27
jokkedansmith: eyeballed it through couple of more times now. Nothing else really standing out. Personally I think bit more logging wouldn't hurt, but I'm more than happy to loo after that on follow up rather than having you going around and doing it.17:30
jokkes/loo/look/17:30
dansmithjokke: I'm happy to be more verbose in logging17:31
dansmithI have to update that mock, and the docstring so I might as well sprinkle some more logs in there now and then we can add more later if you want17:31
jokkeIf you are respinning it anyways, the one thing in that change that would be great to have logged is the threadpool init. Just giving indication of the mode and pool size ... could help debugging17:32
dansmithyep, was just typing there :)17:33
jokkeeasy to confirm that under uwsgi it's indeed real threads and how many ;)17:33
jokkeand same with eventlet that we don't anywhere start suddenly threadpool with real threads if not actually intended.17:33
dansmithsure17:34
openstackgerritAbhishek Kekane proposed openstack/glance stable/train: Fix broken glance-cache-manage utility  https://review.opendev.org/74288917:35
dansmithgmann: This didn't get the import tests in tempest turned on, do I need to do something other than depend on your thing? https://review.opendev.org/#/c/742883/17:47
gmanndansmith: it should run as devstack enabling import is there in depends-on series17:49
gmannchecking.17:49
dansmithyeah I thought so17:49
openstackgerritDan Smith proposed openstack/glance master: Make glance-api able to do async tasks in WSGI mode  https://review.opendev.org/74206517:49
openstackgerritDan Smith proposed openstack/glance master: Make image conversion use a proper python interpreter for prlimit  https://review.opendev.org/74231417:49
openstackgerritDan Smith proposed openstack/glance master: Make wsgi_app support graceful shutdown  https://review.opendev.org/74249317:50
openstackgerritDan Smith proposed openstack/glance master: DNM: Run tempest tests on WSGI stack  https://review.opendev.org/74288317:50
dansmithjokke: ^17:50
gmanndansmith: they are running - https://a7278579f2a7b68e8a09-643409a283e79db7e81f738ea775c76a.ssl.cf5.rackcdn.com/742883/2/check/tempest-integrated-storage/a29c5d9/testr_results.html17:51
gmannhttps://zuul.opendev.org/t/openstack/build/a29c5d9f2f77474683590202accbbc56/log/job-output.txt#2658517:52
dansmithgmann: oh sorry, I meant in the wsgi job17:53
gmannohk17:53
dansmithtempest-integrated-storage-wsgi-import17:53
dansmithoh I see17:54
dansmithyou only set it in standalone mode in the devstack patch17:54
gmanndansmith: i see, i am setting the flag with standalone flag - https://zuul.opendev.org/t/openstack/build/e5c406666bf84d6a9ef20de3dbd961f3/log/controller/logs/tempest_conf.txt#5617:55
dansmithyeah, can I set $TEMPEST_CONF in local.conf?17:55
dansmither, "set things in $TEMPEST_CONF"17:55
dansmithif so I can just override in that patch in .zuul17:55
gmannlet me change it with GLANCE_USE_IMPORT_WORKFLOW17:56
dansmithah okay that'd work17:56
gmannyou can do in zuul.yaml also17:56
dansmithokay17:56
openstackgerritDan Smith proposed openstack/glance master: DNM: Run tempest tests on WSGI stack  https://review.opendev.org/74288317:58
gmanndansmith: done https://review.opendev.org/#/c/742574/17:59
gmanni will set that flag in tempest full job also17:59
dansmithcool, thanks17:59
gmannsorry for not considering the wsgi case :)18:00
* abhishekk signing out for the day, have a nice weekend all18:00
*** k_mouza has joined #openstack-glance18:00
dansmithno problem.. the dependency graph here is crazy :)18:00
dansmithabhishekk: o/18:00
abhishekko/~18:00
gmannlet me get devstack and tempet patches merge for easy dependencies18:01
dansmithI just fixed rosmaita's comment on images_client.py18:04
dansmith(I think)18:04
gmannthanks, i did not check those18:04
*** k_mouza has quit IRC18:05
gmannwe updated at same time and lost your changes, let me update on top of your.18:06
dansmithoops, sorry18:06
openstackgerritMerged openstack/glance master: Fix release note formatting  https://review.opendev.org/74289318:09
gmanndansmith: updated now, please recheck on 742883/18:10
dansmithI think I need a rebase18:13
*** gmann is now known as gmann_lunch18:13
openstackgerritDan Smith proposed openstack/glance master: Make glance-api able to do async tasks in WSGI mode  https://review.opendev.org/74206518:13
openstackgerritDan Smith proposed openstack/glance master: Make image conversion use a proper python interpreter for prlimit  https://review.opendev.org/74231418:13
openstackgerritDan Smith proposed openstack/glance master: Make wsgi_app support graceful shutdown  https://review.opendev.org/74249318:13
openstackgerritDan Smith proposed openstack/glance master: DNM: Run tempest tests on WSGI stack  https://review.opendev.org/74288318:13
dansmithgmann_lunch: thanks!18:13
jokkedansmith: the first patch on the chain looks great ... looking forward to play around with those changes in my test env maybe over the weekend.18:17
dansmithjokke: I think you should find something better to do with your weekend, but... as you wish :)18:18
jokkedansmith: IKR ... yet I actually am quite exited to see all this working :D18:20
dansmithwell, you can look at the wsgi-import job to see that, but.. sure sure :)18:21
jokkenow I'm heading to the store 'though ... Need to keep the priorities in check and I'm short on beer :P18:22
jokkeI think I have nothing under 8.5%ABV in stock18:23
jokkewill poke my head in here once I'm back so just highlight if you need something from me before I call it a weekend.18:23
dansmithenjoy :)18:24
*** gmann_lunch is now known as gmann19:19
dansmithrosmaita: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d8d/742883/5/check/tempest-integrated-storage-wsgi-import/d8dac4d/testr_results.html19:36
dansmithsmcginnis: just sayin' https://imgur.com/a/8j0Uu9C19:42
dansmiththere may or may be two more unfinished panels, but... :)19:43
rosmaitadansmith: nice!19:52
smcginnisdansmith: Not bad!19:56
*** ralonsoh has quit IRC19:57
dansmithrosmaita: the dependency graph for everything that is up right now is super crazy big so I'm waiting to land some of it before I start retooling the jobs to have some semblance of organization,19:58
dansmithbut that's definitely going to happen19:58
dansmithwe have like glance->tempest->devstack->glance->devstack at least going on right now19:58
dansmithI also want to import my nova job to your tree,19:59
dansmithso that you will get a nova-multistore, glance-multistore, ceph, import-enabled, image-converting copy-image test19:59
dansmithwhich is currently running in nova right now (and working)20:00
jokkedansmith: nice, ty ... you deserve something better than beer :D20:14
dansmithI like cars.20:14
jokkeI think I found just the right thing if I can figure out delivery https://hotwheels.mattel.com/shop/en-us/hw/cars-vehicles/hot-wheels-monster-trucks-test-subject-gbv38 :P20:24
dansmithheh20:33
*** baojg has quit IRC20:57
*** baojg has joined #openstack-glance20:58
« Thursday, 2020-07-23 Index Saturday, 2020-07-25 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!