| *** k_mouza has joined #openstack-glance | 00:09 | |
| *** k_mouza has quit IRC | 00:14 | |
| *** tkajinam has quit IRC | 00:59 | |
| *** tkajinam has joined #openstack-glance | 00:59 | |
| *** Liang__ has joined #openstack-glance | 01:08 | |
| *** gyee has quit IRC | 01:32 | |
| *** rcernin has quit IRC | 02:09 | |
| *** rcernin has joined #openstack-glance | 02:18 | |
| *** rcernin has quit IRC | 02:18 | |
| *** rcernin has joined #openstack-glance | 02:19 | |
| *** Liang__ has quit IRC | 03:11 | |
| *** Liang__ has joined #openstack-glance | 03:16 | |
| *** zzzeek has quit IRC | 03:17 | |
| *** zzzeek has joined #openstack-glance | 03:18 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-glance | 04:33 | |
| *** udesale has joined #openstack-glance | 04:44 | |
| *** belmoreira has joined #openstack-glance | 06:29 | |
| *** ralonsoh has joined #openstack-glance | 07:03 | |
| *** njohnston has quit IRC | 07:15 | |
| *** rcernin_ has joined #openstack-glance | 07:42 | |
| *** rcernin has quit IRC | 07:44 | |
| *** zzzeek has quit IRC | 07:45 | |
| *** zzzeek has joined #openstack-glance | 07:47 | |
| *** rosmaita has quit IRC | 07:51 | |
| *** rcernin_ has quit IRC | 07:56 | |
| *** rosmaita has joined #openstack-glance | 08:02 | |
| *** Liang__ has quit IRC | 08:32 | |
| *** Liang__ has joined #openstack-glance | 08:34 | |
| *** Liang__ has quit IRC | 09:33 | |
| *** whoami-rajat__ has joined #openstack-glance | 09:56 | |
| *** zzzeek has quit IRC | 11:20 | |
| *** zzzeek has joined #openstack-glance | 11:21 | |
| *** udesale_ has joined #openstack-glance | 11:28 | |
| *** udesale has quit IRC | 11:31 | |
| *** nikparasyr has joined #openstack-glance | 12:15 | |
| *** lpetrut has joined #openstack-glance | 13:21 | |
| *** zzzeek has quit IRC | 14:11 | |
| *** zzzeek has joined #openstack-glance | 14:12 | |
| *** priteau has joined #openstack-glance | 14:43 | |
| *** zzzeek has quit IRC | 14:56 | |
| *** zzzeek has joined #openstack-glance | 14:59 | |
| *** belmoreira has quit IRC | 15:03 | |
| *** lpetrut has quit IRC | 15:06 | |
| *** abhishekk is now known as abhishekk|afk | 15:42 | |
| *** gyee has joined #openstack-glance | 15:44 | |
| *** abhishekk|afk is now known as abhishekk | 16:10 | |
| *** nikparasyr has left #openstack-glance | 16:11 | |
| *** udesale_ has quit IRC | 16:11 | |
| *** dosaboy has joined #openstack-glance | 16:49 | |
| whoami-rajat__ | ping dansmith | 17:30 |
|---|---|---|
| dansmith | o/ | 17:30 |
| whoami-rajat__ | so for the functional test we have to setup the single store and create image then stop server (which i'm not able to find) and setup multiple stores then get the image | 17:31 |
| whoami-rajat__ | how do i refresh the conf and restart the service there? | 17:31 |
| whoami-rajat__ | i saw this msg https://github.com/openstack/glance/blob/master/glance/tests/functional/__init__.py#L1586-L1591 | 17:32 |
| whoami-rajat__ | but still didn't get a good idea | 17:32 |
| dansmith | yeah, you don't really need to restart it because it doesn't really start anything anyway | 17:32 |
| dansmith | if there's something in the init process that looks at the config, then you can just run start_server() again and it should be fine, | 17:33 |
| dansmith | but unless something is cached somewhere, there's probably not even a need to do that, | 17:33 |
| dansmith | just tweak your config and run another api operation | 17:33 |
| whoami-rajat__ | oh ok | 17:37 |
| whoami-rajat__ | sounds good | 17:37 |
| dansmith | that's the benefit of this base class. it's very direct into the api | 17:37 |
| whoami-rajat__ | and can you provide an idea about how do i unset the config options of single store? | 17:37 |
| dansmith | well, you just need to change some configs back to their default values or something right? | 17:38 |
| whoami-rajat__ | yeah i was thinking the same but i thought there was a way to unset things | 17:40 |
| whoami-rajat__ | ok i will try that | 17:40 |
| whoami-rajat__ | thanks | 17:40 |
| dansmith | not sure about that, I think just setting them back to their defaults is all I'd try to do | 17:41 |
| whoami-rajat__ | ack | 17:41 |
| *** ralonsoh has quit IRC | 17:48 | |
| *** zzzeek has quit IRC | 18:19 | |
| *** zzzeek has joined #openstack-glance | 18:20 | |
| *** priteau has quit IRC | 19:00 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/glance master: Support cinder multiple stores https://review.opendev.org/748039 | 19:13 |
| openstackgerrit | Rajat Dhasmana proposed openstack/glance master: Support cinder multiple stores https://review.opendev.org/748039 | 19:16 |
| openstackgerrit | Rajat Dhasmana proposed openstack/glance master: Adding gate job for glance cinder store https://review.opendev.org/750018 | 19:19 |
| whoami-rajat__ | dansmith: ^^ I've updated the patches with functional tests and moved the gate job to a different patch (to remove devstack dependency while merging), can you please take a look | 19:21 |
| dansmith | whoami-rajat__: left some comments | 19:43 |
| dansmith | functional test is nice, thanks for doing that | 19:43 |
| dansmith | FYI, US holiday on monday and I'll be heading out of here in a little bit | 19:44 |
| whoami-rajat__ | oh | 19:50 |
| whoami-rajat__ | hmm | 19:50 |
| whoami-rajat__ | your comments might take some time to fix | 19:52 |
| dansmith | I think they should be pretty straightforward, so if I'm not around on monday and abhishekk is happy with it, then he can just go for it | 19:54 |
| dansmith | no need to wait for me | 19:54 |
| *** zzzeek has quit IRC | 20:06 | |
| *** zzzeek has joined #openstack-glance | 20:10 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/glance master: Support cinder multiple stores https://review.opendev.org/748039 | 20:48 |
| whoami-rajat__ | dansmith: ^ updated | 20:50 |
| dansmith | whoami-rajat__: looks better, but I'm still not sure why you're passing in identical values in the unit test, and why you seem to be asserting things that are wrong (unless I'm missing something) | 21:00 |
| dansmith | you're asserting that the url is not changed, which is good, but the url is still wrongly formatted, AFAICT | 21:00 |
| whoami-rajat__ | dansmith: if there is no valid store configured for the image then the url remains the same | 21:04 |
| dansmith | whoami-rajat__: you mean if store_instance.is_image_associated_with_store() returns False for all of the locations right? | 21:05 |
| whoami-rajat__ | suppose we have 2 stores with type1 and type2 as cinder_volume_types and there's an image-volume with typ3 then location url won't change for this image i.e. no imgration | 21:05 |
| whoami-rajat__ | for a particular image when it returns false then the location values aren't updated | 21:05 |
| dansmith | okay, I guess maybe I'm thinking about this differently, | 21:06 |
| whoami-rajat__ | dansmith: also doesn't functional tests install test-requirements? | 21:07 |
| dansmith | I'm thinking of the top case as the "needs migration" case and the bottom one as "migration is already done", | 21:07 |
| whoami-rajat__ | no, both are legacy images but for 1st case a valid store exists and 2nd case no valid store exists | 21:07 |
| dansmith | but I think what you're saying is that the bottom one is "no migration can/should be done because that store does not have a volume_type set" ... is that right? | 21:07 |
| whoami-rajat__ | kind of, yes | 21:08 |
| dansmith | what does "nov valid store exists" mean in reality? | 21:08 |
| dansmith | like, what real world situation causes that to happen | 21:08 |
| whoami-rajat__ | the cinder multiple stores are differentiated on the basis of cinder_volume_type, take the example above of two stores defined with type1 and typ2 | 21:09 |
| whoami-rajat__ | suppose a legacy image exists whose image-volume has volume type as type3 | 21:10 |
| whoami-rajat__ | there is no valid store in which it can be moved | 21:10 |
| whoami-rajat__ | i.e. bad upgrade | 21:10 |
| whoami-rajat__ | i think abhishek has put up a document recently explaining how to handle all these upgrade cases | 21:10 |
| dansmith | right, but what does that mean? after someone has upgraded to V, and then changes their stores to point to something other than what the default volume type was in their U deployment where the images are created? | 21:11 |
| whoami-rajat__ | yep | 21:11 |
| whoami-rajat__ | also in U, it is not mandatory to set the cinder_volume_type | 21:12 |
| whoami-rajat__ | so the image-volume's created could be of any type | 21:12 |
| whoami-rajat__ | therefore we need to define all possible stores that exist in our image-volume's to migrate alll images | 21:12 |
| dansmith | okay, I see now | 21:12 |
| dansmith | I really think more words in here would help make that clear, because I really thought you were testing two different scenarios here than I guess you are | 21:14 |
| whoami-rajat__ | yeah i'm not very good with words/explanation stuff, i think Abhishek's document would clear things more | 21:15 |
| whoami-rajat__ | https://review.opendev.org/#/c/749438/ | 21:16 |
| dansmith | I'm commenting with suggested words, just a sec | 21:18 |
| dansmith | whoami-rajat__: can you answer my question about why you're always passing in metadata, store, and expected as identical things? | 21:18 |
| whoami-rajat__ | dansmith: i also don't remember exactly, i think i wrote some tests earlier with different values and this is a residue, i will move them inside the helper method | 21:25 |
| dansmith | ack | 21:25 |
| dansmith | whoami-rajat__: do those words on the test I commented make sense? | 21:25 |
| whoami-rajat__ | that's like a documentation for the tests :P but if it makes the tests easier to understand then works for me | 21:29 |
| dansmith | sure, the tests should be like further documentation for the code... they should be readable to understand why something is tested, which helps understand why the code is doing what it is | 21:30 |
| dansmith | but like I said, it makes sense to put some of that in the docstring as well | 21:30 |
| whoami-rajat__ | ack, it's very late here so i will probably update it on monday, thanks for the reviews dansmith | 21:32 |
| dansmith | ack, have a good weekend! | 21:32 |
| whoami-rajat__ | you too have a great weekend! | 21:33 |
| *** rcernin_ has joined #openstack-glance | 21:52 | |
| *** rcernin_ has quit IRC | 22:29 | |
| *** whoami-rajat__ has quit IRC | 23:57 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!