*** zzzeek has quit IRC | 00:06 | |
*** zzzeek has joined #openstack-glance | 00:08 | |
*** zzzeek has quit IRC | 00:24 | |
*** zzzeek has joined #openstack-glance | 00:29 | |
*** zzzeek has quit IRC | 00:34 | |
*** zzzeek has joined #openstack-glance | 00:35 | |
*** Liang__ has joined #openstack-glance | 01:25 | |
*** hoonetorg has quit IRC | 01:47 | |
*** hoonetorg has joined #openstack-glance | 01:48 | |
*** zzzeek has quit IRC | 02:47 | |
*** zzzeek has joined #openstack-glance | 02:51 | |
*** rcernin has quit IRC | 02:59 | |
*** rcernin has joined #openstack-glance | 03:13 | |
*** udesale has joined #openstack-glance | 03:15 | |
*** zzzeek has quit IRC | 03:19 | |
*** udesale_ has joined #openstack-glance | 03:19 | |
*** zzzeek has joined #openstack-glance | 03:21 | |
*** udesale has quit IRC | 03:22 | |
*** zzzeek has quit IRC | 04:03 | |
*** zzzeek has joined #openstack-glance | 04:05 | |
*** whoami-rajat__ has joined #openstack-glance | 04:15 | |
*** ratailor has joined #openstack-glance | 04:18 | |
*** evrardjp has quit IRC | 04:33 | |
*** evrardjp has joined #openstack-glance | 04:33 | |
*** m75abrams has joined #openstack-glance | 04:53 | |
*** zzzeek has quit IRC | 06:02 | |
*** zzzeek has joined #openstack-glance | 06:03 | |
*** zzzeek has quit IRC | 06:22 | |
*** zzzeek has joined #openstack-glance | 06:24 | |
*** ralonsoh has joined #openstack-glance | 06:35 | |
*** rcernin has quit IRC | 08:00 | |
*** zzzeek has quit IRC | 08:16 | |
*** zzzeek has joined #openstack-glance | 08:17 | |
*** nikparasyr has joined #openstack-glance | 08:24 | |
*** k_mouza has joined #openstack-glance | 08:26 | |
*** priteau has joined #openstack-glance | 08:35 | |
*** zzzeek has quit IRC | 08:47 | |
*** zzzeek has joined #openstack-glance | 08:50 | |
*** priteau has quit IRC | 09:12 | |
*** priteau has joined #openstack-glance | 09:14 | |
*** priteau has quit IRC | 09:17 | |
*** priteau has joined #openstack-glance | 09:17 | |
openstackgerrit | likui proposed openstack/glance master: Add boto3 requirements.txt https://review.opendev.org/750300 | 09:29 |
---|---|---|
*** Liang__ has quit IRC | 10:02 | |
*** k_mouza has quit IRC | 10:16 | |
*** belmoreira has joined #openstack-glance | 10:28 | |
*** zzzeek has quit IRC | 10:48 | |
*** zzzeek has joined #openstack-glance | 10:50 | |
*** k_mouza has joined #openstack-glance | 11:08 | |
*** k_mouza has quit IRC | 11:14 | |
*** k_mouza has joined #openstack-glance | 11:18 | |
*** udesale__ has joined #openstack-glance | 11:20 | |
*** udesale_ has quit IRC | 11:22 | |
openstackgerrit | likui proposed openstack/glance master: Add boto3 requirements.txt https://review.opendev.org/750300 | 11:25 |
*** rosmaita has joined #openstack-glance | 11:58 | |
*** njohnston has joined #openstack-glance | 12:15 | |
mnaser | morning folks: can we have a look at https://review.opendev.org/#/c/748877/ ? | 12:23 |
mnaser | it's still logging errors everywhere for us and it would be useful :) | 12:23 |
openstackgerrit | Merged openstack/glance master: Remove babel.cfg etc https://review.opendev.org/749657 | 12:31 |
openstackgerrit | likui proposed openstack/glance master: Remove six.PY3 and six.PY2 https://review.opendev.org/750342 | 12:32 |
openstackgerrit | likui proposed openstack/glance master: Remove six.PY3 and six.PY2 https://review.opendev.org/750342 | 12:40 |
*** ratailor has quit IRC | 12:52 | |
*** Luzi has joined #openstack-glance | 12:55 | |
openstackgerrit | likui proposed openstack/glance master: Remove six.PY3 and six.PY2 https://review.opendev.org/750342 | 12:58 |
*** k_mouza has joined #openstack-glance | 13:09 | |
*** Luzi has quit IRC | 13:47 | |
*** priteau has quit IRC | 14:23 | |
*** k_mouza has quit IRC | 14:27 | |
whoami-rajat__ | hi smcginnis , I've sent out a mail regarding FFE as the feature requires another release of glance_store, do we require FFE from requirements team as well? | 14:27 |
whoami-rajat__ | abhishekk: rosmaita ^^ | 14:27 |
abhishekk | whoami-rajat__, AFAIK, we don't unless we have cut a stable branch for glance_store with the last release, but word from smcginnis will help us more in this case | 14:29 |
abhishekk | jokke, ^^ | 14:29 |
abhishekk | dansmith, ^^ | 14:30 |
rosmaita | abhishekk: looks like you slipped one past the goalie there ... i think you were supposed to cut a stable branch for the victoria glance_store release | 14:31 |
rosmaita | or, i have my deadlines confused | 14:31 |
abhishekk | rosmaita, I asked smcginnis about the same and he said its not necessary that we should do it in the same patch | 14:31 |
rosmaita | interesting | 14:32 |
abhishekk | in last weeks meeting | 14:33 |
rosmaita | i need to pay more attention at these meetings | 14:33 |
smcginnis | Not the same patch, but the branch should be created. The deadline for non-client libraries was last Thursday, so we are now past the freeze. | 14:34 |
smcginnis | So really it should include a FFE ack from requirements. | 14:35 |
abhishekk | smcginnis, that means we need to put a patch to create new branch as well | 14:35 |
smcginnis | Yep. But I can run a script to generate patches for any libs that are missing them. | 14:36 |
abhishekk | is it possible for you to do it? | 14:36 |
abhishekk | ack | 14:36 |
smcginnis | But if you need to do a FFE, we can either hold off on that, or we can create the branch now, then backport the change. | 14:36 |
smcginnis | What is it that needs to be released yet? | 14:37 |
abhishekk | https://review.opendev.org/750131 | 14:37 |
abhishekk | ^^ | 14:37 |
abhishekk | this issue we found during writing functional tests in glance | 14:37 |
smcginnis | Ah, yep, that looks like it's probably important enough. | 14:37 |
abhishekk | strange that it is not failing in actual development environment but only during tests | 14:38 |
smcginnis | Is it maybe our test code? | 14:38 |
smcginnis | Certainly would be easier if it was just a matter of fixing the test. | 14:38 |
smcginnis | That looks like it's turning a warning into an error. | 14:39 |
abhishekk | yesterday jokke and me put couple of hours looking into it, but didn't get the clue | 14:39 |
abhishekk | yes | 14:39 |
abhishekk | jokke, has pointed out that, for some reason this https://github.com/openstack/glance/blob/master/tox.ini#L16 get overwritten | 14:39 |
smcginnis | Still odd that it would treat a deprecation warning as an error. | 14:41 |
abhishekk | yes | 14:43 |
*** tkajinam has quit IRC | 14:43 | |
abhishekk | So, I guess we should send FFE to requirements team, get this patch, release the store and then create the branch? | 14:46 |
smcginnis | abhishekk: Yeah, that's probably best. | 14:48 |
smcginnis | We may need to do something like https://opendev.org/openstack/glance/src/branch/master/glance/tests/unit/fixtures.py#L133-L136 | 14:48 |
abhishekk | looking | 14:48 |
smcginnis | But if we can just get rid of the warning in the first place, that's probably cleaner. | 14:48 |
*** priteau has joined #openstack-glance | 14:49 | |
abhishekk | smcginnis, let me try first clearing the warning is possible without .new release of store | 14:50 |
abhishekk | if it is then we will fix it in master and later backport | 14:50 |
smcginnis | ++ | 14:50 |
abhishekk | unit | 14:51 |
*** k_mouza has joined #openstack-glance | 14:51 | |
abhishekk | smcginnis, I changed above from error to ignore and tests are passing now | 14:54 |
smcginnis | Great! | 14:55 |
abhishekk | So, is it good idea to ignore it, get the glance patch in, release glance and then enable it on master? | 14:56 |
abhishekk | I think lets go in right direction, apply for FFE, release glance_store then release glance | 14:57 |
abhishekk | smcginnis, whoami-rajat__ ^^ | 15:01 |
smcginnis | abhishekk: Either way. It would be good to stop using the deprecated bits. | 15:02 |
abhishekk | smcginnis, ack, please approve the FFE :D | 15:02 |
abhishekk | whoami-rajat__, will send mail soon | 15:02 |
smcginnis | abhishekk: I've proposed a glance_store stable/victoria, but feel free to -1 that, and/or update that to be a new release with the branch being created from the new point. | 15:02 |
*** k_mouza has quit IRC | 15:03 | |
abhishekk | smcginnis, ack | 15:03 |
*** nikparasyr has left #openstack-glance | 15:09 | |
*** k_mouza has joined #openstack-glance | 15:10 | |
*** k_mouza has quit IRC | 15:29 | |
* abhishekk dinner break | 15:30 | |
*** jmlowe has quit IRC | 15:30 | |
jokke | smcginnis: abhishekk: yeah, I don't know why the tests suddenly treat warnings.warn as errors. I was able to get around that by overwriting the func to pass but no matter what I did on the test definitions it blows. Likely stestr has something hardcoded | 15:32 |
*** jmlowe has joined #openstack-glance | 15:32 | |
smcginnis | Hmm, seems really odd. | 15:33 |
jokke | smcginnis: cheers for the branch patch. I think it would be cleaner not to need release minor for that and backport ;) | 15:33 |
jokke | smcginnis: yeah ... coundn't get to the bottom of it but fortunately the actual fix is easy and should have done ages ago | 15:34 |
abhishekk | jokke, https://opendev.org/openstack/glance/src/branch/master/glance/tests/unit/fixtures.py#L133-L136 | 15:35 |
smcginnis | Yeah, good to get out the deprecated stuff at least. | 15:35 |
*** k_mouza has joined #openstack-glance | 15:41 | |
*** udesale__ has quit IRC | 16:02 | |
*** belmoreira has quit IRC | 16:04 | |
*** k_mouza has quit IRC | 16:06 | |
*** m75abrams has quit IRC | 16:08 | |
*** k_mouza has joined #openstack-glance | 16:08 | |
*** ralonsoh has quit IRC | 16:12 | |
*** ralonsoh has joined #openstack-glance | 16:12 | |
*** k_mouza has quit IRC | 16:18 | |
whoami-rajat__ | smcginnis: I've sent out mail for the requirements FFE | 16:22 |
*** k_mouza has joined #openstack-glance | 16:24 | |
whoami-rajat__ | smcginnis: http://lists.openstack.org/pipermail/openstack-discuss/2020-September/017087.html | 16:27 |
*** k_mouza has quit IRC | 16:30 | |
*** rosmaita has left #openstack-glance | 16:33 | |
*** ralonsoh has quit IRC | 16:39 | |
*** ralonsoh has joined #openstack-glance | 16:40 | |
*** lpetrut has joined #openstack-glance | 16:46 | |
*** ralonsoh has quit IRC | 17:23 | |
*** gyee has joined #openstack-glance | 17:33 | |
*** rosmaita has joined #openstack-glance | 17:33 | |
*** lpetrut has quit IRC | 17:51 | |
*** priteau has quit IRC | 19:20 | |
*** whoami-rajat__ has quit IRC | 20:14 | |
*** zzzeek has quit IRC | 20:16 | |
*** zzzeek has joined #openstack-glance | 20:17 | |
openstackgerrit | Merged openstack/glance master: Support cinder multiple stores https://review.opendev.org/748039 | 20:22 |
rosmaita | \o/ | 20:29 |
*** tkajinam has joined #openstack-glance | 22:57 | |
*** tkajinam has quit IRC | 22:57 | |
*** tkajinam has joined #openstack-glance | 22:58 | |
*** rcernin has joined #openstack-glance | 23:02 | |
*** zzzeek has quit IRC | 23:33 | |
*** zzzeek has joined #openstack-glance | 23:35 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!