| *** zzzeek has quit IRC | 00:13 | |
| *** zzzeek has joined #openstack-glance | 00:15 | |
| *** zzzeek has quit IRC | 00:20 | |
| *** zzzeek has joined #openstack-glance | 00:21 | |
| *** zzzeek has quit IRC | 00:33 | |
| *** zzzeek has joined #openstack-glance | 00:35 | |
| *** Liang__ has joined #openstack-glance | 01:12 | |
| *** zzzeek has quit IRC | 01:22 | |
| *** zzzeek has joined #openstack-glance | 01:24 | |
| *** gyee has quit IRC | 01:25 | |
| *** zzzeek has quit IRC | 01:45 | |
| *** zzzeek has joined #openstack-glance | 01:47 | |
| *** k_mouza has joined #openstack-glance | 02:25 | |
| *** k_mouza has quit IRC | 02:30 | |
| *** rcernin has quit IRC | 02:46 | |
| *** rcernin has joined #openstack-glance | 02:56 | |
| *** k_mouza has joined #openstack-glance | 03:24 | |
| *** k_mouza has quit IRC | 03:28 | |
| *** k_mouza has joined #openstack-glance | 03:32 | |
| *** udesale has joined #openstack-glance | 03:34 | |
| *** k_mouza has quit IRC | 03:36 | |
| *** Liang__ has quit IRC | 04:11 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-glance | 04:33 | |
| *** ratailor has joined #openstack-glance | 04:34 | |
| *** m75abrams has joined #openstack-glance | 04:57 | |
| *** k_mouza has joined #openstack-glance | 05:18 | |
| *** rcernin has quit IRC | 05:19 | |
| *** k_mouza has quit IRC | 05:23 | |
| *** rcernin has joined #openstack-glance | 05:27 | |
| *** rcernin has quit IRC | 05:28 | |
| *** rcernin has joined #openstack-glance | 05:28 | |
| *** ralonsoh has joined #openstack-glance | 06:03 | |
| *** lpetrut has joined #openstack-glance | 06:15 | |
| *** whoami-rajat__ has joined #openstack-glance | 06:45 | |
| *** ratailor has quit IRC | 07:08 | |
| *** ratailor has joined #openstack-glance | 07:08 | |
| *** ralonsoh has quit IRC | 07:17 | |
| openstackgerrit | Grégoire Unbekandt proposed openstack/glance master: Image import "web-download" check downloaded size https://review.opendev.org/752067 | 07:32 |
|---|---|---|
| *** k_mouza has joined #openstack-glance | 07:40 | |
| *** k_mouza has quit IRC | 07:44 | |
| *** rcernin has quit IRC | 08:06 | |
| *** ralonsoh has joined #openstack-glance | 08:20 | |
| *** k_mouza has joined #openstack-glance | 08:22 | |
| *** ralonsoh has quit IRC | 08:24 | |
| *** udesale_ has joined #openstack-glance | 08:24 | |
| *** k_mouza has quit IRC | 08:26 | |
| *** udesale has quit IRC | 08:27 | |
| *** udesale__ has joined #openstack-glance | 08:30 | |
| *** k_mouza has joined #openstack-glance | 08:31 | |
| *** udesale_ has quit IRC | 08:33 | |
| *** k_mouza has quit IRC | 08:35 | |
| *** k_mouza has joined #openstack-glance | 08:44 | |
| *** ralonsoh has joined #openstack-glance | 09:16 | |
| *** jawad_axd has joined #openstack-glance | 10:07 | |
| *** zzzeek has quit IRC | 11:27 | |
| *** zzzeek has joined #openstack-glance | 11:30 | |
| *** ratailor has quit IRC | 12:01 | |
| openstackgerrit | Grégoire Unbekandt proposed openstack/glance master: Image import "web-download" check downloaded size https://review.opendev.org/752067 | 12:58 |
| *** udesale has joined #openstack-glance | 13:15 | |
| *** udesale__ has quit IRC | 13:16 | |
| *** benj_ has quit IRC | 13:38 | |
| *** rosmaita has quit IRC | 13:38 | |
| *** rosmaita has joined #openstack-glance | 13:39 | |
| *** k_mouza has quit IRC | 13:49 | |
| *** benj_ has joined #openstack-glance | 13:51 | |
| *** k_mouza has joined #openstack-glance | 13:56 | |
| *** Liang__ has joined #openstack-glance | 14:00 | |
| *** Liang__ is now known as LiangFang | 14:00 | |
| *** m75abrams has quit IRC | 14:02 | |
| openstackgerrit | Grégoire Unbekandt proposed openstack/glance master: Fix cleaning of web-download image import https://review.opendev.org/607680 | 14:15 |
| *** LiangFang has quit IRC | 14:25 | |
| *** Liang__ has joined #openstack-glance | 14:27 | |
| *** priteau has joined #openstack-glance | 14:30 | |
| *** udesale has quit IRC | 14:37 | |
| *** lpetrut has quit IRC | 14:38 | |
| dansmith | abhishekk: can you comment on my comment about communicating revert parameters through an exception here? https://review.opendev.org/#/c/752067/3/glance/async_/flows/_internal_plugins/web_download.py@129 | 14:39 |
| abhishekk | dansmith, looking | 14:39 |
| abhishekk | dansmith, so revert you are talking about is to use it for cleaning the data? | 14:44 |
| dansmith | abhishekk: yeah, the author is saying they're passing that path into the exception so that the store can be cleaned during revert, in a different patch (see the top-level comment) | 14:45 |
| abhishekk | dansmith, ack, I just saw that other patch | 14:45 |
| abhishekk | dansmith, commented | 14:49 |
| dansmith | abhishekk: ah, that store.add() is the staging store? | 14:50 |
| dansmith | I guess that makes sense | 14:50 |
| abhishekk | yes, staging store | 14:50 |
| dansmith | yeah I kinda forgot that's the flow | 14:52 |
| abhishekk | :D | 14:54 |
| *** k_mouza has quit IRC | 14:55 | |
| *** k_mouza has joined #openstack-glance | 15:01 | |
| *** Liang__ has quit IRC | 15:04 | |
| *** gyee has joined #openstack-glance | 15:05 | |
| jokke | None of that is necessary as it's stored as the target image ID so we always know where that data is if it exists | 15:05 |
| dansmith | well, I think the point was to avoid having to make another db call or something, but regardless, it seemed not-very-taskflow-esque to stash it in the exception, yeah | 15:06 |
| dansmith | s/think/assume/ | 15:06 |
| jokke | don't need even db call, all what's needed is available as we can look up the staging uri from conf if needed and the image id is saved in the task object parameters | 15:08 |
| abhishekk | I think there is a difference here; | 15:09 |
| abhishekk | for glance-direct image is staged before import call is made, so if import is failed then the image-status will reverted back to uploading (which indicates data is in staging and we can reissue import call) | 15:09 |
| abhishekk | In case of web-download image is staged during import call it self so state transition is like <queued-uploading-importing-active> and as we are setting image status back to queued in reviert call of this method then if we try to restage the data to same image using /stage call then it will raise Duplicate exception here (https://github.com/openstack/glance/blob/master/glance/api/v2/image_data.py#L345). | 15:09 |
| abhishekk | So that image is no longer useful and we need to delete it. If we delete data in revert then we can use the image to stage the data and import call. | 15:09 |
| jokke | and if one wants to be really clever about it, just adding "self." x2 (when the path is defined in row 120 and when it's returned in 121 would save that directly in the object | 15:09 |
| dansmith | jokke: right, that was my suggestion | 15:10 |
| jokke | dansmith: ++ | 15:10 |
| jokke | I know myself too well how easy it is to overcomplicate things | 15:11 |
| jokke | most of the things I clean up multiple iterations and end up with like 30% of the code in the first one :P | 15:11 |
| abhishekk | I don't think these bugs are critical enough to involve these in victoria release, we can backport them later as well, any suggestion? | 15:14 |
| abhishekk | jokke, dansmith ^^ | 15:14 |
| dansmith | abhishekk: yeah agree | 15:15 |
| abhishekk | ack | 15:15 |
| jokke | abhishekk: depends when they are ready, we're not even in RC1 yet so now is good time to get stuff fixed to avoid backports | 15:15 |
| abhishekk | hmm, so we can wait till today, if those get merged by tomorrow this time, we need to update release notes and then can tag the release | 15:16 |
| jokke | abhishekk: RC1 is next week, M-3 is just feature freeze | 15:17 |
| jokke | no need to have all bugfixes in this one | 15:18 |
| abhishekk | jokke, right | 15:18 |
| jokke | the whole point for having feature freeze is to get people focusing on bugfixes for few weeks to get stable release out ;) | 15:19 |
| abhishekk | :) | 15:20 |
| * abhishekk dinner break | 15:33 | |
| *** k_mouza has quit IRC | 15:39 | |
| *** k_mouza has joined #openstack-glance | 15:40 | |
| * abhishekk back from dinner break | 16:05 | |
| *** jawad_axd has quit IRC | 16:24 | |
| *** jawad_axd has joined #openstack-glance | 16:37 | |
| *** tonyb has quit IRC | 16:41 | |
| *** tonyb has joined #openstack-glance | 16:42 | |
| *** k_mouza has quit IRC | 16:48 | |
| *** johanssone_ has quit IRC | 16:59 | |
| *** tonyb has quit IRC | 17:01 | |
| *** johanssone has joined #openstack-glance | 17:03 | |
| openstackgerrit | Merged openstack/glance master: Victoria milestone 3 release notes https://review.opendev.org/749650 | 17:10 |
| *** jawad_axd has quit IRC | 17:15 | |
| *** ralonsoh has quit IRC | 17:26 | |
| *** ralonsoh has joined #openstack-glance | 17:58 | |
| *** jawad_axd has joined #openstack-glance | 18:00 | |
| *** jawad_axd has quit IRC | 18:15 | |
| openstackgerrit | Merged openstack/glance_store master: Update user/project referencing from context https://review.opendev.org/750131 | 18:16 |
| *** rosmaita has left #openstack-glance | 18:20 | |
| *** priteau has quit IRC | 19:12 | |
| *** jawad_axd has joined #openstack-glance | 19:19 | |
| *** ralonsoh has quit IRC | 19:20 | |
| *** ralonsoh has joined #openstack-glance | 19:21 | |
| *** ralonsoh has quit IRC | 19:28 | |
| *** jawad_axd has quit IRC | 20:06 | |
| *** whoami-rajat__ has quit IRC | 20:32 | |
| *** zzzeek has quit IRC | 21:05 | |
| *** zzzeek has joined #openstack-glance | 21:07 | |
| *** zzzeek has quit IRC | 21:22 | |
| *** zzzeek has joined #openstack-glance | 21:25 | |
| *** rcernin has joined #openstack-glance | 21:31 | |
| *** rcernin has quit IRC | 21:36 | |
| *** rcernin has joined #openstack-glance | 22:09 | |
| *** rcernin has quit IRC | 22:18 | |
| *** rcernin has joined #openstack-glance | 22:31 | |
| *** rcernin has quit IRC | 22:33 | |
| *** rcernin has joined #openstack-glance | 22:33 | |
| *** zzzeek has quit IRC | 22:38 | |
| *** zzzeek has joined #openstack-glance | 22:40 | |
| *** zzzeek has quit IRC | 22:58 | |
| *** zzzeek has joined #openstack-glance | 23:00 | |
| *** zzzeek has quit IRC | 23:17 | |
| *** zzzeek has joined #openstack-glance | 23:19 | |
| *** zzzeek has quit IRC | 23:43 | |
| *** zzzeek has joined #openstack-glance | 23:44 | |
| *** zzzeek has quit IRC | 23:49 | |
| *** zzzeek has joined #openstack-glance | 23:52 | |
| *** zzzeek has quit IRC | 23:57 | |
| *** zzzeek has joined #openstack-glance | 23:58 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!