*** zzzeek has quit IRC | 00:04 | |
*** zzzeek has joined #openstack-glance | 00:05 | |
*** baojg has joined #openstack-glance | 02:03 | |
*** rcernin has quit IRC | 02:21 | |
*** rcernin has joined #openstack-glance | 02:36 | |
*** rcernin has quit IRC | 02:45 | |
*** rcernin has joined #openstack-glance | 02:45 | |
*** rcernin has quit IRC | 04:00 | |
*** rcernin has joined #openstack-glance | 04:02 | |
*** rcernin has quit IRC | 04:27 | |
*** rcernin has joined #openstack-glance | 04:35 | |
*** udesale has joined #openstack-glance | 04:43 | |
*** ratailor has joined #openstack-glance | 05:15 | |
*** m75abrams has joined #openstack-glance | 05:46 | |
*** whoami-rajat__ has joined #openstack-glance | 05:51 | |
*** gmann has quit IRC | 06:45 | |
*** jungleboyj has quit IRC | 06:45 | |
*** jungleboyj has joined #openstack-glance | 06:46 | |
*** gmann has joined #openstack-glance | 06:47 | |
*** rcernin has quit IRC | 07:25 | |
*** ralonsoh has joined #openstack-glance | 07:26 | |
*** ratailor has quit IRC | 07:44 | |
*** rcernin has joined #openstack-glance | 08:07 | |
*** rcernin has quit IRC | 08:24 | |
*** rcernin has joined #openstack-glance | 08:26 | |
*** rcernin has quit IRC | 08:31 | |
*** rcernin has joined #openstack-glance | 08:37 | |
*** rcernin has quit IRC | 09:27 | |
*** benj_ has quit IRC | 09:28 | |
*** benj_ has joined #openstack-glance | 09:30 | |
*** rcernin has joined #openstack-glance | 09:39 | |
*** k_mouza has joined #openstack-glance | 09:53 | |
*** rcernin has quit IRC | 10:06 | |
*** ratailor has joined #openstack-glance | 10:08 | |
*** baojg has quit IRC | 10:09 | |
*** baojg has joined #openstack-glance | 10:10 | |
*** baojg has quit IRC | 10:10 | |
*** baojg has joined #openstack-glance | 10:10 | |
*** baojg has quit IRC | 10:11 | |
*** baojg has joined #openstack-glance | 10:11 | |
*** baojg has quit IRC | 10:11 | |
*** baojg has joined #openstack-glance | 10:12 | |
*** baojg has quit IRC | 10:12 | |
*** baojg has joined #openstack-glance | 10:13 | |
*** baojg has quit IRC | 10:13 | |
*** baojg has joined #openstack-glance | 10:13 | |
*** baojg has quit IRC | 10:14 | |
*** baojg has joined #openstack-glance | 10:14 | |
*** baojg has quit IRC | 10:15 | |
*** baojg has joined #openstack-glance | 10:15 | |
*** baojg has quit IRC | 10:15 | |
*** baojg has joined #openstack-glance | 10:16 | |
*** baojg has quit IRC | 10:16 | |
openstackgerrit | Stephen Finucane proposed openstack/glance master: Replace collections.Iterable https://review.opendev.org/c/openstack/glance/+/773357 | 10:59 |
---|---|---|
*** rcernin has joined #openstack-glance | 11:16 | |
*** rcernin has quit IRC | 12:33 | |
*** udesale_ has joined #openstack-glance | 12:36 | |
*** udesale has quit IRC | 12:38 | |
*** Luzi has joined #openstack-glance | 12:43 | |
*** rcernin has joined #openstack-glance | 12:47 | |
*** ratailor has quit IRC | 13:03 | |
*** ratailor_ has joined #openstack-glance | 13:03 | |
*** rcernin has quit IRC | 13:38 | |
*** ratailor_ has quit IRC | 13:54 | |
*** Luzi has quit IRC | 13:59 | |
abhishekk | dansmith, rosmaita, jokke, I will be mostly off today and tomorrow due to medical reason | 14:08 |
abhishekk | please send me mail if anything is urgent, thank you | 14:08 |
*** lbragstad has joined #openstack-glance | 14:09 | |
*** lbragstad has quit IRC | 14:16 | |
*** lbragstad has joined #openstack-glance | 14:22 | |
dansmith | abhishekk: can you add the +W here or are you waiting for more review? https://review.opendev.org/c/openstack/glance/+/771070/4 | 14:43 |
abhishekk | forgot that patch was rebased | 14:44 |
dansmith | okay, also rosmaita we have a +2 sandwich, you just need to bless this doc patch in the middle and that series will flush: https://review.opendev.org/c/openstack/glance/+/771249/6 | 14:45 |
openstackgerrit | Dan Smith proposed openstack/glance master: Enable second glance worker for import testing https://review.opendev.org/c/openstack/glance/+/770629 | 15:35 |
*** m75abrams has quit IRC | 16:12 | |
openstackgerrit | Merged openstack/glance master: Make os_glance namespace reserved https://review.opendev.org/c/openstack/glance/+/771070 | 16:19 |
dansmith | gmann: is copy_image missing from the example because it was missing from the json sample? https://review.opendev.org/c/openstack/glance/+/764074/10/glance/tests/etc/policy.yaml | 16:27 |
dansmith | if so, maybe we should include it there in the yaml version? | 16:27 |
gmann | dansmith: it should include as i converted from oslo tool so it should add all json file rule + remaining registered rule | 16:30 |
dansmith | gmann: okay, but... unless I'm blind, it's not there :) | 16:30 |
gmann | let me check | 16:30 |
gmann | with regenerate also | 16:31 |
*** udesale_ has quit IRC | 16:37 | |
gmann | dansmith: remember now after seeing this line - https://github.com/openstack/oslo.policy/blob/master/oslo_policy/generator.py#L428 | 16:56 |
dansmith | so it is because it's not in the json? | 16:57 |
gmann | with oslo convert tool, it only convert the rule exists in file to 1. comment out if rule is same as default 2. keep rest all same but do not add default in file if not there | 16:57 |
gmann | dansmith: yes | 16:57 |
dansmith | gotcha | 16:57 |
gmann | if you want to test with "" then i can add copy but i think it is better now as it test with actual defaults | 16:58 |
gmann | copy_image | 16:58 |
dansmith | gmann: so, I thought we were going to have the sample file be fully commented-out anyway? | 16:58 |
gmann | dansmith: yes | 16:59 |
dansmith | ohh, | 16:59 |
dansmith | this is the test's actual policy, not the sample | 16:59 |
dansmith | I see, nevermind :) | 16:59 |
gmann | yeah | 17:00 |
gmann | dansmith: i cannot find sample policy file in glance doc unless it is somewhere else - https://docs.openstack.org/glance/latest/configuration/index.html | 17:01 |
gmann | i think we should add that | 17:01 |
dansmith | gmann: ack | 17:01 |
dansmith | I just saw this and assumed it was the sample | 17:02 |
dansmith | ah I guess rosmaita is out today. maybe smcginnis could hit this doc patch for us? https://review.opendev.org/c/openstack/glance/+/771249/6 | 17:26 |
openstackgerrit | Erno Kuvaja proposed openstack/glance master: Add get_ksa_client() helper https://review.opendev.org/c/openstack/glance/+/770682 | 17:28 |
openstackgerrit | Erno Kuvaja proposed openstack/glance master: WIP: Distributed image import https://review.opendev.org/c/openstack/glance/+/769976 | 17:28 |
dansmith | jokke: I was hoping you would put that as a patch on top of mine, at least for initial review | 17:29 |
dansmith | especially because this seems to include a bunch of other unrelated gardening, like removing some of the staging store buildup | 17:33 |
jokke | dansmith: like said through the spec discussion, this approach does cleanup a lot | 17:41 |
jokke | which was the whole reason to push for it | 17:42 |
dansmith | jokke: the cleanups can be separate patches to distinguish them from the functional changes, but even still, if we're comparing two approaches (locations vs properties) it's much easier to see one on top of the other, without unrelated refactorings together | 17:42 |
dansmith | jokke: even if we squash the locations changes into this one in the end, I'd still like to review just the locations stuff | 17:43 |
dansmith | and that's what we discussed in the meeting | 17:43 |
jokke | dansmith: very easy on gerrit, just use PS9 (your last revision) as base you can flick between the full change using parent as base or ps9 base | 17:46 |
dansmith | I'm well aware that I can do that :) | 17:46 |
jokke | much easier to review the full change when you don't need to try to layer multiple different changes on top of each other hunting what is doing what | 17:47 |
jokke | ;) | 17:47 |
*** ralonsoh has quit IRC | 17:50 | |
*** rm_work has quit IRC | 18:10 | |
openstackgerrit | Ghanshyam proposed openstack/glance master: Add policy sample file in doc https://review.opendev.org/c/openstack/glance/+/773464 | 18:23 |
gmann | dansmith: ^^ | 18:23 |
*** rm_work has joined #openstack-glance | 18:23 | |
*** rm_work has quit IRC | 18:23 | |
*** rm_work has joined #openstack-glance | 18:25 | |
*** rm_work has joined #openstack-glance | 18:26 | |
*** rm_work has joined #openstack-glance | 18:27 | |
*** rm_work has quit IRC | 18:27 | |
dansmith | gmann: ++ | 18:28 |
*** rm_work has joined #openstack-glance | 18:28 | |
gmann | dansmith: we can also auto generate policy doc along with sample but that will be beneficial once glance policy convert form RuleDefault to DocumentedRuleDefault which has more info about rule | 18:32 |
*** rm_work has joined #openstack-glance | 18:32 | |
dansmith | gmann: isn't this going to generate a sample policy? or you mean auto-generate doc about the policy rules themselves? | 18:32 |
gmann | dansmith: yes rule themselves in policy.html like this - https://docs.openstack.org/nova/latest/configuration/policy.html | 18:33 |
dansmith | cool | 18:33 |
gmann | sample file it will generate | 18:33 |
gmann | it means 773464 | 18:34 |
dansmith | ack, cool | 18:34 |
*** rm_work has joined #openstack-glance | 18:39 | |
*** rm_work has joined #openstack-glance | 18:50 | |
*** k_mouza has quit IRC | 18:51 | |
*** k_mouza has joined #openstack-glance | 18:52 | |
*** k_mouza has joined #openstack-glance | 18:52 | |
*** k_mouza has quit IRC | 18:53 | |
*** k_mouza has joined #openstack-glance | 18:53 | |
*** rm_work has joined #openstack-glance | 18:54 | |
*** k_mouza has quit IRC | 18:58 | |
*** rm_work has joined #openstack-glance | 19:01 | |
*** rm_work has quit IRC | 19:01 | |
*** rm_work has joined #openstack-glance | 19:04 | |
*** rm_work has joined #openstack-glance | 19:15 | |
*** rm_work has quit IRC | 19:15 | |
*** rm_work has joined #openstack-glance | 19:22 | |
*** rm_work has quit IRC | 19:22 | |
*** knikolla_ has joined #openstack-glance | 20:18 | |
*** rm_work has joined #openstack-glance | 20:23 | |
*** knikolla has quit IRC | 20:26 | |
*** zigo has quit IRC | 20:26 | |
*** sorrison has quit IRC | 20:26 | |
*** knikolla_ is now known as knikolla | 20:26 | |
*** zigo has joined #openstack-glance | 20:32 | |
*** gyee has joined #openstack-glance | 21:16 | |
*** whoami-rajat__ has quit IRC | 21:57 | |
*** Underknowledge has joined #openstack-glance | 22:17 | |
*** rcernin has joined #openstack-glance | 22:20 | |
openstackgerrit | Lance Bragstad proposed openstack/python-glanceclient master: Implement support for system-scope arguments https://review.opendev.org/c/openstack/python-glanceclient/+/773532 | 22:21 |
*** Underknowledge has quit IRC | 22:47 | |
*** Underknowledge has joined #openstack-glance | 22:47 | |
jokke | dansmith: I think I figured it out! | 23:07 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!