Thursday, 2021-02-11

*** zzzeek has quit IRC00:01
*** zzzeek has joined #openstack-glance00:02
*** zzzeek has quit IRC02:20
*** zzzeek has joined #openstack-glance02:21
*** zzzeek has quit IRC03:02
*** zzzeek has joined #openstack-glance03:06
*** gyee has quit IRC03:33
*** ratailor has joined #openstack-glance04:20
*** zzzeek has quit IRC05:08
*** zzzeek has joined #openstack-glance05:09
*** udesale has joined #openstack-glance05:20
*** whoami-rajat__ has joined #openstack-glance06:03
*** m75abrams has joined #openstack-glance06:13
*** ralonsoh has joined #openstack-glance06:49
*** CeeMac has joined #openstack-glance07:07
openstackgerritRajat Dhasmana proposed openstack/glance_store master: Validate volume type during image creation  https://review.opendev.org/c/openstack/glance_store/+/77470309:15
*** ralonsoh has quit IRC09:34
*** ralonsoh has joined #openstack-glance09:34
*** udesale_ has joined #openstack-glance10:28
*** udesale has quit IRC10:29
felixhuettner[m]Hi everyone,10:38
felixhuettner[m]i have built a fix for glance deleting images that are still in use here: https://review.opendev.org/c/openstack/glance/+/77287210:38
felixhuettner[m]what would be the best way to proceed from here?10:38
*** admin0 has left #openstack-glance10:40
*** k_mouza has joined #openstack-glance10:53
jokkefelixhuettner[m]: let me have a look11:28
*** zzzeek has quit IRC11:28
*** zzzeek has joined #openstack-glance11:30
jokkefelixhuettner[m]: bug for that would be amazing to start with. Would be great to get that fixed in stable as well11:32
jokkerosmaita: do you remember wasn't the intention that deactivated image would not be user deletable for investigation?11:34
*** k_mouza has quit IRC11:49
*** k_mouza_ has joined #openstack-glance11:49
*** k_mouza_ has quit IRC12:03
*** k_mouza has joined #openstack-glance12:03
openstackgerritStephen Finucane proposed openstack/glance master: Uncap PrettyTable  https://review.opendev.org/c/openstack/glance/+/77514112:22
*** ratailor has quit IRC12:27
*** mgagne has quit IRC12:52
*** mgagne has joined #openstack-glance12:53
*** zzzeek has quit IRC13:07
*** zzzeek has joined #openstack-glance13:08
rosmaitajokke: see the discussion on https://bugs.launchpad.net/glance/+bug/1522524 and https://review.opendev.org/c/openstack/glance/+/25638113:14
openstackLaunchpad bug 1522524 in Glance "User can delete deactivated images" [Wishlist,In progress] - Assigned to Niall Bunting (niall-bunting)13:14
rosmaitajokke: also https://review.opendev.org/c/openstack/glance-specs/+/30101513:16
*** zzzeek has quit IRC13:21
*** zzzeek has joined #openstack-glance13:26
jokkerosmaita: thanks, I thought You might have better recall of this13:42
abhishekkjokke, rosmaita, smcginnis, dansmith weekly meeting in #openstack-meeting in 5 minutes13:53
*** stand has quit IRC13:54
*** m75abrams has quit IRC15:01
openstackgerritAbhishek Kekane proposed openstack/glance_store stable/victoria: Adjust requirements and lower-constraints  https://review.opendev.org/c/openstack/glance_store/+/77519015:38
-openstackstatus- NOTICE: Recent POST_FAILURE results from Zuul for builds started prior to 15:47 UTC were due to network connectivity issues reaching one of our log storage providers, and can be safely rechecked15:50
openstackgerritCyril Roelandt proposed openstack/glance master: Remove unused option "owner_is_tenant"  https://review.opendev.org/c/openstack/glance/+/76392015:53
*** k_mouza_ has joined #openstack-glance16:03
*** k_mouza has quit IRC16:05
*** gyee has joined #openstack-glance16:37
openstackgerritRajat Dhasmana proposed openstack/glance_store master: Validate volume type during image creation  https://review.opendev.org/c/openstack/glance_store/+/77470316:51
*** udesale_ has quit IRC17:47
openstackgerritDan Smith proposed openstack/glance master: DNM Test glance_store lazy volume type check  https://review.opendev.org/c/openstack/glance/+/77524617:53
dansmithwhoami-rajat__: this ^ should run glance's cinder job against your glance_store patch17:53
*** ralonsoh has quit IRC17:54
*** k_mouza_ has quit IRC18:05
lbragstadis anyone here familiar with the context behind https://docs.openstack.org/glance/latest/configuration/glance_api.html#DEFAULT.show_multiple_locations ?19:13
dansmithlbragstad: I assume you mean the context behind the warning and deprecation?19:18
lbragstadyeah - specifically "You cannot work around this option via policy configuration at the present time, though that is the direction we believe the fix will take. "19:18
dansmithyeah, unsure.. AFAIK, nova requires the ability to view the locations in order to do the right thing in a ceph environment, so I would assume there's some other details here19:19
lbragstadyeah - it seems so19:19
lbragstadi was digging around looking for where those policies are called19:19
dansmithand pretty sure nova uses the user's credentials for that, so can't really use a policy to get around showing it19:20
dansmithmy experience in glance has been that nearly everything is enforced at the lowest possible layers19:20
dansmithwhich I think you already know19:20
lbragstadyeah19:20
lbragstadi see those policies are called here - https://opendev.org/openstack/glance/src/branch/master/glance/api/policy.py#L17519:21
dansmiththat one specifically is different than *seeing* the locations I think19:21
lbragstadwhich kind of makes sense - make sure the user can set the location19:21
dansmithI think only nova or a turbo admin would be expected to set the location of an image, AFAIK19:22
dansmithnot anyone considered a "user" in the usual sense,19:22
dansmithalthough again, not sure how we let nova do that and not the user, so I'm sure I'm missing something19:22
lbragstadok - that makes sense19:22
lbragstadwell - can nova fetch an image using it's credentials?19:22
lbragstadits819:23
dansmithin nova, I think we do that when we do the snapshot directly in rbd and then just tell glance "oh by the way, here's the actual url to that thing"19:23
dansmithI think nova uses the user's credentials for that19:23
lbragstadah19:23
dansmithotherwise nova would agree to boot things you can't access19:23
dansmithor shouldn't be able to access rather19:23
lbragstadright19:24
lbragstadi could see where fetching an image that has locations set, as a normal end user would fail if the policy for get_image_location was restricted to administrators19:24
dansmithwell, AFAIK we should let them download the image if they can see it,19:25
dansmithbut being able to see the backend url (i.e. the location) is a very different thing19:25
lbragstadi can't really find anything that enforces the set_image_location policy, then except an error and scrub the locations from the image19:25
lbragstadyeah - exactly19:26
lbragstadi guess i'm wondering if chaining two different policy enforcement calls together in the same API, with conflicting check strings, is the reason for the "this won't work with policy overrides" comment19:26
dansmithyeah idk19:27
dansmithcould also be just that since they construct the api from the config,19:27
dansmiththey either include them or don't and policy won't let you enable that or not19:27
dansmiththere is a lot of config-driven api behavior in glance19:28
* lbragstad nods19:28
lbragstadi need to figure out how https://opendev.org/openstack/glance/src/branch/master/glance/api/policy.py#L274-L319 works depending on show_multiple_locations19:29
lbragstadbased on my extremely limited experience spelunking through glance, they seem to be solving similar issues19:30
dansmithoh right, some of this is enforced on layer 32F of "the onion".. I forgot about that19:31
lbragstadi mean - glance puts a direct_url in the image properties, too19:31
dansmithI think that's the same as the location, but when configured for only one backend19:32
dansmithbut could be wrong19:32
lbragstadyou're probably right, the images i'm looking at only have one backend19:32
dansmithyeah, it's "the best" of the location urls19:32
dansmithhttps://github.com/openstack/glance/blob/2c893fbd80d0241fad2515221b61266ced12f92d/glance/api/v2/images.py#L1360-L136919:33
lbragstadahh19:34
*** rchurch has quit IRC19:34
*** rchurch has joined #openstack-glance19:34
dansmithlbragstad: we have devstack knobs where you can get a multistore glance configured with ceph and file backends, if you want to poke19:38
lbragstadi should try that19:39
dansmithhttps://github.com/openstack/nova/blob/master/.zuul.yaml#L37019:39
lbragstadexcellent - thank you19:39
dansmithlbragstad: that job actually kinda does what you want,19:39
dansmithlbragstad: it uploads the cirros image to the file backend, and the first boot in nova makes nova copy the image to the rbd store, so it's in both places19:40
dansmithlbragstad: I would nuke the standalone=True in that devstack config btw19:40
dansmiththat's just for coverage, but complicates the setup a bit19:41
dansmithalso the whole import_conf part, again just for coverage and you don't need that extra layer either19:41
lbragstadsweet19:42
dansmithit also ups the debug level of oslo.policy because we had to figure out why that policy bit wasn't getting set, which you may also want :)19:43
* lbragstad spins up a new env19:45
dansmithlbragstad: are you asyncing your devstack yet?19:45
dansmithminimal config in five minutes for me :) https://review.opendev.org/c/openstack/devstack/+/77150519:45
lbragstadyeah - i plan to pull that down19:46
lbragstadi haven't redeployed since you posted that19:46
lbragstadbtw - thanks for all the work you've been doing to speed things up and starting the thread on openstack-discuss19:47
lbragstadi contribute minimally to projects like neutron, but i recently experienced the recheck pain and lag time19:48
dansmiththanks :)19:49
dansmithI really just want my patches to get test results faster, but glad it *looks* altruistic :P19:49
lbragstadspending half the week having a staring contest with zuul isn't exactly fun for anyone19:56
dansmithit's about my least favorite thing19:56
dansmithI run dash.py on a monitor above my normal ones and it's super depressing to see a stack of my own patches with no jobs running, which have been in the queue for four hours already19:56
* lbragstad nods19:58
lbragstaddansmith semi-related nova question - but the password associated to instance metadata is the password used to access the instance, if nova is configured to do so, right?20:14
dansmithyeah, but nowadays it requires something to process that, like cloud-init.. not sure if it does or not20:15
dansmithI always use ssh keys of course20:15
lbragstadhttps://opendev.org/openstack/nova/src/branch/master/nova/api/metadata/password.py#L8420:15
lbragstadok - interesting20:15
dansmithyeah, I think it's encrypted using the public part of the ssh host key, IIRC20:15
dansmithso that you can decrypt it inside the guest only with access to the private-to-system credentials20:16
lbragstadok - cool20:17
dansmithI haven't looked at that stuff since probably grizzly, so it could be quite different by now, not sure20:17
*** sangeet has joined #openstack-glance21:08
sangeetI have glance train deployed. I am not able to upload images bigger than 5GB via cli (--file option). I get " ERROR glance.common.wsgi Got error from Swift: put_object('glance', 'e7b58c3e-3894-46bb-b8a8-a3798ca6446c-00023', ...) failure and no ability to reset contents for reupload." Any suggestions21:09
openstackgerritLance Bragstad proposed openstack/glance master: trivial: Fix a typo in devstack plugin.sh  https://review.opendev.org/c/openstack/glance/+/77527621:09
*** rcernin has joined #openstack-glance21:20
sangeetPlease help ^^21:40
*** k_mouza has joined #openstack-glance21:51
*** k_mouza has quit IRC21:56
*** gmann is now known as gmann_afk22:10
lbragstaddansmith you're saying if i create an instance and then take a backup, nova should tell glance to put it in rbd even though the original image lives in the file backend?22:15
dansmithlbragstad: you mean snapshot not backup right?22:15
*** k_mouza has joined #openstack-glance22:15
dansmithlbragstad: if you have nova configured to use the same rbd pool as glance, nova should have asked glance to put it in rbd before it booted the instance22:16
dansmithif it didn't you might have caused nova to download an re-upload the image to rbd itself, which is pathologically bad behavior (and why we have a knob to disable that), but in that case, yes, nova will still snapshot in rbd and inform glance22:17
dansmithnever_download_image_if_on_rbd: True22:17
dansmiththis ^ should prevent nova from doing the stupid thing22:17
* lbragstad checks22:17
*** k_mouza has quit IRC22:22
lbragstadgah - glance isn't configured for multi-store because i misconfigured local.conf22:24
lbragstadnevermind - redeploying, and i'll try that all again...22:24
*** PrinzElvis has quit IRC22:41
*** PrinzElvis has joined #openstack-glance22:41
*** gmann_afk is now known as gmann23:11
openstackgerritLance Bragstad proposed openstack/glance master: WIP: Modify download_image policy to be read-only  https://review.opendev.org/c/openstack/glance/+/77529623:29
*** whoami-rajat__ has quit IRC23:43

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!