Tuesday, 2021-02-16

« Monday, 2021-02-15 Index Wednesday, 2021-02-17 »
*** rcernin has quit IRC02:31
*** k_mouza has joined #openstack-glance02:50
*** zzzeek has quit IRC02:53
*** k_mouza has quit IRC02:54
*** zzzeek has joined #openstack-glance02:55
*** rcernin has joined #openstack-glance03:23
*** rcernin has quit IRC03:28
*** rcernin has joined #openstack-glance03:28
lbragstadabhishekk i based the secure rbac series on top of dansmith's patch because his fix simplifies a bunch of testing for me04:39
abhishekklbragstad, ack04:39
lbragstadbut - the latest test run seems to be failing on owner_is_tenant logic i put in the sqlalchemy api layer04:39
abhishekkwill have a look04:40
lbragstadi'm about to push a two more patch that round out all the image testing, except copy-image04:41
lbragstadbut they might still fail without a rebase04:42
*** udesale has joined #openstack-glance04:54
*** ratailor has joined #openstack-glance04:58
abhishekklbragstad, ack05:01
*** m75abrams has joined #openstack-glance05:25
*** openstackgerrit has joined #openstack-glance05:52
openstackgerritLance Bragstad proposed openstack/glance master: Update logic to support secure RBAC for image membership  https://review.opendev.org/c/openstack/glance/+/77574105:52
openstackgerritLance Bragstad proposed openstack/glance-tempest-plugin master: Add tests for image membership, deactivation, and reactivation  https://review.opendev.org/c/openstack/glance-tempest-plugin/+/77574205:52
*** ianw has quit IRC06:18
*** ianw has joined #openstack-glance06:19
*** zzzeek has quit IRC06:26
*** zzzeek has joined #openstack-glance06:29
*** mugsie has quit IRC06:37
*** k_mouza has joined #openstack-glance06:50
*** k_mouza has quit IRC06:55
openstackgerritAbhishek Kekane proposed openstack/glance master: New API /v2/images/{id}/tasks  https://review.opendev.org/c/openstack/glance/+/77483007:04
openstackgerritAbhishek Kekane proposed openstack/glance master: Update API docs for new /v2/images/{image_id}/tasks API  https://review.opendev.org/c/openstack/glance/+/77559707:04
openstackgerritRajat Dhasmana proposed openstack/glance_store master: Validate volume type during volume create  https://review.opendev.org/c/openstack/glance_store/+/77470307:52
openstackgerritRajat Dhasmana proposed openstack/glance_store master: Validate volume type during volume create  https://review.opendev.org/c/openstack/glance_store/+/77470307:56
*** rcernin has quit IRC08:40
*** rcernin has joined #openstack-glance09:18
*** whoami-rajat__ has joined #openstack-glance09:25
openstackgerritRajat Dhasmana proposed openstack/glance master: Make glance cinder multistore job voting  https://review.opendev.org/c/openstack/glance/+/77577909:25
*** rcernin has quit IRC09:35
*** zzzeek has quit IRC09:53
*** zzzeek has joined #openstack-glance09:53
*** k_mouza has joined #openstack-glance11:00
*** mugsie has joined #openstack-glance11:13
*** udesale has quit IRC11:15
*** udesale_ has joined #openstack-glance11:15
*** ratailor has quit IRC12:20
*** Luzi has joined #openstack-glance12:55
*** rosmaita has left #openstack-glance12:56
*** rosmaita has joined #openstack-glance13:03
*** rcernin has joined #openstack-glance13:33
*** rcernin has quit IRC13:38
*** k_mouza has quit IRC13:39
*** k_mouza has joined #openstack-glance13:39
*** k_mouza_ has joined #openstack-glance13:49
*** k_mouza__ has joined #openstack-glance13:50
*** k_mouza_ has quit IRC13:50
*** k_mouza has quit IRC13:51
*** k_mouza__ has quit IRC13:53
*** k_mouza has joined #openstack-glance13:54
*** udesale__ has joined #openstack-glance13:56
abhishekklbragstad, do you have any input docs to run glance-tempest-plugin in local environment13:58
abhishekkalso, do you want me to work on copy-image tests?13:58
*** udesale_ has quit IRC13:59
*** Luzi has quit IRC14:27
lbragstadabhishekk i don't have any docs - but i can add some14:34
lbragstadthis is what i set in my local.conf14:34
abhishekklbragstad, ack14:35
lbragstadabhishekk http://paste.openstack.org/show/802688/14:35
lbragstadbut - dansmith pointed me to a useful nova job that sets up multiple backends - https://github.com/openstack/nova/blob/master/.zuul.yaml#L37014:36
lbragstadi was in the process of deploying that last week ^ because i wanted to use it to test the the image location policies14:36
lbragstadi think it might also be applicable to the copy image tests14:36
abhishekkright, for copy image we need multiple backends14:37
lbragstadcool14:37
openstackgerritDan Smith proposed openstack/glance-specs master: Distributed Image Import spec  https://review.opendev.org/c/openstack/glance-specs/+/77409714:38
lbragstadi think the only image policy that's not tested is copy_image, otherwise i think we still need tests for image location and metadef policies14:39
dansmithlbragstad: I added that policy and definitely wrote tests for it14:40
dansmithmaybe they're just different than the ones for the other things?14:40
lbragstadoh - awesome14:40
dansmithhttps://review.opendev.org/c/openstack/glance/+/73870314:41
abhishekklbragstad, I think we can deal with metadefs in X14:42
*** m75abrams has quit IRC14:42
abhishekkas we are in short in time, but I can give it a try to write those tests14:42
lbragstadok - so, assuming the image policies are reviewed and if we push the metadef policies to X, that will mean project-administrators are still technically allowed to do things with metadefs, right?14:45
lbragstadin wallaby14:45
abhishekktechnically yes14:46
lbragstadi'm not as familiar with the metadef API14:50
lbragstadif we update the policies to formally use project-admin, project-member, and project-reader, would that still be too much to get in for wallaby?14:50
abhishekklbragstad, I am afraid of getting them reviewed14:51
lbragstadand defer system-scope until X14:51
* lbragstad nods14:51
abhishekkwe are short on reviewers and till now you have realized it as well14:51
abhishekkdansmith, so I have question regarding your suggestion for new test (task show aapi)14:56
abhishekkSo if I created 3 tasks, 2 associated with values for new fields and one is without them then I will get only two tasks in response14:57
dansmithyup14:57
abhishekkok, let me see what I can do there14:58
dansmithabhishekk: the "old" tasks should not be shown in this api, but we should have some in the database to make sure they're not shown, and that none of the code around chokes in their presence14:59
dansmithit's easy to show that if you have new data and new code that things behave, but it's good to remember that everyone's database has old data in it today, so just be explicit in making sure that the old data won't cause an upgrade problem14:59
abhishekkAck15:00
dansmithabhishekk: sounds like we also got the ack from rosmaita on that task age handling, so we should be good to go here I think15:01
abhishekkdansmith, yes15:01
rosmaitadansmith: didn't have time to do a real review, but i think the direction is correct15:02
dansmithjust the validation of that extra age check is what we needed I think15:02
dansmithor what I wanted anyway :)15:02
openstackgerritLance Bragstad proposed openstack/glance-tempest-plugin master: Implement API protection testing for images  https://review.opendev.org/c/openstack/glance-tempest-plugin/+/77356815:28
openstackgerritLance Bragstad proposed openstack/glance-tempest-plugin master: Add tests for image membership, deactivation, and reactivation  https://review.opendev.org/c/openstack/glance-tempest-plugin/+/77574215:28
*** rcernin has joined #openstack-glance15:34
openstackgerritAbhishek Kekane proposed openstack/glance master: New API /v2/images/{id}/tasks  https://review.opendev.org/c/openstack/glance/+/77483015:34
openstackgerritAbhishek Kekane proposed openstack/glance master: Update API docs for new /v2/images/{image_id}/tasks API  https://review.opendev.org/c/openstack/glance/+/77559715:34
openstackgerritAbhishek Kekane proposed openstack/glance master: Bump Images API version to 2.12  https://review.opendev.org/c/openstack/glance/+/77586015:34
dansmithabhishekk: I'll update that tempest test for ^15:36
abhishekkdansmith, ack15:38
*** rcernin has quit IRC15:39
dansmithabhishekk: done, I think that will work16:11
openstackgerritMerged openstack/glance_store master: Validate volume type during volume create  https://review.opendev.org/c/openstack/glance_store/+/77470316:11
*** udesale_ has joined #openstack-glance16:24
*** udesale__ has quit IRC16:27
*** gyee has joined #openstack-glance16:27
abhishekkdansmith, ack16:27
*** udesale__ has joined #openstack-glance16:30
abhishekkdansmith, the request_id you are fetching here https://review.opendev.org/c/openstack/tempest/+/775679/2/tempest/api/image/v2/test_images.py#10516:30
abhishekkis it for the current request or it will be the one from where import request is raised or it will be same for both?16:30
abhishekkdansmith, ignore it16:31
dansmithabhishekk: it's the request_id glance returned from the import call16:31
dansmith?16:31
abhishekkyes, just spotted that, so said ignore it16:31
dansmithah, okay16:32
dansmiththought you were saying I should ignore the request_id :P16:32
*** udesale_ has quit IRC16:32
abhishekk:D16:34
*** udesale__ has quit IRC16:47
* abhishekk leaving for the day16:51
*** rcernin has joined #openstack-glance17:34
*** rcernin has quit IRC17:39
*** ralonsoh has quit IRC18:25
*** k_mouza has quit IRC18:28
*** whoami-rajat__ has quit IRC19:34
*** rcernin has joined #openstack-glance19:35
*** rcernin has quit IRC19:40
*** k_mouza has joined #openstack-glance20:29
*** k_mouza has quit IRC20:34
*** hoonetorg has quit IRC21:02
*** rcernin has joined #openstack-glance21:20
*** rcernin has quit IRC21:29
*** rcernin has joined #openstack-glance21:34
*** rcernin has quit IRC21:39
*** hoonetorg has joined #openstack-glance21:52
*** rcernin has joined #openstack-glance22:24
« Monday, 2021-02-15 Index Wednesday, 2021-02-17 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!