*** tosky has quit IRC | 00:10 | |
jokke | dansmith: dropped to -1 -(W) hopefully that works, if not we just need to throw the empty migration as follow up | 00:58 |
---|---|---|
jokke | world will not end to that missing ;) | 00:59 |
jokke | I think we miss the migration script about every cycle as they are under data_migrations vs. versions | 01:01 |
dansmith | anything that does not add up to "should merge" will make it not merge, so missing a +W is all that is needed | 01:07 |
jokke | kk | 01:08 |
jokke | now I don't need to remember un-2 it tomorrow :) | 01:08 |
jokke | I have a feeling that I've done this exactly sam thing before for same reason :D | 01:11 |
*** zzzeek has quit IRC | 01:15 | |
*** zzzeek has joined #openstack-glance | 01:17 | |
*** rcernin has quit IRC | 02:37 | |
openstackgerrit | Dan Smith proposed openstack/glance master: Add housekeeping module and staging cleaner https://review.opendev.org/c/openstack/glance/+/777012 | 03:06 |
openstackgerrit | Dan Smith proposed openstack/glance master: Test restarting glance for staging cleanup https://review.opendev.org/c/openstack/glance/+/777014 | 03:06 |
openstackgerrit | Dan Smith proposed openstack/glance master: Make functional tests set node_staging_uri https://review.opendev.org/c/openstack/glance/+/777277 | 03:06 |
*** rcernin has joined #openstack-glance | 04:44 | |
*** rcernin has quit IRC | 04:54 | |
*** rcernin has joined #openstack-glance | 04:55 | |
*** ratailor has joined #openstack-glance | 05:01 | |
*** rcernin has quit IRC | 05:14 | |
*** udesale has joined #openstack-glance | 05:21 | |
*** rcernin has joined #openstack-glance | 05:21 | |
openstackgerrit | Lance Bragstad proposed openstack/glance master: Implement project personas for image actions https://review.opendev.org/c/openstack/glance/+/764754 | 05:29 |
openstackgerrit | Lance Bragstad proposed openstack/glance-tempest-plugin master: Implement API protection testing for images https://review.opendev.org/c/openstack/glance-tempest-plugin/+/773568 | 05:30 |
lbragstad | abhishekk ok - that *should* be in good shape, i reworked everything to only include the project-member and project-reader personas | 05:31 |
abhishekk | lbragstad, ack | 05:31 |
abhishekk | lbragstad, so we need same for tasks and metadefs right? | 05:32 |
lbragstad | yeah | 05:32 |
abhishekk | ack | 05:32 |
lbragstad | but it should be less | 05:32 |
abhishekk | right | 05:32 |
lbragstad | https://review.opendev.org/c/openstack/glance/+/765210/13 might be worth abandoning | 05:32 |
abhishekk | yeah, we could revisit it in X | 05:33 |
abhishekk | I will try to work on tasks later today | 05:33 |
lbragstad | https://review.opendev.org/c/openstack/glance/+/775741 and https://review.opendev.org/c/openstack/glance-tempest-plugin/+/775742/3 should take care of the rest of the image API | 05:33 |
abhishekk | ack | 05:33 |
lbragstad | i plan on doing those tomorrow | 05:34 |
*** gyee has quit IRC | 05:34 | |
abhishekk | cool | 05:34 |
lbragstad | then it should just be tasks and metadata, right? | 05:34 |
abhishekk | yes | 05:34 |
lbragstad | ok | 05:34 |
abhishekk | thank you for your efforts (tireless) | 05:35 |
lbragstad | those patches i just pushed pass all tests for me locally and the new tests against gtp | 05:35 |
lbragstad | but - feel free to tweak or recheck if something breaks | 05:35 |
lbragstad | i wouldn't say tirelessly, because i'm going to go pass out :) | 05:35 |
lbragstad | thanks for all the reviews abhishekk | 05:35 |
abhishekk | ack, I will try some checks as well | 05:36 |
abhishekk | so last thing we need is to run gtp on glance jobs, am I right ? | 05:37 |
lbragstad | yeah - i think so | 05:37 |
abhishekk | ok, its late for you, good night | 05:38 |
lbragstad | or we cna enable a gtp job after we get the first patch into glance for the images api (and make it non-voting) | 05:38 |
lbragstad | but - that's up to you | 05:38 |
*** whoami-rajat has joined #openstack-glance | 05:41 | |
abhishekk | ack | 05:46 |
*** ricolin has quit IRC | 06:00 | |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Expand tasks database table to add more columns https://review.opendev.org/c/openstack/glance/+/763739 | 06:00 |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Extract req.context in a variable https://review.opendev.org/c/openstack/glance/+/775596 | 06:00 |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Utilize newly added tasks database fields https://review.opendev.org/c/openstack/glance/+/774615 | 06:00 |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: New API /v2/images/{id}/tasks https://review.opendev.org/c/openstack/glance/+/774830 | 06:00 |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Update API docs for new /v2/images/{image_id}/tasks API https://review.opendev.org/c/openstack/glance/+/775597 | 06:00 |
openstackgerrit | Abhishek Kekane proposed openstack/glance master: Bump Images API version to 2.12 https://review.opendev.org/c/openstack/glance/+/775860 | 06:00 |
*** m75abrams has joined #openstack-glance | 06:03 | |
*** ricolin has joined #openstack-glance | 06:28 | |
openstackgerrit | Merged openstack/glance master: Add basic/common personas to base policies https://review.opendev.org/c/openstack/glance/+/764241 | 07:05 |
dirtwash | abhishekk: u didnt have time to take a look at my xx bytes written out of issue right? | 07:27 |
dirtwash | wonder if something is just counted wrong | 07:27 |
dirtwash | but i cant imagine being the first to hit that issue, seems unlikely | 07:27 |
abhishekk | dirtwash, sorry, I tried, but not able to reproduce it locally | 07:27 |
dirtwash | d you think its a glance issue or ceph related somehow | 07:28 |
abhishekk | is it possible for you to add reproduce steps (what exactly you are doing step by step) to launchpad? | 07:29 |
abhishekk | I didn't see anything wrong in glance code yet | 07:29 |
dirtwash | literally just " create snapshot by any means, ui/cli" | 07:29 |
dirtwash | not many steps there | 07:29 |
abhishekk | you are using glanceclient ? | 07:29 |
dirtwash | tried with the normal openstack cli commands to make a new image and otherwies via webui "create image" | 07:30 |
dirtwash | so not sure glanceclient | 07:30 |
dirtwash | im not a openstack expert, new to it | 07:30 |
dirtwash | but it always fails, only thing that works is importing a new image to the rbd backend, there is no issue then | 07:31 |
abhishekk | could you do it with glance image-create ? | 07:32 |
dirtwash | yes I'll try now | 07:33 |
abhishekk | So please add both the CLI commands you are using | 07:33 |
abhishekk | 1 for creating snapshot | 07:33 |
abhishekk | 2 for importing new image | 07:33 |
dirtwash | hm online it says for snapshot to use 'nova image-create' | 07:34 |
dirtwash | tat it what i used last time | 07:35 |
*** rcernin has quit IRC | 07:39 | |
dirtwash | I can create images just fine, just not sure how to make a snapshot via cli, they all use nova in examples | 07:40 |
*** ralonsoh has joined #openstack-glance | 07:48 | |
abhishekk | dirtwash, nova image-create means you are trying to take snapshot of an instance | 08:05 |
abhishekk | I need to check that | 08:05 |
dirtwash | is it not the same? | 08:07 |
dirtwash | isnt it using glance to do this? | 08:07 |
* dirtwash is confused by openstack | 08:07 | |
abhishekk | AFAIK, nova image-create is used for taking snapshot of instance | 08:10 |
dirtwash | yea and that works | 08:12 |
dirtwash | not | 08:12 |
dirtwash | I meant, it brings the same error | 08:12 |
dirtwash | Im sure that is what te webgui does when I click 'create image' | 08:12 |
dirtwash | so nova imgage-create fails | 08:13 |
dirtwash | and glance logs that error as said | 08:13 |
*** rcernin has joined #openstack-glance | 08:15 | |
*** rcernin has quit IRC | 08:31 | |
*** rcernin has joined #openstack-glance | 08:33 | |
*** rcernin has quit IRC | 09:08 | |
*** hoonetorg has joined #openstack-glance | 09:16 | |
*** tosky has joined #openstack-glance | 09:18 | |
*** rcernin has joined #openstack-glance | 10:27 | |
dirtwash | abhishekk: the nova snapshot command doesnt trow an error, it says it made the image, but the image doesnt exist , it disappears after the error | 10:34 |
*** rcernin has quit IRC | 10:42 | |
*** k_mouza has joined #openstack-glance | 10:48 | |
*** rcernin has joined #openstack-glance | 10:52 | |
*** k_mouza has quit IRC | 10:55 | |
*** k_mouza has joined #openstack-glance | 10:56 | |
*** k_mouza_ has joined #openstack-glance | 11:03 | |
*** k_mouza has quit IRC | 11:06 | |
*** rcernin has quit IRC | 11:12 | |
*** udesale_ has joined #openstack-glance | 11:14 | |
*** udesale has quit IRC | 11:18 | |
*** k_mouza_ has quit IRC | 11:45 | |
*** k_mouza has joined #openstack-glance | 11:46 | |
*** ratailor has quit IRC | 12:07 | |
*** k_mouza has quit IRC | 12:08 | |
*** k_mouza has joined #openstack-glance | 12:21 | |
jokke | dirtwash: you need to look into your Nova logs, sounds like Nova is having issue and after that it cleans up after itself | 12:44 |
*** ajitha has joined #openstack-glance | 12:47 | |
dirtwash | jokke: nova says pipe error but i suspect because the rbd write failure happens in glance | 12:55 |
dirtwash | it cleans up because of that | 12:56 |
jokke | You're not using the same ceph for ephemeral, I take? | 12:57 |
dirtwash | we only use ceph rbd backend for images, not sure what you mean with ephemeral | 12:58 |
dirtwash | otherwise local disk on hypervisors | 12:58 |
jokke | yeah, that's what I meant, nova is not sharing that same ceph | 12:58 |
dirtwash | im confused | 13:00 |
dirtwash | but it is, there is only 1? | 13:00 |
dirtwash | and it worked before vitoria | 13:00 |
dirtwash | we didnt change anyting on ceph | 13:00 |
dirtwash | and it only affects snapshots | 13:00 |
jokke | Are you using multi-store config (do you configure the ceph store in it's own section in the gapi config or do you have the config just under ceph in the glance_store section? | 13:01 |
dirtwash | I didnt set this up but te glanci-api.conf has [rbd] mentionnig ceph stuff, glance_store only has default_backend=rbd | 13:04 |
jokke | ok | 13:04 |
dirtwash | jokke: [rbd] has like pool and user naname and conf location and chunk size, nothing else | 13:06 |
jokke | yep | 13:06 |
dirtwash | im totally new to openstack, someone else set this up, im just tryin to help with debug, i m the ceph admin | 13:07 |
jokke | I was just thinking if we have opportunity to test something, but we really don't with that configuration | 13:07 |
dirtwash | all I know is thatit worked before the upgrade | 13:08 |
jokke | yeah, only thing forward, I'd put Glance and Nova to debug logging and see if the logs reveals what and why is not being happy | 13:11 |
jokke | In glance point of view there is no difference between image and snapshot | 13:12 |
jokke | so creating snapshot is just like creating image, if either works on Glance both _should_ work | 13:12 |
openstackgerrit | Lance Bragstad proposed openstack/glance master: Implement project personas for image actions https://review.opendev.org/c/openstack/glance/+/764754 | 13:14 |
dirtwash | jokke: creating an image works fine, importing an image works fine, snashot doesnt, I alraedy set to debug, neither showed more info | 13:17 |
dirtwash | jokke: thats all the log I got https://bugs.launchpad.net/glance/+bug/1916482 | 13:18 |
openstack | Launchpad bug 1916482 in Glance "rbd.IncompleteWriteError: RBD incomplete write (Wrote only 8388608 out of 8394566 bytes) since Victoria Upgrade, ceph v nautilus" [Undecided,New] | 13:18 |
dirtwash | im happy to try something and paste u the logs | 13:18 |
*** k_mouza has quit IRC | 13:31 | |
*** k_mouza has joined #openstack-glance | 13:32 | |
jokke | yeah, I'm not sure what's going on there. Wondering if the very small size and the resizing is affecting that somehow | 13:32 |
jokke | have you tried if you get same error creating image with just few kilos of data? | 13:34 |
*** Luzi has joined #openstack-glance | 13:47 | |
openstackgerrit | Dan Smith proposed openstack/glance master: Test restarting glance for staging cleanup https://review.opendev.org/c/openstack/glance/+/777014 | 14:05 |
*** Luzi has quit IRC | 14:28 | |
dirtwash | jokke: i havent tried that, i know its creating size0 image for snapshot | 14:31 |
dirtwash | soi should make one thats just few kb big? | 14:31 |
jokke | dirtwash: I would try just using small amout of random data as image file and I think the snapshot rezise message in logs was very small | 14:36 |
dirtwash | 100K testfile maybe? | 14:38 |
dirtwash | or smaller | 14:38 |
dirtwash | so far making images from file worked | 14:40 |
dirtwash | worked fine for 100Kb | 14:41 |
*** Luzi has joined #openstack-glance | 14:43 | |
dansmith | I don't really know stuff about alembic, but what can we add to a job to verify that we have this empty migrate thing if/when we need it? Is there some db manage thing we can run in post that will fail to contract if we are missing it or something? | 15:12 |
dansmith | sounds like it's a bit of tribal knowledge at the moment, and we should really make the computers do our work for us | 15:12 |
dansmith | abhishekk: jokke rosmaita ^ | 15:12 |
*** lpetrut has joined #openstack-glance | 15:13 | |
rosmaita | yeah, i am actually not 100% clear on that | 15:14 |
rosmaita | our dev docs say we should do it | 15:14 |
abhishekk | there is db_check command for glance-manage but not sure it will help | 15:14 |
rosmaita | but it could just be for consistency | 15:14 |
dansmith | okay, if nothing breaks I'm not sure why it's important either :) | 15:14 |
rosmaita | well, there's "nothing breaks in devstack" vs "nothing breaks" | 15:15 |
dansmith | rosmaita: well, that's what I'm asking.. if something breaks not in devstack, we should make devstack or our jobs tickle whatever will break :) | 15:15 |
dansmith | maybe just a functional test to make sure we have a matching migrate for each version we have an expand for? | 15:15 |
rosmaita | that would be good | 15:16 |
rosmaita | "A given database change may not require actions in each of the expand, migrate, contract phases, but nonetheless, we require a script for each phase for every change. In the case where an action is not required, a no-op script, described below, MUST be used." | 15:16 |
rosmaita | https://docs.openstack.org/glance/latest/contributor/database_migrations.html | 15:16 |
rosmaita | but i don't recall if that's a shit can break MUST or a working in glance MUST | 15:17 |
dansmith | okay, so maybe just convention but nothing will actually break? | 15:17 |
dansmith | okay | 15:17 |
*** bhagyashris is now known as bhagyashri|ruck | 15:20 | |
rosmaita | yeah, it may be one of those nothing will break until it does | 15:20 |
*** abhishekk is now known as abhishekk|afk | 15:20 | |
rosmaita | and this is a belt-and-suspenders approach | 15:21 |
*** lpetrut has quit IRC | 15:24 | |
dansmith | rosmaita: the test I'm working on tells me that ocata doesn't have the migrate phase (which is true) | 15:37 |
dansmith | so (a) we need a test and (b) I imagine we would have heard about a problem by now if there was one :) | 15:37 |
rosmaita | i think ocata was community images, there should be a real migrate phase | 15:38 |
dansmith | the only ocata files are: | 15:39 |
dansmith | -rw-rw-r-- 1 dan dan 2.3K Aug 17 2020 ocata_contract01_drop_is_public.py | 15:39 |
dansmith | -rw-rw-r-- 1 dan dan 5.7K Aug 17 2020 ocata_expand01_add_visibility.py | 15:39 |
rosmaita | need to look in /glance/db/sqlalchemy/alembic_migrations/data_migrations/ | 15:39 |
rosmaita | don't ask me why, there was a good reason, but i don't remember | 15:39 |
dansmith | those should be different than schema migrations right? | 15:41 |
rosmaita | yeah, those are the actual data migrations | 15:41 |
rosmaita | the schema changes are expand and contract | 15:42 |
dansmith | ah, so all the migrates should be in the data_migrations directory and expand/contract in versions? | 15:42 |
dansmith | I see, that looks like how it is | 15:42 |
rosmaita | yeah | 15:42 |
*** abhishekk|afk is now known as abhishekk | 15:47 | |
openstackgerrit | Dan Smith proposed openstack/glance master: Add a test for migration naming and phase rules https://review.opendev.org/c/openstack/glance/+/777413 | 15:52 |
dansmith | rosmaita: how's that ^ ? | 15:52 |
dansmith | we have a lot of these "developer trap" tests in nova which helps people submit patches with these sorts of things already sorted, and avoids every core having to remember these kinds of mechanical rules | 15:53 |
rosmaita | great idea, will look at the patch | 15:55 |
rosmaita | while you are thinking about this ... i think our code will break when openstack goes from 'zoo' to 'aardvark' release | 15:57 |
dansmith | do we have some release[0] ordering somewhere? | 15:57 |
*** m75abrams has quit IRC | 15:57 | |
rosmaita | pretty sure it's assumed in the migration code somewhere | 15:58 |
dansmith | okay I thought the whole point of alembic was to avoid things like migration numbers | 15:58 |
dansmith | but like I said, I'm alembic stupid | 15:58 |
rosmaita | yeah, i think this is a glance-imposed restriction when it orders the files to apply | 15:59 |
dansmith | huh, okay | 15:59 |
dansmith | I've looked briefly at neutron things and they have uuids for some of that, but I guess I thought alembic looks at the "down_revision" or "parent" or something to construct the ordering | 16:00 |
rosmaita | looking at your test, i think we ran into a problem with mitaka and that's why the naming convention and all-3-files inclusion was introduced | 16:02 |
dansmith | ack, I figured something like that | 16:03 |
tosky | while you discuss this, may I ask for a review on this zuul stable/train backport (legacy->native job)? https://review.opendev.org/c/openstack/glance_store/+/749235 | 16:05 |
rosmaita | tosky: you are so polite, how can we refuse? | 16:05 |
*** k_mouza_ has joined #openstack-glance | 16:14 | |
dansmith | abhishekk: just checking, but did you notice that housekeeping patch has a test cleanup below it? | 16:15 |
tosky | ehm :) | 16:16 |
tosky | dansmith: thanks, answered :) | 16:16 |
dansmith | tosky: just checking to make sure you're paying attention :P | 16:17 |
dansmith | I don't have +2 on stable so I can't help you further | 16:17 |
*** k_mouza has quit IRC | 16:17 | |
*** gyee has joined #openstack-glance | 16:41 | |
tosky | rosmaita: aaand thanks! | 16:43 |
rosmaita | yw | 16:44 |
*** udesale_ has quit IRC | 16:54 | |
abhishekk | dansmith, yes, I noticed | 16:55 |
abhishekk | just waiting for gate results | 16:55 |
dansmith | oh, gate reported last night, but that's cool, I just slipped that in since you looked yesterday so wasn't sure if you noticed | 16:56 |
abhishekk | yep, you have changed to use glanceclient from openstackclient | 16:59 |
abhishekk | and that's why waiting to make sure it passes again | 17:00 |
dansmith | abhishekk: ah, no I mean the patch underneath | 17:00 |
dansmith | the one on the top is probably just DNM | 17:00 |
abhishekk | ohh, that one | 17:01 |
abhishekk | can we have related bug tag in commit, so if we decided to backport it? | 17:02 |
openstackgerrit | Lance Bragstad proposed openstack/glance master: Implement project personas for image actions https://review.opendev.org/c/openstack/glance/+/764754 | 17:03 |
openstackgerrit | Lance Bragstad proposed openstack/glance-tempest-plugin master: Add tests for image membership, deactivation, and reactivation https://review.opendev.org/c/openstack/glance-tempest-plugin/+/775742 | 17:03 |
abhishekk | lbragstad, you can abandon other patches which are not required now | 17:04 |
lbragstad | sure | 17:05 |
lbragstad | so - from what i can tell, https://review.opendev.org/c/openstack/glance/+/764754/14 implements project-reader and project-member for all image APIs | 17:07 |
lbragstad | i obviously left the project-admin stuff alone | 17:07 |
abhishekk | ack | 17:10 |
abhishekk | project-admin is == current rule:admin ? | 17:10 |
*** k_mouza_ has quit IRC | 17:14 | |
*** k_mouza has joined #openstack-glance | 17:14 | |
lbragstad | abhishekk yeah | 17:24 |
lbragstad | technically - rule:admin works for system-admin, too | 17:25 |
abhishekk | makes sense | 17:25 |
dansmith | abhishekk: sorry, call.. sure, I'll tag it | 17:31 |
abhishekk | dansmith, no problem | 17:31 |
openstackgerrit | Dan Smith proposed openstack/glance master: Make functional tests set node_staging_uri https://review.opendev.org/c/openstack/glance/+/777277 | 17:32 |
openstackgerrit | Dan Smith proposed openstack/glance master: Add housekeeping module and staging cleaner https://review.opendev.org/c/openstack/glance/+/777012 | 17:32 |
openstackgerrit | Dan Smith proposed openstack/glance master: MDNM: Test restarting glance for staging cleanup https://review.opendev.org/c/openstack/glance/+/777014 | 17:33 |
dansmith | abhishekk: marked my intentions to probably not merge the top patch, unless we change our mind ^ | 17:33 |
abhishekk | dansmith, ack, I guess we should avoid the post checking (as after successful run if something went wrong then we need to run it again) | 17:34 |
dansmith | well, this post check doesn't actually check anything, it just does some setup and restarts the service.. you have to look at the log file to see the behavior anyway | 17:35 |
dansmith | I just wanted some way to demonstrate that it was working for all three cases in reality, | 17:35 |
dansmith | but once I was able to restart the functional worker without destroying the database, that need was solved there | 17:36 |
dansmith | s/was able/figured out how to/ | 17:36 |
abhishekk | ack | 17:40 |
* abhishekk signing off for the day | 17:41 | |
openstackgerrit | Merged openstack/glance_store stable/train: zuul: glance_store-src-ceph-tempest replaces a legacy job https://review.opendev.org/c/openstack/glance_store/+/749235 | 17:43 |
*** Luzi has quit IRC | 17:56 | |
*** ralonsoh has quit IRC | 18:00 | |
*** k_mouza has quit IRC | 19:00 | |
*** gregwork has joined #openstack-glance | 19:06 | |
*** rcernin has joined #openstack-glance | 19:10 | |
*** rcernin has quit IRC | 19:15 | |
*** k_mouza has joined #openstack-glance | 20:14 | |
*** k_mouza has quit IRC | 20:19 | |
*** rcernin has joined #openstack-glance | 20:33 | |
*** zzzeek has quit IRC | 20:34 | |
*** zzzeek has joined #openstack-glance | 20:34 | |
*** rcernin has quit IRC | 20:47 | |
*** jdillaman has joined #openstack-glance | 21:04 | |
*** whoami-rajat has quit IRC | 21:12 | |
*** rcernin has joined #openstack-glance | 21:14 | |
*** rcernin has quit IRC | 21:19 | |
*** zzzeek has quit IRC | 21:26 | |
*** zzzeek has joined #openstack-glance | 21:28 | |
*** rcernin has joined #openstack-glance | 21:32 | |
lbragstad | random question - is it possible for metadef sub-objects to have different owners than the namespace? | 21:34 |
*** rcernin has quit IRC | 21:37 | |
*** rcernin has joined #openstack-glance | 21:40 | |
*** rcernin has quit IRC | 21:45 | |
*** rcernin has joined #openstack-glance | 21:46 | |
*** zzzeek has quit IRC | 21:49 | |
*** rcernin has quit IRC | 21:51 | |
*** zzzeek has joined #openstack-glance | 21:53 | |
*** rcernin has joined #openstack-glance | 22:15 | |
*** zzzeek has quit IRC | 23:14 | |
*** zzzeek has joined #openstack-glance | 23:15 | |
*** ajitha has quit IRC | 23:26 | |
*** jv_ has quit IRC | 23:55 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!