Monday, 2021-06-14

*** bhagyashris__ <bhagyashris__!~bhagyashr@103.98.79.86> has joined #openstack-glance01:51
*** bhagyashris_ <bhagyashris_!~bhagyashr@103.98.79.86> has quit IRC (Ping timeout: 480 seconds)01:58
*** priteau <priteau!~priteau@93.186.40.84> has quit IRC (Ping timeout: 480 seconds)02:04
*** priteau <priteau!~priteau@93.186.40.84> has joined #openstack-glance02:06
*** abhishekk <abhishekk!~akekane@116.74.162.143> has joined #openstack-glance05:18
*** ratailor_ <ratailor_!~ratailor@103.115.207.241> has joined #openstack-glance05:43
*** ratailor_ is now known as ratailor05:48
*** icey <icey!~icey@0001bbad.user.oftc.net> has quit IRC ()06:18
*** icey <icey!~icey@0001bbad.user.oftc.net> has joined #openstack-glance06:18
*** bhagyashris__ is now known as bhagyashris06:36
*** pdeore <pdeore!~pdeore@2401:4900:1b82:1ebf:7a02:6805:1a5c:6475> has joined #openstack-glance06:47
*** tkajinam <tkajinam!~tkajinam@240d:1a:6af:1b00:3462:14d1:c5f6:8946> has quit IRC (Quit: Leaving)07:16
*** tkajinam <tkajinam!~tkajinam@240d:1a:6af:1b00:3462:14d1:c5f6:8946> has joined #openstack-glance07:17
*** tosky <tosky!~luigi@dynamic-adsl-78-13-253-141.clienti.tiscali.it> has joined #openstack-glance07:45
*** CeeMac <CeeMac!uid366483@id-366483.brockwell.irccloud.com> has joined #openstack-glance08:05
*** whoami-rajat <whoami-rajat!uid314320@id-314320.brockwell.irccloud.com> has joined #openstack-glance08:14
*** abhishekk <abhishekk!~akekane@116.74.162.143> has quit IRC (Quit: Bye...)09:19
*** Luzi <Luzi!~Luzi@ipservice-092-208-056-099.092.208.pools.vodafone-ip.de> has joined #openstack-glance09:47
*** ratailor_ <ratailor_!~ratailor@2409:4052:2204:5df:d46:7ddd:22bd:3dc0> has joined #openstack-glance10:40
*** ratailor_ <ratailor_!~ratailor@2409:4052:2204:5df:d46:7ddd:22bd:3dc0> has quit IRC (Remote host closed the connection)10:40
*** ratailor_ <ratailor_!~ratailor@103.115.207.228> has joined #openstack-glance10:46
*** ratailor <ratailor!~ratailor@103.115.207.241> has quit IRC (Ping timeout: 480 seconds)10:46
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has quit IRC (Remote host closed the connection)11:27
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has joined #openstack-glance11:37
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has quit IRC (Quit: leaving)11:43
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has joined #openstack-glance11:43
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has quit IRC ()11:45
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has joined #openstack-glance11:46
*** rosmaita <rosmaita!~rosmaita@2601:5c0:c380:b8e0::3397> has joined #openstack-glance12:09
*** ratailor_ <ratailor_!~ratailor@103.115.207.228> has quit IRC (Quit: Leaving)12:46
*** abhishekk <abhishekk!~akekane@116.74.162.143> has joined #openstack-glance13:37
*** abhishekk is now known as akekane|home13:37
*** akekane|home is now known as abhishekk13:37
abhishekkdansmith, o/, around13:58
dansmithabhishekk: yep13:58
abhishekkgood morning!!13:59
abhishekkwhat will be the good time to sync on policy refactoring13:59
abhishekk(will be better if it is tomorrow)14:00
dansmithtomorrow is probably okay, tuesdays are busy for me.. this hour tomorrow should be okay though14:01
*** Luzi <Luzi!~Luzi@ipservice-092-208-056-099.092.208.pools.vodafone-ip.de> has quit IRC (Quit: Leaving)14:01
dansmithI pushed up some more very WIP code on friday just to get it out there14:01
dansmithand I have some notes I can go over with you14:02
abhishekkack14:02
dansmithI think the default rules we merged last cycle for "experimental" RBAC support are not right14:02
abhishekkohh14:03
dansmiththey might be right enough considering our otherwise loose model, I'm not sure, but they're definitely not right from the perspective of making sense, nor for what we need them to be for this refactor effort14:03
dansmithanyway, I'll get those cleaned up and we can discuss tomorrow14:03
dansmithI wish lance was here, but...alas14:04
abhishekkyes14:04
abhishekkalso, I want to ask one thing about quotas documentation14:04
abhishekkshould we also explain parameters needs to set under oslo_limit?14:05
*** pdeore <pdeore!~pdeore@2401:4900:1b82:1ebf:7a02:6805:1a5c:6475> has quit IRC (Ping timeout: 480 seconds)14:06
dansmiththe config parameters?14:06
abhishekkyeah14:07
abhishekkas per documentation if you just enable by turning on use_keystone_limits to True14:07
dansmithhttps://docs.openstack.org/oslo.limit/latest/user/usage.html#configuration14:07
dansmithbut I can link to this ^ in the docs, sure14:07
abhishekkthen while creating image it ruturns 500 error with something containing oslo_limit auth_plugin requires14:08
dansmithI think it's similar config to anything that uses ks_client, you just have to know to put that in [oslo_limit] as well as somethign else14:08
dansmithah, okay, what does it raise? we can catch and log that with a helpful message14:09
abhishekkyep, I think better to add a one line with above link14:09
abhishekkgive me a minute14:09
abhishekkJun 14 14:10:38 akekane-wallaby-dev devstack@g-api.service[1874771]: ERROR glance.common.wsgi oslo_limit.exception.SessionInitError: Can't initialise OpenStackSDK session: An auth plugin is required to determine endpoint URL.14:11
abhishekkJun 14 14:10:38 akekane-wallaby-dev devstack@g-api.service[1874771]: ERROR glance.common.wsgi   File "/opt/stack/glance/glance/quota/keystone.py", line 55, in _enforce_some14:12
dansmithokay, will add something for that14:13
abhishekkack14:14
dansmithyou know, reading this oslo.limit doc, I think lance and I identified a bug in what is prescribed here, which I totally forgot about14:18
dansmithso I will make our docs look like what devstack uses (which works)14:19
dansmithand I need to circle back with him afterwards14:19
abhishekk:D14:19
abhishekkBetter to file a bug then, otherwise ...14:20
dansmithyep, done14:25
dansmithhttps://bugs.launchpad.net/oslo.limit/+bug/193187514:25
abhishekkgreat14:26
abhishekktomorrow 1400 UTC confirm then14:28
dansmithsounds good14:32
abhishekkcool, thank you14:33
opendevreviewDan Smith proposed openstack/glance master: Add unified quotas infrastructure  https://review.opendev.org/c/openstack/glance/+/78805414:41
opendevreviewDan Smith proposed openstack/glance master: Enforce keystone limits for image upload  https://review.opendev.org/c/openstack/glance/+/78805514:41
opendevreviewDan Smith proposed openstack/glance master: Add user_get_staging_usage() to DB API  https://review.opendev.org/c/openstack/glance/+/78807614:41
opendevreviewDan Smith proposed openstack/glance master: Add image_stage_total quota enforcement  https://review.opendev.org/c/openstack/glance/+/78807714:41
opendevreviewDan Smith proposed openstack/glance master: Add user_get_image_count() to DB API  https://review.opendev.org/c/openstack/glance/+/78832614:41
opendevreviewDan Smith proposed openstack/glance master: Add image_count_total quota enforcement  https://review.opendev.org/c/openstack/glance/+/78832714:41
opendevreviewDan Smith proposed openstack/glance master: Add image_count_uploading quota enforcement  https://review.opendev.org/c/openstack/glance/+/79424714:41
opendevreviewDan Smith proposed openstack/glance master: Add unified quotas documentation  https://review.opendev.org/c/openstack/glance/+/79467214:41
opendevreviewDan Smith proposed openstack/glance master: ULTRAWIP: Example usage API  https://review.opendev.org/c/openstack/glance/+/79486014:41
dansmithabhishekk: doc add and SessionInitError handling ^14:41
abhishekkdansmith, ack, looking14:41
abhishekkone mistake 14:43
dansmithWAT14:43
abhishekkcommented14:44
abhishekkDoc looks perfect now, thank you14:46
dansmithah, dang, that was a rebase conflict14:46
dansmithfixed, thanks14:47
opendevreviewDan Smith proposed openstack/glance master: Add unified quotas infrastructure  https://review.opendev.org/c/openstack/glance/+/78805414:47
opendevreviewDan Smith proposed openstack/glance master: Enforce keystone limits for image upload  https://review.opendev.org/c/openstack/glance/+/78805514:47
opendevreviewDan Smith proposed openstack/glance master: Add user_get_staging_usage() to DB API  https://review.opendev.org/c/openstack/glance/+/78807614:47
opendevreviewDan Smith proposed openstack/glance master: Add image_stage_total quota enforcement  https://review.opendev.org/c/openstack/glance/+/78807714:47
opendevreviewDan Smith proposed openstack/glance master: Add user_get_image_count() to DB API  https://review.opendev.org/c/openstack/glance/+/78832614:47
opendevreviewDan Smith proposed openstack/glance master: Add image_count_total quota enforcement  https://review.opendev.org/c/openstack/glance/+/78832714:47
opendevreviewDan Smith proposed openstack/glance master: Add image_count_uploading quota enforcement  https://review.opendev.org/c/openstack/glance/+/79424714:47
opendevreviewDan Smith proposed openstack/glance master: Add unified quotas documentation  https://review.opendev.org/c/openstack/glance/+/79467214:47
opendevreviewDan Smith proposed openstack/glance master: ULTRAWIP: Example usage API  https://review.opendev.org/c/openstack/glance/+/79486014:47
abhishekkyou work really fast, may be faster than light 14:48
abhishekk:D14:48
dansmithalways under the speed limit.. it's the law ;)14:48
abhishekkhaha14:48
abhishekkI think some thing is wrong with rebasing14:51
abhishekkhttps://review.opendev.org/c/openstack/glance/+/794245/414:51
abhishekkthis patch is on top of ULTRAWIP patch14:52
dansmithhmm, it looks correct locally14:52
dansmithoh wait, maybe not14:53
abhishekkalso it doesn't shown in above bot updates14:53
dansmithyeah, hmm14:53
dansmithI think it's right locally, I'm forcing an update, we'll see if that helps14:57
abhishekkack14:58
opendevreviewDan Smith proposed openstack/glance master: Refactor SynchronousAPIBase for more cases  https://review.opendev.org/c/openstack/glance/+/78806514:58
opendevreviewDan Smith proposed openstack/glance master: Update image.size after conversion  https://review.opendev.org/c/openstack/glance/+/78809114:58
opendevreviewDan Smith proposed openstack/glance master: Make image stage set image.size  https://review.opendev.org/c/openstack/glance/+/78807514:58
opendevreviewDan Smith proposed openstack/glance master: Drop lower-constraints jobs  https://review.opendev.org/c/openstack/glance/+/78276814:58
opendevreviewDan Smith proposed openstack/glance master: Add unified quotas infrastructure  https://review.opendev.org/c/openstack/glance/+/78805414:58
opendevreviewDan Smith proposed openstack/glance master: Enforce keystone limits for image upload  https://review.opendev.org/c/openstack/glance/+/78805514:58
opendevreviewDan Smith proposed openstack/glance master: Add user_get_staging_usage() to DB API  https://review.opendev.org/c/openstack/glance/+/78807614:58
opendevreviewDan Smith proposed openstack/glance master: Add image_stage_total quota enforcement  https://review.opendev.org/c/openstack/glance/+/78807714:58
opendevreviewDan Smith proposed openstack/glance master: Add user_get_image_count() to DB API  https://review.opendev.org/c/openstack/glance/+/78832614:58
opendevreviewDan Smith proposed openstack/glance master: Add image_count_total quota enforcement  https://review.opendev.org/c/openstack/glance/+/78832714:58
opendevreviewDan Smith proposed openstack/glance master: Add image_count_uploading quota enforcement  https://review.opendev.org/c/openstack/glance/+/79424714:58
opendevreviewDan Smith proposed openstack/glance master: Add unified quotas documentation  https://review.opendev.org/c/openstack/glance/+/79467214:58
opendevreviewDan Smith proposed openstack/glance master: ULTRAWIP: Example usage API  https://review.opendev.org/c/openstack/glance/+/79486014:58
dansmithokay, looks right all the way down from here right? https://review.opendev.org/c/openstack/glance/+/794860/914:59
abhishekklooking15:00
abhishekkyeah15:00
dansmithI blame gerrit.. all I did was tweak the bottom patch and force a rebase in git-review15:00
abhishekkbut you go to first patch in the chain then its blown up15:02
abhishekkthat is refactor synchronous patch15:02
dansmiththis looks right to me: https://review.opendev.org/c/openstack/glance/+/788065/815:02
dansmithdoes it not to you?15:02
dansmithoh, maybe the get_uploading_count patch got kicked out?15:03
abhishekkyeah15:03
abhishekkI see user_get_uploading_count on top of ultrawip patch15:04
dansmithit's not really, it's just gerrit showing you that because it's an ancestor15:04
dansmithit's not in my stack locally, so that's the problem It hink15:04
abhishekkhmm, and if we see from top, https://review.opendev.org/c/openstack/glance/+/794860/9 then I don't see user_get_uploading_count patch in tree15:05
dansmithright15:06
dansmithI'll stitch it back together, just a sec15:06
abhishekkack15:06
dansmithman, this was seriously messed up15:19
dansmiththat patch got squashed into the one above it, but with no squashed commit message15:19
abhishekkohh15:24
dansmithlet's try this again15:24
opendevreviewDan Smith proposed openstack/glance master: Add image_count_total quota enforcement  https://review.opendev.org/c/openstack/glance/+/78832715:24
opendevreviewDan Smith proposed openstack/glance master: Add user_get_uploading_count() to DB API  https://review.opendev.org/c/openstack/glance/+/79424515:24
opendevreviewDan Smith proposed openstack/glance master: Add image_count_uploading quota enforcement  https://review.opendev.org/c/openstack/glance/+/79424715:24
opendevreviewDan Smith proposed openstack/glance master: Add unified quotas documentation  https://review.opendev.org/c/openstack/glance/+/79467215:24
opendevreviewDan Smith proposed openstack/glance master: ULTRAWIP: Example usage API  https://review.opendev.org/c/openstack/glance/+/79486015:24
abhishekkNow its in right order15:26
dansmithyeah, I dunno what happened there, but thanks for noticing15:30
abhishekkno worries, its good to sorted out in time 15:34
* abhishekk going out for dinner break15:34
abhishekkrosmaita, if you around have some time, then quotas patches are in good shape now15:35
rosmaitaabhishekk: ack15:39
opendevreviewMerged openstack/glance master: Allow member creation when using db.simple api  https://review.opendev.org/c/openstack/glance/+/36635415:41

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!