| opendevreview | Xinxin Shen proposed openstack/glance_store master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/glance_store/+/789762 | 00:29 |
|---|---|---|
| opendevreview | Merged openstack/glance master: Refactor SynchronousAPIBase for more cases https://review.opendev.org/c/openstack/glance/+/788065 | 03:04 |
| *** bhagyashris_ is now known as bhagyashris | 05:13 | |
| opendevreview | Merged openstack/glance master: Update image.size after conversion https://review.opendev.org/c/openstack/glance/+/788091 | 09:34 |
| *** bhagyashris_ is now known as bhagyashris | 09:48 | |
| -opendevstatus- NOTICE: Our Zuul gating CI/CD services will be offline starting around 14:00 UTC (in roughly two hours from now) in order to apply some critical security updates, and is not expected to remain offline for more than 30 minutes. | 12:01 | |
| opendevreview | Merged openstack/glance_store master: Allow any Keystone domain for cinder store https://review.opendev.org/c/openstack/glance_store/+/793826 | 13:22 |
| abhishekk | dansmith, do you have specific direction for policy tests refactoring? | 13:24 |
| abhishekk | I would like to start the work | 13:25 |
| dansmith | sorry, I never commented on your spec lite | 13:26 |
| dansmith | the specific direction is what I have been doing -- we could refactor all the tests to use the current defaults, but then we have to re-refactor them for the new changes we're making | 13:26 |
| dansmith | so I've been taking the approach of converting one policy check at a time, along with setting policy.yaml to equal the default, and fixing the tests as needed | 13:27 |
| abhishekk | okk | 13:28 |
| abhishekk | So I how could I assist in your work | 13:28 |
| dansmith | well, like I said before, it's tough because everything is so interdependent :/ | 13:29 |
| dansmith | however, | 13:29 |
| dansmith | I'm disappearing later today and gone tomorrow, so if you want to work on stuff on top of what I have, now is a good time | 13:29 |
| dansmith | pick another policy check that makes sense to do next and go for it | 13:29 |
| abhishekk | ack | 13:29 |
| dansmith | I have largely avoided writing tests to fill the gaps in my WIP patches, so I can probably spend a good amount of time next week working on that, without altering the surface of what you're trying to work on | 13:30 |
| abhishekk | I will try to go for delete check | 13:30 |
| dansmith | cool, sounds good | 13:30 |
| abhishekk | great | 13:30 |
| abhishekk | thank you and have a good time off | 13:31 |
| dansmith | thanks | 13:31 |
| abhishekk | rosmaita, jokke_, dansmith, smcginnis, weekly meeting in 5 minutes at #openstack-meeting | 13:53 |
| rosmaita | abhishekk: ack | 13:54 |
| -opendevstatus- NOTICE: Our Zuul gating CI/CD services are being taken offline now in order to apply some critical security updates, and are not expected to remain offline for more than 30 minutes. | 13:56 | |
| * abhishekk dinner break | 15:31 | |
| dansmith | rosmaita: re your comment just now on the policy spec, | 16:01 |
| rosmaita | i'm here | 16:01 |
| dansmith | rosmaita: do you realize that the policy.yaml abhishekk is talking about is *totally* wide open? (basically) all the policy rules are blank which means "anyone can do anything" | 16:01 |
| rosmaita | and that's what we're using for testing? | 16:01 |
| dansmith | not that it changes your feedback, just wondering if you realized that based on what you said was the intent before and after | 16:01 |
| dansmith | rosmaita: correct. | 16:02 |
| dansmith | rosmaita: different from the default production sample file, and different still from the actual defaults in code :/ | 16:02 |
| rosmaita | at the risk of insulting someone, holy shit | 16:02 |
| dansmith | seriously | 16:02 |
| dansmith | I was floored when I realized | 16:02 |
| dansmith | rosmaita: https://github.com/openstack/glance/blob/master/glance/tests/etc/policy.yaml | 16:02 |
| rosmaita | just goes to show, there is always something new to learn about glance | 16:03 |
| dansmith | the unit tests also use the fake policy which is an object that just returns pass unless there is a specific rule overridden, | 16:04 |
| dansmith | which means basically all the unit tests assume the same empty rules, but don't even check that the rule is one we support | 16:04 |
| rosmaita | well, i am glad to see this getting fixed, that's for sure | 16:06 |
| dansmith | yeah, and i think rbac is a good excuse to do it, since we really need things changed for it to work properly anyway.. so while we're touching everything we might as well get it closer to correct | 16:07 |
| abhishekk | +1 | 16:07 |
| dansmith | but, it's going to be a lot of work obviously, since there are plenty of tests that assert the wrong behaviors or won't work if we're actually checking policy | 16:07 |
| dansmith | like the one yesterday, | 16:07 |
| abhishekk | rosmaita, the hole is lot bigger than it seems | 16:07 |
| dansmith | that test was testing something that shouldn't work, but no policy so...it was testing something invalid | 16:08 |
| abhishekk | I think we will find more such tests going forward | 16:09 |
| dansmith | for sure | 16:09 |
| abhishekk | rosmaita, if you have time, please have a look at https://review.opendev.org/c/openstack/glance/+/782768/10 | 16:17 |
| opendevreview | Pavlo Shchelokovskyy proposed openstack/glance master: Document domain-related cinder backend options https://review.opendev.org/c/openstack/glance/+/797989 | 16:59 |
| opendevreview | Merged openstack/glance master: Make image stage set image.size https://review.opendev.org/c/openstack/glance/+/788075 | 17:27 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!