| *** bhagyashris__ is now known as bhagyashris | 04:41 | |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move metadef resource type association policy checks in the API https://review.opendev.org/c/openstack/glance/+/799637 | 05:43 |
|---|---|---|
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move metadef property policy checks in the API https://review.opendev.org/c/openstack/glance/+/799635 | 05:43 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef namespaces https://review.opendev.org/c/openstack/glance/+/798700 | 06:36 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef resource-type and object https://review.opendev.org/c/openstack/glance/+/799671 | 06:45 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef property and tags APIs https://review.opendev.org/c/openstack/glance/+/799912 | 06:46 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef resource-type and object https://review.opendev.org/c/openstack/glance/+/799671 | 07:35 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef property and tags APIs https://review.opendev.org/c/openstack/glance/+/799912 | 07:35 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef resource-type and object https://review.opendev.org/c/openstack/glance/+/799671 | 07:41 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef property and tags APIs https://review.opendev.org/c/openstack/glance/+/799912 | 07:42 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Implement API protection testing for metadef namespaces https://review.opendev.org/c/openstack/glance-tempest-plugin/+/800902 | 07:47 |
| opendevreview | Takashi Kajinami proposed openstack/glance master: Deploy healthcheck middleware as app instead of filter https://review.opendev.org/c/openstack/glance/+/802014 | 11:54 |
| opendevreview | Takashi Kajinami proposed openstack/glance master: Deploy healthcheck middleware as app instead of filter https://review.opendev.org/c/openstack/glance/+/802014 | 11:58 |
| opendevreview | Takashi Kajinami proposed openstack/glance master: Deploy healthcheck middleware as app instead of filter https://review.opendev.org/c/openstack/glance/+/802014 | 13:28 |
| whoami-rajat | abhishekk, dansmith Hey, can you take another look at the attachments patch, cinder dependencies have merged https://review.opendev.org/c/openstack/glance_store/+/782200 | 13:54 |
| opendevreview | Takashi Kajinami proposed openstack/glance master: Deploy healthcheck middleware as app instead of filter https://review.opendev.org/c/openstack/glance/+/802014 | 14:16 |
| opendevreview | Takashi Kajinami proposed openstack/glance master: Deploy healthcheck middleware as app instead of filter https://review.opendev.org/c/openstack/glance/+/802014 | 14:17 |
| opendevreview | Takashi Kajinami proposed openstack/glance master: Deploy healthcheck middleware as app instead of filter https://review.opendev.org/c/openstack/glance/+/802014 | 14:21 |
| abhishekk | whoami-rajat, will have a look | 14:32 |
| whoami-rajat | thanks abhishekk | 14:37 |
| abhishekk | np :D | 14:37 |
| abhishekk | whoami-rajat, around ? | 14:55 |
| whoami-rajat | abhishekk, yes (but in a meeting) | 14:56 |
| whoami-rajat | abhishekk, anything urgent? | 14:58 |
| abhishekk | related to your patch | 14:59 |
| abhishekk | ping me once meeeting is over | 14:59 |
| whoami-rajat | ok | 14:59 |
| whoami-rajat | abhishekk, around? | 15:30 |
| abhishekk | whoami-rajat, yep | 15:30 |
| whoami-rajat | abhishekk, cool, so what was the doubt | 15:30 |
| abhishekk | just a minute I need to switch network issues, it is connected ot OFTC but I am not able to browse anything :P | 15:31 |
| whoami-rajat | :D ok | 15:31 |
| akekane_ | whoami-rajat, https://review.opendev.org/c/openstack/glance_store/+/782200/18/glance_store/_drivers/cinder.py | 15:34 |
| akekane_ | line 1018 | 15:34 |
| akekane_ | I think you made this change just because you are using volume_api now right ? | 15:34 |
| whoami-rajat | akekane_, yep, i moved volume create and delete calls to volume_api to handle generic exceptions there | 15:36 |
| whoami-rajat | L#30 https://review.opendev.org/c/openstack/glance_store/+/782200/18/glance_store/common/cinder_utils.py | 15:36 |
| whoami-rajat | to use the above method ^ | 15:37 |
| akekane_ | Can you add something about it in the commit message ? | 15:37 |
| akekane_ | Because I think these changes are not directly related to attachment support change | 15:37 |
| whoami-rajat | yeah, they're kind of re factoring to keep similar things at one place | 15:38 |
| whoami-rajat | i will add a note in commit message | 15:39 |
| akekane_ | cool | 15:40 |
| *** akekane_ is now known as abhishekk | 15:40 | |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Add cinder's new attachment support https://review.opendev.org/c/openstack/glance_store/+/782200 | 15:41 |
| whoami-rajat | abhishekk, done ^ | 15:42 |
| abhishekk | whoami-rajat, thanks | 15:42 |
| whoami-rajat | np | 15:42 |
| abhishekk | whoami-rajat, also don't we have blueprint to tag it ? | 15:47 |
| * abhishekk going for dinner break | 15:55 | |
| whoami-rajat | abhishekk, yes we do, https://blueprints.launchpad.net/glance-store/+spec/attachment-api-and-multiattach-support | 16:11 |
| dansmith | whoami-rajat: if you're going to respin, | 16:19 |
| dansmith | you might want to drop the depends-on patches, since they're all merged, just to make it clear that this is free to move | 16:20 |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Add cinder's new attachment support https://review.opendev.org/c/openstack/glance_store/+/782200 | 16:23 |
| whoami-rajat | dansmith, ^ done | 16:23 |
| dansmith | whoami-rajat: thanks | 16:24 |
| whoami-rajat | (since cinderclient is already released with my patch, this should work) | 16:24 |
| whoami-rajat | dansmith, np | 16:25 |
| dansmith | whoami-rajat: lower-constraints.txt should be gone now, I'm surprised this isn't complaining | 16:25 |
| dansmith | maybe it will once we get a recent test run | 16:25 |
| whoami-rajat | dansmith, i think it's removed from glance but i still see it in glance_store git repo | 16:27 |
| dansmith | gaah, sorry :D | 16:27 |
| whoami-rajat | :D | 16:27 |
| dansmith | whoami-rajat: I haven't looked for the reason, but can you quickly tell me why the test_get_cinderclient_with_user_overidden_and_region() test removed the client call assertion? | 16:31 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef resource-types https://review.opendev.org/c/openstack/glance/+/799671 | 16:34 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef objects https://review.opendev.org/c/openstack/glance/+/802054 | 16:34 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef properties https://review.opendev.org/c/openstack/glance/+/802055 | 16:34 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef tags https://review.opendev.org/c/openstack/glance/+/802056 | 16:34 |
| dansmith | whoami-rajat: okay I guess it doesn't matter | 16:53 |
| whoami-rajat | dansmith, that was done by another patch | 16:54 |
| whoami-rajat | dansmith, https://github.com/openstack/glance_store/commit/98b4a0d4e76df022fa8a85a57b00b859b09e3274 | 16:54 |
| whoami-rajat | i just rebased onto it | 16:54 |
| whoami-rajat | dansmith to be precise https://github.com/openstack/glance_store/commit/98b4a0d4e76df022fa8a85a57b00b859b09e3274#diff-b1720f356a9235fdbd6d15672414ed28331e44f1e3862aec3d49ffe7df2708a9L85 | 16:55 |
| dansmith | oh, hmm, gerrit shows it as changed by this patch in the 16..20 delta, but I see it's not touched in the actual 20 diff, so maybe it's just confused | 16:55 |
| dansmith | whoami-rajat: but +2 anyway :) | 16:55 |
| whoami-rajat | thanks dansmith | 16:56 |
| whoami-rajat | i missed abhishekk's comment while pushing new patch, is it okay if i do it in a followup abhishekk ? | 16:57 |
| abhishekk | regarding that nit ? | 16:57 |
| whoami-rajat | abhishekk, yep | 16:57 |
| dansmith | I can re-+2 if you fix the nit | 16:58 |
| abhishekk | better to edit on the same patch and we both quickly +2 it | 16:58 |
| whoami-rajat | dansmith, that's because there was another patch merged which put my patch in merge conflict, since i fixed it (and it wasn't in my previous code) it shows that | 16:58 |
| whoami-rajat | ok | 16:58 |
| whoami-rajat | give me 2 minutes | 16:58 |
| dansmith | whoami-rajat: ah okay | 16:58 |
| abhishekk | ack | 16:58 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef namespaces https://review.opendev.org/c/openstack/glance/+/798700 | 16:59 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef resource-types https://review.opendev.org/c/openstack/glance/+/799671 | 17:00 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef property and tags APIs https://review.opendev.org/c/openstack/glance/+/799912 | 17:00 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef objects https://review.opendev.org/c/openstack/glance/+/802054 | 17:02 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef properties https://review.opendev.org/c/openstack/glance/+/802055 | 17:02 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef tags https://review.opendev.org/c/openstack/glance/+/802056 | 17:02 |
| * abhishekk signing out | 17:07 | |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Add cinder's new attachment support https://review.opendev.org/c/openstack/glance_store/+/782200 | 17:16 |
| whoami-rajat | abhishekk, dansmith ^^ | 17:16 |
| abhishekk | whoami-rajat, thank you for your patience :D | 17:17 |
| whoami-rajat | no problem :) | 17:17 |
| dansmith | done | 17:17 |
| abhishekk | done | 17:18 |
| whoami-rajat | thank you for your quick review dansmith abhishekk :) | 17:19 |
| * whoami-rajat signing out now | 17:19 | |
| abhishekk | whoami-rajat, any chance of shifting to glance :P | 17:19 |
| abhishekk | no no :P | 17:19 |
| whoami-rajat | abhishekk, if there is work to do :D , currently cinder also has a lot of work to do :) | 17:20 |
| abhishekk | ;) | 17:20 |
| opendevreview | Merged openstack/glance_store master: Add cinder's new attachment support https://review.opendev.org/c/openstack/glance_store/+/782200 | 20:27 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!