| *** akekane_ is now known as abhishekk | 06:03 | |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Implement project personas for metadef namespaces https://review.opendev.org/c/openstack/glance/+/798700 | 07:42 |
|---|---|---|
| opendevreview | Abhishek Kekane proposed openstack/glance master: Add missing forbidden to not found case for GET namespace API https://review.opendev.org/c/openstack/glance/+/804358 | 08:21 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Refactor gateway auth layer for task APIs https://review.opendev.org/c/openstack/glance/+/802243 | 08:28 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Deprecate task specific policies https://review.opendev.org/c/openstack/glance/+/802244 | 08:28 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move Tasks policy checks in the API https://review.opendev.org/c/openstack/glance/+/802245 | 08:28 |
| whoami-rajat | akekane_, hey, any update when l-c job will be fixed/removed from victoria gate? https://review.opendev.org/c/openstack/glance_store/+/786789 | 09:02 |
| whoami-rajat | tha above patch is blocked on it | 09:02 |
| akekane_ | whoami-rajat, is there any patch proposed for it, if not, could you propose it? | 09:03 |
| whoami-rajat | akekane_, i proposed this for wallaby https://review.opendev.org/c/openstack/glance_store/+/790082 | 09:04 |
| akekane_ | looking | 09:04 |
| whoami-rajat | akekane_, I'm not sure what was decided, should we remove it from master as well or just stable branches? | 09:04 |
| akekane_ | for glance we have removed from master | 09:04 |
| akekane_ | so makes sense to remove it from store and client as well | 09:05 |
| whoami-rajat | ok, so it makes sense to do the same for glance_store | 09:05 |
| whoami-rajat | ok | 09:05 |
| whoami-rajat | i will abandon this one and propose one for master | 09:05 |
| akekane_ | I just approved this one :/ | 09:06 |
| akekane_ | should I stop it ? | 09:06 |
| whoami-rajat | i think so | 09:07 |
| whoami-rajat | it will cause inconsistency then... | 09:07 |
| akekane_ | removed the workflow, abandon it now to take it out of zuul | 09:07 |
| whoami-rajat | ack | 09:07 |
| akekane_ | done | 09:08 |
| *** akekane_ is now known as abhishekk | 09:08 | |
| whoami-rajat | thanks | 09:09 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move Tasks policy checks in the API https://review.opendev.org/c/openstack/glance/+/802245 | 09:13 |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Drop lower-constraints job https://review.opendev.org/c/openstack/glance_store/+/804369 | 09:17 |
| whoami-rajat | abhishekk, ^^ proposed for glance_store master | 09:19 |
| abhishekk | ack, looking | 09:20 |
| abhishekk | looks good, add another reviewer as well | 09:22 |
| whoami-rajat | ack | 09:29 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move member policy checks to API layer https://review.opendev.org/c/openstack/glance/+/802996 | 10:45 |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store master: Add volume multiattach handling https://review.opendev.org/c/openstack/glance_store/+/786410 | 13:20 |
| abhishekk | stephenfin, around ? | 13:39 |
| abhishekk | jokke_, rosmaita, dansmith, croelandt, smcginnis glance weekly meeting in 5 minutes at #openstack-meeting | 13:56 |
| stephenfin | abhishekk: 'ish, what's up? | 14:19 |
| abhishekk | stephenfin, oslo tips job is failing for glance | 14:20 |
| abhishekk | issue is related to database, I suppose it is something related to migration stuff we have removed | 14:20 |
| abhishekk | https://3d423a08ba57e3349bef-667e59a55d2239af414b0984e42f005a.ssl.cf5.rackcdn.com/periodic/opendev.org/openstack/glance/master/glance-tox-functional-py36-oslo-tips/c8d34a7/testr_results.html | 14:21 |
| abhishekk | if possible could you please confirm the same ? | 14:21 |
| abhishekk | something similar to this, https://review.opendev.org/c/openstack/oslo.db/+/802573 | 14:30 |
| abhishekk | dansmith, just FYI, I have replied to your comments on members patch and added one more test at the end | 14:34 |
| dansmith | I saw it got updated this morning, and I have it open | 14:34 |
| stephenfin | abhishekk: Yeah, we've been making a lot of changes in oslo.db to get it ready for SQLAlchemy 2.0. Looks like one of those has broken you | 14:42 |
| jokke_ | gotta <3 the tips job :) | 14:42 |
| jokke_ | nce to find it out now, not after the release | 14:42 |
| abhishekk | stephenfin, ack I think the patch I shared will fix us ? | 14:43 |
| abhishekk | https://review.opendev.org/c/openstack/oslo.db/+/802573 this one | 14:43 |
| stephenfin | Possibly, though I'd like to know which patch broke you in the first place | 14:43 |
| abhishekk | qlalchemy.exc.UnboundExecutionError: This Insert is not directly bound to a Connection or Engine. Use the .execute() method of a Connection or Engine to execute this construct. | 14:43 |
| abhishekk | dansmith, ack | 14:45 |
| stephenfin | I bet it's this one https://review.opendev.org/c/openstack/oslo.db/+/802570 | 14:45 |
| abhishekk | looking | 14:46 |
| * stephenfin quickly runs offending unit test on bisected oslo.db repo | 14:46 | |
| abhishekk | yes | 14:46 |
| stephenfin | I should probably write a mail to the mailing list about this. We can't revert that unless we choose not to support the upcoming SQLAlchemy 2.0, so projects are simply going to have to adapt to this, I suspect | 14:48 |
| stephenfin | they'll have to make changes as-is if they want to support SQLAlchemy 2.x themselves anyway | 14:48 |
| abhishekk | hmm | 14:49 |
| opendevreview | Merged openstack/glance_store master: Drop lower-constraints job https://review.opendev.org/c/openstack/glance_store/+/804369 | 14:49 |
| stephenfin | Yup, that's the offending patch | 14:52 |
| stephenfin | I'll write said email | 14:52 |
| stephenfin | and discuss with zzzeek to see if he has any clever ideas | 14:53 |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store stable/wallaby: Drop lower-constraints job https://review.opendev.org/c/openstack/glance_store/+/804346 | 14:53 |
| stephenfin | I have started migrating nova, cinder and placement to be SQLAlchemy 2.x compatible but I won't have time to fix others, unfortunately :( | 14:53 |
| abhishekk | stephenfin, ack, thank you for confirmation, | 14:56 |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store stable/wallaby: Drop lower-constraints job https://review.opendev.org/c/openstack/glance_store/+/804346 | 15:01 |
| opendevreview | Stephen Finucane proposed openstack/glance master: Resolve compatibility with oslo.db future https://review.opendev.org/c/openstack/glance/+/804406 | 15:06 |
| opendevreview | Stephen Finucane proposed openstack/glance master: setup.cfg: Fix errant key https://review.opendev.org/c/openstack/glance/+/804407 | 15:06 |
| stephenfin | abhishekk: ^ that will get you passing again, I hope. There's a lot more to be done for SQLA 2.x compatibility though | 15:06 |
| stephenfin | abhishekk: If you want to see how much, set 'SQLALCHEMY_WARN_20=1' in 'tox.ini' and turn those warnings to errors for the glance module and submodules, similar to here https://review.opendev.org/c/openstack/oslo.db/+/802566/ | 15:08 |
| abhishekk | stephenfin, thank you very much, I will keep track of SQLA 2.x work | 15:08 |
| abhishekk | stephenfin, ack, thank you again | 15:08 |
| stephenfin | abhishekk: If you want to open a Glance (or oslo.db, if you think it better) bug for that and amend my commit message to point to it, feel free to do so. I'd appreciate having a bug I can point to when discussing the kinds of changes people will likely to have to make | 15:12 |
| abhishekk | stephenfin, yes, thinking of reporting a bug, will do it shortly and add it to patch | 15:14 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Resolve compatibility with oslo.db future https://review.opendev.org/c/openstack/glance/+/804406 | 15:39 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: setup.cfg: Fix errant key https://review.opendev.org/c/openstack/glance/+/804407 | 15:40 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: setup.cfg: Fix errant key https://review.opendev.org/c/openstack/glance/+/804407 | 15:40 |
| abhishekk | stephenfin, https://bugs.launchpad.net/glance/+bug/1939716 | 15:40 |
| * abhishekk going for dinner | 15:41 | |
| abhishekk | dansmith, just need confirmation to comment, https://review.opendev.org/c/openstack/glance/+/802996/9/glance/api/v2/policy.py | 16:49 |
| abhishekk | no hurry | 16:49 |
| dansmith | abhishekk: replied, yeah didn't mean check obviously :) | 16:57 |
| abhishekk | ack :D | 16:57 |
| abhishekk | something is wrong in comment again | 17:00 |
| dansmith | jeez | 17:00 |
| dansmith | sorry, hopefully you know what I mean :) | 17:01 |
| abhishekk | yeah | 17:01 |
| opendevreview | Merged openstack/glance_store stable/wallaby: Drop lower-constraints job https://review.opendev.org/c/openstack/glance_store/+/804346 | 18:32 |
| croelandt | abhishekk: Aren't pdeore's patches going to be in merge conflict as soon as your patches get merged? | 18:52 |
| abhishekk | croelandt, right | 18:52 |
| abhishekk | she will rebase those on top of mine | 18:53 |
| croelandt | yeah I'll wait before reviewing those thoroughly then :D | 18:54 |
| abhishekk | you can review first patch of her though | 18:56 |
| abhishekk | or you can shift back to restoring +2s on mine for metadef refactoring :D | 18:56 |
| abhishekk | ohh, you already done that :D | 18:56 |
| dansmith | I was just about to say.. | 18:57 |
| abhishekk | I lost 1 hour just because one silly mistake :/ | 18:58 |
| croelandt | yeah one of them is going to be merged | 19:11 |
| abhishekk | cool, thank you | 19:11 |
| opendevreview | Merged openstack/glance master: Move metadef object policy checks in the API https://review.opendev.org/c/openstack/glance/+/799634 | 19:25 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move member policy checks to API layer https://review.opendev.org/c/openstack/glance/+/802996 | 19:40 |
| * abhishekk upload_image is already enforced at API layer | 19:47 | |
| abhishekk | croelandt, if you could review https://review.opendev.org/c/openstack/glance/+/802996 then we will have much less load next week | 20:56 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Check upload_image policy in the API https://review.opendev.org/c/openstack/glance/+/804463 | 21:17 |
| croelandt | have a good weekend :) | 21:17 |
| abhishekk | croelandt, \o/ | 21:17 |
| * abhishekk signing out for the day | 21:19 | |
| abhishekk | have a good weekend all :D | 21:19 |
| opendevreview | Merged openstack/glance master: Move member policy checks to API layer https://review.opendev.org/c/openstack/glance/+/802996 | 22:18 |
| opendevreview | Merged openstack/glance master: Resolve compatibility with oslo.db future https://review.opendev.org/c/openstack/glance/+/804406 | 22:18 |
| opendevreview | Merged openstack/glance master: setup.cfg: Fix errant key https://review.opendev.org/c/openstack/glance/+/804407 | 22:38 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!