| opendevreview | Rajat Dhasmana proposed openstack/glance_store stable/victoria: Drop lower-constraints job https://review.opendev.org/c/openstack/glance_store/+/804606 | 07:42 |
|---|---|---|
| opendevreview | Rajat Dhasmana proposed openstack/glance_store stable/victoria: Drop lower-constraints job https://review.opendev.org/c/openstack/glance_store/+/804606 | 09:59 |
| opendevreview | Stephen Finucane proposed openstack/glance master: Resolve compatibility with oslo.db future (redux) https://review.opendev.org/c/openstack/glance/+/804699 | 10:58 |
| opendevreview | Erno Kuvaja proposed openstack/glance_store master: Raise correct exception from "Quota full" https://review.opendev.org/c/openstack/glance_store/+/800227 | 11:20 |
| opendevreview | Erno Kuvaja proposed openstack/glance master: 'community' images needs to be treated as public https://review.opendev.org/c/openstack/glance/+/800221 | 11:53 |
| opendevreview | Takashi Kajinami proposed openstack/glance master: Load options from the castellan library https://review.opendev.org/c/openstack/glance/+/804754 | 13:55 |
| abhishekk | croelandt, around? | 13:57 |
| croelandt | yeah | 14:02 |
| croelandt | was going to dive into the dahsboard | 14:02 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef namespaces https://review.opendev.org/c/openstack/glance/+/798700 | 14:07 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef objects https://review.opendev.org/c/openstack/glance/+/802054 | 14:07 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef resource-types https://review.opendev.org/c/openstack/glance/+/799671 | 14:07 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef properties https://review.opendev.org/c/openstack/glance/+/802055 | 14:07 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef tags https://review.opendev.org/c/openstack/glance/+/802056 | 14:07 |
| abhishekk | croelandt, lot has been added there | 14:10 |
| croelandt | yep *sigh* | 14:11 |
| croelandt | anything in particular you want me to review first? :) | 14:12 |
| croelandt | what is more urgent than urgent :D | 14:12 |
| abhishekk | upload/download | 14:12 |
| abhishekk | then staging and import | 14:14 |
| abhishekk | then delete from store | 14:14 |
| abhishekk | then image tags | 14:14 |
| abhishekk | also I have added plenty of bugs in our bug tracker | 14:14 |
| jokke_ | abhishekk: got the tests you wanted for the swift fixes | 14:15 |
| abhishekk | jokke_, going through it | 14:15 |
| abhishekk | I have one question, not related to your change but in general | 14:15 |
| jokke_ | mhm | 14:16 |
| abhishekk | image sharing is only allowed for shared images, right ? | 14:16 |
| jokke_ | correct | 14:16 |
| abhishekk | https://review.opendev.org/c/openstack/glance/+/800221/2/glance/location.py@627 | 14:17 |
| abhishekk | do you think this is not reachable then ? | 14:17 |
| croelandt | FIXME(abhishekk): Everything is fake in this test <- sometimes OpenStack tests feel like we reimplemented everything as mocks :D | 14:17 |
| abhishekk | :D | 14:18 |
| jokke_ | croelandt: that's unittests for you, "Self.assertTrue(mock.True) :P | 14:19 |
| croelandt | Honestly, I find it hard to debug sometimes | 14:20 |
| croelandt | you get fake methods that take fake arguments and then work on fake code | 14:20 |
| croelandt | and I'm like "where is the real stuff I'm supposed to be testing, again?" | 14:21 |
| abhishekk | :D | 14:21 |
| jokke_ | abhishekk: So IIRC turning image from shared to public or community preserves the members, what I don't know is if you can still accept the image after that if you had pending membership there. I'd say if we're not 100% sure that line is good to have there ;) | 14:21 |
| abhishekk | hmm, so can we revert that change then ? | 14:22 |
| jokke_ | abhishekk: you mean the MemberRepoProxy line? | 14:23 |
| abhishekk | yeah ? | 14:23 |
| abhishekk | I don't think it is reachable, I will try to change image visibility from shared to public after having members to it | 14:24 |
| jokke_ | I think you have poked the membership code more recently. I wouldn't trust out of my head that we don't fuck it up anywhere, but if you can, I think we can clean that MemberRepo_Proxy _set_acls() a bit. | 14:25 |
| jokke_ | abhishekk: I included that to the community image patch as the public was there, did not dig in too deep where all it possibly gets called | 14:27 |
| abhishekk | right, | 14:28 |
| abhishekk | it is setting acls for shared images only | 14:28 |
| abhishekk | which is definitely not required | 14:33 |
| abhishekk | dansmith, around ? | 14:37 |
| abhishekk | lbragstad, there is one patch for review, kindly have a look when you get some time | 14:45 |
| abhishekk | https://review.opendev.org/c/openstack/glance/+/804585 | 14:45 |
| dansmith | abhishekk: in a call | 14:50 |
| abhishekk | dansmith, ack | 14:51 |
| jokke_ | croelandt: https://review.opendev.org/c/openstack/glance_store/+/800227 you had +2 on that already | 15:14 |
| jokke_ | just the test abhishekk asked added | 15:14 |
| croelandt | indeed | 15:44 |
| * abhishekk going for dinner break | 15:57 | |
| opendevreview | Merged openstack/glance master: Resolve compatibility with oslo.db future (redux) https://review.opendev.org/c/openstack/glance/+/804699 | 15:59 |
| * dansmith finally peels himself out of the chair for an overdue bio break | 17:02 | |
| abhishekk | lengthy meetings ? | 17:05 |
| dansmith | yeah | 17:06 |
| abhishekk | ok, so not taking much of your time, if you have not started work on add_image policy, should I take it ? | 17:08 |
| opendevreview | Merged openstack/glance_store master: Raise correct exception from "Quota full" https://review.opendev.org/c/openstack/glance_store/+/800227 | 17:08 |
| opendevreview | Merged openstack/glance_store stable/victoria: Drop lower-constraints job https://review.opendev.org/c/openstack/glance_store/+/804606 | 17:08 |
| dansmith | abhishekk: ugh! | 17:09 |
| dansmith | abhishekk: I really want to do it but I still haven't done the other one that is still PoC | 17:10 |
| dansmith | you own that patch anyway, maybe you could just finish that and I'll start on add_image? | 17:10 |
| abhishekk | no problem | 17:10 |
| abhishekk | you also have long list to review :D | 17:10 |
| dansmith | I know :( | 17:11 |
| abhishekk | just FYI I have added one more sheet in spreadsheet which covers APIs which does not have own policies but enforces other checks | 17:11 |
| dansmith | okay cool | 17:12 |
| dansmith | abhishekk: can we put a link to the dashboard in the sheet? I closed that tab apparently | 17:12 |
| abhishekk | Ok, then I will work on PoC | 17:12 |
| abhishekk | dansmith, ack | 17:12 |
| dansmith | thanks | 17:13 |
| abhishekk | np | 17:14 |
| timburke__ | swift | 17:14 |
| timburke__ | bah -- saw a highlight, thought i was searching :P | 17:15 |
| *** timburke__ is now known as timburke | 17:16 | |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store stable/ussuri: Drop lower-constraints job https://review.opendev.org/c/openstack/glance_store/+/804792 | 17:17 |
| abhishekk | we need to consider tests failing with timeouts as well :/ | 18:10 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Check download_image policy in the API https://review.opendev.org/c/openstack/glance/+/804547 | 19:28 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Check download_image policy in the API https://review.opendev.org/c/openstack/glance/+/804547 | 19:32 |
| dansmith | abhishekk: I might need you to look at something related to create image | 19:34 |
| abhishekk | ack | 19:34 |
| abhishekk | let me know | 19:34 |
| dansmith | abhishekk: set_acls() is failing in location, with a specific task | 19:34 |
| dansmith | er, specific test | 19:34 |
| dansmith | once we no longer have the auth layer stuff in there | 19:35 |
| dansmith | I'm guessing something in those layers causes us to skip that on create, but I have yet to find it | 19:35 |
| dansmith | let me push up what I have with one failing test and maybe you can look tomorrow | 19:35 |
| abhishekk | ack | 19:35 |
| abhishekk | will have a look | 19:35 |
| * croelandt is reading so many similar patches that they are all getting mixed up in his head :D | 19:36 | |
| opendevreview | Dan Smith proposed openstack/glance master: Check add_image policy in the API https://review.opendev.org/c/openstack/glance/+/804800 | 19:37 |
| dansmith | left a FIXME in images.py on a re-raise the error so you can see where it's failing ^ | 19:37 |
| abhishekk | ack | 19:37 |
| abhishekk | croelandt, :D | 19:37 |
| abhishekk | dansmith, I think you need to change get_image_factory method as well to remove authorization layer | 19:42 |
| dansmith | oh? | 19:46 |
| abhishekk | also create enforces publicize_image and communitize_image policies as well | 19:47 |
| abhishekk | those will get enforced at policy layer in this process | 19:48 |
| dansmith | I don't see where in the auth/policy factor layers I get somewhere related to the locations stuff | 19:49 |
| abhishekk | new_image enforces them | 19:50 |
| dansmith | yeah, I see that for publicize and communitize, | 19:51 |
| dansmith | I'm saying I don't see where the interaction between the locations failure and the factories is | 19:51 |
| abhishekk | aah | 19:51 |
| abhishekk | I remember create API call also enforces get_image_location somewhere | 19:52 |
| dansmith | in set_acl via ImageLocationProxy | 19:53 |
| dansmith | but I don't really see why that has changed here | 19:53 |
| dansmith | like, I don't see why the test passed before | 19:53 |
| abhishekk | will have a look, didn't see it closely yet | 19:54 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for staging operation in API https://review.opendev.org/c/openstack/glance/+/804558 | 19:54 |
| abhishekk | upload, download, stage API are ready ^^ | 19:54 |
| * abhishekk thinks its something related to policy_enforcer object | 20:19 | |
| abhishekk | dansmith, I will look at it tomorrow | 20:58 |
| dansmith | abhishekk: rgr | 21:18 |
| * abhishekk signing out for the day | 22:27 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!