*** yoctozepto8 is now known as yoctozepto | 00:33 | |
opendevreview | Merged openstack/glance master: Avoid reinitialization of image repo https://review.opendev.org/c/openstack/glance/+/805593 | 01:05 |
---|---|---|
opendevreview | Merged openstack/glance master: Check add_image policy in the API https://review.opendev.org/c/openstack/glance/+/804800 | 01:05 |
*** yoctozepto6 is now known as yoctozepto | 01:21 | |
*** yoctozepto3 is now known as yoctozepto | 02:12 | |
*** yoctozepto8 is now known as yoctozepto | 03:43 | |
*** yoctozepto8 is now known as yoctozepto | 03:57 | |
*** yoctozepto0 is now known as yoctozepto | 04:12 | |
*** yoctozepto1 is now known as yoctozepto | 04:40 | |
*** yoctozepto7 is now known as yoctozepto | 05:43 | |
opendevreview | Mridula Joshi proposed openstack/glance master: Fix overwriting of existing tags while creating new tags https://review.opendev.org/c/openstack/glance/+/804966 | 05:48 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for image import operation in API https://review.opendev.org/c/openstack/glance/+/804590 | 06:15 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for Image Tags in API https://review.opendev.org/c/openstack/glance/+/804588 | 06:15 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for image tasks information in API https://review.opendev.org/c/openstack/glance/+/805590 | 06:15 |
*** yoctozepto0 is now known as yoctozepto | 06:24 | |
*** redrobot0 is now known as redrobot | 06:29 | |
*** yoctozepto9 is now known as yoctozepto | 07:00 | |
*** yoctozepto1 is now known as yoctozepto | 07:52 | |
whoami-rajat | akekane_, hey, can you take a look at this backport https://review.opendev.org/c/openstack/glance_store/+/786789 | 08:52 |
akekane_ | whoami-rajat, ack, will look in15-20 minutes | 08:53 |
*** akekane_ is now known as abhishekk | 08:53 | |
whoami-rajat | akekane_, np thanks | 08:53 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for Image Cache in API https://review.opendev.org/c/openstack/glance/+/805797 | 09:12 |
abhishekk | with this change 100% work up for review for enforcing policy checks at API layer | 09:14 |
abhishekk | croelandt, dansmith ^ | 09:14 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for image import operation in API https://review.opendev.org/c/openstack/glance/+/804590 | 09:36 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for Image Tags in API https://review.opendev.org/c/openstack/glance/+/804588 | 09:36 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for image tasks information in API https://review.opendev.org/c/openstack/glance/+/805590 | 09:36 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for Image Cache in API https://review.opendev.org/c/openstack/glance/+/805797 | 09:36 |
abhishekk | some missing patches added to review dashboard again (those were missed because of spelling mistake in topic name) | 15:00 |
dansmith | dang, I thought we were getting really close | 15:03 |
dansmith | I'm in the middle of another, but had to jump on a call | 15:03 |
abhishekk | sorry :( | 15:03 |
abhishekk | I should really install spell checker :D | 15:04 |
abhishekk | The one which will need careful look is import API related patch, others are easy and straight forward | 15:04 |
* croelandt is reading the import/copy patch | 15:10 | |
abhishekk | O/ | 15:13 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for Image Cache in API https://review.opendev.org/c/openstack/glance/+/805797 | 15:14 |
opendevreview | Merged openstack/glance master: Add missing forbidden to not found case for GET namespace API https://review.opendev.org/c/openstack/glance/+/804358 | 15:29 |
lbragstad | same - i checked the dashboard this morning and only saw 4 patches left for the API refactor :) | 15:58 |
dansmith | inflation :/ | 15:59 |
abhishekk | :D | 15:59 |
* lbragstad sigh | 15:59 | |
lbragstad | well - regardless i am excited we're making progress | 16:00 |
dansmith | I think abhishekk is having so much fun he's just making up new crap for us to refactor :P | 16:01 |
abhishekk | a lot :P | 16:01 |
dansmith | he told me he dreams about policy refactor | 16:01 |
dansmith | I suggested he seek medical help for that ailment :P | 16:01 |
abhishekk | haha | 16:01 |
abhishekk | on that note, I think I should take some break | 16:03 |
abhishekk | will be back after dinner | 16:04 |
lbragstad | RBAC is a condition | 16:11 |
lbragstad | biab | 16:12 |
croelandt | abhishekk: on the same note I'm probably gonna be on PTO for the next two weeks | 16:27 |
croelandt | iirc M3 is on Monday, so that should be OK regarding the reviews, right? | 16:28 |
abhishekk | croelandt, I think at the moment we looks good and will be able to finish policy work by this week | 16:34 |
croelandt | Don't hesitate to spam me this week then :D | 16:34 |
abhishekk | croelandt, cool :D | 16:45 |
abhishekk | dansmith, replied to comments on import patch, kindly have a look | 16:46 |
croelandt | abhishekk: what is the deadline for all the RBAC patches we currently have under reveiw? | 16:50 |
abhishekk | croelandt, I want them in M3 but I think it will go 1 week after M3 and and before RC1 release | 16:51 |
abhishekk | I will try to rebase them tomorrow to remove merge conflict, those will be easier to review since now we have policy checks in API layer, and also we have added good functional test coverage there | 16:52 |
abhishekk | between if someone wants to fix review comments on metadef policy patches then I am ok with that :D | 17:03 |
dansmith | abhishekk: done | 17:27 |
abhishekk | dansmith, ack, thank you | 17:28 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for image import operation in API https://review.opendev.org/c/openstack/glance/+/804590 | 18:28 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for Image Tags in API https://review.opendev.org/c/openstack/glance/+/804588 | 18:28 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for image tasks information in API https://review.opendev.org/c/openstack/glance/+/805590 | 18:28 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for Image Cache in API https://review.opendev.org/c/openstack/glance/+/805797 | 18:28 |
opendevreview | Merged openstack/glance master: Move metadef resource type association policy checks in the API https://review.opendev.org/c/openstack/glance/+/799637 | 18:31 |
croelandt | abhishekk: oh, I had no idea we did not have an "add" method for image tags | 19:10 |
abhishekk | no problem, neither do I before working on this patch | 19:11 |
abhishekk | croelandt, could you please also have a look at import patch once again | 19:17 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Move metadef property policy checks in the API https://review.opendev.org/c/openstack/glance/+/799635 | 19:43 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Move metadef tag policy checks in the API https://review.opendev.org/c/openstack/glance/+/799636 | 19:43 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for image import operation in API https://review.opendev.org/c/openstack/glance/+/804590 | 20:17 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for Image Tags in API https://review.opendev.org/c/openstack/glance/+/804588 | 20:17 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for image tasks information in API https://review.opendev.org/c/openstack/glance/+/805590 | 20:17 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for Image Cache in API https://review.opendev.org/c/openstack/glance/+/805797 | 20:17 |
abhishekk | croelandt, could you please restore +w on https://review.opendev.org/c/openstack/glance/+/804590 (it got rebased :/ ) | 20:19 |
abhishekk | also timeout issue is back and this time it is for functional-py38 | 20:20 |
* abhishekk signing out for the day | 20:36 | |
abhishekk | 5 out of 6 in check queue has timed out :/ | 20:42 |
abhishekk | I will recheck them tomorrow my time | 20:43 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!