| opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for image tasks information in API https://review.opendev.org/c/openstack/glance/+/805590 | 05:57 |
|---|---|---|
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move metadef property policy checks in the API https://review.opendev.org/c/openstack/glance/+/799635 | 05:57 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move metadef tag policy checks in the API https://review.opendev.org/c/openstack/glance/+/799636 | 05:58 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Move metadef tag policy checks in the API https://review.opendev.org/c/openstack/glance/+/799636 | 05:58 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Check policies for Image Cache in API https://review.opendev.org/c/openstack/glance/+/805797 | 07:32 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Add protection testing for metadef namespaces https://review.opendev.org/c/openstack/glance-tempest-plugin/+/800902 | 10:54 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Add protection testing for metadef namespaces https://review.opendev.org/c/openstack/glance-tempest-plugin/+/800902 | 11:01 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Implement API protection testing for metadef objects https://review.opendev.org/c/openstack/glance-tempest-plugin/+/802793 | 12:32 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Implement API protection testing for metadef resource types https://review.opendev.org/c/openstack/glance-tempest-plugin/+/802792 | 13:55 |
| abhishekk | looks like nova patch is not merged yet | 14:14 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Implement API protection testing for metadef properties https://review.opendev.org/c/openstack/glance-tempest-plugin/+/802794 | 14:29 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Implement API protection testing for metadef properties https://review.opendev.org/c/openstack/glance-tempest-plugin/+/802794 | 14:31 |
| akekane_ | dansmith, I have added test case for cache policy enforcement patch | 14:38 |
| akekane_ | #link https://review.opendev.org/c/openstack/glance/+/805797 | 14:39 |
| dansmith | cool, I have to do something urgently for nova this morning but will circle back | 14:39 |
| akekane_ | yep, no worries, take your time | 14:39 |
| akekane_ | lbragstad, if you could take a look at metadef rbac patches, then we will be able to get it merge this cycle | 14:40 |
| *** akekane_ is now known as abhishekk | 14:41 | |
| lbragstad | ack | 14:41 |
| abhishekk | thank you | 14:51 |
| dansmith | abhishekk: glad it wasn't hard :) | 15:05 |
| abhishekk | :D | 15:06 |
| abhishekk | Learning the art of writing easy and simple tests | 15:06 |
| lbragstad | abhishekk ok -i think i worked through most of the metadef changes in glance-tempest-plugin and glance proper | 16:31 |
| lbragstad | but most of my comments are the same across patches | 16:31 |
| abhishekk | lbragstad, ack, going through them now | 16:31 |
| abhishekk | lbragstad, just replied to one of the patch (related to comment in .zuul.yaml) | 16:35 |
| abhishekk | and thank you for your time | 16:35 |
| lbragstad | abhishekk all in all - i think the changes for the metadef parts look good | 16:50 |
| abhishekk | cool | 16:50 |
| lbragstad | the only real concern i think i had outside of organization stuff was we were still using metadef:rule_default | 16:51 |
| abhishekk | ack, I think we reverted that because policy check is like noop there as db was actually returning us the valid result before the policy enforcement | 16:52 |
| lbragstad | ah | 16:52 |
| lbragstad | so - is the plan to put the policy check back in? | 16:52 |
| abhishekk | kind of | 16:53 |
| lbragstad | since the hard-coded checks (in the database for example) are what we're trying to remove? | 16:59 |
| abhishekk | lbragstad, we were working on this parallel (policy moving to API and RBAC for metadefs) at that time we reverted to old policy check for RBAC as policy checks were not moved to API layer | 17:02 |
| abhishekk | but now as it is done, I think we can change this policy to RBAC kind policy | 17:03 |
| opendevreview | Merged openstack/glance master: Move metadef property policy checks in the API https://review.opendev.org/c/openstack/glance/+/799635 | 17:05 |
| opendevreview | Merged openstack/glance master: Move metadef tag policy checks in the API https://review.opendev.org/c/openstack/glance/+/799636 | 17:08 |
| opendevreview | Merged openstack/glance master: Check policies for image tasks information in API https://review.opendev.org/c/openstack/glance/+/805590 | 17:16 |
| lbragstad | nice - only two patches left in the refactoring | 17:18 |
| abhishekk | dansmith, I guess since cyril is not around and he has +2ed the cache patch before adding test, I guess you ninja approve that | 17:18 |
| abhishekk | lbragstad, yep, one is ^^ and other is release note | 17:18 |
| dansmith | abhishekk: sure, wasn't sure if you were ready to approve, I had just +2d before you know, but seems unlikely the cache patch is going to have all that feedback and testing resolved by thursday | 17:19 |
| abhishekk | I am trying my hard to work on fixing those comments, but it is unlikely to get it done in time | 17:20 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef namespaces https://review.opendev.org/c/openstack/glance/+/798700 | 19:47 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef objects https://review.opendev.org/c/openstack/glance/+/802054 | 19:47 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef resource-types https://review.opendev.org/c/openstack/glance/+/799671 | 19:47 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef properties https://review.opendev.org/c/openstack/glance/+/802055 | 19:47 |
| opendevreview | Pranali Deore proposed openstack/glance master: Implement project personas for metadef tags https://review.opendev.org/c/openstack/glance/+/802056 | 19:47 |
| opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Add protection testing for metadef namespaces https://review.opendev.org/c/openstack/glance-tempest-plugin/+/800902 | 20:26 |
| * abhishekk signing out fir the day | 21:16 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!