opendevreview | Pranali Deore proposed openstack/glance-tempest-plugin master: Add protection testing for metadef namespaces https://review.opendev.org/c/openstack/glance-tempest-plugin/+/800902 | 11:39 |
---|---|---|
*** abhishekk is now known as akekane|home | 13:45 | |
*** akekane|home is now known as abhishekk | 13:45 | |
*** akekane_ is now known as abhishekk | 14:34 | |
abhishekk | rosmaita, around? | 14:34 |
rosmaita | yep | 14:34 |
abhishekk | rosmaita, i am not able to recollect, for rc2 we need to pick hash from master branch, right? | 14:35 |
rosmaita | abhishekk: did you cut stable/xena yet? (usually as part of the RC-1 patch) | 14:36 |
abhishekk | yes, it is cut | 14:36 |
rosmaita | yes, then RC2 needs to come from a stable/xena patch | 14:36 |
abhishekk | ack | 14:36 |
abhishekk | thank you | 14:37 |
rosmaita | by "patch" i mean "hash" | 14:37 |
abhishekk | yep | 14:37 |
rosmaita | ok | 14:37 |
rosmaita | btw, thanks for catching that need to raise oslo.log version in requirements | 14:38 |
abhishekk | zigo, ^^ | 14:39 |
abhishekk | it was zigo | 14:39 |
rosmaita | ah, he pointed it out in cinder, too, but i already had a patch posted because of yours! | 14:40 |
abhishekk | :D | 14:42 |
abhishekk | https://review.opendev.org/c/openstack/releases/+/810270 | 14:47 |
abhishekk | rosmaita, jokke_ dansmith ^^^ RC2 | 14:47 |
rosmaita | abhishekk: after what zigo found, i hacked together a lower-constraints job to check cinder requirements minimums ... don't know if you might find it useful for glance: https://review.opendev.org/c/openstack/cinder/+/810131 | 14:52 |
abhishekk | rosmaita, cool, will have a look at it | 14:52 |
abhishekk | rosmaita, I think it will be useful for us too | 14:53 |
rosmaita | cool | 14:55 |
lbragstad | nice work on the metadef protection tests - i just took a look at the namespaces patch and i don't have anything significant to add | 15:00 |
rosmaita | abhishekk: did you also want to raise oslo.policy, just on general principles ... glance has >=3.7.0, probably most of the policy testing was done with 3.8.1 (released in June) | 15:01 |
rosmaita | (i mean before you cut rc2) | 15:02 |
abhishekk | lbragstad, cool, thank you, I have just added couple of comments but those are nits, please have a look at those whether those are worth to fix | 15:02 |
abhishekk | rosmaita, I think at this moment current version is good if it is not breaking anything | 15:03 |
rosmaita | ok | 15:03 |
lbragstad | i think i'm ok fixing those things in a follow up | 15:04 |
abhishekk | ack | 15:04 |
abhishekk | lbragstad, should we raise oslo.policy to 3.8.1 for xena ? | 15:05 |
lbragstad | i don't see why not - 3.7.0 - 3.8.1 shouldn't break glance | 15:06 |
abhishekk | OK, so we need to backport it to xena as well before releasing rc2 | 15:07 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Bump oslo.log to version 3.8.1 https://review.opendev.org/c/openstack/glance/+/810275 | 15:15 |
abhishekk | rosmaita, lbragstad ^^ | 15:15 |
rosmaita | ack | 15:15 |
jokke_ | abhishekk: we're also missing the bug 1939716 from the renos | 15:33 |
abhishekk | jokke_, I think those are test specifc changes | 15:35 |
jokke_ | abhishekk: also -1 on the req patch | 15:37 |
abhishekk | ack | 15:37 |
jokke_ | abhishekk: oh yeah, tru never mind with that reno comment | 15:38 |
abhishekk | jokke_, https://bugs.launchpad.net/glance/+bug/1944445 | 15:39 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Bump oslo.log to version 3.8.1 https://review.opendev.org/c/openstack/glance/+/810275 | 15:40 |
abhishekk | jokke_, ^^, will you backport it to stable/xena ? | 15:41 |
jokke_ | I can if we have reviewers for it | 15:44 |
abhishekk | ack | 15:48 |
opendevreview | Abhishek Kekane proposed openstack/glance master: Bump oslo.policy to version 3.8.1 https://review.opendev.org/c/openstack/glance/+/810275 | 15:50 |
* abhishekk dinner break | 16:00 | |
abhishekk | jokke_, rosmaita zuul passes | 16:50 |
abhishekk | ^^ | 16:50 |
jokke_ | ack | 16:55 |
abhishekk | thanks | 16:57 |
abhishekk | rosmaita, if you are still around and not busy ^^ | 17:28 |
rosmaita | ack | 17:28 |
rosmaita | (just got back from lunch) | 17:28 |
rosmaita | jokke_: good catch on the commit message | 17:30 |
abhishekk | thank you | 17:33 |
* abhishekk signing out for the day | 17:33 | |
rosmaita | have a good evening | 17:33 |
jokke_ | rosmaita: are you going to be around for the afternoon? If I backport that once it merges, you could approve that for Xena? | 17:35 |
rosmaita | jokke_: sure | 17:37 |
jokke_ | rosmaita: cheers, will ping you once chekc has passed | 17:37 |
rosmaita | sounds good | 17:38 |
opendevreview | Merged openstack/glance master: Bump oslo.policy to version 3.8.1 https://review.opendev.org/c/openstack/glance/+/810275 | 18:43 |
opendevreview | Erno Kuvaja proposed openstack/glance stable/xena: Bump oslo.policy to version 3.8.1 https://review.opendev.org/c/openstack/glance/+/810307 | 18:46 |
jokke_ | rosmaita: we got green light from Zuul so if you wanna do the honours, that'd be great | 19:11 |
rosmaita | ok | 19:18 |
rosmaita | jokke_: done | 19:19 |
jokke_ | tyty, have a good one | 19:20 |
rosmaita | cheers | 19:20 |
opendevreview | Lance Bragstad proposed openstack/glance master: Use single quotes in image policies https://review.opendev.org/c/openstack/glance/+/810319 | 20:58 |
lbragstad | ^ relatively easy review that fixes generating sample policy files | 20:59 |
opendevreview | Merged openstack/glance stable/xena: Bump oslo.policy to version 3.8.1 https://review.opendev.org/c/openstack/glance/+/810307 | 21:47 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!