| *** bhagyashris is now known as bhagyashris|rover | 04:08 | |
| opendevreview | Lance Bragstad proposed openstack/glance master: Use single quotes in image policies https://review.opendev.org/c/openstack/glance/+/810319 | 12:58 |
|---|---|---|
| opendevreview | Lance Bragstad proposed openstack/glance master: Use single quotes in image policies https://review.opendev.org/c/openstack/glance/+/810319 | 13:00 |
| croelandt | no meeting today? | 14:04 |
| jokke_ | croelandt: nope, Abhishek sent cancel mail last week iirc | 14:05 |
| Luzi | ah... my luck... | 14:07 |
| croelandt | oh indeed | 14:08 |
| jokke_ | Luzi: what's up? | 14:10 |
| jokke_ | Things finally moving forward? | 14:10 |
| Luzi | yeah i edited the spec-lite, but got ill afterwards. | 14:12 |
| Luzi | even though things are moving forward in barbican i think its better to keep moving with an experimental feature | 14:12 |
| Luzi | well see / hear you at the ptg | 14:14 |
| jokke_ | sure | 14:17 |
| dansmith | croelandt: maybe you could hit this? https://review.opendev.org/c/openstack/glance-tempest-plugin/+/800902/29 | 17:09 |
| dansmith | croelandt: +1 from lbragstad and abhi (as co-author) so .. should be pretty safe, and just tests :) | 17:09 |
| croelandt | let me check | 17:51 |
| croelandt | the tempest_test_regex is fun | 17:55 |
| croelandt | v2..*.Project | 17:55 |
| croelandt | Are the dots literal dots or "anything"? | 17:55 |
| croelandt | this looks weird that no one of them has to be escaped to be treated literally | 17:55 |
| croelandt | oh I missed "We can fix the nits pointed out by me in follow up patch, or in next dependent patch (i.e. metadef objects patch)" | 18:23 |
| croelandt | dansmith: how urgent is this? | 18:23 |
| croelandt | Can't we push one new revision rather than using a followup patch? | 18:23 |
| dansmith | croelandt: we ca, but we've been jerking pranali around a lot, | 18:34 |
| dansmith | note she has a bunch of patches on top that she hasn't rebased because we've been back and forth on stuff | 18:34 |
| dansmith | everything I see on there is all nits, so I just hate to make her go another round | 18:34 |
| dansmith | abhi is out (maybe back tomorrow?) I'm out on monday, and pranali has been more than patient with us | 18:34 |
| dansmith | I also really don't get the pythonic argument for that return value | 18:36 |
| dansmith | I don't know of any real pythonic argument against using a temporary variable, so I think that's just a style/preference nit too :) | 18:37 |
| croelandt | it's not just the variable | 18:42 |
| croelandt | just it's really weird to build a dict value by value | 18:42 |
| croelandt | but OK I see your point | 18:42 |
| dansmith | is it? | 18:43 |
| croelandt | I don't think I ever see t his pattern :D | 18:43 |
| dansmith | mmmmkay :) | 18:44 |
| croelandt | so I +2/+1ed | 18:45 |
| opendevreview | Merged openstack/glance-tempest-plugin master: Add protection testing for metadef namespaces https://review.opendev.org/c/openstack/glance-tempest-plugin/+/800902 | 19:22 |
| rosmaita | jokke_: dansmith: croelandt: looks like something failed when python-glanceclient stable/xena was cut and the releasenotes didn't get published | 21:14 |
| rosmaita | unless i'm missing something: https://docs.openstack.org/releasenotes/python-glanceclient/index.html | 21:14 |
| rosmaita | xena notes build locally | 21:15 |
| rosmaita | anyway, one of you may want to -1 https://review.opendev.org/c/openstack/releases/+/810236 and point out that python-glanceclient is missing | 21:16 |
| rosmaita | (i used up my vote saying that the cinder stuff is OK) | 21:17 |
| dansmith | rosmaita: are we sure that wasn't broken befopre? | 21:19 |
| rosmaita | ummm ... pretty sure? it's got wallaby | 21:19 |
| rosmaita | also, that big patch is missing an update for glance_store | 21:19 |
| dansmith | aactually, | 21:19 |
| dansmith | it's missing a glanceclient no? | 21:20 |
| rosmaita | https://docs.openstack.org/releasenotes/glance_store/xena.html | 21:20 |
| rosmaita | yeah, so 2 problems: | 21:20 |
| rosmaita | 1) this file should have the releasenotes link added: https://review.opendev.org/c/openstack/releases/+/810236/1/deliverables/xena/glance-store.yaml | 21:21 |
| rosmaita | 2) python-glanceclient should have the release notes link added too, but the target of that URL doesn't exist | 21:21 |
| rosmaita | https://docs.openstack.org/releasenotes/python-glanceclient/xena.html gives me a 404 | 21:22 |
| dansmith | yeah commented about the two missing deliverables | 21:22 |
| rosmaita | ok, cool | 21:22 |
| dansmith | hmm, not sure there was a glanceclient release? looking at the history there | 21:23 |
| rosmaita | yeah, there was | 21:23 |
| dansmith | okay i don't see the patch in gerrit | 21:23 |
| rosmaita | https://review.opendev.org/c/openstack/releases/+/810236/1/deliverables/xena/python-glanceclient.yaml | 21:24 |
| rosmaita | you can see the stable/xena branch cut at 3.5.0 | 21:24 |
| dansmith | maybe too old to be on the first page here | 21:24 |
| dansmith | yeah, I see it in the releases repo | 21:24 |
| dansmith | reno is in the tree, and xena is in the index | 21:25 |
| rosmaita | yeah, and the releasenotes build fine locally | 21:25 |
| rosmaita | probably the job that updates the website timed out or something and it never got published | 21:26 |
| dansmith | builds and builds a xena html? | 21:26 |
| * dansmith is trying | 21:26 | |
| dansmith | fails for me: ValueError: Unknown reference 'stable/wallaby' | 21:26 |
| rosmaita | weird | 21:27 |
| dansmith | but surely that should have shown up somewhere if it was really failing | 21:28 |
| rosmaita | yeah, this is what i got locally: https://paste.opendev.org/show/809545/ | 21:29 |
| dansmith | mine fails at L81 | 21:29 |
| rosmaita | i wonder if your releasenotes venv is stale | 21:30 |
| dansmith | built fresh, but let me nuke and try again | 21:30 |
| dansmith | same | 21:31 |
| dansmith | but it never gets far enough to build anything, so it must be different I think, since the wallaby and older things are there on the public site | 21:31 |
| rosmaita | well that sucks ... i'm out of ideas | 21:32 |
| dansmith | yeah I dunno enough about how this works, | 21:32 |
| dansmith | so I would think just waiting until tomorrow when herve can look makes the most sense, no? | 21:32 |
| rosmaita | i think leaving the -1 was sufficient, pretty sure there | 21:32 |
| dansmith | yeah | 21:32 |
| rosmaita | 's nothing we can do from the glance side | 21:32 |
| dansmith | yeah | 21:33 |
| rosmaita | anyway, i would have dropped the -1, but i didn't want the release team to get confused and think there was a cinder problem | 21:33 |
| dansmith | I put another note on the release note links patch about them being missing there, so we'll see I guess | 21:33 |
| dansmith | yep, no prob | 21:33 |
| rosmaita | cool, have a good evening! | 21:34 |
| dansmith | you as well, thanks for the heads up | 21:34 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!