| opendevreview | Takashi Kajinami proposed openstack/glance master: Remove osprofiler parameters from api-paste.ini https://review.opendev.org/c/openstack/glance/+/789095 | 13:18 |
|---|---|---|
| opendevreview | Mridula Joshi proposed openstack/glance master: Added a new API to expose store info https://review.opendev.org/c/openstack/glance/+/824438 | 14:38 |
| opendevreview | Mridula Joshi proposed openstack/python-glanceclient master: Add an optional parameter --detail https://review.opendev.org/c/openstack/python-glanceclient/+/824444 | 14:40 |
| opendevreview | Mridula Joshi proposed openstack/python-glanceclient master: Add an optional parameter --append https://review.opendev.org/c/openstack/python-glanceclient/+/813591 | 14:43 |
| abhishekk | jokke_, around? | 16:02 |
| abhishekk | https://review.opendev.org/c/openstack/glance/+/800957 | 16:25 |
| abhishekk | jokke_, rosmaita, dansmith, croelandt this is the patch I am talking about | 16:25 |
| abhishekk | glance-code-constants-check this is the job | 16:32 |
| abhishekk | If I change the version then the above job will fail | 16:40 |
| opendevreview | Abhishek Kekane proposed openstack/glance master: Cache management API endpoints https://review.opendev.org/c/openstack/glance/+/792022 | 16:50 |
| rosmaita | abhishekk: you mean that when you have CURRENT_RELEASE = 'yoga' in glance/db/migration.py, the test fails? Try creating a 21.0.0.0b1 tag in your local repo and see if the test passes | 16:58 |
| abhishekk | ack | 16:58 |
| rosmaita | i think the order of events has to be: cut M-1 release, (test starts failing), update migration.py | 16:59 |
| rosmaita | not sure exactly how pbr determines the version, though | 16:59 |
| abhishekk | https://paste.opendev.org/show/812493/ | 17:00 |
| abhishekk | this is what I see after changing the CURRENT_RELEASE = 'yoga' | 17:01 |
| abhishekk | I will try by creating the tag | 17:01 |
| rosmaita | i am an idiot, the tag should be 24.0.0.0b1 | 17:01 |
| abhishekk | yeah | 17:02 |
| abhishekk | yeah for the tag part :D | 17:02 |
| rosmaita | well, maybe also for writing that test in the first place | 17:02 |
| abhishekk | creating tag locally also does not help | 17:03 |
| abhishekk | there is glance.egg-info/PKG-INFO which has glance version | 17:11 |
| abhishekk | If I change it to 24.0.---then the test will pass | 17:11 |
| abhishekk | I think its totally related to release | 17:11 |
| rosmaita | abhishekk: i wonder what would happen if you hack glance.egg-info/PKG-INFO | 17:12 |
| rosmaita | third line is Version: | 17:12 |
| abhishekk | yeah | 17:12 |
| abhishekk | I think the info here comes from setup.cfg | 17:14 |
| rosmaita | i didn't see any version info in there, though | 17:15 |
| abhishekk | that will be added when glance is installed as a package using setup.py | 17:15 |
| abhishekk | python3 setup.py --version this will fetch you the current version | 17:26 |
| rosmaita | abhishekk: try doing this before running the test: | 17:34 |
| rosmaita | export PBR_VERSION='24.0.0.0b1' | 17:34 |
| abhishekk | ack | 17:36 |
| abhishekk | no luck | 17:36 |
| rosmaita | dang | 17:37 |
| abhishekk | will try to dig further tomorrow | 17:38 |
| dansmith | abhishekk: I'm not seeing any of the messages in the logs that I would expect if the caching is working.. am I missing something? | 17:38 |
| dansmith | I see images cached as a result of uploads and stuff, but not as a result of queuing | 17:39 |
| abhishekk | you mean to say in this patch, https://review.opendev.org/c/openstack/glance/+/825115 | 17:39 |
| abhishekk | dansmith, 2022-01-31 11:10:32.671020 | controller | {3} tempest.api.image.v2.admin.test_image_caching.ImageCachingTest.test_image_caching_cycle [32.291451s] ... ok | 17:41 |
| dansmith | abhishekk: that says the test ran, yeah | 17:41 |
| dansmith | I mean g-api logs | 17:41 |
| abhishekk | have you checked g-api-r logs ? | 17:41 |
| dansmith | are you hitting g-api-r? | 17:42 |
| abhishekk | I am caching everything on g-api-r | 17:42 |
| dansmith | ahh | 17:42 |
| abhishekk | yeah | 17:42 |
| dansmith | "glance.image_cache.prefetcher [-] Found 1 images to prefetch " | 17:42 |
| dansmith | sweet :) | 17:42 |
| abhishekk | the reason is when I am trying to hit clear API which deletes all cached images I don't want to have any regression on tests using g-api | 17:42 |
| abhishekk | \o/ | 17:43 |
| dansmith | yeah, so.. maybe we should set the periodic timer for g-api-r very low | 17:44 |
| dansmith | which won't affect other things, but will cause that to run the prefetcher very often to lower the wait times | 17:44 |
| abhishekk | agree, that is why I kept it as DNM to decide on timing | 17:44 |
| abhishekk | any ideal time you have in mind? | 17:45 |
| dansmith | just looking for where that's set | 17:45 |
| dansmith | if we use a non-overlapping timer, then I'd say every ten seconds or so | 17:46 |
| abhishekk | https://review.opendev.org/c/openstack/glance/+/825115/3/.zuul.yaml | 17:46 |
| dansmith | I mean in the code | 17:46 |
| abhishekk | ah | 17:46 |
| dansmith | in wsgi I see | 17:47 |
| dansmith | yeah, I'd try setting that to 10s | 17:47 |
| dansmith | but in the -r config | 17:48 |
| dansmith | I guess it doesn't matter that much to set it for both, but it will make a lot of noise in the main one with all the lock verbosity | 17:49 |
| abhishekk | to set it only for -r config we need to change devstack | 17:49 |
| abhishekk | * I think | 17:50 |
| dansmith | yeah, I'll do it | 17:50 |
| abhishekk | cool, thank you | 17:52 |
| abhishekk | unless I don't need to be here, I will sign out now | 17:53 |
| dansmith | o/ | 17:56 |
| abhishekk | o/~ | 17:57 |
| opendevreview | Dan Smith proposed openstack/glance master: DNM: Test override g-api-r cache interval https://review.opendev.org/c/openstack/glance/+/827538 | 18:04 |
| opendevreview | Dan Smith proposed openstack/glance master: DNM: Test override g-api-r cache interval https://review.opendev.org/c/openstack/glance/+/827538 | 19:23 |
| opendevreview | Dan Smith proposed openstack/glance master: DNM: Test override g-api-r cache interval https://review.opendev.org/c/openstack/glance/+/827538 | 20:34 |
| *** timburke_ is now known as timburke | 20:57 | |
| opendevreview | Dan Smith proposed openstack/glance master: DNM: Test override g-api-r cache interval https://review.opendev.org/c/openstack/glance/+/827538 | 21:27 |
| opendevreview | Merged openstack/glance master: Remove six.text_type, six.binary_type usage https://review.opendev.org/c/openstack/glance/+/822733 | 21:55 |
| opendevreview | Merged openstack/glance master: Replace six.BytesIO, six.StringIO usage https://review.opendev.org/c/openstack/glance/+/822734 | 21:55 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!