| *** akekane_ is now known as abhishekk | 06:02 | |
| opendevreview | Abhishek Kekane proposed openstack/python-glanceclient master: Release notes for 3.6.0 https://review.opendev.org/c/openstack/python-glanceclient/+/829653 | 07:21 |
|---|---|---|
| abhishekk | rosmaita, jokke_, dansmith, croelandt, pdeore, weekly meeting in 5 minutes at #openstack-meeting | 13:54 |
| rosmaita | abhishekk: ty | 13:55 |
| abhishekk | np :d | 13:55 |
| abhishekk | that was fast :D | 14:12 |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store stable/xena: Cinder store: Wait for device resize https://review.opendev.org/c/openstack/glance_store/+/829705 | 15:06 |
| opendevreview | Merged openstack/glance-specs master: Add Zed direcotry for specs https://review.opendev.org/c/openstack/glance-specs/+/829157 | 15:14 |
| opendevreview | Merged openstack/glance master: Fix overwriting of existing tags while creating new tags https://review.opendev.org/c/openstack/glance/+/804966 | 16:01 |
| abhishekk | dansmith, by chance if you have spare time will you please have a look at https://review.opendev.org/c/openstack/python-glanceclient/+/800172 | 17:29 |
| dansmith | abhishekk: oh I looked at that the other day and thought you still had comments to address, but I guess you did weeks before and just marked them as done on tues? | 17:30 |
| abhishekk | I guess yeah | 17:31 |
| dansmith | ack, sorry | 17:35 |
| abhishekk | no problem | 17:37 |
| abhishekk | delay was from my side :D | 17:39 |
| dansmith | abhishekk: so, the double table dump | 17:42 |
| dansmith | are there any other examples of that in glanceclient? | 17:42 |
| abhishekk | no, this is the first one | 17:43 |
| dansmith | IMHO, it would be better to dump one table with the queued values just empty or N/A and a state column | 17:43 |
| dansmith | i.e. make it look like one set of data | 17:43 |
| dansmith | the fact that it's two lists is an implementation detail and not likely what they want to see right? | 17:44 |
| dansmith | I just don't like seeing two different size/format tables in one dump I guess | 17:45 |
| abhishekk | hmm | 17:45 |
| dansmith | if you prefer this it's cool, just thought I'd bring it up.. people will start scraping the output when you settle on one, so.. ;) | 17:45 |
| abhishekk | So basically I need to add one more column to the output if we combined it into one | 17:46 |
| abhishekk | i.e. state 'cached' and 'queued' for queued for caching | 17:46 |
| dansmith | yeah | 17:47 |
| dansmith | I mean, you could also infer cache/queue based on the fact that the other columns are missing, but a new state column would be nice too | 17:47 |
| abhishekk | OK, add your suggestion there, I will rework it tomorrow and push it | 17:47 |
| abhishekk | I think 'state' will be nice to have | 17:48 |
| dansmith | I have a couple other comments, so yeah I will | 17:49 |
| abhishekk | ack, sounds good, thank you | 17:49 |
| abhishekk | will do it now, tomorrow is recharge day :D | 17:50 |
| dansmith | ah | 17:50 |
| dansmith | no big rush right? we could do/merge this monday | 17:51 |
| abhishekk | yeah, we have two weeks for client release | 17:51 |
| abhishekk | so will do it on Monday :D | 17:51 |
| dansmith | cool, bug me until I review when it's ready :) | 17:53 |
| abhishekk | sure, thank you :D | 17:53 |
| dansmith | have a good recharge | 17:57 |
| abhishekk | same to you o/ | 17:57 |
| opendevreview | Merged openstack/glance_store stable/xena: Cinder store: Wait for device resize https://review.opendev.org/c/openstack/glance_store/+/829705 | 18:16 |
| opendevreview | Rajat Dhasmana proposed openstack/glance_store stable/wallaby: Cinder store: Wait for device resize https://review.opendev.org/c/openstack/glance_store/+/829771 | 18:31 |
| whoami-rajat | rosmaita, abhishekk ^^ backport for wallaby, please review whenever you get time | 18:32 |
| rosmaita | ack | 18:33 |
| abhishekk | whoami-rajat, ack | 18:33 |
| whoami-rajat | thank you both! | 18:33 |
| abhishekk | there was no merged conflict this time as well, right | 18:34 |
| abhishekk | ? | 18:34 |
| whoami-rajat | yes | 18:39 |
| whoami-rajat | no merge conflict | 18:39 |
| abhishekk | yep, confirmed locally :d | 18:39 |
| whoami-rajat | :D | 18:50 |
| opendevreview | Merged openstack/python-glanceclient master: Add an optional parameter --append https://review.opendev.org/c/openstack/python-glanceclient/+/813591 | 18:51 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!