abhishekk | croelandt, if you around and have time, please have a look https://review.opendev.org/c/openstack/python-glanceclient/+/800172 | 07:42 |
---|---|---|
croelandt | ok, I'm very confused | 16:27 |
croelandt | https://review.opendev.org/c/openstack/python-glanceclient/+/800172 | 16:27 |
croelandt | does line 204 do something, or could it be "pass"? | 16:28 |
opendevreview | Abhishek Kekane proposed openstack/python-glanceclient master: Add support for Cache API https://review.opendev.org/c/openstack/python-glanceclient/+/800172 | 16:45 |
abhishekk | croelandt, your concern is addressed ^^, thank you | 16:45 |
croelandt | :D | 16:46 |
croelandt | let me check | 16:46 |
croelandt | ok, +2ed | 16:46 |
abhishekk | thank you | 16:46 |
abhishekk | rosmaita, once you are good,can you have a look at release notes patch, | 16:50 |
abhishekk | https://review.opendev.org/c/openstack/python-glanceclient/+/829653 | 16:50 |
rosmaita | abhishekk: ack | 16:50 |
abhishekk | It is rendering correctly as well | 16:50 |
abhishekk | dansmith, sorry to ask you to have one more final look on client patch | 16:59 |
abhishekk | just proposed a revision on it | 16:59 |
* abhishekk hides | 16:59 | |
dansmith | ah yeah, good catch croelandt | 17:03 |
rosmaita | abhishekk: left some notes on your release note patch | 17:51 |
abhishekk | rosmaita, ack,thank you | 17:52 |
rosmaita | np | 17:52 |
opendevreview | Abhishek Kekane proposed openstack/python-glanceclient master: Release notes for 3.6.0 https://review.opendev.org/c/openstack/python-glanceclient/+/829653 | 18:16 |
opendevreview | Merged openstack/python-glanceclient master: Add support for Cache API https://review.opendev.org/c/openstack/python-glanceclient/+/800172 | 19:56 |
opendevreview | Abhishek Kekane proposed openstack/python-glanceclient master: Release notes for 3.6.0 https://review.opendev.org/c/openstack/python-glanceclient/+/829653 | 20:49 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!