| bhagyashris | Dakshita hey sure. Here you will get the info related to how to contribute https://wiki.openstack.org/wiki/How_To_Contribute | 06:23 |
|---|---|---|
| -opendevstatus- NOTICE: zuul isn't executing check jobs at the moment, investigation is ongoing, please be patient | 07:18 | |
| ShivaniSangwan | Hey everyone! This side Shivani Sangwan, I was exploring the organisations and projects for the Outreachy program, I found the project 'Add mypy support in OpenStack glance' quite interesting. I have good experience with Python, git, ML and DL and believe would be able to give my best to the project. I wanted to start by working on the tasks/issues | 09:13 |
| ShivaniSangwan | so I could gain knowledge of the codebase, kindly suggest what starter issues should I pick. | 09:13 |
| georgia | Hi this is Georgia and I am more than excited to apply for the Outreachy program and contribute to the Glance API in Openstack Client. Nice to e-meeting you here @croelandt! Is there any indicator at the issues, which are the more appropriate to start with? | 11:55 |
| georgia | At the Project Contribution Information is stated the following, but the tagging is not very clear to me: "Applicants can look for newcomer-friendly issues to use for their first contributions by looking for the following issue tags in the project issue tracker: Intern's Name" | 11:56 |
| croelandt | georgiats: Hello! I believe being able to run unit tests on glance, glanceclient and glance_store would be a good start. Then running https://docs.openstack.org/devstack/latest/ in a VM would be pretty nice! | 13:47 |
| georgiats | Thanks for the info croelandt! I'll try that out and let you know if I have any further questions. Talk to you soon. | 13:51 |
| croelandt | jokke_: Hey! https://review.opendev.org/c/openstack/glance/+/828239 Does this look suitable for stable/wallaby? | 13:55 |
| opendevreview | Tobias Urdin proposed openstack/glance master: Add default image properties support https://review.opendev.org/c/openstack/glance/+/835462 | 14:12 |
| jokke_ | croelandt: let me see | 16:54 |
| opendevreview | Tobias Urdin proposed openstack/glance master: Add default image properties support https://review.opendev.org/c/openstack/glance/+/835462 | 17:23 |
| croelandt | jokke_: it's kind of needed by our downstream CI | 17:52 |
| croelandt | I could cherry-pick it as well, but if it's good enough for stable/wallaby, might as well merge it there | 17:53 |
| jokke_ | croelandt: yeah, need to double check as it's test only, but it also is new dependency | 18:02 |
| jokke_ | croelandt: so the commit message says that those new dependencies are needed for centos, but the python3-devel is applied only to debian/ubuntu and the two others are applied all rpm envs (including suse) ... I think they should be all just 'redhat' for Fedora, Centos and RHEL | 18:08 |
| croelandt | jokke_: they are actually not new dependencies; more like "dependencies we forgot to mention" | 18:24 |
| croelandt | jokke_: we did merge the patch as-is in master and stable/victoria if I'm not mistaken | 18:24 |
| jokke_ | croelandt: I saw it in master and based on the bug and commit message that is wrong too | 18:33 |
| croelandt | so you'd like to fix it in master? | 18:33 |
| croelandt | I think the code is actually ok, but the commit message is buggy | 18:33 |
| jokke_ | but that's what I'm saying they are new dependencies, the fact that redhat does not work without them, is why we can introduce them to redhat platform but as far as the documented behaviour goes, there is no reason for the dpkg and rpm platforms, unless someone points out that they are needed for SuSe too | 18:34 |
| jokke_ | but the dpkg dependency is definitely not needed as the ubuntu based gate works just fine | 18:35 |
| jokke_ | like, sorry but you got it wrong on the master review ;) | 18:36 |
| croelandt | oh I see what you mean | 18:38 |
| croelandt | yeah so on a fresh Ubuntu 20.04 Ineeded python3-devel | 18:40 |
| croelandt | otherwise tox -epy38 would fail because some dependency had to be compiled and required Python.h | 18:41 |
| jokke_ | so did you run the bindep first? Cause it might be pulled as dependency on some other bindep we have? I just wonder cause our gate works. | 18:42 |
| jokke_ | Either way that has nothing to do with the tests failing in centos | 18:42 |
| croelandt | Not sure what I did exactly, that was a long time ago :) | 18:44 |
| croelandt | ok, so not merging this upstream, I guess | 18:44 |
| jokke_ | croelandt: lets check this with Abhishek tomorrow during his hours how he would prefer to solve it. I think it's good to fix things that actually does not work, but target them to correct platform. So IMO best would be to revert the original, patch qemu-img and python3-devel on 'redhat' or 'rpm' depending if SuSe is needed | 18:46 |
| jokke_ | and just minimize the dependency change affecting as small surface as possible for backporting reasons | 18:47 |
| croelandt | makes sense | 18:48 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!